joshpatra/allstarr
1
0
Fork 0
mirror of https://github.com/SoPat712/allstarr.git synced 2026-02-10 07:58:39 -05:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix external mapping deserialization and suppress cache MISS logs

Browse Source 
- Fixed RuntimeBinderException when processing external mappings by replacing dynamic with JsonDocument parsing
- Suppressed cache MISS logs for manual/external mappings (they're expected to be missing most of the time)
- Only log manual/external mapping HITs at INFO level, other cache operations at DEBUG level
- Applied fix to SpotifyTrackMatchingService (2 locations) and AdminController (2 locations)
This commit is contained in:
Josh Patra
2026-02-05 09:57:07 -05:00
parent 7cb722c396
commit 2e1577eb5a
3 changed files with 77 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
allstarr/Controllers/AdminController.cs
View File

@@ -531,14 +531,27 @@ public class AdminController : ControllerBase
{
// Check for external manual mapping
var externalMappingKey = $"spotify:external-map:{decodedName}:{track.SpotifyId}";
var externalMapping = await _cache.GetAsync<dynamic>(externalMappingKey);
var externalMappingJson = await _cache.GetStringAsync(externalMappingKey);
if (HasValue(externalMapping))
if (!string.IsNullOrEmpty(externalMappingJson))
{
try
{
var provider = externalMapping?.provider?.ToString();
var externalId = externalMapping?.id?.ToString();
using var doc = JsonDocument.Parse(externalMappingJson);
var root = doc.RootElement;
string? provider = null;
string? externalId = null;
if (root.TryGetProperty("provider", out var providerEl))
{
provider = providerEl.GetString();
}
if (root.TryGetProperty("id", out var idEl))
{
externalId = idEl.GetString();
}
if (!string.IsNullOrEmpty(provider) && !string.IsNullOrEmpty(externalId))
{
@@ -546,7 +559,7 @@ public class AdminController : ControllerBase
isLocal = false;
externalProvider = provider;
_logger.LogDebug("✓ Manual external mapping found for {Title}: {Provider} {ExternalId}",
track.Title, (object?)provider, (object?)externalId);
track.Title, provider, externalId);
}
}
catch (Exception ex)
@@ -655,13 +668,22 @@ public class AdminController : ControllerBase
{
// Check for external manual mapping
var externalMappingKey = $"spotify:external-map:{decodedName}:{track.SpotifyId}";
var externalMapping = await _cache.GetAsync<dynamic>(externalMappingKey);
var externalMappingJson = await _cache.GetStringAsync(externalMappingKey);
if (HasValue(externalMapping))
if (!string.IsNullOrEmpty(externalMappingJson))
{
try
{
var provider = externalMapping?.provider?.ToString();
using var doc = JsonDocument.Parse(externalMappingJson);
var root = doc.RootElement;
string? provider = null;
if (root.TryGetProperty("provider", out var providerEl))
{
provider = providerEl.GetString();
}
if (!string.IsNullOrEmpty(provider))
{
isLocal = false;