joshpatra/allstarr
1
0
Fork 0
mirror of https://github.com/SoPat712/allstarr.git synced 2026-02-10 07:58:39 -05:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

refactor: optimize playlist interception order

Browse Source 
- Check external playlists first (fast check)
- Only check Spotify if enabled (avoid extra API call)
- Fall back to regular Jellyfin playlists
- Maintains correct behavior for all playlist types
This commit is contained in:
Josh Patra
2026-01-31 16:54:39 -05:00
parent c117fa41f6
commit 4ba2245876
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
allstarr/Controllers/JellyfinController.cs
View File

@@ -1257,8 +1257,16 @@ public class JellyfinController : ControllerBase
{ {
try try
{ {
// Check if this is a Spotify playlist by fetching playlist info first // Check if this is an external playlist (Deezer/Qobuz) first
if (_spotifySettings.Enabled && !playlistId.StartsWith("ext-") && !playlistId.StartsWith("playlist-")) if (PlaylistIdHelper.IsExternalPlaylist(playlistId))
{
var (provider, externalId) = PlaylistIdHelper.ParsePlaylistId(playlistId);
var tracks = await _metadataService.GetPlaylistTracksAsync(provider, externalId);
return _responseBuilder.CreateItemsResponse(tracks);
}
// Only check for Spotify playlists if the feature is enabled
if (_spotifySettings.Enabled && !playlistId.StartsWith("ext-"))
{ {
// Get playlist info from Jellyfin to check the name // Get playlist info from Jellyfin to check the name
var playlistInfo = await _proxyService.GetJsonAsync($"Items/{playlistId}", null, Request.Headers); var playlistInfo = await _proxyService.GetJsonAsync($"Items/{playlistId}", null, Request.Headers);
@@ -1278,14 +1286,6 @@ public class JellyfinController : ControllerBase
} }
} }
// Check if this is an external playlist (Deezer/Qobuz)
if (PlaylistIdHelper.IsExternalPlaylist(playlistId))
{
var (provider, externalId) = PlaylistIdHelper.ParsePlaylistId(playlistId);
var tracks = await _metadataService.GetPlaylistTracksAsync(provider, externalId);
return _responseBuilder.CreateItemsResponse(tracks);
}
// Regular Jellyfin playlist - proxy through // Regular Jellyfin playlist - proxy through
var endpoint = $"Playlists/{playlistId}/Items"; var endpoint = $"Playlists/{playlistId}/Items";
if (Request.QueryString.HasValue) if (Request.QueryString.HasValue)