From 6620b39357d7717f0e7d0ebf88bfd0a49a9cbf11 Mon Sep 17 00:00:00 2001
From: Josh Patra <joshpatra12@gmail.com>
Date: Sat, 31 Jan 2026 01:00:00 -0500
Subject: [PATCH] fix: remove score filtering, add combined title+artist
 matching

---
 allstarr/Controllers/JellyfinController.cs | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/allstarr/Controllers/JellyfinController.cs b/allstarr/Controllers/JellyfinController.cs
index 5d7cecf..46c68b0 100644
--- a/allstarr/Controllers/JellyfinController.cs
+++ b/allstarr/Controllers/JellyfinController.cs
@@ -178,22 +178,19 @@ public class JellyfinController : ControllerBase
         var scoredExternalAlbums = ScoreSearchResults(cleanQuery, externalResult.Albums, a => a.Title, a => a.Artist, isExternal: true);
         var scoredExternalArtists = ScoreSearchResults(cleanQuery, externalResult.Artists, a => a.Name, _ => null, isExternal: true);
 
-        // Merge and sort by score (only include items with score >= 40)
+        // Merge and sort by score (no filtering - just reorder by relevance)
         var allSongs = scoredLocalSongs.Concat(scoredExternalSongs)
-            .Where(x => x.Score >= 40)
             .OrderByDescending(x => x.Score)
             .Select(x => x.Item)
             .ToList();
 
         var allAlbums = scoredLocalAlbums.Concat(scoredExternalAlbums)
-            .Where(x => x.Score >= 40)
             .OrderByDescending(x => x.Score)
             .Select(x => x.Item)
             .ToList();
 
         // Dedupe artists by name, keeping highest scored version
         var artistScores = scoredLocalArtists.Concat(scoredExternalArtists)
-            .Where(x => x.Score >= 40)
             .GroupBy(x => x.Item.Name, StringComparer.OrdinalIgnoreCase)
             .Select(g => g.OrderByDescending(x => x.Score).First())
             .OrderByDescending(x => x.Score)
@@ -210,7 +207,6 @@ public class JellyfinController : ControllerBase
         {
             var scoredPlaylists = playlistResult
                 .Select(p => new { Playlist = p, Score = FuzzyMatcher.CalculateSimilarity(cleanQuery, p.Name) })
-                .Where(x => x.Score >= 40)
                 .OrderByDescending(x => x.Score)
                 .Select(x => _responseBuilder.ConvertPlaylistToJellyfinItem(x.Playlist))
                 .ToList();
@@ -1795,11 +1791,21 @@ public class JellyfinController : ControllerBase
                 ? 0 
                 : FuzzyMatcher.CalculateSimilarity(query, secondary);
 
-            // Use the better of the two scores
-            var baseScore = Math.Max(primaryScore, secondaryScore);
+            // Score against combined "title artist" and "artist title" for queries like "say why zach bryan"
+            var combinedScore = 0;
+            if (!string.IsNullOrEmpty(secondary))
+            {
+                var combined1 = $"{primary} {secondary}";
+                var combined2 = $"{secondary} {primary}";
+                var score1 = FuzzyMatcher.CalculateSimilarity(query, combined1);
+                var score2 = FuzzyMatcher.CalculateSimilarity(query, combined2);
+                combinedScore = Math.Max(score1, score2);
+            }
+
+            // Use the best score from all attempts
+            var baseScore = Math.Max(Math.Max(primaryScore, secondaryScore), combinedScore);
 
             // Give external results a small boost (+5 points) to prioritize the larger catalog
-            // This means external results will rank slightly higher when scores are close
             var finalScore = isExternal ? Math.Min(100, baseScore + 5) : baseScore;
 
             return (item, finalScore);