joshpatra/allstarr
1
0
Fork 0
mirror of https://github.com/SoPat712/allstarr.git synced 2026-02-09 23:55:10 -05:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix HasValue method to handle JsonElement properly

Browse Source 
- Changed parameter type from dynamic? to object? to avoid runtime binding issues
- Added check for JsonValueKind.Undefined in addition to Null
- Fixes crash when checking external mappings that return JsonElement
- Applied fix to both AdminController and SpotifyTrackMatchingService
This commit is contained in:
Josh Patra
2026-02-05 09:40:39 -05:00
parent 9dcaddb2db
commit 7cb722c396
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
allstarr/Controllers/AdminController.cs
View File

@@ -86,10 +86,10 @@ public class AdminController : ControllerBase
/// Helper method to safely check if a dynamic cache result has a value /// Helper method to safely check if a dynamic cache result has a value
/// Handles the case where JsonElement cannot be compared to null directly /// Handles the case where JsonElement cannot be compared to null directly
/// </summary> /// </summary>
private static bool HasValue(dynamic? obj) private static bool HasValue(object? obj)
{ {
if (obj == null) return false; if (obj == null) return false;
if (obj is JsonElement jsonEl) return jsonEl.ValueKind != JsonValueKind.Null; if (obj is JsonElement jsonEl) return jsonEl.ValueKind != JsonValueKind.Null && jsonEl.ValueKind != JsonValueKind.Undefined;
return true; return true;
} }

4
allstarr/Services/Spotify/SpotifyTrackMatchingService.cs
View File

@@ -48,10 +48,10 @@ public class SpotifyTrackMatchingService : BackgroundService
/// Helper method to safely check if a dynamic cache result has a value /// Helper method to safely check if a dynamic cache result has a value
/// Handles the case where JsonElement cannot be compared to null directly /// Handles the case where JsonElement cannot be compared to null directly
/// </summary> /// </summary>
private static bool HasValue(dynamic? obj) private static bool HasValue(object? obj)
{ {
if (obj == null) return false; if (obj == null) return false;
if (obj is JsonElement jsonEl) return jsonEl.ValueKind != JsonValueKind.Null; if (obj is JsonElement jsonEl) return jsonEl.ValueKind != JsonValueKind.Null && jsonEl.ValueKind != JsonValueKind.Undefined;
return true; return true;
} }