joshpatra/allstarr
1
0
Fork 0
mirror of https://github.com/SoPat712/allstarr.git synced 2026-02-09 23:55:10 -05:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix LyricsStartupValidator build errors

Browse Source 
- Remove duplicate _httpClient field (use inherited one)
- Replace ValidationResult.Warning with ValidationResult.Failure
- Use PARTIAL status for partial failures
This commit is contained in:
Josh Patra
2026-02-06 01:54:32 -05:00
parent f103dac6c8
commit 8a3abdcbf7
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
allstarr/Services/Lyrics/LyricsStartupValidator.cs
View File

@@ -12,7 +12,6 @@ namespace allstarr.Services.Lyrics;
public class LyricsStartupValidator : BaseStartupValidator public class LyricsStartupValidator : BaseStartupValidator
{ {
private readonly SpotifyApiSettings _spotifySettings; private readonly SpotifyApiSettings _spotifySettings;
private readonly HttpClient _httpClient;
// Test song: "22" by Taylor Swift // Test song: "22" by Taylor Swift
private const string TestSongTitle = "22"; private const string TestSongTitle = "22";
@@ -29,7 +28,6 @@ public class LyricsStartupValidator : BaseStartupValidator
: base(httpClientFactory.CreateClient()) : base(httpClientFactory.CreateClient())
{ {
_spotifySettings = spotifySettings.Value; _spotifySettings = spotifySettings.Value;
_httpClient = httpClientFactory.CreateClient();
_httpClient.Timeout = TimeSpan.FromSeconds(10); _httpClient.Timeout = TimeSpan.FromSeconds(10);
} }
@@ -60,7 +58,7 @@ public class LyricsStartupValidator : BaseStartupValidator
return allSuccess return allSuccess
? ValidationResult.Success("Lyrics services validation completed") ? ValidationResult.Success("Lyrics services validation completed")
: ValidationResult.Warning("Some lyrics services had issues"); : ValidationResult.Failure("PARTIAL", "Some lyrics services had issues", ConsoleColor.Yellow);
} }
private async Task<bool> TestLrclibAsync(CancellationToken cancellationToken) private async Task<bool> TestLrclibAsync(CancellationToken cancellationToken)