mirror of
https://github.com/SoPat712/allstarr.git
synced 2026-02-09 23:55:10 -05:00
refactor: extract subsonic controller logic into specialized services
- Extract SubsonicRequestParser for HTTP parameter extraction - Extract SubsonicResponseBuilder for XML/JSON response formatting - Extract SubsonicModelMapper for search result parsing and merging - Extract SubsonicProxyService for upstream Subsonic server communication - Add comprehensive test coverage (45 tests) for all new services - Reduce SubsonicController from 1174 to 666 lines (-43%) All tests passing. Build succeeds with 0 errors.
This commit is contained in:
V1ck3s
347
octo-fiesta.Tests/SubsonicModelMapperTests.cs
Normal file
347
octo-fiesta.Tests/SubsonicModelMapperTests.cs
Normal file
@@ -0,0 +1,347 @@
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Moq;
|
||||
using octo_fiesta.Models.Domain;
|
||||
using octo_fiesta.Models.Search;
|
||||
using octo_fiesta.Services.Subsonic;
|
||||
using System.Text;
|
||||
using System.Text.Json;
|
||||
using System.Xml.Linq;
|
||||
|
||||
namespace octo_fiesta.Tests;
|
||||
|
||||
public class SubsonicModelMapperTests
|
||||
{
|
||||
private readonly SubsonicModelMapper _mapper;
|
||||
private readonly Mock<ILogger<SubsonicModelMapper>> _mockLogger;
|
||||
private readonly SubsonicResponseBuilder _responseBuilder;
|
||||
|
||||
public SubsonicModelMapperTests()
|
||||
{
|
||||
_responseBuilder = new SubsonicResponseBuilder();
|
||||
_mockLogger = new Mock<ILogger<SubsonicModelMapper>>();
|
||||
_mapper = new SubsonicModelMapper(_responseBuilder, _mockLogger.Object);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseSearchResponse_JsonWithSongs_ParsesCorrectly()
|
||||
{
|
||||
// Arrange
|
||||
var jsonResponse = @"{
|
||||
""subsonic-response"": {
|
||||
""status"": ""ok"",
|
||||
""version"": ""1.16.1"",
|
||||
""searchResult3"": {
|
||||
""song"": [
|
||||
{
|
||||
""id"": ""song1"",
|
||||
""title"": ""Test Song"",
|
||||
""artist"": ""Test Artist"",
|
||||
""album"": ""Test Album""
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
}";
|
||||
var responseBody = Encoding.UTF8.GetBytes(jsonResponse);
|
||||
|
||||
// Act
|
||||
var (songs, albums, artists) = _mapper.ParseSearchResponse(responseBody, "application/json");
|
||||
|
||||
// Assert
|
||||
Assert.Single(songs);
|
||||
Assert.Empty(albums);
|
||||
Assert.Empty(artists);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseSearchResponse_XmlWithSongs_ParsesCorrectly()
|
||||
{
|
||||
// Arrange
|
||||
var xmlResponse = @"<?xml version=""1.0"" encoding=""UTF-8""?>
|
||||
<subsonic-response xmlns=""http://subsonic.org/restapi"" status=""ok"" version=""1.16.1"">
|
||||
<searchResult3>
|
||||
<song id=""song1"" title=""Test Song"" artist=""Test Artist"" album=""Test Album"" />
|
||||
</searchResult3>
|
||||
</subsonic-response>";
|
||||
var responseBody = Encoding.UTF8.GetBytes(xmlResponse);
|
||||
|
||||
// Act
|
||||
var (songs, albums, artists) = _mapper.ParseSearchResponse(responseBody, "application/xml");
|
||||
|
||||
// Assert
|
||||
Assert.Single(songs);
|
||||
Assert.Empty(albums);
|
||||
Assert.Empty(artists);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseSearchResponse_JsonWithAllTypes_ParsesAllCorrectly()
|
||||
{
|
||||
// Arrange
|
||||
var jsonResponse = @"{
|
||||
""subsonic-response"": {
|
||||
""status"": ""ok"",
|
||||
""version"": ""1.16.1"",
|
||||
""searchResult3"": {
|
||||
""song"": [
|
||||
{""id"": ""song1"", ""title"": ""Song 1""}
|
||||
],
|
||||
""album"": [
|
||||
{""id"": ""album1"", ""name"": ""Album 1""}
|
||||
],
|
||||
""artist"": [
|
||||
{""id"": ""artist1"", ""name"": ""Artist 1""}
|
||||
]
|
||||
}
|
||||
}
|
||||
}";
|
||||
var responseBody = Encoding.UTF8.GetBytes(jsonResponse);
|
||||
|
||||
// Act
|
||||
var (songs, albums, artists) = _mapper.ParseSearchResponse(responseBody, "application/json");
|
||||
|
||||
// Assert
|
||||
Assert.Single(songs);
|
||||
Assert.Single(albums);
|
||||
Assert.Single(artists);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseSearchResponse_XmlWithAllTypes_ParsesAllCorrectly()
|
||||
{
|
||||
// Arrange
|
||||
var xmlResponse = @"<?xml version=""1.0"" encoding=""UTF-8""?>
|
||||
<subsonic-response xmlns=""http://subsonic.org/restapi"" status=""ok"" version=""1.16.1"">
|
||||
<searchResult3>
|
||||
<song id=""song1"" title=""Song 1"" />
|
||||
<album id=""album1"" name=""Album 1"" />
|
||||
<artist id=""artist1"" name=""Artist 1"" />
|
||||
</searchResult3>
|
||||
</subsonic-response>";
|
||||
var responseBody = Encoding.UTF8.GetBytes(xmlResponse);
|
||||
|
||||
// Act
|
||||
var (songs, albums, artists) = _mapper.ParseSearchResponse(responseBody, "application/xml");
|
||||
|
||||
// Assert
|
||||
Assert.Single(songs);
|
||||
Assert.Single(albums);
|
||||
Assert.Single(artists);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseSearchResponse_InvalidJson_ReturnsEmpty()
|
||||
{
|
||||
// Arrange
|
||||
var invalidJson = "{invalid json}";
|
||||
var responseBody = Encoding.UTF8.GetBytes(invalidJson);
|
||||
|
||||
// Act
|
||||
var (songs, albums, artists) = _mapper.ParseSearchResponse(responseBody, "application/json");
|
||||
|
||||
// Assert
|
||||
Assert.Empty(songs);
|
||||
Assert.Empty(albums);
|
||||
Assert.Empty(artists);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseSearchResponse_EmptySearchResult_ReturnsEmpty()
|
||||
{
|
||||
// Arrange
|
||||
var jsonResponse = @"{
|
||||
""subsonic-response"": {
|
||||
""status"": ""ok"",
|
||||
""version"": ""1.16.1"",
|
||||
""searchResult3"": {}
|
||||
}
|
||||
}";
|
||||
var responseBody = Encoding.UTF8.GetBytes(jsonResponse);
|
||||
|
||||
// Act
|
||||
var (songs, albums, artists) = _mapper.ParseSearchResponse(responseBody, "application/json");
|
||||
|
||||
// Assert
|
||||
Assert.Empty(songs);
|
||||
Assert.Empty(albums);
|
||||
Assert.Empty(artists);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeSearchResults_Json_MergesSongsCorrectly()
|
||||
{
|
||||
// Arrange
|
||||
var localSongs = new List<object>
|
||||
{
|
||||
new Dictionary<string, object> { ["id"] = "local1", ["title"] = "Local Song" }
|
||||
};
|
||||
var externalResult = new SearchResult
|
||||
{
|
||||
Songs = new List<Song>
|
||||
{
|
||||
new Song { Id = "ext1", Title = "External Song" }
|
||||
},
|
||||
Albums = new List<Album>(),
|
||||
Artists = new List<Artist>()
|
||||
};
|
||||
|
||||
// Act
|
||||
var (mergedSongs, mergedAlbums, mergedArtists) = _mapper.MergeSearchResults(
|
||||
localSongs, new List<object>(), new List<object>(), externalResult, true);
|
||||
|
||||
// Assert
|
||||
Assert.Equal(2, mergedSongs.Count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeSearchResults_Json_DeduplicatesArtists()
|
||||
{
|
||||
// Arrange
|
||||
var localArtists = new List<object>
|
||||
{
|
||||
new Dictionary<string, object> { ["id"] = "local1", ["name"] = "Test Artist" }
|
||||
};
|
||||
var externalResult = new SearchResult
|
||||
{
|
||||
Songs = new List<Song>(),
|
||||
Albums = new List<Album>(),
|
||||
Artists = new List<Artist>
|
||||
{
|
||||
new Artist { Id = "ext1", Name = "Test Artist" }, // Same name - should be filtered
|
||||
new Artist { Id = "ext2", Name = "Different Artist" } // Different name - should be included
|
||||
}
|
||||
};
|
||||
|
||||
// Act
|
||||
var (mergedSongs, mergedAlbums, mergedArtists) = _mapper.MergeSearchResults(
|
||||
new List<object>(), new List<object>(), localArtists, externalResult, true);
|
||||
|
||||
// Assert
|
||||
Assert.Equal(2, mergedArtists.Count); // 1 local + 1 external (duplicate filtered)
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeSearchResults_Json_CaseInsensitiveDeduplication()
|
||||
{
|
||||
// Arrange
|
||||
var localArtists = new List<object>
|
||||
{
|
||||
new Dictionary<string, object> { ["id"] = "local1", ["name"] = "Test Artist" }
|
||||
};
|
||||
var externalResult = new SearchResult
|
||||
{
|
||||
Songs = new List<Song>(),
|
||||
Albums = new List<Album>(),
|
||||
Artists = new List<Artist>
|
||||
{
|
||||
new Artist { Id = "ext1", Name = "test artist" } // Different case - should still be filtered
|
||||
}
|
||||
};
|
||||
|
||||
// Act
|
||||
var (mergedSongs, mergedAlbums, mergedArtists) = _mapper.MergeSearchResults(
|
||||
new List<object>(), new List<object>(), localArtists, externalResult, true);
|
||||
|
||||
// Assert
|
||||
Assert.Single(mergedArtists); // Only the local artist
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeSearchResults_Xml_MergesSongsCorrectly()
|
||||
{
|
||||
// Arrange
|
||||
var ns = XNamespace.Get("http://subsonic.org/restapi");
|
||||
var localSongs = new List<object>
|
||||
{
|
||||
new XElement("song", new XAttribute("id", "local1"), new XAttribute("title", "Local Song"))
|
||||
};
|
||||
var externalResult = new SearchResult
|
||||
{
|
||||
Songs = new List<Song>
|
||||
{
|
||||
new Song { Id = "ext1", Title = "External Song" }
|
||||
},
|
||||
Albums = new List<Album>(),
|
||||
Artists = new List<Artist>()
|
||||
};
|
||||
|
||||
// Act
|
||||
var (mergedSongs, mergedAlbums, mergedArtists) = _mapper.MergeSearchResults(
|
||||
localSongs, new List<object>(), new List<object>(), externalResult, false);
|
||||
|
||||
// Assert
|
||||
Assert.Equal(2, mergedSongs.Count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeSearchResults_Xml_DeduplicatesArtists()
|
||||
{
|
||||
// Arrange
|
||||
var localArtists = new List<object>
|
||||
{
|
||||
new XElement("artist", new XAttribute("id", "local1"), new XAttribute("name", "Test Artist"))
|
||||
};
|
||||
var externalResult = new SearchResult
|
||||
{
|
||||
Songs = new List<Song>(),
|
||||
Albums = new List<Album>(),
|
||||
Artists = new List<Artist>
|
||||
{
|
||||
new Artist { Id = "ext1", Name = "Test Artist" }, // Same name - should be filtered
|
||||
new Artist { Id = "ext2", Name = "Different Artist" } // Different name - should be included
|
||||
}
|
||||
};
|
||||
|
||||
// Act
|
||||
var (mergedSongs, mergedAlbums, mergedArtists) = _mapper.MergeSearchResults(
|
||||
new List<object>(), new List<object>(), localArtists, externalResult, false);
|
||||
|
||||
// Assert
|
||||
Assert.Equal(2, mergedArtists.Count); // 1 local + 1 external (duplicate filtered)
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeSearchResults_EmptyLocalResults_ReturnsOnlyExternal()
|
||||
{
|
||||
// Arrange
|
||||
var externalResult = new SearchResult
|
||||
{
|
||||
Songs = new List<Song> { new Song { Id = "ext1" } },
|
||||
Albums = new List<Album> { new Album { Id = "ext2" } },
|
||||
Artists = new List<Artist> { new Artist { Id = "ext3", Name = "Artist" } }
|
||||
};
|
||||
|
||||
// Act
|
||||
var (mergedSongs, mergedAlbums, mergedArtists) = _mapper.MergeSearchResults(
|
||||
new List<object>(), new List<object>(), new List<object>(), externalResult, true);
|
||||
|
||||
// Assert
|
||||
Assert.Single(mergedSongs);
|
||||
Assert.Single(mergedAlbums);
|
||||
Assert.Single(mergedArtists);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MergeSearchResults_EmptyExternalResults_ReturnsOnlyLocal()
|
||||
{
|
||||
// Arrange
|
||||
var localSongs = new List<object> { new Dictionary<string, object> { ["id"] = "local1" } };
|
||||
var localAlbums = new List<object> { new Dictionary<string, object> { ["id"] = "local2" } };
|
||||
var localArtists = new List<object> { new Dictionary<string, object> { ["id"] = "local3", ["name"] = "Local" } };
|
||||
var externalResult = new SearchResult
|
||||
{
|
||||
Songs = new List<Song>(),
|
||||
Albums = new List<Album>(),
|
||||
Artists = new List<Artist>()
|
||||
};
|
||||
|
||||
// Act
|
||||
var (mergedSongs, mergedAlbums, mergedArtists) = _mapper.MergeSearchResults(
|
||||
localSongs, localAlbums, localArtists, externalResult, true);
|
||||
|
||||
// Assert
|
||||
Assert.Single(mergedSongs);
|
||||
Assert.Single(mergedAlbums);
|
||||
Assert.Single(mergedArtists);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user