From df3cc51e1770da40a54060facd6b1eb6d6d9555c Mon Sep 17 00:00:00 2001 From: Josh Patra Date: Sun, 1 Feb 2026 11:18:17 -0500 Subject: [PATCH] Fix DownloadSongAsync return type handling --- allstarr/Controllers/JellyfinController.cs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/allstarr/Controllers/JellyfinController.cs b/allstarr/Controllers/JellyfinController.cs index 62fbaf9..84364b7 100644 --- a/allstarr/Controllers/JellyfinController.cs +++ b/allstarr/Controllers/JellyfinController.cs @@ -2112,16 +2112,18 @@ public class JellyfinController : ControllerBase // Trigger download first _logger.LogInformation("Downloading track for kept folder: {ItemId}", itemId); - var downloadResult = await _downloadService.DownloadSongAsync(provider, externalId); + string downloadPath; - if (!downloadResult.IsSuccess) + try { - _logger.LogWarning("Failed to download track {ItemId}: {Error}", itemId, downloadResult.Error); + downloadPath = await _downloadService.DownloadSongAsync(provider, externalId); + } + catch (Exception ex) + { + _logger.LogWarning(ex, "Failed to download track {ItemId}", itemId); return; } - var downloadPath = downloadResult.Value!.FilePath; - // Create kept folder structure: /app/kept/Artist/Album/ var keptBasePath = "/app/kept"; var keptArtistPath = Path.Combine(keptBasePath, PathHelper.SanitizeFileName(song.Artist));