refactor: organize services by provider and standardize settings pattern

octo-fiesta/Services/StartupValidationService.cs

@@ -1,7 +1,7 @@
-using System.Text;
-using System.Text.Json;
 using Microsoft.Extensions.Options;
 using octo_fiesta.Models;
+using octo_fiesta.Services.Deezer;
+using octo_fiesta.Services.Qobuz;
 
 namespace octo_fiesta.Services;
 
@@ -14,16 +14,19 @@ public class StartupValidationService : IHostedService
 {
     private readonly IConfiguration _configuration;
     private readonly IOptions<SubsonicSettings> _subsonicSettings;
+    private readonly IOptions<DeezerSettings> _deezerSettings;
     private readonly IOptions<QobuzSettings> _qobuzSettings;
     private readonly HttpClient _httpClient;
 
     public StartupValidationService(
         IConfiguration configuration,
         IOptions<SubsonicSettings> subsonicSettings,
+        IOptions<DeezerSettings> deezerSettings,
         IOptions<QobuzSettings> qobuzSettings)
     {
         _configuration = configuration;
         _subsonicSettings = subsonicSettings;
+        _deezerSettings = deezerSettings;
         _qobuzSettings = qobuzSettings;
         // Create a dedicated HttpClient without logging to keep startup output clean
         _httpClient = new HttpClient { Timeout = TimeSpan.FromSeconds(10) };
@@ -43,11 +46,13 @@ public class StartupValidationService : IHostedService
         var musicService = _subsonicSettings.Value.MusicService;
         if (musicService == MusicService.Qobuz)
         {
-            await ValidateQobuzAsync(cancellationToken);
+            var qobuzValidator = new QobuzStartupValidator(_qobuzSettings, _httpClient);
+            await qobuzValidator.ValidateAsync(cancellationToken);
         }
         else
         {
-            await ValidateDeezerArlAsync(cancellationToken);
+            var deezerValidator = new DeezerStartupValidator(_deezerSettings, _httpClient);
+            await deezerValidator.ValidateAsync(cancellationToken);
         }
 
         Console.WriteLine();
@@ -121,244 +126,6 @@ public class StartupValidationService : IHostedService
         }
     }
 
-    private async Task ValidateDeezerArlAsync(CancellationToken cancellationToken)
-    {
-        var arl = _configuration["Deezer:Arl"];
-        var arlFallback = _configuration["Deezer:ArlFallback"];
-        var quality = _configuration["Deezer:Quality"];
-
-        Console.WriteLine();
-
-        if (string.IsNullOrWhiteSpace(arl))
-        {
-            WriteStatus("Deezer ARL", "NOT CONFIGURED", ConsoleColor.Red);
-            WriteDetail("Set the Deezer__Arl environment variable");
-            return;
-        }
-
-        WriteStatus("Deezer ARL", MaskSecret(arl), ConsoleColor.Cyan);
-        
-        if (!string.IsNullOrWhiteSpace(arlFallback))
-        {
-            WriteStatus("Deezer ARL Fallback", MaskSecret(arlFallback), ConsoleColor.Cyan);
-        }
-
-        WriteStatus("Deezer Quality", string.IsNullOrWhiteSpace(quality) ? "auto (highest available)" : quality, ConsoleColor.Cyan);
-
-        // Validate ARL by calling Deezer API
-        await ValidateArlTokenAsync(arl, "primary", cancellationToken);
-        
-        if (!string.IsNullOrWhiteSpace(arlFallback))
-        {
-            await ValidateArlTokenAsync(arlFallback, "fallback", cancellationToken);
-        }
-    }
-
-    private async Task ValidateQobuzAsync(CancellationToken cancellationToken)
-    {
-        var userAuthToken = _qobuzSettings.Value.UserAuthToken;
-        var userId = _qobuzSettings.Value.UserId;
-        var quality = _qobuzSettings.Value.Quality;
-
-        Console.WriteLine();
-
-        if (string.IsNullOrWhiteSpace(userAuthToken))
-        {
-            WriteStatus("Qobuz UserAuthToken", "NOT CONFIGURED", ConsoleColor.Red);
-            WriteDetail("Set the Qobuz__UserAuthToken environment variable");
-            return;
-        }
-
-        if (string.IsNullOrWhiteSpace(userId))
-        {
-            WriteStatus("Qobuz UserId", "NOT CONFIGURED", ConsoleColor.Red);
-            WriteDetail("Set the Qobuz__UserId environment variable");
-            return;
-        }
-
-        WriteStatus("Qobuz UserAuthToken", MaskSecret(userAuthToken), ConsoleColor.Cyan);
-        WriteStatus("Qobuz UserId", userId, ConsoleColor.Cyan);
-        WriteStatus("Qobuz Quality", quality ?? "auto (highest available)", ConsoleColor.Cyan);
-
-        // Validate token by calling Qobuz API
-        await ValidateQobuzTokenAsync(userAuthToken, userId, cancellationToken);
-    }
-
-    private async Task ValidateQobuzTokenAsync(string userAuthToken, string userId, CancellationToken cancellationToken)
-    {
-        const string fieldName = "Qobuz credentials";
-        
-        try
-        {
-            // First, get the app ID from bundle service (simple check)
-            var bundleUrl = "https://play.qobuz.com/login";
-            var bundleResponse = await _httpClient.GetAsync(bundleUrl, cancellationToken);
-            
-            if (!bundleResponse.IsSuccessStatusCode)
-            {
-                WriteStatus(fieldName, "UNABLE TO VERIFY", ConsoleColor.Yellow);
-                WriteDetail("Could not fetch Qobuz app configuration");
-                return;
-            }
-
-            // Try to validate with a simple API call
-            // We'll use the user favorites endpoint which requires authentication
-            var appId = "798273057"; // Fallback app ID
-            var apiUrl = $"https://www.qobuz.com/api.json/0.2/favorite/getUserFavorites?user_id={userId}&app_id={appId}";
-            
-            using var request = new HttpRequestMessage(HttpMethod.Get, apiUrl);
-            request.Headers.Add("X-App-Id", appId);
-            request.Headers.Add("X-User-Auth-Token", userAuthToken);
-            request.Headers.Add("User-Agent", "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0");
-
-            var response = await _httpClient.SendAsync(request, cancellationToken);
-
-            if (!response.IsSuccessStatusCode)
-            {
-                // 401 means invalid token, other errors might be network issues
-                if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized)
-                {
-                    WriteStatus(fieldName, "INVALID", ConsoleColor.Red);
-                    WriteDetail("Token is expired or invalid");
-                }
-                else
-                {
-                    WriteStatus(fieldName, $"HTTP {(int)response.StatusCode}", ConsoleColor.Yellow);
-                    WriteDetail("Unable to verify credentials");
-                }
-                return;
-            }
-
-            var json = await response.Content.ReadAsStringAsync(cancellationToken);
-            
-            // If we got a successful response, credentials are valid
-            if (!string.IsNullOrEmpty(json) && !json.Contains("\"error\""))
-            {
-                WriteStatus(fieldName, "VALID", ConsoleColor.Green);
-                WriteDetail($"User ID: {userId}");
-            }
-            else
-            {
-                WriteStatus(fieldName, "INVALID", ConsoleColor.Red);
-                WriteDetail("Unexpected response from Qobuz");
-            }
-        }
-        catch (TaskCanceledException)
-        {
-            WriteStatus(fieldName, "TIMEOUT", ConsoleColor.Yellow);
-            WriteDetail("Could not reach Qobuz within 10 seconds");
-        }
-        catch (HttpRequestException ex)
-        {
-            WriteStatus(fieldName, "UNREACHABLE", ConsoleColor.Yellow);
-            WriteDetail(ex.Message);
-        }
-        catch (Exception ex)
-        {
-            WriteStatus(fieldName, "ERROR", ConsoleColor.Red);
-            WriteDetail(ex.Message);
-        }
-    }
-
-    private async Task ValidateArlTokenAsync(string arl, string label, CancellationToken cancellationToken)
-    {
-        var fieldName = $"Deezer ARL ({label})";
-        
-        try
-        {
-            using var request = new HttpRequestMessage(HttpMethod.Post,
-                "https://www.deezer.com/ajax/gw-light.php?method=deezer.getUserData&input=3&api_version=1.0&api_token=null");
-            
-            request.Headers.Add("Cookie", $"arl={arl}");
-            request.Content = new StringContent("{}", Encoding.UTF8, "application/json");
-
-            var response = await _httpClient.SendAsync(request, cancellationToken);
-
-            if (!response.IsSuccessStatusCode)
-            {
-                WriteStatus(fieldName, $"HTTP {(int)response.StatusCode}", ConsoleColor.Red);
-                return;
-            }
-
-            var json = await response.Content.ReadAsStringAsync(cancellationToken);
-            var doc = JsonDocument.Parse(json);
-
-            if (doc.RootElement.TryGetProperty("results", out var results) &&
-                results.TryGetProperty("USER", out var user))
-            {
-                if (user.TryGetProperty("USER_ID", out var userId))
-                {
-                    var userIdValue = userId.ValueKind == JsonValueKind.Number 
-                        ? userId.GetInt64() 
-                        : long.TryParse(userId.GetString(), out var parsed) ? parsed : 0;
-
-                    if (userIdValue > 0)
-                    {
-                        // BLOG_NAME is the username displayed on Deezer
-                        var userName = user.TryGetProperty("BLOG_NAME", out var blogName) && blogName.GetString() is string bn && !string.IsNullOrEmpty(bn)
-                            ? bn
-                            : user.TryGetProperty("NAME", out var name) && name.GetString() is string n && !string.IsNullOrEmpty(n)
-                                ? n
-                                : "Unknown";
-                        
-                        var offerName = GetOfferName(user);
-                        
-                        WriteStatus(fieldName, "VALID", ConsoleColor.Green);
-                        WriteDetail($"Logged in as {userName} ({offerName})");
-                        return;
-                    }
-                }
-                
-                WriteStatus(fieldName, "INVALID", ConsoleColor.Red);
-                WriteDetail("Token is expired or invalid");
-            }
-            else
-            {
-                WriteStatus(fieldName, "INVALID", ConsoleColor.Red);
-                WriteDetail("Unexpected response from Deezer");
-            }
-        }
-        catch (TaskCanceledException)
-        {
-            WriteStatus(fieldName, "TIMEOUT", ConsoleColor.Yellow);
-            WriteDetail("Could not reach Deezer within 10 seconds");
-        }
-        catch (HttpRequestException ex)
-        {
-            WriteStatus(fieldName, "UNREACHABLE", ConsoleColor.Yellow);
-            WriteDetail(ex.Message);
-        }
-        catch (Exception ex)
-        {
-            WriteStatus(fieldName, "ERROR", ConsoleColor.Red);
-            WriteDetail(ex.Message);
-        }
-    }
-
-    private static string GetOfferName(JsonElement user)
-    {
-        if (!user.TryGetProperty("OPTIONS", out var options))
-        {
-            return "Free";
-        }
-
-        // Check actual streaming capabilities, not just license_token presence
-        var hasLossless = options.TryGetProperty("web_lossless", out var webLossless) && webLossless.GetBoolean();
-        var hasHq = options.TryGetProperty("web_hq", out var webHq) && webHq.GetBoolean();
-
-        if (hasLossless)
-        {
-            return "Premium+ (Lossless)";
-        }
-        
-        if (hasHq)
-        {
-            return "Premium (HQ)";
-        }
-        
-        return "Free";
-    }
-
     private static void WriteStatus(string label, string value, ConsoleColor valueColor)
     {
         Console.Write($"  {label}: ");
@@ -375,23 +142,4 @@ public class StartupValidationService : IHostedService
         Console.WriteLine($"    -> {message}");
         Console.ForegroundColor = originalColor;
     }
-
-    /// <summary>
-    /// Masks a secret string, showing only the first 4 characters followed by asterisks.
-    /// </summary>
-    private static string MaskSecret(string secret)
-    {
-        if (string.IsNullOrEmpty(secret))
-        {
-            return "(empty)";
-        }
-
-        const int visibleChars = 4;
-        if (secret.Length <= visibleChars)
-        {
-            return new string('*', secret.Length);
-        }
-
-        return secret[..visibleChars] + new string('*', Math.Min(secret.Length - visibleChars, 8));
-    }
 }