From e6c56bcecb8681c9198e83c9fcee0071bd3f6085 Mon Sep 17 00:00:00 2001
From: Josh Patra <joshpatra12@gmail.com>
Date: Tue, 7 Apr 2026 14:31:34 -0400
Subject: [PATCH] Allow zero controller opacity in settings

---
 options.js                        | 17 +++++++++++++----
 tests/options.integration.test.js | 17 ++++++++++-------
 2 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/options.js b/options.js
index f26c5b9..ae8e9b4 100644
--- a/options.js
+++ b/options.js
@@ -307,6 +307,11 @@ function clampMarginPxInput(el, fallback) {
   return controllerUtils.clampControllerMarginPx(el && el.value, fallback);
 }
 
+function parseFiniteNumberOrFallback(value, fallback) {
+  var numericValue = parseFloat(value);
+  return Number.isFinite(numericValue) ? numericValue : fallback;
+}
+
 function syncSiteRuleField(ruleEl, rule, key, isCheckbox) {
   var input = ruleEl.querySelector(".site-" + key);
   if (!input) return;
@@ -624,8 +629,10 @@ function save_options() {
     document.getElementById("controllerLocation").value
   );
   settings.controllerOpacity =
-    parseFloat(document.getElementById("controllerOpacity").value) ||
-    tcDefaults.controllerOpacity;
+    parseFiniteNumberOrFallback(
+      document.getElementById("controllerOpacity").value,
+      tcDefaults.controllerOpacity
+    );
 
   settings.controllerMarginTop = clampMarginPxInput(
     document.getElementById("controllerMarginTop"),
@@ -713,8 +720,10 @@ function save_options() {
 
     if (ruleEl.querySelector(".override-opacity").checked) {
       rule.controllerOpacity =
-        parseFloat(ruleEl.querySelector(".site-controllerOpacity").value) ||
-        settings.controllerOpacity;
+        parseFiniteNumberOrFallback(
+          ruleEl.querySelector(".site-controllerOpacity").value,
+          settings.controllerOpacity
+        );
     }
 
     if (ruleEl.querySelector(".override-subtitleNudge").checked) {
diff --git a/tests/options.integration.test.js b/tests/options.integration.test.js
index 4e14f13..4966525 100644
--- a/tests/options.integration.test.js
+++ b/tests/options.integration.test.js
@@ -78,7 +78,7 @@ describe("options page", () => {
 
     document.getElementById("rememberSpeed").checked = true;
     document.getElementById("hideWithControlsTimer").value = "20";
-    document.getElementById("controllerOpacity").value = "0.55";
+    document.getElementById("controllerOpacity").value = "0";
     document.getElementById("controllerMarginTop").value = "250";
     document.getElementById("controllerMarginBottom").value = "-4";
     document.getElementById("enableSubtitleNudge").checked = true;
@@ -98,6 +98,8 @@ describe("options page", () => {
     rule.querySelector(".site-pattern").value = "youtube.com";
     rule.querySelector(".override-playback").checked = true;
     rule.querySelector(".site-rememberSpeed").checked = true;
+    rule.querySelector(".override-opacity").checked = true;
+    rule.querySelector(".site-controllerOpacity").value = "0";
     rule.querySelector(".override-popup-controlbar").checked = true;
     rule.querySelector(".site-showPopupControlBar").checked = false;
     globalThis.populateControlBarZones(
@@ -119,7 +121,7 @@ describe("options page", () => {
 
     expect(savedSettings.rememberSpeed).toBe(true);
     expect(savedSettings.hideWithControlsTimer).toBe(15);
-    expect(savedSettings.controllerOpacity).toBe(0.55);
+    expect(savedSettings.controllerOpacity).toBe(0);
     expect(savedSettings.controllerMarginTop).toBe(200);
     expect(savedSettings.controllerMarginBottom).toBe(0);
     expect(savedSettings.subtitleNudgeInterval).toBe(10);
@@ -129,11 +131,12 @@ describe("options page", () => {
     expect(savedSettings.siteRules).toEqual(
       expect.arrayContaining([
         expect.objectContaining({
-          pattern: "youtube.com",
-          rememberSpeed: true,
-          showPopupControlBar: false,
-          popupControllerButtons: ["advance"]
-        })
+        pattern: "youtube.com",
+        rememberSpeed: true,
+        controllerOpacity: 0,
+        showPopupControlBar: false,
+        popupControllerButtons: ["advance"]
+      })
       ])
     );
   });