From 2e1f7952ca55520aa0bdb527cd217b9d564dfb3e Mon Sep 17 00:00:00 2001 From: codebicycle Date: Thu, 20 Apr 2017 22:36:03 +0300 Subject: [PATCH] Fix options page's numeric inputs Rewind Time (s) Advance Time (s) Speed Change Step --- options.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/options.js b/options.js index 590bb01..66a6b05 100644 --- a/options.js +++ b/options.js @@ -51,6 +51,9 @@ var keyCodeAliases = { 222: '\'', } +var whiteList = ['Backspace', 'Delete', 'Tab', 'Escape', 'Enter', 'Home', 'End', + 'ArrowRight', 'ArrowLeft', 'ArrowUp', 'ArrowDown'] + function recordKeyPress(e) { if ( (e.keyCode >= 48 && e.keyCode <= 57) // Numbers 0-9 @@ -68,7 +71,10 @@ function recordKeyPress(e) { }; function inputFilterNumbersOnly(e) { - var char = String.fromCharCode(e.keyCode); + var char = e.key; + if (whiteList.includes(char)) { + return + } if (!/[\d\.]$/.test(char) || !/^\d+(\.\d*)?$/.test(e.target.value + char)) { e.preventDefault(); e.stopPropagation();