From 60599996ee1f8bb327f053ca39224fe1eee9c7df Mon Sep 17 00:00:00 2001 From: mariusi7 Date: Sun, 24 Sep 2017 10:18:23 +0300 Subject: [PATCH 1/4] Update inject.js Some regional HBO GO sites don't use www anymore, so issue 199 reappeared. --- inject.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inject.js b/inject.js index f9c9799..f21fa8b 100644 --- a/inject.js +++ b/inject.js @@ -151,7 +151,7 @@ chrome.extension.sendMessage({}, function(response) { switch (true) { case (location.hostname == 'www.amazon.com'): - case (/www\.hbogo\./).test(location.hostname): + case (/hbogo\./).test(location.hostname): // insert before parent to bypass overlay this.parent.parentElement.insertBefore(fragment, this.parent); break; From 1004348a47f9a8756af9815359aae55fcafda5ed Mon Sep 17 00:00:00 2001 From: Roly Fentanes Date: Thu, 28 Sep 2017 22:47:21 -0400 Subject: [PATCH 2/4] Remove vscid even if ctrl is not found --- inject.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inject.js b/inject.js index f21fa8b..59d4e3c 100644 --- a/inject.js +++ b/inject.js @@ -270,9 +270,9 @@ chrome.extension.sendMessage({}, function(response) { let ctrl = document.querySelector(`div[data-vscid="${id}"]`) if (ctrl) { node.classList.remove('vsc-initialized'); - delete node.dataset['vscid']; ctrl.remove(); } + delete node.dataset['vscid']; } } } else if (node.children != undefined) { From 194fcc107680f8d84ca75749c375c152f991eedd Mon Sep 17 00:00:00 2001 From: Roly Fentanes Date: Sun, 1 Oct 2017 15:29:59 -0400 Subject: [PATCH 3/4] Also remove className regardless of ctrl --- inject.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inject.js b/inject.js index 59d4e3c..1ce2118 100644 --- a/inject.js +++ b/inject.js @@ -269,9 +269,9 @@ chrome.extension.sendMessage({}, function(response) { let id = node.dataset['vscid']; let ctrl = document.querySelector(`div[data-vscid="${id}"]`) if (ctrl) { - node.classList.remove('vsc-initialized'); ctrl.remove(); } + node.classList.remove('vsc-initialized'); delete node.dataset['vscid']; } } From ae778d2901d710c329e449962429994ba466d865 Mon Sep 17 00:00:00 2001 From: codebicycle Date: Tue, 3 Oct 2017 19:14:37 +0300 Subject: [PATCH 4/4] Replace chrome.extension with chrome.runtime The messaging APIs in `extension` module are deprecated in favor of the equivalent APIs in the `runtime` module. Sources: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/extension https://developer.chrome.com/extensions/extension#methods --- inject.js | 6 +++--- popup.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/inject.js b/inject.js index 1ce2118..f9d50d3 100644 --- a/inject.js +++ b/inject.js @@ -1,4 +1,4 @@ -chrome.extension.sendMessage({}, function(response) { +chrome.runtime.sendMessage({}, function(response) { var tc = { settings: { speed: 1.0, // default 1x @@ -117,7 +117,7 @@ chrome.extension.sendMessage({}, function(response) { var shadow = wrapper.createShadowRoot(); var shadowTemplate = `
@@ -213,7 +213,7 @@ chrome.extension.sendMessage({}, function(response) { defineVideoController(); } else { var link = document.createElement('link'); - link.href = chrome.extension.getURL('inject.css'); + link.href = chrome.runtime.getURL('inject.css'); link.type = 'text/css'; link.rel = 'stylesheet'; document.head.appendChild(link); diff --git a/popup.js b/popup.js index 13d16b1..a60b107 100644 --- a/popup.js +++ b/popup.js @@ -1,6 +1,6 @@ document.addEventListener('DOMContentLoaded', function () { document.querySelector('#config').addEventListener('click', function() { - window.open(chrome.extension.getURL("options.html")); + window.open(chrome.runtime.getURL("options.html")); }); document.querySelector('#about').addEventListener('click', function() {