Update the tc.settings.speed on rateChange (Fix #455) (#458)

* Update the tc.settings.speed on rateChange (Fix #455)
* Refactor speed to lastSpeed
This commit is contained in:
jacobcolbert
2019-04-24 22:47:50 -04:00
committed by Ilya Grigorik
parent 5fec357d2e
commit a159fa4013

View File

@@ -1,6 +1,6 @@
var tc = { var tc = {
settings: { settings: {
speed: 1.0, // default 1x lastSpeed: 1.0, // default 1x
speeds: {}, // empty object to hold speed for each source speeds: {}, // empty object to hold speed for each source
displayKeyCode: 86, // default: V displayKeyCode: 86, // default: V
@@ -76,7 +76,7 @@
blacklist: tc.settings.blacklist.replace(/^\s+|\s+$/gm, '') blacklist: tc.settings.blacklist.replace(/^\s+|\s+$/gm, '')
}); });
} }
tc.settings.speed = Number(storage.speed); tc.settings.lastSpeed = Number(storage.lastSpeed);
tc.settings.displayKeyCode = Number(storage.displayKeyCode); tc.settings.displayKeyCode = Number(storage.displayKeyCode);
tc.settings.rememberSpeed = Boolean(storage.rememberSpeed); tc.settings.rememberSpeed = Boolean(storage.rememberSpeed);
tc.settings.audioBoolean = Boolean(storage.audioBoolean); tc.settings.audioBoolean = Boolean(storage.audioBoolean);
@@ -117,7 +117,7 @@
} }
setKeyBindings("reset", getKeyBindings("fast")); // resetSpeed = fastSpeed setKeyBindings("reset", getKeyBindings("fast")); // resetSpeed = fastSpeed
} else { } else {
tc.settings.speeds[target.src] = tc.settings.speed; tc.settings.speeds[target.src] = tc.settings.lastSpeed;
} }
this.initializeControls(); this.initializeControls();
@@ -128,7 +128,7 @@
} }
setKeyBindings("reset", getKeyBindings("fast")); // resetSpeed = fastSpeed setKeyBindings("reset", getKeyBindings("fast")); // resetSpeed = fastSpeed
} else { } else {
tc.settings.speeds[target.src] = tc.settings.speed; tc.settings.speeds[target.src] = tc.settings.lastSpeed;
} }
target.playbackRate = tc.settings.speeds[target.src]; target.playbackRate = tc.settings.speeds[target.src];
}); });
@@ -140,7 +140,8 @@
var speed = this.getSpeed(); var speed = this.getSpeed();
this.speedIndicator.textContent = speed; this.speedIndicator.textContent = speed;
tc.settings.speeds[this.video.src] = speed; tc.settings.speeds[this.video.src] = speed;
chrome.storage.sync.set({'speed': speed}, function() { tc.settings.lastSpeed = speed;
chrome.storage.sync.set({'lastSpeed': speed}, function() {
console.log('Speed setting saved: ' + speed); console.log('Speed setting saved: ' + speed);
}); });
} }