joshpatra/videospeed
1
0
Fork 0
mirror of https://github.com/SoPat712/videospeed.git synced 2025-08-21 18:08:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix settings page, closes #9

Browse Source
This commit is contained in:
Ilya Grigorik
2014-08-25 13:19:38 -07:00
parent 0c2d90be98
commit e48fc969c0
2 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifest.json
View File

@@ -1,7 +1,7 @@
{ {
"name": "Video Speed Controller", "name": "Video Speed Controller",
"short_name": "videospeed", "short_name": "videospeed",
"version": "0.2.0", "version": "0.2.1",
"manifest_version": 2, "manifest_version": 2,
"description": "Speed up, slow down, and rewind any HTML5 video with quick shortcuts.", "description": "Speed up, slow down, and rewind any HTML5 video with quick shortcuts.",
"homepage_url": "https://github.com/igrigorik/videospeed", "homepage_url": "https://github.com/igrigorik/videospeed",

36
options.js
View File

@@ -2,7 +2,7 @@ function recordKeyPress(e) {
var normalizedChar = String.fromCharCode(e.keyCode).toUpperCase(); var normalizedChar = String.fromCharCode(e.keyCode).toUpperCase();
e.target.value = normalizedChar; e.target.value = normalizedChar;
e.target.keyCode = normalizedChar.charCodeAt(); e.target.keyCode = normalizedChar.charCodeAt();
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();
}; };
@@ -12,7 +12,7 @@ function inputFilterNumbersOnly(e) {
if (!/[\d\.]$/.test(char) || !/^\d+(\.\d*)?$/.test(e.target.value + char)) { if (!/[\d\.]$/.test(char) || !/^\d+(\.\d*)?$/.test(e.target.value + char)) {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();
} }
}; };
function inputFocus(e) { function inputFocus(e) {
@@ -30,14 +30,14 @@ function updateShortcutInputText(inputId, keyCode) {
// Saves options to chrome.storage // Saves options to chrome.storage
function save_options() { function save_options() {
var speedStep = document.getElementById('speedStep').value; var speedStep = document.getElementById('speedStep').value;
var rewindTime = document.getElementById('rewindTime').value; var rewindTime = document.getElementById('rewindTime').value;
var rewindKeyCode = document.getElementById('rewindKeyInput').keyCode; var rewindKeyCode = document.getElementById('rewindKeyInput').keyCode;
var slowerKeyCode = document.getElementById('slowerKeyInput').keyCode; var slowerKeyCode = document.getElementById('slowerKeyInput').keyCode;
var fasterKeyCode = document.getElementById('fasterKeyInput').keyCode; var fasterKeyCode = document.getElementById('fasterKeyInput').keyCode;
var rememberSpeed = document.getElementById('rememberSpeed').checked; var rememberSpeed = document.getElementById('rememberSpeed').checked;
speedStep = isNaN(speedStep) ? 0.1 : Number(speedStep); speedStep = isNaN(speedStep) ? 0.1 : Number(speedStep);
rewindTime = isNaN(rewindTime) ? 10 : Number(rewindTime); rewindTime = isNaN(rewindTime) ? 10 : Number(rewindTime);
rewindKeyCode = isNaN(rewindKeyCode) ? 65 : rewindKeyCode; rewindKeyCode = isNaN(rewindKeyCode) ? 65 : rewindKeyCode;
@@ -81,7 +81,6 @@ function restore_options() {
} }
function restore_defaults() { function restore_defaults() {
chrome.storage.sync.set({ chrome.storage.sync.set({
speedStep: 0.1, speedStep: 0.1,
rewindTime: 10, rewindTime: 10,
@@ -98,23 +97,24 @@ function restore_defaults() {
status.textContent = ''; status.textContent = '';
}, 1000); }, 1000);
}); });
} }
// Event Listeners
document.addEventListener('DOMContentLoaded', restore_options);
document.getElementById('save').addEventListener('click', save_options);
document.getElementById('restore').addEventListener('click', restore_defaults);
initShortcutInput('rewindKeyInput');
initShortcutInput('slowerKeyInput');
initShortcutInput('fasterKeyInput');
document.getElementById('rewindTime').addEventListener('keypress', inputFilterNumbersOnly);
document.getElementById('speedStep').addEventListener('keypress', inputFilterNumbersOnly);
function initShortcutInput(inputId) { function initShortcutInput(inputId) {
document.getElementById(inputId).addEventListener('focus', inputFocus); document.getElementById(inputId).addEventListener('focus', inputFocus);
document.getElementById(inputId).addEventListener('blur', inputBlur); document.getElementById(inputId).addEventListener('blur', inputBlur);
document.getElementById(inputId).addEventListener('keypress', recordKeyPress); document.getElementById(inputId).addEventListener('keypress', recordKeyPress);
} }
document.addEventListener('DOMContentLoaded', function () {
restore_options();
document.getElementById('save').addEventListener('click', save_options);
document.getElementById('restore').addEventListener('click', restore_defaults);
initShortcutInput('rewindKeyInput');
initShortcutInput('slowerKeyInput');
initShortcutInput('fasterKeyInput');
document.getElementById('rewindTime').addEventListener('keypress', inputFilterNumbersOnly);
document.getElementById('speedStep').addEventListener('keypress', inputFilterNumbersOnly);
})