From e85dad32809bbef77cdecf2c03ea9ceb2d59ae22 Mon Sep 17 00:00:00 2001 From: Ilya Grigorik Date: Thu, 8 Feb 2018 13:35:26 +0000 Subject: [PATCH] update audio+video min/max references Audio is no longer cutoff [1]. Video limits still in place. [1] https://developers.google.com/web/updates/2017/12/chrome-63-64-media-updates#remove-muting-extreme-playbackrates Closes #300. --- inject.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/inject.js b/inject.js index 8e62d92..41f9eb5 100644 --- a/inject.js +++ b/inject.js @@ -331,14 +331,12 @@ chrome.runtime.sendMessage({}, function(response) { v.currentTime += tc.settings.advanceTime; } else if (action === 'faster') { // Maximum playback speed in Chrome is set to 16: - // https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?l=103 + // https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp?l=168 var s = Math.min( (v.playbackRate < 0.1 ? 0.0 : v.playbackRate) + tc.settings.speedStep, 16); v.playbackRate = Number(s.toFixed(2)); } else if (action === 'slower') { - // Audio playback is cut at 0.05: - // https://cs.chromium.org/chromium/src/media/filters/audio_renderer_algorithm.cc?l=49 // Video min rate is 0.0625: - // https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?l=102 + // https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp?l=167 var s = Math.max(v.playbackRate - tc.settings.speedStep, 0.0625); v.playbackRate = Number(s.toFixed(2)); } else if (action === 'reset') {