From 823a24475cbfa7b4885cd27b7375197058f544c5 Mon Sep 17 00:00:00 2001 From: Timothy Lim Date: Fri, 11 Oct 2019 17:29:55 +0800 Subject: [PATCH 1/2] Add ability to disable website keybindings for show/hide controller --- inject.js | 7 +++++++ options.html | 4 ++++ options.js | 4 ++++ 3 files changed, 15 insertions(+) diff --git a/inject.js b/inject.js index ad831b4..8d213f7 100644 --- a/inject.js +++ b/inject.js @@ -6,6 +6,7 @@ speeds: {}, // empty object to hold speed for each source displayKeyCode: 86, // default: V + displayForce: false, rememberSpeed: false, // default: false audioBoolean: false, // default: false startHidden: false, // default: false @@ -74,6 +75,7 @@ keyBindings: tc.settings.keyBindings, version: tc.settings.version, displayKeyCode: tc.settings.displayKeyCode, + displayForce: tc.settings.displayForce, rememberSpeed: tc.settings.rememberSpeed, audioBoolean: tc.settings.audioBoolean, startHidden: tc.settings.startHidden, @@ -83,6 +85,7 @@ } tc.settings.lastSpeed = Number(storage.lastSpeed); tc.settings.displayKeyCode = Number(storage.displayKeyCode); + tc.settings.displayForce = String(storage.displayForce); tc.settings.rememberSpeed = Boolean(storage.rememberSpeed); tc.settings.audioBoolean = Boolean(storage.audioBoolean); tc.settings.startHidden = Boolean(storage.startHidden); @@ -360,6 +363,10 @@ if (keyCode == tc.settings.displayKeyCode) { runAction('display', document, true) + if (tc.settings.displayForce === "true") {// disable websites key bindings + event.preventDefault(); + event.stopPropagation(); + } } var item = tc.settings.keyBindings.find(item => item.key === keyCode); if (item) { diff --git a/options.html b/options.html index 102906f..1682d55 100644 --- a/options.html +++ b/options.html @@ -15,6 +15,10 @@
+
- -
+
+ + + +
@@ -120,6 +120,7 @@ function add_shortcut() { + @@ -150,20 +151,14 @@ function save_options() { keyBindings = []; Array.from(document.querySelectorAll(".customs")).forEach(item => createKeyBindings(item)); // Remove added shortcuts - var displayKeyCode = document.getElementById('displayKeyInput').keyCode; - var displayForce = document.getElementById('displayForce').value; var rememberSpeed = document.getElementById('rememberSpeed').checked; var audioBoolean = document.getElementById('audioBoolean').checked; var startHidden = document.getElementById('startHidden').checked; var controllerOpacity = document.getElementById('controllerOpacity').value; var blacklist = document.getElementById('blacklist').value; - displayKeyCode = isNaN(displayKeyCode) ? tcDefaults.displayKeyCode : displayKeyCode; - chrome.storage.sync.remove(["resetSpeed", "speedStep", "fastSpeed", "rewindTime", "advanceTime", "resetKeyCode", "slowerKeyCode", "fasterKeyCode", "rewindKeyCode", "advanceKeyCode", "fastKeyCode"]); chrome.storage.sync.set({ - displayKeyCode: displayKeyCode, - displayForce: displayForce, rememberSpeed: rememberSpeed, audioBoolean: audioBoolean, startHidden: startHidden, @@ -183,19 +178,29 @@ function save_options() { // Restores options from chrome.storage function restore_options() { chrome.storage.sync.get(tcDefaults, function(storage) { - updateShortcutInputText('displayKeyInput', storage.displayKeyCode); - document.getElementById('displayForce').value = storage.displayForce; document.getElementById('rememberSpeed').checked = storage.rememberSpeed; document.getElementById('audioBoolean').checked = storage.audioBoolean; document.getElementById('startHidden').checked = storage.startHidden; document.getElementById('controllerOpacity').value = storage.controllerOpacity; document.getElementById('blacklist').value = storage.blacklist; + // ensure that there is a "display" binding for upgrades from versions that had it as a separate binding + if(storage.keyBindings.filter(x => x.action == "display").length == 0){ + storage.keyBindings.push({ action: "display", value: 0, force: false, predefined: true }); + } + for (let i in storage.keyBindings) { var item = storage.keyBindings[i]; if (item.predefined) { //do predefined ones because their value needed for overlay // document.querySelector("#" + item["action"] + " .customDo").value = item["action"]; + if (item["action"] == "display" && typeof (item["key"]) === "undefined"){ + item["key"] = storage.displayKeyCode || tcDefaults.displayKeyCode; // V + } + + if (customActionsNoValues.includes(item["action"])) + document.querySelector("#" + item["action"] + " .customValue").disabled = true; + updateCustomShortcutInputText(document.querySelector("#" + item["action"] + " .customKey"), item["key"]); document.querySelector("#" + item["action"] + " .customValue").value = item["value"]; document.querySelector("#" + item["action"] + " .customForce").value = item["force"]; @@ -234,12 +239,6 @@ function show_experimental() { document.querySelectorAll(".customForce").forEach(item => item.style.display = 'inline-block'); } -function initShortcutInput(inputId) { - document.getElementById(inputId).addEventListener('focus', inputFocus); - document.getElementById(inputId).addEventListener('blur', inputBlur); - document.getElementById(inputId).addEventListener('keydown', recordKeyPress); -} - document.addEventListener('DOMContentLoaded', function () { restore_options(); @@ -248,8 +247,6 @@ document.addEventListener('DOMContentLoaded', function () { document.getElementById('restore').addEventListener('click', restore_defaults); document.getElementById('experimental').addEventListener('click', show_experimental); - initShortcutInput('displayKeyInput'); - function eventCaller(event, className, funcName) { if (!event.target.classList.contains(className)) { return