joshpatra/videospeed
1
0
Fork 0
mirror of https://github.com/SoPat712/videospeed.git synced 2025-08-21 18:08:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

use MutationRecord's target as fallback for parent

Browse Source
This commit is contained in:
Ilya Grigorik
2016-05-31 22:20:01 -07:00
parent cca8f80bc9
commit fe0ad6d861
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
inject.js
View File

@@ -30,8 +30,9 @@ chrome.extension.sendMessage({}, function(response) {
}); });
function defineVideoController() { function defineVideoController() {
tc.videoController = function(target) { tc.videoController = function(target, parent) {
this.video = target; this.video = target;
this.parent = target.parentElement || parent;
this.document = target.ownerDocument; this.document = target.ownerDocument;
if (!tc.settings.rememberSpeed) { if (!tc.settings.rememberSpeed) {
tc.settings.speed = 1.0; tc.settings.speed = 1.0;
@@ -127,7 +128,11 @@ chrome.extension.sendMessage({}, function(response) {
fragment.appendChild(container); fragment.appendChild(container);
this.video.classList.add('tc-initialized'); this.video.classList.add('tc-initialized');
this.video.parentElement.insertBefore(fragment, this.video);
// Note: when triggered via a MutationRecord, it's possible that the
// target is not the immediate parent. This appends the controller as
// the first element of the target, which may not be the parent.
this.parent.insertBefore(fragment, this.parent.firstChild);
var speed = parseFloat(tc.settings.speed).toFixed(2); var speed = parseFloat(tc.settings.speed).toFixed(2);
speedIndicator.textContent = speed; speedIndicator.textContent = speed;
@@ -197,21 +202,22 @@ chrome.extension.sendMessage({}, function(response) {
}, true); }, true);
var forEach = Array.prototype.forEach; var forEach = Array.prototype.forEach;
function checkForVideo(node) { function checkForVideo(node, parent) {
if (node.nodeName === 'VIDEO') { if (node.nodeName === 'VIDEO') {
if (!node.classList.contains('tc-initialized')) { if (!node.classList.contains('tc-initialized')) {
new tc.videoController(node); new tc.videoController(node, parent);
} }
} else if (node.children != undefined) { } else if (node.children != undefined) {
for (var i = 0; i < node.children.length; i++) { for (var i = 0; i < node.children.length; i++) {
checkForVideo(node.children[i]); checkForVideo(node.children[i],
node.children[i].parentNode || parent);
} }
} }
} }
var observer = new MutationObserver(function(mutations) { var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(mutation) { mutations.forEach(function(mutation) {
forEach.call(mutation.addedNodes, function(node) { forEach.call(mutation.addedNodes, function(node) {
checkForVideo(node); checkForVideo(node, node.parentNode || mutation.target);
}) })
}); });
}); });