Commit Graph

23 Commits

Author SHA1 Message Date
George Ogata
e75f4f0c60 Don't update our video speed setting before the video is loaded.
In this state, the playback rate is always 1, as we haven't had a chance
to update it yet (which currently happens in the play callback).

Fixes speed setting when jumping between YouTube videos.
2015-05-31 03:54:57 -04:00
George Ogata
7031049819 Update our speed setting when the speed is changed externally.
e.g. Coursera videos have their own speed controls. If the speed
is changed from A to B via their controls, then the video is
paused & resumed, our play callback would reset the speed to A.

We now ensure our speed setting is accurate by updating it in the
ratechange callback, which happens no matter how the speed is
updated.
2015-05-24 03:26:53 -04:00
Ilya Grigorik
42c357804d add shortcut to reset playback speed 2015-05-17 20:42:23 -07:00
Ilya Grigorik
9a7cd25d50 add explicit hide/close button 2015-05-14 23:42:12 -07:00
Jordan Burgess
215ef4742c Respect rememberSpeed setting
Playback was retaining the playback speed between videos even with the
‘remember speed’ setting unchecked.
2015-04-03 01:21:34 +01:00
Ilya Grigorik
87cf891531 set minimum speed to 0, closes #29 2015-03-30 11:09:59 -07:00
Ilya Grigorik
2e7308c2e9 improve speed init+save logic
- fix race between settings fetch + controller init
- ratechange is an observer
- set speed on controller init and 'play' events

Side effect: stored default is only updatable via VC controlls; if you
use other methods we will change settings for that playback but the
setting won't be persisted -- this is intentional / required behavior.

Closes #27, #23
2015-03-29 14:41:08 -07:00
Ilya Grigorik
214e296b04 set min/max on playback speed
Video playback range in Chrome: [0.0625, 16]
Audio playback range in Chrome: [0.05, 4]

Setting min to 0.05 and max to 16, since outside of this range you're
not getting audio or video.

closes #26
2015-03-29 11:03:11 -07:00
Ilya Grigorik
5758280776 remove speed change on rewind
Confuses too many people, can be accomplished with/via other shortcuts.

Closes #24.
2015-03-29 10:56:25 -07:00
Ilya Grigorik
e55c8884e5 beautify js 2014-11-30 10:44:33 -08:00
Chirag Bhatia
ec1874e550 Fixed unwanted keypress events when typing into input fields 2014-10-16 01:44:55 +05:30
Radu Filip
8240e35a02 Fixed negative playback speed on rewind 2014-08-17 01:09:43 +01:00
Radu Filip
8dd9d26af7 Minor adjustments
Changed the default value for Remember Playback Speed to 'false'
2014-08-16 17:55:29 +01:00
Radu Filip
e366a38355 Added "Remember Playback Speed" option
Option to control the use of the last video's playback speed for a newly
loaded video
2014-08-16 17:18:52 +01:00
Radu Filip
dfb86cd287 Options Page adjustments
Implemented the adjustments suggested by Ilya: default values
adjustments, input validation, UI
2014-08-16 11:53:34 +01:00
Radu Filip
d3ab0a194e Added Options Page
Added Options Page allowing user to customize shortcuts and other
parameters
2014-08-15 00:26:35 +01:00
Apoorv Saxena
81d4bc8797 updated functionality to save video speed via existing control panel video 2014-06-08 02:59:21 +05:30
Apoorv Saxena
4ec4a2d385 added functionality to allow user to save Video Speed in Chrome Sync Storage via Chrome Extensions's Browser Action and automated the process to apply user saved Video Speed to HTML5 videos 2014-06-06 03:54:15 +05:30
Jordan Burgess
aa9327b5c1 Limit min speed to 0.00 2014-05-30 11:25:53 +01:00
Jordan Burgess
913ad63f00 Rewind goes back 10s and slows down speed by 10 points instead of 20 2014-05-14 14:26:06 +01:00
Šime Vidas
3ddc4248f9 Fixed full screen issue on Vimeo 2014-03-03 22:08:16 +01:00
Šime Vidas
a8a976ce0b Fixed issue with double click 2014-03-03 21:19:19 +01:00
Ilya Grigorik
2965ec345d initial import 2014-03-02 14:44:20 -08:00