mirror of
https://github.com/SoPat712/allstarr.git
synced 2026-02-09 23:55:10 -05:00
Compare commits
315 Commits
main
...
7ff6dbbe7a
| Author | SHA1 | Date | |
|---|---|---|---|
|
7ff6dbbe7a
|
|||
|
e0dbd1d4fd
|
|||
|
328a6a0eea
|
|||
|
9abb53de1a
|
|||
|
349fb740a2
|
|||
|
b604d61039
|
|||
|
3b8d83b43e
|
|||
|
8555b67a38
|
|||
|
629e95ac30
|
|||
|
2153a24c86
|
|||
|
1ddb3954f3
|
|||
|
3319c9b21b
|
|||
|
8966fb1fa2
|
|||
|
3b24ef3e78
|
|||
|
dbeb060d52
|
|||
|
2155a287a5
|
|||
|
cb57b406c1
|
|||
|
e91833ebbb
|
|||
|
2e1577eb5a
|
|||
|
7cb722c396
|
|||
|
9dcaddb2db
|
|||
|
5766cf9f62
|
|||
|
a12d5ea3c9
|
|||
|
25bbf45cbb
|
|||
|
3fd13b855d
|
|||
|
d9c0b8bb54
|
|||
|
400ea31477
|
|||
|
b1cab0ddfc
|
|||
|
7cba915c5e
|
|||
|
dfd7d678e7
|
|||
|
4071f6d650
|
|||
|
d045b33afd
|
|||
|
4f74b34b9a
|
|||
|
b7417614b3
|
|||
|
72b1584d51
|
|||
|
4b289e4ddd
|
|||
|
07844cc9c5
|
|||
|
1601b96800
|
|||
|
7db66067f4
|
|||
|
f44d8652b4
|
|||
|
8fad6d8c4e
|
|||
|
d11b656b23
|
|||
|
cf1428d678
|
|||
|
030937b196
|
|||
|
f77281fd3d
|
|||
|
791a8b3fdb
|
|||
|
7311bbc04a
|
|||
|
696a2d56f2
|
|||
|
5680b9c7c9
|
|||
|
1d31784ff8
|
|||
|
10e58eced9
|
|||
|
0937fcf163
|
|||
|
506f39d606
|
|||
|
7bb7c6a40e
|
|||
|
3403f7a8c9
|
|||
|
3e5c57766b
|
|||
|
24c6219189
|
|||
|
ea21d5aa77
|
|||
|
ee84770397
|
|||
|
7ccb660299
|
|||
|
0793c4614b
|
|||
|
bf02dc5a57
|
|||
|
7938871556
|
|||
|
39f6893741
|
|||
|
cd4fd702fc
|
|||
|
038c3a9614
|
|||
|
6e966f9e0d
|
|||
|
b778b3d31e
|
|||
|
526a079368
|
|||
|
7a7b884af2
|
|||
|
6ab5e44112
|
|||
|
7c92515723
|
|||
|
8091d30602
|
|||
|
e7ff330625
|
|||
|
aadda9b873
|
|||
|
8a84237f13
|
|||
|
e3a118e578
|
|||
|
e17eee9bf3
|
|||
|
4229924f61
|
|||
|
a2a48f6ed9
|
|||
|
c7785b6488
|
|||
|
af03a53af5
|
|||
|
c1c2212b53
|
|||
|
17560f0d34
|
|||
|
6ab314f603
|
|||
|
64ac09becf
|
|||
|
a0bbb7cd4c
|
|||
|
4bd478e85c
|
|||
|
f7a88791e8
|
|||
|
9f8b3d65fb
|
|||
|
1a1f9e136f
|
|||
|
48f69b766d
|
|||
|
d619881b8e
|
|||
|
dccdb7b744
|
|||
|
f240423822
|
|||
|
1492778b14
|
|||
|
08af650d6c
|
|||
|
c44be48eb9
|
|||
|
b16d16c9c9
|
|||
|
e51d569d79
|
|||
|
363c9e6f1b
|
|||
|
f813fe9eeb
|
|||
|
ef0ee65160
|
|||
|
b3bfa16b93
|
|||
|
aa9b5c874d
|
|||
|
e3546425eb
|
|||
|
5646aa07ea
|
|||
|
7cdf7e3806
|
|||
|
fe9c1e17be
|
|||
|
63324def62
|
|||
|
ff72ae2395
|
|||
|
1a3134083b
|
|||
|
bd64f437cd
|
|||
|
5606706dc8
|
|||
|
79a9e4063d
|
|||
|
c33c85455f
|
|||
|
5af2bb1113
|
|||
|
2c1297ebec
|
|||
|
df7f11e769
|
|||
|
75c7acb745
|
|||
|
c7f6783fa2
|
|||
|
4c6406ef8f
|
|||
|
3ddf51924b
|
|||
|
3826f29019
|
|||
|
4036c739a3
|
|||
|
b7379e2fd4
|
|||
|
c9895f6d1a
|
|||
|
71c4241a8a
|
|||
|
ffed9a67f3
|
|||
|
a8d04b225b
|
|||
|
6abf0e0717
|
|||
|
8e7fc8b4ef
|
|||
|
b2c28d10f1
|
|||
|
a335997196
|
|||
|
590f8f76cb
|
|||
|
1532d74a20
|
|||
|
f5ce355747
|
|||
|
494b4bbbc2
|
|||
|
375e1894f3
|
|||
|
bbb0d9bb73
|
|||
|
0356f3c54d
|
|||
|
0c25d16e42
|
|||
|
4c3709113f
|
|||
|
12db8370a3
|
|||
|
64be6eddf4
|
|||
|
0980547848
|
|||
|
2bb1ffa581
|
|||
|
51702a544b
|
|||
|
d9375405a5
|
|||
|
83063f594a
|
|||
|
b40349206d
|
|||
|
8dbac23944
|
|||
|
9fb86d3839
|
|||
|
bb2bda1379
|
|||
|
e9f72efb01
|
|||
|
ab36a43892
|
|||
|
2ffb769a6f
|
|||
|
045c810abc
|
|||
|
4c55520ce0
|
|||
|
04079223c2
|
|||
|
1bb902d96a
|
|||
|
b5f3f54c8b
|
|||
|
3bcb60a09a
|
|||
|
ba78ed0883
|
|||
|
d0f26c0182
|
|||
|
91275a2835
|
|||
|
ccbc9cf859
|
|||
|
97975f1e08
|
|||
|
ff48891a5a
|
|||
|
273fac7a0a
|
|||
|
12436c2f9c
|
|||
|
2315d6ab9f
|
|||
|
6eaeee9a67
|
|||
|
9dd49a2f43
|
|||
|
2bc2816191
|
|||
|
1a2e160279
|
|||
|
4111b5228d
|
|||
|
82b480c47e
|
|||
|
0d246a8e74
|
|||
|
fc3a8134ca
|
|||
|
2f91457e52
|
|||
|
77774120bf
|
|||
|
936fa27aa7
|
|||
|
b90ce423d7
|
|||
|
5f038965a2
|
|||
|
229fa0bf65
|
|||
|
1aec76c3dd
|
|||
|
96b06d5d4f
|
|||
|
747d310375
|
|||
|
fc78a095a9
|
|||
|
65ca80f9a0
|
|||
|
8e6eb5cc4a
|
|||
|
1326f1b3ab
|
|||
|
0011538966
|
|||
|
5acdacf132
|
|||
|
cef836da43
|
|||
|
26c9a72def
|
|||
|
f5124bdda2
|
|||
|
f7f57e711c
|
|||
|
76f633afce
|
|||
|
24df910ffa
|
|||
|
eb46692b25
|
|||
|
c54a32ccfc
|
|||
|
c0c7668cc4
|
|||
|
e860bbe0ee
|
|||
|
df3cc51e17
|
|||
|
027aeab969
|
|||
|
449bcc2561
|
|||
|
8da0bef481
|
|||
|
ae8afa20f8
|
|||
|
da1d28d292
|
|||
|
7e0ea501fc
|
|||
|
bb976fed4f
|
|||
|
df77b16640
|
|||
|
74ae85338c
|
|||
|
72b7198f1d
|
|||
|
b24dfb5b6a
|
|||
|
85f8e1cc5f
|
|||
|
74bd64c949
|
|||
|
1afa68064e
|
|||
|
5251c7ef6d
|
|||
|
63ab25ca91
|
|||
|
628f845e77
|
|||
|
8ef5ee7d8f
|
|||
|
fb3ea1b876
|
|||
|
3f3e1b708d
|
|||
|
bc4faead74
|
|||
|
6ffa2a3277
|
|||
|
c3c01b5559
|
|||
|
47d59ec0f5
|
|||
|
e7f72cd87a
|
|||
|
6d15d02f16
|
|||
|
3137cc4657
|
|||
|
18e700d6a4
|
|||
|
2420cd9a23
|
|||
|
65d6eb041a
|
|||
|
103808f079
|
|||
|
cd29e0de6c
|
|||
|
bd480be382
|
|||
|
293f6f5cc4
|
|||
|
e9b893eb3e
|
|||
|
51694a395d
|
|||
|
32166061ef
|
|||
|
a8845a9ef3
|
|||
|
e873cfe3bf
|
|||
|
43718eaefc
|
|||
|
5f9451f5b4
|
|||
|
2c3ef5c360
|
|||
|
4ba2245876
|
|||
|
c117fa41f6
|
|||
|
2b078453b2
|
|||
|
0ee1883ccb
|
|||
|
8912758b5e
|
|||
|
35d5249843
|
|||
|
62bfb367bc
|
|||
|
6f91361966
|
|||
|
d4036095f1
|
|||
|
6620b39357
|
|||
|
dcaa89171a
|
|||
|
1889dc6e19
|
|||
|
615ad58bc6
|
|||
|
6176777d0f
|
|||
|
a339574f05
|
|||
|
67b4fac64c
|
|||
|
ada6653bd1
|
|||
|
df8dbfc5e1
|
|||
|
e8d3fc4d17
|
|||
|
649351f68b
|
|||
|
3487f79b5e
|
|||
|
3a3f572ead
|
|||
|
d7f15fc3ab
|
|||
|
e43f5cd427
|
|||
|
1b79138923
|
|||
|
dda9736f8d
|
|||
|
9493cb48a5
|
|||
|
6c2453896f
|
|||
|
40594dea7e
|
|||
|
a06bf42887
|
|||
|
6713007650
|
|||
|
e7724c2cc0
|
|||
|
3358fe019d
|
|||
|
9efc54857f
|
|||
|
fcdf47984c
|
|||
|
040a5451a1
|
|||
|
8d76e97449
|
|||
|
a86a8013e6
|
|||
|
4c557a0325
|
|||
|
8540a22846
|
|||
|
36a224bd45
|
|||
|
3af3ebb52b
|
|||
|
614adb9892
|
|||
|
f434f13a19
|
|||
|
625a75f8f9
|
|||
|
d600c5e456
|
|||
|
e23e22a736
|
|||
|
ba0fe35e72
|
|||
|
6e9fe0e69e
|
|||
|
cba955c427
|
|||
|
192173ea64
|
|||
|
c33180abd7
|
|||
|
680454e76e
|
|||
|
34bfc20d28
|
|||
|
489159b424
|
|||
|
2bb754b245
|
|||
|
8d8c0892a2
|
|||
|
e12851e9ca
|
|||
|
f8969bea8d
|
|||
|
ceaa17f018
|
|||
|
9aa7ceb138
|
|||
|
72b1ebc2eb
|
|||
|
48a0351862
|
|||
|
4b95f9910c
|
|||
|
80424a867d
|
|||
|
4afd769602
|
|||
|
b47a5f9063
|
41
.env.example
41
.env.example
@@ -18,30 +18,28 @@ SUBSONIC_URL=http://localhost:4533
|
|||||||
# Server URL (required if using Jellyfin backend)
|
# Server URL (required if using Jellyfin backend)
|
||||||
JELLYFIN_URL=http://localhost:8096
|
JELLYFIN_URL=http://localhost:8096
|
||||||
|
|
||||||
# API key for SERVER-SIDE operations only (get from Jellyfin Dashboard > API Keys)
|
# API key for authentication (get from Jellyfin Dashboard > API Keys)
|
||||||
# This is used by Allstarr to query Jellyfin's library on behalf of the server
|
|
||||||
# CLIENT authentication is handled transparently - clients authenticate directly with Jellyfin
|
|
||||||
JELLYFIN_API_KEY=
|
JELLYFIN_API_KEY=
|
||||||
|
|
||||||
# User ID for SERVER-SIDE library queries (get from Jellyfin Dashboard > Users > click user > check URL)
|
# User ID (get from Jellyfin Dashboard > Users > click user > check URL)
|
||||||
# This determines which user's library Allstarr queries when searching/browsing
|
|
||||||
JELLYFIN_USER_ID=
|
JELLYFIN_USER_ID=
|
||||||
|
|
||||||
# Music library ID (optional, auto-detected if not set)
|
# Music library ID (optional, auto-detected if not set)
|
||||||
# If you have multiple libraries, set this to filter to music only
|
|
||||||
JELLYFIN_LIBRARY_ID=
|
JELLYFIN_LIBRARY_ID=
|
||||||
|
|
||||||
# ===== MUSIC SOURCE SELECTION =====
|
# ===== MUSIC SOURCE SELECTION =====
|
||||||
# Music service to use: SquidWTF, Deezer, or Qobuz (default: SquidWTF)
|
# Music service to use: SquidWTF, Deezer, or Qobuz (default: SquidWTF)
|
||||||
MUSIC_SERVICE=SquidWTF
|
MUSIC_SERVICE=SquidWTF
|
||||||
|
|
||||||
# Base directory for all downloads (default: ./downloads)
|
# Path where downloaded songs will be stored on the host (only applies if STORAGE_MODE=Permanent)
|
||||||
# This creates three subdirectories:
|
|
||||||
# - downloads/permanent/ - Permanently downloaded tracks (STORAGE_MODE=Permanent)
|
|
||||||
# - downloads/cache/ - Temporarily cached tracks (STORAGE_MODE=Cache)
|
|
||||||
# - downloads/kept/ - Favorited external tracks (always permanent)
|
|
||||||
DOWNLOAD_PATH=./downloads
|
DOWNLOAD_PATH=./downloads
|
||||||
|
|
||||||
|
# Path where favorited external tracks are permanently kept
|
||||||
|
KEPT_PATH=./kept
|
||||||
|
|
||||||
|
# Path for cache files (Spotify missing tracks, etc.)
|
||||||
|
CACHE_PATH=./cache
|
||||||
|
|
||||||
# ===== SQUIDWTF CONFIGURATION =====
|
# ===== SQUIDWTF CONFIGURATION =====
|
||||||
# Different quality options for SquidWTF. Only FLAC supported right now
|
# Different quality options for SquidWTF. Only FLAC supported right now
|
||||||
SQUIDWTF_QUALITY=FLAC
|
SQUIDWTF_QUALITY=FLAC
|
||||||
@@ -110,14 +108,27 @@ CACHE_DURATION_HOURS=1
|
|||||||
|
|
||||||
# ===== SPOTIFY PLAYLIST INJECTION (JELLYFIN ONLY) =====
|
# ===== SPOTIFY PLAYLIST INJECTION (JELLYFIN ONLY) =====
|
||||||
# REQUIRES: Jellyfin Spotify Import Plugin (https://github.com/Viperinius/jellyfin-plugin-spotify-import)
|
# REQUIRES: Jellyfin Spotify Import Plugin (https://github.com/Viperinius/jellyfin-plugin-spotify-import)
|
||||||
# This feature intercepts Spotify Import plugin playlists and fills them with tracks from external providers
|
# This feature intercepts Spotify Import plugin playlists (Release Radar, Discover Weekly) and fills them
|
||||||
|
# with tracks auto-matched from external providers (SquidWTF, Deezer, Qobuz)
|
||||||
# Uses JELLYFIN_URL and JELLYFIN_API_KEY configured above (no separate credentials needed)
|
# Uses JELLYFIN_URL and JELLYFIN_API_KEY configured above (no separate credentials needed)
|
||||||
|
|
||||||
# Enable Spotify playlist injection (optional, default: false)
|
# Enable Spotify playlist injection (optional, default: false)
|
||||||
SPOTIFY_IMPORT_ENABLED=false
|
SPOTIFY_IMPORT_ENABLED=false
|
||||||
|
|
||||||
|
# Sync schedule: When does the Spotify Import plugin run?
|
||||||
|
# Set these to match your plugin's sync schedule in Jellyfin
|
||||||
|
# Example: If plugin runs daily at 4:15 PM, set HOUR=16 and MINUTE=15
|
||||||
|
SPOTIFY_IMPORT_SYNC_START_HOUR=16
|
||||||
|
SPOTIFY_IMPORT_SYNC_START_MINUTE=15
|
||||||
|
|
||||||
|
# Sync window: How long to search for missing tracks files (in hours)
|
||||||
|
# The fetcher will check every 5 minutes within this window
|
||||||
|
# Example: If plugin runs at 4:15 PM and window is 2 hours, checks from 4:00 PM to 6:00 PM
|
||||||
|
SPOTIFY_IMPORT_SYNC_WINDOW_HOURS=2
|
||||||
|
|
||||||
# Matching interval: How often to run track matching (in hours)
|
# Matching interval: How often to run track matching (in hours)
|
||||||
# Spotify playlists like Discover Weekly update once per week, Release Radar updates weekly
|
# Spotify playlists like Discover Weekly update once per week, Release Radar updates weekly
|
||||||
|
# Most playlists don't change frequently, so running once per day is reasonable
|
||||||
# Set to 0 to only run once on startup (manual trigger via admin UI still works)
|
# Set to 0 to only run once on startup (manual trigger via admin UI still works)
|
||||||
# Default: 24 hours
|
# Default: 24 hours
|
||||||
SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS=24
|
SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS=24
|
||||||
@@ -176,9 +187,3 @@ SPOTIFY_API_RATE_LIMIT_DELAY_MS=100
|
|||||||
# Prefer ISRC matching over fuzzy title/artist matching (default: true)
|
# Prefer ISRC matching over fuzzy title/artist matching (default: true)
|
||||||
# ISRC provides exact track identification across different streaming services
|
# ISRC provides exact track identification across different streaming services
|
||||||
SPOTIFY_API_PREFER_ISRC_MATCHING=true
|
SPOTIFY_API_PREFER_ISRC_MATCHING=true
|
||||||
|
|
||||||
# Spotify Lyrics API URL (default: http://spotify-lyrics:8080)
|
|
||||||
# Uses the spotify-lyrics-api sidecar service for fetching synchronized lyrics
|
|
||||||
# This service is automatically started in docker-compose
|
|
||||||
# Leave as default unless running a custom deployment
|
|
||||||
SPOTIFY_LYRICS_API_URL=http://spotify-lyrics:8080
|
|
||||||
|
|||||||
15
.gitignore
vendored
15
.gitignore
vendored
@@ -84,19 +84,15 @@ cache/
|
|||||||
redis-data/
|
redis-data/
|
||||||
|
|
||||||
# API keys and specs (ignore markdown docs, keep OpenAPI spec)
|
# API keys and specs (ignore markdown docs, keep OpenAPI spec)
|
||||||
apis/steering/
|
|
||||||
apis/api-calls/*.json
|
|
||||||
!apis/api-calls/jellyfin-openapi-stable.json
|
|
||||||
apis/temp.json
|
|
||||||
|
|
||||||
# Temporary documentation files
|
|
||||||
apis/*.md
|
apis/*.md
|
||||||
|
apis/*.json
|
||||||
|
!apis/jellyfin-openapi-stable.json
|
||||||
|
|
||||||
# Log files for debugging
|
# Log files for debugging
|
||||||
apis/api-calls/*.log
|
apis/*.log
|
||||||
|
|
||||||
# Endpoint usage tracking
|
# Endpoint usage tracking
|
||||||
apis/api-calls/endpoint-usage.json
|
apis/endpoint-usage.json
|
||||||
/app/cache/endpoint-usage/
|
/app/cache/endpoint-usage/
|
||||||
|
|
||||||
# Original source code for reference
|
# Original source code for reference
|
||||||
@@ -104,6 +100,3 @@ originals/
|
|||||||
|
|
||||||
# Sample missing playlists for Spotify integration testing
|
# Sample missing playlists for Spotify integration testing
|
||||||
sampleMissingPlaylists/
|
sampleMissingPlaylists/
|
||||||
|
|
||||||
# Migration guide (local only)
|
|
||||||
MIGRATION.md
|
|
||||||
331
README.md
331
README.md
@@ -5,7 +5,11 @@
|
|||||||
[](https://github.com/SoPat712/allstarr/pkgs/container/allstarr)
|
[](https://github.com/SoPat712/allstarr/pkgs/container/allstarr)
|
||||||
[](LICENSE)
|
[](LICENSE)
|
||||||
|
|
||||||
A media server proxy that integrates music streaming providers with your local library. Works with **Jellyfin** and **Subsonic-compatible** servers. When a song isn't in your local library, it gets fetched from your configured provider, downloaded, and served to your client. The downloaded song then lives in your library for next time.
|
A media server proxy that integrates music streaming providers with your local library. Works with **Jellyfin** and **Subsonic-compatible** servers (Navidrome). When a song isn't in your local library, it gets fetched from your configured provider, downloaded, and served to your client. The downloaded song then lives in your library for next time.
|
||||||
|
|
||||||
|
**THIS IS UNDER ACTIVE DEVELOPMENT**
|
||||||
|
|
||||||
|
Please report all bugs as soon as possible, as the Jellyfin addition is entirely a test at this point
|
||||||
|
|
||||||
## Quick Start
|
## Quick Start
|
||||||
|
|
||||||
@@ -36,15 +40,15 @@ The proxy will be available at `http://localhost:5274`.
|
|||||||
|
|
||||||
## Web Dashboard
|
## Web Dashboard
|
||||||
|
|
||||||
Allstarr includes a web UI for easy configuration and playlist management, accessible at `http://localhost:5275`
|
Allstarr includes a web-based dashboard for easy configuration and playlist management, accessible at `http://localhost:5275` (internal port, not exposed through reverse proxy).
|
||||||
|
|
||||||
### Features
|
### Features
|
||||||
|
|
||||||
- **Playlist Management**: Link Jellyfin playlists to Spotify playlists with just a few clicks
|
- **Real-time Status**: Monitor Spotify authentication, cookie age, and playlist sync status
|
||||||
- **Provider Matching**: It should fill in the gaps of your Jellyfin library with tracks from your selected provider
|
- **Playlist Management**: Link Jellyfin playlists to Spotify playlists with a few clicks
|
||||||
- **WebUI**: Update settings without manually editing .env files
|
- **Configuration Editor**: Update settings without manually editing .env files
|
||||||
- **Music**: Using multiple sources for music (optimized for SquidWTF right now, though)
|
- **Track Viewer**: Browse tracks in your configured playlists
|
||||||
- **Lyrics**: Using multiple sources for lyrics, first Jellyfin Lyrics, then Spotify Lyrics, then LrcLib as a last resort
|
- **Cache Management**: Clear cached data and restart the container
|
||||||
|
|
||||||
### Quick Setup with Web UI
|
### Quick Setup with Web UI
|
||||||
|
|
||||||
@@ -61,20 +65,18 @@ Allstarr includes a web UI for easy configuration and playlist management, acces
|
|||||||
- `37i9dQZF1DXcBWIGoYBM5M` (just the ID)
|
- `37i9dQZF1DXcBWIGoYBM5M` (just the ID)
|
||||||
- `spotify:playlist:37i9dQZF1DXcBWIGoYBM5M` (Spotify URI)
|
- `spotify:playlist:37i9dQZF1DXcBWIGoYBM5M` (Spotify URI)
|
||||||
- `https://open.spotify.com/playlist/37i9dQZF1DXcBWIGoYBM5M` (full URL)
|
- `https://open.spotify.com/playlist/37i9dQZF1DXcBWIGoYBM5M` (full URL)
|
||||||
4. **Restart** to apply changes (should be a banner)
|
4. **Restart** to apply changes (button in Configuration tab)
|
||||||
|
|
||||||
Then, proceeed to **Active Playlists**, which shows you which Spotify playlists are currently being monitored and filled with tracks, and lets you do a bunch of useful operations on them.
|
### Why Two Playlist Tabs?
|
||||||
|
|
||||||
|
- **Link Playlists**: Shows all Jellyfin playlists and lets you connect them to Spotify
|
||||||
|
- **Active Playlists**: Shows which Spotify playlists are currently being monitored and filled with tracks
|
||||||
|
|
||||||
### Configuration Persistence
|
### Configuration Persistence
|
||||||
|
|
||||||
The web UI updates your `.env` file directly. Changes persist across container restarts, but require a restart to take effect. In development mode, the `.env` file is in your project root. In Docker, it's at `/app/.env`.
|
The web UI updates your `.env` file directly. Changes persist across container restarts, but require a restart to take effect. In development mode, the `.env` file is in your project root. In Docker, it's at `/app/.env`.
|
||||||
|
|
||||||
There's an environment variable to modify this.
|
**Recommended workflow**: Use the `sp_dc` cookie method (simpler and more reliable than the Jellyfin Spotify Import plugin).
|
||||||
|
|
||||||
|
|
||||||
**Recommended workflow**: Use the `sp_dc` cookie method alongside the [Spotify Import Plugin](https://github.com/Viperinius/jellyfin-plugin-spotify-import?tab=readme-ov-file).
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
### Nginx Proxy Setup (Required)
|
### Nginx Proxy Setup (Required)
|
||||||
|
|
||||||
@@ -140,7 +142,6 @@ This project brings together all the music streaming providers into one unified
|
|||||||
|
|
||||||
- [Feishin](https://github.com/jeffvli/feishin) (Mac/Windows/Linux)
|
- [Feishin](https://github.com/jeffvli/feishin) (Mac/Windows/Linux)
|
||||||
- [Musiver](https://music.aqzscn.cn/en/) (Android/IOS/Windows/Android)
|
- [Musiver](https://music.aqzscn.cn/en/) (Android/IOS/Windows/Android)
|
||||||
- [Finamp](https://github.com/jmshrv/finamp) ()
|
|
||||||
|
|
||||||
_Working on getting more currently_
|
_Working on getting more currently_
|
||||||
|
|
||||||
@@ -334,7 +335,7 @@ Subsonic__EnableExternalPlaylists=false
|
|||||||
|
|
||||||
### Spotify Playlist Injection (Jellyfin Only)
|
### Spotify Playlist Injection (Jellyfin Only)
|
||||||
|
|
||||||
Allstarr automatically fills your Spotify playlists (like Release Radar and Discover Weekly) with tracks from your configured streaming provider (SquidWTF, Deezer, or Qobuz). This works by intercepting playlists created by the Jellyfin Spotify Import plugin and matching missing tracks with your streaming service.
|
Allstarr can automatically fill your Spotify playlists (like Release Radar and Discover Weekly) with tracks from your configured streaming provider (SquidWTF, Deezer, or Qobuz). This feature works by intercepting playlists created by the Jellyfin Spotify Import plugin and matching missing tracks with your streaming service.
|
||||||
|
|
||||||
#### Prerequisites
|
#### Prerequisites
|
||||||
|
|
||||||
@@ -348,112 +349,136 @@ Allstarr automatically fills your Spotify playlists (like Release Radar and Disc
|
|||||||
- Go to Jellyfin Dashboard → Plugins → Spotify Import
|
- Go to Jellyfin Dashboard → Plugins → Spotify Import
|
||||||
- Connect your Spotify account
|
- Connect your Spotify account
|
||||||
- Select which playlists to sync (e.g., Release Radar, Discover Weekly)
|
- Select which playlists to sync (e.g., Release Radar, Discover Weekly)
|
||||||
- Set a sync schedule (the plugin will create playlists in Jellyfin)
|
- Set a daily sync schedule (e.g., 4:15 PM daily)
|
||||||
|
- The plugin will create playlists in Jellyfin and generate "missing tracks" files for songs not in your library
|
||||||
|
|
||||||
3. **Configure Allstarr**
|
3. **Configure Allstarr**
|
||||||
- Enable Spotify Import in Allstarr (see configuration below)
|
- Allstarr needs to know when the plugin runs and which playlists to intercept
|
||||||
- Link your Jellyfin playlists to Spotify playlists via the Web UI
|
- Uses your existing `JELLYFIN_URL` and `JELLYFIN_API_KEY` settings (no additional credentials needed)
|
||||||
- Uses your existing `JELLYFIN_URL` and `JELLYFIN_API_KEY` settings
|
|
||||||
|
|
||||||
#### Configuration
|
#### Configuration
|
||||||
|
|
||||||
| Setting | Description |
|
| Setting | Description |
|
||||||
|---------|-------------|
|
|---------|-------------|
|
||||||
| `SpotifyImport:Enabled` | Enable Spotify playlist injection (default: `false`) |
|
| `SpotifyImport:Enabled` | Enable Spotify playlist injection (default: `false`) |
|
||||||
| `SpotifyImport:MatchingIntervalHours` | How often to run track matching in hours (default: 24, set to 0 for startup only) |
|
| `SpotifyImport:SyncStartHour` | Hour when the Spotify Import plugin runs (24-hour format, 0-23) |
|
||||||
| `SpotifyImport:Playlists` | JSON array of playlists (managed via Web UI) |
|
| `SpotifyImport:SyncStartMinute` | Minute when the plugin runs (0-59) |
|
||||||
|
| `SpotifyImport:SyncWindowHours` | Hours to search for missing tracks files after sync time (default: 2) |
|
||||||
|
| `SpotifyImport:PlaylistIds` | Comma-separated Jellyfin playlist IDs to intercept |
|
||||||
|
| `SpotifyImport:PlaylistNames` | Comma-separated playlist names (must match order of IDs) |
|
||||||
|
|
||||||
**Environment variables example:**
|
**Environment variables example:**
|
||||||
```bash
|
```bash
|
||||||
# Enable the feature
|
# Enable the feature
|
||||||
SPOTIFY_IMPORT_ENABLED=true
|
SPOTIFY_IMPORT_ENABLED=true
|
||||||
|
|
||||||
# Matching interval (24 hours = once per day)
|
# Sync window settings (optional - used to prevent fetching too frequently)
|
||||||
SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS=24
|
# The fetcher searches backwards from current time for the last 48 hours
|
||||||
|
SPOTIFY_IMPORT_SYNC_START_HOUR=16
|
||||||
|
SPOTIFY_IMPORT_SYNC_START_MINUTE=15
|
||||||
|
SPOTIFY_IMPORT_SYNC_WINDOW_HOURS=2
|
||||||
|
|
||||||
# Playlists (use Web UI to manage instead of editing manually)
|
# Get playlist IDs from Jellyfin URLs: https://jellyfin.example.com/web/#/details?id=PLAYLIST_ID
|
||||||
SPOTIFY_IMPORT_PLAYLISTS=[["Discover Weekly","37i9dQZEVXcV6s7Dm7RXsU","first"],["Release Radar","37i9dQZEVXbng2vDHnfQlC","first"]]
|
SPOTIFY_IMPORT_PLAYLIST_IDS=ba50e26c867ec9d57ab2f7bf24cfd6b0,4383a46d8bcac3be2ef9385053ea18df
|
||||||
|
|
||||||
|
# Names must match exactly as they appear in Jellyfin (used to find missing tracks files)
|
||||||
|
SPOTIFY_IMPORT_PLAYLIST_NAMES=Release Radar,Discover Weekly
|
||||||
```
|
```
|
||||||
|
|
||||||
#### How It Works
|
#### How It Works
|
||||||
|
|
||||||
1. **Spotify Import Plugin Runs**
|
1. **Spotify Import Plugin Runs** (e.g., daily at 4:15 PM)
|
||||||
- Plugin fetches your Spotify playlists
|
- Plugin fetches your Spotify playlists
|
||||||
- Creates/updates playlists in Jellyfin with tracks already in your library
|
- Creates/updates playlists in Jellyfin with tracks already in your library
|
||||||
- Generates "missing tracks" JSON files for songs not found locally
|
- Generates "missing tracks" JSON files for songs not found locally
|
||||||
|
- Files are named like: `Release Radar_missing_2026-02-01_16-15.json`
|
||||||
|
|
||||||
2. **Allstarr Matches Tracks** (on startup + every 24 hours by default)
|
2. **Allstarr Fetches Missing Tracks** (within sync window)
|
||||||
- Reads missing tracks files from the Jellyfin plugin
|
- Searches for missing tracks files from the Jellyfin plugin
|
||||||
|
- Searches **+24 hours forward first** (newest files), then **-48 hours backward** if not found
|
||||||
|
- This efficiently finds the most recent file regardless of timezone differences
|
||||||
|
- Example: Server time 12 PM EST, file timestamped 9 PM UTC (same day) → Found in forward search
|
||||||
|
- Caches the list of missing tracks in Redis + file cache
|
||||||
|
- Runs automatically on startup (if needed) and every 5 minutes during the sync window
|
||||||
|
|
||||||
|
3. **Allstarr Matches Tracks** (2 minutes after startup, then configurable interval)
|
||||||
- For each missing track, searches your streaming provider (SquidWTF, Deezer, or Qobuz)
|
- For each missing track, searches your streaming provider (SquidWTF, Deezer, or Qobuz)
|
||||||
- Uses fuzzy matching to find the best match (title + artist similarity)
|
- Uses fuzzy matching to find the best match (title + artist similarity)
|
||||||
- Rate-limited to avoid overwhelming the service (150ms delay between searches)
|
- Rate-limited to avoid overwhelming the service (150ms delay between searches)
|
||||||
- Pre-builds playlist cache for instant loading
|
- Caches matched results for 1 hour
|
||||||
|
- **Pre-builds playlist items cache** for instant serving (no "on the fly" building)
|
||||||
|
- Default interval: 24 hours (configurable via `SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS`)
|
||||||
|
- Set to 0 to only run once on startup (manual trigger via admin UI still works)
|
||||||
|
|
||||||
3. **You Open the Playlist in Jellyfin**
|
4. **You Open the Playlist in Jellyfin**
|
||||||
- Allstarr intercepts the request
|
- Allstarr intercepts the request
|
||||||
- Returns a merged list: local tracks + matched streaming tracks
|
- Returns a merged list: local tracks + matched streaming tracks
|
||||||
- Loads instantly from cache!
|
- Loads instantly from cache (no searching needed!)
|
||||||
|
|
||||||
4. **You Play a Track**
|
5. **You Play a Track**
|
||||||
- Local tracks stream from Jellyfin normally
|
- If it's a local track, streams from Jellyfin normally
|
||||||
- Matched tracks download from streaming provider on-demand
|
- If it's a matched track, downloads from streaming provider on-demand
|
||||||
- Downloaded tracks are saved to your library for future use
|
- Downloaded tracks are saved to your library for future use
|
||||||
|
|
||||||
#### Manual API Triggers
|
#### Manual Triggers
|
||||||
|
|
||||||
You can manually trigger operations via the admin API:
|
You can manually trigger syncing and matching via API:
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
# Get API key from your .env file
|
|
||||||
API_KEY="your-api-key-here"
|
|
||||||
|
|
||||||
# Fetch missing tracks from Jellyfin plugin
|
# Fetch missing tracks from Jellyfin plugin
|
||||||
curl "http://localhost:5274/spotify/sync?api_key=$API_KEY"
|
curl "https://your-jellyfin-proxy.com/spotify/sync?api_key=YOUR_API_KEY"
|
||||||
|
|
||||||
# Trigger track matching (searches streaming provider)
|
# Trigger track matching (searches streaming provider)
|
||||||
curl "http://localhost:5274/spotify/match?api_key=$API_KEY"
|
curl "https://your-jellyfin-proxy.com/spotify/match?api_key=YOUR_API_KEY"
|
||||||
|
|
||||||
# Match all playlists (refresh all matches)
|
# Clear cache to force re-matching
|
||||||
curl "http://localhost:5274/spotify/match-all?api_key=$API_KEY"
|
curl "https://your-jellyfin-proxy.com/spotify/clear-cache?api_key=YOUR_API_KEY"
|
||||||
|
|
||||||
# Clear cache and rebuild
|
|
||||||
curl "http://localhost:5274/spotify/clear-cache?api_key=$API_KEY"
|
|
||||||
|
|
||||||
# Refresh specific playlist
|
|
||||||
curl "http://localhost:5274/spotify/refresh-playlist?playlistId=PLAYLIST_ID&api_key=$API_KEY"
|
|
||||||
```
|
```
|
||||||
|
|
||||||
#### Web UI Management
|
#### Startup Behavior
|
||||||
|
|
||||||
The easiest way to manage Spotify playlists is through the Web UI at `http://localhost:5275`:
|
When Allstarr starts with Spotify Import enabled:
|
||||||
|
|
||||||
1. **Link Playlists Tab**: Link Jellyfin playlists to Spotify playlists
|
**Smart Cache Check:**
|
||||||
2. **Active Playlists Tab**: View status, trigger matching, and manage playlists
|
- Checks if today's sync window has passed (e.g., if sync is at 4 PM + 2 hour window = 6 PM)
|
||||||
3. **Configuration Tab**: Enable/disable Spotify Import and adjust settings
|
- If before 6 PM and yesterday's cache exists → **Skips fetch** (cache is still current)
|
||||||
|
- If after 6 PM or no cache exists → **Fetches missing tracks** from Jellyfin plugin
|
||||||
|
|
||||||
|
**Track Matching:**
|
||||||
|
- **T+2min**: Matches tracks with streaming provider (with rate limiting)
|
||||||
|
- Only matches playlists that don't already have cached matches
|
||||||
|
- **Result**: Playlists load instantly when you open them!
|
||||||
|
|
||||||
|
**Example Timeline:**
|
||||||
|
- Plugin runs daily at 4:15 PM, creates files at ~4:16 PM
|
||||||
|
- You restart Allstarr at 12:00 PM (noon) the next day
|
||||||
|
- Startup check: "Today's sync window ends at 6 PM, and I have yesterday's 4:16 PM file"
|
||||||
|
- **Decision**: Skip fetch, use existing cache
|
||||||
|
- At 6:01 PM: Next scheduled check will search for new files
|
||||||
|
|
||||||
#### Troubleshooting
|
#### Troubleshooting
|
||||||
|
|
||||||
**Playlists are empty:**
|
**Playlists are empty:**
|
||||||
- Check that the Spotify Import plugin is running and creating playlists
|
- Check that the Spotify Import plugin is running and creating playlists
|
||||||
- Verify playlists are linked in the Web UI
|
- Verify `SPOTIFY_IMPORT_PLAYLIST_IDS` match your Jellyfin playlist IDs
|
||||||
- Check logs: `docker-compose logs -f allstarr | grep -i spotify`
|
- Check logs: `docker-compose logs -f allstarr | grep -i spotify`
|
||||||
|
|
||||||
**Tracks aren't matching:**
|
**Tracks aren't matching:**
|
||||||
- Ensure your streaming provider is configured (`MUSIC_SERVICE`, credentials)
|
- Ensure your streaming provider is configured (`MUSIC_SERVICE`, credentials)
|
||||||
- Manually trigger matching via Web UI or API
|
- Check that playlist names in `SPOTIFY_IMPORT_PLAYLIST_NAMES` match exactly
|
||||||
- Check that the Jellyfin plugin generated missing tracks files
|
- Manually trigger matching: `curl "https://your-proxy.com/spotify/match?api_key=KEY"`
|
||||||
|
|
||||||
**Performance:**
|
**Sync timing issues:**
|
||||||
- Matching runs in background with rate limiting (150ms between searches)
|
- Set `SPOTIFY_IMPORT_SYNC_START_HOUR/MINUTE` to match your plugin schedule
|
||||||
- First match may take a few minutes for large playlists
|
- Increase `SPOTIFY_IMPORT_SYNC_WINDOW_HOURS` if files aren't being found
|
||||||
- Subsequent loads are instant (served from cache)
|
- Check Jellyfin plugin logs to confirm when it runs
|
||||||
|
|
||||||
#### Notes
|
#### Notes
|
||||||
|
|
||||||
- Uses your existing `JELLYFIN_URL` and `JELLYFIN_API_KEY` settings
|
- This feature uses your existing `JELLYFIN_URL` and `JELLYFIN_API_KEY` settings
|
||||||
- Matched tracks cached for fast loading
|
- Matched tracks are cached for 1 hour to avoid repeated searches
|
||||||
- Missing tracks cache persists across restarts (Redis + file cache)
|
- Missing tracks cache persists across restarts (stored in Redis + file cache)
|
||||||
- Rate limiting prevents overwhelming your streaming provider
|
- Rate limiting prevents overwhelming your streaming provider (150ms between searches)
|
||||||
- Only works with Jellyfin backend (not Subsonic/Navidrome)
|
- Only works with Jellyfin backend (not Subsonic/Navidrome)
|
||||||
|
|
||||||
### Getting Credentials
|
### Getting Credentials
|
||||||
@@ -567,46 +592,9 @@ If you prefer to run Allstarr without Docker:
|
|||||||
|
|
||||||
## API Endpoints
|
## API Endpoints
|
||||||
|
|
||||||
### Jellyfin Backend (Primary Focus)
|
|
||||||
|
|
||||||
The proxy provides comprehensive Jellyfin API support with streaming provider integration:
|
|
||||||
|
|
||||||
| Endpoint | Description |
|
|
||||||
|----------|-------------|
|
|
||||||
| `GET /Items` | Search and browse library items (local + streaming providers) |
|
|
||||||
| `GET /Artists` | Browse artists with merged results from local + streaming |
|
|
||||||
| `GET /Artists/AlbumArtists` | Album artists with streaming provider results |
|
|
||||||
| `GET /Users/{userId}/Items` | User library items with external content |
|
|
||||||
| `GET /Audio/{id}/stream` | Stream audio, downloading from provider on-demand |
|
|
||||||
| `GET /Audio/{id}/Lyrics` | Lyrics from Jellyfin, Spotify, or LRCLib |
|
|
||||||
| `GET /Items/{id}/Images/{type}` | Proxy cover art for external content |
|
|
||||||
| `GET /Playlists/{id}/Items` | Playlist items (Spotify Import integration) |
|
|
||||||
| `POST /UserFavoriteItems/{id}` | Favorite items; copies external tracks to kept folder |
|
|
||||||
| `DELETE /UserFavoriteItems/{id}` | Unfavorite items |
|
|
||||||
| `POST /Sessions/Playing` | Playback reporting for external tracks |
|
|
||||||
| `POST /Sessions/Playing/Progress` | Playback progress tracking |
|
|
||||||
| `POST /Sessions/Playing/Stopped` | Playback stopped reporting |
|
|
||||||
| `WebSocket /socket` | Real-time session management and remote control |
|
|
||||||
|
|
||||||
**Admin API (Port 5275):**
|
|
||||||
| Endpoint | Description |
|
|
||||||
|----------|-------------|
|
|
||||||
| `GET /api/config` | Get current configuration |
|
|
||||||
| `POST /api/config` | Update configuration |
|
|
||||||
| `GET /api/playlists` | List Spotify Import playlists |
|
|
||||||
| `POST /api/playlists/link` | Link Jellyfin playlist to Spotify |
|
|
||||||
| `DELETE /api/playlists/{id}` | Unlink playlist |
|
|
||||||
| `POST /spotify/sync` | Fetch missing tracks from Jellyfin plugin |
|
|
||||||
| `POST /spotify/match` | Trigger track matching |
|
|
||||||
| `POST /spotify/match-all` | Match all playlists |
|
|
||||||
| `POST /spotify/clear-cache` | Clear playlist cache |
|
|
||||||
| `POST /spotify/refresh-playlist` | Refresh specific playlist |
|
|
||||||
|
|
||||||
All other Jellyfin API endpoints are passed through unchanged.
|
|
||||||
|
|
||||||
### Subsonic Backend
|
### Subsonic Backend
|
||||||
|
|
||||||
The proxy implements the Subsonic API with streaming provider integration:
|
The proxy implements the Subsonic API and adds transparent streaming provider integration:
|
||||||
|
|
||||||
| Endpoint | Description |
|
| Endpoint | Description |
|
||||||
|----------|-------------|
|
|----------|-------------|
|
||||||
@@ -620,6 +608,20 @@ The proxy implements the Subsonic API with streaming provider integration:
|
|||||||
|
|
||||||
All other Subsonic API endpoints are passed through to Navidrome unchanged.
|
All other Subsonic API endpoints are passed through to Navidrome unchanged.
|
||||||
|
|
||||||
|
### Jellyfin Backend
|
||||||
|
|
||||||
|
The proxy implements a subset of the Jellyfin API:
|
||||||
|
|
||||||
|
| Endpoint | Description |
|
||||||
|
|----------|-------------|
|
||||||
|
| `GET /Items` | Search and browse library items |
|
||||||
|
| `GET /Artists` | Browse artists with streaming provider results |
|
||||||
|
| `GET /Audio/{id}/stream` | Stream audio, downloading from provider if needed |
|
||||||
|
| `GET /Items/{id}/Images/{type}` | Proxy cover art for external content |
|
||||||
|
| `POST /UserFavoriteItems/{id}` | Favorite items; triggers playlist download |
|
||||||
|
|
||||||
|
All other Jellyfin API endpoints are passed through unchanged.
|
||||||
|
|
||||||
## External ID Format
|
## External ID Format
|
||||||
|
|
||||||
External (streaming provider) content uses typed IDs:
|
External (streaming provider) content uses typed IDs:
|
||||||
@@ -634,37 +636,25 @@ Legacy format `ext-deezer-{id}` is also supported (assumes song type).
|
|||||||
|
|
||||||
## Download Folder Structure
|
## Download Folder Structure
|
||||||
|
|
||||||
All downloads are organized under a single base directory (default: `./downloads`):
|
Downloaded music is organized as:
|
||||||
|
|
||||||
```
|
```
|
||||||
downloads/
|
downloads/
|
||||||
├── permanent/ # Permanent downloads (STORAGE_MODE=Permanent)
|
├── Artist Name/
|
||||||
│ ├── Artist Name/
|
│ ├── Album Title/
|
||||||
│ │ ├── Album Title/
|
│ │ ├── 01 - Track One.mp3
|
||||||
│ │ │ ├── 01 - Track One.flac
|
│ │ ├── 02 - Track Two.mp3
|
||||||
│ │ │ ├── 02 - Track Two.flac
|
|
||||||
│ │ │ └── ...
|
|
||||||
│ │ └── Another Album/
|
|
||||||
│ │ └── ...
|
│ │ └── ...
|
||||||
│ └── playlists/
|
│ └── Another Album/
|
||||||
│ ├── My Favorite Songs.m3u
|
│ └── ...
|
||||||
│ └── Chill Vibes.m3u
|
├── Another Artist/
|
||||||
├── cache/ # Temporary cache (STORAGE_MODE=Cache)
|
│ └── ...
|
||||||
│ └── Artist Name/
|
└── playlists/
|
||||||
│ └── Album Title/
|
├── My Favorite Songs.m3u
|
||||||
│ └── Track.flac
|
├── Chill Vibes.m3u
|
||||||
└── kept/ # Favorited external tracks (always permanent)
|
└── ...
|
||||||
└── Artist Name/
|
|
||||||
└── Album Title/
|
|
||||||
└── Track.flac
|
|
||||||
```
|
```
|
||||||
|
|
||||||
**Storage modes:**
|
Playlists are stored as M3U files with relative paths to downloaded tracks, making them portable and compatible with most music players.
|
||||||
- **Permanent** (`downloads/permanent/`): Files saved permanently and registered in your media server
|
|
||||||
- **Cache** (`downloads/cache/`): Temporary files, auto-cleaned after `CACHE_DURATION_HOURS`
|
|
||||||
- **Kept** (`downloads/kept/`): External tracks you've favorited - always permanent, separate from cache
|
|
||||||
|
|
||||||
Playlists are stored as M3U files with relative paths, making them portable and compatible with most music players.
|
|
||||||
|
|
||||||
## Metadata Embedding
|
## Metadata Embedding
|
||||||
|
|
||||||
@@ -695,17 +685,10 @@ dotnet test
|
|||||||
```
|
```
|
||||||
allstarr/
|
allstarr/
|
||||||
├── Controllers/
|
├── Controllers/
|
||||||
│ ├── AdminController.cs # Admin dashboard API
|
│ ├── JellyfinController.cs # Jellyfin API controller (registered when Backend:Type=Jellyfin)
|
||||||
│ ├── JellyfinController.cs # Jellyfin API controller
|
│ └── SubsonicController.cs # Subsonic API controller (registered when Backend:Type=Subsonic)
|
||||||
│ └── SubsonicController.cs # Subsonic API controller
|
|
||||||
├── Filters/
|
|
||||||
│ ├── AdminPortFilter.cs # Admin port access control
|
|
||||||
│ ├── ApiKeyAuthFilter.cs # API key authentication
|
|
||||||
│ └── JellyfinAuthFilter.cs # Jellyfin authentication
|
|
||||||
├── Middleware/
|
├── Middleware/
|
||||||
│ ├── AdminStaticFilesMiddleware.cs # Admin UI static file serving
|
│ └── GlobalExceptionHandler.cs # Global error handling
|
||||||
│ ├── GlobalExceptionHandler.cs # Global error handling
|
|
||||||
│ └── WebSocketProxyMiddleware.cs # WebSocket proxying for Jellyfin
|
|
||||||
├── Models/
|
├── Models/
|
||||||
│ ├── Domain/ # Domain entities
|
│ ├── Domain/ # Domain entities
|
||||||
│ │ ├── Song.cs
|
│ │ ├── Song.cs
|
||||||
@@ -714,39 +697,18 @@ allstarr/
|
|||||||
│ ├── Settings/ # Configuration models
|
│ ├── Settings/ # Configuration models
|
||||||
│ │ ├── SubsonicSettings.cs
|
│ │ ├── SubsonicSettings.cs
|
||||||
│ │ ├── DeezerSettings.cs
|
│ │ ├── DeezerSettings.cs
|
||||||
│ │ ├── QobuzSettings.cs
|
│ │ └── QobuzSettings.cs
|
||||||
│ │ ├── SquidWTFSettings.cs
|
|
||||||
│ │ ├── SpotifyApiSettings.cs
|
|
||||||
│ │ ├── SpotifyImportSettings.cs
|
|
||||||
│ │ ├── MusicBrainzSettings.cs
|
|
||||||
│ │ └── RedisSettings.cs
|
|
||||||
│ ├── Download/ # Download-related models
|
│ ├── Download/ # Download-related models
|
||||||
│ │ ├── DownloadInfo.cs
|
│ │ ├── DownloadInfo.cs
|
||||||
│ │ └── DownloadStatus.cs
|
│ │ └── DownloadStatus.cs
|
||||||
│ ├── Lyrics/
|
|
||||||
│ │ └── LyricsInfo.cs
|
|
||||||
│ ├── Search/
|
│ ├── Search/
|
||||||
│ │ └── SearchResult.cs
|
│ │ └── SearchResult.cs
|
||||||
│ ├── Spotify/
|
|
||||||
│ │ ├── MissingTrack.cs
|
|
||||||
│ │ └── SpotifyPlaylistTrack.cs
|
|
||||||
│ └── Subsonic/
|
│ └── Subsonic/
|
||||||
│ ├── ExternalPlaylist.cs
|
|
||||||
│ └── ScanStatus.cs
|
│ └── ScanStatus.cs
|
||||||
├── Services/
|
├── Services/
|
||||||
│ ├── Common/ # Shared services
|
│ ├── Common/ # Shared services
|
||||||
│ │ ├── BaseDownloadService.cs # Template method base class
|
│ │ ├── BaseDownloadService.cs # Template method base class
|
||||||
│ │ ├── CacheCleanupService.cs # Cache cleanup background service
|
|
||||||
│ │ ├── CacheWarmingService.cs # Startup cache warming
|
|
||||||
│ │ ├── EndpointBenchmarkService.cs # Endpoint performance benchmarking
|
|
||||||
│ │ ├── FuzzyMatcher.cs # Fuzzy string matching
|
|
||||||
│ │ ├── GenreEnrichmentService.cs # MusicBrainz genre enrichment
|
|
||||||
│ │ ├── OdesliService.cs # Odesli/song.link conversion
|
|
||||||
│ │ ├── ParallelMetadataService.cs # Parallel metadata fetching
|
|
||||||
│ │ ├── PathHelper.cs # Path utilities
|
│ │ ├── PathHelper.cs # Path utilities
|
||||||
│ │ ├── PlaylistIdHelper.cs # Playlist ID helpers
|
|
||||||
│ │ ├── RedisCacheService.cs # Redis caching
|
|
||||||
│ │ ├── RoundRobinFallbackHelper.cs # Load balancing and failover
|
|
||||||
│ │ ├── Result.cs # Result<T> pattern
|
│ │ ├── Result.cs # Result<T> pattern
|
||||||
│ │ └── Error.cs # Error types
|
│ │ └── Error.cs # Error types
|
||||||
│ ├── Deezer/ # Deezer provider
|
│ ├── Deezer/ # Deezer provider
|
||||||
@@ -758,35 +720,12 @@ allstarr/
|
|||||||
│ │ ├── QobuzMetadataService.cs
|
│ │ ├── QobuzMetadataService.cs
|
||||||
│ │ ├── QobuzBundleService.cs
|
│ │ ├── QobuzBundleService.cs
|
||||||
│ │ └── QobuzStartupValidator.cs
|
│ │ └── QobuzStartupValidator.cs
|
||||||
│ ├── SquidWTF/ # SquidWTF provider
|
|
||||||
│ │ ├── SquidWTFDownloadService.cs
|
|
||||||
│ │ ├── SquidWTFMetadataService.cs
|
|
||||||
│ │ └── SquidWTFStartupValidator.cs
|
|
||||||
│ ├── Jellyfin/ # Jellyfin integration
|
|
||||||
│ │ ├── JellyfinModelMapper.cs # Model mapping
|
|
||||||
│ │ ├── JellyfinProxyService.cs # Request proxying
|
|
||||||
│ │ ├── JellyfinResponseBuilder.cs # Response building
|
|
||||||
│ │ ├── JellyfinSessionManager.cs # Session management
|
|
||||||
│ │ └── JellyfinStartupValidator.cs # Startup validation
|
|
||||||
│ ├── Lyrics/ # Lyrics services
|
|
||||||
│ │ ├── LrclibService.cs # LRCLIB lyrics
|
|
||||||
│ │ ├── LyricsPrefetchService.cs # Background lyrics prefetching
|
|
||||||
│ │ ├── LyricsStartupValidator.cs # Lyrics validation
|
|
||||||
│ │ └── SpotifyLyricsService.cs # Spotify lyrics
|
|
||||||
│ ├── MusicBrainz/
|
|
||||||
│ │ └── MusicBrainzService.cs # MusicBrainz metadata
|
|
||||||
│ ├── Spotify/ # Spotify integration
|
|
||||||
│ │ ├── SpotifyApiClient.cs # Spotify API client
|
|
||||||
│ │ ├── SpotifyMissingTracksFetcher.cs # Missing tracks fetcher
|
|
||||||
│ │ ├── SpotifyPlaylistFetcher.cs # Playlist fetcher
|
|
||||||
│ │ └── SpotifyTrackMatchingService.cs # Track matching
|
|
||||||
│ ├── Local/ # Local library
|
│ ├── Local/ # Local library
|
||||||
│ │ ├── ILocalLibraryService.cs
|
│ │ ├── ILocalLibraryService.cs
|
||||||
│ │ └── LocalLibraryService.cs
|
│ │ └── LocalLibraryService.cs
|
||||||
│ ├── Subsonic/ # Subsonic API logic
|
│ ├── Subsonic/ # Subsonic API logic
|
||||||
│ │ ├── PlaylistSyncService.cs # Playlist synchronization
|
|
||||||
│ │ ├── SubsonicModelMapper.cs # Model mapping
|
|
||||||
│ │ ├── SubsonicProxyService.cs # Request proxying
|
│ │ ├── SubsonicProxyService.cs # Request proxying
|
||||||
|
│ │ ├── SubsonicModelMapper.cs # Model mapping
|
||||||
│ │ ├── SubsonicRequestParser.cs # Request parsing
|
│ │ ├── SubsonicRequestParser.cs # Request parsing
|
||||||
│ │ └── SubsonicResponseBuilder.cs # Response building
|
│ │ └── SubsonicResponseBuilder.cs # Response building
|
||||||
│ ├── Validation/ # Startup validation
|
│ ├── Validation/ # Startup validation
|
||||||
@@ -798,17 +737,13 @@ allstarr/
|
|||||||
│ ├── IDownloadService.cs # Download interface
|
│ ├── IDownloadService.cs # Download interface
|
||||||
│ ├── IMusicMetadataService.cs # Metadata interface
|
│ ├── IMusicMetadataService.cs # Metadata interface
|
||||||
│ └── StartupValidationService.cs
|
│ └── StartupValidationService.cs
|
||||||
├── wwwroot/ # Admin UI static files
|
|
||||||
│ ├── index.html # Admin dashboard
|
|
||||||
│ └── placeholder.png # Placeholder image
|
|
||||||
├── Program.cs # Application entry point
|
├── Program.cs # Application entry point
|
||||||
└── appsettings.json # Configuration
|
└── appsettings.json # Configuration
|
||||||
|
|
||||||
allstarr.Tests/
|
allstarr.Tests/
|
||||||
├── DeezerDownloadServiceTests.cs # Deezer download tests
|
├── DeezerDownloadServiceTests.cs # Deezer download tests
|
||||||
├── DeezerMetadataServiceTests.cs # Deezer metadata tests
|
├── DeezerMetadataServiceTests.cs # Deezer metadata tests
|
||||||
├── JellyfinResponseStructureTests.cs # Jellyfin response tests
|
├── QobuzDownloadServiceTests.cs # Qobuz download tests (127 tests)
|
||||||
├── QobuzDownloadServiceTests.cs # Qobuz download tests
|
|
||||||
├── LocalLibraryServiceTests.cs # Local library tests
|
├── LocalLibraryServiceTests.cs # Local library tests
|
||||||
├── SubsonicModelMapperTests.cs # Model mapping tests
|
├── SubsonicModelMapperTests.cs # Model mapping tests
|
||||||
├── SubsonicProxyServiceTests.cs # Proxy service tests
|
├── SubsonicProxyServiceTests.cs # Proxy service tests
|
||||||
@@ -882,7 +817,7 @@ We welcome contributions! Here's how to get started:
|
|||||||
- Follow existing code patterns and conventions
|
- Follow existing code patterns and conventions
|
||||||
- Add tests for new features
|
- Add tests for new features
|
||||||
- Update documentation as needed
|
- Update documentation as needed
|
||||||
- Keep commits feature focused
|
- Keep commits focused and atomic
|
||||||
|
|
||||||
### Testing
|
### Testing
|
||||||
|
|
||||||
@@ -904,14 +839,8 @@ GPL-3.0
|
|||||||
|
|
||||||
## Acknowledgments
|
## Acknowledgments
|
||||||
|
|
||||||
- [octo-fiesta](https://github.com/V1ck3s/octo-fiesta) - The original
|
|
||||||
- [octo-fiestarr](https://github.com/bransoned/octo-fiestarr) - The fork that introduced me to this idea based on the above
|
|
||||||
- [Jellyfin Spotify Import Plugin](https://github.com/Viperinius/jellyfin-plugin-spotify-import?tab=readme-ov-file) - The plugin that I **strongly** recommend using alongside this repo
|
|
||||||
- [Jellyfin](https://jellyfin.org/) - The free and open-source media server
|
|
||||||
- [Navidrome](https://www.navidrome.org/) - The excellent self-hosted music server
|
- [Navidrome](https://www.navidrome.org/) - The excellent self-hosted music server
|
||||||
- [Subsonic API](http://www.subsonic.org/pages/api.jsp) - The API specification
|
- [Jellyfin](https://jellyfin.org/) - The free and open-source media server
|
||||||
- [Hi-Fi API](https://github.com/binimum/hifi-api) - These people do some great work, and you should thank them for this even existing!
|
|
||||||
- [Deezer](https://www.deezer.com/) - Music streaming service
|
- [Deezer](https://www.deezer.com/) - Music streaming service
|
||||||
- [Qobuz](https://www.qobuz.com/) - Hi-Res music streaming service
|
- [Qobuz](https://www.qobuz.com/) - Hi-Res music streaming service
|
||||||
- [spotify-lyrics-api](https://github.com/akashrchandran/spotify-lyrics-api) - Thank them for the fact that we have access to Spotify's lyrics!
|
- [Subsonic API](http://www.subsonic.org/pages/api.jsp) - The API specification
|
||||||
- [LRCLIB](https://github.com/tranxuanthang/lrclib) - The GOATS for giving us a free api for lyrics! They power LRCGET, which I'm sure some of you have heard of
|
|
||||||
|
|||||||
@@ -28,7 +28,6 @@ public class AdminController : ControllerBase
|
|||||||
private readonly SpotifyApiSettings _spotifyApiSettings;
|
private readonly SpotifyApiSettings _spotifyApiSettings;
|
||||||
private readonly SpotifyImportSettings _spotifyImportSettings;
|
private readonly SpotifyImportSettings _spotifyImportSettings;
|
||||||
private readonly JellyfinSettings _jellyfinSettings;
|
private readonly JellyfinSettings _jellyfinSettings;
|
||||||
private readonly SubsonicSettings _subsonicSettings;
|
|
||||||
private readonly DeezerSettings _deezerSettings;
|
private readonly DeezerSettings _deezerSettings;
|
||||||
private readonly QobuzSettings _qobuzSettings;
|
private readonly QobuzSettings _qobuzSettings;
|
||||||
private readonly SquidWTFSettings _squidWtfSettings;
|
private readonly SquidWTFSettings _squidWtfSettings;
|
||||||
@@ -53,7 +52,6 @@ public class AdminController : ControllerBase
|
|||||||
IOptions<SpotifyApiSettings> spotifyApiSettings,
|
IOptions<SpotifyApiSettings> spotifyApiSettings,
|
||||||
IOptions<SpotifyImportSettings> spotifyImportSettings,
|
IOptions<SpotifyImportSettings> spotifyImportSettings,
|
||||||
IOptions<JellyfinSettings> jellyfinSettings,
|
IOptions<JellyfinSettings> jellyfinSettings,
|
||||||
IOptions<SubsonicSettings> subsonicSettings,
|
|
||||||
IOptions<DeezerSettings> deezerSettings,
|
IOptions<DeezerSettings> deezerSettings,
|
||||||
IOptions<QobuzSettings> qobuzSettings,
|
IOptions<QobuzSettings> qobuzSettings,
|
||||||
IOptions<SquidWTFSettings> squidWtfSettings,
|
IOptions<SquidWTFSettings> squidWtfSettings,
|
||||||
@@ -71,7 +69,6 @@ public class AdminController : ControllerBase
|
|||||||
_spotifyApiSettings = spotifyApiSettings.Value;
|
_spotifyApiSettings = spotifyApiSettings.Value;
|
||||||
_spotifyImportSettings = spotifyImportSettings.Value;
|
_spotifyImportSettings = spotifyImportSettings.Value;
|
||||||
_jellyfinSettings = jellyfinSettings.Value;
|
_jellyfinSettings = jellyfinSettings.Value;
|
||||||
_subsonicSettings = subsonicSettings.Value;
|
|
||||||
_deezerSettings = deezerSettings.Value;
|
_deezerSettings = deezerSettings.Value;
|
||||||
_qobuzSettings = qobuzSettings.Value;
|
_qobuzSettings = qobuzSettings.Value;
|
||||||
_squidWtfSettings = squidWtfSettings.Value;
|
_squidWtfSettings = squidWtfSettings.Value;
|
||||||
@@ -91,6 +88,8 @@ public class AdminController : ControllerBase
|
|||||||
_envFilePath = _environment.IsDevelopment()
|
_envFilePath = _environment.IsDevelopment()
|
||||||
? Path.Combine(_environment.ContentRootPath, "..", ".env")
|
? Path.Combine(_environment.ContentRootPath, "..", ".env")
|
||||||
: "/app/.env";
|
: "/app/.env";
|
||||||
|
|
||||||
|
_logger.LogInformation("Admin controller initialized. .env path: {EnvFilePath}", _envFilePath);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static List<string> DecodeSquidWtfUrls()
|
private static List<string> DecodeSquidWtfUrls()
|
||||||
@@ -166,7 +165,8 @@ public class AdminController : ControllerBase
|
|||||||
spotifyImport = new
|
spotifyImport = new
|
||||||
{
|
{
|
||||||
enabled = _spotifyImportSettings.Enabled,
|
enabled = _spotifyImportSettings.Enabled,
|
||||||
matchingIntervalHours = _spotifyImportSettings.MatchingIntervalHours,
|
syncTime = $"{_spotifyImportSettings.SyncStartHour:D2}:{_spotifyImportSettings.SyncStartMinute:D2}",
|
||||||
|
syncWindowHours = _spotifyImportSettings.SyncWindowHours,
|
||||||
playlistCount = _spotifyImportSettings.Playlists.Count
|
playlistCount = _spotifyImportSettings.Playlists.Count
|
||||||
},
|
},
|
||||||
deezer = new
|
deezer = new
|
||||||
@@ -211,40 +211,8 @@ public class AdminController : ControllerBase
|
|||||||
/// Get list of configured playlists with their current data
|
/// Get list of configured playlists with their current data
|
||||||
/// </summary>
|
/// </summary>
|
||||||
[HttpGet("playlists")]
|
[HttpGet("playlists")]
|
||||||
public async Task<IActionResult> GetPlaylists([FromQuery] bool refresh = false)
|
public async Task<IActionResult> GetPlaylists()
|
||||||
{
|
{
|
||||||
var playlistCacheFile = "/app/cache/admin_playlists_summary.json";
|
|
||||||
|
|
||||||
// Check file cache first (5 minute TTL) unless refresh is requested
|
|
||||||
if (!refresh && System.IO.File.Exists(playlistCacheFile))
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var fileInfo = new FileInfo(playlistCacheFile);
|
|
||||||
var age = DateTime.UtcNow - fileInfo.LastWriteTimeUtc;
|
|
||||||
|
|
||||||
if (age.TotalMinutes < 5)
|
|
||||||
{
|
|
||||||
var cachedJson = await System.IO.File.ReadAllTextAsync(playlistCacheFile);
|
|
||||||
var cachedData = JsonSerializer.Deserialize<Dictionary<string, object>>(cachedJson);
|
|
||||||
_logger.LogDebug("📦 Returning cached playlist summary (age: {Age:F1}m)", age.TotalMinutes);
|
|
||||||
return Ok(cachedData);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogDebug("🔄 Cache expired (age: {Age:F1}m), refreshing...", age.TotalMinutes);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogWarning(ex, "Failed to read cached playlist summary");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else if (refresh)
|
|
||||||
{
|
|
||||||
_logger.LogInformation("🔄 Force refresh requested for playlist summary");
|
|
||||||
}
|
|
||||||
|
|
||||||
var playlists = new List<object>();
|
var playlists = new List<object>();
|
||||||
|
|
||||||
// Read playlists directly from .env file to get the latest configuration
|
// Read playlists directly from .env file to get the latest configuration
|
||||||
@@ -374,37 +342,12 @@ public class AdminController : ControllerBase
|
|||||||
|
|
||||||
foreach (var item in cachedPlaylistItems)
|
foreach (var item in cachedPlaylistItems)
|
||||||
{
|
{
|
||||||
// Check if it's external by looking for external provider in ProviderIds
|
// Check if it's external by looking for ProviderIds (external songs have this)
|
||||||
// External providers: SquidWTF, Deezer, Qobuz, Tidal
|
|
||||||
var isExternal = false;
|
var isExternal = false;
|
||||||
|
|
||||||
if (item.TryGetValue("ProviderIds", out var providerIdsObj) && providerIdsObj != null)
|
if (item.TryGetValue("ProviderIds", out var providerIdsObj) && providerIdsObj != null)
|
||||||
{
|
{
|
||||||
// Handle both Dictionary<string, string> and JsonElement
|
// Has ProviderIds = external track
|
||||||
Dictionary<string, string>? providerIds = null;
|
isExternal = true;
|
||||||
|
|
||||||
if (providerIdsObj is Dictionary<string, string> dict)
|
|
||||||
{
|
|
||||||
providerIds = dict;
|
|
||||||
}
|
|
||||||
else if (providerIdsObj is JsonElement jsonEl && jsonEl.ValueKind == JsonValueKind.Object)
|
|
||||||
{
|
|
||||||
providerIds = new Dictionary<string, string>();
|
|
||||||
foreach (var prop in jsonEl.EnumerateObject())
|
|
||||||
{
|
|
||||||
providerIds[prop.Name] = prop.Value.GetString() ?? "";
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (providerIds != null)
|
|
||||||
{
|
|
||||||
// Check for external provider keys (not MusicBrainz, ISRC, Spotify, etc)
|
|
||||||
isExternal = providerIds.Keys.Any(k =>
|
|
||||||
k.Equals("SquidWTF", StringComparison.OrdinalIgnoreCase) ||
|
|
||||||
k.Equals("Deezer", StringComparison.OrdinalIgnoreCase) ||
|
|
||||||
k.Equals("Qobuz", StringComparison.OrdinalIgnoreCase) ||
|
|
||||||
k.Equals("Tidal", StringComparison.OrdinalIgnoreCase));
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if (isExternal)
|
if (isExternal)
|
||||||
@@ -469,31 +412,9 @@ public class AdminController : ControllerBase
|
|||||||
foreach (var track in spotifyTracks)
|
foreach (var track in spotifyTracks)
|
||||||
{
|
{
|
||||||
var isLocal = false;
|
var isLocal = false;
|
||||||
var hasExternalMapping = false;
|
|
||||||
|
|
||||||
// FIRST: Check for manual Jellyfin mapping
|
if (localTracks.Count > 0)
|
||||||
var manualMappingKey = $"spotify:manual-map:{config.Name}:{track.SpotifyId}";
|
|
||||||
var manualJellyfinId = await _cache.GetAsync<string>(manualMappingKey);
|
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(manualJellyfinId))
|
|
||||||
{
|
{
|
||||||
// Manual Jellyfin mapping exists - this track is definitely local
|
|
||||||
isLocal = true;
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
// Check for external manual mapping
|
|
||||||
var externalMappingKey = $"spotify:external-map:{config.Name}:{track.SpotifyId}";
|
|
||||||
var externalMappingJson = await _cache.GetStringAsync(externalMappingKey);
|
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(externalMappingJson))
|
|
||||||
{
|
|
||||||
// External manual mapping exists
|
|
||||||
hasExternalMapping = true;
|
|
||||||
}
|
|
||||||
else if (localTracks.Count > 0)
|
|
||||||
{
|
|
||||||
// SECOND: No manual mapping, try fuzzy matching with local tracks
|
|
||||||
var bestMatch = localTracks
|
var bestMatch = localTracks
|
||||||
.Select(local => new
|
.Select(local => new
|
||||||
{
|
{
|
||||||
@@ -517,7 +438,6 @@ public class AdminController : ControllerBase
|
|||||||
isLocal = true;
|
isLocal = true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
if (isLocal)
|
if (isLocal)
|
||||||
{
|
{
|
||||||
@@ -525,8 +445,8 @@ public class AdminController : ControllerBase
|
|||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
// Check if external track is matched (either manual mapping or auto-matched)
|
// Check if external track is matched
|
||||||
if (hasExternalMapping || matchedSpotifyIds.Contains(track.SpotifyId))
|
if (matchedSpotifyIds.Contains(track.SpotifyId))
|
||||||
{
|
{
|
||||||
externalMatchedCount++;
|
externalMatchedCount++;
|
||||||
}
|
}
|
||||||
@@ -570,25 +490,55 @@ public class AdminController : ControllerBase
|
|||||||
_logger.LogWarning("Playlist {Name} has no JellyfinId configured", config.Name);
|
_logger.LogWarning("Playlist {Name} has no JellyfinId configured", config.Name);
|
||||||
}
|
}
|
||||||
|
|
||||||
playlists.Add(playlistInfo);
|
// Get lyrics completion status
|
||||||
}
|
|
||||||
|
|
||||||
// Save to file cache
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
var cacheDir = "/app/cache";
|
var tracks = await _playlistFetcher.GetPlaylistTracksAsync(config.Name);
|
||||||
Directory.CreateDirectory(cacheDir);
|
if (tracks.Count > 0)
|
||||||
var cacheFile = Path.Combine(cacheDir, "admin_playlists_summary.json");
|
{
|
||||||
|
var lyricsWithCount = 0;
|
||||||
|
var lyricsWithoutCount = 0;
|
||||||
|
|
||||||
var response = new { playlists };
|
foreach (var track in tracks)
|
||||||
var json = JsonSerializer.Serialize(response, new JsonSerializerOptions { WriteIndented = false });
|
{
|
||||||
await System.IO.File.WriteAllTextAsync(cacheFile, json);
|
var cacheKey = $"lyrics:{track.PrimaryArtist}:{track.Title}:{track.Album}:{track.DurationMs / 1000}";
|
||||||
|
var existingLyrics = await _cache.GetStringAsync(cacheKey);
|
||||||
|
|
||||||
_logger.LogDebug("💾 Saved playlist summary to cache");
|
if (!string.IsNullOrEmpty(existingLyrics))
|
||||||
|
{
|
||||||
|
lyricsWithCount++;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
lyricsWithoutCount++;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
playlistInfo["lyricsTotal"] = tracks.Count;
|
||||||
|
playlistInfo["lyricsCached"] = lyricsWithCount;
|
||||||
|
playlistInfo["lyricsMissing"] = lyricsWithoutCount;
|
||||||
|
playlistInfo["lyricsPercentage"] = tracks.Count > 0
|
||||||
|
? (int)Math.Round((double)lyricsWithCount / tracks.Count * 100)
|
||||||
|
: 0;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
playlistInfo["lyricsTotal"] = 0;
|
||||||
|
playlistInfo["lyricsCached"] = 0;
|
||||||
|
playlistInfo["lyricsMissing"] = 0;
|
||||||
|
playlistInfo["lyricsPercentage"] = 0;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogWarning(ex, "Failed to save playlist summary cache");
|
_logger.LogWarning(ex, "Failed to get lyrics completion for playlist {Name}", config.Name);
|
||||||
|
playlistInfo["lyricsTotal"] = 0;
|
||||||
|
playlistInfo["lyricsCached"] = 0;
|
||||||
|
playlistInfo["lyricsMissing"] = 0;
|
||||||
|
playlistInfo["lyricsPercentage"] = 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
playlists.Add(playlistInfo);
|
||||||
}
|
}
|
||||||
|
|
||||||
return Ok(new { playlists });
|
return Ok(new { playlists });
|
||||||
@@ -605,151 +555,91 @@ public class AdminController : ControllerBase
|
|||||||
// Get Spotify tracks
|
// Get Spotify tracks
|
||||||
var spotifyTracks = await _playlistFetcher.GetPlaylistTracksAsync(decodedName);
|
var spotifyTracks = await _playlistFetcher.GetPlaylistTracksAsync(decodedName);
|
||||||
|
|
||||||
|
// Get the playlist config to find Jellyfin ID
|
||||||
|
var playlistConfig = _spotifyImportSettings.Playlists
|
||||||
|
.FirstOrDefault(p => p.Name.Equals(decodedName, StringComparison.OrdinalIgnoreCase));
|
||||||
|
|
||||||
var tracksWithStatus = new List<object>();
|
var tracksWithStatus = new List<object>();
|
||||||
|
|
||||||
// Use the pre-built playlist cache (same as GetPlaylists endpoint)
|
if (!string.IsNullOrEmpty(playlistConfig?.JellyfinId))
|
||||||
// This cache includes all matched tracks with proper provider IDs
|
{
|
||||||
var playlistItemsCacheKey = $"spotify:playlist:items:{decodedName}";
|
// Get existing tracks from Jellyfin to determine local/external status
|
||||||
|
var userId = _jellyfinSettings.UserId;
|
||||||
List<Dictionary<string, object?>>? cachedPlaylistItems = null;
|
if (!string.IsNullOrEmpty(userId))
|
||||||
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
cachedPlaylistItems = await _cache.GetAsync<List<Dictionary<string, object?>>>(playlistItemsCacheKey);
|
var url = $"{_jellyfinSettings.Url}/Playlists/{playlistConfig.JellyfinId}/Items?UserId={userId}";
|
||||||
}
|
var request = new HttpRequestMessage(HttpMethod.Get, url);
|
||||||
catch (Exception cacheEx)
|
request.Headers.Add("X-Emby-Authorization", GetJellyfinAuthHeader());
|
||||||
|
|
||||||
|
var response = await _jellyfinHttpClient.SendAsync(request);
|
||||||
|
if (response.IsSuccessStatusCode)
|
||||||
{
|
{
|
||||||
_logger.LogWarning(cacheEx, "Failed to deserialize playlist cache for {Playlist}", decodedName);
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
|
using var doc = JsonDocument.Parse(json);
|
||||||
|
|
||||||
|
// Build list of local tracks (match by name only - no Spotify IDs!)
|
||||||
|
var localTracks = new List<(string Title, string Artist)>();
|
||||||
|
if (doc.RootElement.TryGetProperty("Items", out var items))
|
||||||
|
{
|
||||||
|
foreach (var item in items.EnumerateArray())
|
||||||
|
{
|
||||||
|
var title = item.TryGetProperty("Name", out var nameEl) ? nameEl.GetString() ?? "" : "";
|
||||||
|
var artist = "";
|
||||||
|
|
||||||
|
if (item.TryGetProperty("Artists", out var artistsEl) && artistsEl.GetArrayLength() > 0)
|
||||||
|
{
|
||||||
|
artist = artistsEl[0].GetString() ?? "";
|
||||||
|
}
|
||||||
|
else if (item.TryGetProperty("AlbumArtist", out var albumArtistEl))
|
||||||
|
{
|
||||||
|
artist = albumArtistEl.GetString() ?? "";
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogInformation("GetPlaylistTracks for {Playlist}: Cache found: {Found}, Count: {Count}",
|
if (!string.IsNullOrEmpty(title))
|
||||||
decodedName, cachedPlaylistItems != null, cachedPlaylistItems?.Count ?? 0);
|
|
||||||
|
|
||||||
if (cachedPlaylistItems != null && cachedPlaylistItems.Count > 0)
|
|
||||||
{
|
{
|
||||||
// Build a map of Spotify ID -> cached item for quick lookup
|
localTracks.Add((title, artist));
|
||||||
var spotifyIdToItem = new Dictionary<string, Dictionary<string, object?>>();
|
|
||||||
|
|
||||||
foreach (var item in cachedPlaylistItems)
|
|
||||||
{
|
|
||||||
if (item.TryGetValue("ProviderIds", out var providerIdsObj) && providerIdsObj != null)
|
|
||||||
{
|
|
||||||
Dictionary<string, string>? providerIds = null;
|
|
||||||
|
|
||||||
if (providerIdsObj is Dictionary<string, string> dict)
|
|
||||||
{
|
|
||||||
providerIds = dict;
|
|
||||||
}
|
|
||||||
else if (providerIdsObj is JsonElement jsonEl && jsonEl.ValueKind == JsonValueKind.Object)
|
|
||||||
{
|
|
||||||
providerIds = new Dictionary<string, string>();
|
|
||||||
foreach (var prop in jsonEl.EnumerateObject())
|
|
||||||
{
|
|
||||||
providerIds[prop.Name] = prop.Value.GetString() ?? "";
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (providerIds != null && providerIds.TryGetValue("Spotify", out var spotifyId) && !string.IsNullOrEmpty(spotifyId))
|
|
||||||
{
|
|
||||||
spotifyIdToItem[spotifyId] = item;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Match each Spotify track to its cached item
|
_logger.LogInformation("Found {Count} local tracks in Jellyfin playlist {Playlist}",
|
||||||
|
localTracks.Count, decodedName);
|
||||||
|
|
||||||
|
// Get matched external tracks cache
|
||||||
|
var matchedTracksKey = $"spotify:matched:ordered:{decodedName}";
|
||||||
|
var matchedTracks = await _cache.GetAsync<List<MatchedTrack>>(matchedTracksKey);
|
||||||
|
var matchedSpotifyIds = new HashSet<string>(
|
||||||
|
matchedTracks?.Select(m => m.SpotifyId) ?? Enumerable.Empty<string>()
|
||||||
|
);
|
||||||
|
|
||||||
|
// Match Spotify tracks to local tracks by name (fuzzy matching)
|
||||||
foreach (var track in spotifyTracks)
|
foreach (var track in spotifyTracks)
|
||||||
{
|
{
|
||||||
bool? isLocal = null;
|
bool? isLocal = null;
|
||||||
string? externalProvider = null;
|
string? externalProvider = null;
|
||||||
|
|
||||||
|
// FIRST: Check for manual mapping (same as SpotifyTrackMatchingService)
|
||||||
|
var manualMappingKey = $"spotify:manual-map:{decodedName}:{track.SpotifyId}";
|
||||||
|
var manualJellyfinId = await _cache.GetAsync<string>(manualMappingKey);
|
||||||
bool isManualMapping = false;
|
bool isManualMapping = false;
|
||||||
string? manualMappingType = null;
|
string? manualMappingType = null;
|
||||||
string? manualMappingId = null;
|
string? manualMappingId = null;
|
||||||
|
|
||||||
if (spotifyIdToItem.TryGetValue(track.SpotifyId, out var cachedItem))
|
|
||||||
{
|
|
||||||
// Track is in the cache - determine if it's local or external
|
|
||||||
if (cachedItem.TryGetValue("ProviderIds", out var providerIdsObj) && providerIdsObj != null)
|
|
||||||
{
|
|
||||||
Dictionary<string, string>? providerIds = null;
|
|
||||||
|
|
||||||
if (providerIdsObj is Dictionary<string, string> dict)
|
|
||||||
{
|
|
||||||
providerIds = dict;
|
|
||||||
}
|
|
||||||
else if (providerIdsObj is JsonElement jsonEl && jsonEl.ValueKind == JsonValueKind.Object)
|
|
||||||
{
|
|
||||||
providerIds = new Dictionary<string, string>();
|
|
||||||
foreach (var prop in jsonEl.EnumerateObject())
|
|
||||||
{
|
|
||||||
providerIds[prop.Name] = prop.Value.GetString() ?? "";
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (providerIds != null)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Track {Title} has ProviderIds: {Keys}", track.Title, string.Join(", ", providerIds.Keys));
|
|
||||||
|
|
||||||
// Check for external provider keys (case-insensitive)
|
|
||||||
// External providers: squidwtf, deezer, qobuz, tidal (lowercase)
|
|
||||||
var providerKey = providerIds.Keys.FirstOrDefault(k =>
|
|
||||||
k.Equals("squidwtf", StringComparison.OrdinalIgnoreCase) ||
|
|
||||||
k.Equals("SquidWTF", StringComparison.OrdinalIgnoreCase));
|
|
||||||
|
|
||||||
if (providerKey != null)
|
|
||||||
{
|
|
||||||
isLocal = false;
|
|
||||||
externalProvider = "SquidWTF";
|
|
||||||
_logger.LogDebug("✓ Track {Title} identified as SquidWTF", track.Title);
|
|
||||||
}
|
|
||||||
else if ((providerKey = providerIds.Keys.FirstOrDefault(k => k.Equals("deezer", StringComparison.OrdinalIgnoreCase))) != null)
|
|
||||||
{
|
|
||||||
isLocal = false;
|
|
||||||
externalProvider = "Deezer";
|
|
||||||
_logger.LogDebug("✓ Track {Title} identified as Deezer", track.Title);
|
|
||||||
}
|
|
||||||
else if ((providerKey = providerIds.Keys.FirstOrDefault(k => k.Equals("qobuz", StringComparison.OrdinalIgnoreCase))) != null)
|
|
||||||
{
|
|
||||||
isLocal = false;
|
|
||||||
externalProvider = "Qobuz";
|
|
||||||
_logger.LogDebug("✓ Track {Title} identified as Qobuz", track.Title);
|
|
||||||
}
|
|
||||||
else if ((providerKey = providerIds.Keys.FirstOrDefault(k => k.Equals("tidal", StringComparison.OrdinalIgnoreCase))) != null)
|
|
||||||
{
|
|
||||||
isLocal = false;
|
|
||||||
externalProvider = "Tidal";
|
|
||||||
_logger.LogDebug("✓ Track {Title} identified as Tidal", track.Title);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
// No external provider key found - it's a local track
|
|
||||||
// Local tracks have MusicBrainz, ISRC, Spotify IDs but no external provider
|
|
||||||
isLocal = true;
|
|
||||||
_logger.LogDebug("✓ Track {Title} identified as LOCAL (has ProviderIds but no external provider)", track.Title);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogWarning("Track {Title} has ProviderIds object but it's null after parsing", track.Title);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogWarning("Track {Title} in cache but has NO ProviderIds - treating as missing", track.Title);
|
|
||||||
isLocal = null;
|
|
||||||
externalProvider = null;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Check if this is a manual mapping
|
|
||||||
var manualJellyfinKey = $"spotify:manual-map:{decodedName}:{track.SpotifyId}";
|
|
||||||
var manualJellyfinId = await _cache.GetAsync<string>(manualJellyfinKey);
|
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(manualJellyfinId))
|
if (!string.IsNullOrEmpty(manualJellyfinId))
|
||||||
{
|
{
|
||||||
|
// Manual Jellyfin mapping exists - this track is definitely local
|
||||||
|
isLocal = true;
|
||||||
isManualMapping = true;
|
isManualMapping = true;
|
||||||
manualMappingType = "jellyfin";
|
manualMappingType = "jellyfin";
|
||||||
manualMappingId = manualJellyfinId;
|
manualMappingId = manualJellyfinId;
|
||||||
|
_logger.LogDebug("✓ Manual Jellyfin mapping found for {Title}: Jellyfin ID {Id}",
|
||||||
|
track.Title, manualJellyfinId);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
|
// Check for external manual mapping
|
||||||
var externalMappingKey = $"spotify:external-map:{decodedName}:{track.SpotifyId}";
|
var externalMappingKey = $"spotify:external-map:{decodedName}:{track.SpotifyId}";
|
||||||
var externalMappingJson = await _cache.GetStringAsync(externalMappingKey);
|
var externalMappingJson = await _cache.GetStringAsync(externalMappingKey);
|
||||||
|
|
||||||
@@ -760,25 +650,91 @@ public class AdminController : ControllerBase
|
|||||||
using var extDoc = JsonDocument.Parse(externalMappingJson);
|
using var extDoc = JsonDocument.Parse(externalMappingJson);
|
||||||
var extRoot = extDoc.RootElement;
|
var extRoot = extDoc.RootElement;
|
||||||
|
|
||||||
|
string? provider = null;
|
||||||
|
string? externalId = null;
|
||||||
|
|
||||||
|
if (extRoot.TryGetProperty("provider", out var providerEl))
|
||||||
|
{
|
||||||
|
provider = providerEl.GetString();
|
||||||
|
}
|
||||||
|
|
||||||
if (extRoot.TryGetProperty("id", out var idEl))
|
if (extRoot.TryGetProperty("id", out var idEl))
|
||||||
{
|
{
|
||||||
|
externalId = idEl.GetString();
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!string.IsNullOrEmpty(provider) && !string.IsNullOrEmpty(externalId))
|
||||||
|
{
|
||||||
|
// External manual mapping exists
|
||||||
|
isLocal = false;
|
||||||
|
externalProvider = provider;
|
||||||
isManualMapping = true;
|
isManualMapping = true;
|
||||||
manualMappingType = "external";
|
manualMappingType = "external";
|
||||||
manualMappingId = idEl.GetString();
|
manualMappingId = externalId;
|
||||||
|
_logger.LogDebug("✓ Manual external mapping found for {Title}: {Provider} {ExternalId}",
|
||||||
|
track.Title, provider, externalId);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
catch { }
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogWarning(ex, "Failed to process external manual mapping for {Title}", track.Title);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
else if (localTracks.Count > 0)
|
||||||
|
{
|
||||||
|
// SECOND: No manual mapping, try fuzzy matching
|
||||||
|
var bestMatch = localTracks
|
||||||
|
.Select(local => new
|
||||||
|
{
|
||||||
|
Local = local,
|
||||||
|
TitleScore = FuzzyMatcher.CalculateSimilarity(track.Title, local.Title),
|
||||||
|
ArtistScore = FuzzyMatcher.CalculateSimilarity(track.PrimaryArtist, local.Artist)
|
||||||
|
})
|
||||||
|
.Select(x => new
|
||||||
|
{
|
||||||
|
x.Local,
|
||||||
|
x.TitleScore,
|
||||||
|
x.ArtistScore,
|
||||||
|
TotalScore = (x.TitleScore * 0.7) + (x.ArtistScore * 0.3)
|
||||||
|
})
|
||||||
|
.OrderByDescending(x => x.TotalScore)
|
||||||
|
.FirstOrDefault();
|
||||||
|
|
||||||
|
// Use 70% threshold (same as playback matching)
|
||||||
|
if (bestMatch != null && bestMatch.TotalScore >= 70)
|
||||||
|
{
|
||||||
|
isLocal = true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// If not local, check if it's externally matched or missing
|
||||||
|
if (isLocal != true)
|
||||||
|
{
|
||||||
|
// Check if there's a manual external mapping
|
||||||
|
if (isManualMapping && manualMappingType == "external")
|
||||||
|
{
|
||||||
|
// Track has manual external mapping - it's available externally
|
||||||
|
isLocal = false;
|
||||||
|
// externalProvider already set above
|
||||||
|
}
|
||||||
|
else if (matchedSpotifyIds.Contains(track.SpotifyId))
|
||||||
|
{
|
||||||
|
// Track is externally matched (search succeeded)
|
||||||
|
isLocal = false;
|
||||||
|
externalProvider = "SquidWTF"; // Default to SquidWTF for external matches
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
// Track not in cache - it's missing
|
// Track is missing (search failed)
|
||||||
isLocal = null;
|
isLocal = null;
|
||||||
externalProvider = null;
|
externalProvider = null;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Check lyrics status
|
// Check lyrics status (only from our cache - lrclib/Spotify)
|
||||||
|
// Note: For local tracks, Jellyfin may have embedded lyrics that we don't check here
|
||||||
|
// Those will be served directly by Jellyfin when requested
|
||||||
var cacheKey = $"lyrics:{track.PrimaryArtist}:{track.Title}:{track.Album}:{track.DurationMs / 1000}";
|
var cacheKey = $"lyrics:{track.PrimaryArtist}:{track.Title}:{track.Album}:{track.DurationMs / 1000}";
|
||||||
var existingLyrics = await _cache.GetStringAsync(cacheKey);
|
var existingLyrics = await _cache.GetStringAsync(cacheKey);
|
||||||
var hasLyrics = !string.IsNullOrEmpty(existingLyrics);
|
var hasLyrics = !string.IsNullOrEmpty(existingLyrics);
|
||||||
@@ -795,7 +751,7 @@ public class AdminController : ControllerBase
|
|||||||
albumArtUrl = track.AlbumArtUrl,
|
albumArtUrl = track.AlbumArtUrl,
|
||||||
isLocal = isLocal,
|
isLocal = isLocal,
|
||||||
externalProvider = externalProvider,
|
externalProvider = externalProvider,
|
||||||
searchQuery = isLocal != true ? $"{track.Title} {track.PrimaryArtist}" : null,
|
searchQuery = isLocal != true ? $"{track.Title} {track.PrimaryArtist}" : null, // Set for both external and missing
|
||||||
isManualMapping = isManualMapping,
|
isManualMapping = isManualMapping,
|
||||||
manualMappingType = manualMappingType,
|
manualMappingType = manualMappingType,
|
||||||
manualMappingId = manualMappingId,
|
manualMappingId = manualMappingId,
|
||||||
@@ -810,10 +766,16 @@ public class AdminController : ControllerBase
|
|||||||
tracks = tracksWithStatus
|
tracks = tracksWithStatus
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogWarning(ex, "Failed to get local track status for {Playlist}", decodedName);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Fallback: Cache not available, use matched tracks cache
|
// If we get here, we couldn't get local tracks from Jellyfin
|
||||||
_logger.LogWarning("Playlist cache not available for {Playlist}, using fallback", decodedName);
|
// Just return tracks with basic external/missing status based on cache
|
||||||
|
|
||||||
var fallbackMatchedTracksKey = $"spotify:matched:ordered:{decodedName}";
|
var fallbackMatchedTracksKey = $"spotify:matched:ordered:{decodedName}";
|
||||||
var fallbackMatchedTracks = await _cache.GetAsync<List<MatchedTrack>>(fallbackMatchedTracksKey);
|
var fallbackMatchedTracks = await _cache.GetAsync<List<MatchedTrack>>(fallbackMatchedTracksKey);
|
||||||
var fallbackMatchedSpotifyIds = new HashSet<string>(
|
var fallbackMatchedSpotifyIds = new HashSet<string>(
|
||||||
@@ -825,7 +787,7 @@ public class AdminController : ControllerBase
|
|||||||
bool? isLocal = null;
|
bool? isLocal = null;
|
||||||
string? externalProvider = null;
|
string? externalProvider = null;
|
||||||
|
|
||||||
// Check for manual Jellyfin mapping
|
// Check for manual mappings
|
||||||
var manualMappingKey = $"spotify:manual-map:{decodedName}:{track.SpotifyId}";
|
var manualMappingKey = $"spotify:manual-map:{decodedName}:{track.SpotifyId}";
|
||||||
var manualJellyfinId = await _cache.GetAsync<string>(manualMappingKey);
|
var manualJellyfinId = await _cache.GetAsync<string>(manualMappingKey);
|
||||||
|
|
||||||
@@ -866,11 +828,13 @@ public class AdminController : ControllerBase
|
|||||||
}
|
}
|
||||||
else if (fallbackMatchedSpotifyIds.Contains(track.SpotifyId))
|
else if (fallbackMatchedSpotifyIds.Contains(track.SpotifyId))
|
||||||
{
|
{
|
||||||
|
// Track is externally matched (search succeeded)
|
||||||
isLocal = false;
|
isLocal = false;
|
||||||
externalProvider = "SquidWTF";
|
externalProvider = "SquidWTF"; // Default to SquidWTF for external matches
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
|
// Track is missing (search failed)
|
||||||
isLocal = null;
|
isLocal = null;
|
||||||
externalProvider = null;
|
externalProvider = null;
|
||||||
}
|
}
|
||||||
@@ -888,7 +852,7 @@ public class AdminController : ControllerBase
|
|||||||
albumArtUrl = track.AlbumArtUrl,
|
albumArtUrl = track.AlbumArtUrl,
|
||||||
isLocal = isLocal,
|
isLocal = isLocal,
|
||||||
externalProvider = externalProvider,
|
externalProvider = externalProvider,
|
||||||
searchQuery = isLocal != true ? $"{track.Title} {track.PrimaryArtist}" : null
|
searchQuery = isLocal != true ? $"{track.Title} {track.PrimaryArtist}" : null // Set for both external and missing
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -908,10 +872,6 @@ public class AdminController : ControllerBase
|
|||||||
{
|
{
|
||||||
_logger.LogInformation("Manual playlist refresh triggered from admin UI");
|
_logger.LogInformation("Manual playlist refresh triggered from admin UI");
|
||||||
await _playlistFetcher.TriggerFetchAsync();
|
await _playlistFetcher.TriggerFetchAsync();
|
||||||
|
|
||||||
// Invalidate playlist summary cache
|
|
||||||
InvalidatePlaylistSummaryCache();
|
|
||||||
|
|
||||||
return Ok(new { message = "Playlist refresh triggered", timestamp = DateTime.UtcNow });
|
return Ok(new { message = "Playlist refresh triggered", timestamp = DateTime.UtcNow });
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -932,10 +892,6 @@ public class AdminController : ControllerBase
|
|||||||
try
|
try
|
||||||
{
|
{
|
||||||
await _matchingService.TriggerMatchingForPlaylistAsync(decodedName);
|
await _matchingService.TriggerMatchingForPlaylistAsync(decodedName);
|
||||||
|
|
||||||
// Invalidate playlist summary cache
|
|
||||||
InvalidatePlaylistSummaryCache();
|
|
||||||
|
|
||||||
return Ok(new { message = $"Track matching triggered for {decodedName}", timestamp = DateTime.UtcNow });
|
return Ok(new { message = $"Track matching triggered for {decodedName}", timestamp = DateTime.UtcNow });
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
@@ -945,77 +901,6 @@ public class AdminController : ControllerBase
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Clear cache and rebuild for a specific playlist
|
|
||||||
/// </summary>
|
|
||||||
[HttpPost("playlists/{name}/clear-cache")]
|
|
||||||
public async Task<IActionResult> ClearPlaylistCache(string name)
|
|
||||||
{
|
|
||||||
var decodedName = Uri.UnescapeDataString(name);
|
|
||||||
_logger.LogInformation("Clear cache & rebuild triggered for playlist: {Name}", decodedName);
|
|
||||||
|
|
||||||
if (_matchingService == null)
|
|
||||||
{
|
|
||||||
return BadRequest(new { error = "Track matching service is not available" });
|
|
||||||
}
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
// Clear all cache keys for this playlist
|
|
||||||
var cacheKeys = new[]
|
|
||||||
{
|
|
||||||
$"spotify:playlist:items:{decodedName}", // Pre-built items cache
|
|
||||||
$"spotify:matched:ordered:{decodedName}", // Ordered matched tracks
|
|
||||||
$"spotify:matched:{decodedName}", // Legacy matched tracks
|
|
||||||
$"spotify:missing:{decodedName}" // Missing tracks
|
|
||||||
};
|
|
||||||
|
|
||||||
foreach (var key in cacheKeys)
|
|
||||||
{
|
|
||||||
await _cache.DeleteAsync(key);
|
|
||||||
_logger.LogDebug("Cleared cache key: {Key}", key);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Delete file caches
|
|
||||||
var safeName = string.Join("_", decodedName.Split(Path.GetInvalidFileNameChars()));
|
|
||||||
var filesToDelete = new[]
|
|
||||||
{
|
|
||||||
Path.Combine(CacheDirectory, $"{safeName}_items.json"),
|
|
||||||
Path.Combine(CacheDirectory, $"{safeName}_matched.json")
|
|
||||||
};
|
|
||||||
|
|
||||||
foreach (var file in filesToDelete)
|
|
||||||
{
|
|
||||||
if (System.IO.File.Exists(file))
|
|
||||||
{
|
|
||||||
System.IO.File.Delete(file);
|
|
||||||
_logger.LogDebug("Deleted cache file: {File}", file);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogInformation("✓ Cleared all caches for playlist: {Name}", decodedName);
|
|
||||||
|
|
||||||
// Trigger rebuild
|
|
||||||
await _matchingService.TriggerMatchingForPlaylistAsync(decodedName);
|
|
||||||
|
|
||||||
// Invalidate playlist summary cache
|
|
||||||
InvalidatePlaylistSummaryCache();
|
|
||||||
|
|
||||||
return Ok(new
|
|
||||||
{
|
|
||||||
message = $"Cache cleared and rebuild triggered for {decodedName}",
|
|
||||||
timestamp = DateTime.UtcNow,
|
|
||||||
clearedKeys = cacheKeys.Length,
|
|
||||||
clearedFiles = filesToDelete.Count(System.IO.File.Exists)
|
|
||||||
});
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogError(ex, "Failed to clear cache for {Name}", decodedName);
|
|
||||||
return StatusCode(500, new { error = "Failed to clear cache", details = ex.Message });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Search Jellyfin library for tracks (for manual mapping)
|
/// Search Jellyfin library for tracks (for manual mapping)
|
||||||
/// </summary>
|
/// </summary>
|
||||||
@@ -1168,7 +1053,7 @@ public class AdminController : ControllerBase
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Save manual track mapping (local Jellyfin or external provider)
|
/// Save manual track mapping
|
||||||
/// </summary>
|
/// </summary>
|
||||||
[HttpPost("playlists/{name}/map")]
|
[HttpPost("playlists/{name}/map")]
|
||||||
public async Task<IActionResult> SaveManualMapping(string name, [FromBody] ManualMappingRequest request)
|
public async Task<IActionResult> SaveManualMapping(string name, [FromBody] ManualMappingRequest request)
|
||||||
@@ -1196,8 +1081,6 @@ public class AdminController : ControllerBase
|
|||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
string? normalizedProvider = null;
|
|
||||||
|
|
||||||
if (hasJellyfinMapping)
|
if (hasJellyfinMapping)
|
||||||
{
|
{
|
||||||
// Store Jellyfin mapping in cache (NO EXPIRATION - manual mappings are permanent)
|
// Store Jellyfin mapping in cache (NO EXPIRATION - manual mappings are permanent)
|
||||||
@@ -1214,7 +1097,7 @@ public class AdminController : ControllerBase
|
|||||||
{
|
{
|
||||||
// Store external mapping in cache (NO EXPIRATION - manual mappings are permanent)
|
// Store external mapping in cache (NO EXPIRATION - manual mappings are permanent)
|
||||||
var externalMappingKey = $"spotify:external-map:{decodedName}:{request.SpotifyId}";
|
var externalMappingKey = $"spotify:external-map:{decodedName}:{request.SpotifyId}";
|
||||||
normalizedProvider = request.ExternalProvider!.ToLowerInvariant(); // Normalize to lowercase
|
var normalizedProvider = request.ExternalProvider!.ToLowerInvariant(); // Normalize to lowercase
|
||||||
var externalMapping = new { provider = normalizedProvider, id = request.ExternalId };
|
var externalMapping = new { provider = normalizedProvider, id = request.ExternalId };
|
||||||
await _cache.SetAsync(externalMappingKey, externalMapping);
|
await _cache.SetAsync(externalMappingKey, externalMapping);
|
||||||
|
|
||||||
@@ -1261,16 +1144,58 @@ public class AdminController : ControllerBase
|
|||||||
|
|
||||||
_logger.LogInformation("Cleared playlist caches for {Playlist} to force rebuild", decodedName);
|
_logger.LogInformation("Cleared playlist caches for {Playlist} to force rebuild", decodedName);
|
||||||
|
|
||||||
// Fetch external provider track details to return to the UI (only for external mappings)
|
// Fetch the mapped track details to return to the UI
|
||||||
string? trackTitle = null;
|
string? trackTitle = null;
|
||||||
string? trackArtist = null;
|
string? trackArtist = null;
|
||||||
string? trackAlbum = null;
|
string? trackAlbum = null;
|
||||||
|
bool isLocalMapping = hasJellyfinMapping;
|
||||||
|
|
||||||
if (hasExternalMapping && normalizedProvider != null)
|
if (hasJellyfinMapping)
|
||||||
{
|
{
|
||||||
|
// Fetch Jellyfin track details
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var userId = _jellyfinSettings.UserId;
|
||||||
|
var trackUrl = $"{_jellyfinSettings.Url}/Items/{request.JellyfinId}";
|
||||||
|
if (!string.IsNullOrEmpty(userId))
|
||||||
|
{
|
||||||
|
trackUrl += $"?UserId={userId}";
|
||||||
|
}
|
||||||
|
|
||||||
|
var trackRequest = new HttpRequestMessage(HttpMethod.Get, trackUrl);
|
||||||
|
trackRequest.Headers.Add("X-Emby-Authorization", GetJellyfinAuthHeader());
|
||||||
|
|
||||||
|
var response = await _jellyfinHttpClient.SendAsync(trackRequest);
|
||||||
|
|
||||||
|
if (response.IsSuccessStatusCode)
|
||||||
|
{
|
||||||
|
var trackData = await response.Content.ReadAsStringAsync();
|
||||||
|
using var doc = JsonDocument.Parse(trackData);
|
||||||
|
var track = doc.RootElement;
|
||||||
|
|
||||||
|
trackTitle = track.TryGetProperty("Name", out var nameEl) ? nameEl.GetString() : null;
|
||||||
|
trackArtist = track.TryGetProperty("AlbumArtist", out var artistEl) ? artistEl.GetString() :
|
||||||
|
(track.TryGetProperty("Artists", out var artistsEl) && artistsEl.GetArrayLength() > 0
|
||||||
|
? artistsEl[0].GetString() : null);
|
||||||
|
trackAlbum = track.TryGetProperty("Album", out var albumEl) ? albumEl.GetString() : null;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
_logger.LogWarning("Failed to fetch Jellyfin track {Id}: {StatusCode}", request.JellyfinId, response.StatusCode);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogWarning(ex, "Failed to fetch mapped track details, but mapping was saved");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
// Fetch external provider track details
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
var metadataService = HttpContext.RequestServices.GetRequiredService<IMusicMetadataService>();
|
var metadataService = HttpContext.RequestServices.GetRequiredService<IMusicMetadataService>();
|
||||||
|
var normalizedProvider = request.ExternalProvider!.ToLowerInvariant(); // Normalize to lowercase
|
||||||
var externalSong = await metadataService.GetSongAsync(normalizedProvider, request.ExternalId!);
|
var externalSong = await metadataService.GetSongAsync(normalizedProvider, request.ExternalId!);
|
||||||
|
|
||||||
if (externalSong != null)
|
if (externalSong != null)
|
||||||
@@ -1324,12 +1249,12 @@ public class AdminController : ControllerBase
|
|||||||
// Return success with track details if available
|
// Return success with track details if available
|
||||||
var mappedTrack = new
|
var mappedTrack = new
|
||||||
{
|
{
|
||||||
id = request.ExternalId,
|
id = hasJellyfinMapping ? request.JellyfinId : request.ExternalId,
|
||||||
title = trackTitle ?? "Unknown",
|
title = trackTitle ?? "Unknown",
|
||||||
artist = trackArtist ?? "Unknown",
|
artist = trackArtist ?? "Unknown",
|
||||||
album = trackAlbum ?? "Unknown",
|
album = trackAlbum ?? "Unknown",
|
||||||
isLocal = false,
|
isLocal = isLocalMapping,
|
||||||
externalProvider = request.ExternalProvider!.ToLowerInvariant()
|
externalProvider = hasExternalMapping ? request.ExternalProvider!.ToLowerInvariant() : null
|
||||||
};
|
};
|
||||||
|
|
||||||
return Ok(new
|
return Ok(new
|
||||||
@@ -1391,7 +1316,9 @@ public class AdminController : ControllerBase
|
|||||||
spotifyImport = new
|
spotifyImport = new
|
||||||
{
|
{
|
||||||
enabled = _spotifyImportSettings.Enabled,
|
enabled = _spotifyImportSettings.Enabled,
|
||||||
matchingIntervalHours = _spotifyImportSettings.MatchingIntervalHours,
|
syncStartHour = _spotifyImportSettings.SyncStartHour,
|
||||||
|
syncStartMinute = _spotifyImportSettings.SyncStartMinute,
|
||||||
|
syncWindowHours = _spotifyImportSettings.SyncWindowHours,
|
||||||
playlists = _spotifyImportSettings.Playlists.Select(p => new
|
playlists = _spotifyImportSettings.Playlists.Select(p => new
|
||||||
{
|
{
|
||||||
name = p.Name,
|
name = p.Name,
|
||||||
@@ -1406,16 +1333,6 @@ public class AdminController : ControllerBase
|
|||||||
userId = _jellyfinSettings.UserId ?? "(not set)",
|
userId = _jellyfinSettings.UserId ?? "(not set)",
|
||||||
libraryId = _jellyfinSettings.LibraryId
|
libraryId = _jellyfinSettings.LibraryId
|
||||||
},
|
},
|
||||||
library = new
|
|
||||||
{
|
|
||||||
downloadPath = _subsonicSettings.StorageMode == StorageMode.Cache
|
|
||||||
? Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "cache")
|
|
||||||
: Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "permanent"),
|
|
||||||
keptPath = Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "kept"),
|
|
||||||
storageMode = _subsonicSettings.StorageMode.ToString(),
|
|
||||||
cacheDurationHours = _subsonicSettings.CacheDurationHours,
|
|
||||||
downloadMode = _subsonicSettings.DownloadMode.ToString()
|
|
||||||
},
|
|
||||||
deezer = new
|
deezer = new
|
||||||
{
|
{
|
||||||
arl = MaskValue(_deezerSettings.Arl, showLast: 8),
|
arl = MaskValue(_deezerSettings.Arl, showLast: 8),
|
||||||
@@ -1982,13 +1899,8 @@ public class AdminController : ControllerBase
|
|||||||
var isConfigured = configuredPlaylist != null;
|
var isConfigured = configuredPlaylist != null;
|
||||||
var linkedSpotifyId = configuredPlaylist?.Id;
|
var linkedSpotifyId = configuredPlaylist?.Id;
|
||||||
|
|
||||||
// Only fetch detailed track stats for configured Spotify playlists
|
// Fetch track details to categorize local vs external
|
||||||
// This avoids expensive queries for large non-Spotify playlists
|
var trackStats = await GetPlaylistTrackStats(id!);
|
||||||
var trackStats = (LocalTracks: 0, ExternalTracks: 0, ExternalAvailable: 0);
|
|
||||||
if (isConfigured)
|
|
||||||
{
|
|
||||||
trackStats = await GetPlaylistTrackStats(id!);
|
|
||||||
}
|
|
||||||
|
|
||||||
playlists.Add(new
|
playlists.Add(new
|
||||||
{
|
{
|
||||||
@@ -2697,11 +2609,7 @@ public class AdminController : ControllerBase
|
|||||||
if (parts.Length >= 3)
|
if (parts.Length >= 3)
|
||||||
{
|
{
|
||||||
var timestamp = parts[0];
|
var timestamp = parts[0];
|
||||||
var method = parts[1];
|
var endpoint = parts[1];
|
||||||
var endpoint = parts[2];
|
|
||||||
|
|
||||||
// Combine method and endpoint for better clarity
|
|
||||||
var fullEndpoint = $"{method} {endpoint}";
|
|
||||||
|
|
||||||
// Filter by date if specified
|
// Filter by date if specified
|
||||||
if (sinceDate.HasValue && DateTime.TryParse(timestamp, out var logDate))
|
if (sinceDate.HasValue && DateTime.TryParse(timestamp, out var logDate))
|
||||||
@@ -2710,7 +2618,7 @@ public class AdminController : ControllerBase
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
usage[fullEndpoint] = usage.GetValueOrDefault(fullEndpoint, 0) + 1;
|
usage[endpoint] = usage.GetValueOrDefault(endpoint, 0) + 1;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2983,200 +2891,6 @@ public class AdminController : ControllerBase
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Get all manual track mappings (both Jellyfin and external) for all playlists
|
|
||||||
/// </summary>
|
|
||||||
[HttpGet("mappings/tracks")]
|
|
||||||
public async Task<IActionResult> GetAllTrackMappings()
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var mappingsDir = "/app/cache/mappings";
|
|
||||||
var allMappings = new List<object>();
|
|
||||||
|
|
||||||
if (!Directory.Exists(mappingsDir))
|
|
||||||
{
|
|
||||||
return Ok(new { mappings = allMappings, totalCount = 0 });
|
|
||||||
}
|
|
||||||
|
|
||||||
var files = Directory.GetFiles(mappingsDir, "*_mappings.json");
|
|
||||||
|
|
||||||
foreach (var file in files)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var json = await System.IO.File.ReadAllTextAsync(file);
|
|
||||||
var playlistMappings = JsonSerializer.Deserialize<Dictionary<string, ManualMappingEntry>>(json);
|
|
||||||
|
|
||||||
if (playlistMappings != null)
|
|
||||||
{
|
|
||||||
var fileName = Path.GetFileNameWithoutExtension(file);
|
|
||||||
var playlistName = fileName.Replace("_mappings", "").Replace("_", " ");
|
|
||||||
|
|
||||||
foreach (var mapping in playlistMappings.Values)
|
|
||||||
{
|
|
||||||
allMappings.Add(new
|
|
||||||
{
|
|
||||||
playlist = playlistName,
|
|
||||||
spotifyId = mapping.SpotifyId,
|
|
||||||
type = !string.IsNullOrEmpty(mapping.JellyfinId) ? "jellyfin" : "external",
|
|
||||||
jellyfinId = mapping.JellyfinId,
|
|
||||||
externalProvider = mapping.ExternalProvider,
|
|
||||||
externalId = mapping.ExternalId,
|
|
||||||
createdAt = mapping.CreatedAt
|
|
||||||
});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogWarning(ex, "Failed to read mapping file {File}", file);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return Ok(new
|
|
||||||
{
|
|
||||||
mappings = allMappings.OrderBy(m => ((dynamic)m).playlist).ThenBy(m => ((dynamic)m).createdAt),
|
|
||||||
totalCount = allMappings.Count,
|
|
||||||
jellyfinCount = allMappings.Count(m => ((dynamic)m).type == "jellyfin"),
|
|
||||||
externalCount = allMappings.Count(m => ((dynamic)m).type == "external")
|
|
||||||
});
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogError(ex, "Failed to get track mappings");
|
|
||||||
return StatusCode(500, new { error = "Failed to get track mappings" });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Delete a manual track mapping
|
|
||||||
/// </summary>
|
|
||||||
[HttpDelete("mappings/tracks")]
|
|
||||||
public async Task<IActionResult> DeleteTrackMapping([FromQuery] string playlist, [FromQuery] string spotifyId)
|
|
||||||
{
|
|
||||||
if (string.IsNullOrEmpty(playlist) || string.IsNullOrEmpty(spotifyId))
|
|
||||||
{
|
|
||||||
return BadRequest(new { error = "playlist and spotifyId parameters are required" });
|
|
||||||
}
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var mappingsDir = "/app/cache/mappings";
|
|
||||||
var safeName = string.Join("_", playlist.Split(Path.GetInvalidFileNameChars()));
|
|
||||||
var filePath = Path.Combine(mappingsDir, $"{safeName}_mappings.json");
|
|
||||||
|
|
||||||
if (!System.IO.File.Exists(filePath))
|
|
||||||
{
|
|
||||||
return NotFound(new { error = "Mapping file not found for playlist" });
|
|
||||||
}
|
|
||||||
|
|
||||||
// Load existing mappings
|
|
||||||
var json = await System.IO.File.ReadAllTextAsync(filePath);
|
|
||||||
var mappings = JsonSerializer.Deserialize<Dictionary<string, ManualMappingEntry>>(json);
|
|
||||||
|
|
||||||
if (mappings == null || !mappings.ContainsKey(spotifyId))
|
|
||||||
{
|
|
||||||
return NotFound(new { error = "Mapping not found" });
|
|
||||||
}
|
|
||||||
|
|
||||||
// Remove the mapping
|
|
||||||
mappings.Remove(spotifyId);
|
|
||||||
|
|
||||||
// Save back to file (or delete file if empty)
|
|
||||||
if (mappings.Count == 0)
|
|
||||||
{
|
|
||||||
System.IO.File.Delete(filePath);
|
|
||||||
_logger.LogInformation("🗑️ Deleted empty mapping file for playlist {Playlist}", playlist);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
var updatedJson = JsonSerializer.Serialize(mappings, new JsonSerializerOptions { WriteIndented = true });
|
|
||||||
await System.IO.File.WriteAllTextAsync(filePath, updatedJson);
|
|
||||||
_logger.LogInformation("🗑️ Deleted mapping: {Playlist} - {SpotifyId}", playlist, spotifyId);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Also remove from Redis cache
|
|
||||||
var cacheKey = $"manual:mapping:{playlist}:{spotifyId}";
|
|
||||||
await _cache.DeleteAsync(cacheKey);
|
|
||||||
|
|
||||||
return Ok(new { success = true, message = "Mapping deleted successfully" });
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogError(ex, "Failed to delete track mapping for {Playlist} - {SpotifyId}", playlist, spotifyId);
|
|
||||||
return StatusCode(500, new { error = "Failed to delete track mapping" });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Test Spotify lyrics API by fetching lyrics for a specific Spotify track ID
|
|
||||||
/// Example: GET /api/admin/lyrics/spotify/test?trackId=3yII7UwgLF6K5zW3xad3MP
|
|
||||||
/// </summary>
|
|
||||||
[HttpGet("lyrics/spotify/test")]
|
|
||||||
public async Task<IActionResult> TestSpotifyLyrics([FromQuery] string trackId)
|
|
||||||
{
|
|
||||||
if (string.IsNullOrEmpty(trackId))
|
|
||||||
{
|
|
||||||
return BadRequest(new { error = "trackId parameter is required" });
|
|
||||||
}
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var spotifyLyricsService = _serviceProvider.GetService<allstarr.Services.Lyrics.SpotifyLyricsService>();
|
|
||||||
|
|
||||||
if (spotifyLyricsService == null)
|
|
||||||
{
|
|
||||||
return StatusCode(500, new { error = "Spotify lyrics service not available" });
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogInformation("Testing Spotify lyrics for track ID: {TrackId}", trackId);
|
|
||||||
|
|
||||||
var result = await spotifyLyricsService.GetLyricsByTrackIdAsync(trackId);
|
|
||||||
|
|
||||||
if (result == null)
|
|
||||||
{
|
|
||||||
return NotFound(new
|
|
||||||
{
|
|
||||||
error = "No lyrics found",
|
|
||||||
trackId,
|
|
||||||
message = "Lyrics may not be available for this track, or the Spotify API is not configured correctly"
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
return Ok(new
|
|
||||||
{
|
|
||||||
success = true,
|
|
||||||
trackId = result.SpotifyTrackId,
|
|
||||||
syncType = result.SyncType,
|
|
||||||
lineCount = result.Lines.Count,
|
|
||||||
language = result.Language,
|
|
||||||
provider = result.Provider,
|
|
||||||
providerDisplayName = result.ProviderDisplayName,
|
|
||||||
lines = result.Lines.Select(l => new
|
|
||||||
{
|
|
||||||
startTimeMs = l.StartTimeMs,
|
|
||||||
endTimeMs = l.EndTimeMs,
|
|
||||||
words = l.Words
|
|
||||||
}).ToList(),
|
|
||||||
// Also show LRC format
|
|
||||||
lrcFormat = string.Join("\n", result.Lines.Select(l =>
|
|
||||||
{
|
|
||||||
var timestamp = TimeSpan.FromMilliseconds(l.StartTimeMs);
|
|
||||||
var mm = (int)timestamp.TotalMinutes;
|
|
||||||
var ss = timestamp.Seconds;
|
|
||||||
var ms = timestamp.Milliseconds / 10;
|
|
||||||
return $"[{mm:D2}:{ss:D2}.{ms:D2}]{l.Words}";
|
|
||||||
}))
|
|
||||||
});
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogError(ex, "Failed to test Spotify lyrics for track {TrackId}", trackId);
|
|
||||||
return StatusCode(500, new { error = $"Failed to fetch lyrics: {ex.Message}" });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Prefetch lyrics for a specific playlist
|
/// Prefetch lyrics for a specific playlist
|
||||||
/// </summary>
|
/// </summary>
|
||||||
@@ -3218,30 +2932,7 @@ public class AdminController : ControllerBase
|
|||||||
}
|
}
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
|
}
|
||||||
#region Helper Methods
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Invalidates the cached playlist summary so it will be regenerated on next request
|
|
||||||
/// </summary>
|
|
||||||
private void InvalidatePlaylistSummaryCache()
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var cacheFile = "/app/cache/admin_playlists_summary.json";
|
|
||||||
if (System.IO.File.Exists(cacheFile))
|
|
||||||
{
|
|
||||||
System.IO.File.Delete(cacheFile);
|
|
||||||
_logger.LogDebug("🗑️ Invalidated playlist summary cache");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogWarning(ex, "Failed to invalidate playlist summary cache");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#endregion
|
|
||||||
|
|
||||||
public class ManualMappingRequest
|
public class ManualMappingRequest
|
||||||
{
|
{
|
||||||
@@ -3296,202 +2987,3 @@ public class LinkPlaylistRequest
|
|||||||
public string Name { get; set; } = string.Empty;
|
public string Name { get; set; } = string.Empty;
|
||||||
public string SpotifyPlaylistId { get; set; } = string.Empty;
|
public string SpotifyPlaylistId { get; set; } = string.Empty;
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// GET /api/admin/downloads
|
|
||||||
/// Lists all downloaded files in the KEPT folder only (favorited tracks)
|
|
||||||
/// </summary>
|
|
||||||
[HttpGet("downloads")]
|
|
||||||
public IActionResult GetDownloads()
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var keptPath = Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "kept");
|
|
||||||
|
|
||||||
_logger.LogInformation("📂 Checking kept folder: {Path}", keptPath);
|
|
||||||
_logger.LogInformation("📂 Directory exists: {Exists}", Directory.Exists(keptPath));
|
|
||||||
|
|
||||||
if (!Directory.Exists(keptPath))
|
|
||||||
{
|
|
||||||
_logger.LogWarning("Kept folder does not exist: {Path}", keptPath);
|
|
||||||
return Ok(new { files = new List<object>(), totalSize = 0, count = 0 });
|
|
||||||
}
|
|
||||||
|
|
||||||
var files = new List<object>();
|
|
||||||
long totalSize = 0;
|
|
||||||
|
|
||||||
// Recursively get all audio files from kept folder
|
|
||||||
var audioExtensions = new[] { ".flac", ".mp3", ".m4a", ".opus" };
|
|
||||||
|
|
||||||
var allFiles = Directory.GetFiles(keptPath, "*.*", SearchOption.AllDirectories)
|
|
||||||
.Where(f => audioExtensions.Contains(Path.GetExtension(f).ToLowerInvariant()))
|
|
||||||
.ToList();
|
|
||||||
|
|
||||||
_logger.LogInformation("📂 Found {Count} audio files in kept folder", allFiles.Count);
|
|
||||||
|
|
||||||
foreach (var filePath in allFiles)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("📂 Processing file: {Path}", filePath);
|
|
||||||
|
|
||||||
var fileInfo = new FileInfo(filePath);
|
|
||||||
var relativePath = Path.GetRelativePath(keptPath, filePath);
|
|
||||||
|
|
||||||
// Parse artist/album/track from path structure
|
|
||||||
var parts = relativePath.Split(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);
|
|
||||||
var artist = parts.Length > 0 ? parts[0] : "";
|
|
||||||
var album = parts.Length > 1 ? parts[1] : "";
|
|
||||||
var fileName = parts.Length > 2 ? parts[^1] : Path.GetFileName(filePath);
|
|
||||||
|
|
||||||
files.Add(new
|
|
||||||
{
|
|
||||||
path = relativePath,
|
|
||||||
fullPath = filePath,
|
|
||||||
artist,
|
|
||||||
album,
|
|
||||||
fileName,
|
|
||||||
size = fileInfo.Length,
|
|
||||||
sizeFormatted = FormatFileSize(fileInfo.Length),
|
|
||||||
lastModified = fileInfo.LastWriteTimeUtc,
|
|
||||||
extension = fileInfo.Extension
|
|
||||||
});
|
|
||||||
|
|
||||||
totalSize += fileInfo.Length;
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogInformation("📂 Returning {Count} kept files, total size: {Size}", files.Count, FormatFileSize(totalSize));
|
|
||||||
|
|
||||||
return Ok(new
|
|
||||||
{
|
|
||||||
files = files.OrderBy(f => ((dynamic)f).artist).ThenBy(f => ((dynamic)f).album).ThenBy(f => ((dynamic)f).fileName),
|
|
||||||
totalSize,
|
|
||||||
totalSizeFormatted = FormatFileSize(totalSize),
|
|
||||||
count = files.Count
|
|
||||||
});
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogError(ex, "Failed to list kept downloads");
|
|
||||||
return StatusCode(500, new { error = "Failed to list kept downloads" });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// DELETE /api/admin/downloads
|
|
||||||
/// Deletes a specific kept file and cleans up empty folders
|
|
||||||
/// </summary>
|
|
||||||
[HttpDelete("downloads")]
|
|
||||||
public IActionResult DeleteDownload([FromQuery] string path)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
if (string.IsNullOrEmpty(path))
|
|
||||||
{
|
|
||||||
return BadRequest(new { error = "Path is required" });
|
|
||||||
}
|
|
||||||
|
|
||||||
var keptPath = Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "kept");
|
|
||||||
var fullPath = Path.Combine(keptPath, path);
|
|
||||||
|
|
||||||
_logger.LogInformation("🗑️ Delete request for: {Path}", fullPath);
|
|
||||||
|
|
||||||
// Security: Ensure the path is within the kept directory
|
|
||||||
var normalizedFullPath = Path.GetFullPath(fullPath);
|
|
||||||
var normalizedKeptPath = Path.GetFullPath(keptPath);
|
|
||||||
|
|
||||||
if (!normalizedFullPath.StartsWith(normalizedKeptPath))
|
|
||||||
{
|
|
||||||
_logger.LogWarning("🗑️ Invalid path (outside kept folder): {Path}", normalizedFullPath);
|
|
||||||
return BadRequest(new { error = "Invalid path" });
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!System.IO.File.Exists(fullPath))
|
|
||||||
{
|
|
||||||
_logger.LogWarning("🗑️ File not found: {Path}", fullPath);
|
|
||||||
return NotFound(new { error = "File not found" });
|
|
||||||
}
|
|
||||||
|
|
||||||
System.IO.File.Delete(fullPath);
|
|
||||||
_logger.LogInformation("🗑️ Deleted file: {Path}", fullPath);
|
|
||||||
|
|
||||||
// Clean up empty directories (Album folder, then Artist folder if empty)
|
|
||||||
var directory = Path.GetDirectoryName(fullPath);
|
|
||||||
while (directory != null && directory != keptPath && directory.StartsWith(keptPath))
|
|
||||||
{
|
|
||||||
if (Directory.Exists(directory) && !Directory.EnumerateFileSystemEntries(directory).Any())
|
|
||||||
{
|
|
||||||
Directory.Delete(directory);
|
|
||||||
_logger.LogInformation("🗑️ Deleted empty directory: {Dir}", directory);
|
|
||||||
directory = Path.GetDirectoryName(directory);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogDebug("🗑️ Directory not empty or doesn't exist, stopping cleanup: {Dir}", directory);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return Ok(new { success = true, message = "File deleted successfully" });
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogError(ex, "Failed to delete file: {Path}", path);
|
|
||||||
return StatusCode(500, new { error = "Failed to delete file" });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// GET /api/admin/downloads/file
|
|
||||||
/// Downloads a specific file from the kept folder
|
|
||||||
/// </summary>
|
|
||||||
[HttpGet("downloads/file")]
|
|
||||||
public IActionResult DownloadFile([FromQuery] string path)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
if (string.IsNullOrEmpty(path))
|
|
||||||
{
|
|
||||||
return BadRequest(new { error = "Path is required" });
|
|
||||||
}
|
|
||||||
|
|
||||||
var keptPath = Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "kept");
|
|
||||||
var fullPath = Path.Combine(keptPath, path);
|
|
||||||
|
|
||||||
// Security: Ensure the path is within the kept directory
|
|
||||||
var normalizedFullPath = Path.GetFullPath(fullPath);
|
|
||||||
var normalizedKeptPath = Path.GetFullPath(keptPath);
|
|
||||||
|
|
||||||
if (!normalizedFullPath.StartsWith(normalizedKeptPath))
|
|
||||||
{
|
|
||||||
return BadRequest(new { error = "Invalid path" });
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!System.IO.File.Exists(fullPath))
|
|
||||||
{
|
|
||||||
return NotFound(new { error = "File not found" });
|
|
||||||
}
|
|
||||||
|
|
||||||
var fileName = Path.GetFileName(fullPath);
|
|
||||||
var fileStream = System.IO.File.OpenRead(fullPath);
|
|
||||||
|
|
||||||
return File(fileStream, "application/octet-stream", fileName);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogError(ex, "Failed to download file: {Path}", path);
|
|
||||||
return StatusCode(500, new { error = "Failed to download file" });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
private static string FormatFileSize(long bytes)
|
|
||||||
{
|
|
||||||
string[] sizes = { "B", "KB", "MB", "GB", "TB" };
|
|
||||||
double len = bytes;
|
|
||||||
int order = 0;
|
|
||||||
while (len >= 1024 && order < sizes.Length - 1)
|
|
||||||
{
|
|
||||||
order++;
|
|
||||||
len = len / 1024;
|
|
||||||
}
|
|
||||||
return $"{len:0.##} {sizes[order]}";
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -40,9 +40,7 @@ public class JellyfinController : ControllerBase
|
|||||||
private readonly SpotifyPlaylistFetcher? _spotifyPlaylistFetcher;
|
private readonly SpotifyPlaylistFetcher? _spotifyPlaylistFetcher;
|
||||||
private readonly SpotifyLyricsService? _spotifyLyricsService;
|
private readonly SpotifyLyricsService? _spotifyLyricsService;
|
||||||
private readonly LrclibService? _lrclibService;
|
private readonly LrclibService? _lrclibService;
|
||||||
private readonly OdesliService _odesliService;
|
|
||||||
private readonly RedisCacheService _cache;
|
private readonly RedisCacheService _cache;
|
||||||
private readonly IConfiguration _configuration;
|
|
||||||
private readonly ILogger<JellyfinController> _logger;
|
private readonly ILogger<JellyfinController> _logger;
|
||||||
|
|
||||||
public JellyfinController(
|
public JellyfinController(
|
||||||
@@ -56,9 +54,7 @@ public class JellyfinController : ControllerBase
|
|||||||
JellyfinModelMapper modelMapper,
|
JellyfinModelMapper modelMapper,
|
||||||
JellyfinProxyService proxyService,
|
JellyfinProxyService proxyService,
|
||||||
JellyfinSessionManager sessionManager,
|
JellyfinSessionManager sessionManager,
|
||||||
OdesliService odesliService,
|
|
||||||
RedisCacheService cache,
|
RedisCacheService cache,
|
||||||
IConfiguration configuration,
|
|
||||||
ILogger<JellyfinController> logger,
|
ILogger<JellyfinController> logger,
|
||||||
ParallelMetadataService? parallelMetadataService = null,
|
ParallelMetadataService? parallelMetadataService = null,
|
||||||
PlaylistSyncService? playlistSyncService = null,
|
PlaylistSyncService? playlistSyncService = null,
|
||||||
@@ -81,9 +77,7 @@ public class JellyfinController : ControllerBase
|
|||||||
_spotifyPlaylistFetcher = spotifyPlaylistFetcher;
|
_spotifyPlaylistFetcher = spotifyPlaylistFetcher;
|
||||||
_spotifyLyricsService = spotifyLyricsService;
|
_spotifyLyricsService = spotifyLyricsService;
|
||||||
_lrclibService = lrclibService;
|
_lrclibService = lrclibService;
|
||||||
_odesliService = odesliService;
|
|
||||||
_cache = cache;
|
_cache = cache;
|
||||||
_configuration = configuration;
|
|
||||||
_logger = logger;
|
_logger = logger;
|
||||||
|
|
||||||
if (string.IsNullOrWhiteSpace(_settings.Url))
|
if (string.IsNullOrWhiteSpace(_settings.Url))
|
||||||
@@ -96,7 +90,7 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Searches local Jellyfin library and external providers.
|
/// Searches local Jellyfin library and external providers.
|
||||||
/// Combines songs/albums/artists. Works with /Items and /Users/{userId}/Items.
|
/// Dedupes artists, combines songs/albums. Works with /Items and /Users/{userId}/Items.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
[HttpGet("Items", Order = 1)]
|
[HttpGet("Items", Order = 1)]
|
||||||
[HttpGet("Users/{userId}/Items", Order = 1)]
|
[HttpGet("Users/{userId}/Items", Order = 1)]
|
||||||
@@ -279,71 +273,53 @@ public class JellyfinController : ControllerBase
|
|||||||
// Parse Jellyfin results into domain models
|
// Parse Jellyfin results into domain models
|
||||||
var (localSongs, localAlbums, localArtists) = _modelMapper.ParseItemsResponse(jellyfinResult);
|
var (localSongs, localAlbums, localArtists) = _modelMapper.ParseItemsResponse(jellyfinResult);
|
||||||
|
|
||||||
// Respect source ordering (SquidWTF/Tidal has better search ranking than our fuzzy matching)
|
// Score and filter Jellyfin results by relevance
|
||||||
// Just interleave local and external results based on which source has better overall match
|
var scoredLocalSongs = ScoreSearchResults(cleanQuery, localSongs, s => s.Title, s => s.Artist, s => s.Album, isExternal: false);
|
||||||
|
var scoredLocalAlbums = ScoreSearchResults(cleanQuery, localAlbums, a => a.Title, a => a.Artist, _ => null, isExternal: false);
|
||||||
|
var scoredLocalArtists = ScoreSearchResults(cleanQuery, localArtists, a => a.Name, _ => null, _ => null, isExternal: false);
|
||||||
|
|
||||||
// Calculate average match score for each source to determine which should come first
|
// Score external results with a small boost
|
||||||
var localSongsAvgScore = localSongs.Any()
|
var scoredExternalSongs = ScoreSearchResults(cleanQuery, externalResult.Songs, s => s.Title, s => s.Artist, s => s.Album, isExternal: true);
|
||||||
? localSongs.Average(s => FuzzyMatcher.CalculateSimilarity(cleanQuery, s.Title))
|
var scoredExternalAlbums = ScoreSearchResults(cleanQuery, externalResult.Albums, a => a.Title, a => a.Artist, _ => null, isExternal: true);
|
||||||
: 0.0;
|
var scoredExternalArtists = ScoreSearchResults(cleanQuery, externalResult.Artists, a => a.Name, _ => null, _ => null, isExternal: true);
|
||||||
var externalSongsAvgScore = externalResult.Songs.Any()
|
|
||||||
? externalResult.Songs.Average(s => FuzzyMatcher.CalculateSimilarity(cleanQuery, s.Title))
|
|
||||||
: 0.0;
|
|
||||||
|
|
||||||
var localAlbumsAvgScore = localAlbums.Any()
|
// Merge and sort by score (no filtering - just reorder by relevance)
|
||||||
? localAlbums.Average(a => FuzzyMatcher.CalculateSimilarity(cleanQuery, a.Title))
|
var allSongs = scoredLocalSongs.Concat(scoredExternalSongs)
|
||||||
: 0.0;
|
.OrderByDescending(x => x.Score)
|
||||||
var externalAlbumsAvgScore = externalResult.Albums.Any()
|
.Select(x => x.Item)
|
||||||
? externalResult.Albums.Average(a => FuzzyMatcher.CalculateSimilarity(cleanQuery, a.Title))
|
.ToList();
|
||||||
: 0.0;
|
|
||||||
|
|
||||||
var localArtistsAvgScore = localArtists.Any()
|
var allAlbums = scoredLocalAlbums.Concat(scoredExternalAlbums)
|
||||||
? localArtists.Average(a => FuzzyMatcher.CalculateSimilarity(cleanQuery, a.Name))
|
.OrderByDescending(x => x.Score)
|
||||||
: 0.0;
|
.Select(x => x.Item)
|
||||||
var externalArtistsAvgScore = externalResult.Artists.Any()
|
.ToList();
|
||||||
? externalResult.Artists.Average(a => FuzzyMatcher.CalculateSimilarity(cleanQuery, a.Name))
|
|
||||||
: 0.0;
|
|
||||||
|
|
||||||
// Interleave results: put better-matching source first, preserve original ordering within each source
|
// Dedupe artists by name, keeping highest scored version
|
||||||
var allSongs = localSongsAvgScore >= externalSongsAvgScore
|
var artistScores = scoredLocalArtists.Concat(scoredExternalArtists)
|
||||||
? localSongs.Concat(externalResult.Songs).ToList()
|
.GroupBy(x => x.Item.Name, StringComparer.OrdinalIgnoreCase)
|
||||||
: externalResult.Songs.Concat(localSongs).ToList();
|
.Select(g => g.OrderByDescending(x => x.Score).First())
|
||||||
|
.OrderByDescending(x => x.Score)
|
||||||
var allAlbums = localAlbumsAvgScore >= externalAlbumsAvgScore
|
.Select(x => x.Item)
|
||||||
? localAlbums.Concat(externalResult.Albums).ToList()
|
.ToList();
|
||||||
: externalResult.Albums.Concat(localAlbums).ToList();
|
|
||||||
|
|
||||||
var allArtists = localArtistsAvgScore >= externalArtistsAvgScore
|
|
||||||
? localArtists.Concat(externalResult.Artists).ToList()
|
|
||||||
: externalResult.Artists.Concat(localArtists).ToList();
|
|
||||||
|
|
||||||
// Log results for debugging
|
|
||||||
if (_logger.IsEnabled(LogLevel.Debug))
|
|
||||||
{
|
|
||||||
_logger.LogDebug("🎵 Songs: Local avg score={LocalScore:F2}, External avg score={ExtScore:F2}, Local first={LocalFirst}",
|
|
||||||
localSongsAvgScore, externalSongsAvgScore, localSongsAvgScore >= externalSongsAvgScore);
|
|
||||||
_logger.LogDebug("💿 Albums: Local avg score={LocalScore:F2}, External avg score={ExtScore:F2}, Local first={LocalFirst}",
|
|
||||||
localAlbumsAvgScore, externalAlbumsAvgScore, localAlbumsAvgScore >= externalAlbumsAvgScore);
|
|
||||||
_logger.LogDebug("🎤 Artists: Local avg score={LocalScore:F2}, External avg score={ExtScore:F2}, Local first={LocalFirst}",
|
|
||||||
localArtistsAvgScore, externalArtistsAvgScore, localArtistsAvgScore >= externalArtistsAvgScore);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Convert to Jellyfin format
|
// Convert to Jellyfin format
|
||||||
var mergedSongs = allSongs.Select(s => _responseBuilder.ConvertSongToJellyfinItem(s)).ToList();
|
var mergedSongs = allSongs.Select(s => _responseBuilder.ConvertSongToJellyfinItem(s)).ToList();
|
||||||
var mergedAlbums = allAlbums.Select(a => _responseBuilder.ConvertAlbumToJellyfinItem(a)).ToList();
|
var mergedAlbums = allAlbums.Select(a => _responseBuilder.ConvertAlbumToJellyfinItem(a)).ToList();
|
||||||
var mergedArtists = allArtists.Select(a => _responseBuilder.ConvertArtistToJellyfinItem(a)).ToList();
|
var mergedArtists = artistScores.Select(a => _responseBuilder.ConvertArtistToJellyfinItem(a)).ToList();
|
||||||
|
|
||||||
// Add playlists (preserve their order too)
|
// Add playlists (score them too)
|
||||||
if (playlistResult.Count > 0)
|
if (playlistResult.Count > 0)
|
||||||
{
|
{
|
||||||
var playlistItems = playlistResult
|
var scoredPlaylists = playlistResult
|
||||||
.Select(p => _responseBuilder.ConvertPlaylistToJellyfinItem(p))
|
.Select(p => new { Playlist = p, Score = FuzzyMatcher.CalculateSimilarity(cleanQuery, p.Name) })
|
||||||
|
.OrderByDescending(x => x.Score)
|
||||||
|
.Select(x => _responseBuilder.ConvertPlaylistToJellyfinItem(x.Playlist))
|
||||||
.ToList();
|
.ToList();
|
||||||
|
|
||||||
mergedAlbums.AddRange(playlistItems);
|
mergedAlbums.AddRange(scoredPlaylists);
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogInformation("Merged results (preserving source order): Songs={Songs}, Albums={Albums}, Artists={Artists}",
|
_logger.LogInformation("Scored and filtered results: Songs={Songs}, Albums={Albums}, Artists={Artists}",
|
||||||
mergedSongs.Count, mergedAlbums.Count, mergedArtists.Count);
|
mergedSongs.Count, mergedAlbums.Count, mergedArtists.Count);
|
||||||
|
|
||||||
// Pre-fetch lyrics for top 3 songs in background (don't await)
|
// Pre-fetch lyrics for top 3 songs in background (don't await)
|
||||||
@@ -516,10 +492,20 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
var (localSongs, localAlbums, localArtists) = _modelMapper.ParseItemsResponse(jellyfinResult);
|
var (localSongs, localAlbums, localArtists) = _modelMapper.ParseItemsResponse(jellyfinResult);
|
||||||
|
|
||||||
// NO deduplication - merge all results and take top matches
|
// Merge and convert to search hints format
|
||||||
var allSongs = localSongs.Concat(externalResult.Songs).Take(limit).ToList();
|
var allSongs = localSongs.Concat(externalResult.Songs).Take(limit).ToList();
|
||||||
var allAlbums = localAlbums.Concat(externalResult.Albums).Take(limit).ToList();
|
var allAlbums = localAlbums.Concat(externalResult.Albums).Take(limit).ToList();
|
||||||
var allArtists = localArtists.Concat(externalResult.Artists).Take(limit).ToList();
|
|
||||||
|
// Dedupe artists by name
|
||||||
|
var artistNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||||
|
var allArtists = new List<Artist>();
|
||||||
|
foreach (var artist in localArtists.Concat(externalResult.Artists))
|
||||||
|
{
|
||||||
|
if (artistNames.Add(artist.Name))
|
||||||
|
{
|
||||||
|
allArtists.Add(artist);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
return _responseBuilder.CreateSearchHintsResponse(
|
return _responseBuilder.CreateSearchHintsResponse(
|
||||||
allSongs.Take(limit).ToList(),
|
allSongs.Take(limit).ToList(),
|
||||||
@@ -694,11 +680,27 @@ public class JellyfinController : ControllerBase
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// NO deduplication - merge all artists and sort by relevance
|
// Merge and deduplicate by name
|
||||||
// Show ALL matches (local + external) sorted by best match first
|
var artistNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||||
var mergedArtists = localArtists.Concat(externalArtists).ToList();
|
var mergedArtists = new List<Artist>();
|
||||||
|
|
||||||
_logger.LogInformation("Returning {Count} total artists (local + external, no deduplication)", mergedArtists.Count);
|
foreach (var artist in localArtists)
|
||||||
|
{
|
||||||
|
if (artistNames.Add(artist.Name))
|
||||||
|
{
|
||||||
|
mergedArtists.Add(artist);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
foreach (var artist in externalArtists)
|
||||||
|
{
|
||||||
|
if (artistNames.Add(artist.Name))
|
||||||
|
{
|
||||||
|
mergedArtists.Add(artist);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
_logger.LogInformation("Returning {Count} merged artists", mergedArtists.Count);
|
||||||
|
|
||||||
// Convert to Jellyfin format
|
// Convert to Jellyfin format
|
||||||
var artistItems = mergedArtists.Select(a => _responseBuilder.ConvertArtistToJellyfinItem(a)).ToList();
|
var artistItems = mergedArtists.Select(a => _responseBuilder.ConvertArtistToJellyfinItem(a)).ToList();
|
||||||
@@ -1065,8 +1067,7 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
if (imageBytes == null || contentType == null)
|
if (imageBytes == null || contentType == null)
|
||||||
{
|
{
|
||||||
// Return placeholder if Jellyfin doesn't have image
|
return NotFound();
|
||||||
return await GetPlaceholderImageAsync();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return File(imageBytes, contentType);
|
return File(imageBytes, contentType);
|
||||||
@@ -1083,8 +1084,7 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
if (string.IsNullOrEmpty(coverUrl))
|
if (string.IsNullOrEmpty(coverUrl))
|
||||||
{
|
{
|
||||||
// Return placeholder "no image available" image
|
return NotFound();
|
||||||
return await GetPlaceholderImageAsync();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Fetch and return the image using the proxy service's HttpClient
|
// Fetch and return the image using the proxy service's HttpClient
|
||||||
@@ -1093,8 +1093,7 @@ public class JellyfinController : ControllerBase
|
|||||||
var response = await _proxyService.HttpClient.GetAsync(coverUrl);
|
var response = await _proxyService.HttpClient.GetAsync(coverUrl);
|
||||||
if (!response.IsSuccessStatusCode)
|
if (!response.IsSuccessStatusCode)
|
||||||
{
|
{
|
||||||
// Return placeholder on fetch failure
|
return NotFound();
|
||||||
return await GetPlaceholderImageAsync();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
var imageBytes = await response.Content.ReadAsByteArrayAsync();
|
var imageBytes = await response.Content.ReadAsByteArrayAsync();
|
||||||
@@ -1104,34 +1103,10 @@ public class JellyfinController : ControllerBase
|
|||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogWarning(ex, "Failed to fetch cover art from {Url}", coverUrl);
|
_logger.LogWarning(ex, "Failed to fetch cover art from {Url}", coverUrl);
|
||||||
// Return placeholder on exception
|
return NotFound();
|
||||||
return await GetPlaceholderImageAsync();
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Returns a placeholder "no image available" image.
|
|
||||||
/// Generates a simple 1x1 transparent PNG as a minimal placeholder.
|
|
||||||
/// TODO: Replace with actual "no image available" graphic from wwwroot/placeholder.png
|
|
||||||
/// </summary>
|
|
||||||
private async Task<IActionResult> GetPlaceholderImageAsync()
|
|
||||||
{
|
|
||||||
// Check if custom placeholder exists in wwwroot
|
|
||||||
var placeholderPath = Path.Combine(Directory.GetCurrentDirectory(), "wwwroot", "placeholder.png");
|
|
||||||
if (System.IO.File.Exists(placeholderPath))
|
|
||||||
{
|
|
||||||
var imageBytes = await System.IO.File.ReadAllBytesAsync(placeholderPath);
|
|
||||||
return File(imageBytes, "image/png");
|
|
||||||
}
|
|
||||||
|
|
||||||
// Fallback: Return a 1x1 transparent PNG as minimal placeholder
|
|
||||||
var transparentPng = Convert.FromBase64String(
|
|
||||||
"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg=="
|
|
||||||
);
|
|
||||||
|
|
||||||
return File(transparentPng, "image/png");
|
|
||||||
}
|
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
|
|
||||||
#region Lyrics
|
#region Lyrics
|
||||||
@@ -1144,8 +1119,6 @@ public class JellyfinController : ControllerBase
|
|||||||
[HttpGet("Items/{itemId}/Lyrics")]
|
[HttpGet("Items/{itemId}/Lyrics")]
|
||||||
public async Task<IActionResult> GetLyrics(string itemId)
|
public async Task<IActionResult> GetLyrics(string itemId)
|
||||||
{
|
{
|
||||||
_logger.LogInformation("🎵 GetLyrics called for itemId: {ItemId}", itemId);
|
|
||||||
|
|
||||||
if (string.IsNullOrWhiteSpace(itemId))
|
if (string.IsNullOrWhiteSpace(itemId))
|
||||||
{
|
{
|
||||||
return NotFound();
|
return NotFound();
|
||||||
@@ -1153,9 +1126,6 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
var (isExternal, provider, externalId) = _localLibraryService.ParseSongId(itemId);
|
var (isExternal, provider, externalId) = _localLibraryService.ParseSongId(itemId);
|
||||||
|
|
||||||
_logger.LogInformation("🎵 Lyrics request: itemId={ItemId}, isExternal={IsExternal}, provider={Provider}, externalId={ExternalId}",
|
|
||||||
itemId, isExternal, provider, externalId);
|
|
||||||
|
|
||||||
// For local tracks, check if Jellyfin already has embedded lyrics
|
// For local tracks, check if Jellyfin already has embedded lyrics
|
||||||
if (!isExternal)
|
if (!isExternal)
|
||||||
{
|
{
|
||||||
@@ -1164,16 +1134,13 @@ public class JellyfinController : ControllerBase
|
|||||||
// Try to get lyrics from Jellyfin first (it reads embedded lyrics from files)
|
// Try to get lyrics from Jellyfin first (it reads embedded lyrics from files)
|
||||||
var (jellyfinLyrics, statusCode) = await _proxyService.GetJsonAsync($"Audio/{itemId}/Lyrics", null, Request.Headers);
|
var (jellyfinLyrics, statusCode) = await _proxyService.GetJsonAsync($"Audio/{itemId}/Lyrics", null, Request.Headers);
|
||||||
|
|
||||||
_logger.LogInformation("Jellyfin lyrics check result: statusCode={StatusCode}, hasLyrics={HasLyrics}",
|
|
||||||
statusCode, jellyfinLyrics != null);
|
|
||||||
|
|
||||||
if (jellyfinLyrics != null && statusCode == 200)
|
if (jellyfinLyrics != null && statusCode == 200)
|
||||||
{
|
{
|
||||||
_logger.LogInformation("Found embedded lyrics in Jellyfin for track {ItemId}", itemId);
|
_logger.LogInformation("Found embedded lyrics in Jellyfin for track {ItemId}", itemId);
|
||||||
return new JsonResult(JsonSerializer.Deserialize<object>(jellyfinLyrics.RootElement.GetRawText()));
|
return new JsonResult(JsonSerializer.Deserialize<object>(jellyfinLyrics.RootElement.GetRawText()));
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogInformation("No embedded lyrics found in Jellyfin (status: {StatusCode}), trying Spotify/LRCLIB", statusCode);
|
_logger.LogInformation("No embedded lyrics found in Jellyfin, trying Spotify/LRCLIB");
|
||||||
}
|
}
|
||||||
|
|
||||||
// Get song metadata for lyrics search
|
// Get song metadata for lyrics search
|
||||||
@@ -1183,53 +1150,7 @@ public class JellyfinController : ControllerBase
|
|||||||
if (isExternal)
|
if (isExternal)
|
||||||
{
|
{
|
||||||
song = await _metadataService.GetSongAsync(provider!, externalId!);
|
song = await _metadataService.GetSongAsync(provider!, externalId!);
|
||||||
|
// For Deezer tracks, we'll search Spotify by metadata
|
||||||
// Use Spotify ID from song metadata if available (populated during GetSongAsync)
|
|
||||||
if (song != null && !string.IsNullOrEmpty(song.SpotifyId))
|
|
||||||
{
|
|
||||||
spotifyTrackId = song.SpotifyId;
|
|
||||||
_logger.LogInformation("Using Spotify ID {SpotifyId} from song metadata for {Provider}/{ExternalId}",
|
|
||||||
spotifyTrackId, provider, externalId);
|
|
||||||
}
|
|
||||||
// Fallback: Try to find Spotify ID from matched tracks cache
|
|
||||||
else if (song != null)
|
|
||||||
{
|
|
||||||
spotifyTrackId = await FindSpotifyIdForExternalTrackAsync(song);
|
|
||||||
if (!string.IsNullOrEmpty(spotifyTrackId))
|
|
||||||
{
|
|
||||||
_logger.LogInformation("Found Spotify ID {SpotifyId} for external track {Provider}/{ExternalId} from cache",
|
|
||||||
spotifyTrackId, provider, externalId);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
// Last resort: Try to convert via Odesli/song.link
|
|
||||||
if (provider == "squidwtf")
|
|
||||||
{
|
|
||||||
spotifyTrackId = await _odesliService.ConvertTidalToSpotifyIdAsync(externalId!, HttpContext.RequestAborted);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
// For other providers, build the URL and convert
|
|
||||||
var sourceUrl = provider?.ToLowerInvariant() switch
|
|
||||||
{
|
|
||||||
"deezer" => $"https://www.deezer.com/track/{externalId}",
|
|
||||||
"qobuz" => $"https://www.qobuz.com/us-en/album/-/-/{externalId}",
|
|
||||||
_ => null
|
|
||||||
};
|
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(sourceUrl))
|
|
||||||
{
|
|
||||||
spotifyTrackId = await _odesliService.ConvertUrlToSpotifyIdAsync(sourceUrl, HttpContext.RequestAborted);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(spotifyTrackId))
|
|
||||||
{
|
|
||||||
_logger.LogInformation("Converted {Provider}/{ExternalId} to Spotify ID {SpotifyId} via Odesli",
|
|
||||||
provider, externalId, spotifyTrackId);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -1276,20 +1197,27 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
LyricsInfo? lyrics = null;
|
LyricsInfo? lyrics = null;
|
||||||
|
|
||||||
// Try Spotify lyrics ONLY if we have a valid Spotify track ID
|
// Try Spotify lyrics first (better synced lyrics quality)
|
||||||
// Spotify lyrics only work for tracks from injected playlists that have been matched
|
if (_spotifyLyricsService != null && _spotifyApiSettings.Enabled)
|
||||||
if (_spotifyLyricsService != null && _spotifyApiSettings.Enabled && !string.IsNullOrEmpty(spotifyTrackId))
|
|
||||||
{
|
{
|
||||||
// Validate that this is a real Spotify ID (not spotify:local or other invalid formats)
|
_logger.LogInformation("Trying Spotify lyrics for: {Artist} - {Title}", searchArtist, searchTitle);
|
||||||
var cleanSpotifyId = spotifyTrackId.Replace("spotify:track:", "").Trim();
|
|
||||||
|
|
||||||
// Spotify track IDs are 22 characters, base62 encoded
|
SpotifyLyricsResult? spotifyLyrics = null;
|
||||||
if (cleanSpotifyId.Length == 22 && !cleanSpotifyId.Contains(":") && !cleanSpotifyId.Contains("local"))
|
|
||||||
|
// If we have a Spotify track ID, use it directly
|
||||||
|
if (!string.IsNullOrEmpty(spotifyTrackId))
|
||||||
{
|
{
|
||||||
_logger.LogInformation("Trying Spotify lyrics for track ID: {SpotifyId} ({Artist} - {Title})",
|
spotifyLyrics = await _spotifyLyricsService.GetLyricsByTrackIdAsync(spotifyTrackId);
|
||||||
cleanSpotifyId, searchArtist, searchTitle);
|
}
|
||||||
|
else
|
||||||
var spotifyLyrics = await _spotifyLyricsService.GetLyricsByTrackIdAsync(cleanSpotifyId);
|
{
|
||||||
|
// Search by metadata (without [S] tags)
|
||||||
|
spotifyLyrics = await _spotifyLyricsService.SearchAndGetLyricsAsync(
|
||||||
|
searchTitle,
|
||||||
|
searchArtists.Count > 0 ? searchArtists[0] : searchArtist,
|
||||||
|
searchAlbum,
|
||||||
|
song.Duration.HasValue ? song.Duration.Value * 1000 : null);
|
||||||
|
}
|
||||||
|
|
||||||
if (spotifyLyrics != null && spotifyLyrics.Lines.Count > 0)
|
if (spotifyLyrics != null && spotifyLyrics.Lines.Count > 0)
|
||||||
{
|
{
|
||||||
@@ -1297,15 +1225,6 @@ public class JellyfinController : ControllerBase
|
|||||||
searchArtist, searchTitle, spotifyLyrics.Lines.Count, spotifyLyrics.SyncType);
|
searchArtist, searchTitle, spotifyLyrics.Lines.Count, spotifyLyrics.SyncType);
|
||||||
lyrics = _spotifyLyricsService.ToLyricsInfo(spotifyLyrics);
|
lyrics = _spotifyLyricsService.ToLyricsInfo(spotifyLyrics);
|
||||||
}
|
}
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogDebug("No Spotify lyrics found for track ID {SpotifyId}", cleanSpotifyId);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Invalid Spotify ID format: {SpotifyId}, skipping Spotify lyrics", spotifyTrackId);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Fall back to LRCLIB if no Spotify lyrics
|
// Fall back to LRCLIB if no Spotify lyrics
|
||||||
@@ -1425,122 +1344,6 @@ public class JellyfinController : ControllerBase
|
|||||||
return Ok(response);
|
return Ok(response);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Proactively fetches and caches lyrics for a track in the background.
|
|
||||||
/// Called when playback starts to ensure lyrics are ready when requested.
|
|
||||||
/// </summary>
|
|
||||||
private async Task PrefetchLyricsForTrackAsync(string itemId, bool isExternal, string? provider, string? externalId)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
Song? song = null;
|
|
||||||
string? spotifyTrackId = null;
|
|
||||||
|
|
||||||
if (isExternal && !string.IsNullOrEmpty(provider) && !string.IsNullOrEmpty(externalId))
|
|
||||||
{
|
|
||||||
// Get external track metadata
|
|
||||||
song = await _metadataService.GetSongAsync(provider, externalId);
|
|
||||||
|
|
||||||
// Try to find Spotify ID from matched tracks cache
|
|
||||||
if (song != null)
|
|
||||||
{
|
|
||||||
spotifyTrackId = await FindSpotifyIdForExternalTrackAsync(song);
|
|
||||||
|
|
||||||
// If no cached Spotify ID, try Odesli conversion
|
|
||||||
if (string.IsNullOrEmpty(spotifyTrackId) && provider == "squidwtf")
|
|
||||||
{
|
|
||||||
spotifyTrackId = await _odesliService.ConvertTidalToSpotifyIdAsync(externalId, HttpContext.RequestAborted);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
// Get local track metadata from Jellyfin
|
|
||||||
var (item, _) = await _proxyService.GetItemAsync(itemId, Request.Headers);
|
|
||||||
if (item != null && item.RootElement.TryGetProperty("Type", out var typeEl) &&
|
|
||||||
typeEl.GetString() == "Audio")
|
|
||||||
{
|
|
||||||
song = new Song
|
|
||||||
{
|
|
||||||
Title = item.RootElement.TryGetProperty("Name", out var name) ? name.GetString() ?? "" : "",
|
|
||||||
Artist = item.RootElement.TryGetProperty("AlbumArtist", out var artist) ? artist.GetString() ?? "" : "",
|
|
||||||
Album = item.RootElement.TryGetProperty("Album", out var album) ? album.GetString() ?? "" : "",
|
|
||||||
Duration = item.RootElement.TryGetProperty("RunTimeTicks", out var ticks) ? (int)(ticks.GetInt64() / 10000000) : 0
|
|
||||||
};
|
|
||||||
|
|
||||||
// Check for Spotify ID in provider IDs
|
|
||||||
if (item.RootElement.TryGetProperty("ProviderIds", out var providerIds))
|
|
||||||
{
|
|
||||||
if (providerIds.TryGetProperty("Spotify", out var spotifyId))
|
|
||||||
{
|
|
||||||
spotifyTrackId = spotifyId.GetString();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (song == null)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Could not get song metadata for lyrics prefetch: {ItemId}", itemId);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Strip [S] suffix for lyrics search
|
|
||||||
var searchTitle = song.Title.Replace(" [S]", "").Trim();
|
|
||||||
var searchArtist = song.Artist?.Replace(" [S]", "").Trim() ?? "";
|
|
||||||
var searchAlbum = song.Album?.Replace(" [S]", "").Trim() ?? "";
|
|
||||||
var searchArtists = song.Artists.Select(a => a.Replace(" [S]", "").Trim()).ToList();
|
|
||||||
|
|
||||||
if (searchArtists.Count == 0 && !string.IsNullOrEmpty(searchArtist))
|
|
||||||
{
|
|
||||||
searchArtists.Add(searchArtist);
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogDebug("🎵 Prefetching lyrics for: {Artist} - {Title}", searchArtist, searchTitle);
|
|
||||||
|
|
||||||
// Try Spotify lyrics if we have a valid Spotify track ID
|
|
||||||
if (_spotifyLyricsService != null && _spotifyApiSettings.Enabled && !string.IsNullOrEmpty(spotifyTrackId))
|
|
||||||
{
|
|
||||||
var cleanSpotifyId = spotifyTrackId.Replace("spotify:track:", "").Trim();
|
|
||||||
|
|
||||||
if (cleanSpotifyId.Length == 22 && !cleanSpotifyId.Contains(":") && !cleanSpotifyId.Contains("local"))
|
|
||||||
{
|
|
||||||
var spotifyLyrics = await _spotifyLyricsService.GetLyricsByTrackIdAsync(cleanSpotifyId);
|
|
||||||
|
|
||||||
if (spotifyLyrics != null && spotifyLyrics.Lines.Count > 0)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Prefetched Spotify lyrics for {Artist} - {Title} ({LineCount} lines)",
|
|
||||||
searchArtist, searchTitle, spotifyLyrics.Lines.Count);
|
|
||||||
return; // Success, lyrics are now cached
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Fall back to LRCLIB
|
|
||||||
if (_lrclibService != null)
|
|
||||||
{
|
|
||||||
var lyrics = await _lrclibService.GetLyricsAsync(
|
|
||||||
searchTitle,
|
|
||||||
searchArtists.ToArray(),
|
|
||||||
searchAlbum,
|
|
||||||
song.Duration ?? 0);
|
|
||||||
|
|
||||||
if (lyrics != null)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Prefetched LRCLIB lyrics for {Artist} - {Title}", searchArtist, searchTitle);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogDebug("No lyrics found for {Artist} - {Title}", searchArtist, searchTitle);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Error prefetching lyrics for track {ItemId}", itemId);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
|
|
||||||
#region Favorites
|
#region Favorites
|
||||||
@@ -1807,16 +1610,6 @@ public class JellyfinController : ControllerBase
|
|||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
// Check cache first (1 hour TTL for playlist images since they can change)
|
|
||||||
var cacheKey = $"playlist:image:{playlistId}";
|
|
||||||
var cachedImage = await _cache.GetAsync<byte[]>(cacheKey);
|
|
||||||
|
|
||||||
if (cachedImage != null)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Serving cached playlist image for {PlaylistId}", playlistId);
|
|
||||||
return File(cachedImage, "image/jpeg");
|
|
||||||
}
|
|
||||||
|
|
||||||
var (provider, externalId) = PlaylistIdHelper.ParsePlaylistId(playlistId);
|
var (provider, externalId) = PlaylistIdHelper.ParsePlaylistId(playlistId);
|
||||||
var playlist = await _metadataService.GetPlaylistAsync(provider, externalId);
|
var playlist = await _metadataService.GetPlaylistAsync(provider, externalId);
|
||||||
|
|
||||||
@@ -1833,11 +1626,6 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
var imageBytes = await response.Content.ReadAsByteArrayAsync();
|
var imageBytes = await response.Content.ReadAsByteArrayAsync();
|
||||||
var contentType = response.Content.Headers.ContentType?.ToString() ?? "image/jpeg";
|
var contentType = response.Content.Headers.ContentType?.ToString() ?? "image/jpeg";
|
||||||
|
|
||||||
// Cache for 1 hour (playlists can change, so don't cache too long)
|
|
||||||
await _cache.SetAsync(cacheKey, imageBytes, TimeSpan.FromHours(1));
|
|
||||||
_logger.LogDebug("Cached playlist image for {PlaylistId}", playlistId);
|
|
||||||
|
|
||||||
return File(imageBytes, contentType);
|
return File(imageBytes, contentType);
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
@@ -1873,43 +1661,26 @@ public class JellyfinController : ControllerBase
|
|||||||
_logger.LogInformation("Authentication request received");
|
_logger.LogInformation("Authentication request received");
|
||||||
// DO NOT log request body or detailed headers - contains password
|
// DO NOT log request body or detailed headers - contains password
|
||||||
|
|
||||||
// Forward to Jellyfin server with client headers - completely transparent proxy
|
// Forward to Jellyfin server with client headers
|
||||||
var (result, statusCode) = await _proxyService.PostJsonAsync("Users/AuthenticateByName", body, Request.Headers);
|
var (result, statusCode) = await _proxyService.PostJsonAsync("Users/AuthenticateByName", body, Request.Headers);
|
||||||
|
|
||||||
// Pass through Jellyfin's response exactly as-is (transparent proxy)
|
if (result == null)
|
||||||
if (result != null)
|
|
||||||
{
|
{
|
||||||
var responseJson = result.RootElement.GetRawText();
|
_logger.LogWarning("Authentication failed - status {StatusCode}", statusCode);
|
||||||
|
if (statusCode == 401)
|
||||||
// On successful auth, extract access token and post session capabilities in background
|
|
||||||
if (statusCode == 200)
|
|
||||||
{
|
{
|
||||||
_logger.LogInformation("Authentication successful");
|
return Unauthorized(new { error = "Invalid username or password" });
|
||||||
|
}
|
||||||
// Extract access token from response for session capabilities
|
return StatusCode(statusCode, new { error = "Authentication failed" });
|
||||||
string? accessToken = null;
|
|
||||||
if (result.RootElement.TryGetProperty("AccessToken", out var tokenEl))
|
|
||||||
{
|
|
||||||
accessToken = tokenEl.GetString();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Post session capabilities in background if we have a token
|
_logger.LogInformation("Authentication successful");
|
||||||
if (!string.IsNullOrEmpty(accessToken))
|
|
||||||
{
|
// Post session capabilities immediately after authentication
|
||||||
// Capture token in closure - don't use Request.Headers (will be disposed)
|
// This ensures Jellyfin creates a session that will show up in the dashboard
|
||||||
var token = accessToken;
|
|
||||||
_ = Task.Run(async () =>
|
|
||||||
{
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
_logger.LogDebug("🔧 Posting session capabilities after authentication");
|
_logger.LogInformation("🔧 Posting session capabilities after authentication");
|
||||||
|
|
||||||
// Build auth header with the new token
|
|
||||||
var authHeaders = new HeaderDictionary
|
|
||||||
{
|
|
||||||
["X-Emby-Token"] = token
|
|
||||||
};
|
|
||||||
|
|
||||||
var capabilities = new
|
var capabilities = new
|
||||||
{
|
{
|
||||||
PlayableMediaTypes = new[] { "Audio" },
|
PlayableMediaTypes = new[] { "Audio" },
|
||||||
@@ -1920,36 +1691,23 @@ public class JellyfinController : ControllerBase
|
|||||||
};
|
};
|
||||||
|
|
||||||
var capabilitiesJson = JsonSerializer.Serialize(capabilities);
|
var capabilitiesJson = JsonSerializer.Serialize(capabilities);
|
||||||
var (capResult, capStatus) = await _proxyService.PostJsonAsync("Sessions/Capabilities/Full", capabilitiesJson, authHeaders);
|
var (capResult, capStatus) = await _proxyService.PostJsonAsync("Sessions/Capabilities/Full", capabilitiesJson, Request.Headers);
|
||||||
|
|
||||||
if (capStatus == 204 || capStatus == 200)
|
if (capStatus == 204 || capStatus == 200)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ Session capabilities posted after auth ({StatusCode})", capStatus);
|
_logger.LogInformation("✓ Session capabilities posted after auth ({StatusCode})", capStatus);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
_logger.LogDebug("⚠ Session capabilities returned {StatusCode} after auth", capStatus);
|
_logger.LogWarning("⚠ Session capabilities returned {StatusCode} after auth", capStatus);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogDebug(ex, "Failed to post session capabilities after auth");
|
_logger.LogWarning(ex, "Failed to post session capabilities after auth, continuing anyway");
|
||||||
}
|
|
||||||
});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogWarning("Authentication failed - status {StatusCode}", statusCode);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Return Jellyfin's exact response
|
return Content(result.RootElement.GetRawText(), "application/json");
|
||||||
return Content(responseJson, "application/json");
|
|
||||||
}
|
|
||||||
|
|
||||||
// No response body from Jellyfin - return status code only
|
|
||||||
_logger.LogWarning("Authentication request returned {StatusCode} with no response body", statusCode);
|
|
||||||
return StatusCode(statusCode);
|
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
@@ -2183,7 +1941,7 @@ public class JellyfinController : ControllerBase
|
|||||||
var method = Request.Method;
|
var method = Request.Method;
|
||||||
var queryString = Request.QueryString.HasValue ? Request.QueryString.Value : "";
|
var queryString = Request.QueryString.HasValue ? Request.QueryString.Value : "";
|
||||||
|
|
||||||
_logger.LogDebug("📡 Session capabilities reported - Method: {Method}, Query: {Query}", method, queryString);
|
_logger.LogInformation("📡 Session capabilities reported - Method: {Method}, Query: {Query}", method, queryString);
|
||||||
_logger.LogInformation("Headers: {Headers}",
|
_logger.LogInformation("Headers: {Headers}",
|
||||||
string.Join(", ", Request.Headers.Where(h => h.Key.Contains("Auth", StringComparison.OrdinalIgnoreCase) || h.Key.Contains("Device", StringComparison.OrdinalIgnoreCase) || h.Key.Contains("Client", StringComparison.OrdinalIgnoreCase))
|
string.Join(", ", Request.Headers.Where(h => h.Key.Contains("Auth", StringComparison.OrdinalIgnoreCase) || h.Key.Contains("Device", StringComparison.OrdinalIgnoreCase) || h.Key.Contains("Client", StringComparison.OrdinalIgnoreCase))
|
||||||
.Select(h => $"{h.Key}={h.Value}")));
|
.Select(h => $"{h.Key}={h.Value}")));
|
||||||
@@ -2208,11 +1966,7 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
if (statusCode == 204 || statusCode == 200)
|
if (statusCode == 204 || statusCode == 200)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ Session capabilities forwarded to Jellyfin ({StatusCode})", statusCode);
|
_logger.LogInformation("✓ Session capabilities forwarded to Jellyfin ({StatusCode})", statusCode);
|
||||||
}
|
|
||||||
else if (statusCode == 401)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("⚠ Jellyfin returned 401 for capabilities (token expired)");
|
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -2246,7 +2000,7 @@ public class JellyfinController : ControllerBase
|
|||||||
}
|
}
|
||||||
Request.Body.Position = 0;
|
Request.Body.Position = 0;
|
||||||
|
|
||||||
_logger.LogDebug("📻 Playback START reported");
|
_logger.LogInformation("📻 Playback START reported");
|
||||||
|
|
||||||
// Parse the body to check if it's an external track
|
// Parse the body to check if it's an external track
|
||||||
var doc = JsonDocument.Parse(body);
|
var doc = JsonDocument.Parse(body);
|
||||||
@@ -2284,73 +2038,17 @@ public class JellyfinController : ControllerBase
|
|||||||
{
|
{
|
||||||
_logger.LogInformation("🎵 External track playback started: {Name} ({Provider}/{ExternalId})",
|
_logger.LogInformation("🎵 External track playback started: {Name} ({Provider}/{ExternalId})",
|
||||||
itemName ?? "Unknown", provider, externalId);
|
itemName ?? "Unknown", provider, externalId);
|
||||||
|
// For external tracks, we can't report to Jellyfin since it doesn't know about them
|
||||||
// Proactively fetch lyrics in background for external tracks
|
// Just return success so the client is happy
|
||||||
_ = Task.Run(async () =>
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
await PrefetchLyricsForTrackAsync(itemId, isExternal: true, provider, externalId);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Failed to prefetch lyrics for external track {ItemId}", itemId);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
// Create a ghost/fake item to report to Jellyfin so "Now Playing" shows up
|
|
||||||
// Generate a deterministic UUID from the external ID
|
|
||||||
var ghostUuid = GenerateUuidFromString(itemId);
|
|
||||||
|
|
||||||
// Build minimal playback start with just the ghost UUID
|
|
||||||
// Don't include the Item object - Jellyfin will just track the session without item details
|
|
||||||
var playbackStart = new
|
|
||||||
{
|
|
||||||
ItemId = ghostUuid,
|
|
||||||
PositionTicks = positionTicks ?? 0,
|
|
||||||
CanSeek = true,
|
|
||||||
IsPaused = false,
|
|
||||||
IsMuted = false,
|
|
||||||
PlayMethod = "DirectPlay"
|
|
||||||
};
|
|
||||||
|
|
||||||
var playbackJson = JsonSerializer.Serialize(playbackStart);
|
|
||||||
_logger.LogDebug("📤 Sending ghost playback start for external track: {Json}", playbackJson);
|
|
||||||
|
|
||||||
// Forward to Jellyfin with ghost UUID
|
|
||||||
var (ghostResult, ghostStatusCode) = await _proxyService.PostJsonAsync("Sessions/Playing", playbackJson, Request.Headers);
|
|
||||||
|
|
||||||
if (ghostStatusCode == 204 || ghostStatusCode == 200)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Ghost playback start forwarded to Jellyfin for external track ({StatusCode})", ghostStatusCode);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogWarning("⚠️ Ghost playback start returned status {StatusCode} for external track", ghostStatusCode);
|
|
||||||
}
|
|
||||||
|
|
||||||
return NoContent();
|
return NoContent();
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogInformation("🎵 Local track playback started: {Name} (ID: {ItemId})",
|
_logger.LogInformation("🎵 Local track playback started: {Name} (ID: {ItemId})",
|
||||||
itemName ?? "Unknown", itemId);
|
itemName ?? "Unknown", itemId);
|
||||||
|
|
||||||
// Proactively fetch lyrics in background for local tracks
|
|
||||||
_ = Task.Run(async () =>
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
await PrefetchLyricsForTrackAsync(itemId, isExternal: false, null, null);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Failed to prefetch lyrics for local track {ItemId}", itemId);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// For local tracks, forward playback start to Jellyfin FIRST
|
// For local tracks, forward playback start to Jellyfin FIRST
|
||||||
_logger.LogDebug("Forwarding playback start to Jellyfin...");
|
_logger.LogInformation("Forwarding playback start to Jellyfin...");
|
||||||
|
|
||||||
// Fetch full item details to include in playback report
|
// Fetch full item details to include in playback report
|
||||||
try
|
try
|
||||||
@@ -2376,7 +2074,7 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
if (statusCode == 204 || statusCode == 200)
|
if (statusCode == 204 || statusCode == 200)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ Playback start forwarded to Jellyfin ({StatusCode})", statusCode);
|
_logger.LogInformation("✓ Playback start forwarded to Jellyfin ({StatusCode})", statusCode);
|
||||||
|
|
||||||
// NOW ensure session exists with capabilities (after playback is reported)
|
// NOW ensure session exists with capabilities (after playback is reported)
|
||||||
if (!string.IsNullOrEmpty(deviceId))
|
if (!string.IsNullOrEmpty(deviceId))
|
||||||
@@ -2384,7 +2082,7 @@ public class JellyfinController : ControllerBase
|
|||||||
var sessionCreated = await _sessionManager.EnsureSessionAsync(deviceId, client ?? "Unknown", device ?? "Unknown", version ?? "1.0", Request.Headers);
|
var sessionCreated = await _sessionManager.EnsureSessionAsync(deviceId, client ?? "Unknown", device ?? "Unknown", version ?? "1.0", Request.Headers);
|
||||||
if (sessionCreated)
|
if (sessionCreated)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ SESSION: Session ensured for device {DeviceId} after playback start", deviceId);
|
_logger.LogWarning("✓ SESSION: Session ensured for device {DeviceId} after playback start", deviceId);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -2408,7 +2106,7 @@ public class JellyfinController : ControllerBase
|
|||||||
var (result, statusCode) = await _proxyService.PostJsonAsync("Sessions/Playing", body, Request.Headers);
|
var (result, statusCode) = await _proxyService.PostJsonAsync("Sessions/Playing", body, Request.Headers);
|
||||||
if (statusCode == 204 || statusCode == 200)
|
if (statusCode == 204 || statusCode == 200)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ Basic playback start forwarded to Jellyfin ({StatusCode})", statusCode);
|
_logger.LogInformation("✓ Basic playback start forwarded to Jellyfin ({StatusCode})", statusCode);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -2481,36 +2179,7 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
if (isExternal)
|
if (isExternal)
|
||||||
{
|
{
|
||||||
// For external tracks, report progress with ghost UUID to Jellyfin
|
// For external tracks, just acknowledge (no logging to avoid spam)
|
||||||
var ghostUuid = GenerateUuidFromString(itemId);
|
|
||||||
|
|
||||||
// Build progress report with ghost UUID
|
|
||||||
var progressReport = new
|
|
||||||
{
|
|
||||||
ItemId = ghostUuid,
|
|
||||||
PositionTicks = positionTicks ?? 0,
|
|
||||||
IsPaused = false,
|
|
||||||
IsMuted = false,
|
|
||||||
CanSeek = true,
|
|
||||||
PlayMethod = "DirectPlay"
|
|
||||||
};
|
|
||||||
|
|
||||||
var progressJson = JsonSerializer.Serialize(progressReport);
|
|
||||||
|
|
||||||
// Forward to Jellyfin with ghost UUID
|
|
||||||
var (progressResult, progressStatusCode) = await _proxyService.PostJsonAsync("Sessions/Playing/Progress", progressJson, Request.Headers);
|
|
||||||
|
|
||||||
// Log progress occasionally for debugging (every ~30 seconds)
|
|
||||||
if (positionTicks.HasValue)
|
|
||||||
{
|
|
||||||
var position = TimeSpan.FromTicks(positionTicks.Value);
|
|
||||||
if (position.Seconds % 30 == 0 && position.Milliseconds < 500)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("▶️ External track progress: {Position:mm\\:ss} ({Provider}/{ExternalId}) - Status: {StatusCode}",
|
|
||||||
position, provider, externalId, progressStatusCode);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return NoContent();
|
return NoContent();
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2521,14 +2190,12 @@ public class JellyfinController : ControllerBase
|
|||||||
// Only log at 10-second intervals
|
// Only log at 10-second intervals
|
||||||
if (position.Seconds % 10 == 0 && position.Milliseconds < 500)
|
if (position.Seconds % 10 == 0 && position.Milliseconds < 500)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("▶️ Progress: {Position:mm\\:ss} for item {ItemId}", position, itemId);
|
_logger.LogInformation("▶️ Progress: {Position:mm\\:ss} for item {ItemId}", position, itemId);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// For local tracks, forward to Jellyfin
|
// For local tracks, forward to Jellyfin
|
||||||
_logger.LogDebug("📤 Sending playback progress body: {Body}", body);
|
|
||||||
|
|
||||||
var (result, statusCode) = await _proxyService.PostJsonAsync("Sessions/Playing/Progress", body, Request.Headers);
|
var (result, statusCode) = await _proxyService.PostJsonAsync("Sessions/Playing/Progress", body, Request.Headers);
|
||||||
|
|
||||||
if (statusCode != 204 && statusCode != 200)
|
if (statusCode != 204 && statusCode != 200)
|
||||||
@@ -2561,7 +2228,7 @@ public class JellyfinController : ControllerBase
|
|||||||
}
|
}
|
||||||
Request.Body.Position = 0;
|
Request.Body.Position = 0;
|
||||||
|
|
||||||
_logger.LogDebug("⏹️ Playback STOPPED reported");
|
_logger.LogInformation("⏹️ Playback STOPPED reported");
|
||||||
|
|
||||||
// Parse the body to check if it's an external track
|
// Parse the body to check if it's an external track
|
||||||
var doc = JsonDocument.Parse(body);
|
var doc = JsonDocument.Parse(body);
|
||||||
@@ -2603,23 +2270,11 @@ public class JellyfinController : ControllerBase
|
|||||||
_logger.LogInformation("🎵 External track playback stopped: {Name} at {Position} ({Provider}/{ExternalId})",
|
_logger.LogInformation("🎵 External track playback stopped: {Name} at {Position} ({Provider}/{ExternalId})",
|
||||||
itemName ?? "Unknown", position, provider, externalId);
|
itemName ?? "Unknown", position, provider, externalId);
|
||||||
|
|
||||||
// Report stop to Jellyfin with ghost UUID
|
// Mark session as potentially ended after playback stops
|
||||||
var ghostUuid = GenerateUuidFromString(itemId);
|
// Wait 50 seconds for next song to start before cleaning up
|
||||||
|
if (!string.IsNullOrEmpty(deviceId))
|
||||||
var stopInfo = new
|
|
||||||
{
|
{
|
||||||
ItemId = ghostUuid,
|
_sessionManager.MarkSessionPotentiallyEnded(deviceId, TimeSpan.FromSeconds(50));
|
||||||
PositionTicks = positionTicks ?? 0
|
|
||||||
};
|
|
||||||
|
|
||||||
var stopJson = JsonSerializer.Serialize(stopInfo);
|
|
||||||
_logger.LogDebug("📤 Sending ghost playback stop for external track: {Json}", stopJson);
|
|
||||||
|
|
||||||
var (stopResult, stopStatusCode) = await _proxyService.PostJsonAsync("Sessions/Playing/Stopped", stopJson, Request.Headers);
|
|
||||||
|
|
||||||
if (stopStatusCode == 204 || stopStatusCode == 200)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Ghost playback stop forwarded to Jellyfin ({StatusCode})", stopStatusCode);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return NoContent();
|
return NoContent();
|
||||||
@@ -2630,34 +2285,12 @@ public class JellyfinController : ControllerBase
|
|||||||
}
|
}
|
||||||
|
|
||||||
// For local tracks, forward to Jellyfin
|
// For local tracks, forward to Jellyfin
|
||||||
_logger.LogDebug("Forwarding playback stop to Jellyfin...");
|
_logger.LogInformation("Forwarding playback stop to Jellyfin...");
|
||||||
|
|
||||||
// Log the body being sent for debugging
|
|
||||||
_logger.LogInformation("📤 Sending playback stop body: {Body}", body);
|
|
||||||
|
|
||||||
// Validate that body is not empty
|
|
||||||
if (string.IsNullOrWhiteSpace(body) || body == "{}")
|
|
||||||
{
|
|
||||||
_logger.LogWarning("⚠️ Playback stop body is empty, building minimal valid payload");
|
|
||||||
// Build a minimal valid PlaybackStopInfo
|
|
||||||
var stopInfo = new
|
|
||||||
{
|
|
||||||
ItemId = itemId,
|
|
||||||
PositionTicks = positionTicks ?? 0
|
|
||||||
};
|
|
||||||
body = JsonSerializer.Serialize(stopInfo);
|
|
||||||
_logger.LogInformation("📤 Built playback stop body: {Body}", body);
|
|
||||||
}
|
|
||||||
|
|
||||||
var (result, statusCode) = await _proxyService.PostJsonAsync("Sessions/Playing/Stopped", body, Request.Headers);
|
var (result, statusCode) = await _proxyService.PostJsonAsync("Sessions/Playing/Stopped", body, Request.Headers);
|
||||||
|
|
||||||
if (statusCode == 204 || statusCode == 200)
|
if (statusCode == 204 || statusCode == 200)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ Playback stop forwarded to Jellyfin ({StatusCode})", statusCode);
|
_logger.LogInformation("✓ Playback stop forwarded to Jellyfin ({StatusCode})", statusCode);
|
||||||
}
|
|
||||||
else if (statusCode == 401)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Playback stop returned 401 (token expired)");
|
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -2716,7 +2349,7 @@ public class JellyfinController : ControllerBase
|
|||||||
var queryString = Request.QueryString.HasValue ? Request.QueryString.Value : "";
|
var queryString = Request.QueryString.HasValue ? Request.QueryString.Value : "";
|
||||||
var endpoint = string.IsNullOrEmpty(path) ? $"Sessions{queryString}" : $"Sessions/{path}{queryString}";
|
var endpoint = string.IsNullOrEmpty(path) ? $"Sessions{queryString}" : $"Sessions/{path}{queryString}";
|
||||||
|
|
||||||
_logger.LogDebug("🔄 Proxying session request: {Method} {Endpoint}", method, endpoint);
|
_logger.LogInformation("🔄 Proxying session request: {Method} {Endpoint}", method, endpoint);
|
||||||
_logger.LogDebug("Session proxy headers: {Headers}",
|
_logger.LogDebug("Session proxy headers: {Headers}",
|
||||||
string.Join(", ", Request.Headers.Where(h => h.Key.Contains("Auth", StringComparison.OrdinalIgnoreCase))
|
string.Join(", ", Request.Headers.Where(h => h.Key.Contains("Auth", StringComparison.OrdinalIgnoreCase))
|
||||||
.Select(h => $"{h.Key}={h.Value}")));
|
.Select(h => $"{h.Key}={h.Value}")));
|
||||||
@@ -2746,11 +2379,11 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
if (result != null)
|
if (result != null)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ Session request proxied successfully ({StatusCode})", statusCode);
|
_logger.LogInformation("✓ Session request proxied successfully ({StatusCode})", statusCode);
|
||||||
return new JsonResult(result.RootElement.Clone());
|
return new JsonResult(result.RootElement.Clone());
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogDebug("✓ Session request proxied ({StatusCode}, no body)", statusCode);
|
_logger.LogInformation("✓ Session request proxied ({StatusCode}, no body)", statusCode);
|
||||||
return StatusCode(statusCode);
|
return StatusCode(statusCode);
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
@@ -2808,7 +2441,7 @@ public class JellyfinController : ControllerBase
|
|||||||
if (path.Contains("session", StringComparison.OrdinalIgnoreCase) ||
|
if (path.Contains("session", StringComparison.OrdinalIgnoreCase) ||
|
||||||
path.Contains("capabilit", StringComparison.OrdinalIgnoreCase))
|
path.Contains("capabilit", StringComparison.OrdinalIgnoreCase))
|
||||||
{
|
{
|
||||||
_logger.LogDebug("🔍 SESSION/CAPABILITY REQUEST: {Method} /{Path}{Query}", Request.Method, path, Request.QueryString);
|
_logger.LogWarning("🔍 SESSION/CAPABILITY REQUEST: {Method} /{Path}{Query}", Request.Method, path, Request.QueryString);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -3472,14 +3105,6 @@ public class JellyfinController : ControllerBase
|
|||||||
_logger.LogInformation("✅ Loaded {Count} playlist items from Redis cache for {Playlist}",
|
_logger.LogInformation("✅ Loaded {Count} playlist items from Redis cache for {Playlist}",
|
||||||
cachedItems.Count, spotifyPlaylistName);
|
cachedItems.Count, spotifyPlaylistName);
|
||||||
|
|
||||||
// Log sample item to verify Spotify IDs are present
|
|
||||||
if (cachedItems.Count > 0 && cachedItems[0].ContainsKey("ProviderIds"))
|
|
||||||
{
|
|
||||||
var providerIds = cachedItems[0]["ProviderIds"] as Dictionary<string, object>;
|
|
||||||
var hasSpotifyId = providerIds?.ContainsKey("Spotify") ?? false;
|
|
||||||
_logger.LogDebug("Sample cached item has Spotify ID: {HasSpotifyId}", hasSpotifyId);
|
|
||||||
}
|
|
||||||
|
|
||||||
return new JsonResult(new
|
return new JsonResult(new
|
||||||
{
|
{
|
||||||
Items = cachedItems,
|
Items = cachedItems,
|
||||||
@@ -3651,27 +3276,11 @@ public class JellyfinController : ControllerBase
|
|||||||
{
|
{
|
||||||
// Convert external song to Jellyfin item format
|
// Convert external song to Jellyfin item format
|
||||||
var externalItem = _responseBuilder.ConvertSongToJellyfinItem(matched.MatchedSong);
|
var externalItem = _responseBuilder.ConvertSongToJellyfinItem(matched.MatchedSong);
|
||||||
|
|
||||||
// Add Spotify ID to ProviderIds so lyrics can work
|
|
||||||
if (!string.IsNullOrEmpty(spotifyTrack.SpotifyId))
|
|
||||||
{
|
|
||||||
if (!externalItem.ContainsKey("ProviderIds"))
|
|
||||||
{
|
|
||||||
externalItem["ProviderIds"] = new Dictionary<string, string>();
|
|
||||||
}
|
|
||||||
|
|
||||||
var providerIds = externalItem["ProviderIds"] as Dictionary<string, string>;
|
|
||||||
if (providerIds != null && !providerIds.ContainsKey("Spotify"))
|
|
||||||
{
|
|
||||||
providerIds["Spotify"] = spotifyTrack.SpotifyId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
finalItems.Add(externalItem);
|
finalItems.Add(externalItem);
|
||||||
externalUsedCount++;
|
externalUsedCount++;
|
||||||
_logger.LogDebug("📥 Position #{Pos}: '{Title}' → EXTERNAL: {Provider}/{Id} (Spotify ID: {SpotifyId})",
|
_logger.LogDebug("📥 Position #{Pos}: '{Title}' → EXTERNAL: {Provider}/{Id}",
|
||||||
spotifyTrack.Position, spotifyTrack.Title,
|
spotifyTrack.Position, spotifyTrack.Title,
|
||||||
matched.MatchedSong.ExternalProvider, matched.MatchedSong.ExternalId, spotifyTrack.SpotifyId);
|
matched.MatchedSong.ExternalProvider, matched.MatchedSong.ExternalId);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -3822,7 +3431,8 @@ public class JellyfinController : ControllerBase
|
|||||||
{
|
{
|
||||||
Song = song,
|
Song = song,
|
||||||
TitleScore = FuzzyMatcher.CalculateSimilarity(track.Title, song.Title),
|
TitleScore = FuzzyMatcher.CalculateSimilarity(track.Title, song.Title),
|
||||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(track.Artists, song.Artist, song.Contributors)
|
// Calculate artist score by checking ALL artists match
|
||||||
|
ArtistScore = CalculateArtistMatchScore(track.Artists, song.Artist, song.Contributors)
|
||||||
})
|
})
|
||||||
.Select(x => new
|
.Select(x => new
|
||||||
{
|
{
|
||||||
@@ -3915,8 +3525,8 @@ public class JellyfinController : ControllerBase
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Build kept folder path: Artist/Album/
|
// Build kept folder path: /app/kept/Artist/Album/
|
||||||
var keptBasePath = Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "kept");
|
var keptBasePath = "/app/kept";
|
||||||
var keptArtistPath = Path.Combine(keptBasePath, PathHelper.SanitizeFileName(song.Artist));
|
var keptArtistPath = Path.Combine(keptBasePath, PathHelper.SanitizeFileName(song.Artist));
|
||||||
var keptAlbumPath = Path.Combine(keptArtistPath, PathHelper.SanitizeFileName(song.Album));
|
var keptAlbumPath = Path.Combine(keptArtistPath, PathHelper.SanitizeFileName(song.Album));
|
||||||
|
|
||||||
@@ -4212,7 +3822,7 @@ public class JellyfinController : ControllerBase
|
|||||||
var song = await _metadataService.GetSongAsync(provider!, externalId!);
|
var song = await _metadataService.GetSongAsync(provider!, externalId!);
|
||||||
if (song == null) return;
|
if (song == null) return;
|
||||||
|
|
||||||
var keptBasePath = Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "kept");
|
var keptBasePath = "/app/kept";
|
||||||
var keptArtistPath = Path.Combine(keptBasePath, PathHelper.SanitizeFileName(song.Artist));
|
var keptArtistPath = Path.Combine(keptBasePath, PathHelper.SanitizeFileName(song.Artist));
|
||||||
var keptAlbumPath = Path.Combine(keptArtistPath, PathHelper.SanitizeFileName(song.Album));
|
var keptAlbumPath = Path.Combine(keptArtistPath, PathHelper.SanitizeFileName(song.Album));
|
||||||
|
|
||||||
@@ -4512,69 +4122,5 @@ public class JellyfinController : ControllerBase
|
|||||||
|
|
||||||
return (deviceId, client, device, version);
|
return (deviceId, client, device, version);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Generates a deterministic UUID (v5) from a string.
|
|
||||||
/// This allows us to create consistent UUIDs for external track IDs.
|
|
||||||
/// </summary>
|
|
||||||
private string GenerateUuidFromString(string input)
|
|
||||||
{
|
|
||||||
// Use MD5 hash to generate a deterministic UUID
|
|
||||||
using var md5 = System.Security.Cryptography.MD5.Create();
|
|
||||||
var hash = md5.ComputeHash(System.Text.Encoding.UTF8.GetBytes(input));
|
|
||||||
|
|
||||||
// Convert to UUID format (version 5, namespace-based)
|
|
||||||
hash[6] = (byte)((hash[6] & 0x0F) | 0x50); // Version 5
|
|
||||||
hash[8] = (byte)((hash[8] & 0x3F) | 0x80); // Variant
|
|
||||||
|
|
||||||
var guid = new Guid(hash);
|
|
||||||
return guid.ToString();
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Finds the Spotify ID for an external track by searching through all playlist matched tracks caches.
|
|
||||||
/// This allows us to get Spotify lyrics for external tracks that were matched from Spotify playlists.
|
|
||||||
/// </summary>
|
|
||||||
private async Task<string?> FindSpotifyIdForExternalTrackAsync(Song externalSong)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
// Get all configured playlists
|
|
||||||
var playlists = _spotifySettings.Playlists;
|
|
||||||
|
|
||||||
// Search through each playlist's matched tracks cache
|
|
||||||
foreach (var playlist in playlists)
|
|
||||||
{
|
|
||||||
var cacheKey = $"spotify:matched:ordered:{playlist.Name}";
|
|
||||||
var matchedTracks = await _cache.GetAsync<List<MatchedTrack>>(cacheKey);
|
|
||||||
|
|
||||||
if (matchedTracks == null || matchedTracks.Count == 0)
|
|
||||||
continue;
|
|
||||||
|
|
||||||
// Look for a match by external ID
|
|
||||||
var match = matchedTracks.FirstOrDefault(t =>
|
|
||||||
t.MatchedSong != null &&
|
|
||||||
t.MatchedSong.ExternalProvider == externalSong.ExternalProvider &&
|
|
||||||
t.MatchedSong.ExternalId == externalSong.ExternalId);
|
|
||||||
|
|
||||||
if (match != null && !string.IsNullOrEmpty(match.SpotifyId))
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Found Spotify ID {SpotifyId} for {Provider}/{ExternalId} in playlist {Playlist}",
|
|
||||||
match.SpotifyId, externalSong.ExternalProvider, externalSong.ExternalId, playlist.Name);
|
|
||||||
return match.SpotifyId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogDebug("No Spotify ID found for external track {Provider}/{ExternalId}",
|
|
||||||
externalSong.ExternalProvider, externalSong.ExternalId);
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogWarning(ex, "Error finding Spotify ID for external track");
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// force rebuild Sun Jan 25 13:22:47 EST 2026
|
// force rebuild Sun Jan 25 13:22:47 EST 2026
|
||||||
|
|||||||
@@ -28,7 +28,6 @@ public class SubsonicController : ControllerBase
|
|||||||
private readonly SubsonicModelMapper _modelMapper;
|
private readonly SubsonicModelMapper _modelMapper;
|
||||||
private readonly SubsonicProxyService _proxyService;
|
private readonly SubsonicProxyService _proxyService;
|
||||||
private readonly PlaylistSyncService? _playlistSyncService;
|
private readonly PlaylistSyncService? _playlistSyncService;
|
||||||
private readonly RedisCacheService _cache;
|
|
||||||
private readonly ILogger<SubsonicController> _logger;
|
private readonly ILogger<SubsonicController> _logger;
|
||||||
|
|
||||||
public SubsonicController(
|
public SubsonicController(
|
||||||
@@ -40,7 +39,6 @@ public class SubsonicController : ControllerBase
|
|||||||
SubsonicResponseBuilder responseBuilder,
|
SubsonicResponseBuilder responseBuilder,
|
||||||
SubsonicModelMapper modelMapper,
|
SubsonicModelMapper modelMapper,
|
||||||
SubsonicProxyService proxyService,
|
SubsonicProxyService proxyService,
|
||||||
RedisCacheService cache,
|
|
||||||
ILogger<SubsonicController> logger,
|
ILogger<SubsonicController> logger,
|
||||||
PlaylistSyncService? playlistSyncService = null)
|
PlaylistSyncService? playlistSyncService = null)
|
||||||
{
|
{
|
||||||
@@ -53,7 +51,6 @@ public class SubsonicController : ControllerBase
|
|||||||
_modelMapper = modelMapper;
|
_modelMapper = modelMapper;
|
||||||
_proxyService = proxyService;
|
_proxyService = proxyService;
|
||||||
_playlistSyncService = playlistSyncService;
|
_playlistSyncService = playlistSyncService;
|
||||||
_cache = cache;
|
|
||||||
_logger = logger;
|
_logger = logger;
|
||||||
|
|
||||||
if (string.IsNullOrWhiteSpace(_subsonicSettings.Url))
|
if (string.IsNullOrWhiteSpace(_subsonicSettings.Url))
|
||||||
@@ -562,16 +559,6 @@ public class SubsonicController : ControllerBase
|
|||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
// Check cache first (1 hour TTL for playlist images since they can change)
|
|
||||||
var cacheKey = $"playlist:image:{id}";
|
|
||||||
var cachedImage = await _cache.GetAsync<byte[]>(cacheKey);
|
|
||||||
|
|
||||||
if (cachedImage != null)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Serving cached playlist cover art for {Id}", id);
|
|
||||||
return File(cachedImage, "image/jpeg");
|
|
||||||
}
|
|
||||||
|
|
||||||
var (provider, externalId) = PlaylistIdHelper.ParsePlaylistId(id);
|
var (provider, externalId) = PlaylistIdHelper.ParsePlaylistId(id);
|
||||||
var playlist = await _metadataService.GetPlaylistAsync(provider, externalId);
|
var playlist = await _metadataService.GetPlaylistAsync(provider, externalId);
|
||||||
|
|
||||||
@@ -589,11 +576,6 @@ public class SubsonicController : ControllerBase
|
|||||||
|
|
||||||
var imageBytes = await imageResponse.Content.ReadAsByteArrayAsync();
|
var imageBytes = await imageResponse.Content.ReadAsByteArrayAsync();
|
||||||
var contentType = imageResponse.Content.Headers.ContentType?.ToString() ?? "image/jpeg";
|
var contentType = imageResponse.Content.Headers.ContentType?.ToString() ?? "image/jpeg";
|
||||||
|
|
||||||
// Cache for 1 hour (playlists can change, so don't cache too long)
|
|
||||||
await _cache.SetAsync(cacheKey, imageBytes, TimeSpan.FromHours(1));
|
|
||||||
_logger.LogDebug("Cached playlist cover art for {Id}", id);
|
|
||||||
|
|
||||||
return File(imageBytes, contentType);
|
return File(imageBytes, contentType);
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
|
|||||||
@@ -2,44 +2,239 @@ using Microsoft.AspNetCore.Mvc;
|
|||||||
using Microsoft.AspNetCore.Mvc.Filters;
|
using Microsoft.AspNetCore.Mvc.Filters;
|
||||||
using Microsoft.Extensions.Options;
|
using Microsoft.Extensions.Options;
|
||||||
using allstarr.Models.Settings;
|
using allstarr.Models.Settings;
|
||||||
|
using System.Text.Json;
|
||||||
|
using System.Text.RegularExpressions;
|
||||||
|
|
||||||
namespace allstarr.Filters;
|
namespace allstarr.Filters;
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// REMOVED: Authentication filter for Jellyfin API endpoints.
|
/// Authentication filter for Jellyfin API endpoints.
|
||||||
///
|
/// Validates client credentials against configured username and API key.
|
||||||
/// This filter has been removed because Allstarr acts as a TRANSPARENT PROXY.
|
/// Clients can authenticate via:
|
||||||
/// Clients authenticate directly with Jellyfin through the proxy, not with the proxy itself.
|
/// - Authorization header: MediaBrowser Token="apikey"
|
||||||
///
|
/// - X-Emby-Token header
|
||||||
/// Authentication flow:
|
/// - Query parameter: api_key
|
||||||
/// 1. Client sends credentials to /Users/AuthenticateByName
|
/// - JSON body (for login endpoints): Username/Pw fields
|
||||||
/// 2. Proxy forwards request to Jellyfin (no validation)
|
|
||||||
/// 3. Jellyfin validates credentials and returns AccessToken
|
|
||||||
/// 4. Client uses AccessToken in subsequent requests
|
|
||||||
/// 5. Proxy forwards token to Jellyfin for validation
|
|
||||||
///
|
|
||||||
/// The proxy NEVER validates credentials or tokens - that's Jellyfin's job.
|
|
||||||
/// The proxy only forwards authentication headers transparently.
|
|
||||||
///
|
|
||||||
/// If you need to restrict access to the proxy itself, use network-level controls
|
|
||||||
/// (firewall, VPN, reverse proxy with auth) instead of application-level auth.
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public class JellyfinAuthFilter : IAsyncActionFilter
|
public partial class JellyfinAuthFilter : IAsyncActionFilter
|
||||||
{
|
{
|
||||||
|
private readonly JellyfinSettings _settings;
|
||||||
private readonly ILogger<JellyfinAuthFilter> _logger;
|
private readonly ILogger<JellyfinAuthFilter> _logger;
|
||||||
|
|
||||||
public JellyfinAuthFilter(ILogger<JellyfinAuthFilter> logger)
|
public JellyfinAuthFilter(
|
||||||
|
IOptions<JellyfinSettings> settings,
|
||||||
|
ILogger<JellyfinAuthFilter> logger)
|
||||||
{
|
{
|
||||||
|
_settings = settings.Value;
|
||||||
_logger = logger;
|
_logger = logger;
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task OnActionExecutionAsync(ActionExecutingContext context, ActionExecutionDelegate next)
|
public async Task OnActionExecutionAsync(ActionExecutingContext context, ActionExecutionDelegate next)
|
||||||
{
|
{
|
||||||
// This filter is now a no-op - all authentication is handled by Jellyfin
|
// Skip auth if no credentials configured (open mode)
|
||||||
// Keeping the class for backwards compatibility but it does nothing
|
if (string.IsNullOrEmpty(_settings.ClientUsername) || string.IsNullOrEmpty(_settings.ApiKey))
|
||||||
|
{
|
||||||
|
_logger.LogDebug("Auth skipped - no client credentials configured");
|
||||||
|
await next();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
_logger.LogTrace("JellyfinAuthFilter: Transparent proxy mode - no authentication check");
|
var request = context.HttpContext.Request;
|
||||||
|
|
||||||
|
// Try to extract credentials from various sources
|
||||||
|
var (username, token) = await ExtractCredentialsAsync(request);
|
||||||
|
|
||||||
|
// Validate credentials
|
||||||
|
if (!ValidateCredentials(username, token))
|
||||||
|
{
|
||||||
|
_logger.LogWarning("Authentication failed for user '{Username}' from {IP}",
|
||||||
|
username ?? "unknown",
|
||||||
|
context.HttpContext.Connection.RemoteIpAddress);
|
||||||
|
|
||||||
|
context.Result = new UnauthorizedObjectResult(new
|
||||||
|
{
|
||||||
|
error = "Invalid credentials",
|
||||||
|
message = "Authentication required. Provide valid username and API key."
|
||||||
|
});
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
_logger.LogDebug("Authentication successful for user '{Username}'", username);
|
||||||
await next();
|
await next();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private async Task<(string? username, string? token)> ExtractCredentialsAsync(HttpRequest request)
|
||||||
|
{
|
||||||
|
string? username = null;
|
||||||
|
string? token = null;
|
||||||
|
|
||||||
|
// 1. Check Authorization header (MediaBrowser format)
|
||||||
|
if (request.Headers.TryGetValue("Authorization", out var authHeader))
|
||||||
|
{
|
||||||
|
var authValue = authHeader.ToString();
|
||||||
|
|
||||||
|
// Parse MediaBrowser auth header: MediaBrowser Client="...", Token="..."
|
||||||
|
if (authValue.StartsWith("MediaBrowser", StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
token = ExtractTokenFromMediaBrowser(authValue);
|
||||||
|
username = ExtractUserIdFromMediaBrowser(authValue);
|
||||||
|
}
|
||||||
|
// Basic auth: Basic base64(username:password)
|
||||||
|
else if (authValue.StartsWith("Basic ", StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
(username, token) = ParseBasicAuth(authValue);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// 2. Check X-Emby-Token header
|
||||||
|
if (string.IsNullOrEmpty(token) && request.Headers.TryGetValue("X-Emby-Token", out var embyToken))
|
||||||
|
{
|
||||||
|
token = embyToken.ToString();
|
||||||
|
}
|
||||||
|
|
||||||
|
// 3. Check X-MediaBrowser-Token header
|
||||||
|
if (string.IsNullOrEmpty(token) && request.Headers.TryGetValue("X-MediaBrowser-Token", out var mbToken))
|
||||||
|
{
|
||||||
|
token = mbToken.ToString();
|
||||||
|
}
|
||||||
|
|
||||||
|
// 4. Check X-Emby-Authorization header (alternative format)
|
||||||
|
if (string.IsNullOrEmpty(token) && request.Headers.TryGetValue("X-Emby-Authorization", out var embyAuth))
|
||||||
|
{
|
||||||
|
token = ExtractTokenFromMediaBrowser(embyAuth.ToString());
|
||||||
|
if (string.IsNullOrEmpty(username))
|
||||||
|
{
|
||||||
|
username = ExtractUserIdFromMediaBrowser(embyAuth.ToString());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// 5. Check query parameters
|
||||||
|
if (string.IsNullOrEmpty(token))
|
||||||
|
{
|
||||||
|
token = request.Query["api_key"].FirstOrDefault()
|
||||||
|
?? request.Query["ApiKey"].FirstOrDefault()
|
||||||
|
?? request.Query["X-Emby-Token"].FirstOrDefault();
|
||||||
|
}
|
||||||
|
|
||||||
|
if (string.IsNullOrEmpty(username))
|
||||||
|
{
|
||||||
|
username = request.Query["userId"].FirstOrDefault()
|
||||||
|
?? request.Query["UserId"].FirstOrDefault()
|
||||||
|
?? request.Query["u"].FirstOrDefault();
|
||||||
|
}
|
||||||
|
|
||||||
|
// 6. Check JSON body for login endpoints (Jellyfin: Username/Pw, Navidrome: username/password)
|
||||||
|
if ((string.IsNullOrEmpty(username) || string.IsNullOrEmpty(token)) &&
|
||||||
|
request.ContentType?.Contains("application/json", StringComparison.OrdinalIgnoreCase) == true &&
|
||||||
|
request.ContentLength > 0)
|
||||||
|
{
|
||||||
|
var (bodyUsername, bodyPassword) = await ExtractCredentialsFromBodyAsync(request);
|
||||||
|
if (string.IsNullOrEmpty(username)) username = bodyUsername;
|
||||||
|
if (string.IsNullOrEmpty(token)) token = bodyPassword;
|
||||||
|
}
|
||||||
|
|
||||||
|
return (username, token);
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task<(string? username, string? password)> ExtractCredentialsFromBodyAsync(HttpRequest request)
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
request.EnableBuffering();
|
||||||
|
request.Body.Position = 0;
|
||||||
|
|
||||||
|
using var reader = new StreamReader(request.Body, leaveOpen: true);
|
||||||
|
var body = await reader.ReadToEndAsync();
|
||||||
|
request.Body.Position = 0;
|
||||||
|
|
||||||
|
if (string.IsNullOrEmpty(body)) return (null, null);
|
||||||
|
|
||||||
|
using var doc = JsonDocument.Parse(body);
|
||||||
|
var root = doc.RootElement;
|
||||||
|
|
||||||
|
// Try Jellyfin format: Username, Pw
|
||||||
|
string? username = null;
|
||||||
|
string? password = null;
|
||||||
|
|
||||||
|
if (root.TryGetProperty("Username", out var usernameProp))
|
||||||
|
username = usernameProp.GetString();
|
||||||
|
else if (root.TryGetProperty("username", out var usernameLowerProp))
|
||||||
|
username = usernameLowerProp.GetString();
|
||||||
|
|
||||||
|
if (root.TryGetProperty("Pw", out var pwProp))
|
||||||
|
password = pwProp.GetString();
|
||||||
|
else if (root.TryGetProperty("pw", out var pwLowerProp))
|
||||||
|
password = pwLowerProp.GetString();
|
||||||
|
else if (root.TryGetProperty("Password", out var passwordProp))
|
||||||
|
password = passwordProp.GetString();
|
||||||
|
else if (root.TryGetProperty("password", out var passwordLowerProp))
|
||||||
|
password = passwordLowerProp.GetString();
|
||||||
|
|
||||||
|
return (username, password);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogDebug(ex, "Failed to parse credentials from request body");
|
||||||
|
return (null, null);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private string? ExtractTokenFromMediaBrowser(string header)
|
||||||
|
{
|
||||||
|
var match = TokenRegex().Match(header);
|
||||||
|
return match.Success ? match.Groups[1].Value : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
private string? ExtractUserIdFromMediaBrowser(string header)
|
||||||
|
{
|
||||||
|
var match = UserIdRegex().Match(header);
|
||||||
|
return match.Success ? match.Groups[1].Value : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
private static (string? username, string? password) ParseBasicAuth(string authHeader)
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var base64 = authHeader["Basic ".Length..].Trim();
|
||||||
|
var bytes = Convert.FromBase64String(base64);
|
||||||
|
var credentials = System.Text.Encoding.UTF8.GetString(bytes);
|
||||||
|
var parts = credentials.Split(':', 2);
|
||||||
|
|
||||||
|
return parts.Length == 2 ? (parts[0], parts[1]) : (null, null);
|
||||||
|
}
|
||||||
|
catch
|
||||||
|
{
|
||||||
|
return (null, null);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private bool ValidateCredentials(string? username, string? token)
|
||||||
|
{
|
||||||
|
// Must have token (API key used as password)
|
||||||
|
if (string.IsNullOrEmpty(token))
|
||||||
|
{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Token must match API key
|
||||||
|
if (!string.Equals(token, _settings.ApiKey, StringComparison.Ordinal))
|
||||||
|
{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
// If username provided, it must match configured client username
|
||||||
|
if (!string.IsNullOrEmpty(username) &&
|
||||||
|
!string.Equals(username, _settings.ClientUsername, StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
[GeneratedRegex(@"Token=""([^""]+)""", RegexOptions.IgnoreCase)]
|
||||||
|
private static partial Regex TokenRegex();
|
||||||
|
|
||||||
|
[GeneratedRegex(@"UserId=""([^""]+)""", RegexOptions.IgnoreCase)]
|
||||||
|
private static partial Regex UserIdRegex();
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -54,7 +54,7 @@ public class WebSocketProxyMiddleware
|
|||||||
if (context.Request.Path.StartsWithSegments("/socket", StringComparison.OrdinalIgnoreCase) &&
|
if (context.Request.Path.StartsWithSegments("/socket", StringComparison.OrdinalIgnoreCase) &&
|
||||||
context.WebSockets.IsWebSocketRequest)
|
context.WebSockets.IsWebSocketRequest)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("🔌 WEBSOCKET: WebSocket connection request received from {RemoteIp}",
|
_logger.LogInformation("🔌 WEBSOCKET: WebSocket connection request received from {RemoteIp}",
|
||||||
context.Connection.RemoteIpAddress);
|
context.Connection.RemoteIpAddress);
|
||||||
|
|
||||||
await HandleWebSocketProxyAsync(context);
|
await HandleWebSocketProxyAsync(context);
|
||||||
@@ -142,7 +142,7 @@ public class WebSocketProxyMiddleware
|
|||||||
serverWebSocket.Options.SetRequestHeader("User-Agent", "Allstarr/1.0");
|
serverWebSocket.Options.SetRequestHeader("User-Agent", "Allstarr/1.0");
|
||||||
|
|
||||||
await serverWebSocket.ConnectAsync(new Uri(jellyfinWsUrl), context.RequestAborted);
|
await serverWebSocket.ConnectAsync(new Uri(jellyfinWsUrl), context.RequestAborted);
|
||||||
_logger.LogDebug("✓ WEBSOCKET: Connected to Jellyfin WebSocket");
|
_logger.LogInformation("✓ WEBSOCKET: Connected to Jellyfin WebSocket");
|
||||||
|
|
||||||
// Start bidirectional proxying
|
// Start bidirectional proxying
|
||||||
var clientToServer = ProxyMessagesAsync(clientWebSocket, serverWebSocket, "Client→Server", context.RequestAborted);
|
var clientToServer = ProxyMessagesAsync(clientWebSocket, serverWebSocket, "Client→Server", context.RequestAborted);
|
||||||
@@ -154,17 +154,9 @@ public class WebSocketProxyMiddleware
|
|||||||
_logger.LogDebug("🔌 WEBSOCKET: WebSocket proxy connection closed");
|
_logger.LogDebug("🔌 WEBSOCKET: WebSocket proxy connection closed");
|
||||||
}
|
}
|
||||||
catch (WebSocketException wsEx)
|
catch (WebSocketException wsEx)
|
||||||
{
|
|
||||||
// 403 is expected when tokens expire or session ends - don't spam logs
|
|
||||||
if (wsEx.Message.Contains("403"))
|
|
||||||
{
|
|
||||||
_logger.LogDebug("WEBSOCKET: Connection rejected with 403 (token expired or session ended)");
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
{
|
||||||
_logger.LogWarning(wsEx, "⚠️ WEBSOCKET: WebSocket error: {Message}", wsEx.Message);
|
_logger.LogWarning(wsEx, "⚠️ WEBSOCKET: WebSocket error: {Message}", wsEx.Message);
|
||||||
}
|
}
|
||||||
}
|
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogError(ex, "❌ WEBSOCKET: Error in WebSocket proxy");
|
_logger.LogError(ex, "❌ WEBSOCKET: Error in WebSocket proxy");
|
||||||
@@ -202,7 +194,7 @@ public class WebSocketProxyMiddleware
|
|||||||
// CRITICAL: Notify session manager that client disconnected
|
// CRITICAL: Notify session manager that client disconnected
|
||||||
if (!string.IsNullOrEmpty(deviceId))
|
if (!string.IsNullOrEmpty(deviceId))
|
||||||
{
|
{
|
||||||
_logger.LogDebug("🧹 WEBSOCKET: Client disconnected, removing session for device {DeviceId}", deviceId);
|
_logger.LogInformation("🧹 WEBSOCKET: Client disconnected, removing session for device {DeviceId}", deviceId);
|
||||||
await _sessionManager.RemoveSessionAsync(deviceId);
|
await _sessionManager.RemoveSessionAsync(deviceId);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -247,7 +239,7 @@ public class WebSocketProxyMiddleware
|
|||||||
if (direction == "Server→Client")
|
if (direction == "Server→Client")
|
||||||
{
|
{
|
||||||
var messageText = System.Text.Encoding.UTF8.GetString(messageBytes);
|
var messageText = System.Text.Encoding.UTF8.GetString(messageBytes);
|
||||||
_logger.LogTrace("📥 WEBSOCKET {Direction}: {Preview}",
|
_logger.LogInformation("📥 WEBSOCKET {Direction}: {Preview}",
|
||||||
direction,
|
direction,
|
||||||
messageText.Length > 500 ? messageText[..500] + "..." : messageText);
|
messageText.Length > 500 ? messageText[..500] + "..." : messageText);
|
||||||
}
|
}
|
||||||
@@ -282,7 +274,7 @@ public class WebSocketProxyMiddleware
|
|||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogDebug(ex, "WEBSOCKET {Direction}: Error proxying messages (connection closed)", direction);
|
_logger.LogWarning(ex, "⚠️ WEBSOCKET {Direction}: Error proxying messages", direction);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -44,11 +44,6 @@ public class Song
|
|||||||
/// </summary>
|
/// </summary>
|
||||||
public string? Isrc { get; set; }
|
public string? Isrc { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Spotify track ID (for lyrics and matching)
|
|
||||||
/// </summary>
|
|
||||||
public string? SpotifyId { get; set; }
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Full release date (format: YYYY-MM-DD)
|
/// Full release date (format: YYYY-MM-DD)
|
||||||
/// </summary>
|
/// </summary>
|
||||||
|
|||||||
@@ -69,11 +69,4 @@ public class SpotifyApiSettings
|
|||||||
/// Used to track cookie age and warn when it's approaching expiration (~1 year).
|
/// Used to track cookie age and warn when it's approaching expiration (~1 year).
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public string? SessionCookieSetDate { get; set; }
|
public string? SessionCookieSetDate { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// URL of the Spotify Lyrics API sidecar service.
|
|
||||||
/// Default: http://spotify-lyrics:8080 (docker-compose service name)
|
|
||||||
/// This service wraps Spotify's color-lyrics API for easier access.
|
|
||||||
/// </summary>
|
|
||||||
public string LyricsApiUrl { get; set; } = "http://spotify-lyrics:8080";
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -59,6 +59,27 @@ public class SpotifyImportSettings
|
|||||||
/// </summary>
|
/// </summary>
|
||||||
public bool Enabled { get; set; }
|
public bool Enabled { get; set; }
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Hour when Spotify Import plugin runs (24-hour format, 0-23)
|
||||||
|
/// NOTE: This setting is now optional and only used for the sync window check.
|
||||||
|
/// The fetcher will search backwards from current time for the last 48 hours,
|
||||||
|
/// so timezone confusion is avoided.
|
||||||
|
/// </summary>
|
||||||
|
public int SyncStartHour { get; set; } = 16;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Minute when Spotify Import plugin runs (0-59)
|
||||||
|
/// NOTE: This setting is now optional and only used for the sync window check.
|
||||||
|
/// </summary>
|
||||||
|
public int SyncStartMinute { get; set; } = 15;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// How many hours to search for missing tracks files after sync start time
|
||||||
|
/// This prevents the fetcher from running too frequently.
|
||||||
|
/// Set to 0 to disable the sync window check and always search on startup.
|
||||||
|
/// </summary>
|
||||||
|
public int SyncWindowHours { get; set; } = 2;
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// How often to run track matching in hours.
|
/// How often to run track matching in hours.
|
||||||
/// Spotify playlists like Discover Weekly update once per week, Release Radar updates weekly.
|
/// Spotify playlists like Discover Weekly update once per week, Release Radar updates weekly.
|
||||||
|
|||||||
@@ -22,21 +22,16 @@ static List<string> DecodeSquidWtfUrls()
|
|||||||
{
|
{
|
||||||
var encodedUrls = new[]
|
var encodedUrls = new[]
|
||||||
{
|
{
|
||||||
"aHR0cHM6Ly90cml0b24uc3F1aWQud3Rm", // triton.squid.wtf
|
"aHR0cHM6Ly90cml0b24uc3F1aWQud3Rm", // triton
|
||||||
"aHR0cHM6Ly90aWRhbC1hcGkuYmluaW11bS5vcmc=", // tidal-api.binimum.org
|
"aHR0cHM6Ly90aWRhbC1hcGkuYmluaW11bS5vcmc=", // binimum
|
||||||
"aHR0cHM6Ly90aWRhbC5raW5vcGx1cy5vbmxpbmU=", // tidal.kinoplus.online
|
"aHR0cHM6Ly90aWRhbC5raW5vcGx1cy5vbmxpbmU=", // kinoplus
|
||||||
"aHR0cHM6Ly9oaWZpLXR3by5zcG90aXNhdmVyLm5ldA==", // hifi-two.spotisaver.net
|
"aHR0cHM6Ly9oaWZpLXR3by5zcG90aXNhdmVyLm5ldA==", // spoti-2
|
||||||
"aHR0cHM6Ly9oaWZpLW9uZS5zcG90aXNhdmVyLm5ldA==", // hifi-one.spotisaver.net
|
"aHR0cHM6Ly9oaWZpLW9uZS5zcG90aXNhdmVyLm5ldA==", // spoti-1
|
||||||
"aHR0cHM6Ly93b2xmLnFxZGwuc2l0ZQ==", // wolf.qqdl.site
|
"aHR0cHM6Ly93b2xmLnFxZGwuc2l0ZQ==", // wolf
|
||||||
"aHR0cDovL2h1bmQucXFkbC5zaXRl", // hund.qqdl.site (http)
|
"aHR0cDovL2h1bmQucXFkbC5zaXRl", // hund
|
||||||
"aHR0cHM6Ly9rYXR6ZS5xcWRsLnNpdGU=", // katze.qqdl.site
|
"aHR0cHM6Ly9rYXR6ZS5xcWRsLnNpdGU=", // katze
|
||||||
"aHR0cHM6Ly92b2dlbC5xcWRsLnNpdGU=", // vogel.qqdl.site
|
"aHR0cHM6Ly92b2dlbC5xcWRsLnNpdGU=", // vogel
|
||||||
"aHR0cHM6Ly9tYXVzLnFxZGwuc2l0ZQ==", // maus.qqdl.site
|
"aHR0cHM6Ly9tYXVzLnFxZGwuc2l0ZQ==" // maus
|
||||||
"aHR0cHM6Ly9ldS1jZW50cmFsLm1vbm9jaHJvbWUudGY=", // eu-central.monochrome.tf
|
|
||||||
"aHR0cHM6Ly91cy13ZXN0Lm1vbm9jaHJvbWUudGY=", // us-west.monochrome.tf
|
|
||||||
"aHR0cHM6Ly9hcnJhbi5tb25vY2hyb21lLnRm", // arran.monochrome.tf
|
|
||||||
"aHR0cHM6Ly9hcGkubW9ub2Nocm9tZS50Zg==", // api.monochrome.tf
|
|
||||||
"aHR0cHM6Ly9odW5kLnFxZGwuc2l0ZQ==" // hund.qqdl.site (https)
|
|
||||||
};
|
};
|
||||||
|
|
||||||
return encodedUrls
|
return encodedUrls
|
||||||
@@ -358,7 +353,7 @@ builder.Services.Configure<SpotifyImportSettings>(options =>
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Log configuration at startup
|
// Log configuration at startup
|
||||||
Console.WriteLine($"Spotify Import: Enabled={options.Enabled}, MatchingInterval={options.MatchingIntervalHours}h");
|
Console.WriteLine($"Spotify Import: Enabled={options.Enabled}, SyncHour={options.SyncStartHour}:{options.SyncStartMinute:D2}, WindowHours={options.SyncWindowHours}");
|
||||||
Console.WriteLine($"Spotify Import Playlists: {options.Playlists.Count} configured");
|
Console.WriteLine($"Spotify Import Playlists: {options.Playlists.Count} configured");
|
||||||
foreach (var playlist in options.Playlists)
|
foreach (var playlist in options.Playlists)
|
||||||
{
|
{
|
||||||
@@ -384,7 +379,6 @@ else
|
|||||||
|
|
||||||
// Business services - shared across backends
|
// Business services - shared across backends
|
||||||
builder.Services.AddSingleton<RedisCacheService>();
|
builder.Services.AddSingleton<RedisCacheService>();
|
||||||
builder.Services.AddSingleton<OdesliService>();
|
|
||||||
builder.Services.AddSingleton<ILocalLibraryService, LocalLibraryService>();
|
builder.Services.AddSingleton<ILocalLibraryService, LocalLibraryService>();
|
||||||
builder.Services.AddSingleton<LrclibService>();
|
builder.Services.AddSingleton<LrclibService>();
|
||||||
|
|
||||||
@@ -465,7 +459,6 @@ else if (musicService == MusicService.SquidWTF)
|
|||||||
sp.GetRequiredService<Microsoft.Extensions.Options.IOptions<SquidWTFSettings>>(),
|
sp.GetRequiredService<Microsoft.Extensions.Options.IOptions<SquidWTFSettings>>(),
|
||||||
sp,
|
sp,
|
||||||
sp.GetRequiredService<ILogger<SquidWTFDownloadService>>(),
|
sp.GetRequiredService<ILogger<SquidWTFDownloadService>>(),
|
||||||
sp.GetRequiredService<OdesliService>(),
|
|
||||||
squidWtfApiUrls));
|
squidWtfApiUrls));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -482,19 +475,13 @@ else
|
|||||||
builder.Services.AddSingleton<IStartupValidator, SubsonicStartupValidator>();
|
builder.Services.AddSingleton<IStartupValidator, SubsonicStartupValidator>();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Register endpoint benchmark service
|
|
||||||
builder.Services.AddSingleton<EndpointBenchmarkService>();
|
|
||||||
|
|
||||||
builder.Services.AddSingleton<IStartupValidator, DeezerStartupValidator>();
|
builder.Services.AddSingleton<IStartupValidator, DeezerStartupValidator>();
|
||||||
builder.Services.AddSingleton<IStartupValidator, QobuzStartupValidator>();
|
builder.Services.AddSingleton<IStartupValidator, QobuzStartupValidator>();
|
||||||
builder.Services.AddSingleton<IStartupValidator>(sp =>
|
builder.Services.AddSingleton<IStartupValidator>(sp =>
|
||||||
new SquidWTFStartupValidator(
|
new SquidWTFStartupValidator(
|
||||||
sp.GetRequiredService<Microsoft.Extensions.Options.IOptions<SquidWTFSettings>>(),
|
sp.GetRequiredService<Microsoft.Extensions.Options.IOptions<SquidWTFSettings>>(),
|
||||||
sp.GetRequiredService<IHttpClientFactory>().CreateClient(),
|
sp.GetRequiredService<IHttpClientFactory>().CreateClient(),
|
||||||
squidWtfApiUrls,
|
squidWtfApiUrls));
|
||||||
sp.GetRequiredService<EndpointBenchmarkService>(),
|
|
||||||
sp.GetRequiredService<ILogger<SquidWTFStartupValidator>>()));
|
|
||||||
builder.Services.AddSingleton<IStartupValidator, LyricsStartupValidator>();
|
|
||||||
|
|
||||||
// Register orchestrator as hosted service
|
// Register orchestrator as hosted service
|
||||||
builder.Services.AddHostedService<StartupValidationOrchestrator>();
|
builder.Services.AddHostedService<StartupValidationOrchestrator>();
|
||||||
@@ -580,9 +567,8 @@ builder.Services.AddSingleton<allstarr.Services.Spotify.SpotifyTrackMatchingServ
|
|||||||
builder.Services.AddHostedService(sp => sp.GetRequiredService<allstarr.Services.Spotify.SpotifyTrackMatchingService>());
|
builder.Services.AddHostedService(sp => sp.GetRequiredService<allstarr.Services.Spotify.SpotifyTrackMatchingService>());
|
||||||
|
|
||||||
// Register lyrics prefetch service (prefetches lyrics for all playlist tracks)
|
// Register lyrics prefetch service (prefetches lyrics for all playlist tracks)
|
||||||
// DISABLED - No need to prefetch since Jellyfin and Spotify lyrics are fast
|
builder.Services.AddSingleton<allstarr.Services.Lyrics.LyricsPrefetchService>();
|
||||||
// builder.Services.AddSingleton<allstarr.Services.Lyrics.LyricsPrefetchService>();
|
builder.Services.AddHostedService(sp => sp.GetRequiredService<allstarr.Services.Lyrics.LyricsPrefetchService>());
|
||||||
// builder.Services.AddHostedService(sp => sp.GetRequiredService<allstarr.Services.Lyrics.LyricsPrefetchService>());
|
|
||||||
|
|
||||||
// Register MusicBrainz service for metadata enrichment
|
// Register MusicBrainz service for metadata enrichment
|
||||||
builder.Services.Configure<allstarr.Models.Settings.MusicBrainzSettings>(options =>
|
builder.Services.Configure<allstarr.Models.Settings.MusicBrainzSettings>(options =>
|
||||||
|
|||||||
@@ -31,11 +31,6 @@ public abstract class BaseDownloadService : IDownloadService
|
|||||||
protected readonly ConcurrentDictionary<string, DownloadInfo> ActiveDownloads = new();
|
protected readonly ConcurrentDictionary<string, DownloadInfo> ActiveDownloads = new();
|
||||||
protected readonly SemaphoreSlim DownloadLock = new(1, 1);
|
protected readonly SemaphoreSlim DownloadLock = new(1, 1);
|
||||||
|
|
||||||
// Rate limiting fields
|
|
||||||
private readonly SemaphoreSlim _requestLock = new(1, 1);
|
|
||||||
private DateTime _lastRequestTime = DateTime.MinValue;
|
|
||||||
private readonly int _minRequestIntervalMs = 200;
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Lazy-loaded PlaylistSyncService to avoid circular dependency
|
/// Lazy-loaded PlaylistSyncService to avoid circular dependency
|
||||||
/// </summary>
|
/// </summary>
|
||||||
@@ -95,89 +90,23 @@ public abstract class BaseDownloadService : IDownloadService
|
|||||||
|
|
||||||
public async Task<Stream> DownloadAndStreamAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default)
|
public async Task<Stream> DownloadAndStreamAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default)
|
||||||
{
|
{
|
||||||
var startTime = DateTime.UtcNow;
|
|
||||||
|
|
||||||
// Check if already downloaded locally
|
// Check if already downloaded locally
|
||||||
var localPath = await LocalLibraryService.GetLocalPathForExternalSongAsync(externalProvider, externalId);
|
var localPath = await LocalLibraryService.GetLocalPathForExternalSongAsync(externalProvider, externalId);
|
||||||
if (localPath != null && IOFile.Exists(localPath))
|
if (localPath != null && IOFile.Exists(localPath))
|
||||||
{
|
{
|
||||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
Logger.LogInformation("Streaming from local cache: {Path}", localPath);
|
||||||
Logger.LogInformation("Streaming from local cache ({ElapsedMs}ms): {Path}", elapsed, localPath);
|
|
||||||
|
|
||||||
// Update access time for cache cleanup
|
|
||||||
if (SubsonicSettings.StorageMode == StorageMode.Cache)
|
|
||||||
{
|
|
||||||
IOFile.SetLastAccessTime(localPath, DateTime.UtcNow);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Start background Odesli conversion for lyrics (if not already cached)
|
|
||||||
StartBackgroundOdesliConversion(externalProvider, externalId);
|
|
||||||
|
|
||||||
return IOFile.OpenRead(localPath);
|
return IOFile.OpenRead(localPath);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Download to disk first to ensure complete file with metadata
|
// For on-demand streaming, download to disk first to ensure complete file
|
||||||
// This is necessary because:
|
// This is necessary because:
|
||||||
// 1. Clients may seek to arbitrary positions (requires full file)
|
// 1. Clients may seek to arbitrary positions (requires full file)
|
||||||
// 2. Metadata embedding requires complete file
|
// 2. Metadata embedding requires complete file
|
||||||
// 3. Caching for future plays
|
// 3. Caching for future plays
|
||||||
Logger.LogInformation("Downloading song for streaming: {Provider}:{ExternalId}", externalProvider, externalId);
|
Logger.LogInformation("Downloading song for streaming: {Provider}:{ExternalId}", externalProvider, externalId);
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
localPath = await DownloadSongInternalAsync(externalProvider, externalId, triggerAlbumDownload: true, cancellationToken);
|
localPath = await DownloadSongInternalAsync(externalProvider, externalId, triggerAlbumDownload: true, cancellationToken);
|
||||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
|
||||||
Logger.LogInformation("Download completed, starting stream ({ElapsedMs}ms total): {Path}", elapsed, localPath);
|
|
||||||
|
|
||||||
// Start background Odesli conversion for lyrics (after stream starts)
|
|
||||||
StartBackgroundOdesliConversion(externalProvider, externalId);
|
|
||||||
|
|
||||||
return IOFile.OpenRead(localPath);
|
return IOFile.OpenRead(localPath);
|
||||||
}
|
}
|
||||||
catch (OperationCanceledException)
|
|
||||||
{
|
|
||||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
|
||||||
Logger.LogWarning("Download cancelled by client after {ElapsedMs}ms for {Provider}:{ExternalId}", elapsed, externalProvider, externalId);
|
|
||||||
throw;
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
|
||||||
Logger.LogError(ex, "Download failed after {ElapsedMs}ms for {Provider}:{ExternalId}", elapsed, externalProvider, externalId);
|
|
||||||
throw;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Starts background Odesli conversion for lyrics support.
|
|
||||||
/// This is called AFTER streaming starts so it doesn't block the client.
|
|
||||||
/// </summary>
|
|
||||||
private void StartBackgroundOdesliConversion(string externalProvider, string externalId)
|
|
||||||
{
|
|
||||||
_ = Task.Run(async () =>
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
// Provider-specific conversion (override in subclasses if needed)
|
|
||||||
await ConvertToSpotifyIdAsync(externalProvider, externalId);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
Logger.LogDebug(ex, "Background Spotify ID conversion failed for {Provider}:{ExternalId}", externalProvider, externalId);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Converts external track ID to Spotify ID for lyrics support.
|
|
||||||
/// Override in provider-specific services if needed.
|
|
||||||
/// </summary>
|
|
||||||
protected virtual Task ConvertToSpotifyIdAsync(string externalProvider, string externalId)
|
|
||||||
{
|
|
||||||
// Default implementation does nothing
|
|
||||||
// Provider-specific services can override this
|
|
||||||
return Task.CompletedTask;
|
|
||||||
}
|
|
||||||
|
|
||||||
public DownloadInfo? GetDownloadStatus(string songId)
|
public DownloadInfo? GetDownloadStatus(string songId)
|
||||||
{
|
{
|
||||||
@@ -192,13 +121,20 @@ public abstract class BaseDownloadService : IDownloadService
|
|||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check local library (works for both cache and permanent storage)
|
// Check local library
|
||||||
var localPath = await LocalLibraryService.GetLocalPathForExternalSongAsync(externalProvider, externalId);
|
var localPath = await LocalLibraryService.GetLocalPathForExternalSongAsync(externalProvider, externalId);
|
||||||
if (localPath != null && IOFile.Exists(localPath))
|
if (localPath != null && IOFile.Exists(localPath))
|
||||||
{
|
{
|
||||||
return localPath;
|
return localPath;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Check cache directory
|
||||||
|
var cachedPath = GetCachedFilePath(externalProvider, externalId);
|
||||||
|
if (cachedPath != null && IOFile.Exists(cachedPath))
|
||||||
|
{
|
||||||
|
return cachedPath;
|
||||||
|
}
|
||||||
|
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -267,44 +203,47 @@ public abstract class BaseDownloadService : IDownloadService
|
|||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
// Check if already downloaded (works for both cache and permanent modes)
|
// Check if already downloaded (skip for cache mode as we want to check cache folder)
|
||||||
|
if (!isCache)
|
||||||
|
{
|
||||||
var existingPath = await LocalLibraryService.GetLocalPathForExternalSongAsync(externalProvider, externalId);
|
var existingPath = await LocalLibraryService.GetLocalPathForExternalSongAsync(externalProvider, externalId);
|
||||||
if (existingPath != null && IOFile.Exists(existingPath))
|
if (existingPath != null && IOFile.Exists(existingPath))
|
||||||
{
|
{
|
||||||
Logger.LogInformation("Song already downloaded: {Path}", existingPath);
|
Logger.LogInformation("Song already downloaded: {Path}", existingPath);
|
||||||
|
|
||||||
// For cache mode, update file access time for cache cleanup logic
|
|
||||||
if (isCache)
|
|
||||||
{
|
|
||||||
IOFile.SetLastAccessTime(existingPath, DateTime.UtcNow);
|
|
||||||
}
|
|
||||||
|
|
||||||
return existingPath;
|
return existingPath;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
// For cache mode, check if file exists in cache directory
|
||||||
|
var cachedPath = GetCachedFilePath(externalProvider, externalId);
|
||||||
|
if (cachedPath != null && IOFile.Exists(cachedPath))
|
||||||
|
{
|
||||||
|
Logger.LogInformation("Song found in cache: {Path}", cachedPath);
|
||||||
|
// Update file access time for cache cleanup logic
|
||||||
|
IOFile.SetLastAccessTime(cachedPath, DateTime.UtcNow);
|
||||||
|
return cachedPath;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Check if download in progress
|
// Check if download in progress
|
||||||
if (ActiveDownloads.TryGetValue(songId, out var activeDownload) && activeDownload.Status == DownloadStatus.InProgress)
|
if (ActiveDownloads.TryGetValue(songId, out var activeDownload) && activeDownload.Status == DownloadStatus.InProgress)
|
||||||
{
|
{
|
||||||
Logger.LogDebug("Download already in progress for {SongId}, waiting for completion...", songId);
|
Logger.LogInformation("Download already in progress for {SongId}, waiting...", songId);
|
||||||
// Release lock while waiting
|
// Release lock while waiting
|
||||||
DownloadLock.Release();
|
DownloadLock.Release();
|
||||||
|
|
||||||
// Wait for download to complete, checking every 100ms (faster than 500ms)
|
|
||||||
// Also respect cancellation token so client timeouts are handled immediately
|
|
||||||
while (ActiveDownloads.TryGetValue(songId, out activeDownload) && activeDownload.Status == DownloadStatus.InProgress)
|
while (ActiveDownloads.TryGetValue(songId, out activeDownload) && activeDownload.Status == DownloadStatus.InProgress)
|
||||||
{
|
{
|
||||||
cancellationToken.ThrowIfCancellationRequested();
|
await Task.Delay(500, cancellationToken);
|
||||||
await Task.Delay(100, cancellationToken);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if (activeDownload?.Status == DownloadStatus.Completed && activeDownload.LocalPath != null)
|
if (activeDownload?.Status == DownloadStatus.Completed && activeDownload.LocalPath != null)
|
||||||
{
|
{
|
||||||
Logger.LogDebug("Download completed while waiting, returning path: {Path}", activeDownload.LocalPath);
|
|
||||||
return activeDownload.LocalPath;
|
return activeDownload.LocalPath;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Download failed or was cancelled
|
throw new Exception(activeDownload?.ErrorMessage ?? "Download failed");
|
||||||
throw new Exception(activeDownload?.ErrorMessage ?? "Download failed while waiting");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Get metadata
|
// Get metadata
|
||||||
@@ -638,34 +577,29 @@ public abstract class BaseDownloadService : IDownloadService
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
#endregion
|
|
||||||
|
|
||||||
#region Rate Limiting
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Queues a request with rate limiting to prevent overwhelming the API.
|
/// Gets the cached file path for a given provider and external ID
|
||||||
/// Ensures minimum interval between requests.
|
/// Returns null if no cached file exists
|
||||||
/// </summary>
|
/// </summary>
|
||||||
protected async Task<T> QueueRequestAsync<T>(Func<Task<T>> action)
|
protected string? GetCachedFilePath(string provider, string externalId)
|
||||||
{
|
{
|
||||||
await _requestLock.WaitAsync();
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
var now = DateTime.UtcNow;
|
// Search for cached files matching the pattern: {provider}_{externalId}.*
|
||||||
var timeSinceLastRequest = (now - _lastRequestTime).TotalMilliseconds;
|
var pattern = $"{provider}_{externalId}.*";
|
||||||
|
var files = Directory.GetFiles(CachePath, pattern, SearchOption.AllDirectories);
|
||||||
|
|
||||||
if (timeSinceLastRequest < _minRequestIntervalMs)
|
if (files.Length > 0)
|
||||||
{
|
{
|
||||||
await Task.Delay((int)(_minRequestIntervalMs - timeSinceLastRequest));
|
return files[0]; // Return first match
|
||||||
}
|
}
|
||||||
|
|
||||||
_lastRequestTime = DateTime.UtcNow;
|
return null;
|
||||||
return await action();
|
|
||||||
}
|
}
|
||||||
finally
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_requestLock.Release();
|
Logger.LogWarning(ex, "Failed to search for cached file: {Provider}_{ExternalId}", provider, externalId);
|
||||||
|
return null;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -94,16 +94,16 @@ public class CacheCleanupService : BackgroundService
|
|||||||
{
|
{
|
||||||
var fileInfo = new FileInfo(filePath);
|
var fileInfo = new FileInfo(filePath);
|
||||||
|
|
||||||
// Use last write time (when file was created/downloaded) to determine if file should be deleted
|
// Use last access time to determine if file should be deleted
|
||||||
// LastAccessTime is unreliable on many filesystems (noatime mount option)
|
// This gets updated when a cached file is streamed
|
||||||
if (fileInfo.LastWriteTimeUtc < cutoffTime)
|
if (fileInfo.LastAccessTimeUtc < cutoffTime)
|
||||||
{
|
{
|
||||||
var size = fileInfo.Length;
|
var size = fileInfo.Length;
|
||||||
File.Delete(filePath);
|
File.Delete(filePath);
|
||||||
deletedCount++;
|
deletedCount++;
|
||||||
totalSize += size;
|
totalSize += size;
|
||||||
_logger.LogDebug("Deleted cached file: {Path} (age: {Age:F1} hours)",
|
_logger.LogDebug("Deleted cached file: {Path} (last accessed: {LastAccess})",
|
||||||
filePath, (DateTime.UtcNow - fileInfo.LastWriteTimeUtc).TotalHours);
|
filePath, fileInfo.LastAccessTimeUtc);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
|
|||||||
@@ -1,135 +0,0 @@
|
|||||||
using System.Diagnostics;
|
|
||||||
|
|
||||||
namespace allstarr.Services.Common;
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Benchmarks API endpoints on startup and maintains performance metrics.
|
|
||||||
/// Used to prioritize faster endpoints in racing scenarios.
|
|
||||||
/// </summary>
|
|
||||||
public class EndpointBenchmarkService
|
|
||||||
{
|
|
||||||
private readonly ILogger<EndpointBenchmarkService> _logger;
|
|
||||||
private readonly Dictionary<string, EndpointMetrics> _metrics = new();
|
|
||||||
private readonly SemaphoreSlim _lock = new(1, 1);
|
|
||||||
|
|
||||||
public EndpointBenchmarkService(ILogger<EndpointBenchmarkService> logger)
|
|
||||||
{
|
|
||||||
_logger = logger;
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Benchmarks a list of endpoints by making test requests.
|
|
||||||
/// Returns endpoints sorted by average response time (fastest first).
|
|
||||||
/// </summary>
|
|
||||||
public async Task<List<string>> BenchmarkEndpointsAsync(
|
|
||||||
List<string> endpoints,
|
|
||||||
Func<string, CancellationToken, Task<bool>> testFunc,
|
|
||||||
int pingCount = 3,
|
|
||||||
CancellationToken cancellationToken = default)
|
|
||||||
{
|
|
||||||
_logger.LogInformation("🏁 Benchmarking {Count} endpoints with {Pings} pings each...", endpoints.Count, pingCount);
|
|
||||||
|
|
||||||
var tasks = endpoints.Select(async endpoint =>
|
|
||||||
{
|
|
||||||
var sw = Stopwatch.StartNew();
|
|
||||||
var successCount = 0;
|
|
||||||
var totalMs = 0L;
|
|
||||||
|
|
||||||
for (int i = 0; i < pingCount; i++)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var pingStart = Stopwatch.GetTimestamp();
|
|
||||||
var success = await testFunc(endpoint, cancellationToken);
|
|
||||||
var pingMs = Stopwatch.GetElapsedTime(pingStart).TotalMilliseconds;
|
|
||||||
|
|
||||||
if (success)
|
|
||||||
{
|
|
||||||
successCount++;
|
|
||||||
totalMs += (long)pingMs;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Benchmark ping failed for {Endpoint}", endpoint);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Small delay between pings
|
|
||||||
if (i < pingCount - 1)
|
|
||||||
{
|
|
||||||
await Task.Delay(100, cancellationToken);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
sw.Stop();
|
|
||||||
|
|
||||||
var avgMs = successCount > 0 ? totalMs / successCount : long.MaxValue;
|
|
||||||
var metrics = new EndpointMetrics
|
|
||||||
{
|
|
||||||
Endpoint = endpoint,
|
|
||||||
AverageResponseMs = avgMs,
|
|
||||||
SuccessRate = (double)successCount / pingCount,
|
|
||||||
LastBenchmark = DateTime.UtcNow
|
|
||||||
};
|
|
||||||
|
|
||||||
await _lock.WaitAsync(cancellationToken);
|
|
||||||
try
|
|
||||||
{
|
|
||||||
_metrics[endpoint] = metrics;
|
|
||||||
}
|
|
||||||
finally
|
|
||||||
{
|
|
||||||
_lock.Release();
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogInformation(" {Endpoint}: {AvgMs}ms avg, {SuccessRate:P0} success rate",
|
|
||||||
endpoint, avgMs, metrics.SuccessRate);
|
|
||||||
|
|
||||||
return metrics;
|
|
||||||
}).ToList();
|
|
||||||
|
|
||||||
var results = await Task.WhenAll(tasks);
|
|
||||||
|
|
||||||
// Sort by: success rate first (must be > 0), then by average response time
|
|
||||||
var sorted = results
|
|
||||||
.Where(m => m.SuccessRate > 0)
|
|
||||||
.OrderByDescending(m => m.SuccessRate)
|
|
||||||
.ThenBy(m => m.AverageResponseMs)
|
|
||||||
.Select(m => m.Endpoint)
|
|
||||||
.ToList();
|
|
||||||
|
|
||||||
_logger.LogInformation("✅ Benchmark complete. Fastest: {Fastest} ({Ms}ms)",
|
|
||||||
sorted.FirstOrDefault() ?? "none",
|
|
||||||
results.Where(m => m.SuccessRate > 0).MinBy(m => m.AverageResponseMs)?.AverageResponseMs ?? 0);
|
|
||||||
|
|
||||||
return sorted;
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Gets the metrics for a specific endpoint.
|
|
||||||
/// </summary>
|
|
||||||
public EndpointMetrics? GetMetrics(string endpoint)
|
|
||||||
{
|
|
||||||
_metrics.TryGetValue(endpoint, out var metrics);
|
|
||||||
return metrics;
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Gets all endpoint metrics sorted by performance.
|
|
||||||
/// </summary>
|
|
||||||
public List<EndpointMetrics> GetAllMetrics()
|
|
||||||
{
|
|
||||||
return _metrics.Values
|
|
||||||
.OrderByDescending(m => m.SuccessRate)
|
|
||||||
.ThenBy(m => m.AverageResponseMs)
|
|
||||||
.ToList();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
public class EndpointMetrics
|
|
||||||
{
|
|
||||||
public string Endpoint { get; set; } = string.Empty;
|
|
||||||
public long AverageResponseMs { get; set; }
|
|
||||||
public double SuccessRate { get; set; }
|
|
||||||
public DateTime LastBenchmark { get; set; }
|
|
||||||
}
|
|
||||||
@@ -2,64 +2,12 @@ namespace allstarr.Services.Common;
|
|||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Provides fuzzy string matching for search result scoring.
|
/// Provides fuzzy string matching for search result scoring.
|
||||||
/// OPTIMAL ORDER: 1. Strip decorators → 2. Substring matching → 3. Levenshtein → 4. Greedy assignment
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public static class FuzzyMatcher
|
public static class FuzzyMatcher
|
||||||
{
|
{
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// STEP 1: Strips common decorators from track titles to improve matching.
|
/// Calculates a similarity score between two strings (0-100).
|
||||||
/// Removes: (feat. X), (with Y), (ft. Z), - From "Album", [Remix], etc.
|
/// Higher score means better match.
|
||||||
/// This MUST be done first to avoid systematic noise in matching.
|
|
||||||
/// </summary>
|
|
||||||
public static string StripDecorators(string title)
|
|
||||||
{
|
|
||||||
if (string.IsNullOrWhiteSpace(title))
|
|
||||||
{
|
|
||||||
return string.Empty;
|
|
||||||
}
|
|
||||||
|
|
||||||
var cleaned = title;
|
|
||||||
|
|
||||||
// Remove (feat. ...), (ft. ...), (with ...), (featuring ...)
|
|
||||||
cleaned = System.Text.RegularExpressions.Regex.Replace(
|
|
||||||
cleaned,
|
|
||||||
@"\s*[\(\[]?\s*(feat\.?|ft\.?|with|featuring)\s+[^\)\]]+[\)\]]?",
|
|
||||||
"",
|
|
||||||
System.Text.RegularExpressions.RegexOptions.IgnoreCase);
|
|
||||||
|
|
||||||
// Remove - From "Album Name" or - From Album Name
|
|
||||||
cleaned = System.Text.RegularExpressions.Regex.Replace(
|
|
||||||
cleaned,
|
|
||||||
@"\s*-\s*from\s+[""']?[^""']+[""']?",
|
|
||||||
"",
|
|
||||||
System.Text.RegularExpressions.RegexOptions.IgnoreCase);
|
|
||||||
|
|
||||||
// Remove - Remastered, - Radio Edit, etc.
|
|
||||||
cleaned = System.Text.RegularExpressions.Regex.Replace(
|
|
||||||
cleaned,
|
|
||||||
@"\s*-\s*(remaster|radio edit|single version|album version|extended|original mix)[^\-]*",
|
|
||||||
"",
|
|
||||||
System.Text.RegularExpressions.RegexOptions.IgnoreCase);
|
|
||||||
|
|
||||||
// Remove [Remix], [Remaster], [Live], [Explicit], etc.
|
|
||||||
cleaned = System.Text.RegularExpressions.Regex.Replace(
|
|
||||||
cleaned,
|
|
||||||
@"\s*[\[\(](remix|remaster|live|acoustic|radio edit|explicit|clean|official|audio|video|lyric)[^\]\)]*[\]\)]",
|
|
||||||
"",
|
|
||||||
System.Text.RegularExpressions.RegexOptions.IgnoreCase);
|
|
||||||
|
|
||||||
// Remove trailing/leading whitespace and normalize
|
|
||||||
cleaned = cleaned.Trim();
|
|
||||||
|
|
||||||
return cleaned;
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Calculates similarity score following OPTIMAL ORDER:
|
|
||||||
/// 1. Strip decorators (already done by caller)
|
|
||||||
/// 2. Substring matching (cheap, high-precision)
|
|
||||||
/// 3. Levenshtein distance (expensive, fuzzy)
|
|
||||||
/// Returns score 0-100.
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public static int CalculateSimilarity(string query, string target)
|
public static int CalculateSimilarity(string query, string target)
|
||||||
{
|
{
|
||||||
@@ -68,87 +16,47 @@ public static class FuzzyMatcher
|
|||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
var queryNorm = NormalizeForMatching(query);
|
var queryLower = NormalizeForMatching(query);
|
||||||
var targetNorm = NormalizeForMatching(target);
|
var targetLower = NormalizeForMatching(target);
|
||||||
|
|
||||||
// STEP 2: SUBSTRING MATCHING (cheap, high-precision)
|
|
||||||
|
|
||||||
// Exact match
|
// Exact match
|
||||||
if (queryNorm == targetNorm)
|
if (queryLower == targetLower)
|
||||||
{
|
{
|
||||||
return 100;
|
return 100;
|
||||||
}
|
}
|
||||||
|
|
||||||
// One string fully contains the other (substring match)
|
|
||||||
// Example: "luther" ⊂ "luther remastered" → instant win
|
|
||||||
if (targetNorm.Contains(queryNorm) || queryNorm.Contains(targetNorm))
|
|
||||||
{
|
|
||||||
return 95;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Starts with query
|
// Starts with query
|
||||||
if (targetNorm.StartsWith(queryNorm) || queryNorm.StartsWith(targetNorm))
|
if (targetLower.StartsWith(queryLower))
|
||||||
{
|
{
|
||||||
return 90;
|
return 90;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Contains query as whole word
|
// Contains query as whole word
|
||||||
if (targetNorm.Contains($" {queryNorm} ") ||
|
if (targetLower.Contains($" {queryLower} ") ||
|
||||||
targetNorm.StartsWith($"{queryNorm} ") ||
|
targetLower.StartsWith($"{queryLower} ") ||
|
||||||
targetNorm.EndsWith($" {queryNorm}") ||
|
targetLower.EndsWith($" {queryLower}"))
|
||||||
queryNorm.Contains($" {targetNorm} ") ||
|
|
||||||
queryNorm.StartsWith($"{targetNorm} ") ||
|
|
||||||
queryNorm.EndsWith($" {targetNorm}"))
|
|
||||||
{
|
{
|
||||||
return 85;
|
return 80;
|
||||||
}
|
}
|
||||||
|
|
||||||
// STEP 3: LEVENSHTEIN DISTANCE (expensive, fuzzy)
|
// Contains query anywhere
|
||||||
// Only use this for candidates that survived substring checks
|
if (targetLower.Contains(queryLower))
|
||||||
|
{
|
||||||
|
return 70;
|
||||||
|
}
|
||||||
|
|
||||||
var distance = LevenshteinDistance(queryNorm, targetNorm);
|
// Calculate Levenshtein distance for fuzzy matching
|
||||||
var maxLength = Math.Max(queryNorm.Length, targetNorm.Length);
|
var distance = LevenshteinDistance(queryLower, targetLower);
|
||||||
|
var maxLength = Math.Max(queryLower.Length, targetLower.Length);
|
||||||
|
|
||||||
if (maxLength == 0)
|
if (maxLength == 0)
|
||||||
{
|
{
|
||||||
return 100;
|
return 100;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Normalize distance by length: score = 1 - (distance / max_length)
|
// Convert distance to similarity score (0-60 range for fuzzy matches)
|
||||||
var normalizedSimilarity = 1.0 - ((double)distance / maxLength);
|
var similarity = (1.0 - (double)distance / maxLength) * 60;
|
||||||
|
return (int)Math.Max(0, similarity);
|
||||||
// Convert to 0-80 range (reserve 80-100 for substring matches)
|
|
||||||
var score = (int)(normalizedSimilarity * 80);
|
|
||||||
|
|
||||||
return Math.Max(0, score);
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// AGGRESSIVE matching that follows optimal order:
|
|
||||||
/// 1. Strip decorators FIRST
|
|
||||||
/// 2. Substring matching
|
|
||||||
/// 3. Levenshtein distance
|
|
||||||
/// Returns the best score.
|
|
||||||
/// </summary>
|
|
||||||
public static int CalculateSimilarityAggressive(string query, string target)
|
|
||||||
{
|
|
||||||
if (string.IsNullOrWhiteSpace(query) || string.IsNullOrWhiteSpace(target))
|
|
||||||
{
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
// STEP 1: Strip decorators FIRST (always)
|
|
||||||
var queryStripped = StripDecorators(query);
|
|
||||||
var targetStripped = StripDecorators(target);
|
|
||||||
|
|
||||||
// STEP 2-3: Substring matching + Levenshtein
|
|
||||||
var strippedScore = CalculateSimilarity(queryStripped, targetStripped);
|
|
||||||
|
|
||||||
// Also try without stripping in case decorators are part of the actual title
|
|
||||||
var rawScore = CalculateSimilarity(query, target);
|
|
||||||
|
|
||||||
// Return the best score
|
|
||||||
return Math.Max(rawScore, strippedScore);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
@@ -221,54 +129,4 @@ public static class FuzzyMatcher
|
|||||||
|
|
||||||
return distance[sourceLength, targetLength];
|
return distance[sourceLength, targetLength];
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Calculates artist match score between Spotify artists and local song artists.
|
|
||||||
/// Checks bidirectional matching and penalizes mismatches.
|
|
||||||
/// Penalizes if artist counts don't match or if any artist is missing.
|
|
||||||
/// Returns score 0-100.
|
|
||||||
/// </summary>
|
|
||||||
public static double CalculateArtistMatchScore(List<string> spotifyArtists, string songMainArtist, List<string> songContributors)
|
|
||||||
{
|
|
||||||
if (spotifyArtists.Count == 0 || string.IsNullOrEmpty(songMainArtist))
|
|
||||||
return 0;
|
|
||||||
|
|
||||||
// Build list of all song artists (main + contributors)
|
|
||||||
var allSongArtists = new List<string> { songMainArtist };
|
|
||||||
allSongArtists.AddRange(songContributors);
|
|
||||||
|
|
||||||
// If artist counts differ significantly, penalize
|
|
||||||
var countDiff = Math.Abs(spotifyArtists.Count - allSongArtists.Count);
|
|
||||||
if (countDiff > 1) // Allow 1 artist difference (sometimes features are listed differently)
|
|
||||||
return 0;
|
|
||||||
|
|
||||||
// Check that each Spotify artist has a good match in song artists
|
|
||||||
var spotifyScores = new List<double>();
|
|
||||||
foreach (var spotifyArtist in spotifyArtists)
|
|
||||||
{
|
|
||||||
var bestMatch = allSongArtists.Max(songArtist =>
|
|
||||||
CalculateSimilarity(spotifyArtist, songArtist));
|
|
||||||
spotifyScores.Add(bestMatch);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Check that each song artist has a good match in Spotify artists
|
|
||||||
var songScores = new List<double>();
|
|
||||||
foreach (var songArtist in allSongArtists)
|
|
||||||
{
|
|
||||||
var bestMatch = spotifyArtists.Max(spotifyArtist =>
|
|
||||||
CalculateSimilarity(songArtist, spotifyArtist));
|
|
||||||
songScores.Add(bestMatch);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Average all scores - this ensures ALL artists must match well
|
|
||||||
var allScores = spotifyScores.Concat(songScores);
|
|
||||||
var avgScore = allScores.Average();
|
|
||||||
|
|
||||||
// Penalize if any individual artist match is poor (< 70)
|
|
||||||
var minScore = allScores.Min();
|
|
||||||
if (minScore < 70)
|
|
||||||
avgScore *= 0.7; // 30% penalty for poor individual match
|
|
||||||
|
|
||||||
return avgScore;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,143 +0,0 @@
|
|||||||
using System.Text.Json;
|
|
||||||
using Microsoft.Extensions.Logging;
|
|
||||||
|
|
||||||
namespace allstarr.Services.Common;
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Service for converting music URLs between platforms using Odesli/song.link API
|
|
||||||
/// </summary>
|
|
||||||
public class OdesliService
|
|
||||||
{
|
|
||||||
private readonly HttpClient _httpClient;
|
|
||||||
private readonly ILogger<OdesliService> _logger;
|
|
||||||
private readonly RedisCacheService _cache;
|
|
||||||
|
|
||||||
public OdesliService(
|
|
||||||
IHttpClientFactory httpClientFactory,
|
|
||||||
ILogger<OdesliService> logger,
|
|
||||||
RedisCacheService cache)
|
|
||||||
{
|
|
||||||
_httpClient = httpClientFactory.CreateClient();
|
|
||||||
_logger = logger;
|
|
||||||
_cache = cache;
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Converts a Tidal track ID to a Spotify track ID using Odesli
|
|
||||||
/// Results are cached for 7 days
|
|
||||||
/// </summary>
|
|
||||||
public async Task<string?> ConvertTidalToSpotifyIdAsync(string tidalTrackId, CancellationToken cancellationToken = default)
|
|
||||||
{
|
|
||||||
// Check cache first (7 day TTL - these mappings don't change)
|
|
||||||
var cacheKey = $"odesli:tidal-to-spotify:{tidalTrackId}";
|
|
||||||
var cached = await _cache.GetAsync<string>(cacheKey);
|
|
||||||
if (!string.IsNullOrEmpty(cached))
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Using cached Spotify ID for Tidal track {TidalId}", tidalTrackId);
|
|
||||||
return cached;
|
|
||||||
}
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var tidalUrl = $"https://tidal.com/browse/track/{tidalTrackId}";
|
|
||||||
var odesliUrl = $"https://api.song.link/v1-alpha.1/links?url={Uri.EscapeDataString(tidalUrl)}&userCountry=US";
|
|
||||||
|
|
||||||
_logger.LogDebug("🔗 Converting Tidal track {TidalId} to Spotify ID via Odesli", tidalTrackId);
|
|
||||||
|
|
||||||
var odesliResponse = await _httpClient.GetAsync(odesliUrl, cancellationToken);
|
|
||||||
if (odesliResponse.IsSuccessStatusCode)
|
|
||||||
{
|
|
||||||
var odesliJson = await odesliResponse.Content.ReadAsStringAsync(cancellationToken);
|
|
||||||
var odesliDoc = JsonDocument.Parse(odesliJson);
|
|
||||||
|
|
||||||
// Extract Spotify track ID from the Spotify URL
|
|
||||||
if (odesliDoc.RootElement.TryGetProperty("linksByPlatform", out var platforms) &&
|
|
||||||
platforms.TryGetProperty("spotify", out var spotifyPlatform) &&
|
|
||||||
spotifyPlatform.TryGetProperty("url", out var spotifyUrlEl))
|
|
||||||
{
|
|
||||||
var spotifyUrl = spotifyUrlEl.GetString();
|
|
||||||
if (!string.IsNullOrEmpty(spotifyUrl))
|
|
||||||
{
|
|
||||||
// Extract ID from URL: https://open.spotify.com/track/{id}
|
|
||||||
var match = System.Text.RegularExpressions.Regex.Match(spotifyUrl, @"spotify\.com/track/([a-zA-Z0-9]+)");
|
|
||||||
if (match.Success)
|
|
||||||
{
|
|
||||||
var spotifyId = match.Groups[1].Value;
|
|
||||||
_logger.LogInformation("✓ Converted Tidal/{TidalId} → Spotify ID {SpotifyId}", tidalTrackId, spotifyId);
|
|
||||||
|
|
||||||
// Cache for 7 days
|
|
||||||
await _cache.SetAsync(cacheKey, spotifyId, TimeSpan.FromDays(7));
|
|
||||||
|
|
||||||
return spotifyId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Failed to convert Tidal track to Spotify ID via Odesli");
|
|
||||||
}
|
|
||||||
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Converts any music URL to a Spotify track ID using Odesli
|
|
||||||
/// Results are cached for 7 days
|
|
||||||
/// </summary>
|
|
||||||
public async Task<string?> ConvertUrlToSpotifyIdAsync(string musicUrl, CancellationToken cancellationToken = default)
|
|
||||||
{
|
|
||||||
// Check cache first
|
|
||||||
var cacheKey = $"odesli:url-to-spotify:{musicUrl}";
|
|
||||||
var cached = await _cache.GetAsync<string>(cacheKey);
|
|
||||||
if (!string.IsNullOrEmpty(cached))
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Using cached Spotify ID for URL {Url}", musicUrl);
|
|
||||||
return cached;
|
|
||||||
}
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var odesliUrl = $"https://api.song.link/v1-alpha.1/links?url={Uri.EscapeDataString(musicUrl)}&userCountry=US";
|
|
||||||
|
|
||||||
_logger.LogDebug("🔗 Converting URL to Spotify ID via Odesli: {Url}", musicUrl);
|
|
||||||
|
|
||||||
var odesliResponse = await _httpClient.GetAsync(odesliUrl, cancellationToken);
|
|
||||||
if (odesliResponse.IsSuccessStatusCode)
|
|
||||||
{
|
|
||||||
var odesliJson = await odesliResponse.Content.ReadAsStringAsync(cancellationToken);
|
|
||||||
var odesliDoc = JsonDocument.Parse(odesliJson);
|
|
||||||
|
|
||||||
// Extract Spotify track ID from the Spotify URL
|
|
||||||
if (odesliDoc.RootElement.TryGetProperty("linksByPlatform", out var platforms) &&
|
|
||||||
platforms.TryGetProperty("spotify", out var spotifyPlatform) &&
|
|
||||||
spotifyPlatform.TryGetProperty("url", out var spotifyUrlEl))
|
|
||||||
{
|
|
||||||
var spotifyUrl = spotifyUrlEl.GetString();
|
|
||||||
if (!string.IsNullOrEmpty(spotifyUrl))
|
|
||||||
{
|
|
||||||
// Extract ID from URL: https://open.spotify.com/track/{id}
|
|
||||||
var match = System.Text.RegularExpressions.Regex.Match(spotifyUrl, @"spotify\.com/track/([a-zA-Z0-9]+)");
|
|
||||||
if (match.Success)
|
|
||||||
{
|
|
||||||
var spotifyId = match.Groups[1].Value;
|
|
||||||
_logger.LogInformation("✓ Converted URL → Spotify ID {SpotifyId}", spotifyId);
|
|
||||||
|
|
||||||
// Cache for 7 days
|
|
||||||
await _cache.SetAsync(cacheKey, spotifyId, TimeSpan.FromDays(7));
|
|
||||||
|
|
||||||
return spotifyId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Failed to convert URL to Spotify ID via Odesli");
|
|
||||||
}
|
|
||||||
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -1,313 +0,0 @@
|
|||||||
namespace allstarr.Services.Common;
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Helper for round-robin load balancing with fallback across multiple API endpoints.
|
|
||||||
/// Distributes load evenly while maintaining reliability through automatic failover.
|
|
||||||
/// </summary>
|
|
||||||
public class RoundRobinFallbackHelper
|
|
||||||
{
|
|
||||||
private readonly List<string> _apiUrls;
|
|
||||||
private int _currentUrlIndex = 0;
|
|
||||||
private readonly object _urlIndexLock = new object();
|
|
||||||
private readonly ILogger _logger;
|
|
||||||
private readonly string _serviceName;
|
|
||||||
private readonly HttpClient _healthCheckClient;
|
|
||||||
|
|
||||||
// Cache health check results for 30 seconds to avoid excessive checks
|
|
||||||
private readonly Dictionary<string, (bool isHealthy, DateTime checkedAt)> _healthCache = new();
|
|
||||||
private readonly object _healthCacheLock = new object();
|
|
||||||
private readonly TimeSpan _healthCacheExpiry = TimeSpan.FromSeconds(30);
|
|
||||||
|
|
||||||
public int EndpointCount => _apiUrls.Count;
|
|
||||||
|
|
||||||
public RoundRobinFallbackHelper(List<string> apiUrls, ILogger logger, string serviceName)
|
|
||||||
{
|
|
||||||
_apiUrls = apiUrls ?? throw new ArgumentNullException(nameof(apiUrls));
|
|
||||||
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
|
|
||||||
_serviceName = serviceName ?? "Service";
|
|
||||||
|
|
||||||
if (_apiUrls.Count == 0)
|
|
||||||
{
|
|
||||||
throw new ArgumentException("API URLs list cannot be empty", nameof(apiUrls));
|
|
||||||
}
|
|
||||||
|
|
||||||
// Create a dedicated HttpClient for health checks with short timeout
|
|
||||||
_healthCheckClient = new HttpClient
|
|
||||||
{
|
|
||||||
Timeout = TimeSpan.FromSeconds(3) // Quick health check timeout
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Quickly checks if an endpoint is healthy (responds within 3 seconds).
|
|
||||||
/// Results are cached for 30 seconds to avoid excessive health checks.
|
|
||||||
/// </summary>
|
|
||||||
private async Task<bool> IsEndpointHealthyAsync(string baseUrl)
|
|
||||||
{
|
|
||||||
// Check cache first
|
|
||||||
lock (_healthCacheLock)
|
|
||||||
{
|
|
||||||
if (_healthCache.TryGetValue(baseUrl, out var cached))
|
|
||||||
{
|
|
||||||
if (DateTime.UtcNow - cached.checkedAt < _healthCacheExpiry)
|
|
||||||
{
|
|
||||||
return cached.isHealthy;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Perform health check
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var response = await _healthCheckClient.GetAsync(baseUrl, HttpCompletionOption.ResponseHeadersRead);
|
|
||||||
var isHealthy = response.IsSuccessStatusCode;
|
|
||||||
|
|
||||||
// Cache result
|
|
||||||
lock (_healthCacheLock)
|
|
||||||
{
|
|
||||||
_healthCache[baseUrl] = (isHealthy, DateTime.UtcNow);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!isHealthy)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("{Service} endpoint {Endpoint} health check failed: {StatusCode}",
|
|
||||||
_serviceName, baseUrl, response.StatusCode);
|
|
||||||
}
|
|
||||||
|
|
||||||
return isHealthy;
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "{Service} endpoint {Endpoint} health check failed", _serviceName, baseUrl);
|
|
||||||
|
|
||||||
// Cache as unhealthy
|
|
||||||
lock (_healthCacheLock)
|
|
||||||
{
|
|
||||||
_healthCache[baseUrl] = (false, DateTime.UtcNow);
|
|
||||||
}
|
|
||||||
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Gets a list of healthy endpoints, checking them in parallel.
|
|
||||||
/// Falls back to all endpoints if none are healthy.
|
|
||||||
/// </summary>
|
|
||||||
private async Task<List<string>> GetHealthyEndpointsAsync()
|
|
||||||
{
|
|
||||||
var healthCheckTasks = _apiUrls.Select(async url => new
|
|
||||||
{
|
|
||||||
Url = url,
|
|
||||||
IsHealthy = await IsEndpointHealthyAsync(url)
|
|
||||||
}).ToList();
|
|
||||||
|
|
||||||
var results = await Task.WhenAll(healthCheckTasks);
|
|
||||||
var healthyEndpoints = results.Where(r => r.IsHealthy).Select(r => r.Url).ToList();
|
|
||||||
|
|
||||||
if (healthyEndpoints.Count == 0)
|
|
||||||
{
|
|
||||||
_logger.LogWarning("{Service} health check: no healthy endpoints found, will try all", _serviceName);
|
|
||||||
return _apiUrls;
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogDebug("{Service} health check: {Healthy}/{Total} endpoints healthy",
|
|
||||||
_serviceName, healthyEndpoints.Count, _apiUrls.Count);
|
|
||||||
|
|
||||||
return healthyEndpoints;
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Updates the endpoint order based on benchmark results (fastest first).
|
|
||||||
/// </summary>
|
|
||||||
public void SetEndpointOrder(List<string> orderedEndpoints)
|
|
||||||
{
|
|
||||||
lock (_urlIndexLock)
|
|
||||||
{
|
|
||||||
// Reorder _apiUrls to match the benchmarked order
|
|
||||||
var reordered = orderedEndpoints.Where(e => _apiUrls.Contains(e)).ToList();
|
|
||||||
|
|
||||||
// Add any endpoints that weren't benchmarked (shouldn't happen, but be safe)
|
|
||||||
foreach (var url in _apiUrls.Where(u => !reordered.Contains(u)))
|
|
||||||
{
|
|
||||||
reordered.Add(url);
|
|
||||||
}
|
|
||||||
|
|
||||||
_apiUrls.Clear();
|
|
||||||
_apiUrls.AddRange(reordered);
|
|
||||||
_currentUrlIndex = 0;
|
|
||||||
|
|
||||||
_logger.LogInformation("📊 {Service} endpoints reordered by benchmark: {Endpoints}",
|
|
||||||
_serviceName, string.Join(", ", _apiUrls.Take(3)));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Tries the request with the next provider in round-robin, then falls back to others on failure.
|
|
||||||
/// This distributes load evenly across all providers while maintaining reliability.
|
|
||||||
/// Performs quick health checks first to avoid wasting time on dead endpoints.
|
|
||||||
/// Throws exception if all endpoints fail.
|
|
||||||
/// </summary>
|
|
||||||
public async Task<T> TryWithFallbackAsync<T>(Func<string, Task<T>> action)
|
|
||||||
{
|
|
||||||
// Get healthy endpoints first (with caching to avoid excessive checks)
|
|
||||||
var healthyEndpoints = await GetHealthyEndpointsAsync();
|
|
||||||
|
|
||||||
// Start with the next URL in round-robin to distribute load
|
|
||||||
var startIndex = 0;
|
|
||||||
lock (_urlIndexLock)
|
|
||||||
{
|
|
||||||
startIndex = _currentUrlIndex;
|
|
||||||
_currentUrlIndex = (_currentUrlIndex + 1) % _apiUrls.Count;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Try healthy endpoints first, then fall back to all if needed
|
|
||||||
var endpointsToTry = healthyEndpoints.Count < _apiUrls.Count
|
|
||||||
? healthyEndpoints.Concat(_apiUrls.Except(healthyEndpoints)).ToList()
|
|
||||||
: healthyEndpoints;
|
|
||||||
|
|
||||||
// Try all URLs starting from the round-robin selected one
|
|
||||||
for (int attempt = 0; attempt < endpointsToTry.Count; attempt++)
|
|
||||||
{
|
|
||||||
var urlIndex = (startIndex + attempt) % endpointsToTry.Count;
|
|
||||||
var baseUrl = endpointsToTry[urlIndex];
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Trying {Service} endpoint {Endpoint} (attempt {Attempt}/{Total})",
|
|
||||||
_serviceName, baseUrl, attempt + 1, endpointsToTry.Count);
|
|
||||||
return await action(baseUrl);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogWarning(ex, "{Service} request failed with endpoint {Endpoint}, trying next...",
|
|
||||||
_serviceName, baseUrl);
|
|
||||||
|
|
||||||
// Mark as unhealthy in cache
|
|
||||||
lock (_healthCacheLock)
|
|
||||||
{
|
|
||||||
_healthCache[baseUrl] = (false, DateTime.UtcNow);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (attempt == endpointsToTry.Count - 1)
|
|
||||||
{
|
|
||||||
_logger.LogError("All {Count} {Service} endpoints failed", endpointsToTry.Count, _serviceName);
|
|
||||||
throw;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
throw new Exception($"All {_serviceName} endpoints failed");
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Races all endpoints in parallel and returns the first successful result.
|
|
||||||
/// Cancels remaining requests once one succeeds. Great for latency-sensitive operations.
|
|
||||||
/// </summary>
|
|
||||||
public async Task<T> RaceAllEndpointsAsync<T>(Func<string, CancellationToken, Task<T>> action, CancellationToken cancellationToken = default)
|
|
||||||
{
|
|
||||||
if (_apiUrls.Count == 1)
|
|
||||||
{
|
|
||||||
// No point racing with one endpoint
|
|
||||||
return await action(_apiUrls[0], cancellationToken);
|
|
||||||
}
|
|
||||||
|
|
||||||
using var raceCts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
|
|
||||||
var tasks = new List<Task<(T result, string endpoint, bool success)>>();
|
|
||||||
|
|
||||||
// Start all requests in parallel
|
|
||||||
foreach (var baseUrl in _apiUrls)
|
|
||||||
{
|
|
||||||
var task = Task.Run(async () =>
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Racing {Service} endpoint {Endpoint}", _serviceName, baseUrl);
|
|
||||||
var result = await action(baseUrl, raceCts.Token);
|
|
||||||
return (result, baseUrl, true);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "{Service} race failed for endpoint {Endpoint}", _serviceName, baseUrl);
|
|
||||||
return (default(T)!, baseUrl, false);
|
|
||||||
}
|
|
||||||
}, raceCts.Token);
|
|
||||||
|
|
||||||
tasks.Add(task);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Wait for first successful completion
|
|
||||||
while (tasks.Count > 0)
|
|
||||||
{
|
|
||||||
var completedTask = await Task.WhenAny(tasks);
|
|
||||||
var (result, endpoint, success) = await completedTask;
|
|
||||||
|
|
||||||
if (success)
|
|
||||||
{
|
|
||||||
_logger.LogInformation("🏁 {Service} race won by {Endpoint}, canceling others", _serviceName, endpoint);
|
|
||||||
raceCts.Cancel(); // Cancel all other requests
|
|
||||||
return result;
|
|
||||||
}
|
|
||||||
|
|
||||||
tasks.Remove(completedTask);
|
|
||||||
}
|
|
||||||
|
|
||||||
throw new Exception($"All {_serviceName} endpoints failed in race");
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Tries the request with the next provider in round-robin, then falls back to others on failure.
|
|
||||||
/// Performs quick health checks first to avoid wasting time on dead endpoints.
|
|
||||||
/// Returns default value if all endpoints fail (does not throw).
|
|
||||||
/// </summary>
|
|
||||||
public async Task<T> TryWithFallbackAsync<T>(Func<string, Task<T>> action, T defaultValue)
|
|
||||||
{
|
|
||||||
// Get healthy endpoints first (with caching to avoid excessive checks)
|
|
||||||
var healthyEndpoints = await GetHealthyEndpointsAsync();
|
|
||||||
|
|
||||||
// Start with the next URL in round-robin to distribute load
|
|
||||||
var startIndex = 0;
|
|
||||||
lock (_urlIndexLock)
|
|
||||||
{
|
|
||||||
startIndex = _currentUrlIndex;
|
|
||||||
_currentUrlIndex = (_currentUrlIndex + 1) % _apiUrls.Count;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Try healthy endpoints first, then fall back to all if needed
|
|
||||||
var endpointsToTry = healthyEndpoints.Count < _apiUrls.Count
|
|
||||||
? healthyEndpoints.Concat(_apiUrls.Except(healthyEndpoints)).ToList()
|
|
||||||
: healthyEndpoints;
|
|
||||||
|
|
||||||
// Try all URLs starting from the round-robin selected one
|
|
||||||
for (int attempt = 0; attempt < endpointsToTry.Count; attempt++)
|
|
||||||
{
|
|
||||||
var urlIndex = (startIndex + attempt) % endpointsToTry.Count;
|
|
||||||
var baseUrl = endpointsToTry[urlIndex];
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Trying {Service} endpoint {Endpoint} (attempt {Attempt}/{Total})",
|
|
||||||
_serviceName, baseUrl, attempt + 1, endpointsToTry.Count);
|
|
||||||
return await action(baseUrl);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogWarning(ex, "{Service} request failed with endpoint {Endpoint}, trying next...",
|
|
||||||
_serviceName, baseUrl);
|
|
||||||
|
|
||||||
// Mark as unhealthy in cache
|
|
||||||
lock (_healthCacheLock)
|
|
||||||
{
|
|
||||||
_healthCache[baseUrl] = (false, DateTime.UtcNow);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (attempt == endpointsToTry.Count - 1)
|
|
||||||
{
|
|
||||||
_logger.LogError("All {Count} {Service} endpoints failed, returning default value",
|
|
||||||
endpointsToTry.Count, _serviceName);
|
|
||||||
return defaultValue;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return defaultValue;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -24,6 +24,7 @@ namespace allstarr.Services.Deezer;
|
|||||||
public class DeezerDownloadService : BaseDownloadService
|
public class DeezerDownloadService : BaseDownloadService
|
||||||
{
|
{
|
||||||
private readonly HttpClient _httpClient;
|
private readonly HttpClient _httpClient;
|
||||||
|
private readonly SemaphoreSlim _requestLock = new(1, 1);
|
||||||
|
|
||||||
private readonly string? _arl;
|
private readonly string? _arl;
|
||||||
private readonly string? _arlFallback;
|
private readonly string? _arlFallback;
|
||||||
@@ -32,6 +33,9 @@ public class DeezerDownloadService : BaseDownloadService
|
|||||||
private string? _apiToken;
|
private string? _apiToken;
|
||||||
private string? _licenseToken;
|
private string? _licenseToken;
|
||||||
|
|
||||||
|
private DateTime _lastRequestTime = DateTime.MinValue;
|
||||||
|
private readonly int _minRequestIntervalMs = 200;
|
||||||
|
|
||||||
private const string DeezerApiBase = "https://api.deezer.com";
|
private const string DeezerApiBase = "https://api.deezer.com";
|
||||||
|
|
||||||
// Deezer's standard Blowfish CBC encryption key for track decryption
|
// Deezer's standard Blowfish CBC encryption key for track decryption
|
||||||
@@ -107,10 +111,7 @@ public class DeezerDownloadService : BaseDownloadService
|
|||||||
|
|
||||||
// Build organized folder structure: Artist/Album/Track using AlbumArtist (fallback to Artist for singles)
|
// Build organized folder structure: Artist/Album/Track using AlbumArtist (fallback to Artist for singles)
|
||||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||||
// Cache mode uses downloads/cache/ folder, Permanent mode uses downloads/permanent/
|
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache ? CachePath : DownloadPath;
|
||||||
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache
|
|
||||||
? Path.Combine("downloads", "cache")
|
|
||||||
: Path.Combine("downloads", "permanent");
|
|
||||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension);
|
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension);
|
||||||
|
|
||||||
// Create directories if they don't exist
|
// Create directories if they don't exist
|
||||||
@@ -493,6 +494,27 @@ public class DeezerDownloadService : BaseDownloadService
|
|||||||
await RetryWithBackoffAsync<bool>(action, maxRetries, initialDelayMs);
|
await RetryWithBackoffAsync<bool>(action, maxRetries, initialDelayMs);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private async Task<T> QueueRequestAsync<T>(Func<Task<T>> action)
|
||||||
|
{
|
||||||
|
await _requestLock.WaitAsync();
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var now = DateTime.UtcNow;
|
||||||
|
var timeSinceLastRequest = (now - _lastRequestTime).TotalMilliseconds;
|
||||||
|
|
||||||
|
if (timeSinceLastRequest < _minRequestIntervalMs)
|
||||||
|
{
|
||||||
|
await Task.Delay((int)(_minRequestIntervalMs - timeSinceLastRequest));
|
||||||
|
}
|
||||||
|
|
||||||
|
_lastRequestTime = DateTime.UtcNow;
|
||||||
|
return await action();
|
||||||
|
}
|
||||||
|
finally
|
||||||
|
{
|
||||||
|
_requestLock.Release();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
|
|
||||||
|
|||||||
@@ -168,11 +168,6 @@ public class JellyfinProxyService
|
|||||||
(h.Value.ToString().Contains("image", StringComparison.OrdinalIgnoreCase) ||
|
(h.Value.ToString().Contains("image", StringComparison.OrdinalIgnoreCase) ||
|
||||||
h.Value.ToString().Contains("document", StringComparison.OrdinalIgnoreCase))) == true);
|
h.Value.ToString().Contains("document", StringComparison.OrdinalIgnoreCase))) == true);
|
||||||
|
|
||||||
// Check if this is a public endpoint that doesn't require authentication
|
|
||||||
bool isPublicEndpoint = url.Contains("/System/Info/Public", StringComparison.OrdinalIgnoreCase) ||
|
|
||||||
url.Contains("/Branding/", StringComparison.OrdinalIgnoreCase) ||
|
|
||||||
url.Contains("/Startup/", StringComparison.OrdinalIgnoreCase);
|
|
||||||
|
|
||||||
// Forward authentication headers from client if provided
|
// Forward authentication headers from client if provided
|
||||||
if (clientHeaders != null && clientHeaders.Count > 0)
|
if (clientHeaders != null && clientHeaders.Count > 0)
|
||||||
{
|
{
|
||||||
@@ -184,27 +179,11 @@ public class JellyfinProxyService
|
|||||||
var headerValue = header.Value.ToString();
|
var headerValue = header.Value.ToString();
|
||||||
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
||||||
authHeaderAdded = true;
|
authHeaderAdded = true;
|
||||||
_logger.LogTrace("Forwarded X-Emby-Authorization header");
|
_logger.LogInformation("✓ Forwarded X-Emby-Authorization: {Value}", headerValue);
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Try X-Emby-Token (simpler format used by some clients)
|
|
||||||
if (!authHeaderAdded)
|
|
||||||
{
|
|
||||||
foreach (var header in clientHeaders)
|
|
||||||
{
|
|
||||||
if (header.Key.Equals("X-Emby-Token", StringComparison.OrdinalIgnoreCase))
|
|
||||||
{
|
|
||||||
var headerValue = header.Value.ToString();
|
|
||||||
request.Headers.TryAddWithoutValidation("X-Emby-Token", headerValue);
|
|
||||||
authHeaderAdded = true;
|
|
||||||
_logger.LogTrace("Forwarded X-Emby-Token header");
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// If no X-Emby-Authorization, check if Authorization header contains MediaBrowser format
|
// If no X-Emby-Authorization, check if Authorization header contains MediaBrowser format
|
||||||
// Some clients send it as "Authorization" instead of "X-Emby-Authorization"
|
// Some clients send it as "Authorization" instead of "X-Emby-Authorization"
|
||||||
if (!authHeaderAdded)
|
if (!authHeaderAdded)
|
||||||
@@ -222,32 +201,37 @@ public class JellyfinProxyService
|
|||||||
// Forward as X-Emby-Authorization (Jellyfin's expected header)
|
// Forward as X-Emby-Authorization (Jellyfin's expected header)
|
||||||
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
||||||
authHeaderAdded = true;
|
authHeaderAdded = true;
|
||||||
_logger.LogTrace("Converted Authorization to X-Emby-Authorization");
|
_logger.LogInformation("✓ Converted Authorization to X-Emby-Authorization: {Value}", headerValue);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
// Standard Bearer token - forward as-is
|
// Standard Bearer token - forward as-is
|
||||||
request.Headers.TryAddWithoutValidation("Authorization", headerValue);
|
request.Headers.TryAddWithoutValidation("Authorization", headerValue);
|
||||||
authHeaderAdded = true;
|
authHeaderAdded = true;
|
||||||
_logger.LogTrace("Forwarded Authorization header");
|
_logger.LogInformation("✓ Forwarded Authorization (Bearer): {Value}", headerValue);
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check for api_key query parameter (some clients use this)
|
// Only log warnings for non-browser static requests
|
||||||
if (!authHeaderAdded && url.Contains("api_key=", StringComparison.OrdinalIgnoreCase))
|
if (!authHeaderAdded && !isBrowserStaticRequest)
|
||||||
{
|
{
|
||||||
authHeaderAdded = true; // It's in the URL, no need to add header
|
_logger.LogWarning("✗ No auth header found. Available headers: {Headers}",
|
||||||
_logger.LogTrace("Using api_key from query string");
|
string.Join(", ", clientHeaders.Select(h => $"{h.Key}={h.Value}")));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
else if (!isBrowserStaticRequest)
|
||||||
|
{
|
||||||
|
_logger.LogWarning("✗ No client headers provided for {Url}", url);
|
||||||
|
}
|
||||||
|
|
||||||
// Only log warnings for non-public, non-browser requests without auth
|
// DO NOT use server API key as fallback - let Jellyfin handle unauthenticated requests
|
||||||
if (!authHeaderAdded && !isBrowserStaticRequest && !isPublicEndpoint)
|
// If client doesn't provide auth, they get what they deserve (401 from Jellyfin)
|
||||||
|
if (!authHeaderAdded && !isBrowserStaticRequest)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("No client auth provided for {Url} - Jellyfin will handle authentication", url);
|
_logger.LogInformation("No client auth provided for {Url} - forwarding without auth", url);
|
||||||
}
|
}
|
||||||
|
|
||||||
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
|
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
|
||||||
@@ -264,28 +248,14 @@ public class JellyfinProxyService
|
|||||||
{
|
{
|
||||||
if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized)
|
if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized)
|
||||||
{
|
{
|
||||||
// 401 means token expired or invalid - client needs to re-authenticate
|
_logger.LogWarning("Jellyfin returned 401 Unauthorized for {Url} - passing through to client", url);
|
||||||
_logger.LogInformation("Jellyfin returned 401 Unauthorized for {Url} - client should re-authenticate", url);
|
|
||||||
}
|
}
|
||||||
else if (!isBrowserStaticRequest && !isPublicEndpoint)
|
else if (!isBrowserStaticRequest) // Don't log 404s for browser static requests
|
||||||
{
|
{
|
||||||
_logger.LogWarning("Jellyfin request failed: {StatusCode} for {Url}", response.StatusCode, url);
|
_logger.LogWarning("Jellyfin request failed: {StatusCode} for {Url}", response.StatusCode, url);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Try to parse error response to pass through to client
|
// Return null body with the actual status code
|
||||||
if (!string.IsNullOrWhiteSpace(content))
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var errorDoc = JsonDocument.Parse(content);
|
|
||||||
return (errorDoc, statusCode);
|
|
||||||
}
|
|
||||||
catch
|
|
||||||
{
|
|
||||||
// Not valid JSON, return null
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return (null, statusCode);
|
return (null, statusCode);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -327,10 +297,8 @@ public class JellyfinProxyService
|
|||||||
request.Content = new StringContent(bodyToSend, System.Text.Encoding.UTF8, "application/json");
|
request.Content = new StringContent(bodyToSend, System.Text.Encoding.UTF8, "application/json");
|
||||||
|
|
||||||
bool authHeaderAdded = false;
|
bool authHeaderAdded = false;
|
||||||
bool isAuthEndpoint = endpoint.Contains("Authenticate", StringComparison.OrdinalIgnoreCase);
|
|
||||||
|
|
||||||
// Forward authentication headers from client (case-insensitive)
|
// Forward authentication headers from client (case-insensitive)
|
||||||
// Try X-Emby-Authorization first
|
|
||||||
foreach (var header in clientHeaders)
|
foreach (var header in clientHeaders)
|
||||||
{
|
{
|
||||||
if (header.Key.Equals("X-Emby-Authorization", StringComparison.OrdinalIgnoreCase))
|
if (header.Key.Equals("X-Emby-Authorization", StringComparison.OrdinalIgnoreCase))
|
||||||
@@ -338,28 +306,11 @@ public class JellyfinProxyService
|
|||||||
var headerValue = header.Value.ToString();
|
var headerValue = header.Value.ToString();
|
||||||
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
||||||
authHeaderAdded = true;
|
authHeaderAdded = true;
|
||||||
_logger.LogTrace("Forwarded X-Emby-Authorization header");
|
_logger.LogDebug("Forwarded X-Emby-Authorization from client");
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Try X-Emby-Token
|
|
||||||
if (!authHeaderAdded)
|
|
||||||
{
|
|
||||||
foreach (var header in clientHeaders)
|
|
||||||
{
|
|
||||||
if (header.Key.Equals("X-Emby-Token", StringComparison.OrdinalIgnoreCase))
|
|
||||||
{
|
|
||||||
var headerValue = header.Value.ToString();
|
|
||||||
request.Headers.TryAddWithoutValidation("X-Emby-Token", headerValue);
|
|
||||||
authHeaderAdded = true;
|
|
||||||
_logger.LogTrace("Forwarded X-Emby-Token header");
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Try Authorization header
|
|
||||||
if (!authHeaderAdded)
|
if (!authHeaderAdded)
|
||||||
{
|
{
|
||||||
foreach (var header in clientHeaders)
|
foreach (var header in clientHeaders)
|
||||||
@@ -374,13 +325,13 @@ public class JellyfinProxyService
|
|||||||
{
|
{
|
||||||
// Forward as X-Emby-Authorization
|
// Forward as X-Emby-Authorization
|
||||||
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
request.Headers.TryAddWithoutValidation("X-Emby-Authorization", headerValue);
|
||||||
_logger.LogTrace("Converted Authorization to X-Emby-Authorization");
|
_logger.LogDebug("Converted Authorization to X-Emby-Authorization");
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
// Standard Bearer token
|
// Standard Bearer token
|
||||||
request.Headers.TryAddWithoutValidation("Authorization", headerValue);
|
request.Headers.TryAddWithoutValidation("Authorization", headerValue);
|
||||||
_logger.LogTrace("Forwarded Authorization header");
|
_logger.LogDebug("Forwarded Authorization header");
|
||||||
}
|
}
|
||||||
authHeaderAdded = true;
|
authHeaderAdded = true;
|
||||||
break;
|
break;
|
||||||
@@ -388,23 +339,30 @@ public class JellyfinProxyService
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// For authentication endpoints, credentials are in the body, not headers
|
// DO NOT use server credentials as fallback
|
||||||
// For other endpoints without auth, let Jellyfin reject the request
|
// Exception: For auth endpoints, client provides their own credentials in the body
|
||||||
if (!authHeaderAdded && !isAuthEndpoint)
|
// For all other endpoints, if client doesn't provide auth, let Jellyfin reject it
|
||||||
|
if (!authHeaderAdded)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("No client auth provided for POST {Url} - Jellyfin will handle authentication", url);
|
_logger.LogInformation("No client auth provided for POST {Url} - forwarding without auth", url);
|
||||||
}
|
}
|
||||||
|
|
||||||
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
|
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
|
||||||
|
|
||||||
// DO NOT log the body for auth endpoints - it contains passwords!
|
// DO NOT log the body for auth endpoints - it contains passwords!
|
||||||
if (isAuthEndpoint)
|
if (endpoint.Contains("Authenticate", StringComparison.OrdinalIgnoreCase))
|
||||||
{
|
{
|
||||||
_logger.LogDebug("POST to Jellyfin: {Url} (auth request - body not logged)", url);
|
_logger.LogDebug("POST to Jellyfin: {Url} (auth request - body not logged)", url);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
_logger.LogTrace("POST to Jellyfin: {Url}, body length: {Length} bytes", url, bodyToSend.Length);
|
_logger.LogInformation("POST to Jellyfin: {Url}, body length: {Length} bytes", url, bodyToSend.Length);
|
||||||
|
|
||||||
|
// Log body content for playback endpoints to debug
|
||||||
|
if (endpoint.Contains("Playing", StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
_logger.LogInformation("Sending body to Jellyfin: {Body}", bodyToSend);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
var response = await _httpClient.SendAsync(request);
|
var response = await _httpClient.SendAsync(request);
|
||||||
@@ -414,39 +372,15 @@ public class JellyfinProxyService
|
|||||||
if (!response.IsSuccessStatusCode)
|
if (!response.IsSuccessStatusCode)
|
||||||
{
|
{
|
||||||
var errorContent = await response.Content.ReadAsStringAsync();
|
var errorContent = await response.Content.ReadAsStringAsync();
|
||||||
|
_logger.LogWarning("❌ SESSION: Jellyfin POST request failed: {StatusCode} for {Url}. Response: {Response}",
|
||||||
// 401 is expected when tokens expire - don't spam logs
|
response.StatusCode, url, errorContent);
|
||||||
if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized)
|
|
||||||
{
|
|
||||||
_logger.LogInformation("Jellyfin POST returned 401 for {Url} - client should re-authenticate", url);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
_logger.LogWarning("Jellyfin POST request failed: {StatusCode} for {Url}. Response: {Response}",
|
|
||||||
response.StatusCode, url, errorContent.Length > 200 ? errorContent[..200] + "..." : errorContent);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Try to parse error response as JSON to pass through to client
|
|
||||||
if (!string.IsNullOrWhiteSpace(errorContent))
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var errorDoc = JsonDocument.Parse(errorContent);
|
|
||||||
return (errorDoc, statusCode);
|
|
||||||
}
|
|
||||||
catch
|
|
||||||
{
|
|
||||||
// Not valid JSON, return null
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return (null, statusCode);
|
return (null, statusCode);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Log successful session-related responses
|
// Log successful session-related responses
|
||||||
if (endpoint.Contains("Sessions", StringComparison.OrdinalIgnoreCase))
|
if (endpoint.Contains("Sessions", StringComparison.OrdinalIgnoreCase))
|
||||||
{
|
{
|
||||||
_logger.LogTrace("Jellyfin responded {StatusCode} for {Endpoint}", statusCode, endpoint);
|
_logger.LogWarning("✓ SESSION: Jellyfin responded {StatusCode} for {Endpoint}", statusCode, endpoint);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Handle 204 No Content responses (e.g., /sessions/playing, /sessions/playing/progress)
|
// Handle 204 No Content responses (e.g., /sessions/playing, /sessions/playing/progress)
|
||||||
@@ -463,6 +397,13 @@ public class JellyfinProxyService
|
|||||||
return (null, statusCode);
|
return (null, statusCode);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Log response content for session endpoints
|
||||||
|
if (endpoint.Contains("Sessions", StringComparison.OrdinalIgnoreCase) && !string.IsNullOrWhiteSpace(responseContent))
|
||||||
|
{
|
||||||
|
var preview = responseContent.Length > 200 ? responseContent[..200] + "..." : responseContent;
|
||||||
|
_logger.LogWarning("📥 SESSION: Jellyfin response body: {Body}", preview);
|
||||||
|
}
|
||||||
|
|
||||||
return (JsonDocument.Parse(responseContent), statusCode);
|
return (JsonDocument.Parse(responseContent), statusCode);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -38,13 +38,12 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Ensures a session exists for the given device. Creates one if needed.
|
/// Ensures a session exists for the given device. Creates one if needed.
|
||||||
/// Returns false if token is expired (401), indicating client needs to re-authenticate.
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public async Task<bool> EnsureSessionAsync(string deviceId, string client, string device, string version, IHeaderDictionary headers)
|
public async Task<bool> EnsureSessionAsync(string deviceId, string client, string device, string version, IHeaderDictionary headers)
|
||||||
{
|
{
|
||||||
if (string.IsNullOrEmpty(deviceId))
|
if (string.IsNullOrEmpty(deviceId))
|
||||||
{
|
{
|
||||||
_logger.LogWarning("Cannot create session - no device ID");
|
_logger.LogWarning("⚠️ SESSION: Cannot create session - no device ID");
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -52,37 +51,25 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
if (_sessions.TryGetValue(deviceId, out var existingSession))
|
if (_sessions.TryGetValue(deviceId, out var existingSession))
|
||||||
{
|
{
|
||||||
existingSession.LastActivity = DateTime.UtcNow;
|
existingSession.LastActivity = DateTime.UtcNow;
|
||||||
_logger.LogTrace("Session already exists for device {DeviceId}", deviceId);
|
_logger.LogDebug("✓ SESSION: Session already exists for device {DeviceId}", deviceId);
|
||||||
|
|
||||||
// Refresh capabilities to keep session alive
|
// Refresh capabilities to keep session alive
|
||||||
// If this returns false (401), the token expired and client needs to re-auth
|
await PostCapabilitiesAsync(headers);
|
||||||
var success = await PostCapabilitiesAsync(headers);
|
|
||||||
if (!success)
|
|
||||||
{
|
|
||||||
// Token expired - remove the stale session
|
|
||||||
_logger.LogInformation("Token expired for device {DeviceId} - removing session", deviceId);
|
|
||||||
await RemoveSessionAsync(deviceId);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogDebug("Creating new session for device: {DeviceId} ({Client} on {Device})", deviceId, client, device);
|
_logger.LogInformation("🔧 SESSION: Creating new session for device: {DeviceId} ({Client} on {Device})", deviceId, client, device);
|
||||||
|
|
||||||
|
// Log the headers we received for debugging
|
||||||
|
_logger.LogDebug("🔍 SESSION: Headers received for session creation: {Headers}",
|
||||||
|
string.Join(", ", headers.Select(h => $"{h.Key}={h.Value.ToString().Substring(0, Math.Min(30, h.Value.ToString().Length))}...")));
|
||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
// Post session capabilities to Jellyfin - this creates the session
|
// Post session capabilities to Jellyfin - this creates the session
|
||||||
var success = await PostCapabilitiesAsync(headers);
|
await PostCapabilitiesAsync(headers);
|
||||||
|
|
||||||
if (!success)
|
_logger.LogInformation("✓ SESSION: Session created for {DeviceId}", deviceId);
|
||||||
{
|
|
||||||
// Token expired or invalid - client needs to re-authenticate
|
|
||||||
_logger.LogInformation("Failed to create session for {DeviceId} - token may be expired", deviceId);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogDebug("Session created for {DeviceId}", deviceId);
|
|
||||||
|
|
||||||
// Track this session
|
// Track this session
|
||||||
_sessions[deviceId] = new SessionInfo
|
_sessions[deviceId] = new SessionInfo
|
||||||
@@ -102,16 +89,15 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogError(ex, "Error creating session for {DeviceId}", deviceId);
|
_logger.LogError(ex, "❌ SESSION: Error creating session for {DeviceId}", deviceId);
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Posts session capabilities to Jellyfin.
|
/// Posts session capabilities to Jellyfin.
|
||||||
/// Returns true if successful, false if token expired (401).
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
private async Task<bool> PostCapabilitiesAsync(IHeaderDictionary headers)
|
private async Task PostCapabilitiesAsync(IHeaderDictionary headers)
|
||||||
{
|
{
|
||||||
var capabilities = new
|
var capabilities = new
|
||||||
{
|
{
|
||||||
@@ -132,19 +118,12 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
|
|
||||||
if (statusCode == 204 || statusCode == 200)
|
if (statusCode == 204 || statusCode == 200)
|
||||||
{
|
{
|
||||||
_logger.LogTrace("Posted capabilities successfully ({StatusCode})", statusCode);
|
_logger.LogDebug("✓ SESSION: Posted capabilities successfully ({StatusCode})", statusCode);
|
||||||
return true;
|
|
||||||
}
|
|
||||||
else if (statusCode == 401)
|
|
||||||
{
|
|
||||||
// Token expired - this is expected, client needs to re-authenticate
|
|
||||||
_logger.LogDebug("Capabilities returned 401 (token expired) - client should re-authenticate");
|
|
||||||
return false;
|
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
_logger.LogDebug("Capabilities post returned {StatusCode}", statusCode);
|
// 401 is common when cached headers have expired - not a critical error
|
||||||
return false;
|
_logger.LogDebug("SESSION: Capabilities post returned {StatusCode} (may be expected if token expired)", statusCode);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -199,7 +178,7 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
if (_sessions.TryGetValue(deviceId, out var currentSession) &&
|
if (_sessions.TryGetValue(deviceId, out var currentSession) &&
|
||||||
currentSession.LastActivity <= markedTime)
|
currentSession.LastActivity <= markedTime)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("🧹 SESSION: Auto-removing inactive session {DeviceId} after playback stop", deviceId);
|
_logger.LogInformation("🧹 SESSION: Auto-removing inactive session {DeviceId} after playback stop", deviceId);
|
||||||
await RemoveSessionAsync(deviceId);
|
await RemoveSessionAsync(deviceId);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
@@ -244,7 +223,7 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
{
|
{
|
||||||
if (_sessions.TryRemove(deviceId, out var session))
|
if (_sessions.TryRemove(deviceId, out var session))
|
||||||
{
|
{
|
||||||
_logger.LogDebug("🗑️ SESSION: Removing session for device {DeviceId}", deviceId);
|
_logger.LogInformation("🗑️ SESSION: Removing session for device {DeviceId}", deviceId);
|
||||||
|
|
||||||
// Close WebSocket if it exists
|
// Close WebSocket if it exists
|
||||||
if (session.WebSocket != null && session.WebSocket.State == WebSocketState.Open)
|
if (session.WebSocket != null && session.WebSocket.State == WebSocketState.Open)
|
||||||
@@ -256,7 +235,7 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogDebug(ex, "WEBSOCKET: Error closing WebSocket for {DeviceId}", deviceId);
|
_logger.LogWarning(ex, "⚠️ WEBSOCKET: Error closing WebSocket for {DeviceId}", deviceId);
|
||||||
}
|
}
|
||||||
finally
|
finally
|
||||||
{
|
{
|
||||||
@@ -276,7 +255,7 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
};
|
};
|
||||||
var stopJson = JsonSerializer.Serialize(stopPayload);
|
var stopJson = JsonSerializer.Serialize(stopPayload);
|
||||||
await _proxyService.PostJsonAsync("Sessions/Playing/Stopped", stopJson, session.Headers);
|
await _proxyService.PostJsonAsync("Sessions/Playing/Stopped", stopJson, session.Headers);
|
||||||
_logger.LogDebug("🛑 SESSION: Reported playback stopped for {DeviceId} (ItemId: {ItemId}, Position: {Position})",
|
_logger.LogInformation("🛑 SESSION: Reported playback stopped for {DeviceId} (ItemId: {ItemId}, Position: {Position})",
|
||||||
deviceId, session.LastPlayingItemId, session.LastPlayingPositionTicks);
|
deviceId, session.LastPlayingItemId, session.LastPlayingPositionTicks);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -319,23 +298,20 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
webSocket = new ClientWebSocket();
|
webSocket = new ClientWebSocket();
|
||||||
session.WebSocket = webSocket;
|
session.WebSocket = webSocket;
|
||||||
|
|
||||||
// Use stored session headers instead of parameter (parameter might be disposed)
|
|
||||||
var sessionHeaders = session.Headers;
|
|
||||||
|
|
||||||
// Log available headers for debugging
|
// Log available headers for debugging
|
||||||
_logger.LogDebug("🔍 WEBSOCKET: Available headers for {DeviceId}: {Headers}",
|
_logger.LogDebug("🔍 WEBSOCKET: Available headers for {DeviceId}: {Headers}",
|
||||||
deviceId, string.Join(", ", sessionHeaders.Keys));
|
deviceId, string.Join(", ", headers.Keys));
|
||||||
|
|
||||||
// Forward authentication headers from the CLIENT - this is critical for session to appear under the right user
|
// Forward authentication headers from the CLIENT - this is critical for session to appear under the right user
|
||||||
bool authFound = false;
|
bool authFound = false;
|
||||||
if (sessionHeaders.TryGetValue("X-Emby-Authorization", out var embyAuth))
|
if (headers.TryGetValue("X-Emby-Authorization", out var embyAuth))
|
||||||
{
|
{
|
||||||
webSocket.Options.SetRequestHeader("X-Emby-Authorization", embyAuth.ToString());
|
webSocket.Options.SetRequestHeader("X-Emby-Authorization", embyAuth.ToString());
|
||||||
_logger.LogDebug("🔑 WEBSOCKET: Using X-Emby-Authorization for {DeviceId}: {Auth}",
|
_logger.LogDebug("🔑 WEBSOCKET: Using X-Emby-Authorization for {DeviceId}: {Auth}",
|
||||||
deviceId, embyAuth.ToString().Length > 50 ? embyAuth.ToString()[..50] + "..." : embyAuth.ToString());
|
deviceId, embyAuth.ToString().Length > 50 ? embyAuth.ToString()[..50] + "..." : embyAuth.ToString());
|
||||||
authFound = true;
|
authFound = true;
|
||||||
}
|
}
|
||||||
else if (sessionHeaders.TryGetValue("Authorization", out var auth))
|
else if (headers.TryGetValue("Authorization", out var auth))
|
||||||
{
|
{
|
||||||
var authValue = auth.ToString();
|
var authValue = auth.ToString();
|
||||||
if (authValue.Contains("MediaBrowser", StringComparison.OrdinalIgnoreCase))
|
if (authValue.Contains("MediaBrowser", StringComparison.OrdinalIgnoreCase))
|
||||||
@@ -360,11 +336,11 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
if (!string.IsNullOrEmpty(_settings.ApiKey))
|
if (!string.IsNullOrEmpty(_settings.ApiKey))
|
||||||
{
|
{
|
||||||
jellyfinWsUrl += $"?api_key={_settings.ApiKey}";
|
jellyfinWsUrl += $"?api_key={_settings.ApiKey}";
|
||||||
_logger.LogDebug("WEBSOCKET: No client auth found in headers, falling back to server API key for {DeviceId}", deviceId);
|
_logger.LogWarning("⚠️ WEBSOCKET: No client auth found in headers, falling back to server API key for {DeviceId}", deviceId);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
_logger.LogWarning("❌ WEBSOCKET: No authentication available for {DeviceId} - WebSocket will fail", deviceId);
|
_logger.LogWarning("❌ WEBSOCKET: No authentication available for {DeviceId}!", deviceId);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -375,7 +351,7 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
|
|
||||||
// Connect to Jellyfin
|
// Connect to Jellyfin
|
||||||
await webSocket.ConnectAsync(new Uri(jellyfinWsUrl), CancellationToken.None);
|
await webSocket.ConnectAsync(new Uri(jellyfinWsUrl), CancellationToken.None);
|
||||||
_logger.LogDebug("✓ WEBSOCKET: Connected to Jellyfin for device {DeviceId}", deviceId);
|
_logger.LogInformation("✓ WEBSOCKET: Connected to Jellyfin for device {DeviceId}", deviceId);
|
||||||
|
|
||||||
// CRITICAL: Send ForceKeepAlive message to initialize session in Jellyfin
|
// CRITICAL: Send ForceKeepAlive message to initialize session in Jellyfin
|
||||||
// This tells Jellyfin to create/show the session in the dashboard
|
// This tells Jellyfin to create/show the session in the dashboard
|
||||||
@@ -431,8 +407,8 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
// Log other message types at trace level
|
// Log other message types at info level
|
||||||
_logger.LogTrace("📥 WEBSOCKET: {DeviceId}: {Message}",
|
_logger.LogInformation("📥 WEBSOCKET: {DeviceId}: {Message}",
|
||||||
deviceId, message.Length > 100 ? message[..100] + "..." : message);
|
deviceId, message.Length > 100 ? message[..100] + "..." : message);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -454,7 +430,7 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
}
|
}
|
||||||
catch (WebSocketException wsEx)
|
catch (WebSocketException wsEx)
|
||||||
{
|
{
|
||||||
_logger.LogDebug(wsEx, "WEBSOCKET: Connection closed for device {DeviceId}", deviceId);
|
_logger.LogWarning(wsEx, "⚠️ WEBSOCKET: WebSocket error for device {DeviceId}", deviceId);
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -490,7 +466,6 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
/// <summary>
|
/// <summary>
|
||||||
/// Periodically pings Jellyfin to keep sessions alive.
|
/// Periodically pings Jellyfin to keep sessions alive.
|
||||||
/// Note: This is a backup mechanism. The WebSocket connection is the primary keep-alive.
|
/// Note: This is a backup mechanism. The WebSocket connection is the primary keep-alive.
|
||||||
/// Removes sessions with expired tokens (401 responses).
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
private async void KeepSessionsAlive(object? state)
|
private async void KeepSessionsAlive(object? state)
|
||||||
{
|
{
|
||||||
@@ -502,43 +477,29 @@ public class JellyfinSessionManager : IDisposable
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogTrace("Keeping {Count} sessions alive", activeSessions.Count);
|
_logger.LogDebug("💓 SESSION: Keeping {Count} sessions alive", activeSessions.Count);
|
||||||
|
|
||||||
var expiredSessions = new List<string>();
|
|
||||||
|
|
||||||
foreach (var session in activeSessions)
|
foreach (var session in activeSessions)
|
||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
// Post capabilities again to keep session alive
|
// Post capabilities again to keep session alive
|
||||||
// If this returns false (401), the token has expired
|
// Note: This may fail with 401 if the client's token has expired
|
||||||
var success = await PostCapabilitiesAsync(session.Headers);
|
// That's okay - the WebSocket connection keeps the session alive anyway
|
||||||
|
await PostCapabilitiesAsync(session.Headers);
|
||||||
if (!success)
|
|
||||||
{
|
|
||||||
_logger.LogInformation("Token expired for device {DeviceId} during keep-alive - marking for removal", session.DeviceId);
|
|
||||||
expiredSessions.Add(session.DeviceId);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogDebug(ex, "Error keeping session alive for {DeviceId}", session.DeviceId);
|
_logger.LogDebug(ex, "SESSION: Error keeping session alive for {DeviceId} (WebSocket still active)", session.DeviceId);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Remove sessions with expired tokens
|
|
||||||
foreach (var deviceId in expiredSessions)
|
|
||||||
{
|
|
||||||
_logger.LogInformation("Removing session with expired token: {DeviceId}", deviceId);
|
|
||||||
await RemoveSessionAsync(deviceId);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Clean up stale sessions after 3 minutes of inactivity
|
// Clean up stale sessions after 3 minutes of inactivity
|
||||||
// This balances cleaning up finished sessions with allowing brief pauses/network issues
|
// This balances cleaning up finished sessions with allowing brief pauses/network issues
|
||||||
var staleSessions = _sessions.Where(kvp => now - kvp.Value.LastActivity > TimeSpan.FromMinutes(3)).ToList();
|
var staleSessions = _sessions.Where(kvp => now - kvp.Value.LastActivity > TimeSpan.FromMinutes(3)).ToList();
|
||||||
foreach (var stale in staleSessions)
|
foreach (var stale in staleSessions)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("Removing stale session for {DeviceId} (inactive for {Minutes:F1} minutes)",
|
_logger.LogInformation("🧹 SESSION: Removing stale session for {DeviceId} (inactive for {Minutes:F1} minutes)",
|
||||||
stale.Key, (now - stale.Value.LastActivity).TotalMinutes);
|
stale.Key, (now - stale.Value.LastActivity).TotalMinutes);
|
||||||
await RemoveSessionAsync(stale.Key);
|
await RemoveSessionAsync(stale.Key);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -30,14 +30,6 @@ public class LrclibService
|
|||||||
|
|
||||||
public async Task<LyricsInfo?> GetLyricsAsync(string trackName, string[] artistNames, string albumName, int durationSeconds)
|
public async Task<LyricsInfo?> GetLyricsAsync(string trackName, string[] artistNames, string albumName, int durationSeconds)
|
||||||
{
|
{
|
||||||
// Validate input parameters
|
|
||||||
if (string.IsNullOrWhiteSpace(trackName) || artistNames == null || artistNames.Length == 0)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Invalid parameters for lyrics search: trackName={TrackName}, artistCount={ArtistCount}",
|
|
||||||
trackName, artistNames?.Length ?? 0);
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
var artistName = string.Join(", ", artistNames);
|
var artistName = string.Join(", ", artistNames);
|
||||||
var cacheKey = $"lyrics:{artistName}:{trackName}:{albumName}:{durationSeconds}";
|
var cacheKey = $"lyrics:{artistName}:{trackName}:{albumName}:{durationSeconds}";
|
||||||
|
|
||||||
@@ -120,7 +112,7 @@ public class LrclibService
|
|||||||
var artistCountBonus = resultArtistCount == expectedArtistCount ? 50.0 : 0.0;
|
var artistCountBonus = resultArtistCount == expectedArtistCount ? 50.0 : 0.0;
|
||||||
|
|
||||||
// Duration match (within 5 seconds is good)
|
// Duration match (within 5 seconds is good)
|
||||||
var durationDiff = result.Duration.HasValue ? Math.Abs(result.Duration.Value - durationSeconds) : 999;
|
var durationDiff = Math.Abs(result.Duration - durationSeconds);
|
||||||
var durationScore = durationDiff <= 5 ? 100.0 : Math.Max(0, 100 - (durationDiff * 2));
|
var durationScore = durationDiff <= 5 ? 100.0 : Math.Max(0, 100 - (durationDiff * 2));
|
||||||
|
|
||||||
// Bonus for having synced lyrics (prefer synced over plain)
|
// Bonus for having synced lyrics (prefer synced over plain)
|
||||||
@@ -151,7 +143,7 @@ public class LrclibService
|
|||||||
TrackName = bestMatch.TrackName ?? trackName,
|
TrackName = bestMatch.TrackName ?? trackName,
|
||||||
ArtistName = bestMatch.ArtistName ?? artistName,
|
ArtistName = bestMatch.ArtistName ?? artistName,
|
||||||
AlbumName = bestMatch.AlbumName ?? albumName,
|
AlbumName = bestMatch.AlbumName ?? albumName,
|
||||||
Duration = bestMatch.Duration.HasValue ? (int)Math.Round(bestMatch.Duration.Value) : durationSeconds,
|
Duration = (int)Math.Round(bestMatch.Duration),
|
||||||
Instrumental = bestMatch.Instrumental,
|
Instrumental = bestMatch.Instrumental,
|
||||||
PlainLyrics = bestMatch.PlainLyrics,
|
PlainLyrics = bestMatch.PlainLyrics,
|
||||||
SyncedLyrics = bestMatch.SyncedLyrics
|
SyncedLyrics = bestMatch.SyncedLyrics
|
||||||
@@ -200,7 +192,7 @@ public class LrclibService
|
|||||||
TrackName = lyrics.TrackName ?? trackName,
|
TrackName = lyrics.TrackName ?? trackName,
|
||||||
ArtistName = lyrics.ArtistName ?? artistName,
|
ArtistName = lyrics.ArtistName ?? artistName,
|
||||||
AlbumName = lyrics.AlbumName ?? albumName,
|
AlbumName = lyrics.AlbumName ?? albumName,
|
||||||
Duration = lyrics.Duration.HasValue ? (int)Math.Round(lyrics.Duration.Value) : durationSeconds,
|
Duration = (int)Math.Round(lyrics.Duration),
|
||||||
Instrumental = lyrics.Instrumental,
|
Instrumental = lyrics.Instrumental,
|
||||||
PlainLyrics = lyrics.PlainLyrics,
|
PlainLyrics = lyrics.PlainLyrics,
|
||||||
SyncedLyrics = lyrics.SyncedLyrics
|
SyncedLyrics = lyrics.SyncedLyrics
|
||||||
@@ -342,7 +334,7 @@ public class LrclibService
|
|||||||
TrackName = lyrics.TrackName ?? trackName,
|
TrackName = lyrics.TrackName ?? trackName,
|
||||||
ArtistName = lyrics.ArtistName ?? artistName,
|
ArtistName = lyrics.ArtistName ?? artistName,
|
||||||
AlbumName = lyrics.AlbumName ?? albumName,
|
AlbumName = lyrics.AlbumName ?? albumName,
|
||||||
Duration = lyrics.Duration.HasValue ? (int)Math.Round(lyrics.Duration.Value) : durationSeconds,
|
Duration = (int)Math.Round(lyrics.Duration),
|
||||||
Instrumental = lyrics.Instrumental,
|
Instrumental = lyrics.Instrumental,
|
||||||
PlainLyrics = lyrics.PlainLyrics,
|
PlainLyrics = lyrics.PlainLyrics,
|
||||||
SyncedLyrics = lyrics.SyncedLyrics
|
SyncedLyrics = lyrics.SyncedLyrics
|
||||||
@@ -398,7 +390,7 @@ public class LrclibService
|
|||||||
TrackName = lyrics.TrackName ?? string.Empty,
|
TrackName = lyrics.TrackName ?? string.Empty,
|
||||||
ArtistName = lyrics.ArtistName ?? string.Empty,
|
ArtistName = lyrics.ArtistName ?? string.Empty,
|
||||||
AlbumName = lyrics.AlbumName ?? string.Empty,
|
AlbumName = lyrics.AlbumName ?? string.Empty,
|
||||||
Duration = lyrics.Duration.HasValue ? (int)Math.Round(lyrics.Duration.Value) : 0,
|
Duration = (int)Math.Round(lyrics.Duration),
|
||||||
Instrumental = lyrics.Instrumental,
|
Instrumental = lyrics.Instrumental,
|
||||||
PlainLyrics = lyrics.PlainLyrics,
|
PlainLyrics = lyrics.PlainLyrics,
|
||||||
SyncedLyrics = lyrics.SyncedLyrics
|
SyncedLyrics = lyrics.SyncedLyrics
|
||||||
@@ -427,7 +419,7 @@ public class LrclibService
|
|||||||
public string? TrackName { get; set; }
|
public string? TrackName { get; set; }
|
||||||
public string? ArtistName { get; set; }
|
public string? ArtistName { get; set; }
|
||||||
public string? AlbumName { get; set; }
|
public string? AlbumName { get; set; }
|
||||||
public double? Duration { get; set; }
|
public double Duration { get; set; }
|
||||||
public bool Instrumental { get; set; }
|
public bool Instrumental { get; set; }
|
||||||
public string? PlainLyrics { get; set; }
|
public string? PlainLyrics { get; set; }
|
||||||
public string? SyncedLyrics { get; set; }
|
public string? SyncedLyrics { get; set; }
|
||||||
|
|||||||
@@ -124,42 +124,6 @@ public class LyricsPrefetchService : BackgroundService
|
|||||||
return (0, 0, 0);
|
return (0, 0, 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Get the pre-built playlist items cache which includes Jellyfin item IDs for local tracks
|
|
||||||
var playlistItemsKey = $"spotify:playlist:items:{playlistName}";
|
|
||||||
var playlistItems = await _cache.GetAsync<List<Dictionary<string, object?>>>(playlistItemsKey);
|
|
||||||
|
|
||||||
// Build a map of Spotify ID -> Jellyfin Item ID for quick lookup
|
|
||||||
var spotifyToJellyfinId = new Dictionary<string, string>();
|
|
||||||
if (playlistItems != null)
|
|
||||||
{
|
|
||||||
foreach (var item in playlistItems)
|
|
||||||
{
|
|
||||||
// Check if this is a local Jellyfin track (has Id field, no ProviderIds for external)
|
|
||||||
if (item.TryGetValue("Id", out var idObj) && idObj != null)
|
|
||||||
{
|
|
||||||
var jellyfinId = idObj.ToString();
|
|
||||||
|
|
||||||
// Try to get Spotify provider ID
|
|
||||||
if (item.TryGetValue("ProviderIds", out var providerIdsObj) && providerIdsObj != null)
|
|
||||||
{
|
|
||||||
var providerIdsJson = JsonSerializer.Serialize(providerIdsObj);
|
|
||||||
using var doc = JsonDocument.Parse(providerIdsJson);
|
|
||||||
if (doc.RootElement.TryGetProperty("Spotify", out var spotifyIdEl))
|
|
||||||
{
|
|
||||||
var spotifyId = spotifyIdEl.GetString();
|
|
||||||
if (!string.IsNullOrEmpty(spotifyId) && !string.IsNullOrEmpty(jellyfinId))
|
|
||||||
{
|
|
||||||
spotifyToJellyfinId[spotifyId] = jellyfinId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
_logger.LogDebug("Found {Count} local Jellyfin tracks with Spotify IDs in playlist {Playlist}",
|
|
||||||
spotifyToJellyfinId.Count, playlistName);
|
|
||||||
}
|
|
||||||
|
|
||||||
var fetched = 0;
|
var fetched = 0;
|
||||||
var cached = 0;
|
var cached = 0;
|
||||||
var missing = 0;
|
var missing = 0;
|
||||||
@@ -171,9 +135,7 @@ public class LyricsPrefetchService : BackgroundService
|
|||||||
try
|
try
|
||||||
{
|
{
|
||||||
// Check if lyrics are already cached
|
// Check if lyrics are already cached
|
||||||
// Use same cache key format as LrclibService: join all artists with ", "
|
var cacheKey = $"lyrics:{track.PrimaryArtist}:{track.Title}:{track.Album}:{track.DurationMs / 1000}";
|
||||||
var artistName = string.Join(", ", track.Artists);
|
|
||||||
var cacheKey = $"lyrics:{artistName}:{track.Title}:{track.Album}:{track.DurationMs / 1000}";
|
|
||||||
var existingLyrics = await _cache.GetStringAsync(cacheKey);
|
var existingLyrics = await _cache.GetStringAsync(cacheKey);
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(existingLyrics))
|
if (!string.IsNullOrEmpty(existingLyrics))
|
||||||
@@ -183,40 +145,25 @@ public class LyricsPrefetchService : BackgroundService
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Priority 1: Check if this track has local Jellyfin lyrics (embedded in file)
|
// Check if this track has local Jellyfin lyrics (embedded in file)
|
||||||
// Use the Jellyfin item ID from the playlist cache if available
|
var hasLocalLyrics = await CheckForLocalJellyfinLyricsAsync(track.SpotifyId);
|
||||||
if (spotifyToJellyfinId.TryGetValue(track.SpotifyId, out var jellyfinItemId))
|
|
||||||
{
|
|
||||||
var hasLocalLyrics = await CheckForLocalJellyfinLyricsByIdAsync(jellyfinItemId, track.PrimaryArtist, track.Title);
|
|
||||||
if (hasLocalLyrics)
|
if (hasLocalLyrics)
|
||||||
{
|
{
|
||||||
cached++;
|
cached++;
|
||||||
_logger.LogInformation("✓ Local Jellyfin lyrics found for {Artist} - {Track}, skipping external fetch",
|
_logger.LogInformation("✓ Local Jellyfin lyrics found for {Artist} - {Track}, skipping LRCLib fetch",
|
||||||
track.PrimaryArtist, track.Title);
|
track.PrimaryArtist, track.Title);
|
||||||
|
|
||||||
// Remove any previously cached LRCLib lyrics for this track
|
// Remove any previously cached LRCLib lyrics for this track
|
||||||
var artistNameForRemoval = string.Join(", ", track.Artists);
|
await RemoveCachedLyricsAsync(track.PrimaryArtist, track.Title, track.Album, track.DurationMs / 1000);
|
||||||
await RemoveCachedLyricsAsync(artistNameForRemoval, track.Title, track.Album, track.DurationMs / 1000);
|
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
// Priority 2: Try Spotify lyrics if we have a Spotify ID
|
// Fetch lyrics from LRCLib
|
||||||
LyricsInfo? lyrics = null;
|
var lyrics = await _lrclibService.GetLyricsAsync(
|
||||||
if (!string.IsNullOrEmpty(track.SpotifyId))
|
|
||||||
{
|
|
||||||
lyrics = await TryGetSpotifyLyricsAsync(track.SpotifyId, track.Title, track.PrimaryArtist);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Priority 3: Fall back to LRCLib if no Spotify lyrics
|
|
||||||
if (lyrics == null)
|
|
||||||
{
|
|
||||||
lyrics = await _lrclibService.GetLyricsAsync(
|
|
||||||
track.Title,
|
track.Title,
|
||||||
track.Artists.ToArray(),
|
track.Artists.ToArray(),
|
||||||
track.Album,
|
track.Album,
|
||||||
track.DurationMs / 1000);
|
track.DurationMs / 1000);
|
||||||
}
|
|
||||||
|
|
||||||
if (lyrics != null)
|
if (lyrics != null)
|
||||||
{
|
{
|
||||||
@@ -225,8 +172,7 @@ public class LyricsPrefetchService : BackgroundService
|
|||||||
track.PrimaryArtist, track.Title, !string.IsNullOrEmpty(lyrics.SyncedLyrics));
|
track.PrimaryArtist, track.Title, !string.IsNullOrEmpty(lyrics.SyncedLyrics));
|
||||||
|
|
||||||
// Save to file cache
|
// Save to file cache
|
||||||
var artistNameForSave = string.Join(", ", track.Artists);
|
await SaveLyricsToFileAsync(track.PrimaryArtist, track.Title, track.Album, track.DurationMs / 1000, lyrics);
|
||||||
await SaveLyricsToFileAsync(artistNameForSave, track.Title, track.Album, track.DurationMs / 1000, lyrics);
|
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -355,84 +301,11 @@ public class LyricsPrefetchService : BackgroundService
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Tries to get lyrics from Spotify using the track's Spotify ID.
|
|
||||||
/// Returns null if Spotify API is not enabled or lyrics not found.
|
|
||||||
/// </summary>
|
|
||||||
private async Task<LyricsInfo?> TryGetSpotifyLyricsAsync(string spotifyTrackId, string trackTitle, string artistName)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
using var scope = _serviceProvider.CreateScope();
|
|
||||||
var spotifyLyricsService = scope.ServiceProvider.GetService<SpotifyLyricsService>();
|
|
||||||
|
|
||||||
if (spotifyLyricsService == null)
|
|
||||||
{
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
var spotifyLyrics = await spotifyLyricsService.GetLyricsByTrackIdAsync(spotifyTrackId);
|
|
||||||
|
|
||||||
if (spotifyLyrics != null && spotifyLyrics.Lines.Count > 0)
|
|
||||||
{
|
|
||||||
_logger.LogInformation("✓ Found Spotify lyrics for {Artist} - {Track} ({LineCount} lines)",
|
|
||||||
artistName, trackTitle, spotifyLyrics.Lines.Count);
|
|
||||||
return spotifyLyricsService.ToLyricsInfo(spotifyLyrics);
|
|
||||||
}
|
|
||||||
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Error fetching Spotify lyrics for track {SpotifyId}", spotifyTrackId);
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Checks if a track has embedded lyrics in Jellyfin using the Jellyfin item ID.
|
|
||||||
/// This is the most efficient method as it directly queries the lyrics endpoint.
|
|
||||||
/// </summary>
|
|
||||||
private async Task<bool> CheckForLocalJellyfinLyricsByIdAsync(string jellyfinItemId, string artistName, string trackTitle)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
using var scope = _serviceProvider.CreateScope();
|
|
||||||
var proxyService = scope.ServiceProvider.GetService<JellyfinProxyService>();
|
|
||||||
|
|
||||||
if (proxyService == null)
|
|
||||||
{
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Directly check if this track has lyrics using the item ID
|
|
||||||
// Use internal method with server API key since this is a background operation
|
|
||||||
var (lyricsResult, lyricsStatusCode) = await proxyService.GetJsonAsyncInternal(
|
|
||||||
$"Audio/{jellyfinItemId}/Lyrics",
|
|
||||||
null);
|
|
||||||
|
|
||||||
if (lyricsResult != null && lyricsStatusCode == 200)
|
|
||||||
{
|
|
||||||
// Track has embedded lyrics in Jellyfin
|
|
||||||
_logger.LogDebug("Found embedded lyrics in Jellyfin for {Artist} - {Track} (ID: {JellyfinId})",
|
|
||||||
artistName, trackTitle, jellyfinItemId);
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Error checking Jellyfin lyrics for item {ItemId}", jellyfinItemId);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Checks if a track has embedded lyrics in Jellyfin by querying the Jellyfin API.
|
/// Checks if a track has embedded lyrics in Jellyfin by querying the Jellyfin API.
|
||||||
/// This prevents downloading lyrics from LRCLib when the local file already has them.
|
/// This prevents downloading lyrics from LRCLib when the local file already has them.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
private async Task<bool> CheckForLocalJellyfinLyricsAsync(string spotifyTrackId, string artistName, string trackTitle)
|
private async Task<bool> CheckForLocalJellyfinLyricsAsync(string spotifyTrackId)
|
||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
@@ -444,18 +317,16 @@ public class LyricsPrefetchService : BackgroundService
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Search for the track in Jellyfin by artist and title
|
// Search for the track in Jellyfin by Spotify provider ID
|
||||||
// Jellyfin doesn't support anyProviderIdEquals - that's an Emby API parameter
|
|
||||||
var searchTerm = $"{artistName} {trackTitle}";
|
|
||||||
var searchParams = new Dictionary<string, string>
|
var searchParams = new Dictionary<string, string>
|
||||||
{
|
{
|
||||||
["searchTerm"] = searchTerm,
|
["anyProviderIdEquals"] = $"Spotify.{spotifyTrackId}",
|
||||||
["includeItemTypes"] = "Audio",
|
["includeItemTypes"] = "Audio",
|
||||||
["recursive"] = "true",
|
["recursive"] = "true",
|
||||||
["limit"] = "5" // Get a few results to find best match
|
["limit"] = "1"
|
||||||
};
|
};
|
||||||
|
|
||||||
var (searchResult, statusCode) = await proxyService.GetJsonAsyncInternal("Items", searchParams);
|
var (searchResult, statusCode) = await proxyService.GetJsonAsync("Items", searchParams, null);
|
||||||
|
|
||||||
if (searchResult == null || statusCode != 200)
|
if (searchResult == null || statusCode != 200)
|
||||||
{
|
{
|
||||||
@@ -470,57 +341,30 @@ public class LyricsPrefetchService : BackgroundService
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Find the best matching track by comparing artist and title
|
// Get the first matching track's ID
|
||||||
string? bestMatchId = null;
|
var firstItem = items[0];
|
||||||
foreach (var item in items.EnumerateArray())
|
if (!firstItem.TryGetProperty("Id", out var idElement))
|
||||||
{
|
{
|
||||||
if (!item.TryGetProperty("Name", out var nameEl) ||
|
return false;
|
||||||
!item.TryGetProperty("Id", out var idEl))
|
|
||||||
{
|
|
||||||
continue;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
var itemTitle = nameEl.GetString() ?? "";
|
var jellyfinTrackId = idElement.GetString();
|
||||||
var itemId = idEl.GetString();
|
if (string.IsNullOrEmpty(jellyfinTrackId))
|
||||||
|
|
||||||
// Check if title matches (case-insensitive)
|
|
||||||
if (itemTitle.Equals(trackTitle, StringComparison.OrdinalIgnoreCase))
|
|
||||||
{
|
|
||||||
// Also check artist if available
|
|
||||||
if (item.TryGetProperty("Artists", out var artistsEl) && artistsEl.GetArrayLength() > 0)
|
|
||||||
{
|
|
||||||
var itemArtist = artistsEl[0].GetString() ?? "";
|
|
||||||
if (itemArtist.Equals(artistName, StringComparison.OrdinalIgnoreCase))
|
|
||||||
{
|
|
||||||
bestMatchId = itemId;
|
|
||||||
break; // Exact match found
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// If no exact artist match but title matches, use it as fallback
|
|
||||||
if (bestMatchId == null)
|
|
||||||
{
|
|
||||||
bestMatchId = itemId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (string.IsNullOrEmpty(bestMatchId))
|
|
||||||
{
|
{
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check if this track has lyrics
|
// Check if this track has lyrics
|
||||||
// Use internal method with server API key since this is a background operation
|
var (lyricsResult, lyricsStatusCode) = await proxyService.GetJsonAsync(
|
||||||
var (lyricsResult, lyricsStatusCode) = await proxyService.GetJsonAsyncInternal(
|
$"Audio/{jellyfinTrackId}/Lyrics",
|
||||||
$"Audio/{bestMatchId}/Lyrics",
|
null,
|
||||||
null);
|
null);
|
||||||
|
|
||||||
if (lyricsResult != null && lyricsStatusCode == 200)
|
if (lyricsResult != null && lyricsStatusCode == 200)
|
||||||
{
|
{
|
||||||
// Track has embedded lyrics in Jellyfin
|
// Track has embedded lyrics in Jellyfin
|
||||||
_logger.LogDebug("Found embedded lyrics in Jellyfin for {Artist} - {Track} (Jellyfin ID: {JellyfinId})",
|
_logger.LogDebug("Found embedded lyrics in Jellyfin for Spotify track {SpotifyId} (Jellyfin ID: {JellyfinId})",
|
||||||
artistName, trackTitle, bestMatchId);
|
spotifyTrackId, jellyfinTrackId);
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -1,189 +0,0 @@
|
|||||||
using System.Text.Json;
|
|
||||||
using Microsoft.Extensions.Options;
|
|
||||||
using allstarr.Models.Settings;
|
|
||||||
using allstarr.Services.Validation;
|
|
||||||
|
|
||||||
namespace allstarr.Services.Lyrics;
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Validates lyrics services (LRCLib, Spotify Lyrics Sidecar, Spotify API) at startup
|
|
||||||
/// Tests with "22" by Taylor Swift (Spotify ID: 3yII7UwgLF6K5zW3xad3MP)
|
|
||||||
/// </summary>
|
|
||||||
public class LyricsStartupValidator : BaseStartupValidator
|
|
||||||
{
|
|
||||||
private readonly SpotifyApiSettings _spotifySettings;
|
|
||||||
|
|
||||||
// Test song: "22" by Taylor Swift
|
|
||||||
private const string TestSongTitle = "22";
|
|
||||||
private const string TestArtist = "Taylor Swift";
|
|
||||||
private const string TestAlbum = "Red";
|
|
||||||
private const int TestDuration = 232; // seconds
|
|
||||||
private const string TestSpotifyId = "3yII7UwgLF6K5zW3xad3MP";
|
|
||||||
|
|
||||||
public override string ServiceName => "Lyrics Services";
|
|
||||||
|
|
||||||
public LyricsStartupValidator(
|
|
||||||
IOptions<SpotifyApiSettings> spotifySettings,
|
|
||||||
IHttpClientFactory httpClientFactory)
|
|
||||||
: base(httpClientFactory.CreateClient())
|
|
||||||
{
|
|
||||||
_spotifySettings = spotifySettings.Value;
|
|
||||||
_httpClient.Timeout = TimeSpan.FromSeconds(10);
|
|
||||||
}
|
|
||||||
|
|
||||||
public override async Task<ValidationResult> ValidateAsync(CancellationToken cancellationToken)
|
|
||||||
{
|
|
||||||
Console.WriteLine();
|
|
||||||
WriteStatus("Lyrics Test Song", $"{TestSongTitle} by {TestArtist}", ConsoleColor.Cyan);
|
|
||||||
WriteDetail($"Spotify ID: {TestSpotifyId}");
|
|
||||||
|
|
||||||
var allSuccess = true;
|
|
||||||
|
|
||||||
// Test 1: LRCLib
|
|
||||||
allSuccess &= await TestLrclibAsync(cancellationToken);
|
|
||||||
|
|
||||||
// Test 2: Spotify Lyrics Sidecar
|
|
||||||
allSuccess &= await TestSpotifyLyricsSidecarAsync(cancellationToken);
|
|
||||||
|
|
||||||
// Test 3: Spotify API (if enabled)
|
|
||||||
if (_spotifySettings.Enabled)
|
|
||||||
{
|
|
||||||
allSuccess &= await TestSpotifyApiAsync(cancellationToken);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
WriteStatus("Spotify API", "DISABLED", ConsoleColor.Yellow);
|
|
||||||
WriteDetail("Enable SpotifyApi__Enabled to test Spotify API lyrics");
|
|
||||||
}
|
|
||||||
|
|
||||||
return allSuccess
|
|
||||||
? ValidationResult.Success("Lyrics services validation completed")
|
|
||||||
: ValidationResult.Failure("PARTIAL", "Some lyrics services had issues", ConsoleColor.Yellow);
|
|
||||||
}
|
|
||||||
|
|
||||||
private async Task<bool> TestLrclibAsync(CancellationToken cancellationToken)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var url = $"https://lrclib.net/api/get?artist_name={Uri.EscapeDataString(TestArtist)}&track_name={Uri.EscapeDataString(TestSongTitle)}&album_name={Uri.EscapeDataString(TestAlbum)}&duration={TestDuration}";
|
|
||||||
|
|
||||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
|
||||||
|
|
||||||
if (response.IsSuccessStatusCode)
|
|
||||||
{
|
|
||||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
|
||||||
var doc = JsonDocument.Parse(json);
|
|
||||||
|
|
||||||
var hasSyncedLyrics = doc.RootElement.TryGetProperty("syncedLyrics", out var synced) &&
|
|
||||||
!string.IsNullOrEmpty(synced.GetString());
|
|
||||||
var hasPlainLyrics = doc.RootElement.TryGetProperty("plainLyrics", out var plain) &&
|
|
||||||
!string.IsNullOrEmpty(plain.GetString());
|
|
||||||
|
|
||||||
WriteStatus("LRCLib", "WORKING", ConsoleColor.Green);
|
|
||||||
WriteDetail($"✓ Synced: {hasSyncedLyrics}, Plain: {hasPlainLyrics}");
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
else if (response.StatusCode == System.Net.HttpStatusCode.NotFound)
|
|
||||||
{
|
|
||||||
WriteStatus("LRCLib", "NO LYRICS FOUND", ConsoleColor.Yellow);
|
|
||||||
WriteDetail("Service is working but no lyrics available for test song");
|
|
||||||
return true; // Service is working, just no lyrics
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
WriteStatus("LRCLib", $"HTTP {(int)response.StatusCode}", ConsoleColor.Red);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
WriteStatus("LRCLib", "ERROR", ConsoleColor.Red);
|
|
||||||
WriteDetail($"Failed to connect: {ex.Message}");
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
private async Task<bool> TestSpotifyLyricsSidecarAsync(CancellationToken cancellationToken)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
if (string.IsNullOrEmpty(_spotifySettings.LyricsApiUrl))
|
|
||||||
{
|
|
||||||
WriteStatus("Spotify Lyrics Sidecar", "NOT CONFIGURED", ConsoleColor.Yellow);
|
|
||||||
WriteDetail("Set SpotifyApi__LyricsApiUrl to enable");
|
|
||||||
return true; // Not an error, just not configured
|
|
||||||
}
|
|
||||||
|
|
||||||
var url = $"{_spotifySettings.LyricsApiUrl}/?trackid={TestSpotifyId}&format=id3";
|
|
||||||
|
|
||||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
|
||||||
|
|
||||||
if (response.IsSuccessStatusCode)
|
|
||||||
{
|
|
||||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
|
||||||
var doc = JsonDocument.Parse(json);
|
|
||||||
|
|
||||||
var hasError = doc.RootElement.TryGetProperty("error", out var error) && error.GetBoolean();
|
|
||||||
|
|
||||||
if (hasError)
|
|
||||||
{
|
|
||||||
var message = doc.RootElement.TryGetProperty("message", out var msg)
|
|
||||||
? msg.GetString()
|
|
||||||
: "Unknown error";
|
|
||||||
WriteStatus("Spotify Lyrics Sidecar", "API ERROR", ConsoleColor.Yellow);
|
|
||||||
WriteDetail($"⚠ {message}");
|
|
||||||
WriteDetail("Check if sp_dc cookie is valid");
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
var syncType = doc.RootElement.TryGetProperty("syncType", out var st)
|
|
||||||
? st.GetString()
|
|
||||||
: "UNKNOWN";
|
|
||||||
var lineCount = doc.RootElement.TryGetProperty("lines", out var lines)
|
|
||||||
? lines.GetArrayLength()
|
|
||||||
: 0;
|
|
||||||
|
|
||||||
WriteStatus("Spotify Lyrics Sidecar", "WORKING", ConsoleColor.Green);
|
|
||||||
WriteDetail($"✓ Type: {syncType}, Lines: {lineCount}");
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
WriteStatus("Spotify Lyrics Sidecar", $"HTTP {(int)response.StatusCode}", ConsoleColor.Red);
|
|
||||||
WriteDetail("Check if spotify-lyrics container is running");
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
WriteStatus("Spotify Lyrics Sidecar", "ERROR", ConsoleColor.Red);
|
|
||||||
WriteDetail($"Failed to connect: {ex.Message}");
|
|
||||||
WriteDetail("Ensure spotify-lyrics container is running in docker-compose");
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
private async Task<bool> TestSpotifyApiAsync(CancellationToken cancellationToken)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
if (string.IsNullOrEmpty(_spotifySettings.ClientId))
|
|
||||||
{
|
|
||||||
WriteStatus("Spotify API", "NOT CONFIGURED", ConsoleColor.Yellow);
|
|
||||||
WriteDetail("Set SpotifyApi__ClientId to enable");
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
WriteStatus("Spotify API", "CONFIGURED", ConsoleColor.Green);
|
|
||||||
WriteDetail($"Client ID: {_spotifySettings.ClientId.Substring(0, Math.Min(8, _spotifySettings.ClientId.Length))}...");
|
|
||||||
WriteDetail("Note: Spotify API is used for track matching, not lyrics");
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
WriteStatus("Spotify API", "ERROR", ConsoleColor.Red);
|
|
||||||
WriteDetail($"Validation failed: {ex.Message}");
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -24,25 +24,31 @@ public class SpotifyLyricsService
|
|||||||
{
|
{
|
||||||
private readonly ILogger<SpotifyLyricsService> _logger;
|
private readonly ILogger<SpotifyLyricsService> _logger;
|
||||||
private readonly SpotifyApiSettings _settings;
|
private readonly SpotifyApiSettings _settings;
|
||||||
|
private readonly SpotifyApiClient _spotifyClient;
|
||||||
private readonly RedisCacheService _cache;
|
private readonly RedisCacheService _cache;
|
||||||
private readonly HttpClient _httpClient;
|
private readonly HttpClient _httpClient;
|
||||||
|
|
||||||
|
private const string LyricsApiBase = "https://spclient.wg.spotify.com/color-lyrics/v2/track";
|
||||||
|
|
||||||
public SpotifyLyricsService(
|
public SpotifyLyricsService(
|
||||||
ILogger<SpotifyLyricsService> logger,
|
ILogger<SpotifyLyricsService> logger,
|
||||||
IOptions<SpotifyApiSettings> settings,
|
IOptions<SpotifyApiSettings> settings,
|
||||||
|
SpotifyApiClient spotifyClient,
|
||||||
RedisCacheService cache,
|
RedisCacheService cache,
|
||||||
IHttpClientFactory httpClientFactory)
|
IHttpClientFactory httpClientFactory)
|
||||||
{
|
{
|
||||||
_logger = logger;
|
_logger = logger;
|
||||||
_settings = settings.Value;
|
_settings = settings.Value;
|
||||||
|
_spotifyClient = spotifyClient;
|
||||||
_cache = cache;
|
_cache = cache;
|
||||||
|
|
||||||
_httpClient = httpClientFactory.CreateClient();
|
_httpClient = httpClientFactory.CreateClient();
|
||||||
_httpClient.Timeout = TimeSpan.FromSeconds(10);
|
_httpClient.DefaultRequestHeaders.Add("User-Agent", "Mozilla/5.0");
|
||||||
|
_httpClient.DefaultRequestHeaders.Add("App-Platform", "WebPlayer");
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Gets synchronized lyrics for a Spotify track by its ID using the sidecar API.
|
/// Gets synchronized lyrics for a Spotify track by its ID.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
/// <param name="spotifyTrackId">Spotify track ID (e.g., "3a8mo25v74BMUOJ1IDUEBL")</param>
|
/// <param name="spotifyTrackId">Spotify track ID (e.g., "3a8mo25v74BMUOJ1IDUEBL")</param>
|
||||||
/// <returns>Lyrics info with synced lyrics in LRC format, or null if not available</returns>
|
/// <returns>Lyrics info with synced lyrics in LRC format, or null if not available</returns>
|
||||||
@@ -54,37 +60,58 @@ public class SpotifyLyricsService
|
|||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (string.IsNullOrEmpty(_settings.LyricsApiUrl))
|
|
||||||
{
|
|
||||||
_logger.LogWarning("Spotify lyrics API URL not configured");
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Normalize track ID (remove URI prefix if present)
|
// Normalize track ID (remove URI prefix if present)
|
||||||
spotifyTrackId = ExtractTrackId(spotifyTrackId);
|
spotifyTrackId = ExtractTrackId(spotifyTrackId);
|
||||||
|
|
||||||
// NO CACHING - Spotify lyrics come from local Docker container (fast)
|
// Check cache
|
||||||
|
var cacheKey = $"spotify:lyrics:{spotifyTrackId}";
|
||||||
|
var cached = await _cache.GetAsync<SpotifyLyricsResult>(cacheKey);
|
||||||
|
if (cached != null)
|
||||||
|
{
|
||||||
|
_logger.LogDebug("Returning cached Spotify lyrics for track {TrackId}", spotifyTrackId);
|
||||||
|
return cached;
|
||||||
|
}
|
||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
var url = $"{_settings.LyricsApiUrl}/?trackid={spotifyTrackId}&format=id3";
|
// Get access token
|
||||||
|
var token = await _spotifyClient.GetWebAccessTokenAsync();
|
||||||
|
if (string.IsNullOrEmpty(token))
|
||||||
|
{
|
||||||
|
_logger.LogWarning("Could not get Spotify access token for lyrics");
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
_logger.LogDebug("Fetching lyrics from sidecar API: {Url}", url);
|
// Request lyrics from Spotify's color-lyrics API
|
||||||
|
var url = $"{LyricsApiBase}/{spotifyTrackId}?format=json&vocalRemoval=false&market=from_token";
|
||||||
|
|
||||||
var response = await _httpClient.GetAsync(url);
|
var request = new HttpRequestMessage(HttpMethod.Get, url);
|
||||||
|
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", token);
|
||||||
|
request.Headers.Add("Accept", "application/json");
|
||||||
|
|
||||||
|
var response = await _httpClient.SendAsync(request);
|
||||||
|
|
||||||
|
if (response.StatusCode == HttpStatusCode.NotFound)
|
||||||
|
{
|
||||||
|
_logger.LogDebug("No lyrics found on Spotify for track {TrackId}", spotifyTrackId);
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
if (!response.IsSuccessStatusCode)
|
if (!response.IsSuccessStatusCode)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("Sidecar API returned {StatusCode} for track {TrackId}",
|
_logger.LogWarning("Spotify lyrics API returned {StatusCode} for track {TrackId}",
|
||||||
response.StatusCode, spotifyTrackId);
|
response.StatusCode, spotifyTrackId);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
var json = await response.Content.ReadAsStringAsync();
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
var result = ParseSidecarResponse(json, spotifyTrackId);
|
var result = ParseLyricsResponse(json, spotifyTrackId);
|
||||||
|
|
||||||
if (result != null)
|
if (result != null)
|
||||||
{
|
{
|
||||||
_logger.LogInformation("Got Spotify lyrics from sidecar for track {TrackId} ({LineCount} lines)",
|
// Cache for 30 days (lyrics don't change)
|
||||||
|
await _cache.SetAsync(cacheKey, result, TimeSpan.FromDays(30));
|
||||||
|
_logger.LogInformation("Cached Spotify lyrics for track {TrackId} ({LineCount} lines)",
|
||||||
spotifyTrackId, result.Lines.Count);
|
spotifyTrackId, result.Lines.Count);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -92,15 +119,14 @@ public class SpotifyLyricsService
|
|||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogWarning(ex, "Error fetching lyrics from sidecar API for track {TrackId}", spotifyTrackId);
|
_logger.LogError(ex, "Error fetching Spotify lyrics for track {TrackId}", spotifyTrackId);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Searches for a track on Spotify and returns its lyrics using the sidecar API.
|
/// Searches for a track on Spotify and returns its lyrics.
|
||||||
/// Useful when you have track metadata but not a Spotify ID.
|
/// Useful when you have track metadata but not a Spotify ID.
|
||||||
/// Note: This requires the sidecar to handle search, or we skip it.
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public async Task<SpotifyLyricsResult?> SearchAndGetLyricsAsync(
|
public async Task<SpotifyLyricsResult?> SearchAndGetLyricsAsync(
|
||||||
string trackName,
|
string trackName,
|
||||||
@@ -110,17 +136,87 @@ public class SpotifyLyricsService
|
|||||||
{
|
{
|
||||||
if (!_settings.Enabled || string.IsNullOrEmpty(_settings.SessionCookie))
|
if (!_settings.Enabled || string.IsNullOrEmpty(_settings.SessionCookie))
|
||||||
{
|
{
|
||||||
_logger.LogDebug("Spotify lyrics search skipped: API not enabled or no session cookie");
|
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
// The sidecar API only supports track ID, not search
|
try
|
||||||
// So we skip Spotify lyrics for search-based requests
|
{
|
||||||
// LRCLib will be used as fallback
|
var token = await _spotifyClient.GetWebAccessTokenAsync();
|
||||||
_logger.LogDebug("Spotify lyrics search by metadata not supported with sidecar API, skipping");
|
if (string.IsNullOrEmpty(token))
|
||||||
|
{
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Search for the track
|
||||||
|
var query = $"track:{trackName} artist:{artistName}";
|
||||||
|
if (!string.IsNullOrEmpty(albumName))
|
||||||
|
{
|
||||||
|
query += $" album:{albumName}";
|
||||||
|
}
|
||||||
|
|
||||||
|
var searchUrl = $"https://api.spotify.com/v1/search?q={Uri.EscapeDataString(query)}&type=track&limit=5";
|
||||||
|
|
||||||
|
var request = new HttpRequestMessage(HttpMethod.Get, searchUrl);
|
||||||
|
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", token);
|
||||||
|
|
||||||
|
var response = await _httpClient.SendAsync(request);
|
||||||
|
if (!response.IsSuccessStatusCode)
|
||||||
|
{
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
|
using var doc = JsonDocument.Parse(json);
|
||||||
|
var root = doc.RootElement;
|
||||||
|
|
||||||
|
if (!root.TryGetProperty("tracks", out var tracks) ||
|
||||||
|
!tracks.TryGetProperty("items", out var items) ||
|
||||||
|
items.GetArrayLength() == 0)
|
||||||
|
{
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Find best match considering duration if provided
|
||||||
|
string? bestMatchId = null;
|
||||||
|
var bestScore = 0;
|
||||||
|
|
||||||
|
foreach (var item in items.EnumerateArray())
|
||||||
|
{
|
||||||
|
var id = item.TryGetProperty("id", out var idProp) ? idProp.GetString() : null;
|
||||||
|
if (string.IsNullOrEmpty(id)) continue;
|
||||||
|
|
||||||
|
var score = 100; // Base score
|
||||||
|
|
||||||
|
// Check duration match
|
||||||
|
if (durationMs.HasValue && item.TryGetProperty("duration_ms", out var durProp))
|
||||||
|
{
|
||||||
|
var trackDuration = durProp.GetInt32();
|
||||||
|
var durationDiff = Math.Abs(trackDuration - durationMs.Value);
|
||||||
|
if (durationDiff < 2000) score += 50; // Within 2 seconds
|
||||||
|
else if (durationDiff < 5000) score += 25; // Within 5 seconds
|
||||||
|
}
|
||||||
|
|
||||||
|
if (score > bestScore)
|
||||||
|
{
|
||||||
|
bestScore = score;
|
||||||
|
bestMatchId = id;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!string.IsNullOrEmpty(bestMatchId))
|
||||||
|
{
|
||||||
|
return await GetLyricsByTrackIdAsync(bestMatchId);
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogError(ex, "Error searching Spotify for lyrics: {Track} - {Artist}", trackName, artistName);
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Converts Spotify lyrics to LRCLIB-compatible LyricsInfo format.
|
/// Converts Spotify lyrics to LRCLIB-compatible LyricsInfo format.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
@@ -155,37 +251,29 @@ public class SpotifyLyricsService
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
private SpotifyLyricsResult? ParseLyricsResponse(string json, string trackId)
|
||||||
/// Parses the response from the sidecar spotify-lyrics-api service.
|
|
||||||
/// Format: {"error": false, "syncType": "LINE_SYNCED", "lines": [...]}
|
|
||||||
/// </summary>
|
|
||||||
private SpotifyLyricsResult? ParseSidecarResponse(string json, string trackId)
|
|
||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
using var doc = JsonDocument.Parse(json);
|
using var doc = JsonDocument.Parse(json);
|
||||||
var root = doc.RootElement;
|
var root = doc.RootElement;
|
||||||
|
|
||||||
// Check for error
|
|
||||||
if (root.TryGetProperty("error", out var error) && error.GetBoolean())
|
|
||||||
{
|
|
||||||
_logger.LogDebug("Sidecar API returned error for track {TrackId}", trackId);
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
var result = new SpotifyLyricsResult
|
var result = new SpotifyLyricsResult
|
||||||
{
|
{
|
||||||
SpotifyTrackId = trackId
|
SpotifyTrackId = trackId
|
||||||
};
|
};
|
||||||
|
|
||||||
// Get sync type
|
// Parse lyrics lines
|
||||||
if (root.TryGetProperty("syncType", out var syncType))
|
if (root.TryGetProperty("lyrics", out var lyrics))
|
||||||
|
{
|
||||||
|
// Check sync type
|
||||||
|
if (lyrics.TryGetProperty("syncType", out var syncType))
|
||||||
{
|
{
|
||||||
result.SyncType = syncType.GetString() ?? "LINE_SYNCED";
|
result.SyncType = syncType.GetString() ?? "LINE_SYNCED";
|
||||||
}
|
}
|
||||||
|
|
||||||
// Parse lines
|
// Parse lines
|
||||||
if (root.TryGetProperty("lines", out var lines))
|
if (lyrics.TryGetProperty("lines", out var lines))
|
||||||
{
|
{
|
||||||
foreach (var line in lines.EnumerateArray())
|
foreach (var line in lines.EnumerateArray())
|
||||||
{
|
{
|
||||||
@@ -199,19 +287,84 @@ public class SpotifyLyricsService
|
|||||||
? long.Parse(end.GetString() ?? "0") : 0
|
? long.Parse(end.GetString() ?? "0") : 0
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Parse syllables if available (for word-level sync)
|
||||||
|
if (line.TryGetProperty("syllables", out var syllables))
|
||||||
|
{
|
||||||
|
foreach (var syllable in syllables.EnumerateArray())
|
||||||
|
{
|
||||||
|
lyricsLine.Syllables.Add(new SpotifyLyricsSyllable
|
||||||
|
{
|
||||||
|
StartTimeMs = syllable.TryGetProperty("startTimeMs", out var sStart)
|
||||||
|
? long.Parse(sStart.GetString() ?? "0") : 0,
|
||||||
|
Text = syllable.TryGetProperty("charsIndex", out var text)
|
||||||
|
? text.GetString() ?? "" : ""
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
result.Lines.Add(lyricsLine);
|
result.Lines.Add(lyricsLine);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Parse color information
|
||||||
|
if (lyrics.TryGetProperty("colors", out var colors))
|
||||||
|
{
|
||||||
|
result.Colors = new SpotifyLyricsColors
|
||||||
|
{
|
||||||
|
Background = colors.TryGetProperty("background", out var bg)
|
||||||
|
? ParseColorValue(bg) : null,
|
||||||
|
Text = colors.TryGetProperty("text", out var txt)
|
||||||
|
? ParseColorValue(txt) : null,
|
||||||
|
HighlightText = colors.TryGetProperty("highlightText", out var ht)
|
||||||
|
? ParseColorValue(ht) : null
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// Language
|
||||||
|
if (lyrics.TryGetProperty("language", out var lang))
|
||||||
|
{
|
||||||
|
result.Language = lang.GetString();
|
||||||
|
}
|
||||||
|
|
||||||
|
// Provider info
|
||||||
|
if (lyrics.TryGetProperty("provider", out var provider))
|
||||||
|
{
|
||||||
|
result.Provider = provider.GetString();
|
||||||
|
}
|
||||||
|
|
||||||
|
// Display info
|
||||||
|
if (lyrics.TryGetProperty("providerDisplayName", out var providerDisplay))
|
||||||
|
{
|
||||||
|
result.ProviderDisplayName = providerDisplay.GetString();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
_logger.LogError(ex, "Error parsing sidecar API response");
|
_logger.LogError(ex, "Error parsing Spotify lyrics response");
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private static int? ParseColorValue(JsonElement element)
|
||||||
|
{
|
||||||
|
if (element.ValueKind == JsonValueKind.Number)
|
||||||
|
{
|
||||||
|
return element.GetInt32();
|
||||||
|
}
|
||||||
|
if (element.ValueKind == JsonValueKind.String)
|
||||||
|
{
|
||||||
|
var str = element.GetString();
|
||||||
|
if (!string.IsNullOrEmpty(str) && int.TryParse(str, out var val))
|
||||||
|
{
|
||||||
|
return val;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
private static string ExtractTrackId(string input)
|
private static string ExtractTrackId(string input)
|
||||||
{
|
{
|
||||||
if (string.IsNullOrEmpty(input)) return input;
|
if (string.IsNullOrEmpty(input)) return input;
|
||||||
|
|||||||
@@ -110,10 +110,7 @@ public class QobuzDownloadService : BaseDownloadService
|
|||||||
|
|
||||||
// Build organized folder structure using AlbumArtist (fallback to Artist for singles)
|
// Build organized folder structure using AlbumArtist (fallback to Artist for singles)
|
||||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||||
// Cache mode uses downloads/cache/ folder, Permanent mode uses downloads/permanent/
|
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache ? CachePath : DownloadPath;
|
||||||
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache
|
|
||||||
? Path.Combine(DownloadPath, "cache")
|
|
||||||
: Path.Combine(DownloadPath, "permanent");
|
|
||||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension);
|
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension);
|
||||||
|
|
||||||
var albumFolder = Path.GetDirectoryName(outputPath)!;
|
var albumFolder = Path.GetDirectoryName(outputPath)!;
|
||||||
|
|||||||
@@ -44,7 +44,7 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
public async Task TriggerFetchAsync()
|
public async Task TriggerFetchAsync()
|
||||||
{
|
{
|
||||||
_logger.LogInformation("Manual fetch triggered");
|
_logger.LogInformation("Manual fetch triggered");
|
||||||
await FetchMissingTracksAsync(CancellationToken.None);
|
await FetchMissingTracksAsync(CancellationToken.None, bypassSyncWindowCheck: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
protected override async Task ExecuteAsync(CancellationToken stoppingToken)
|
protected override async Task ExecuteAsync(CancellationToken stoppingToken)
|
||||||
@@ -84,7 +84,20 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
|
|
||||||
_logger.LogInformation("Spotify Import ENABLED");
|
_logger.LogInformation("Spotify Import ENABLED");
|
||||||
_logger.LogInformation("Configured Playlists: {Count}", _spotifySettings.Value.Playlists.Count);
|
_logger.LogInformation("Configured Playlists: {Count}", _spotifySettings.Value.Playlists.Count);
|
||||||
_logger.LogInformation("Background check interval: 5 minutes");
|
|
||||||
|
// Log the search schedule
|
||||||
|
var settings = _spotifySettings.Value;
|
||||||
|
var syncTime = DateTime.Today
|
||||||
|
.AddHours(settings.SyncStartHour)
|
||||||
|
.AddMinutes(settings.SyncStartMinute);
|
||||||
|
var syncEndTime = syncTime.AddHours(settings.SyncWindowHours);
|
||||||
|
|
||||||
|
_logger.LogInformation("Search Schedule:");
|
||||||
|
_logger.LogInformation(" Plugin sync time: {Time:HH:mm} UTC (configured)", syncTime);
|
||||||
|
_logger.LogInformation(" Search window: {Start:HH:mm} - {End:HH:mm} UTC ({Hours}h window)",
|
||||||
|
syncTime, syncEndTime, settings.SyncWindowHours);
|
||||||
|
_logger.LogInformation(" Will search for new files once per day after sync window ends");
|
||||||
|
_logger.LogInformation(" Background check interval: 5 minutes");
|
||||||
|
|
||||||
// Fetch playlist names from Jellyfin
|
// Fetch playlist names from Jellyfin
|
||||||
await LoadPlaylistNamesAsync();
|
await LoadPlaylistNamesAsync();
|
||||||
@@ -96,7 +109,7 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
}
|
}
|
||||||
_logger.LogInformation("========================================");
|
_logger.LogInformation("========================================");
|
||||||
|
|
||||||
// Run on startup if we don't have cache
|
// Check if we should run on startup
|
||||||
if (!_hasRunOnce)
|
if (!_hasRunOnce)
|
||||||
{
|
{
|
||||||
var shouldRun = await ShouldRunOnStartupAsync();
|
var shouldRun = await ShouldRunOnStartupAsync();
|
||||||
@@ -105,7 +118,7 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
_logger.LogInformation("Running initial fetch on startup");
|
_logger.LogInformation("Running initial fetch on startup");
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
await FetchMissingTracksAsync(stoppingToken);
|
await FetchMissingTracksAsync(stoppingToken, bypassSyncWindowCheck: true);
|
||||||
_hasRunOnce = true;
|
_hasRunOnce = true;
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
@@ -115,20 +128,21 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
_logger.LogInformation("Skipping startup fetch - already have cached files");
|
_logger.LogInformation("Skipping startup fetch - already have current files");
|
||||||
_hasRunOnce = true;
|
_hasRunOnce = true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Background loop - check for new files every 5 minutes
|
|
||||||
while (!stoppingToken.IsCancellationRequested)
|
while (!stoppingToken.IsCancellationRequested)
|
||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
|
// Only fetch if we're past today's sync window AND we haven't fetched today yet
|
||||||
var shouldFetch = await ShouldFetchNowAsync();
|
var shouldFetch = await ShouldFetchNowAsync();
|
||||||
if (shouldFetch)
|
if (shouldFetch)
|
||||||
{
|
{
|
||||||
await FetchMissingTracksAsync(stoppingToken);
|
await FetchMissingTracksAsync(stoppingToken);
|
||||||
|
_hasRunOnce = true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
@@ -142,29 +156,42 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
|
|
||||||
private async Task<bool> ShouldFetchNowAsync()
|
private async Task<bool> ShouldFetchNowAsync()
|
||||||
{
|
{
|
||||||
// Check if we have recent cache files (within last 24 hours)
|
var settings = _spotifySettings.Value;
|
||||||
var now = DateTime.UtcNow;
|
var now = DateTime.UtcNow;
|
||||||
var cacheThreshold = now.AddHours(-24);
|
|
||||||
|
|
||||||
|
// Calculate today's sync window
|
||||||
|
var todaySync = now.Date
|
||||||
|
.AddHours(settings.SyncStartHour)
|
||||||
|
.AddMinutes(settings.SyncStartMinute);
|
||||||
|
var todaySyncEnd = todaySync.AddHours(settings.SyncWindowHours);
|
||||||
|
|
||||||
|
// Only fetch if we're past today's sync window
|
||||||
|
if (now < todaySyncEnd)
|
||||||
|
{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if we already have today's files
|
||||||
foreach (var playlistName in _playlistIdToName.Values)
|
foreach (var playlistName in _playlistIdToName.Values)
|
||||||
{
|
{
|
||||||
var filePath = GetCacheFilePath(playlistName);
|
var filePath = GetCacheFilePath(playlistName);
|
||||||
|
|
||||||
if (!File.Exists(filePath))
|
if (File.Exists(filePath))
|
||||||
{
|
{
|
||||||
// Missing cache file for this playlist
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
var fileTime = File.GetLastWriteTimeUtc(filePath);
|
var fileTime = File.GetLastWriteTimeUtc(filePath);
|
||||||
if (fileTime < cacheThreshold)
|
|
||||||
|
// If file is from today's sync or later, we already have it
|
||||||
|
if (fileTime >= todaySync)
|
||||||
{
|
{
|
||||||
// Cache file is older than 24 hours
|
continue;
|
||||||
return true;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// All playlists have recent cache files
|
// Missing today's file for this playlist
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
// All playlists have today's files
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -183,6 +210,25 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
{
|
{
|
||||||
_logger.LogInformation("=== STARTUP CACHE CHECK ===");
|
_logger.LogInformation("=== STARTUP CACHE CHECK ===");
|
||||||
|
|
||||||
|
var settings = _spotifySettings.Value;
|
||||||
|
var now = DateTime.UtcNow;
|
||||||
|
|
||||||
|
// Calculate today's sync window
|
||||||
|
var todaySync = now.Date
|
||||||
|
.AddHours(settings.SyncStartHour)
|
||||||
|
.AddMinutes(settings.SyncStartMinute);
|
||||||
|
var todaySyncEnd = todaySync.AddHours(settings.SyncWindowHours);
|
||||||
|
|
||||||
|
_logger.LogInformation("Today's sync window: {Start:yyyy-MM-dd HH:mm} - {End:yyyy-MM-dd HH:mm} UTC",
|
||||||
|
todaySync, todaySyncEnd);
|
||||||
|
_logger.LogInformation("Current time: {Now:yyyy-MM-dd HH:mm} UTC", now);
|
||||||
|
|
||||||
|
// If we're still before today's sync window end, we should have yesterday's or today's file
|
||||||
|
// Don't search again until after today's sync window ends
|
||||||
|
if (now < todaySyncEnd)
|
||||||
|
{
|
||||||
|
_logger.LogInformation("We're before today's sync window end - checking if we have recent cache...");
|
||||||
|
|
||||||
var allPlaylistsHaveCache = true;
|
var allPlaylistsHaveCache = true;
|
||||||
|
|
||||||
foreach (var playlistName in _playlistIdToName.Values)
|
foreach (var playlistName in _playlistIdToName.Values)
|
||||||
@@ -219,8 +265,66 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
if (allPlaylistsHaveCache)
|
if (allPlaylistsHaveCache)
|
||||||
{
|
{
|
||||||
_logger.LogInformation("=== ALL PLAYLISTS HAVE CACHE - SKIPPING STARTUP FETCH ===");
|
_logger.LogInformation("=== ALL PLAYLISTS HAVE CACHE - SKIPPING STARTUP FETCH ===");
|
||||||
|
_logger.LogInformation("Will search again after {Time:yyyy-MM-dd HH:mm} UTC", todaySyncEnd);
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// If we're after today's sync window end, check if we already have today's file
|
||||||
|
if (now >= todaySyncEnd)
|
||||||
|
{
|
||||||
|
_logger.LogInformation("We're after today's sync window end - checking if we already fetched today's files...");
|
||||||
|
|
||||||
|
var allPlaylistsHaveTodaysFile = true;
|
||||||
|
|
||||||
|
foreach (var playlistName in _playlistIdToName.Values)
|
||||||
|
{
|
||||||
|
var filePath = GetCacheFilePath(playlistName);
|
||||||
|
var cacheKey = $"spotify:missing:{playlistName}";
|
||||||
|
|
||||||
|
// Check if file exists and was created today (after sync start)
|
||||||
|
if (File.Exists(filePath))
|
||||||
|
{
|
||||||
|
var fileTime = File.GetLastWriteTimeUtc(filePath);
|
||||||
|
|
||||||
|
// File should be from today's sync window or later
|
||||||
|
if (fileTime >= todaySync)
|
||||||
|
{
|
||||||
|
var fileAge = DateTime.UtcNow - fileTime;
|
||||||
|
_logger.LogInformation(" {Playlist}: Have today's file (created {Time:yyyy-MM-dd HH:mm}, age: {Age:F1}h)",
|
||||||
|
playlistName, fileTime, fileAge.TotalHours);
|
||||||
|
|
||||||
|
// Load into Redis if not already there
|
||||||
|
if (!await _cache.ExistsAsync(cacheKey))
|
||||||
|
{
|
||||||
|
await LoadFromFileCache(playlistName);
|
||||||
|
}
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
_logger.LogInformation(" {Playlist}: File is old (from {Time:yyyy-MM-dd HH:mm}, before today's sync)",
|
||||||
|
playlistName, fileTime);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
_logger.LogInformation(" {Playlist}: No file found", playlistName);
|
||||||
|
}
|
||||||
|
|
||||||
|
allPlaylistsHaveTodaysFile = false;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (allPlaylistsHaveTodaysFile)
|
||||||
|
{
|
||||||
|
_logger.LogInformation("=== ALL PLAYLISTS HAVE TODAY'S FILES - SKIPPING STARTUP FETCH ===");
|
||||||
|
|
||||||
|
// Calculate when to search next (tomorrow after sync window)
|
||||||
|
var tomorrowSyncEnd = todaySyncEnd.AddDays(1);
|
||||||
|
_logger.LogInformation("Will search again after {Time:yyyy-MM-dd HH:mm} UTC", tomorrowSyncEnd);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
_logger.LogInformation("=== WILL FETCH ON STARTUP ===");
|
_logger.LogInformation("=== WILL FETCH ON STARTUP ===");
|
||||||
return true;
|
return true;
|
||||||
@@ -276,9 +380,32 @@ public class SpotifyMissingTracksFetcher : BackgroundService
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private async Task FetchMissingTracksAsync(CancellationToken cancellationToken)
|
private async Task FetchMissingTracksAsync(CancellationToken cancellationToken, bool bypassSyncWindowCheck = false)
|
||||||
{
|
{
|
||||||
_logger.LogInformation("=== FETCHING MISSING TRACKS ===");
|
var settings = _spotifySettings.Value;
|
||||||
|
var now = DateTime.UtcNow;
|
||||||
|
var syncStart = now.Date
|
||||||
|
.AddHours(settings.SyncStartHour)
|
||||||
|
.AddMinutes(settings.SyncStartMinute);
|
||||||
|
var syncEnd = syncStart.AddHours(settings.SyncWindowHours);
|
||||||
|
|
||||||
|
// Only run after the sync window has passed (unless bypassing for startup)
|
||||||
|
if (!bypassSyncWindowCheck && now < syncEnd)
|
||||||
|
{
|
||||||
|
_logger.LogInformation("Skipping fetch - sync window not passed yet (now: {Now}, window ends: {End})",
|
||||||
|
now, syncEnd);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (bypassSyncWindowCheck)
|
||||||
|
{
|
||||||
|
_logger.LogInformation("=== FETCHING MISSING TRACKS (STARTUP MODE) ===");
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
_logger.LogInformation("=== FETCHING MISSING TRACKS (SYNC WINDOW PASSED) ===");
|
||||||
|
}
|
||||||
|
|
||||||
_logger.LogInformation("Processing {Count} playlists", _playlistIdToName.Count);
|
_logger.LogInformation("Processing {Count} playlists", _playlistIdToName.Count);
|
||||||
|
|
||||||
// Track when we find files to optimize search for other playlists
|
// Track when we find files to optimize search for other playlists
|
||||||
|
|||||||
@@ -227,7 +227,6 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
/// New matching mode that uses ISRC when available for exact matches.
|
/// New matching mode that uses ISRC when available for exact matches.
|
||||||
/// Preserves track position for correct playlist ordering.
|
/// Preserves track position for correct playlist ordering.
|
||||||
/// Only matches tracks that aren't already in the Jellyfin playlist.
|
/// Only matches tracks that aren't already in the Jellyfin playlist.
|
||||||
/// Uses GREEDY ASSIGNMENT to maximize total matches.
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
private async Task MatchPlaylistTracksWithIsrcAsync(
|
private async Task MatchPlaylistTracksWithIsrcAsync(
|
||||||
string playlistName,
|
string playlistName,
|
||||||
@@ -321,7 +320,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogInformation("Matching {ToMatch}/{Total} tracks for {Playlist} (skipping {Existing} already in Jellyfin, ISRC: {IsrcEnabled}, AGGRESSIVE MODE)",
|
_logger.LogInformation("Matching {ToMatch}/{Total} tracks for {Playlist} (skipping {Existing} already in Jellyfin, ISRC: {IsrcEnabled})",
|
||||||
tracksToMatch.Count, spotifyTracks.Count, playlistName, existingSpotifyIds.Count, _spotifyApiSettings.PreferIsrcMatching);
|
tracksToMatch.Count, spotifyTracks.Count, playlistName, existingSpotifyIds.Count, _spotifyApiSettings.PreferIsrcMatching);
|
||||||
|
|
||||||
// Check cache - use snapshot/timestamp to detect changes
|
// Check cache - use snapshot/timestamp to detect changes
|
||||||
@@ -368,9 +367,6 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
var fuzzyMatches = 0;
|
var fuzzyMatches = 0;
|
||||||
var noMatch = 0;
|
var noMatch = 0;
|
||||||
|
|
||||||
// GREEDY ASSIGNMENT: Collect all possible matches first, then assign optimally
|
|
||||||
var allCandidates = new List<(SpotifyPlaylistTrack SpotifyTrack, Song MatchedSong, double Score, string MatchType)>();
|
|
||||||
|
|
||||||
// Process tracks in batches for parallel searching
|
// Process tracks in batches for parallel searching
|
||||||
var orderedTracks = tracksToMatch.OrderBy(t => t.Position).ToList();
|
var orderedTracks = tracksToMatch.OrderBy(t => t.Position).ToList();
|
||||||
for (int i = 0; i < orderedTracks.Count; i += BatchSize)
|
for (int i = 0; i < orderedTracks.Count; i += BatchSize)
|
||||||
@@ -386,86 +382,34 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
var candidates = new List<(Song Song, double Score, string MatchType)>();
|
Song? matchedSong = null;
|
||||||
|
var matchType = "none";
|
||||||
|
|
||||||
// Try ISRC match first if available and enabled
|
// Try ISRC match first if available and enabled
|
||||||
if (_spotifyApiSettings.PreferIsrcMatching && !string.IsNullOrEmpty(spotifyTrack.Isrc))
|
if (_spotifyApiSettings.PreferIsrcMatching && !string.IsNullOrEmpty(spotifyTrack.Isrc))
|
||||||
{
|
{
|
||||||
var isrcSong = await TryMatchByIsrcAsync(spotifyTrack.Isrc, metadataService);
|
matchedSong = await TryMatchByIsrcAsync(spotifyTrack.Isrc, metadataService);
|
||||||
if (isrcSong != null)
|
if (matchedSong != null)
|
||||||
{
|
{
|
||||||
candidates.Add((isrcSong, 100.0, "isrc"));
|
matchType = "isrc";
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Always try fuzzy matching to get more candidates
|
// Fall back to fuzzy matching
|
||||||
var fuzzySongs = await TryMatchByFuzzyMultipleAsync(
|
if (matchedSong == null)
|
||||||
|
{
|
||||||
|
matchedSong = await TryMatchByFuzzyAsync(
|
||||||
spotifyTrack.Title,
|
spotifyTrack.Title,
|
||||||
spotifyTrack.Artists,
|
spotifyTrack.Artists,
|
||||||
metadataService);
|
metadataService);
|
||||||
|
|
||||||
foreach (var (song, score) in fuzzySongs)
|
if (matchedSong != null)
|
||||||
{
|
{
|
||||||
candidates.Add((song, score, "fuzzy"));
|
matchType = "fuzzy";
|
||||||
}
|
|
||||||
|
|
||||||
return (spotifyTrack, candidates);
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
_logger.LogDebug(ex, "Failed to match track: {Title} - {Artist}",
|
|
||||||
spotifyTrack.Title, spotifyTrack.PrimaryArtist);
|
|
||||||
return (spotifyTrack, new List<(Song, double, string)>());
|
|
||||||
}
|
|
||||||
}).ToList();
|
|
||||||
|
|
||||||
// Wait for all tracks in this batch to complete
|
|
||||||
var batchResults = await Task.WhenAll(batchTasks);
|
|
||||||
|
|
||||||
// Collect all candidates
|
|
||||||
foreach (var (spotifyTrack, candidates) in batchResults)
|
|
||||||
{
|
|
||||||
foreach (var (song, score, matchType) in candidates)
|
|
||||||
{
|
|
||||||
allCandidates.Add((spotifyTrack, song, score, matchType));
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Rate limiting between batches
|
if (matchedSong != null)
|
||||||
if (i + BatchSize < orderedTracks.Count)
|
|
||||||
{
|
|
||||||
await Task.Delay(DelayBetweenSearchesMs, cancellationToken);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// GREEDY ASSIGNMENT: Assign each Spotify track to its best unique match
|
|
||||||
var usedSongIds = new HashSet<string>();
|
|
||||||
var assignments = new Dictionary<string, (Song Song, double Score, string MatchType)>();
|
|
||||||
|
|
||||||
// Sort candidates by score (highest first)
|
|
||||||
var sortedCandidates = allCandidates
|
|
||||||
.OrderByDescending(c => c.Score)
|
|
||||||
.ToList();
|
|
||||||
|
|
||||||
foreach (var (spotifyTrack, song, score, matchType) in sortedCandidates)
|
|
||||||
{
|
|
||||||
// Skip if this Spotify track already has a match
|
|
||||||
if (assignments.ContainsKey(spotifyTrack.SpotifyId))
|
|
||||||
continue;
|
|
||||||
|
|
||||||
// Skip if this song is already used
|
|
||||||
if (usedSongIds.Contains(song.Id))
|
|
||||||
continue;
|
|
||||||
|
|
||||||
// Assign this match
|
|
||||||
assignments[spotifyTrack.SpotifyId] = (song, score, matchType);
|
|
||||||
usedSongIds.Add(song.Id);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Build final matched tracks list
|
|
||||||
foreach (var spotifyTrack in orderedTracks)
|
|
||||||
{
|
|
||||||
if (assignments.TryGetValue(spotifyTrack.SpotifyId, out var match))
|
|
||||||
{
|
{
|
||||||
var matched = new MatchedTrack
|
var matched = new MatchedTrack
|
||||||
{
|
{
|
||||||
@@ -474,24 +418,54 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
SpotifyTitle = spotifyTrack.Title,
|
SpotifyTitle = spotifyTrack.Title,
|
||||||
SpotifyArtist = spotifyTrack.PrimaryArtist,
|
SpotifyArtist = spotifyTrack.PrimaryArtist,
|
||||||
Isrc = spotifyTrack.Isrc,
|
Isrc = spotifyTrack.Isrc,
|
||||||
MatchType = match.MatchType,
|
MatchType = matchType,
|
||||||
MatchedSong = match.Song
|
MatchedSong = matchedSong
|
||||||
};
|
};
|
||||||
|
|
||||||
matchedTracks.Add(matched);
|
_logger.LogDebug(" #{Position} {Title} - {Artist} → {MatchType} match: {MatchedTitle}",
|
||||||
|
|
||||||
if (match.MatchType == "isrc") isrcMatches++;
|
|
||||||
else if (match.MatchType == "fuzzy") fuzzyMatches++;
|
|
||||||
|
|
||||||
_logger.LogDebug(" #{Position} {Title} - {Artist} → {MatchType} match (score: {Score:F1}): {MatchedTitle}",
|
|
||||||
spotifyTrack.Position, spotifyTrack.Title, spotifyTrack.PrimaryArtist,
|
spotifyTrack.Position, spotifyTrack.Title, spotifyTrack.PrimaryArtist,
|
||||||
match.MatchType, match.Score, match.Song.Title);
|
matchType, matchedSong.Title);
|
||||||
|
|
||||||
|
return ((MatchedTrack?)matched, matchType);
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
_logger.LogDebug(" #{Position} {Title} - {Artist} → no match",
|
||||||
|
spotifyTrack.Position, spotifyTrack.Title, spotifyTrack.PrimaryArtist);
|
||||||
|
return ((MatchedTrack?)null, "none");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogDebug(ex, "Failed to match track: {Title} - {Artist}",
|
||||||
|
spotifyTrack.Title, spotifyTrack.PrimaryArtist);
|
||||||
|
return ((MatchedTrack?)null, "none");
|
||||||
|
}
|
||||||
|
}).ToList();
|
||||||
|
|
||||||
|
// Wait for all tracks in this batch to complete
|
||||||
|
var batchResults = await Task.WhenAll(batchTasks);
|
||||||
|
|
||||||
|
// Collect results
|
||||||
|
foreach (var result in batchResults)
|
||||||
|
{
|
||||||
|
var (matched, matchType) = result;
|
||||||
|
if (matched != null)
|
||||||
|
{
|
||||||
|
matchedTracks.Add(matched);
|
||||||
|
if (matchType == "isrc") isrcMatches++;
|
||||||
|
else if (matchType == "fuzzy") fuzzyMatches++;
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
noMatch++;
|
noMatch++;
|
||||||
_logger.LogDebug(" #{Position} {Title} - {Artist} → no match",
|
}
|
||||||
spotifyTrack.Position, spotifyTrack.Title, spotifyTrack.PrimaryArtist);
|
}
|
||||||
|
|
||||||
|
// Rate limiting between batches (not between individual tracks)
|
||||||
|
if (i + BatchSize < orderedTracks.Count)
|
||||||
|
{
|
||||||
|
await Task.Delay(DelayBetweenSearchesMs, cancellationToken);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -509,11 +483,10 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
await _cache.SetAsync(legacyKey, legacySongs, TimeSpan.FromHours(1));
|
await _cache.SetAsync(legacyKey, legacySongs, TimeSpan.FromHours(1));
|
||||||
|
|
||||||
_logger.LogInformation(
|
_logger.LogInformation(
|
||||||
"✓ Cached {Matched}/{Total} tracks for {Playlist} via GREEDY ASSIGNMENT (ISRC: {Isrc}, Fuzzy: {Fuzzy}, No match: {NoMatch}) - manual mappings will be applied next",
|
"✓ Cached {Matched}/{Total} tracks for {Playlist} via search (ISRC: {Isrc}, Fuzzy: {Fuzzy}, No match: {NoMatch}) - manual mappings will be applied next",
|
||||||
matchedTracks.Count, tracksToMatch.Count, playlistName, isrcMatches, fuzzyMatches, noMatch);
|
matchedTracks.Count, tracksToMatch.Count, playlistName, isrcMatches, fuzzyMatches, noMatch);
|
||||||
|
|
||||||
// Pre-build playlist items cache for instant serving
|
// Pre-build playlist items cache for instant serving
|
||||||
// This is what makes the UI show all matched tracks at once
|
|
||||||
await PreBuildPlaylistItemsCacheAsync(playlistName, playlistConfig?.JellyfinId, spotifyTracks, matchedTracks, cancellationToken);
|
await PreBuildPlaylistItemsCacheAsync(playlistName, playlistConfig?.JellyfinId, spotifyTracks, matchedTracks, cancellationToken);
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
@@ -522,64 +495,6 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Returns multiple candidate matches with scores for greedy assignment.
|
|
||||||
/// FOLLOWS OPTIMAL ORDER:
|
|
||||||
/// 1. Strip decorators (done in FuzzyMatcher)
|
|
||||||
/// 2. Substring matching (done in FuzzyMatcher)
|
|
||||||
/// 3. Levenshtein distance (done in FuzzyMatcher)
|
|
||||||
/// This method just collects candidates; greedy assignment happens later.
|
|
||||||
/// </summary>
|
|
||||||
private async Task<List<(Song Song, double Score)>> TryMatchByFuzzyMultipleAsync(
|
|
||||||
string title,
|
|
||||||
List<string> artists,
|
|
||||||
IMusicMetadataService metadataService)
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var primaryArtist = artists.FirstOrDefault() ?? "";
|
|
||||||
|
|
||||||
// STEP 1: Strip decorators FIRST (before searching)
|
|
||||||
var titleStripped = FuzzyMatcher.StripDecorators(title);
|
|
||||||
var query = $"{titleStripped} {primaryArtist}";
|
|
||||||
|
|
||||||
var results = await metadataService.SearchSongsAsync(query, limit: 10);
|
|
||||||
|
|
||||||
if (results.Count == 0) return new List<(Song, double)>();
|
|
||||||
|
|
||||||
// STEP 2-3: Score all results (substring + Levenshtein already in CalculateSimilarityAggressive)
|
|
||||||
var scoredResults = results
|
|
||||||
.Select(song => new
|
|
||||||
{
|
|
||||||
Song = song,
|
|
||||||
// Use aggressive matching which follows optimal order internally
|
|
||||||
TitleScore = FuzzyMatcher.CalculateSimilarityAggressive(title, song.Title),
|
|
||||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(artists, song.Artist, song.Contributors)
|
|
||||||
})
|
|
||||||
.Select(x => new
|
|
||||||
{
|
|
||||||
x.Song,
|
|
||||||
x.TitleScore,
|
|
||||||
x.ArtistScore,
|
|
||||||
// Weight: 70% title, 30% artist (prioritize title matching)
|
|
||||||
TotalScore = (x.TitleScore * 0.7) + (x.ArtistScore * 0.3)
|
|
||||||
})
|
|
||||||
.Where(x =>
|
|
||||||
x.TotalScore >= 40 ||
|
|
||||||
(x.ArtistScore >= 70 && x.TitleScore >= 30) ||
|
|
||||||
x.TitleScore >= 85)
|
|
||||||
.OrderByDescending(x => x.TotalScore)
|
|
||||||
.Select(x => (x.Song, x.TotalScore))
|
|
||||||
.ToList();
|
|
||||||
|
|
||||||
return scoredResults;
|
|
||||||
}
|
|
||||||
catch
|
|
||||||
{
|
|
||||||
return new List<(Song, double)>();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Attempts to match a track by ISRC using provider search.
|
/// Attempts to match a track by ISRC using provider search.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
@@ -609,12 +524,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Attempts to match a track by title and artist using AGGRESSIVE fuzzy matching.
|
/// Attempts to match a track by title and artist using fuzzy matching.
|
||||||
/// FOLLOWS OPTIMAL ORDER:
|
|
||||||
/// 1. Strip decorators FIRST (before searching)
|
|
||||||
/// 2. Substring matching (in FuzzyMatcher)
|
|
||||||
/// 3. Levenshtein distance (in FuzzyMatcher)
|
|
||||||
/// PRIORITY: Match as many tracks as possible, even with lower confidence.
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
private async Task<Song?> TryMatchByFuzzyAsync(
|
private async Task<Song?> TryMatchByFuzzyAsync(
|
||||||
string title,
|
string title,
|
||||||
@@ -624,62 +534,30 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
try
|
try
|
||||||
{
|
{
|
||||||
var primaryArtist = artists.FirstOrDefault() ?? "";
|
var primaryArtist = artists.FirstOrDefault() ?? "";
|
||||||
|
var query = $"{title} {primaryArtist}";
|
||||||
// STEP 1: Strip decorators FIRST (before searching)
|
var results = await metadataService.SearchSongsAsync(query, limit: 5);
|
||||||
var titleStripped = FuzzyMatcher.StripDecorators(title);
|
|
||||||
var query = $"{titleStripped} {primaryArtist}";
|
|
||||||
|
|
||||||
var results = await metadataService.SearchSongsAsync(query, limit: 10);
|
|
||||||
|
|
||||||
if (results.Count == 0) return null;
|
if (results.Count == 0) return null;
|
||||||
|
|
||||||
// STEP 2-3: Score all results (substring + Levenshtein in CalculateSimilarityAggressive)
|
var bestMatch = results
|
||||||
var scoredResults = results
|
|
||||||
.Select(song => new
|
.Select(song => new
|
||||||
{
|
{
|
||||||
Song = song,
|
Song = song,
|
||||||
// Use aggressive matching which follows optimal order internally
|
TitleScore = FuzzyMatcher.CalculateSimilarity(title, song.Title),
|
||||||
TitleScore = FuzzyMatcher.CalculateSimilarityAggressive(title, song.Title),
|
ArtistScore = CalculateArtistMatchScore(artists, song.Artist, song.Contributors)
|
||||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(artists, song.Artist, song.Contributors)
|
|
||||||
})
|
})
|
||||||
.Select(x => new
|
.Select(x => new
|
||||||
{
|
{
|
||||||
x.Song,
|
x.Song,
|
||||||
x.TitleScore,
|
x.TitleScore,
|
||||||
x.ArtistScore,
|
x.ArtistScore,
|
||||||
// Weight: 70% title, 30% artist (prioritize title matching)
|
TotalScore = (x.TitleScore * 0.6) + (x.ArtistScore * 0.4)
|
||||||
TotalScore = (x.TitleScore * 0.7) + (x.ArtistScore * 0.3)
|
|
||||||
})
|
})
|
||||||
.OrderByDescending(x => x.TotalScore)
|
.OrderByDescending(x => x.TotalScore)
|
||||||
.ToList();
|
.FirstOrDefault();
|
||||||
|
|
||||||
var bestMatch = scoredResults.FirstOrDefault();
|
if (bestMatch != null && bestMatch.TotalScore >= 60)
|
||||||
|
|
||||||
if (bestMatch == null) return null;
|
|
||||||
|
|
||||||
// AGGRESSIVE: Accept matches with score >= 40 (was 50)
|
|
||||||
if (bestMatch.TotalScore >= 40)
|
|
||||||
{
|
{
|
||||||
_logger.LogDebug("✓ Matched (score: {Score:F1}, title: {TitleScore}, artist: {ArtistScore}): {SpotifyTitle} → {MatchedTitle}",
|
|
||||||
bestMatch.TotalScore, bestMatch.TitleScore, bestMatch.ArtistScore, title, bestMatch.Song.Title);
|
|
||||||
return bestMatch.Song;
|
|
||||||
}
|
|
||||||
|
|
||||||
// SUPER AGGRESSIVE: If artist matches well (70+), accept even lower title scores
|
|
||||||
// This handles cases like "a" → "a-blah" where artist is the same
|
|
||||||
if (bestMatch.ArtistScore >= 70 && bestMatch.TitleScore >= 30)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Matched via artist priority (artist: {ArtistScore}, title: {TitleScore}): {SpotifyTitle} → {MatchedTitle}",
|
|
||||||
bestMatch.ArtistScore, bestMatch.TitleScore, title, bestMatch.Song.Title);
|
|
||||||
return bestMatch.Song;
|
|
||||||
}
|
|
||||||
|
|
||||||
// ULTRA AGGRESSIVE: If title has high substring match (85+), accept it
|
|
||||||
// This handles "luther" → "luther (feat. sza)"
|
|
||||||
if (bestMatch.TitleScore >= 85)
|
|
||||||
{
|
|
||||||
_logger.LogDebug("✓ Matched via substring (title: {TitleScore}): {SpotifyTitle} → {MatchedTitle}",
|
|
||||||
bestMatch.TitleScore, title, bestMatch.Song.Title);
|
|
||||||
return bestMatch.Song;
|
return bestMatch.Song;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -744,7 +622,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
Song = song,
|
Song = song,
|
||||||
TitleScore = FuzzyMatcher.CalculateSimilarity(track.Title, song.Title),
|
TitleScore = FuzzyMatcher.CalculateSimilarity(track.Title, song.Title),
|
||||||
// Calculate artist score by checking ALL artists match
|
// Calculate artist score by checking ALL artists match
|
||||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(track.Artists, song.Artist, song.Contributors)
|
ArtistScore = CalculateArtistMatchScore(track.Artists, song.Artist, song.Contributors)
|
||||||
})
|
})
|
||||||
.Select(x => new
|
.Select(x => new
|
||||||
{
|
{
|
||||||
@@ -927,69 +805,50 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
var usedJellyfinItems = new HashSet<string>();
|
var usedJellyfinItems = new HashSet<string>();
|
||||||
var localUsedCount = 0;
|
var localUsedCount = 0;
|
||||||
var externalUsedCount = 0;
|
var externalUsedCount = 0;
|
||||||
|
var manualLocalCount = 0;
|
||||||
var manualExternalCount = 0;
|
var manualExternalCount = 0;
|
||||||
|
|
||||||
foreach (var spotifyTrack in spotifyTracks.OrderBy(t => t.Position))
|
foreach (var spotifyTrack in spotifyTracks.OrderBy(t => t.Position))
|
||||||
{
|
{
|
||||||
if (cancellationToken.IsCancellationRequested) break;
|
if (cancellationToken.IsCancellationRequested) break;
|
||||||
|
|
||||||
JsonElement? matchedJellyfinItem = null;
|
// FIRST: Check for manual mapping
|
||||||
string? matchedKey = null;
|
|
||||||
|
|
||||||
// FIRST: Check for manual Jellyfin mapping
|
|
||||||
var manualMappingKey = $"spotify:manual-map:{playlistName}:{spotifyTrack.SpotifyId}";
|
var manualMappingKey = $"spotify:manual-map:{playlistName}:{spotifyTrack.SpotifyId}";
|
||||||
var manualJellyfinId = await _cache.GetAsync<string>(manualMappingKey);
|
var manualJellyfinId = await _cache.GetAsync<string>(manualMappingKey);
|
||||||
|
|
||||||
|
JsonElement? matchedJellyfinItem = null;
|
||||||
|
string? matchedKey = null;
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(manualJellyfinId))
|
if (!string.IsNullOrEmpty(manualJellyfinId))
|
||||||
{
|
{
|
||||||
// Find the Jellyfin item by ID
|
// Manual Jellyfin mapping exists - fetch the Jellyfin item by ID
|
||||||
foreach (var kvp in jellyfinItemsByName)
|
try
|
||||||
{
|
{
|
||||||
var item = kvp.Value;
|
var itemUrl = $"Items/{manualJellyfinId}?UserId={userId}";
|
||||||
if (item.TryGetProperty("Id", out var idEl) && idEl.GetString() == manualJellyfinId)
|
var (itemResponse, itemStatusCode) = await proxyService.GetJsonAsync(itemUrl, null, headers);
|
||||||
|
|
||||||
|
if (itemStatusCode == 200 && itemResponse != null)
|
||||||
{
|
{
|
||||||
matchedJellyfinItem = item;
|
matchedJellyfinItem = itemResponse.RootElement;
|
||||||
matchedKey = kvp.Key;
|
manualLocalCount++;
|
||||||
_logger.LogInformation("✓ Using manual Jellyfin mapping for {Title}: Jellyfin ID {Id}",
|
_logger.LogDebug("✓ Using manual Jellyfin mapping for {Title}: Jellyfin ID {Id}",
|
||||||
spotifyTrack.Title, manualJellyfinId);
|
spotifyTrack.Title, manualJellyfinId);
|
||||||
break;
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
_logger.LogWarning("Manual Jellyfin mapping points to invalid Jellyfin ID {Id} for {Title}",
|
||||||
|
manualJellyfinId, spotifyTrack.Title);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogWarning(ex, "Failed to fetch manually mapped Jellyfin item {Id}", manualJellyfinId);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (matchedJellyfinItem.HasValue)
|
// Check for external manual mapping if no Jellyfin mapping found
|
||||||
|
if (!matchedJellyfinItem.HasValue)
|
||||||
{
|
{
|
||||||
// Use the raw Jellyfin item (preserves ALL metadata)
|
|
||||||
var itemDict = JsonSerializer.Deserialize<Dictionary<string, object?>>(matchedJellyfinItem.Value.GetRawText());
|
|
||||||
if (itemDict != null)
|
|
||||||
{
|
|
||||||
// Add Spotify ID to ProviderIds so lyrics can work for local tracks too
|
|
||||||
if (!string.IsNullOrEmpty(spotifyTrack.SpotifyId))
|
|
||||||
{
|
|
||||||
if (!itemDict.ContainsKey("ProviderIds"))
|
|
||||||
{
|
|
||||||
itemDict["ProviderIds"] = new Dictionary<string, string>();
|
|
||||||
}
|
|
||||||
|
|
||||||
var providerIds = itemDict["ProviderIds"] as Dictionary<string, string>;
|
|
||||||
if (providerIds != null && !providerIds.ContainsKey("Spotify"))
|
|
||||||
{
|
|
||||||
providerIds["Spotify"] = spotifyTrack.SpotifyId;
|
|
||||||
_logger.LogDebug("Added Spotify ID {SpotifyId} to local track for lyrics support", spotifyTrack.SpotifyId);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
finalItems.Add(itemDict);
|
|
||||||
if (matchedKey != null)
|
|
||||||
{
|
|
||||||
usedJellyfinItems.Add(matchedKey);
|
|
||||||
}
|
|
||||||
localUsedCount++;
|
|
||||||
}
|
|
||||||
continue; // Skip to next track
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// SECOND: Check for external manual mapping
|
|
||||||
var externalMappingKey = $"spotify:external-map:{playlistName}:{spotifyTrack.SpotifyId}";
|
var externalMappingKey = $"spotify:external-map:{playlistName}:{spotifyTrack.SpotifyId}";
|
||||||
var externalMappingJson = await _cache.GetStringAsync(externalMappingKey);
|
var externalMappingJson = await _cache.GetStringAsync(externalMappingKey);
|
||||||
|
|
||||||
@@ -1069,22 +928,6 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
|
|
||||||
// Convert external song to Jellyfin item format and add to finalItems
|
// Convert external song to Jellyfin item format and add to finalItems
|
||||||
var externalItem = responseBuilder.ConvertSongToJellyfinItem(externalSong);
|
var externalItem = responseBuilder.ConvertSongToJellyfinItem(externalSong);
|
||||||
|
|
||||||
// Add Spotify ID to ProviderIds so lyrics can work
|
|
||||||
if (!string.IsNullOrEmpty(spotifyTrack.SpotifyId))
|
|
||||||
{
|
|
||||||
if (!externalItem.ContainsKey("ProviderIds"))
|
|
||||||
{
|
|
||||||
externalItem["ProviderIds"] = new Dictionary<string, string>();
|
|
||||||
}
|
|
||||||
|
|
||||||
var providerIds = externalItem["ProviderIds"] as Dictionary<string, string>;
|
|
||||||
if (providerIds != null && !providerIds.ContainsKey("Spotify"))
|
|
||||||
{
|
|
||||||
providerIds["Spotify"] = spotifyTrack.SpotifyId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
finalItems.Add(externalItem);
|
finalItems.Add(externalItem);
|
||||||
externalUsedCount++;
|
externalUsedCount++;
|
||||||
manualExternalCount++;
|
manualExternalCount++;
|
||||||
@@ -1099,8 +942,11 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
_logger.LogWarning(ex, "Failed to process external manual mapping for {Title}", spotifyTrack.Title);
|
_logger.LogWarning(ex, "Failed to process external manual mapping for {Title}", spotifyTrack.Title);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// If no manual external mapping, try AGGRESSIVE fuzzy matching with local Jellyfin tracks
|
// SECOND: If no manual mapping, try fuzzy matching
|
||||||
|
if (!matchedJellyfinItem.HasValue)
|
||||||
|
{
|
||||||
double bestScore = 0;
|
double bestScore = 0;
|
||||||
|
|
||||||
foreach (var kvp in jellyfinItemsByName)
|
foreach (var kvp in jellyfinItemsByName)
|
||||||
@@ -1115,24 +961,18 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
artist = artistsEl[0].GetString() ?? "";
|
artist = artistsEl[0].GetString() ?? "";
|
||||||
}
|
}
|
||||||
|
|
||||||
// Use AGGRESSIVE matching with decorator stripping
|
var titleScore = FuzzyMatcher.CalculateSimilarity(spotifyTrack.Title, title);
|
||||||
var titleScore = FuzzyMatcher.CalculateSimilarityAggressive(spotifyTrack.Title, title);
|
|
||||||
var artistScore = FuzzyMatcher.CalculateSimilarity(spotifyTrack.PrimaryArtist, artist);
|
var artistScore = FuzzyMatcher.CalculateSimilarity(spotifyTrack.PrimaryArtist, artist);
|
||||||
|
|
||||||
// Weight: 70% title, 30% artist (prioritize title matching)
|
|
||||||
var totalScore = (titleScore * 0.7) + (artistScore * 0.3);
|
var totalScore = (titleScore * 0.7) + (artistScore * 0.3);
|
||||||
|
|
||||||
// AGGRESSIVE: Accept score >= 40 (was 70)
|
if (totalScore > bestScore && totalScore >= 70)
|
||||||
// Also accept if artist matches well (70+) and title is decent (30+)
|
|
||||||
var isGoodMatch = totalScore >= 40 || (artistScore >= 70 && titleScore >= 30);
|
|
||||||
|
|
||||||
if (totalScore > bestScore && isGoodMatch)
|
|
||||||
{
|
{
|
||||||
bestScore = totalScore;
|
bestScore = totalScore;
|
||||||
matchedJellyfinItem = item;
|
matchedJellyfinItem = item;
|
||||||
matchedKey = kvp.Key;
|
matchedKey = kvp.Key;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if (matchedJellyfinItem.HasValue)
|
if (matchedJellyfinItem.HasValue)
|
||||||
{
|
{
|
||||||
@@ -1140,22 +980,6 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
var itemDict = JsonSerializer.Deserialize<Dictionary<string, object?>>(matchedJellyfinItem.Value.GetRawText());
|
var itemDict = JsonSerializer.Deserialize<Dictionary<string, object?>>(matchedJellyfinItem.Value.GetRawText());
|
||||||
if (itemDict != null)
|
if (itemDict != null)
|
||||||
{
|
{
|
||||||
// Add Spotify ID to ProviderIds so lyrics can work for fuzzy-matched local tracks too
|
|
||||||
if (!string.IsNullOrEmpty(spotifyTrack.SpotifyId))
|
|
||||||
{
|
|
||||||
if (!itemDict.ContainsKey("ProviderIds"))
|
|
||||||
{
|
|
||||||
itemDict["ProviderIds"] = new Dictionary<string, string>();
|
|
||||||
}
|
|
||||||
|
|
||||||
var providerIds = itemDict["ProviderIds"] as Dictionary<string, string>;
|
|
||||||
if (providerIds != null && !providerIds.ContainsKey("Spotify"))
|
|
||||||
{
|
|
||||||
providerIds["Spotify"] = spotifyTrack.SpotifyId;
|
|
||||||
_logger.LogDebug("Added Spotify ID {SpotifyId} to fuzzy-matched local track for lyrics support", spotifyTrack.SpotifyId);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
finalItems.Add(itemDict);
|
finalItems.Add(itemDict);
|
||||||
if (matchedKey != null)
|
if (matchedKey != null)
|
||||||
{
|
{
|
||||||
@@ -1172,22 +996,6 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
{
|
{
|
||||||
// Convert external song to Jellyfin item format
|
// Convert external song to Jellyfin item format
|
||||||
var externalItem = responseBuilder.ConvertSongToJellyfinItem(matched.MatchedSong);
|
var externalItem = responseBuilder.ConvertSongToJellyfinItem(matched.MatchedSong);
|
||||||
|
|
||||||
// Add Spotify ID to ProviderIds so lyrics can work
|
|
||||||
if (!string.IsNullOrEmpty(spotifyTrack.SpotifyId))
|
|
||||||
{
|
|
||||||
if (!externalItem.ContainsKey("ProviderIds"))
|
|
||||||
{
|
|
||||||
externalItem["ProviderIds"] = new Dictionary<string, string>();
|
|
||||||
}
|
|
||||||
|
|
||||||
var providerIds = externalItem["ProviderIds"] as Dictionary<string, string>;
|
|
||||||
if (providerIds != null && !providerIds.ContainsKey("Spotify"))
|
|
||||||
{
|
|
||||||
providerIds["Spotify"] = spotifyTrack.SpotifyId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
finalItems.Add(externalItem);
|
finalItems.Add(externalItem);
|
||||||
externalUsedCount++;
|
externalUsedCount++;
|
||||||
}
|
}
|
||||||
@@ -1204,9 +1012,9 @@ public class SpotifyTrackMatchingService : BackgroundService
|
|||||||
await SavePlaylistItemsToFileAsync(playlistName, finalItems);
|
await SavePlaylistItemsToFileAsync(playlistName, finalItems);
|
||||||
|
|
||||||
var manualMappingInfo = "";
|
var manualMappingInfo = "";
|
||||||
if (manualExternalCount > 0)
|
if (manualLocalCount > 0 || manualExternalCount > 0)
|
||||||
{
|
{
|
||||||
manualMappingInfo = $" [Manual external: {manualExternalCount}]";
|
manualMappingInfo = $" [Manual: {manualLocalCount} local, {manualExternalCount} external]";
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogInformation(
|
_logger.LogInformation(
|
||||||
|
|||||||
@@ -7,7 +7,6 @@ using allstarr.Models.Search;
|
|||||||
using allstarr.Models.Subsonic;
|
using allstarr.Models.Subsonic;
|
||||||
using allstarr.Services.Local;
|
using allstarr.Services.Local;
|
||||||
using allstarr.Services.Common;
|
using allstarr.Services.Common;
|
||||||
using allstarr.Services.Lyrics;
|
|
||||||
using Microsoft.Extensions.Options;
|
using Microsoft.Extensions.Options;
|
||||||
using IOFile = System.IO.File;
|
using IOFile = System.IO.File;
|
||||||
using Microsoft.Extensions.Logging;
|
using Microsoft.Extensions.Logging;
|
||||||
@@ -15,48 +14,21 @@ using Microsoft.Extensions.Logging;
|
|||||||
namespace allstarr.Services.SquidWTF;
|
namespace allstarr.Services.SquidWTF;
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Handles track downloading from tidal.squid.wtf (no encryption, no auth required).
|
/// Handles track downloading from tidal.squid.wtf (no encryption, no auth required)
|
||||||
///
|
/// Downloads are direct from Tidal's CDN via the squid.wtf proxy
|
||||||
/// Downloads are direct from Tidal's CDN via the squid.wtf proxy. The service:
|
|
||||||
/// 1. Fetches download info from hifi-api /track/ endpoint
|
|
||||||
/// 2. Decodes base64 manifest to get actual Tidal CDN URL
|
|
||||||
/// 3. Downloads directly from Tidal CDN (no decryption needed)
|
|
||||||
/// 4. Converts Tidal track ID to Spotify ID in parallel (for lyrics matching)
|
|
||||||
/// 5. Writes ID3/FLAC metadata tags and embeds cover art
|
|
||||||
///
|
|
||||||
/// Per hifi-api spec, the /track/ endpoint returns:
|
|
||||||
/// { "version": "2.0", "data": {
|
|
||||||
/// trackId, assetPresentation, audioMode, audioQuality,
|
|
||||||
/// manifestMimeType: "application/vnd.tidal.bts",
|
|
||||||
/// manifest: "base64-encoded-json",
|
|
||||||
/// albumReplayGain, trackReplayGain, bitDepth, sampleRate
|
|
||||||
/// }}
|
|
||||||
///
|
|
||||||
/// The manifest decodes to:
|
|
||||||
/// { "mimeType": "audio/flac", "codecs": "flac", "encryptionType": "NONE",
|
|
||||||
/// "urls": ["https://lgf.audio.tidal.com/mediatracks/..."] }
|
|
||||||
///
|
|
||||||
/// Quality Mapping:
|
|
||||||
/// - HI_RES → HI_RES_LOSSLESS (24-bit/192kHz FLAC)
|
|
||||||
/// - FLAC/LOSSLESS → LOSSLESS (16-bit/44.1kHz FLAC)
|
|
||||||
/// - HIGH → HIGH (320kbps AAC)
|
|
||||||
/// - LOW → LOW (96kbps AAC)
|
|
||||||
///
|
|
||||||
/// Features:
|
|
||||||
/// - Racing multiple endpoints for fastest download
|
|
||||||
/// - Automatic failover to backup endpoints
|
|
||||||
/// - Parallel Spotify ID conversion via Odesli
|
|
||||||
/// - Organized folder structure: Artist/Album/Track
|
|
||||||
/// - Unique filename resolution for duplicates
|
|
||||||
/// - Support for both cache and permanent storage modes
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public class SquidWTFDownloadService : BaseDownloadService
|
public class SquidWTFDownloadService : BaseDownloadService
|
||||||
{
|
{
|
||||||
private readonly HttpClient _httpClient;
|
private readonly HttpClient _httpClient;
|
||||||
|
private readonly SemaphoreSlim _requestLock = new(1, 1);
|
||||||
private readonly SquidWTFSettings _squidwtfSettings;
|
private readonly SquidWTFSettings _squidwtfSettings;
|
||||||
private readonly OdesliService _odesliService;
|
|
||||||
private readonly RoundRobinFallbackHelper _fallbackHelper;
|
private DateTime _lastRequestTime = DateTime.MinValue;
|
||||||
private readonly IServiceProvider _serviceProvider;
|
private readonly int _minRequestIntervalMs = 200;
|
||||||
|
|
||||||
|
private readonly List<string> _apiUrls;
|
||||||
|
private int _currentUrlIndex = 0;
|
||||||
|
private readonly object _urlIndexLock = new object();
|
||||||
|
|
||||||
protected override string ProviderName => "squidwtf";
|
protected override string ProviderName => "squidwtf";
|
||||||
|
|
||||||
@@ -69,26 +41,59 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
IOptions<SquidWTFSettings> SquidWTFSettings,
|
IOptions<SquidWTFSettings> SquidWTFSettings,
|
||||||
IServiceProvider serviceProvider,
|
IServiceProvider serviceProvider,
|
||||||
ILogger<SquidWTFDownloadService> logger,
|
ILogger<SquidWTFDownloadService> logger,
|
||||||
OdesliService odesliService,
|
|
||||||
List<string> apiUrls)
|
List<string> apiUrls)
|
||||||
: base(configuration, localLibraryService, metadataService, subsonicSettings.Value, serviceProvider, logger)
|
: base(configuration, localLibraryService, metadataService, subsonicSettings.Value, serviceProvider, logger)
|
||||||
{
|
{
|
||||||
_httpClient = httpClientFactory.CreateClient();
|
_httpClient = httpClientFactory.CreateClient();
|
||||||
_squidwtfSettings = SquidWTFSettings.Value;
|
_squidwtfSettings = SquidWTFSettings.Value;
|
||||||
_odesliService = odesliService;
|
_apiUrls = apiUrls;
|
||||||
_fallbackHelper = new RoundRobinFallbackHelper(apiUrls, logger, "SquidWTF");
|
|
||||||
_serviceProvider = serviceProvider;
|
|
||||||
|
|
||||||
// Increase timeout for large downloads and slow endpoints
|
|
||||||
_httpClient.Timeout = TimeSpan.FromMinutes(5);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Tries the request with the next provider in round-robin, then falls back to others on failure.
|
||||||
|
/// This distributes load evenly across all providers while maintaining reliability.
|
||||||
|
/// </summary>
|
||||||
|
private async Task<T> TryWithFallbackAsync<T>(Func<string, Task<T>> action)
|
||||||
|
{
|
||||||
|
// Start with the next URL in round-robin to distribute load
|
||||||
|
var startIndex = 0;
|
||||||
|
lock (_urlIndexLock)
|
||||||
|
{
|
||||||
|
startIndex = _currentUrlIndex;
|
||||||
|
_currentUrlIndex = (_currentUrlIndex + 1) % _apiUrls.Count;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Try all URLs starting from the round-robin selected one
|
||||||
|
for (int attempt = 0; attempt < _apiUrls.Count; attempt++)
|
||||||
|
{
|
||||||
|
var urlIndex = (startIndex + attempt) % _apiUrls.Count;
|
||||||
|
var baseUrl = _apiUrls[urlIndex];
|
||||||
|
|
||||||
|
try
|
||||||
|
{
|
||||||
|
Logger.LogDebug("Trying endpoint {Endpoint} (attempt {Attempt}/{Total})",
|
||||||
|
baseUrl, attempt + 1, _apiUrls.Count);
|
||||||
|
return await action(baseUrl);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
Logger.LogWarning(ex, "Request failed with endpoint {Endpoint}, trying next...", baseUrl);
|
||||||
|
|
||||||
|
if (attempt == _apiUrls.Count - 1)
|
||||||
|
{
|
||||||
|
Logger.LogError("All {Count} SquidWTF endpoints failed", _apiUrls.Count);
|
||||||
|
throw;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
throw new Exception("All SquidWTF endpoints failed");
|
||||||
|
}
|
||||||
|
|
||||||
#region BaseDownloadService Implementation
|
#region BaseDownloadService Implementation
|
||||||
|
|
||||||
public override async Task<bool> IsAvailableAsync()
|
public override async Task<bool> IsAvailableAsync()
|
||||||
{
|
{
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
var response = await _httpClient.GetAsync(baseUrl);
|
var response = await _httpClient.GetAsync(baseUrl);
|
||||||
Console.WriteLine($"Response code from is available async: {response.IsSuccessStatusCode}");
|
Console.WriteLine($"Response code from is available async: {response.IsSuccessStatusCode}");
|
||||||
@@ -111,8 +116,8 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
{
|
{
|
||||||
var downloadInfo = await GetTrackDownloadInfoAsync(trackId, cancellationToken);
|
var downloadInfo = await GetTrackDownloadInfoAsync(trackId, cancellationToken);
|
||||||
|
|
||||||
Logger.LogInformation("Track download URL obtained from hifi-api: {Url}", downloadInfo.DownloadUrl);
|
Logger.LogInformation("Track token obtained: {Url}", downloadInfo.DownloadUrl);
|
||||||
Logger.LogInformation("Using format: {Format} (Quality: {Quality})", downloadInfo.MimeType, downloadInfo.AudioQuality);
|
Logger.LogInformation("Using format: {Format}", downloadInfo.MimeType);
|
||||||
|
|
||||||
// Determine extension from MIME type
|
// Determine extension from MIME type
|
||||||
var extension = downloadInfo.MimeType?.ToLower() switch
|
var extension = downloadInfo.MimeType?.ToLower() switch
|
||||||
@@ -125,10 +130,7 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
|
|
||||||
// Build organized folder structure: Artist/Album/Track using AlbumArtist (fallback to Artist for singles)
|
// Build organized folder structure: Artist/Album/Track using AlbumArtist (fallback to Artist for singles)
|
||||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||||
// Cache mode uses downloads/cache/ folder, Permanent mode uses downloads/permanent/
|
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache ? CachePath : DownloadPath;
|
||||||
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache
|
|
||||||
? Path.Combine("downloads", "cache")
|
|
||||||
: Path.Combine("downloads", "permanent");
|
|
||||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension);
|
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension);
|
||||||
|
|
||||||
// Create directories if they don't exist
|
// Create directories if they don't exist
|
||||||
@@ -138,53 +140,10 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
// Resolve unique path if file already exists
|
// Resolve unique path if file already exists
|
||||||
outputPath = PathHelper.ResolveUniquePath(outputPath);
|
outputPath = PathHelper.ResolveUniquePath(outputPath);
|
||||||
|
|
||||||
// Use round-robin with fallback for downloads to reduce CPU usage
|
// Download from Tidal CDN (no authentication needed, token is in URL)
|
||||||
Logger.LogDebug("Using round-robin endpoint selection for download");
|
var response = await QueueRequestAsync(async () =>
|
||||||
|
|
||||||
var response = await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
|
||||||
{
|
{
|
||||||
// Map quality settings to Tidal's quality levels per hifi-api spec
|
using var request = new HttpRequestMessage(HttpMethod.Get, downloadInfo.DownloadUrl);
|
||||||
var quality = _squidwtfSettings.Quality?.ToUpperInvariant() switch
|
|
||||||
{
|
|
||||||
"FLAC" => "LOSSLESS",
|
|
||||||
"HI_RES" => "HI_RES_LOSSLESS",
|
|
||||||
"LOSSLESS" => "LOSSLESS",
|
|
||||||
"HIGH" => "HIGH",
|
|
||||||
"LOW" => "LOW",
|
|
||||||
_ => "LOSSLESS"
|
|
||||||
};
|
|
||||||
|
|
||||||
var url = $"{baseUrl}/track/?id={trackId}&quality={quality}";
|
|
||||||
|
|
||||||
// Get download info from this endpoint
|
|
||||||
var infoResponse = await _httpClient.GetAsync(url, cancellationToken);
|
|
||||||
infoResponse.EnsureSuccessStatusCode();
|
|
||||||
|
|
||||||
var json = await infoResponse.Content.ReadAsStringAsync(cancellationToken);
|
|
||||||
var doc = JsonDocument.Parse(json);
|
|
||||||
|
|
||||||
if (!doc.RootElement.TryGetProperty("data", out var data))
|
|
||||||
{
|
|
||||||
throw new Exception("Invalid response from API");
|
|
||||||
}
|
|
||||||
|
|
||||||
var manifestBase64 = data.GetProperty("manifest").GetString()
|
|
||||||
?? throw new Exception("No manifest in response");
|
|
||||||
|
|
||||||
// Decode base64 manifest to get actual CDN URL
|
|
||||||
var manifestJson = Encoding.UTF8.GetString(Convert.FromBase64String(manifestBase64));
|
|
||||||
var manifest = JsonDocument.Parse(manifestJson);
|
|
||||||
|
|
||||||
if (!manifest.RootElement.TryGetProperty("urls", out var urls) || urls.GetArrayLength() == 0)
|
|
||||||
{
|
|
||||||
throw new Exception("No download URLs in manifest");
|
|
||||||
}
|
|
||||||
|
|
||||||
var downloadUrl = urls[0].GetString()
|
|
||||||
?? throw new Exception("Download URL is null");
|
|
||||||
|
|
||||||
// Start the actual download from Tidal CDN (no encryption - squid.wtf handles everything)
|
|
||||||
using var request = new HttpRequestMessage(HttpMethod.Get, downloadUrl);
|
|
||||||
request.Headers.Add("User-Agent", "Mozilla/5.0");
|
request.Headers.Add("User-Agent", "Mozilla/5.0");
|
||||||
request.Headers.Add("Accept", "*/*");
|
request.Headers.Add("Accept", "*/*");
|
||||||
|
|
||||||
@@ -202,26 +161,7 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
// Close file before writing metadata
|
// Close file before writing metadata
|
||||||
await outputFile.DisposeAsync();
|
await outputFile.DisposeAsync();
|
||||||
|
|
||||||
// Start Spotify ID conversion in background (for lyrics support)
|
// Write metadata and cover art
|
||||||
// This doesn't block streaming - lyrics endpoint will fetch it on-demand if needed
|
|
||||||
_ = Task.Run(async () =>
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var spotifyId = await _odesliService.ConvertTidalToSpotifyIdAsync(trackId, CancellationToken.None);
|
|
||||||
if (!string.IsNullOrEmpty(spotifyId))
|
|
||||||
{
|
|
||||||
Logger.LogDebug("Background Spotify ID obtained for Tidal/{TrackId}: {SpotifyId}", trackId, spotifyId);
|
|
||||||
// Spotify ID is cached by Odesli service for future lyrics requests
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
Logger.LogDebug(ex, "Background Spotify ID conversion failed for Tidal/{TrackId}", trackId);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
// Write metadata and cover art (without Spotify ID - it's only needed for lyrics)
|
|
||||||
await WriteMetadataAsync(outputPath, song, cancellationToken);
|
await WriteMetadataAsync(outputPath, song, cancellationToken);
|
||||||
|
|
||||||
return outputPath;
|
return outputPath;
|
||||||
@@ -231,22 +171,13 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
|
|
||||||
#region SquidWTF API Methods
|
#region SquidWTF API Methods
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Gets track download information from hifi-api /track/ endpoint.
|
|
||||||
/// Per hifi-api spec: GET /track/?id={trackId}&quality={quality}
|
|
||||||
/// Returns: { "version": "2.0", "data": { trackId, assetPresentation, audioMode, audioQuality,
|
|
||||||
/// manifestMimeType, manifestHash, manifest (base64), albumReplayGain, trackReplayGain, bitDepth, sampleRate } }
|
|
||||||
/// The manifest is base64-encoded JSON containing: { mimeType, codecs, encryptionType, urls: [downloadUrl] }
|
|
||||||
/// Quality options: HI_RES_LOSSLESS (24-bit/192kHz FLAC), LOSSLESS (16-bit/44.1kHz FLAC), HIGH (320kbps AAC), LOW (96kbps AAC)
|
|
||||||
/// </summary>
|
|
||||||
private async Task<DownloadResult> GetTrackDownloadInfoAsync(string trackId, CancellationToken cancellationToken)
|
private async Task<DownloadResult> GetTrackDownloadInfoAsync(string trackId, CancellationToken cancellationToken)
|
||||||
{
|
{
|
||||||
return await QueueRequestAsync(async () =>
|
return await QueueRequestAsync(async () =>
|
||||||
{
|
{
|
||||||
// Use round-robin with fallback instead of racing to reduce CPU usage
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
|
||||||
{
|
{
|
||||||
// Map quality settings to Tidal's quality levels per hifi-api spec
|
// Map quality settings to Tidal's quality levels
|
||||||
var quality = _squidwtfSettings.Quality?.ToUpperInvariant() switch
|
var quality = _squidwtfSettings.Quality?.ToUpperInvariant() switch
|
||||||
{
|
{
|
||||||
"FLAC" => "LOSSLESS",
|
"FLAC" => "LOSSLESS",
|
||||||
@@ -259,7 +190,7 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
|
|
||||||
var url = $"{baseUrl}/track/?id={trackId}&quality={quality}";
|
var url = $"{baseUrl}/track/?id={trackId}&quality={quality}";
|
||||||
|
|
||||||
Logger.LogDebug("Fetching track download info from: {Url}", url);
|
Console.WriteLine($"%%%%%%%%%%%%%%%%%%% URL For downloads??: {url}");
|
||||||
|
|
||||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||||
response.EnsureSuccessStatusCode();
|
response.EnsureSuccessStatusCode();
|
||||||
@@ -297,7 +228,8 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
? audioQualityEl.GetString()
|
? audioQualityEl.GetString()
|
||||||
: "LOSSLESS";
|
: "LOSSLESS";
|
||||||
|
|
||||||
Logger.LogInformation("Track download URL obtained from hifi-api: {Url}", downloadUrl);
|
Logger.LogDebug("Decoded manifest - URL: {Url}, MIME: {MimeType}, Quality: {Quality}",
|
||||||
|
downloadUrl, mimeType, audioQuality);
|
||||||
|
|
||||||
return new DownloadResult
|
return new DownloadResult
|
||||||
{
|
{
|
||||||
@@ -309,56 +241,29 @@ public class SquidWTFDownloadService : BaseDownloadService
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
|
|
||||||
#region Utility Methods
|
#region Utility Methods
|
||||||
|
|
||||||
/// <summary>
|
private async Task<T> QueueRequestAsync<T>(Func<Task<T>> action)
|
||||||
/// Converts Tidal track ID to Spotify ID for lyrics support.
|
|
||||||
/// Called in background after streaming starts.
|
|
||||||
/// Also prefetches lyrics immediately after conversion.
|
|
||||||
/// </summary>
|
|
||||||
protected override async Task ConvertToSpotifyIdAsync(string externalProvider, string externalId)
|
|
||||||
{
|
|
||||||
if (externalProvider != "squidwtf")
|
|
||||||
{
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
var spotifyId = await _odesliService.ConvertTidalToSpotifyIdAsync(externalId, CancellationToken.None);
|
|
||||||
if (!string.IsNullOrEmpty(spotifyId))
|
|
||||||
{
|
|
||||||
Logger.LogDebug("Background Spotify ID obtained for Tidal/{TrackId}: {SpotifyId}", externalId, spotifyId);
|
|
||||||
|
|
||||||
// Immediately prefetch lyrics now that we have the Spotify ID
|
|
||||||
// This ensures lyrics are cached and ready when the client requests them
|
|
||||||
_ = Task.Run(async () =>
|
|
||||||
{
|
{
|
||||||
|
await _requestLock.WaitAsync();
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
using var scope = _serviceProvider.CreateScope();
|
var now = DateTime.UtcNow;
|
||||||
var spotifyLyricsService = scope.ServiceProvider.GetService<SpotifyLyricsService>();
|
var timeSinceLastRequest = (now - _lastRequestTime).TotalMilliseconds;
|
||||||
|
|
||||||
if (spotifyLyricsService != null)
|
if (timeSinceLastRequest < _minRequestIntervalMs)
|
||||||
{
|
{
|
||||||
var lyrics = await spotifyLyricsService.GetLyricsByTrackIdAsync(spotifyId);
|
await Task.Delay((int)(_minRequestIntervalMs - timeSinceLastRequest));
|
||||||
if (lyrics != null && lyrics.Lines.Count > 0)
|
}
|
||||||
|
|
||||||
|
_lastRequestTime = DateTime.UtcNow;
|
||||||
|
return await action();
|
||||||
|
}
|
||||||
|
finally
|
||||||
{
|
{
|
||||||
Logger.LogDebug("Background lyrics prefetched for Spotify/{SpotifyId}: {LineCount} lines",
|
_requestLock.Release();
|
||||||
spotifyId, lyrics.Lines.Count);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
Logger.LogDebug("No lyrics available for Spotify/{SpotifyId}", spotifyId);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch (Exception ex)
|
|
||||||
{
|
|
||||||
Logger.LogDebug(ex, "Background lyrics prefetch failed for Spotify/{SpotifyId}", spotifyId);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -12,41 +12,7 @@ using System.Text.Json.Nodes;
|
|||||||
namespace allstarr.Services.SquidWTF;
|
namespace allstarr.Services.SquidWTF;
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Metadata service implementation using the SquidWTF API (free, no key required).
|
/// Metadata service implementation using the SquidWTF API (free, no key required)
|
||||||
///
|
|
||||||
/// SquidWTF is a proxy to Tidal's API that provides free access to Tidal's music catalog.
|
|
||||||
/// This implementation follows the hifi-api specification documented at the forked repository.
|
|
||||||
///
|
|
||||||
/// API Endpoints (per hifi-api spec):
|
|
||||||
/// - GET /search/?s={query} - Search tracks (returns data.items array)
|
|
||||||
/// - GET /search/?a={query} - Search artists (returns data.artists.items array)
|
|
||||||
/// - GET /search/?al={query} - Search albums (returns data.albums.items array, undocumented)
|
|
||||||
/// - GET /search/?p={query} - Search playlists (returns data.playlists.items array, undocumented)
|
|
||||||
/// - GET /info/?id={trackId} - Get track metadata (returns data object with full track info)
|
|
||||||
/// - GET /track/?id={trackId}&quality={quality} - Get track download info (returns manifest)
|
|
||||||
/// - GET /album/?id={albumId} - Get album with tracks (undocumented, returns data.items array)
|
|
||||||
/// - GET /artist/?f={artistId} - Get artist with albums (undocumented, returns albums.items array)
|
|
||||||
/// - GET /playlist/?id={playlistId} - Get playlist with tracks (undocumented)
|
|
||||||
///
|
|
||||||
/// Quality Options:
|
|
||||||
/// - HI_RES_LOSSLESS: 24-bit/192kHz FLAC
|
|
||||||
/// - LOSSLESS: 16-bit/44.1kHz FLAC
|
|
||||||
/// - HIGH: 320kbps AAC
|
|
||||||
/// - LOW: 96kbps AAC
|
|
||||||
///
|
|
||||||
/// Response Structure:
|
|
||||||
/// All responses follow: { "version": "2.0", "data": { ... } }
|
|
||||||
/// Track objects include: id, title, duration, trackNumber, volumeNumber, explicit, bpm, isrc,
|
|
||||||
/// artist (singular), artists (array), album (object with id, title, cover UUID)
|
|
||||||
/// Cover art URLs: https://resources.tidal.com/images/{uuid-with-slashes}/{size}.jpg
|
|
||||||
///
|
|
||||||
/// Features:
|
|
||||||
/// - Round-robin load balancing across multiple mirror endpoints
|
|
||||||
/// - Automatic failover to backup endpoints on failure
|
|
||||||
/// - Racing endpoints for fastest response on latency-sensitive operations
|
|
||||||
/// - Redis caching for albums and artists (24-hour TTL)
|
|
||||||
/// - Explicit content filtering support
|
|
||||||
/// - Parallel Spotify ID conversion via Odesli for lyrics matching
|
|
||||||
/// </summary>
|
/// </summary>
|
||||||
|
|
||||||
public class SquidWTFMetadataService : IMusicMetadataService
|
public class SquidWTFMetadataService : IMusicMetadataService
|
||||||
@@ -55,7 +21,9 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
private readonly SubsonicSettings _settings;
|
private readonly SubsonicSettings _settings;
|
||||||
private readonly ILogger<SquidWTFMetadataService> _logger;
|
private readonly ILogger<SquidWTFMetadataService> _logger;
|
||||||
private readonly RedisCacheService _cache;
|
private readonly RedisCacheService _cache;
|
||||||
private readonly RoundRobinFallbackHelper _fallbackHelper;
|
private readonly List<string> _apiUrls;
|
||||||
|
private int _currentUrlIndex = 0;
|
||||||
|
private readonly object _urlIndexLock = new object();
|
||||||
|
|
||||||
public SquidWTFMetadataService(
|
public SquidWTFMetadataService(
|
||||||
IHttpClientFactory httpClientFactory,
|
IHttpClientFactory httpClientFactory,
|
||||||
@@ -69,33 +37,79 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
_settings = settings.Value;
|
_settings = settings.Value;
|
||||||
_logger = logger;
|
_logger = logger;
|
||||||
_cache = cache;
|
_cache = cache;
|
||||||
_fallbackHelper = new RoundRobinFallbackHelper(apiUrls, logger, "SquidWTF");
|
_apiUrls = apiUrls;
|
||||||
|
|
||||||
// Set up default headers
|
// Set up default headers
|
||||||
_httpClient.DefaultRequestHeaders.Add("User-Agent",
|
_httpClient.DefaultRequestHeaders.Add("User-Agent",
|
||||||
"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0");
|
"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0");
|
||||||
|
|
||||||
// Increase timeout for large artist/album responses (some artists have 100+ albums)
|
|
||||||
_httpClient.Timeout = TimeSpan.FromMinutes(5);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Gets the next URL in round-robin fashion to distribute load across providers
|
||||||
|
/// </summary>
|
||||||
|
private string GetNextBaseUrl()
|
||||||
|
{
|
||||||
|
lock (_urlIndexLock)
|
||||||
|
{
|
||||||
|
var url = _apiUrls[_currentUrlIndex];
|
||||||
|
_currentUrlIndex = (_currentUrlIndex + 1) % _apiUrls.Count;
|
||||||
|
return url;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Tries the request with the next provider in round-robin, then falls back to others on failure.
|
||||||
|
/// This distributes load evenly across all providers while maintaining reliability.
|
||||||
|
/// </summary>
|
||||||
|
private async Task<T> TryWithFallbackAsync<T>(Func<string, Task<T>> action, T defaultValue)
|
||||||
|
{
|
||||||
|
// Start with the next URL in round-robin to distribute load
|
||||||
|
var startIndex = 0;
|
||||||
|
lock (_urlIndexLock)
|
||||||
|
{
|
||||||
|
startIndex = _currentUrlIndex;
|
||||||
|
_currentUrlIndex = (_currentUrlIndex + 1) % _apiUrls.Count;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Try all URLs starting from the round-robin selected one
|
||||||
|
for (int attempt = 0; attempt < _apiUrls.Count; attempt++)
|
||||||
|
{
|
||||||
|
var urlIndex = (startIndex + attempt) % _apiUrls.Count;
|
||||||
|
var baseUrl = _apiUrls[urlIndex];
|
||||||
|
|
||||||
|
try
|
||||||
|
{
|
||||||
|
_logger.LogDebug("Trying endpoint {Endpoint} (attempt {Attempt}/{Total})",
|
||||||
|
baseUrl, attempt + 1, _apiUrls.Count);
|
||||||
|
return await action(baseUrl);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogWarning(ex, "Request failed with endpoint {Endpoint}, trying next...", baseUrl);
|
||||||
|
|
||||||
|
if (attempt == _apiUrls.Count - 1)
|
||||||
|
{
|
||||||
|
_logger.LogError("All {Count} SquidWTF endpoints failed", _apiUrls.Count);
|
||||||
|
return defaultValue;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return defaultValue;
|
||||||
|
}
|
||||||
|
|
||||||
public async Task<List<Song>> SearchSongsAsync(string query, int limit = 20)
|
public async Task<List<Song>> SearchSongsAsync(string query, int limit = 20)
|
||||||
{
|
{
|
||||||
// Race all endpoints for fastest search results
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
return await _fallbackHelper.RaceAllEndpointsAsync(async (baseUrl, ct) =>
|
|
||||||
{
|
{
|
||||||
// Use 's' parameter for track search as per hifi-api spec
|
|
||||||
var url = $"{baseUrl}/search/?s={Uri.EscapeDataString(query)}";
|
var url = $"{baseUrl}/search/?s={Uri.EscapeDataString(query)}";
|
||||||
var response = await _httpClient.GetAsync(url, ct);
|
var response = await _httpClient.GetAsync(url);
|
||||||
|
|
||||||
if (!response.IsSuccessStatusCode)
|
if (!response.IsSuccessStatusCode)
|
||||||
{
|
{
|
||||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||||
}
|
}
|
||||||
|
|
||||||
var json = await response.Content.ReadAsStringAsync(ct);
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
|
|
||||||
// Check for error in response body
|
// Check for error in response body
|
||||||
var result = JsonDocument.Parse(json);
|
var result = JsonDocument.Parse(json);
|
||||||
@@ -106,7 +120,6 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
}
|
}
|
||||||
|
|
||||||
var songs = new List<Song>();
|
var songs = new List<Song>();
|
||||||
// Per hifi-api spec: track search returns data.items array
|
|
||||||
if (result.RootElement.TryGetProperty("data", out var data) &&
|
if (result.RootElement.TryGetProperty("data", out var data) &&
|
||||||
data.TryGetProperty("items", out var items))
|
data.TryGetProperty("items", out var items))
|
||||||
{
|
{
|
||||||
@@ -116,36 +129,30 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
if (count >= limit) break;
|
if (count >= limit) break;
|
||||||
|
|
||||||
var song = ParseTidalTrack(track);
|
var song = ParseTidalTrack(track);
|
||||||
if (ShouldIncludeSong(song))
|
|
||||||
{
|
|
||||||
songs.Add(song);
|
songs.Add(song);
|
||||||
}
|
|
||||||
count++;
|
count++;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return songs;
|
return songs;
|
||||||
});
|
}, new List<Song>());
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task<List<Album>> SearchAlbumsAsync(string query, int limit = 20)
|
public async Task<List<Album>> SearchAlbumsAsync(string query, int limit = 20)
|
||||||
{
|
{
|
||||||
// Race all endpoints for fastest search results
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
return await _fallbackHelper.RaceAllEndpointsAsync(async (baseUrl, ct) =>
|
|
||||||
{
|
{
|
||||||
// Note: hifi-api doesn't document album search, but 'al' parameter is commonly used
|
|
||||||
var url = $"{baseUrl}/search/?al={Uri.EscapeDataString(query)}";
|
var url = $"{baseUrl}/search/?al={Uri.EscapeDataString(query)}";
|
||||||
var response = await _httpClient.GetAsync(url, ct);
|
var response = await _httpClient.GetAsync(url);
|
||||||
|
|
||||||
if (!response.IsSuccessStatusCode)
|
if (!response.IsSuccessStatusCode)
|
||||||
{
|
{
|
||||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
return new List<Album>();
|
||||||
}
|
}
|
||||||
|
|
||||||
var json = await response.Content.ReadAsStringAsync(ct);
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
var result = JsonDocument.Parse(json);
|
var result = JsonDocument.Parse(json);
|
||||||
|
|
||||||
var albums = new List<Album>();
|
var albums = new List<Album>();
|
||||||
// Per hifi-api spec: album search returns data.albums.items array
|
|
||||||
if (result.RootElement.TryGetProperty("data", out var data) &&
|
if (result.RootElement.TryGetProperty("data", out var data) &&
|
||||||
data.TryGetProperty("albums", out var albumsObj) &&
|
data.TryGetProperty("albums", out var albumsObj) &&
|
||||||
albumsObj.TryGetProperty("items", out var items))
|
albumsObj.TryGetProperty("items", out var items))
|
||||||
@@ -161,31 +168,25 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
}
|
}
|
||||||
|
|
||||||
return albums;
|
return albums;
|
||||||
});
|
}, new List<Album>());
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task<List<Artist>> SearchArtistsAsync(string query, int limit = 20)
|
public async Task<List<Artist>> SearchArtistsAsync(string query, int limit = 20)
|
||||||
{
|
{
|
||||||
// Race all endpoints for fastest search results
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
return await _fallbackHelper.RaceAllEndpointsAsync(async (baseUrl, ct) =>
|
|
||||||
{
|
{
|
||||||
// Per hifi-api spec: use 'a' parameter for artist search
|
|
||||||
var url = $"{baseUrl}/search/?a={Uri.EscapeDataString(query)}";
|
var url = $"{baseUrl}/search/?a={Uri.EscapeDataString(query)}";
|
||||||
_logger.LogInformation("🔍 SQUIDWTF: Searching artists with URL: {Url}", url);
|
var response = await _httpClient.GetAsync(url);
|
||||||
|
|
||||||
var response = await _httpClient.GetAsync(url, ct);
|
|
||||||
|
|
||||||
if (!response.IsSuccessStatusCode)
|
if (!response.IsSuccessStatusCode)
|
||||||
{
|
{
|
||||||
_logger.LogWarning("⚠️ SQUIDWTF: Artist search failed with status {StatusCode}", response.StatusCode);
|
return new List<Artist>();
|
||||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
var json = await response.Content.ReadAsStringAsync(ct);
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
var result = JsonDocument.Parse(json);
|
var result = JsonDocument.Parse(json);
|
||||||
|
|
||||||
var artists = new List<Artist>();
|
var artists = new List<Artist>();
|
||||||
// Per hifi-api spec: artist search returns data.artists.items array
|
|
||||||
if (result.RootElement.TryGetProperty("data", out var data) &&
|
if (result.RootElement.TryGetProperty("data", out var data) &&
|
||||||
data.TryGetProperty("artists", out var artistsObj) &&
|
data.TryGetProperty("artists", out var artistsObj) &&
|
||||||
artistsObj.TryGetProperty("items", out var items))
|
artistsObj.TryGetProperty("items", out var items))
|
||||||
@@ -195,23 +196,19 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
{
|
{
|
||||||
if (count >= limit) break;
|
if (count >= limit) break;
|
||||||
|
|
||||||
var parsedArtist = ParseTidalArtist(artist);
|
artists.Add(ParseTidalArtist(artist));
|
||||||
artists.Add(parsedArtist);
|
|
||||||
_logger.LogDebug("🎤 SQUIDWTF: Found artist: {Name} (ID: {Id})", parsedArtist.Name, parsedArtist.ExternalId);
|
|
||||||
count++;
|
count++;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
_logger.LogInformation("✓ SQUIDWTF: Artist search returned {Count} results", artists.Count);
|
|
||||||
return artists;
|
return artists;
|
||||||
});
|
}, new List<Artist>());
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task<List<ExternalPlaylist>> SearchPlaylistsAsync(string query, int limit = 20)
|
public async Task<List<ExternalPlaylist>> SearchPlaylistsAsync(string query, int limit = 20)
|
||||||
{
|
{
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
// Per hifi-api spec: use 'p' parameter for playlist search
|
|
||||||
var url = $"{baseUrl}/search/?p={Uri.EscapeDataString(query)}";
|
var url = $"{baseUrl}/search/?p={Uri.EscapeDataString(query)}";
|
||||||
var response = await _httpClient.GetAsync(url);
|
var response = await _httpClient.GetAsync(url);
|
||||||
if (!response.IsSuccessStatusCode) return new List<ExternalPlaylist>();
|
if (!response.IsSuccessStatusCode) return new List<ExternalPlaylist>();
|
||||||
@@ -220,20 +217,15 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
var result = JsonDocument.Parse(json);
|
var result = JsonDocument.Parse(json);
|
||||||
|
|
||||||
var playlists = new List<ExternalPlaylist>();
|
var playlists = new List<ExternalPlaylist>();
|
||||||
// Per hifi-api spec: playlist search returns data.playlists.items array
|
|
||||||
if (result.RootElement.TryGetProperty("data", out var data) &&
|
if (result.RootElement.TryGetProperty("data", out var data) &&
|
||||||
data.TryGetProperty("playlists", out var playlistObj) &&
|
data.TryGetProperty("playlists", out var playlistObj) &&
|
||||||
playlistObj.TryGetProperty("items", out var items))
|
playlistObj.TryGetProperty("items", out var items))
|
||||||
{
|
{
|
||||||
int count = 0;
|
|
||||||
foreach(var playlist in items.EnumerateArray())
|
foreach(var playlist in items.EnumerateArray())
|
||||||
{
|
{
|
||||||
if (count >= limit) break;
|
|
||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
playlists.Add(ParseTidalPlaylist(playlist));
|
playlists.Add(ParseTidalPlaylist(playlist));
|
||||||
count++;
|
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
@@ -269,9 +261,8 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
{
|
{
|
||||||
if (externalProvider != "squidwtf") return null;
|
if (externalProvider != "squidwtf") return null;
|
||||||
|
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
// Per hifi-api spec: GET /info/?id={trackId} returns track metadata
|
|
||||||
var url = $"{baseUrl}/info/?id={externalId}";
|
var url = $"{baseUrl}/info/?id={externalId}";
|
||||||
|
|
||||||
var response = await _httpClient.GetAsync(url);
|
var response = await _httpClient.GetAsync(url);
|
||||||
@@ -280,16 +271,10 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
var json = await response.Content.ReadAsStringAsync();
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
var result = JsonDocument.Parse(json);
|
var result = JsonDocument.Parse(json);
|
||||||
|
|
||||||
// Per hifi-api spec: response is { "version": "2.0", "data": { track object } }
|
|
||||||
if (!result.RootElement.TryGetProperty("data", out var track))
|
if (!result.RootElement.TryGetProperty("data", out var track))
|
||||||
return null;
|
return null;
|
||||||
|
|
||||||
var song = ParseTidalTrackFull(track);
|
return ParseTidalTrackFull(track);
|
||||||
|
|
||||||
// NOTE: Spotify ID conversion happens during download (in SquidWTFDownloadService)
|
|
||||||
// This avoids redundant conversions and ensures it's done in parallel with the download
|
|
||||||
|
|
||||||
return song;
|
|
||||||
}, (Song?)null);
|
}, (Song?)null);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -302,9 +287,8 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
var cached = await _cache.GetAsync<Album>(cacheKey);
|
var cached = await _cache.GetAsync<Album>(cacheKey);
|
||||||
if (cached != null) return cached;
|
if (cached != null) return cached;
|
||||||
|
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
// Note: hifi-api doesn't document album endpoint, but /album/?id={albumId} is commonly used
|
|
||||||
var url = $"{baseUrl}/album/?id={externalId}";
|
var url = $"{baseUrl}/album/?id={externalId}";
|
||||||
|
|
||||||
var response = await _httpClient.GetAsync(url);
|
var response = await _httpClient.GetAsync(url);
|
||||||
@@ -313,18 +297,17 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
var json = await response.Content.ReadAsStringAsync();
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
var result = JsonDocument.Parse(json);
|
var result = JsonDocument.Parse(json);
|
||||||
|
|
||||||
// Response structure: { "data": { album object with "items" array of tracks } }
|
|
||||||
if (!result.RootElement.TryGetProperty("data", out var albumElement))
|
if (!result.RootElement.TryGetProperty("data", out var albumElement))
|
||||||
return null;
|
return null;
|
||||||
|
|
||||||
var album = ParseTidalAlbum(albumElement);
|
var album = ParseTidalAlbum(albumElement);
|
||||||
|
|
||||||
// Get album tracks from items array
|
// Get album tracks
|
||||||
if (albumElement.TryGetProperty("items", out var tracks))
|
if (albumElement.TryGetProperty("items", out var tracks))
|
||||||
{
|
{
|
||||||
foreach (var trackWrapper in tracks.EnumerateArray())
|
foreach (var trackWrapper in tracks.EnumerateArray())
|
||||||
{
|
{
|
||||||
// Each item is wrapped: { "item": { track object } }
|
|
||||||
if (trackWrapper.TryGetProperty("item", out var track))
|
if (trackWrapper.TryGetProperty("item", out var track))
|
||||||
{
|
{
|
||||||
var song = ParseTidalTrack(track);
|
var song = ParseTidalTrack(track);
|
||||||
@@ -358,9 +341,8 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
return cached;
|
return cached;
|
||||||
}
|
}
|
||||||
|
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
// Note: hifi-api doesn't document artist endpoint, but /artist/?f={artistId} is commonly used
|
|
||||||
var url = $"{baseUrl}/artist/?f={externalId}";
|
var url = $"{baseUrl}/artist/?f={externalId}";
|
||||||
_logger.LogInformation("Fetching artist from {Url}", url);
|
_logger.LogInformation("Fetching artist from {Url}", url);
|
||||||
|
|
||||||
@@ -378,23 +360,18 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
JsonElement? artistSource = null;
|
JsonElement? artistSource = null;
|
||||||
int albumCount = 0;
|
int albumCount = 0;
|
||||||
|
|
||||||
// Response structure: { "albums": { "items": [ album objects ] }, "tracks": [ track objects ] }
|
// Think this can maybe switch to something using ParseTidalAlbum
|
||||||
// Extract artist info from albums.items[0].artist (most reliable source)
|
|
||||||
if (result.RootElement.TryGetProperty("albums", out var albums) &&
|
if (result.RootElement.TryGetProperty("albums", out var albums) &&
|
||||||
albums.TryGetProperty("items", out var albumItems) &&
|
albums.TryGetProperty("items", out var albumItems) &&
|
||||||
albumItems.GetArrayLength() > 0)
|
albumItems.GetArrayLength() > 0)
|
||||||
{
|
{
|
||||||
albumCount = albumItems.GetArrayLength();
|
albumCount = albumItems.GetArrayLength();
|
||||||
if (albumItems[0].TryGetProperty("artist", out var artistEl))
|
artistSource = albumItems[0].GetProperty("artist");
|
||||||
{
|
|
||||||
artistSource = artistEl;
|
|
||||||
_logger.LogInformation("Found artist from albums, albumCount={AlbumCount}", albumCount);
|
_logger.LogInformation("Found artist from albums, albumCount={AlbumCount}", albumCount);
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
// Fallback: try to get artist from tracks[0].artists[0]
|
// Think this can maybe switch to something using ParseTidalTrack
|
||||||
if (artistSource == null &&
|
else if (result.RootElement.TryGetProperty("tracks", out var tracks) &&
|
||||||
result.RootElement.TryGetProperty("tracks", out var tracks) &&
|
|
||||||
tracks.GetArrayLength() > 0 &&
|
tracks.GetArrayLength() > 0 &&
|
||||||
tracks[0].TryGetProperty("artists", out var artists) &&
|
tracks[0].TryGetProperty("artists", out var artists) &&
|
||||||
artists.GetArrayLength() > 0)
|
artists.GetArrayLength() > 0)
|
||||||
@@ -405,13 +382,11 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
|
|
||||||
if (artistSource == null)
|
if (artistSource == null)
|
||||||
{
|
{
|
||||||
_logger.LogDebug("Could not find artist data in response. Response keys: {Keys}",
|
_logger.LogWarning("Could not find artist data in response");
|
||||||
string.Join(", ", result.RootElement.EnumerateObject().Select(p => p.Name)));
|
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
var artistElement = artistSource.Value;
|
var artistElement = artistSource.Value;
|
||||||
// Normalize artist data to include album count
|
|
||||||
var normalizedArtist = new JsonObject
|
var normalizedArtist = new JsonObject
|
||||||
{
|
{
|
||||||
["id"] = artistElement.GetProperty("id").GetInt64(),
|
["id"] = artistElement.GetProperty("id").GetInt64(),
|
||||||
@@ -436,11 +411,10 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
{
|
{
|
||||||
if (externalProvider != "squidwtf") return new List<Album>();
|
if (externalProvider != "squidwtf") return new List<Album>();
|
||||||
|
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
_logger.LogInformation("GetArtistAlbumsAsync called for SquidWTF artist {ExternalId}", externalId);
|
_logger.LogInformation("GetArtistAlbumsAsync called for SquidWTF artist {ExternalId}", externalId);
|
||||||
|
|
||||||
// Note: hifi-api doesn't document artist endpoint, but /artist/?f={artistId} is commonly used
|
|
||||||
var url = $"{baseUrl}/artist/?f={externalId}";
|
var url = $"{baseUrl}/artist/?f={externalId}";
|
||||||
_logger.LogInformation("Fetching artist albums from URL: {Url}", url);
|
_logger.LogInformation("Fetching artist albums from URL: {Url}", url);
|
||||||
var response = await _httpClient.GetAsync(url);
|
var response = await _httpClient.GetAsync(url);
|
||||||
@@ -457,7 +431,6 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
|
|
||||||
var albums = new List<Album>();
|
var albums = new List<Album>();
|
||||||
|
|
||||||
// Response structure: { "albums": { "items": [ album objects ] } }
|
|
||||||
if (result.RootElement.TryGetProperty("albums", out var albumsObj) &&
|
if (result.RootElement.TryGetProperty("albums", out var albumsObj) &&
|
||||||
albumsObj.TryGetProperty("items", out var items))
|
albumsObj.TryGetProperty("items", out var items))
|
||||||
{
|
{
|
||||||
@@ -483,9 +456,8 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
{
|
{
|
||||||
if (externalProvider != "squidwtf") return null;
|
if (externalProvider != "squidwtf") return null;
|
||||||
|
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
// Note: hifi-api doesn't document playlist endpoint, but /playlist/?id={playlistId} is commonly used
|
|
||||||
var url = $"{baseUrl}/playlist/?id={externalId}";
|
var url = $"{baseUrl}/playlist/?id={externalId}";
|
||||||
var response = await _httpClient.GetAsync(url);
|
var response = await _httpClient.GetAsync(url);
|
||||||
if (!response.IsSuccessStatusCode) return null;
|
if (!response.IsSuccessStatusCode) return null;
|
||||||
@@ -493,10 +465,8 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
var json = await response.Content.ReadAsStringAsync();
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
var playlistElement = JsonDocument.Parse(json).RootElement;
|
var playlistElement = JsonDocument.Parse(json).RootElement;
|
||||||
|
|
||||||
// Check for error response
|
|
||||||
if (playlistElement.TryGetProperty("error", out _)) return null;
|
if (playlistElement.TryGetProperty("error", out _)) return null;
|
||||||
|
|
||||||
// Response structure: { "playlist": { playlist object }, "items": [ track wrappers ] }
|
|
||||||
return ParseTidalPlaylist(playlistElement);
|
return ParseTidalPlaylist(playlistElement);
|
||||||
}, (ExternalPlaylist?)null);
|
}, (ExternalPlaylist?)null);
|
||||||
}
|
}
|
||||||
@@ -505,9 +475,8 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
{
|
{
|
||||||
if (externalProvider != "squidwtf") return new List<Song>();
|
if (externalProvider != "squidwtf") return new List<Song>();
|
||||||
|
|
||||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
return await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
// Note: hifi-api doesn't document playlist endpoint, but /playlist/?id={playlistId} is commonly used
|
|
||||||
var url = $"{baseUrl}/playlist/?id={externalId}";
|
var url = $"{baseUrl}/playlist/?id={externalId}";
|
||||||
var response = await _httpClient.GetAsync(url);
|
var response = await _httpClient.GetAsync(url);
|
||||||
if (!response.IsSuccessStatusCode) return new List<Song>();
|
if (!response.IsSuccessStatusCode) return new List<Song>();
|
||||||
@@ -515,13 +484,11 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
var json = await response.Content.ReadAsStringAsync();
|
var json = await response.Content.ReadAsStringAsync();
|
||||||
var playlistElement = JsonDocument.Parse(json).RootElement;
|
var playlistElement = JsonDocument.Parse(json).RootElement;
|
||||||
|
|
||||||
// Check for error response
|
|
||||||
if (playlistElement.TryGetProperty("error", out _)) return new List<Song>();
|
if (playlistElement.TryGetProperty("error", out _)) return new List<Song>();
|
||||||
|
|
||||||
JsonElement? playlist = null;
|
JsonElement? playlist = null;
|
||||||
JsonElement? tracks = null;
|
JsonElement? tracks = null;
|
||||||
|
|
||||||
// Response structure: { "playlist": { playlist object }, "items": [ track wrappers ] }
|
|
||||||
if (playlistElement.TryGetProperty("playlist", out var playlistEl))
|
if (playlistElement.TryGetProperty("playlist", out var playlistEl))
|
||||||
{
|
{
|
||||||
playlist = playlistEl;
|
playlist = playlistEl;
|
||||||
@@ -544,7 +511,6 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
int trackIndex = 1;
|
int trackIndex = 1;
|
||||||
foreach (var entry in tracks.Value.EnumerateArray())
|
foreach (var entry in tracks.Value.EnumerateArray())
|
||||||
{
|
{
|
||||||
// Each item is wrapped: { "item": { track object } }
|
|
||||||
if (!entry.TryGetProperty("item", out var track))
|
if (!entry.TryGetProperty("item", out var track))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
@@ -567,14 +533,6 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
|
|
||||||
// --- Parser functions start here ---
|
// --- Parser functions start here ---
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Parses a Tidal track object from hifi-api search/album/playlist responses.
|
|
||||||
/// Per hifi-api spec, track objects contain: id, title, duration, trackNumber, volumeNumber,
|
|
||||||
/// explicit, artist (singular), artists (array), album (object with id, title, cover).
|
|
||||||
/// </summary>
|
|
||||||
/// <param name="track">JSON element containing track data</param>
|
|
||||||
/// <param name="fallbackTrackNumber">Optional track number to use if not present in JSON</param>
|
|
||||||
/// <returns>Parsed Song object</returns>
|
|
||||||
private Song ParseTidalTrack(JsonElement track, int? fallbackTrackNumber = null)
|
private Song ParseTidalTrack(JsonElement track, int? fallbackTrackNumber = null)
|
||||||
{
|
{
|
||||||
var externalId = track.GetProperty("id").GetInt64().ToString();
|
var externalId = track.GetProperty("id").GetInt64().ToString();
|
||||||
@@ -664,13 +622,6 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Parses a full Tidal track object from hifi-api /info/ endpoint.
|
|
||||||
/// Per hifi-api spec, full track objects include additional metadata: bpm, isrc, key, keyScale,
|
|
||||||
/// streamStartDate (for year), copyright, replayGain, peak, audioQuality, audioModes.
|
|
||||||
/// </summary>
|
|
||||||
/// <param name="track">JSON element containing full track data</param>
|
|
||||||
/// <returns>Parsed Song object with extended metadata</returns>
|
|
||||||
private Song ParseTidalTrackFull(JsonElement track)
|
private Song ParseTidalTrackFull(JsonElement track)
|
||||||
{
|
{
|
||||||
var externalId = track.GetProperty("id").GetInt64().ToString();
|
var externalId = track.GetProperty("id").GetInt64().ToString();
|
||||||
@@ -792,13 +743,6 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Parses a Tidal album object from hifi-api responses.
|
|
||||||
/// Per hifi-api spec, album objects contain: id, title, releaseDate, numberOfTracks,
|
|
||||||
/// cover (UUID), artist (object) or artists (array).
|
|
||||||
/// </summary>
|
|
||||||
/// <param name="album">JSON element containing album data</param>
|
|
||||||
/// <returns>Parsed Album object</returns>
|
|
||||||
private Album ParseTidalAlbum(JsonElement album)
|
private Album ParseTidalAlbum(JsonElement album)
|
||||||
{
|
{
|
||||||
var externalId = album.GetProperty("id").GetInt64().ToString();
|
var externalId = album.GetProperty("id").GetInt64().ToString();
|
||||||
@@ -852,13 +796,8 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
// TODO: Think of a way to implement album count when this function is called by search function
|
||||||
/// Parses a Tidal artist object from hifi-api responses.
|
// as the API endpoint in search does not include this data
|
||||||
/// Per hifi-api spec, artist objects contain: id, name, picture (UUID).
|
|
||||||
/// Note: albums_count is not in the standard API response but is added by GetArtistAsync.
|
|
||||||
/// </summary>
|
|
||||||
/// <param name="artist">JSON element containing artist data</param>
|
|
||||||
/// <returns>Parsed Artist object</returns>
|
|
||||||
private Artist ParseTidalArtist(JsonElement artist)
|
private Artist ParseTidalArtist(JsonElement artist)
|
||||||
{
|
{
|
||||||
var externalId = artist.GetProperty("id").GetInt64().ToString();
|
var externalId = artist.GetProperty("id").GetInt64().ToString();
|
||||||
@@ -884,14 +823,6 @@ public class SquidWTFMetadataService : IMusicMetadataService
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Parses a Tidal playlist from hifi-api /playlist/ endpoint response.
|
|
||||||
/// Per hifi-api spec (undocumented), response structure is:
|
|
||||||
/// { "playlist": { uuid, title, description, creator, created, numberOfTracks, duration, squareImage },
|
|
||||||
/// "items": [ { "item": { track object } } ] }
|
|
||||||
/// </summary>
|
|
||||||
/// <param name="playlistElement">Root JSON element containing playlist and items</param>
|
|
||||||
/// <returns>Parsed ExternalPlaylist object</returns>
|
|
||||||
private ExternalPlaylist ParseTidalPlaylist(JsonElement playlistElement)
|
private ExternalPlaylist ParseTidalPlaylist(JsonElement playlistElement)
|
||||||
{
|
{
|
||||||
JsonElement? playlist = null;
|
JsonElement? playlist = null;
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ using System.Text.Json;
|
|||||||
using Microsoft.Extensions.Options;
|
using Microsoft.Extensions.Options;
|
||||||
using allstarr.Models.Settings;
|
using allstarr.Models.Settings;
|
||||||
using allstarr.Services.Validation;
|
using allstarr.Services.Validation;
|
||||||
using allstarr.Services.Common;
|
|
||||||
|
|
||||||
namespace allstarr.Services.SquidWTF;
|
namespace allstarr.Services.SquidWTF;
|
||||||
|
|
||||||
@@ -13,26 +12,56 @@ namespace allstarr.Services.SquidWTF;
|
|||||||
public class SquidWTFStartupValidator : BaseStartupValidator
|
public class SquidWTFStartupValidator : BaseStartupValidator
|
||||||
{
|
{
|
||||||
private readonly SquidWTFSettings _settings;
|
private readonly SquidWTFSettings _settings;
|
||||||
private readonly RoundRobinFallbackHelper _fallbackHelper;
|
private readonly List<string> _apiUrls;
|
||||||
private readonly EndpointBenchmarkService _benchmarkService;
|
private int _currentUrlIndex = 0;
|
||||||
private readonly ILogger<SquidWTFStartupValidator> _logger;
|
private readonly object _urlIndexLock = new object();
|
||||||
|
|
||||||
public override string ServiceName => "SquidWTF";
|
public override string ServiceName => "SquidWTF";
|
||||||
|
|
||||||
public SquidWTFStartupValidator(
|
public SquidWTFStartupValidator(IOptions<SquidWTFSettings> settings, HttpClient httpClient, List<string> apiUrls)
|
||||||
IOptions<SquidWTFSettings> settings,
|
|
||||||
HttpClient httpClient,
|
|
||||||
List<string> apiUrls,
|
|
||||||
EndpointBenchmarkService benchmarkService,
|
|
||||||
ILogger<SquidWTFStartupValidator> logger)
|
|
||||||
: base(httpClient)
|
: base(httpClient)
|
||||||
{
|
{
|
||||||
_settings = settings.Value;
|
_settings = settings.Value;
|
||||||
_fallbackHelper = new RoundRobinFallbackHelper(apiUrls, logger, "SquidWTF");
|
_apiUrls = apiUrls;
|
||||||
_benchmarkService = benchmarkService;
|
|
||||||
_logger = logger;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Tries the request with the next provider in round-robin, then falls back to others on failure.
|
||||||
|
/// This distributes load evenly across all providers while maintaining reliability.
|
||||||
|
/// </summary>
|
||||||
|
private async Task<T> TryWithFallbackAsync<T>(Func<string, Task<T>> action, T defaultValue)
|
||||||
|
{
|
||||||
|
// Start with the next URL in round-robin to distribute load
|
||||||
|
var startIndex = 0;
|
||||||
|
lock (_urlIndexLock)
|
||||||
|
{
|
||||||
|
startIndex = _currentUrlIndex;
|
||||||
|
_currentUrlIndex = (_currentUrlIndex + 1) % _apiUrls.Count;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Try all URLs starting from the round-robin selected one
|
||||||
|
for (int attempt = 0; attempt < _apiUrls.Count; attempt++)
|
||||||
|
{
|
||||||
|
var urlIndex = (startIndex + attempt) % _apiUrls.Count;
|
||||||
|
var baseUrl = _apiUrls[urlIndex];
|
||||||
|
|
||||||
|
try
|
||||||
|
{
|
||||||
|
return await action(baseUrl);
|
||||||
|
}
|
||||||
|
catch
|
||||||
|
{
|
||||||
|
WriteDetail($"Endpoint {baseUrl} failed, trying next...");
|
||||||
|
|
||||||
|
if (attempt == _apiUrls.Count - 1)
|
||||||
|
{
|
||||||
|
WriteDetail($"All {_apiUrls.Count} endpoints failed");
|
||||||
|
return defaultValue;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return defaultValue;
|
||||||
|
}
|
||||||
|
|
||||||
public override async Task<ValidationResult> ValidateAsync(CancellationToken cancellationToken)
|
public override async Task<ValidationResult> ValidateAsync(CancellationToken cancellationToken)
|
||||||
{
|
{
|
||||||
@@ -50,49 +79,8 @@ public class SquidWTFStartupValidator : BaseStartupValidator
|
|||||||
|
|
||||||
WriteStatus("SquidWTF Quality", quality, ConsoleColor.Cyan);
|
WriteStatus("SquidWTF Quality", quality, ConsoleColor.Cyan);
|
||||||
|
|
||||||
// Benchmark all endpoints to determine fastest
|
|
||||||
var apiUrls = _fallbackHelper.EndpointCount > 0
|
|
||||||
? Enumerable.Range(0, _fallbackHelper.EndpointCount).Select(_ => "").ToList() // Placeholder, we'll get actual URLs from fallback helper
|
|
||||||
: new List<string>();
|
|
||||||
|
|
||||||
// Get the actual API URLs by reflection (not ideal, but works for now)
|
|
||||||
var fallbackHelperType = _fallbackHelper.GetType();
|
|
||||||
var apiUrlsField = fallbackHelperType.GetField("_apiUrls", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
|
|
||||||
if (apiUrlsField != null)
|
|
||||||
{
|
|
||||||
apiUrls = (List<string>)apiUrlsField.GetValue(_fallbackHelper)!;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (apiUrls.Count > 1)
|
|
||||||
{
|
|
||||||
WriteStatus("Benchmarking Endpoints", $"{apiUrls.Count} endpoints", ConsoleColor.Cyan);
|
|
||||||
|
|
||||||
var orderedEndpoints = await _benchmarkService.BenchmarkEndpointsAsync(
|
|
||||||
apiUrls,
|
|
||||||
async (endpoint, ct) =>
|
|
||||||
{
|
|
||||||
try
|
|
||||||
{
|
|
||||||
var response = await _httpClient.GetAsync(endpoint, ct);
|
|
||||||
return response.IsSuccessStatusCode;
|
|
||||||
}
|
|
||||||
catch
|
|
||||||
{
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
},
|
|
||||||
pingCount: 2,
|
|
||||||
cancellationToken);
|
|
||||||
|
|
||||||
if (orderedEndpoints.Count > 0)
|
|
||||||
{
|
|
||||||
_fallbackHelper.SetEndpointOrder(orderedEndpoints);
|
|
||||||
WriteDetail($"Fastest endpoint: {orderedEndpoints.First()}");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Test connectivity with fallback
|
// Test connectivity with fallback
|
||||||
var result = await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
var result = await TryWithFallbackAsync(async (baseUrl) =>
|
||||||
{
|
{
|
||||||
var response = await _httpClient.GetAsync(baseUrl, cancellationToken);
|
var response = await _httpClient.GetAsync(baseUrl, cancellationToken);
|
||||||
|
|
||||||
@@ -119,8 +107,8 @@ public class SquidWTFStartupValidator : BaseStartupValidator
|
|||||||
{
|
{
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
// Test search with "22" by Taylor Swift
|
// Test search with a simple query
|
||||||
var searchUrl = $"{baseUrl}/search/?s=22%20Taylor%20Swift";
|
var searchUrl = $"{baseUrl}/search/?s=Taylor%20Swift";
|
||||||
var searchResponse = await _httpClient.GetAsync(searchUrl, cancellationToken);
|
var searchResponse = await _httpClient.GetAsync(searchUrl, cancellationToken);
|
||||||
|
|
||||||
if (searchResponse.IsSuccessStatusCode)
|
if (searchResponse.IsSuccessStatusCode)
|
||||||
@@ -133,36 +121,7 @@ public class SquidWTFStartupValidator : BaseStartupValidator
|
|||||||
{
|
{
|
||||||
var itemCount = items.GetArrayLength();
|
var itemCount = items.GetArrayLength();
|
||||||
WriteStatus("Search Functionality", "WORKING", ConsoleColor.Green);
|
WriteStatus("Search Functionality", "WORKING", ConsoleColor.Green);
|
||||||
WriteDetail($"Test search for '22' by Taylor Swift returned {itemCount} results");
|
WriteDetail($"Test search returned {itemCount} results");
|
||||||
|
|
||||||
// Check if we found the actual song
|
|
||||||
bool foundTaylorSwift22 = false;
|
|
||||||
foreach (var item in items.EnumerateArray())
|
|
||||||
{
|
|
||||||
if (item.TryGetProperty("title", out var title) &&
|
|
||||||
item.TryGetProperty("artists", out var artists) &&
|
|
||||||
artists.GetArrayLength() > 0)
|
|
||||||
{
|
|
||||||
var titleStr = title.GetString() ?? "";
|
|
||||||
var artistName = artists[0].TryGetProperty("name", out var name)
|
|
||||||
? name.GetString() ?? ""
|
|
||||||
: "";
|
|
||||||
|
|
||||||
if (titleStr.Contains("22", StringComparison.OrdinalIgnoreCase) &&
|
|
||||||
artistName.Contains("Taylor Swift", StringComparison.OrdinalIgnoreCase))
|
|
||||||
{
|
|
||||||
foundTaylorSwift22 = true;
|
|
||||||
var trackId = item.TryGetProperty("id", out var id) ? id.GetInt64() : 0;
|
|
||||||
WriteDetail($"✓ Found: '{titleStr}' by {artistName} (ID: {trackId})");
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!foundTaylorSwift22)
|
|
||||||
{
|
|
||||||
WriteDetail("⚠ Could not find exact match for '22' by Taylor Swift in results");
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -32,8 +32,7 @@
|
|||||||
"EnableExternalPlaylists": true
|
"EnableExternalPlaylists": true
|
||||||
},
|
},
|
||||||
"Library": {
|
"Library": {
|
||||||
"DownloadPath": "./downloads",
|
"DownloadPath": "./downloads"
|
||||||
"KeptPath": "/app/kept"
|
|
||||||
},
|
},
|
||||||
"Qobuz": {
|
"Qobuz": {
|
||||||
"UserAuthToken": "your-qobuz-token",
|
"UserAuthToken": "your-qobuz-token",
|
||||||
|
|||||||
@@ -539,7 +539,6 @@
|
|||||||
<div class="tab" data-tab="jellyfin-playlists">Link Playlists</div>
|
<div class="tab" data-tab="jellyfin-playlists">Link Playlists</div>
|
||||||
<div class="tab" data-tab="playlists">Active Playlists</div>
|
<div class="tab" data-tab="playlists">Active Playlists</div>
|
||||||
<div class="tab" data-tab="config">Configuration</div>
|
<div class="tab" data-tab="config">Configuration</div>
|
||||||
<div class="tab" data-tab="endpoints">API Analytics</div>
|
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<!-- Dashboard Tab -->
|
<!-- Dashboard Tab -->
|
||||||
@@ -645,18 +644,12 @@
|
|||||||
|
|
||||||
<!-- Active Playlists Tab -->
|
<!-- Active Playlists Tab -->
|
||||||
<div class="tab-content" id="tab-playlists">
|
<div class="tab-content" id="tab-playlists">
|
||||||
<!-- Warning Banner (hidden by default) -->
|
|
||||||
<div id="matching-warning-banner" style="display:none;background:#f59e0b;color:#000;padding:16px;border-radius:8px;margin-bottom:16px;font-weight:600;text-align:center;box-shadow:0 4px 6px rgba(0,0,0,0.1);">
|
|
||||||
⚠️ TRACK MATCHING IN PROGRESS - Please wait for matching to complete before making changes to playlists or mappings!
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div class="card">
|
<div class="card">
|
||||||
<h2>
|
<h2>
|
||||||
Active Spotify Playlists
|
Active Spotify Playlists
|
||||||
<div class="actions">
|
<div class="actions">
|
||||||
<button onclick="matchAllPlaylists()" title="Match tracks for all playlists against your local library and external providers. This may take several minutes.">Match All Tracks</button>
|
<button onclick="matchAllPlaylists()">Match All Tracks</button>
|
||||||
<button onclick="refreshPlaylists()" title="Fetch the latest playlist data from Spotify without re-matching tracks.">Refresh All</button>
|
<button onclick="refreshPlaylists()">Refresh All</button>
|
||||||
<button onclick="refreshAndMatchAll()" title="Clear caches, fetch fresh data from Spotify, and match all tracks. This is a full rebuild and may take several minutes." style="background:var(--accent);border-color:var(--accent);">Refresh & Match All</button>
|
|
||||||
</div>
|
</div>
|
||||||
</h2>
|
</h2>
|
||||||
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
||||||
@@ -669,139 +662,20 @@
|
|||||||
<th>Spotify ID</th>
|
<th>Spotify ID</th>
|
||||||
<th>Tracks</th>
|
<th>Tracks</th>
|
||||||
<th>Completion</th>
|
<th>Completion</th>
|
||||||
|
<th>Lyrics</th>
|
||||||
<th>Cache Age</th>
|
<th>Cache Age</th>
|
||||||
<th>Actions</th>
|
<th>Actions</th>
|
||||||
</tr>
|
</tr>
|
||||||
</thead>
|
</thead>
|
||||||
<tbody id="playlist-table-body">
|
<tbody id="playlist-table-body">
|
||||||
<tr>
|
<tr>
|
||||||
<td colspan="6" class="loading">
|
<td colspan="7" class="loading">
|
||||||
<span class="spinner"></span> Loading playlists...
|
<span class="spinner"></span> Loading playlists...
|
||||||
</td>
|
</td>
|
||||||
</tr>
|
</tr>
|
||||||
</tbody>
|
</tbody>
|
||||||
</table>
|
</table>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<!-- Manual Track Mappings Section -->
|
|
||||||
<div class="card">
|
|
||||||
<h2>
|
|
||||||
Manual Track Mappings
|
|
||||||
<div class="actions">
|
|
||||||
<button onclick="fetchTrackMappings()">Refresh</button>
|
|
||||||
</div>
|
|
||||||
</h2>
|
|
||||||
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
|
||||||
Manual mappings override automatic matching for external providers (SquidWTF, Deezer, Qobuz). For local Jellyfin tracks, use the Spotify Import plugin instead.
|
|
||||||
</p>
|
|
||||||
<div id="mappings-summary" style="display: flex; gap: 20px; margin-bottom: 16px; padding: 12px; background: var(--bg-tertiary); border-radius: 6px;">
|
|
||||||
<div>
|
|
||||||
<span style="color: var(--text-secondary);">Total:</span>
|
|
||||||
<span style="font-weight: 600; margin-left: 8px;" id="mappings-total">0</span>
|
|
||||||
</div>
|
|
||||||
<div>
|
|
||||||
<span style="color: var(--text-secondary);">External:</span>
|
|
||||||
<span style="font-weight: 600; margin-left: 8px; color: var(--success);" id="mappings-external">0</span>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<table class="playlist-table">
|
|
||||||
<thead>
|
|
||||||
<tr>
|
|
||||||
<th>Playlist</th>
|
|
||||||
<th>Spotify ID</th>
|
|
||||||
<th>Type</th>
|
|
||||||
<th>Target</th>
|
|
||||||
<th>Created</th>
|
|
||||||
<th>Actions</th>
|
|
||||||
</tr>
|
|
||||||
</thead>
|
|
||||||
<tbody id="mappings-table-body">
|
|
||||||
<tr>
|
|
||||||
<td colspan="6" class="loading">
|
|
||||||
<span class="spinner"></span> Loading mappings...
|
|
||||||
</td>
|
|
||||||
</tr>
|
|
||||||
</tbody>
|
|
||||||
</table>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<!-- Missing Tracks Section -->
|
|
||||||
<div class="card">
|
|
||||||
<h2>
|
|
||||||
Missing Tracks (All Playlists)
|
|
||||||
<div class="actions">
|
|
||||||
<button onclick="fetchMissingTracks()">Refresh</button>
|
|
||||||
</div>
|
|
||||||
</h2>
|
|
||||||
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
|
||||||
Tracks that couldn't be matched locally or externally. Map them manually to add them to your playlists.
|
|
||||||
</p>
|
|
||||||
<div id="missing-summary" style="display: flex; gap: 20px; margin-bottom: 16px; padding: 12px; background: var(--bg-tertiary); border-radius: 6px;">
|
|
||||||
<div>
|
|
||||||
<span style="color: var(--text-secondary);">Total Missing:</span>
|
|
||||||
<span style="font-weight: 600; margin-left: 8px; color: var(--warning);" id="missing-total">0</span>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<table class="playlist-table">
|
|
||||||
<thead>
|
|
||||||
<tr>
|
|
||||||
<th>Playlist</th>
|
|
||||||
<th>Track</th>
|
|
||||||
<th>Artist</th>
|
|
||||||
<th>Album</th>
|
|
||||||
<th>Actions</th>
|
|
||||||
</tr>
|
|
||||||
</thead>
|
|
||||||
<tbody id="missing-tracks-table-body">
|
|
||||||
<tr>
|
|
||||||
<td colspan="5" class="loading">
|
|
||||||
<span class="spinner"></span> Loading missing tracks...
|
|
||||||
</td>
|
|
||||||
</tr>
|
|
||||||
</tbody>
|
|
||||||
</table>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<!-- Kept Downloads Section -->
|
|
||||||
<div class="card">
|
|
||||||
<h2>
|
|
||||||
Kept Downloads
|
|
||||||
<div class="actions">
|
|
||||||
<button onclick="fetchDownloads()">Refresh</button>
|
|
||||||
</div>
|
|
||||||
</h2>
|
|
||||||
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
|
||||||
Downloaded files stored permanently. Download or delete individual tracks.
|
|
||||||
</p>
|
|
||||||
<div id="downloads-summary" style="display: flex; gap: 20px; margin-bottom: 16px; padding: 12px; background: var(--bg-tertiary); border-radius: 6px;">
|
|
||||||
<div>
|
|
||||||
<span style="color: var(--text-secondary);">Total Files:</span>
|
|
||||||
<span style="font-weight: 600; margin-left: 8px; color: var(--accent);" id="downloads-count">0</span>
|
|
||||||
</div>
|
|
||||||
<div>
|
|
||||||
<span style="color: var(--text-secondary);">Total Size:</span>
|
|
||||||
<span style="font-weight: 600; margin-left: 8px; color: var(--accent);" id="downloads-size">0 B</span>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<table class="playlist-table">
|
|
||||||
<thead>
|
|
||||||
<tr>
|
|
||||||
<th>Artist</th>
|
|
||||||
<th>Album</th>
|
|
||||||
<th>File</th>
|
|
||||||
<th>Size</th>
|
|
||||||
<th>Actions</th>
|
|
||||||
</tr>
|
|
||||||
</thead>
|
|
||||||
<tbody id="downloads-table-body">
|
|
||||||
<tr>
|
|
||||||
<td colspan="5" class="loading">
|
|
||||||
<span class="spinner"></span> Loading downloads...
|
|
||||||
</td>
|
|
||||||
</tr>
|
|
||||||
</tbody>
|
|
||||||
</table>
|
|
||||||
</div>
|
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<!-- Configuration Tab -->
|
<!-- Configuration Tab -->
|
||||||
@@ -926,22 +800,6 @@
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div class="card">
|
|
||||||
<h2>Library Settings</h2>
|
|
||||||
<div class="config-section">
|
|
||||||
<div class="config-item">
|
|
||||||
<span class="label">Download Path (Cache)</span>
|
|
||||||
<span class="value" id="config-download-path">-</span>
|
|
||||||
<button onclick="openEditSetting('LIBRARY_DOWNLOAD_PATH', 'Download Path', 'text')">Edit</button>
|
|
||||||
</div>
|
|
||||||
<div class="config-item">
|
|
||||||
<span class="label">Kept Path (Favorited)</span>
|
|
||||||
<span class="value" id="config-kept-path">-</span>
|
|
||||||
<button onclick="openEditSetting('LIBRARY_KEPT_PATH', 'Kept Path', 'text')">Edit</button>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div class="card">
|
<div class="card">
|
||||||
<h2>Sync Schedule</h2>
|
<h2>Sync Schedule</h2>
|
||||||
<div class="config-section">
|
<div class="config-section">
|
||||||
@@ -981,85 +839,6 @@
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<!-- API Analytics Tab -->
|
|
||||||
<div class="tab-content" id="tab-endpoints">
|
|
||||||
<div class="card">
|
|
||||||
<h2>
|
|
||||||
API Endpoint Usage
|
|
||||||
<div class="actions">
|
|
||||||
<button onclick="fetchEndpointUsage()">Refresh</button>
|
|
||||||
<button class="danger" onclick="clearEndpointUsage()">Clear Data</button>
|
|
||||||
</div>
|
|
||||||
</h2>
|
|
||||||
<p style="color: var(--text-secondary); margin-bottom: 16px;">
|
|
||||||
Track which Jellyfin API endpoints are being called most frequently. Useful for debugging and understanding client behavior.
|
|
||||||
</p>
|
|
||||||
|
|
||||||
<div id="endpoints-summary" style="display: grid; grid-template-columns: repeat(auto-fit, minmax(200px, 1fr)); gap: 16px; margin-bottom: 20px;">
|
|
||||||
<div style="background: var(--bg-tertiary); padding: 16px; border-radius: 8px;">
|
|
||||||
<div style="color: var(--text-secondary); font-size: 0.85rem; margin-bottom: 4px;">Total Requests</div>
|
|
||||||
<div style="font-size: 1.8rem; font-weight: 600; color: var(--accent);" id="endpoints-total-requests">0</div>
|
|
||||||
</div>
|
|
||||||
<div style="background: var(--bg-tertiary); padding: 16px; border-radius: 8px;">
|
|
||||||
<div style="color: var(--text-secondary); font-size: 0.85rem; margin-bottom: 4px;">Unique Endpoints</div>
|
|
||||||
<div style="font-size: 1.8rem; font-weight: 600; color: var(--success);" id="endpoints-unique-count">0</div>
|
|
||||||
</div>
|
|
||||||
<div style="background: var(--bg-tertiary); padding: 16px; border-radius: 8px;">
|
|
||||||
<div style="color: var(--text-secondary); font-size: 0.85rem; margin-bottom: 4px;">Most Called</div>
|
|
||||||
<div style="font-size: 1.1rem; font-weight: 600; color: var(--text-primary); word-break: break-all;" id="endpoints-most-called">-</div>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div style="margin-bottom: 16px;">
|
|
||||||
<label style="display: block; margin-bottom: 8px; color: var(--text-secondary); font-size: 0.9rem;">Show Top</label>
|
|
||||||
<select id="endpoints-top-select" onchange="fetchEndpointUsage()" style="padding: 8px; background: var(--bg-tertiary); border: 1px solid var(--border); border-radius: 6px; color: var(--text-primary);">
|
|
||||||
<option value="25">Top 25</option>
|
|
||||||
<option value="50" selected>Top 50</option>
|
|
||||||
<option value="100">Top 100</option>
|
|
||||||
<option value="500">Top 500</option>
|
|
||||||
</select>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div style="max-height: 600px; overflow-y: auto;">
|
|
||||||
<table class="playlist-table">
|
|
||||||
<thead>
|
|
||||||
<tr>
|
|
||||||
<th style="width: 60px;">#</th>
|
|
||||||
<th>Endpoint</th>
|
|
||||||
<th style="width: 120px; text-align: right;">Requests</th>
|
|
||||||
<th style="width: 120px; text-align: right;">% of Total</th>
|
|
||||||
</tr>
|
|
||||||
</thead>
|
|
||||||
<tbody id="endpoints-table-body">
|
|
||||||
<tr>
|
|
||||||
<td colspan="4" class="loading">
|
|
||||||
<span class="spinner"></span> Loading endpoint usage data...
|
|
||||||
</td>
|
|
||||||
</tr>
|
|
||||||
</tbody>
|
|
||||||
</table>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div class="card">
|
|
||||||
<h2>About Endpoint Tracking</h2>
|
|
||||||
<p style="color: var(--text-secondary); line-height: 1.6;">
|
|
||||||
Allstarr logs every Jellyfin API endpoint call to help you understand how clients interact with your server.
|
|
||||||
This data is stored in <code style="background: var(--bg-tertiary); padding: 2px 6px; border-radius: 4px;">/app/cache/endpoint-usage/endpoints.csv</code>
|
|
||||||
and persists across restarts.
|
|
||||||
<br><br>
|
|
||||||
<strong>Common Endpoints:</strong>
|
|
||||||
<ul style="margin-top: 8px; margin-left: 20px;">
|
|
||||||
<li><code>/Users/{userId}/Items</code> - Browse library items</li>
|
|
||||||
<li><code>/Items/{itemId}</code> - Get item details</li>
|
|
||||||
<li><code>/Audio/{itemId}/stream</code> - Stream audio</li>
|
|
||||||
<li><code>/Sessions/Playing</code> - Report playback status</li>
|
|
||||||
<li><code>/Search/Hints</code> - Search functionality</li>
|
|
||||||
</ul>
|
|
||||||
</p>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<!-- Add Playlist Modal -->
|
<!-- Add Playlist Modal -->
|
||||||
@@ -1117,9 +896,9 @@
|
|||||||
<!-- Manual Track Mapping Modal -->
|
<!-- Manual Track Mapping Modal -->
|
||||||
<div class="modal" id="manual-map-modal">
|
<div class="modal" id="manual-map-modal">
|
||||||
<div class="modal-content" style="max-width: 600px;">
|
<div class="modal-content" style="max-width: 600px;">
|
||||||
<h3>Map Track to External Provider</h3>
|
<h3>Map Track</h3>
|
||||||
<p style="color: var(--text-secondary); margin-bottom: 16px;">
|
<p style="color: var(--text-secondary); margin-bottom: 16px;">
|
||||||
Map this track to an external provider (SquidWTF, Deezer, or Qobuz). For local Jellyfin tracks, use the Spotify Import plugin instead.
|
Map this track to either a local Jellyfin track or provide an external provider ID.
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
<!-- Track Info -->
|
<!-- Track Info -->
|
||||||
@@ -1131,8 +910,41 @@
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
<!-- Mapping Type Selection -->
|
||||||
|
<div class="form-group">
|
||||||
|
<label>Mapping Type</label>
|
||||||
|
<select id="map-type-select" onchange="toggleMappingType()" style="width: 100%;">
|
||||||
|
<option value="jellyfin">Map to Local Jellyfin Track</option>
|
||||||
|
<option value="external">Map to External Provider ID</option>
|
||||||
|
</select>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<!-- Jellyfin Mapping Section -->
|
||||||
|
<div id="jellyfin-mapping-section">
|
||||||
|
<div class="form-group">
|
||||||
|
<label>Search Jellyfin Tracks</label>
|
||||||
|
<input type="text" id="map-search-query" placeholder="Search by title, artist, or album..." oninput="searchJellyfinTracks()">
|
||||||
|
<small style="color: var(--text-secondary); display: block; margin-top: 4px;">
|
||||||
|
Tip: Use commas to search multiple terms (e.g., "It Ain't Easy, David Bowie")
|
||||||
|
</small>
|
||||||
|
</div>
|
||||||
|
<div style="text-align: center; color: var(--text-secondary); margin: 12px 0;">— OR —</div>
|
||||||
|
<div class="form-group">
|
||||||
|
<label>Paste Jellyfin Track URL</label>
|
||||||
|
<input type="text" id="map-jellyfin-url" placeholder="https://jellyfin.example.com/web/#/details?id=..." oninput="extractJellyfinId()">
|
||||||
|
<small style="color: var(--text-secondary); display: block; margin-top: 4px;">
|
||||||
|
Paste the full URL from your Jellyfin web interface
|
||||||
|
</small>
|
||||||
|
</div>
|
||||||
|
<div id="map-search-results" style="max-height: 300px; overflow-y: auto; margin-top: 12px;">
|
||||||
|
<p style="text-align: center; color: var(--text-secondary); padding: 20px;">
|
||||||
|
Type to search for local tracks or paste a Jellyfin URL...
|
||||||
|
</p>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
|
||||||
<!-- External Mapping Section -->
|
<!-- External Mapping Section -->
|
||||||
<div id="external-mapping-section">
|
<div id="external-mapping-section" style="display: none;">
|
||||||
<div class="form-group">
|
<div class="form-group">
|
||||||
<label>External Provider</label>
|
<label>External Provider</label>
|
||||||
<select id="map-external-provider" style="width: 100%;">
|
<select id="map-external-provider" style="width: 100%;">
|
||||||
@@ -1154,6 +966,7 @@
|
|||||||
|
|
||||||
<input type="hidden" id="map-playlist-name">
|
<input type="hidden" id="map-playlist-name">
|
||||||
<input type="hidden" id="map-spotify-id">
|
<input type="hidden" id="map-spotify-id">
|
||||||
|
<input type="hidden" id="map-selected-jellyfin-id">
|
||||||
<div class="modal-actions">
|
<div class="modal-actions">
|
||||||
<button onclick="closeModal('manual-map-modal')">Cancel</button>
|
<button onclick="closeModal('manual-map-modal')">Cancel</button>
|
||||||
<button class="primary" onclick="saveManualMapping()" id="map-save-btn" disabled>Save Mapping</button>
|
<button class="primary" onclick="saveManualMapping()" id="map-save-btn" disabled>Save Mapping</button>
|
||||||
@@ -1281,37 +1094,8 @@
|
|||||||
if (hash) {
|
if (hash) {
|
||||||
switchTab(hash);
|
switchTab(hash);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Start auto-refresh for playlists tab (every 5 seconds)
|
|
||||||
startPlaylistAutoRefresh();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// Auto-refresh functionality for playlists
|
|
||||||
let playlistAutoRefreshInterval = null;
|
|
||||||
|
|
||||||
function startPlaylistAutoRefresh() {
|
|
||||||
// Clear any existing interval
|
|
||||||
if (playlistAutoRefreshInterval) {
|
|
||||||
clearInterval(playlistAutoRefreshInterval);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Refresh every 5 seconds when on playlists tab
|
|
||||||
playlistAutoRefreshInterval = setInterval(() => {
|
|
||||||
const playlistsTab = document.getElementById('tab-playlists');
|
|
||||||
if (playlistsTab && playlistsTab.classList.contains('active')) {
|
|
||||||
// Silently refresh without showing loading state
|
|
||||||
fetchPlaylists(true);
|
|
||||||
}
|
|
||||||
}, 5000);
|
|
||||||
}
|
|
||||||
|
|
||||||
function stopPlaylistAutoRefresh() {
|
|
||||||
if (playlistAutoRefreshInterval) {
|
|
||||||
clearInterval(playlistAutoRefreshInterval);
|
|
||||||
playlistAutoRefreshInterval = null;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Toast notification
|
// Toast notification
|
||||||
function showToast(message, type = 'success', duration = 3000) {
|
function showToast(message, type = 'success', duration = 3000) {
|
||||||
const toast = document.createElement('div');
|
const toast = document.createElement('div');
|
||||||
@@ -1451,7 +1235,7 @@
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async function fetchPlaylists(silent = false) {
|
async function fetchPlaylists() {
|
||||||
try {
|
try {
|
||||||
const res = await fetch('/api/admin/playlists');
|
const res = await fetch('/api/admin/playlists');
|
||||||
const data = await res.json();
|
const data = await res.json();
|
||||||
@@ -1459,9 +1243,7 @@
|
|||||||
const tbody = document.getElementById('playlist-table-body');
|
const tbody = document.getElementById('playlist-table-body');
|
||||||
|
|
||||||
if (data.playlists.length === 0) {
|
if (data.playlists.length === 0) {
|
||||||
if (!silent) {
|
tbody.innerHTML = '<tr><td colspan="7" style="text-align:center;color:var(--text-secondary);padding:40px;">No playlists configured. Link playlists from the Jellyfin Playlists tab.</td></tr>';
|
||||||
tbody.innerHTML = '<tr><td colspan="6" style="text-align:center;color:var(--text-secondary);padding:40px;">No playlists configured. Link playlists from the Jellyfin Playlists tab.</td></tr>';
|
|
||||||
}
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1529,10 +1311,20 @@
|
|||||||
<span style="font-size:0.85rem;color:${completionColor};font-weight:500;min-width:40px;">${completionPct}%</span>
|
<span style="font-size:0.85rem;color:${completionColor};font-weight:500;min-width:40px;">${completionPct}%</span>
|
||||||
</div>
|
</div>
|
||||||
</td>
|
</td>
|
||||||
|
<td>
|
||||||
|
${p.lyricsTotal > 0 ? `
|
||||||
|
<div style="display:flex;align-items:center;gap:8px;">
|
||||||
|
<div style="flex:1;background:var(--bg-tertiary);height:12px;border-radius:6px;overflow:hidden;">
|
||||||
|
<div style="width:${p.lyricsPercentage}%;height:100%;background:${p.lyricsPercentage === 100 ? '#10b981' : '#3b82f6'};transition:width 0.3s;" title="${p.lyricsCached} lyrics cached"></div>
|
||||||
|
</div>
|
||||||
|
<span style="font-size:0.85rem;color:var(--text-secondary);font-weight:500;min-width:40px;">${p.lyricsPercentage}%</span>
|
||||||
|
</div>
|
||||||
|
` : '<span style="color:var(--text-secondary);font-size:0.85rem;">-</span>'}
|
||||||
|
</td>
|
||||||
<td class="cache-age">${p.cacheAge || '-'}</td>
|
<td class="cache-age">${p.cacheAge || '-'}</td>
|
||||||
<td>
|
<td>
|
||||||
<button onclick="clearPlaylistCache('${escapeJs(p.name)}')">Clear Cache & Rebuild</button>
|
|
||||||
<button onclick="matchPlaylistTracks('${escapeJs(p.name)}')">Match Tracks</button>
|
<button onclick="matchPlaylistTracks('${escapeJs(p.name)}')">Match Tracks</button>
|
||||||
|
<button onclick="prefetchLyrics('${escapeJs(p.name)}')">Prefetch Lyrics</button>
|
||||||
<button onclick="viewTracks('${escapeJs(p.name)}')">View</button>
|
<button onclick="viewTracks('${escapeJs(p.name)}')">View</button>
|
||||||
<button class="danger" onclick="removePlaylist('${escapeJs(p.name)}')">Remove</button>
|
<button class="danger" onclick="removePlaylist('${escapeJs(p.name)}')">Remove</button>
|
||||||
</td>
|
</td>
|
||||||
@@ -1545,232 +1337,6 @@
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async function fetchTrackMappings() {
|
|
||||||
try {
|
|
||||||
const res = await fetch('/api/admin/mappings/tracks');
|
|
||||||
const data = await res.json();
|
|
||||||
|
|
||||||
// Update summary (only external now)
|
|
||||||
document.getElementById('mappings-total').textContent = data.externalCount || 0;
|
|
||||||
document.getElementById('mappings-external').textContent = data.externalCount || 0;
|
|
||||||
|
|
||||||
const tbody = document.getElementById('mappings-table-body');
|
|
||||||
|
|
||||||
if (data.mappings.length === 0) {
|
|
||||||
tbody.innerHTML = '<tr><td colspan="6" style="text-align:center;color:var(--text-secondary);padding:40px;">No manual mappings found.</td></tr>';
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Filter to only show external mappings
|
|
||||||
const externalMappings = data.mappings.filter(m => m.type === 'external');
|
|
||||||
|
|
||||||
if (externalMappings.length === 0) {
|
|
||||||
tbody.innerHTML = '<tr><td colspan="6" style="text-align:center;color:var(--text-secondary);padding:40px;">No external mappings found. Local Jellyfin mappings should be managed via Spotify Import plugin.</td></tr>';
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
tbody.innerHTML = externalMappings.map((m, index) => {
|
|
||||||
const typeColor = 'var(--success)';
|
|
||||||
const typeBadge = `<span style="display:inline-block;padding:2px 8px;border-radius:4px;font-size:0.8rem;background:${typeColor}20;color:${typeColor};font-weight:500;">external</span>`;
|
|
||||||
|
|
||||||
const targetDisplay = `<span style="font-family:monospace;font-size:0.85rem;color:var(--success);">${m.externalProvider}/${m.externalId}</span>`;
|
|
||||||
|
|
||||||
const createdDate = m.createdAt ? new Date(m.createdAt).toLocaleString() : '-';
|
|
||||||
|
|
||||||
return `
|
|
||||||
<tr>
|
|
||||||
<td><strong>${escapeHtml(m.playlist)}</strong></td>
|
|
||||||
<td style="font-family:monospace;font-size:0.85rem;color:var(--text-secondary);">${m.spotifyId}</td>
|
|
||||||
<td>${typeBadge}</td>
|
|
||||||
<td>${targetDisplay}</td>
|
|
||||||
<td style="color:var(--text-secondary);font-size:0.85rem;">${createdDate}</td>
|
|
||||||
<td>
|
|
||||||
<button class="danger delete-mapping-btn" style="padding:4px 12px;font-size:0.8rem;" data-playlist="${escapeHtml(m.playlist)}" data-spotify-id="${m.spotifyId}">Remove</button>
|
|
||||||
</td>
|
|
||||||
</tr>
|
|
||||||
`;
|
|
||||||
}).join('');
|
|
||||||
|
|
||||||
// Add event listeners to all delete buttons
|
|
||||||
document.querySelectorAll('.delete-mapping-btn').forEach(btn => {
|
|
||||||
btn.addEventListener('click', function() {
|
|
||||||
const playlist = this.getAttribute('data-playlist');
|
|
||||||
const spotifyId = this.getAttribute('data-spotify-id');
|
|
||||||
deleteTrackMapping(playlist, spotifyId);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to fetch track mappings:', error);
|
|
||||||
showToast('Failed to fetch track mappings', 'error');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function deleteTrackMapping(playlist, spotifyId) {
|
|
||||||
if (!confirm(`Remove manual external mapping for ${spotifyId} in playlist "${playlist}"?\n\nThis will:\n• Delete the manual mapping from the cache\n• Allow the track to be matched automatically again\n• The track may be re-matched with potentially better results\n\nThis action cannot be undone.`)) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
try {
|
|
||||||
const res = await fetch(`/api/admin/mappings/tracks?playlist=${encodeURIComponent(playlist)}&spotifyId=${encodeURIComponent(spotifyId)}`, {
|
|
||||||
method: 'DELETE'
|
|
||||||
});
|
|
||||||
|
|
||||||
if (res.ok) {
|
|
||||||
showToast('Mapping removed successfully', 'success');
|
|
||||||
await fetchTrackMappings();
|
|
||||||
} else {
|
|
||||||
const error = await res.json();
|
|
||||||
showToast(error.error || 'Failed to remove mapping', 'error');
|
|
||||||
}
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to delete mapping:', error);
|
|
||||||
showToast('Failed to remove mapping', 'error');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function fetchMissingTracks() {
|
|
||||||
try {
|
|
||||||
const res = await fetch('/api/admin/playlists');
|
|
||||||
const data = await res.json();
|
|
||||||
|
|
||||||
const tbody = document.getElementById('missing-tracks-table-body');
|
|
||||||
const missingTracks = [];
|
|
||||||
|
|
||||||
// Collect all missing tracks from all playlists
|
|
||||||
for (const playlist of data.playlists) {
|
|
||||||
if (playlist.externalMissing > 0) {
|
|
||||||
// Fetch tracks for this playlist
|
|
||||||
try {
|
|
||||||
const tracksRes = await fetch(`/api/admin/playlists/${encodeURIComponent(playlist.name)}/tracks`);
|
|
||||||
const tracksData = await tracksRes.json();
|
|
||||||
|
|
||||||
// Filter to only missing tracks (isLocal === null)
|
|
||||||
const missing = tracksData.tracks.filter(t => t.isLocal === null);
|
|
||||||
missing.forEach(t => {
|
|
||||||
missingTracks.push({
|
|
||||||
playlist: playlist.name,
|
|
||||||
...t
|
|
||||||
});
|
|
||||||
});
|
|
||||||
} catch (err) {
|
|
||||||
console.error(`Failed to fetch tracks for ${playlist.name}:`, err);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Update summary
|
|
||||||
document.getElementById('missing-total').textContent = missingTracks.length;
|
|
||||||
|
|
||||||
if (missingTracks.length === 0) {
|
|
||||||
tbody.innerHTML = '<tr><td colspan="5" style="text-align:center;color:var(--text-secondary);padding:40px;">🎉 No missing tracks! All tracks are matched.</td></tr>';
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
tbody.innerHTML = missingTracks.map(t => {
|
|
||||||
const artist = (t.artists && t.artists.length > 0) ? t.artists.join(', ') : '';
|
|
||||||
const searchQuery = `${t.title} ${artist}`;
|
|
||||||
return `
|
|
||||||
<tr>
|
|
||||||
<td><strong>${escapeHtml(t.playlist)}</strong></td>
|
|
||||||
<td>${escapeHtml(t.title)}</td>
|
|
||||||
<td>${escapeHtml(artist)}</td>
|
|
||||||
<td style="color:var(--text-secondary);">${t.album ? escapeHtml(t.album) : '-'}</td>
|
|
||||||
<td>
|
|
||||||
<button onclick="searchProvider('${escapeJs(searchQuery)}', 'squidwtf')"
|
|
||||||
style="margin-right:4px;font-size:0.75rem;padding:4px 8px;background:#3b82f6;border-color:#3b82f6;color:white;">🔍 Search</button>
|
|
||||||
<button onclick="openMapToLocal('${escapeJs(t.playlist)}', '${escapeJs(t.spotifyId)}', '${escapeJs(t.title)}', '${escapeJs(artist)}')"
|
|
||||||
style="margin-right:4px;font-size:0.75rem;padding:4px 8px;background:var(--success);border-color:var(--success);">Map to Local</button>
|
|
||||||
<button onclick="openMapToExternal('${escapeJs(t.playlist)}', '${escapeJs(t.spotifyId)}', '${escapeJs(t.title)}', '${escapeJs(artist)}')"
|
|
||||||
style="font-size:0.75rem;padding:4px 8px;background:var(--warning);border-color:var(--warning);">Map to External</button>
|
|
||||||
</td>
|
|
||||||
</tr>
|
|
||||||
`;
|
|
||||||
}).join('');
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to fetch missing tracks:', error);
|
|
||||||
showToast('Failed to fetch missing tracks', 'error');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function fetchDownloads() {
|
|
||||||
try {
|
|
||||||
const res = await fetch('/api/admin/downloads');
|
|
||||||
const data = await res.json();
|
|
||||||
|
|
||||||
const tbody = document.getElementById('downloads-table-body');
|
|
||||||
|
|
||||||
// Update summary
|
|
||||||
document.getElementById('downloads-count').textContent = data.count;
|
|
||||||
document.getElementById('downloads-size').textContent = data.totalSizeFormatted;
|
|
||||||
|
|
||||||
if (data.count === 0) {
|
|
||||||
tbody.innerHTML = '<tr><td colspan="5" style="text-align:center;color:var(--text-secondary);padding:40px;">No downloaded files found.</td></tr>';
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
tbody.innerHTML = data.files.map(f => {
|
|
||||||
return `
|
|
||||||
<tr data-path="${escapeHtml(f.path)}">
|
|
||||||
<td><strong>${escapeHtml(f.artist)}</strong></td>
|
|
||||||
<td>${escapeHtml(f.album)}</td>
|
|
||||||
<td style="font-family:monospace;font-size:0.85rem;">${escapeHtml(f.fileName)}</td>
|
|
||||||
<td style="color:var(--text-secondary);">${f.sizeFormatted}</td>
|
|
||||||
<td>
|
|
||||||
<button onclick="downloadFile('${escapeJs(f.path)}')"
|
|
||||||
style="margin-right:4px;font-size:0.75rem;padding:4px 8px;background:var(--accent);border-color:var(--accent);">Download</button>
|
|
||||||
<button onclick="deleteDownload('${escapeJs(f.path)}')"
|
|
||||||
class="danger" style="font-size:0.75rem;padding:4px 8px;">Delete</button>
|
|
||||||
</td>
|
|
||||||
</tr>
|
|
||||||
`;
|
|
||||||
}).join('');
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to fetch downloads:', error);
|
|
||||||
showToast('Failed to fetch downloads', 'error');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function downloadFile(path) {
|
|
||||||
try {
|
|
||||||
window.open(`/api/admin/downloads/file?path=${encodeURIComponent(path)}`, '_blank');
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to download file:', error);
|
|
||||||
showToast('Failed to download file', 'error');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function deleteDownload(path) {
|
|
||||||
if (!confirm(`Delete this file?\n\n${path}\n\nThis action cannot be undone.`)) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
try {
|
|
||||||
const res = await fetch(`/api/admin/downloads?path=${encodeURIComponent(path)}`, {
|
|
||||||
method: 'DELETE'
|
|
||||||
});
|
|
||||||
|
|
||||||
if (res.ok) {
|
|
||||||
showToast('File deleted successfully', 'success');
|
|
||||||
|
|
||||||
// Remove the row immediately for live update
|
|
||||||
const escapedPath = path.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
|
|
||||||
const row = document.querySelector(`tr[data-path="${escapedPath}"]`);
|
|
||||||
if (row) {
|
|
||||||
row.remove();
|
|
||||||
}
|
|
||||||
|
|
||||||
// Refresh to update counts
|
|
||||||
await fetchDownloads();
|
|
||||||
} else {
|
|
||||||
const error = await res.json();
|
|
||||||
showToast(error.error || 'Failed to delete file', 'error');
|
|
||||||
}
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to delete file:', error);
|
|
||||||
showToast('Failed to delete file', 'error');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function fetchConfig() {
|
async function fetchConfig() {
|
||||||
try {
|
try {
|
||||||
const res = await fetch('/api/admin/config');
|
const res = await fetch('/api/admin/config');
|
||||||
@@ -1812,10 +1378,6 @@
|
|||||||
document.getElementById('config-jellyfin-user-id').textContent = data.jellyfin.userId || '(not set)';
|
document.getElementById('config-jellyfin-user-id').textContent = data.jellyfin.userId || '(not set)';
|
||||||
document.getElementById('config-jellyfin-library-id').textContent = data.jellyfin.libraryId || '-';
|
document.getElementById('config-jellyfin-library-id').textContent = data.jellyfin.libraryId || '-';
|
||||||
|
|
||||||
// Library settings
|
|
||||||
document.getElementById('config-download-path').textContent = data.library?.downloadPath || './downloads';
|
|
||||||
document.getElementById('config-kept-path').textContent = data.library?.keptPath || '/app/kept';
|
|
||||||
|
|
||||||
// Sync settings
|
// Sync settings
|
||||||
const syncHour = data.spotifyImport.syncStartHour;
|
const syncHour = data.spotifyImport.syncStartHour;
|
||||||
const syncMin = data.spotifyImport.syncStartMinute;
|
const syncMin = data.spotifyImport.syncStartMinute;
|
||||||
@@ -2019,40 +1581,8 @@
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async function clearPlaylistCache(name) {
|
|
||||||
if (!confirm(`Clear cache and rebuild for "${name}"?\n\nThis will:\n• Clear Redis cache\n• Delete file caches\n• Rebuild with latest Spotify IDs\n\nThis may take a minute.`)) return;
|
|
||||||
|
|
||||||
try {
|
|
||||||
// Show warning banner
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'block';
|
|
||||||
|
|
||||||
showToast(`Clearing cache for ${name}...`, 'info');
|
|
||||||
const res = await fetch(`/api/admin/playlists/${encodeURIComponent(name)}/clear-cache`, { method: 'POST' });
|
|
||||||
const data = await res.json();
|
|
||||||
|
|
||||||
if (res.ok) {
|
|
||||||
showToast(`✓ ${data.message} (Cleared ${data.clearedKeys} cache keys, ${data.clearedFiles} files)`, 'success', 5000);
|
|
||||||
// Refresh the playlists table after a delay to show updated counts
|
|
||||||
setTimeout(() => {
|
|
||||||
fetchPlaylists();
|
|
||||||
// Hide warning banner after refresh
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}, 3000);
|
|
||||||
} else {
|
|
||||||
showToast(data.error || 'Failed to clear cache', 'error');
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
|
||||||
} catch (error) {
|
|
||||||
showToast('Failed to clear cache', 'error');
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function matchPlaylistTracks(name) {
|
async function matchPlaylistTracks(name) {
|
||||||
try {
|
try {
|
||||||
// Show warning banner
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'block';
|
|
||||||
|
|
||||||
showToast(`Matching tracks for ${name}...`, 'success');
|
showToast(`Matching tracks for ${name}...`, 'success');
|
||||||
const res = await fetch(`/api/admin/playlists/${encodeURIComponent(name)}/match`, { method: 'POST' });
|
const res = await fetch(`/api/admin/playlists/${encodeURIComponent(name)}/match`, { method: 'POST' });
|
||||||
const data = await res.json();
|
const data = await res.json();
|
||||||
@@ -2060,18 +1590,12 @@
|
|||||||
if (res.ok) {
|
if (res.ok) {
|
||||||
showToast(`✓ ${data.message}`, 'success');
|
showToast(`✓ ${data.message}`, 'success');
|
||||||
// Refresh the playlists table after a delay to show updated counts
|
// Refresh the playlists table after a delay to show updated counts
|
||||||
setTimeout(() => {
|
setTimeout(fetchPlaylists, 2000);
|
||||||
fetchPlaylists();
|
|
||||||
// Hide warning banner after refresh
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}, 2000);
|
|
||||||
} else {
|
} else {
|
||||||
showToast(data.error || 'Failed to match tracks', 'error');
|
showToast(data.error || 'Failed to match tracks', 'error');
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
showToast('Failed to match tracks', 'error');
|
showToast('Failed to match tracks', 'error');
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2079,9 +1603,6 @@
|
|||||||
if (!confirm('Match tracks for ALL playlists? This may take a few minutes.')) return;
|
if (!confirm('Match tracks for ALL playlists? This may take a few minutes.')) return;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
// Show warning banner
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'block';
|
|
||||||
|
|
||||||
showToast('Matching tracks for all playlists...', 'success');
|
showToast('Matching tracks for all playlists...', 'success');
|
||||||
const res = await fetch('/api/admin/playlists/match-all', { method: 'POST' });
|
const res = await fetch('/api/admin/playlists/match-all', { method: 'POST' });
|
||||||
const data = await res.json();
|
const data = await res.json();
|
||||||
@@ -2089,68 +1610,32 @@
|
|||||||
if (res.ok) {
|
if (res.ok) {
|
||||||
showToast(`✓ ${data.message}`, 'success');
|
showToast(`✓ ${data.message}`, 'success');
|
||||||
// Refresh the playlists table after a delay to show updated counts
|
// Refresh the playlists table after a delay to show updated counts
|
||||||
setTimeout(() => {
|
setTimeout(fetchPlaylists, 2000);
|
||||||
fetchPlaylists();
|
|
||||||
// Hide warning banner after refresh
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}, 2000);
|
|
||||||
} else {
|
} else {
|
||||||
showToast(data.error || 'Failed to match tracks', 'error');
|
showToast(data.error || 'Failed to match tracks', 'error');
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
showToast('Failed to match tracks', 'error');
|
showToast('Failed to match tracks', 'error');
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async function refreshAndMatchAll() {
|
async function prefetchLyrics(name) {
|
||||||
if (!confirm('Clear caches, refresh from Spotify, and match all tracks?\n\nThis will:\n• Clear all playlist caches\n• Fetch fresh data from Spotify\n• Match all tracks against local library and external providers\n\nThis may take several minutes.')) return;
|
|
||||||
|
|
||||||
try {
|
try {
|
||||||
// Show warning banner
|
showToast(`Prefetching lyrics for ${name}...`, 'info', 5000);
|
||||||
document.getElementById('matching-warning-banner').style.display = 'block';
|
const res = await fetch(`/api/admin/playlists/${encodeURIComponent(name)}/prefetch-lyrics`, { method: 'POST' });
|
||||||
|
|
||||||
showToast('Starting full refresh and match...', 'info', 3000);
|
|
||||||
|
|
||||||
// Step 1: Clear all caches
|
|
||||||
showToast('Step 1/3: Clearing caches...', 'info', 2000);
|
|
||||||
await fetch('/api/admin/cache/clear', { method: 'POST' });
|
|
||||||
|
|
||||||
// Wait for cache to be fully cleared
|
|
||||||
await new Promise(resolve => setTimeout(resolve, 2000));
|
|
||||||
|
|
||||||
// Step 2: Refresh playlists from Spotify
|
|
||||||
showToast('Step 2/3: Fetching from Spotify...', 'info', 2000);
|
|
||||||
await fetch('/api/admin/playlists/refresh', { method: 'POST' });
|
|
||||||
|
|
||||||
// Wait for Spotify fetch to complete
|
|
||||||
await new Promise(resolve => setTimeout(resolve, 5000));
|
|
||||||
|
|
||||||
// Step 3: Match all tracks
|
|
||||||
showToast('Step 3/3: Matching all tracks (this may take several minutes)...', 'info', 3000);
|
|
||||||
const res = await fetch('/api/admin/playlists/match-all', { method: 'POST' });
|
|
||||||
const data = await res.json();
|
const data = await res.json();
|
||||||
|
|
||||||
if (res.ok) {
|
if (res.ok) {
|
||||||
showToast(`✓ Full refresh and match complete!`, 'success', 5000);
|
const summary = `Fetched: ${data.fetched}, Cached: ${data.cached}, Missing: ${data.missing}`;
|
||||||
// Refresh the playlists table after a delay
|
showToast(`✓ Lyrics prefetch complete for ${name}. ${summary}`, 'success', 8000);
|
||||||
setTimeout(() => {
|
|
||||||
fetchPlaylists();
|
|
||||||
// Hide warning banner after refresh
|
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}, 3000);
|
|
||||||
} else {
|
} else {
|
||||||
showToast(data.error || 'Failed to match tracks', 'error');
|
showToast(data.error || 'Failed to prefetch lyrics', 'error');
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
showToast('Failed to complete refresh and match', 'error');
|
showToast('Failed to prefetch lyrics', 'error');
|
||||||
document.getElementById('matching-warning-banner').style.display = 'none';
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
async function searchProvider(query, provider) {
|
async function searchProvider(query, provider) {
|
||||||
// Use SquidWTF HiFi API with round-robin base URLs for all searches
|
// Use SquidWTF HiFi API with round-robin base URLs for all searches
|
||||||
// Get a random base URL from the backend
|
// Get a random base URL from the backend
|
||||||
@@ -2706,6 +2191,34 @@
|
|||||||
document.getElementById('map-save-btn').disabled = false;
|
document.getElementById('map-save-btn').disabled = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Toggle between Jellyfin and external mapping modes
|
||||||
|
function toggleMappingType() {
|
||||||
|
const mappingType = document.getElementById('map-type-select').value;
|
||||||
|
const jellyfinSection = document.getElementById('jellyfin-mapping-section');
|
||||||
|
const externalSection = document.getElementById('external-mapping-section');
|
||||||
|
const saveBtn = document.getElementById('map-save-btn');
|
||||||
|
|
||||||
|
if (mappingType === 'jellyfin') {
|
||||||
|
jellyfinSection.style.display = 'block';
|
||||||
|
externalSection.style.display = 'none';
|
||||||
|
// Reset external fields
|
||||||
|
document.getElementById('map-external-id').value = '';
|
||||||
|
// Check if Jellyfin track is selected
|
||||||
|
const jellyfinId = document.getElementById('map-selected-jellyfin-id').value;
|
||||||
|
saveBtn.disabled = !jellyfinId;
|
||||||
|
} else {
|
||||||
|
jellyfinSection.style.display = 'none';
|
||||||
|
externalSection.style.display = 'block';
|
||||||
|
// Reset Jellyfin fields
|
||||||
|
document.getElementById('map-search-query').value = '';
|
||||||
|
document.getElementById('map-jellyfin-url').value = '';
|
||||||
|
document.getElementById('map-selected-jellyfin-id').value = '';
|
||||||
|
document.getElementById('map-search-results').innerHTML = '<p style="text-align: center; color: var(--text-secondary); padding: 20px;">Enter an external provider ID above</p>';
|
||||||
|
// Check if external mapping is valid
|
||||||
|
validateExternalMapping();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Validate external mapping input
|
// Validate external mapping input
|
||||||
function validateExternalMapping() {
|
function validateExternalMapping() {
|
||||||
const externalId = document.getElementById('map-external-id').value.trim();
|
const externalId = document.getElementById('map-external-id').value.trim();
|
||||||
@@ -2715,7 +2228,7 @@
|
|||||||
saveBtn.disabled = !externalId;
|
saveBtn.disabled = !externalId;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Open manual mapping modal (external only)
|
// Update the openManualMap function to reset the modal state
|
||||||
function openManualMap(playlistName, position, title, artist, spotifyId) {
|
function openManualMap(playlistName, position, title, artist, spotifyId) {
|
||||||
document.getElementById('map-playlist-name').value = playlistName;
|
document.getElementById('map-playlist-name').value = playlistName;
|
||||||
document.getElementById('map-position').textContent = position + 1;
|
document.getElementById('map-position').textContent = position + 1;
|
||||||
@@ -2723,38 +2236,74 @@
|
|||||||
document.getElementById('map-spotify-artist').textContent = artist;
|
document.getElementById('map-spotify-artist').textContent = artist;
|
||||||
document.getElementById('map-spotify-id').value = spotifyId;
|
document.getElementById('map-spotify-id').value = spotifyId;
|
||||||
|
|
||||||
// Reset fields
|
// Reset to Jellyfin mapping mode
|
||||||
|
document.getElementById('map-type-select').value = 'jellyfin';
|
||||||
|
document.getElementById('jellyfin-mapping-section').style.display = 'block';
|
||||||
|
document.getElementById('external-mapping-section').style.display = 'none';
|
||||||
|
|
||||||
|
// Reset all fields
|
||||||
|
document.getElementById('map-search-query').value = '';
|
||||||
|
document.getElementById('map-jellyfin-url').value = '';
|
||||||
|
document.getElementById('map-selected-jellyfin-id').value = '';
|
||||||
document.getElementById('map-external-id').value = '';
|
document.getElementById('map-external-id').value = '';
|
||||||
document.getElementById('map-external-provider').value = 'SquidWTF';
|
document.getElementById('map-external-provider').value = 'SquidWTF';
|
||||||
document.getElementById('map-save-btn').disabled = true;
|
document.getElementById('map-save-btn').disabled = true;
|
||||||
|
document.getElementById('map-search-results').innerHTML = '<p style="text-align: center; color: var(--text-secondary); padding: 20px;">Type to search for local tracks or paste a Jellyfin URL...</p>';
|
||||||
|
|
||||||
openModal('manual-map-modal');
|
openModal('manual-map-modal');
|
||||||
}
|
}
|
||||||
|
|
||||||
// Alias for backward compatibility
|
// Open external mapping modal (pre-set to external mode)
|
||||||
function openExternalMap(playlistName, position, title, artist, spotifyId) {
|
function openExternalMap(playlistName, position, title, artist, spotifyId) {
|
||||||
openManualMap(playlistName, position, title, artist, spotifyId);
|
document.getElementById('map-playlist-name').value = playlistName;
|
||||||
|
document.getElementById('map-position').textContent = position + 1;
|
||||||
|
document.getElementById('map-spotify-title').textContent = title;
|
||||||
|
document.getElementById('map-spotify-artist').textContent = artist;
|
||||||
|
document.getElementById('map-spotify-id').value = spotifyId;
|
||||||
|
|
||||||
|
// Set to external mapping mode
|
||||||
|
document.getElementById('map-type-select').value = 'external';
|
||||||
|
document.getElementById('jellyfin-mapping-section').style.display = 'none';
|
||||||
|
document.getElementById('external-mapping-section').style.display = 'block';
|
||||||
|
|
||||||
|
// Reset all fields
|
||||||
|
document.getElementById('map-search-query').value = '';
|
||||||
|
document.getElementById('map-jellyfin-url').value = '';
|
||||||
|
document.getElementById('map-selected-jellyfin-id').value = '';
|
||||||
|
document.getElementById('map-external-id').value = '';
|
||||||
|
document.getElementById('map-external-provider').value = 'SquidWTF';
|
||||||
|
document.getElementById('map-save-btn').disabled = true;
|
||||||
|
document.getElementById('map-search-results').innerHTML = '<p style="text-align: center; color: var(--text-secondary); padding: 20px;">Enter an external provider ID above</p>';
|
||||||
|
|
||||||
|
openModal('manual-map-modal');
|
||||||
}
|
}
|
||||||
|
|
||||||
// Save manual mapping (external only)
|
// Update the saveManualMapping function to handle both types
|
||||||
async function saveManualMapping() {
|
async function saveManualMapping() {
|
||||||
const playlistName = document.getElementById('map-playlist-name').value;
|
const playlistName = document.getElementById('map-playlist-name').value;
|
||||||
const spotifyId = document.getElementById('map-spotify-id').value;
|
const spotifyId = document.getElementById('map-spotify-id').value;
|
||||||
|
const mappingType = document.getElementById('map-type-select').value;
|
||||||
const position = parseInt(document.getElementById('map-position').textContent) - 1; // Convert back to 0-indexed
|
const position = parseInt(document.getElementById('map-position').textContent) - 1; // Convert back to 0-indexed
|
||||||
|
|
||||||
|
let requestBody = { spotifyId };
|
||||||
|
|
||||||
|
if (mappingType === 'jellyfin') {
|
||||||
|
const jellyfinId = document.getElementById('map-selected-jellyfin-id').value;
|
||||||
|
if (!jellyfinId) {
|
||||||
|
showToast('Please select a track', 'error');
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
requestBody.jellyfinId = jellyfinId;
|
||||||
|
} else {
|
||||||
const externalProvider = document.getElementById('map-external-provider').value;
|
const externalProvider = document.getElementById('map-external-provider').value;
|
||||||
const externalId = document.getElementById('map-external-id').value.trim();
|
const externalId = document.getElementById('map-external-id').value.trim();
|
||||||
|
|
||||||
if (!externalId) {
|
if (!externalId) {
|
||||||
showToast('Please enter an external provider ID', 'error');
|
showToast('Please enter an external provider ID', 'error');
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
requestBody.externalProvider = externalProvider;
|
||||||
const requestBody = {
|
requestBody.externalId = externalId;
|
||||||
spotifyId,
|
}
|
||||||
externalProvider,
|
|
||||||
externalId
|
|
||||||
};
|
|
||||||
|
|
||||||
// Show loading state
|
// Show loading state
|
||||||
const saveBtn = document.getElementById('map-save-btn');
|
const saveBtn = document.getElementById('map-save-btn');
|
||||||
@@ -2777,7 +2326,8 @@
|
|||||||
const data = await res.json();
|
const data = await res.json();
|
||||||
|
|
||||||
if (res.ok) {
|
if (res.ok) {
|
||||||
showToast(`✓ Track mapped to ${requestBody.externalProvider} - rebuilding playlist...`, 'success');
|
const mappingTypeText = mappingType === 'jellyfin' ? 'local Jellyfin track' : `${requestBody.externalProvider} ID`;
|
||||||
|
showToast(`✓ Track mapped to ${mappingTypeText} - rebuilding playlist...`, 'success');
|
||||||
closeModal('manual-map-modal');
|
closeModal('manual-map-modal');
|
||||||
|
|
||||||
// Show rebuilding indicator
|
// Show rebuilding indicator
|
||||||
@@ -2785,15 +2335,27 @@
|
|||||||
|
|
||||||
// Show detailed info toast after a moment
|
// Show detailed info toast after a moment
|
||||||
setTimeout(() => {
|
setTimeout(() => {
|
||||||
|
if (mappingType === 'jellyfin') {
|
||||||
|
showToast('🔄 Rebuilding playlist with your local track mapping...', 'info', 8000);
|
||||||
|
} else {
|
||||||
showToast(`🔄 Rebuilding playlist with your ${requestBody.externalProvider} mapping...`, 'info', 8000);
|
showToast(`🔄 Rebuilding playlist with your ${requestBody.externalProvider} mapping...`, 'info', 8000);
|
||||||
|
}
|
||||||
}, 1000);
|
}, 1000);
|
||||||
|
|
||||||
// Update the track in the UI without refreshing
|
// Update the track in the UI without refreshing
|
||||||
const trackItem = document.querySelector(`.track-item[data-position="${position}"]`);
|
const trackItem = document.querySelector(`.track-item[data-position="${position}"]`);
|
||||||
if (trackItem) {
|
if (trackItem) {
|
||||||
const titleEl = trackItem.querySelector('.track-info h4');
|
const titleEl = trackItem.querySelector('.track-info h4');
|
||||||
if (titleEl) {
|
if (titleEl && mappingType === 'jellyfin' && data.track) {
|
||||||
// Update status badge to show provider
|
// For Jellyfin mappings, update with actual track info
|
||||||
|
const titleText = data.track.title;
|
||||||
|
const newStatusBadge = '<span class="status-badge success" style="font-size:0.75rem;padding:2px 8px;margin-left:8px;"><span class="status-dot"></span>Local</span>';
|
||||||
|
titleEl.innerHTML = escapeHtml(titleText) + newStatusBadge;
|
||||||
|
|
||||||
|
const artistEl = trackItem.querySelector('.track-info .artists');
|
||||||
|
if (artistEl) artistEl.textContent = data.track.artist;
|
||||||
|
} else if (titleEl && mappingType === 'external') {
|
||||||
|
// For external mappings, update status badge to show provider
|
||||||
const currentTitle = titleEl.textContent.split(' - ')[0]; // Remove old status
|
const currentTitle = titleEl.textContent.split(' - ')[0]; // Remove old status
|
||||||
const capitalizedProvider = capitalizeProvider(requestBody.externalProvider);
|
const capitalizedProvider = capitalizeProvider(requestBody.externalProvider);
|
||||||
const newStatusBadge = `<span class="status-badge warning" style="font-size:0.75rem;padding:2px 8px;margin-left:8px;"><span class="status-dot"></span>${escapeHtml(capitalizedProvider)}</span>`;
|
const newStatusBadge = `<span class="status-badge warning" style="font-size:0.75rem;padding:2px 8px;margin-left:8px;"><span class="status-dot"></span>${escapeHtml(capitalizedProvider)}</span>`;
|
||||||
@@ -2938,117 +2500,15 @@
|
|||||||
// Initial load
|
// Initial load
|
||||||
fetchStatus();
|
fetchStatus();
|
||||||
fetchPlaylists();
|
fetchPlaylists();
|
||||||
fetchTrackMappings();
|
|
||||||
fetchMissingTracks();
|
|
||||||
fetchDownloads();
|
|
||||||
fetchJellyfinUsers();
|
fetchJellyfinUsers();
|
||||||
fetchJellyfinPlaylists();
|
fetchJellyfinPlaylists();
|
||||||
fetchConfig();
|
fetchConfig();
|
||||||
fetchEndpointUsage();
|
|
||||||
|
|
||||||
// Auto-refresh every 30 seconds
|
// Auto-refresh every 30 seconds
|
||||||
setInterval(() => {
|
setInterval(() => {
|
||||||
fetchStatus();
|
fetchStatus();
|
||||||
fetchPlaylists();
|
fetchPlaylists();
|
||||||
fetchTrackMappings();
|
|
||||||
fetchMissingTracks();
|
|
||||||
fetchDownloads();
|
|
||||||
|
|
||||||
// Refresh endpoint usage if on that tab
|
|
||||||
const endpointsTab = document.getElementById('tab-endpoints');
|
|
||||||
if (endpointsTab && endpointsTab.classList.contains('active')) {
|
|
||||||
fetchEndpointUsage();
|
|
||||||
}
|
|
||||||
}, 30000);
|
}, 30000);
|
||||||
|
|
||||||
// Endpoint Usage Functions
|
|
||||||
async function fetchEndpointUsage() {
|
|
||||||
try {
|
|
||||||
const topSelect = document.getElementById('endpoints-top-select');
|
|
||||||
const top = topSelect ? topSelect.value : 50;
|
|
||||||
|
|
||||||
const res = await fetch(`/api/admin/debug/endpoint-usage?top=${top}`);
|
|
||||||
const data = await res.json();
|
|
||||||
|
|
||||||
// Update summary stats
|
|
||||||
document.getElementById('endpoints-total-requests').textContent = data.totalRequests?.toLocaleString() || '0';
|
|
||||||
document.getElementById('endpoints-unique-count').textContent = data.totalEndpoints?.toLocaleString() || '0';
|
|
||||||
|
|
||||||
const mostCalled = data.endpoints && data.endpoints.length > 0
|
|
||||||
? data.endpoints[0].endpoint
|
|
||||||
: '-';
|
|
||||||
document.getElementById('endpoints-most-called').textContent = mostCalled;
|
|
||||||
|
|
||||||
// Update table
|
|
||||||
const tbody = document.getElementById('endpoints-table-body');
|
|
||||||
|
|
||||||
if (!data.endpoints || data.endpoints.length === 0) {
|
|
||||||
tbody.innerHTML = '<tr><td colspan="4" style="text-align:center;color:var(--text-secondary);padding:40px;">No endpoint usage data available yet. Data will appear as clients make requests.</td></tr>';
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
tbody.innerHTML = data.endpoints.map((ep, index) => {
|
|
||||||
const percentage = data.totalRequests > 0
|
|
||||||
? ((ep.count / data.totalRequests) * 100).toFixed(1)
|
|
||||||
: '0.0';
|
|
||||||
|
|
||||||
// Color code based on usage
|
|
||||||
let countColor = 'var(--text-primary)';
|
|
||||||
if (ep.count > 1000) countColor = 'var(--error)';
|
|
||||||
else if (ep.count > 100) countColor = 'var(--warning)';
|
|
||||||
else if (ep.count > 10) countColor = 'var(--accent)';
|
|
||||||
|
|
||||||
// Highlight common patterns
|
|
||||||
let endpointDisplay = ep.endpoint;
|
|
||||||
if (ep.endpoint.includes('/stream')) {
|
|
||||||
endpointDisplay = `<span style="color:var(--success)">${escapeHtml(ep.endpoint)}</span>`;
|
|
||||||
} else if (ep.endpoint.includes('/Playing')) {
|
|
||||||
endpointDisplay = `<span style="color:var(--accent)">${escapeHtml(ep.endpoint)}</span>`;
|
|
||||||
} else if (ep.endpoint.includes('/Search')) {
|
|
||||||
endpointDisplay = `<span style="color:var(--warning)">${escapeHtml(ep.endpoint)}</span>`;
|
|
||||||
} else {
|
|
||||||
endpointDisplay = escapeHtml(ep.endpoint);
|
|
||||||
}
|
|
||||||
|
|
||||||
return `
|
|
||||||
<tr>
|
|
||||||
<td style="color:var(--text-secondary);text-align:center;">${index + 1}</td>
|
|
||||||
<td style="font-family:monospace;font-size:0.85rem;">${endpointDisplay}</td>
|
|
||||||
<td style="text-align:right;font-weight:600;color:${countColor}">${ep.count.toLocaleString()}</td>
|
|
||||||
<td style="text-align:right;color:var(--text-secondary)">${percentage}%</td>
|
|
||||||
</tr>
|
|
||||||
`;
|
|
||||||
}).join('');
|
|
||||||
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to fetch endpoint usage:', error);
|
|
||||||
const tbody = document.getElementById('endpoints-table-body');
|
|
||||||
tbody.innerHTML = '<tr><td colspan="4" style="text-align:center;color:var(--error);padding:40px;">Failed to load endpoint usage data</td></tr>';
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function clearEndpointUsage() {
|
|
||||||
if (!confirm('Are you sure you want to clear all endpoint usage data? This cannot be undone.')) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
try {
|
|
||||||
const res = await fetch('/api/admin/debug/endpoint-usage', { method: 'DELETE' });
|
|
||||||
const data = await res.json();
|
|
||||||
|
|
||||||
showToast(data.message || 'Endpoint usage data cleared', 'success');
|
|
||||||
fetchEndpointUsage();
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Failed to clear endpoint usage:', error);
|
|
||||||
showToast('Failed to clear endpoint usage data', 'error');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
function escapeHtml(text) {
|
|
||||||
const div = document.createElement('div');
|
|
||||||
div.textContent = text;
|
|
||||||
return div.innerHTML;
|
|
||||||
}
|
|
||||||
</script>
|
</script>
|
||||||
</body>
|
</body>
|
||||||
</html>
|
</html>
|
||||||
|
|||||||
Binary file not shown.
|
Before Width: | Height: | Size: 53 KiB |
@@ -17,17 +17,6 @@ services:
|
|||||||
networks:
|
networks:
|
||||||
- allstarr-network
|
- allstarr-network
|
||||||
|
|
||||||
spotify-lyrics:
|
|
||||||
image: akashrchandran/spotify-lyrics-api:latest
|
|
||||||
container_name: allstarr-spotify-lyrics
|
|
||||||
restart: unless-stopped
|
|
||||||
ports:
|
|
||||||
- "8365:8080"
|
|
||||||
environment:
|
|
||||||
- SP_DC=${SPOTIFY_API_SESSION_COOKIE:-}
|
|
||||||
networks:
|
|
||||||
- allstarr-network
|
|
||||||
|
|
||||||
allstarr:
|
allstarr:
|
||||||
# Use pre-built image from GitHub Container Registry
|
# Use pre-built image from GitHub Container Registry
|
||||||
# For latest stable: ghcr.io/sopat712/allstarr:latest
|
# For latest stable: ghcr.io/sopat712/allstarr:latest
|
||||||
@@ -51,8 +40,6 @@ services:
|
|||||||
depends_on:
|
depends_on:
|
||||||
redis:
|
redis:
|
||||||
condition: service_healthy
|
condition: service_healthy
|
||||||
spotify-lyrics:
|
|
||||||
condition: service_started
|
|
||||||
healthcheck:
|
healthcheck:
|
||||||
test: ["CMD", "curl", "-f", "http://localhost:8080/health"]
|
test: ["CMD", "curl", "-f", "http://localhost:8080/health"]
|
||||||
interval: 30s
|
interval: 30s
|
||||||
@@ -111,8 +98,6 @@ services:
|
|||||||
- SpotifyApi__CacheDurationMinutes=${SPOTIFY_API_CACHE_DURATION_MINUTES:-60}
|
- SpotifyApi__CacheDurationMinutes=${SPOTIFY_API_CACHE_DURATION_MINUTES:-60}
|
||||||
- SpotifyApi__RateLimitDelayMs=${SPOTIFY_API_RATE_LIMIT_DELAY_MS:-100}
|
- SpotifyApi__RateLimitDelayMs=${SPOTIFY_API_RATE_LIMIT_DELAY_MS:-100}
|
||||||
- SpotifyApi__PreferIsrcMatching=${SPOTIFY_API_PREFER_ISRC_MATCHING:-true}
|
- SpotifyApi__PreferIsrcMatching=${SPOTIFY_API_PREFER_ISRC_MATCHING:-true}
|
||||||
# Spotify Lyrics API sidecar service URL (internal)
|
|
||||||
- SpotifyApi__LyricsApiUrl=${SPOTIFY_LYRICS_API_URL:-http://spotify-lyrics:8080}
|
|
||||||
|
|
||||||
# ===== SHARED =====
|
# ===== SHARED =====
|
||||||
- Library__DownloadPath=/app/downloads
|
- Library__DownloadPath=/app/downloads
|
||||||
|
|||||||
Reference in New Issue
Block a user