mirror of
https://github.com/SoPat712/allstarr.git
synced 2026-04-23 02:32:48 -04:00
Compare commits
49 Commits
v1.3.0
...
v1.5.1-beta.1
| Author | SHA1 | Date | |
|---|---|---|---|
|
3c291d5fac
|
|||
|
2a430a1c38
|
|||
|
1a0f7c0282
|
|||
|
6b89fe548f
|
|||
|
233af5dc8f
|
|||
|
4c1e6979b3
|
|||
|
0738e2d588
|
|||
|
0a5b383526
|
|||
|
5e8cb13d1a
|
|||
|
efdeef927a
|
|||
|
5c184d38c8
|
|||
|
30f68729fc
|
|||
|
53f7b5e8b3
|
|||
|
4b423eecb2
|
|||
|
da33ba9fbd
|
|||
|
6c95cfd2d6
|
|||
|
d4230a2f79
|
|||
|
50157db484
|
|||
|
2d11d913e8
|
|||
|
299cb025f1
|
|||
|
f9e5b7f323
|
|||
|
b737db93be
|
|||
|
953719e796
|
|||
|
ecdd514579
|
|||
|
db714fee2d
|
|||
|
efe1660d81
|
|||
|
639070556a
|
|||
|
00a5d152a5
|
|||
|
1ba6135115
|
|||
|
ec994773dd
|
|||
|
39c8f16b59
|
|||
|
a6a423d5a1
|
|||
|
899451d405
|
|||
|
8d6dd7ccf1
|
|||
|
ebdd8d4e2a
|
|||
|
e4599a419e
|
|||
|
86290dff0d
|
|||
|
0a9e528418
|
|||
|
f74728fc73
|
|||
|
87467be61b
|
|||
|
713ecd4ec8
|
|||
|
0ff1e3a428
|
|||
|
cef18b9482
|
|||
|
1bfe30b216
|
|||
|
c9c82a650d
|
|||
|
d0a7dbcc96
|
|||
|
9c9a827a91
|
|||
|
96889738df
|
|||
|
f3c791496e
|
+21
-8
@@ -32,6 +32,7 @@ CORS_ALLOW_CREDENTIALS=false
|
||||
|
||||
# Redis data persistence directory (default: ./redis-data)
|
||||
# Contains Redis RDB snapshots and AOF logs for crash recovery
|
||||
# Keep this separate from CACHE_PATH / ./cache. It should only contain Valkey persistence files.
|
||||
REDIS_DATA_PATH=./redis-data
|
||||
|
||||
# ===== CACHE TTL SETTINGS =====
|
||||
@@ -40,8 +41,8 @@ REDIS_DATA_PATH=./redis-data
|
||||
# All values are configurable via Web UI (Configuration tab > Cache Settings)
|
||||
# Changes require container restart to apply
|
||||
|
||||
# Search results cache duration in minutes (default: 120 = 2 hours)
|
||||
CACHE_SEARCH_RESULTS_MINUTES=120
|
||||
# Search results cache duration in minutes (default: 1)
|
||||
CACHE_SEARCH_RESULTS_MINUTES=1
|
||||
|
||||
# Playlist cover images cache duration in hours (default: 168 = 1 week)
|
||||
CACHE_PLAYLIST_IMAGES_HOURS=168
|
||||
@@ -68,6 +69,11 @@ CACHE_ODESLI_LOOKUP_DAYS=60
|
||||
# Jellyfin proxy images cache duration in days (default: 14 = 2 weeks)
|
||||
CACHE_PROXY_IMAGES_DAYS=14
|
||||
|
||||
# Transcoded audio file cache duration in minutes (default: 60 = 1 hour)
|
||||
# Quality-override files (lower quality streams for cellular/transcoding)
|
||||
# are cached in {downloads}/transcoded/ and cleaned up after this duration
|
||||
CACHE_TRANSCODE_MINUTES=60
|
||||
|
||||
|
||||
# ===== SUBSONIC/NAVIDROME CONFIGURATION =====
|
||||
# Server URL (required if using Subsonic backend)
|
||||
@@ -94,12 +100,10 @@ JELLYFIN_LIBRARY_ID=
|
||||
# Music service to use: SquidWTF, Deezer, or Qobuz (default: SquidWTF)
|
||||
MUSIC_SERVICE=SquidWTF
|
||||
|
||||
# Base directory for all downloads (default: ./downloads)
|
||||
# This creates three subdirectories:
|
||||
# - downloads/permanent/ - Permanently downloaded tracks (STORAGE_MODE=Permanent)
|
||||
# - downloads/cache/ - Temporarily cached tracks (STORAGE_MODE=Cache)
|
||||
# - downloads/kept/ - Favorited external tracks (always permanent)
|
||||
Library__DownloadPath=./downloads
|
||||
# Base directory for permanently downloaded tracks (default: ./downloads)
|
||||
# Note: Temporarily cached tracks are stored in {DOWNLOAD_PATH}/cache. Favorited
|
||||
# tracks are stored separately in KEPT_PATH (default: ./kept)
|
||||
DOWNLOAD_PATH=./downloads
|
||||
|
||||
# ===== SQUIDWTF CONFIGURATION =====
|
||||
# Preferred audio quality (optional, default: LOSSLESS)
|
||||
@@ -110,6 +114,9 @@ Library__DownloadPath=./downloads
|
||||
# If not specified, LOSSLESS (16-bit FLAC) will be used
|
||||
SQUIDWTF_QUALITY=LOSSLESS
|
||||
|
||||
# Minimum interval between requests in milliseconds (default: 200)
|
||||
SQUIDWTF_MIN_REQUEST_INTERVAL_MS=200
|
||||
|
||||
# ===== DEEZER CONFIGURATION =====
|
||||
# Deezer ARL token (required if using Deezer)
|
||||
# See README.md for instructions on how to get this token
|
||||
@@ -122,6 +129,9 @@ DEEZER_ARL_FALLBACK=
|
||||
# If not specified, the highest available quality for your account will be used
|
||||
DEEZER_QUALITY=
|
||||
|
||||
# Minimum interval between requests in milliseconds (default: 200)
|
||||
DEEZER_MIN_REQUEST_INTERVAL_MS=200
|
||||
|
||||
# ===== QOBUZ CONFIGURATION =====
|
||||
# Qobuz user authentication token (required if using Qobuz)
|
||||
# Get this from your browser after logging into play.qobuz.com
|
||||
@@ -136,6 +146,9 @@ QOBUZ_USER_ID=
|
||||
# If not specified, the highest available quality will be used
|
||||
QOBUZ_QUALITY=
|
||||
|
||||
# Minimum interval between requests in milliseconds (default: 200)
|
||||
QOBUZ_MIN_REQUEST_INTERVAL_MS=200
|
||||
|
||||
# ===== MUSICBRAINZ CONFIGURATION =====
|
||||
# Enable MusicBrainz metadata lookups (optional, default: true)
|
||||
MUSICBRAINZ_ENABLED=true
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
# These are supported funding model platforms
|
||||
|
||||
github: # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
|
||||
github: [SoPat712]
|
||||
patreon: # Replace with a single Patreon username
|
||||
open_collective: # Replace with a single Open Collective username
|
||||
ko_fi: joshpatra
|
||||
|
||||
@@ -73,7 +73,7 @@ jobs:
|
||||
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
|
||||
tags: |
|
||||
type=ref,event=branch
|
||||
type=sha,prefix=
|
||||
type=ref,event=tag
|
||||
type=semver,pattern={{version}}
|
||||
type=semver,pattern={{major}}.{{minor}}
|
||||
type=semver,pattern={{major}}
|
||||
|
||||
@@ -13,6 +13,7 @@ COPY allstarr/ allstarr/
|
||||
COPY allstarr.Tests/ allstarr.Tests/
|
||||
|
||||
RUN dotnet publish allstarr/allstarr.csproj -c Release -o /app/publish
|
||||
COPY .env.example /app/publish/
|
||||
|
||||
# Runtime stage
|
||||
FROM mcr.microsoft.com/dotnet/aspnet:10.0
|
||||
|
||||
@@ -5,7 +5,7 @@
|
||||
[](https://github.com/SoPat712/allstarr/pkgs/container/allstarr)
|
||||
[](LICENSE)
|
||||
|
||||
A media server proxy that integrates music streaming providers with your local library. Works with **Jellyfin** and **Subsonic-compatible** servers. When a song isn't in your local library, it gets fetched from your configured provider, downloaded, and served to your client. The downloaded song then lives in your library for next time.
|
||||
A media server proxy that integrates music streaming providers with your local library. Works with **Jellyfin** servers. When a song isn't in your local library, it gets fetched from your configured provider, downloaded, and served to your client. The downloaded song then lives in your library for next time.
|
||||
|
||||
## Quick Start
|
||||
|
||||
@@ -39,7 +39,6 @@ The proxy will be available at `http://localhost:5274`.
|
||||
Allstarr includes a web UI for easy configuration and playlist management, accessible at `http://localhost:5275`
|
||||
<img width="1664" height="1101" alt="image" src="https://github.com/user-attachments/assets/9159100b-7e11-449e-8530-517d336d6bd2" />
|
||||
|
||||
|
||||
### Features
|
||||
|
||||
- **Playlist Management**: Link Jellyfin playlists to Spotify playlists with just a few clicks
|
||||
@@ -66,17 +65,16 @@ Allstarr includes a web UI for easy configuration and playlist management, acces
|
||||
- `37i9dQZF1DXcBWIGoYBM5M` (just the ID)
|
||||
- `spotify:playlist:37i9dQZF1DXcBWIGoYBM5M` (Spotify URI)
|
||||
- `https://open.spotify.com/playlist/37i9dQZF1DXcBWIGoYBM5M` (full URL)
|
||||
4. **Restart** to apply changes (should be a banner)
|
||||
4. **Restart Allstarr** to apply changes (should be a banner)
|
||||
|
||||
Then, proceeed to **Active Playlists**, which shows you which Spotify playlists are currently being monitored and filled with tracks, and lets you do a bunch of useful operations on them.
|
||||
|
||||
### Configuration Persistence
|
||||
|
||||
The web UI updates your `.env` file directly. Changes persist across container restarts, but require a restart to take effect. In development mode, the `.env` file is in your project root. In Docker, it's at `/app/.env`.
|
||||
The web UI updates your `.env` file directly. Allstarr reloads that file on startup, so a normal container restart is enough for UI changes to take effect. In development mode, the `.env` file is in your project root. In Docker, it's at `/app/.env`.
|
||||
|
||||
There's an environment variable to modify this.
|
||||
|
||||
|
||||
**Recommended workflow**: Use the `sp_dc` cookie method alongside the [Spotify Import Plugin](https://github.com/Viperinius/jellyfin-plugin-spotify-import?tab=readme-ov-file).
|
||||
|
||||
### Nginx Proxy Setup (Optional)
|
||||
@@ -87,20 +85,20 @@ This service only exposes ports internally. You can use nginx to proxy to it, ho
|
||||
server {
|
||||
listen 443 ssl http2;
|
||||
server_name your-domain.com;
|
||||
|
||||
|
||||
ssl_certificate /etc/letsencrypt/live/your-domain.com/fullchain.pem;
|
||||
ssl_certificate_key /etc/letsencrypt/live/your-domain.com/privkey.pem;
|
||||
ssl_protocols TLSv1.2 TLSv1.3;
|
||||
|
||||
|
||||
# Security headers
|
||||
add_header Strict-Transport-Security "max-age=31536000" always;
|
||||
add_header X-Content-Type-Options "nosniff" always;
|
||||
|
||||
|
||||
# Streaming settings
|
||||
proxy_buffering off;
|
||||
proxy_request_buffering off;
|
||||
proxy_read_timeout 600s;
|
||||
|
||||
|
||||
location / {
|
||||
proxy_pass http://allstarr:8080;
|
||||
proxy_set_header Host $host;
|
||||
@@ -119,7 +117,7 @@ This project brings together all the music streaming providers into one unified
|
||||
|
||||
## Features
|
||||
|
||||
- **Dual Backend Support**: Works with Jellyfin and Subsonic-compatible servers (Navidrome, Airsonic, etc.)
|
||||
- **Dual Backend Support**: Works with Jellyfin
|
||||
- **Multi-Provider Architecture**: Pluggable system for streaming providers (Deezer, Qobuz, SquidWTF)
|
||||
- **Transparent Proxy**: Sits between your music clients and media server
|
||||
- **Automatic Search**: Searches streaming providers when songs aren't local
|
||||
@@ -139,43 +137,21 @@ This project brings together all the music streaming providers into one unified
|
||||
## Supported Backends
|
||||
|
||||
### Jellyfin
|
||||
|
||||
[Jellyfin](https://jellyfin.org/) is a free and open-source media server. Allstarr connects via the Jellyfin API using your Jellyfin user login. (I plan to move this to api key if possible)
|
||||
|
||||
**Compatible Jellyfin clients:**
|
||||
|
||||
- [Feishin](https://github.com/jeffvli/feishin) (Mac/Windows/Linux)
|
||||
<img width="1691" height="1128" alt="image" src="https://github.com/user-attachments/assets/c602f71c-c4dd-49a9-b533-1558e24a9f45" />
|
||||
|
||||
<img width="1691" height="1128" alt="image" src="https://github.com/user-attachments/assets/c602f71c-c4dd-49a9-b533-1558e24a9f45" />
|
||||
|
||||
- [Musiver](https://music.aqzscn.cn/en/) (Android/iOS/Windows/Android)
|
||||
<img width="523" height="1025" alt="image" src="https://github.com/user-attachments/assets/135e2721-5fd7-482f-bb06-b0736003cfe7" />
|
||||
|
||||
<img width="523" height="1025" alt="image" src="https://github.com/user-attachments/assets/135e2721-5fd7-482f-bb06-b0736003cfe7" />
|
||||
|
||||
- [Finamp](https://github.com/jmshrv/finamp) (Android/iOS)
|
||||
|
||||
- [Finer Player](https://monk-studio.com/finer) (iOS/iPadOS/macOS/tvOS)
|
||||
|
||||
_Working on getting more currently_
|
||||
|
||||
### Subsonic/Navidrome
|
||||
[Navidrome](https://www.navidrome.org/) and other Subsonic-compatible servers are supported via the Subsonic API.
|
||||
|
||||
**Compatible Subsonic clients:**
|
||||
|
||||
#### PC
|
||||
- [Aonsoku](https://github.com/victoralvesf/aonsoku)
|
||||
- [Feishin](https://github.com/jeffvli/feishin)
|
||||
- [Subplayer](https://github.com/peguerosdc/subplayer)
|
||||
- [Aurial](https://github.com/shrimpza/aurial)
|
||||
|
||||
#### Android
|
||||
- [Tempus](https://github.com/eddyizm/tempus)
|
||||
- [Substreamer](https://substreamerapp.com/)
|
||||
|
||||
#### iOS
|
||||
- [Narjo](https://www.reddit.com/r/NarjoApp/)
|
||||
- [Arpeggi](https://www.reddit.com/r/arpeggiApp/)
|
||||
|
||||
> **Want to improve client compatibility?** Pull requests are welcome!
|
||||
|
||||
### Incompatible Clients
|
||||
@@ -198,13 +174,12 @@ Choose your preferred provider via the `MUSIC_SERVICE` environment variable. Add
|
||||
|
||||
- A running media server:
|
||||
- **Jellyfin**: Any recent version with API access enabled
|
||||
- **Subsonic**: Navidrome or other Subsonic-compatible server
|
||||
- **Docker and Docker Compose** (recommended) - includes Redis and Spotify Lyrics API sidecars
|
||||
- Redis is used for caching (search results, playlists, lyrics, etc.)
|
||||
- Spotify Lyrics API provides synchronized lyrics for Spotify tracks
|
||||
- Credentials for at least one music provider (IF NOT USING SQUIDWTF):
|
||||
- **Deezer**: ARL token from browser cookies
|
||||
- **Qobuz**: User ID + User Auth Token from browser localStorage ([see Wiki guide](https://github.com/V1ck3s/octo-fiesta/wiki/Getting-Qobuz-Credentials-(User-ID-&-Token)))
|
||||
- **Qobuz**: User ID + User Auth Token from browser localStorage ([see Wiki guide](<https://github.com/V1ck3s/octo-fiesta/wiki/Getting-Qobuz-Credentials-(User-ID-&-Token)>))
|
||||
- **OR** [.NET 10.0 SDK](https://dotnet.microsoft.com/download/dotnet/10.0) for manual installation (requires separate Redis setup)
|
||||
|
||||
## Configuration
|
||||
@@ -212,47 +187,39 @@ Choose your preferred provider via the `MUSIC_SERVICE` environment variable. Add
|
||||
### Environment Setup
|
||||
|
||||
1. **Create your environment file**
|
||||
|
||||
```bash
|
||||
cp .env.example .env
|
||||
```
|
||||
|
||||
2. **Edit the `.env` file** with your configuration:
|
||||
|
||||
**For Jellyfin backend:**
|
||||
**Server Settings:**
|
||||
|
||||
```bash
|
||||
# Backend selection
|
||||
BACKEND_TYPE=Jellyfin
|
||||
|
||||
|
||||
# Jellyfin server URL
|
||||
JELLYFIN_URL=http://localhost:8096
|
||||
|
||||
|
||||
# API key (get from Jellyfin Dashboard > API Keys)
|
||||
JELLYFIN_API_KEY=your-api-key-here
|
||||
|
||||
|
||||
# User ID (from Jellyfin Dashboard > Users > click user > check URL)
|
||||
JELLYFIN_USER_ID=your-user-id-here
|
||||
|
||||
|
||||
# Music library ID (optional, auto-detected if not set)
|
||||
JELLYFIN_LIBRARY_ID=
|
||||
```
|
||||
|
||||
**For Subsonic/Navidrome backend:**
|
||||
```bash
|
||||
# Backend selection
|
||||
BACKEND_TYPE=Subsonic
|
||||
|
||||
# Navidrome/Subsonic server URL
|
||||
SUBSONIC_URL=http://localhost:4533
|
||||
```
|
||||
|
||||
**Common settings (both backends):**
|
||||
```bash
|
||||
# Path where downloaded songs will be stored
|
||||
DOWNLOAD_PATH=./downloads
|
||||
|
||||
|
||||
# Music service to use: SquidWTF, Deezer, or Qobuz
|
||||
MUSIC_SERVICE=SquidWTF
|
||||
|
||||
|
||||
# Storage mode: Permanent or Cache
|
||||
STORAGE_MODE=Permanent
|
||||
```
|
||||
@@ -260,7 +227,7 @@ Choose your preferred provider via the `MUSIC_SERVICE` environment variable. Add
|
||||
See the full `.env.example` for all available options including Deezer/Qobuz credentials.
|
||||
|
||||
3. **Configure your client**
|
||||
|
||||
|
||||
Point your music client to `http://localhost:5274` instead of your media server directly.
|
||||
|
||||
> **Tip**: Make sure the `DOWNLOAD_PATH` points to a directory that your media server can scan, so downloaded songs appear in your library.
|
||||
@@ -272,21 +239,24 @@ For detailed configuration options, see [CONFIGURATION.md](CONFIGURATION.md).
|
||||
If you prefer to run Allstarr without Docker:
|
||||
|
||||
1. **Clone the repository**
|
||||
|
||||
```bash
|
||||
git clone https://github.com/SoPat712/allstarr.git
|
||||
cd allstarr
|
||||
```
|
||||
|
||||
2. **Restore dependencies**
|
||||
|
||||
```bash
|
||||
dotnet restore
|
||||
```
|
||||
|
||||
3. **Configure the application**
|
||||
|
||||
|
||||
Edit `allstarr/appsettings.json`:
|
||||
|
||||
|
||||
**For Jellyfin:**
|
||||
|
||||
```json
|
||||
{
|
||||
"Backend": {
|
||||
@@ -303,33 +273,18 @@ If you prefer to run Allstarr without Docker:
|
||||
}
|
||||
}
|
||||
```
|
||||
|
||||
**For Subsonic/Navidrome:**
|
||||
```json
|
||||
{
|
||||
"Backend": {
|
||||
"Type": "Subsonic"
|
||||
},
|
||||
"Subsonic": {
|
||||
"Url": "http://localhost:4533",
|
||||
"MusicService": "SquidWTF"
|
||||
},
|
||||
"Library": {
|
||||
"DownloadPath": "./downloads"
|
||||
}
|
||||
}
|
||||
```
|
||||
|
||||
4. **Run the server**
|
||||
|
||||
```bash
|
||||
cd allstarr
|
||||
dotnet run
|
||||
```
|
||||
|
||||
|
||||
The proxy will start on `http://localhost:5274` by default.
|
||||
|
||||
5. **Configure your client**
|
||||
|
||||
|
||||
Point your music client to `http://localhost:5274` instead of your media server directly.
|
||||
|
||||
## Documentation
|
||||
@@ -341,7 +296,6 @@ If you prefer to run Allstarr without Docker:
|
||||
|
||||
## Limitations
|
||||
|
||||
- **Playlist Search**: Subsonic clients like Aonsoku filter playlists client-side from a cached `getPlaylists` call. Streaming provider playlists appear in global search (`search3`) but not in the Playlists tab filter.
|
||||
- **Region Restrictions**: Some tracks may be unavailable depending on your region and provider.
|
||||
- **Token Expiration**: Provider authentication tokens expire and need periodic refresh.
|
||||
|
||||
@@ -356,7 +310,6 @@ GPL-3.0
|
||||
- [Jellyfin Spotify Import Plugin](https://github.com/Viperinius/jellyfin-plugin-spotify-import?tab=readme-ov-file) - The plugin that I **strongly** recommend using alongside this repo
|
||||
- [Jellyfin](https://jellyfin.org/) - The free and open-source media server
|
||||
- [Navidrome](https://www.navidrome.org/) - The excellent self-hosted music server
|
||||
- [Subsonic API](http://www.subsonic.org/pages/api.jsp) - The API specification
|
||||
- [Hi-Fi API](https://github.com/binimum/hifi-api) - These people do some great work, and you should thank them for this even existing!
|
||||
- [Deezer](https://www.deezer.com/) - Music streaming service
|
||||
- [Qobuz](https://www.qobuz.com/) - Hi-Res music streaming service
|
||||
|
||||
@@ -39,6 +39,22 @@ public class AuthHeaderHelperTests
|
||||
Assert.True(request.Headers.Contains("X-Emby-Authorization"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ForwardAuthHeaders_ShouldForwardXEmbyToken()
|
||||
{
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Token"] = "abc"
|
||||
};
|
||||
|
||||
using var request = new HttpRequestMessage();
|
||||
var forwarded = AuthHeaderHelper.ForwardAuthHeaders(headers, request);
|
||||
|
||||
Assert.True(forwarded);
|
||||
Assert.True(request.Headers.TryGetValues("X-Emby-Token", out var values));
|
||||
Assert.Contains("abc", values);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ForwardAuthHeaders_ShouldForwardStandardAuthorization()
|
||||
{
|
||||
|
||||
@@ -0,0 +1,60 @@
|
||||
using System.Net;
|
||||
using allstarr.Middleware;
|
||||
using Microsoft.AspNetCore.Http;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class BotProbeBlockMiddlewareTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task InvokeAsync_ScannerPath_Returns404WithoutCallingNext()
|
||||
{
|
||||
var nextInvoked = false;
|
||||
var middleware = new BotProbeBlockMiddleware(
|
||||
_ =>
|
||||
{
|
||||
nextInvoked = true;
|
||||
return Task.CompletedTask;
|
||||
},
|
||||
NullLogger<BotProbeBlockMiddleware>.Instance);
|
||||
|
||||
var context = CreateContext("/.env");
|
||||
|
||||
await middleware.InvokeAsync(context);
|
||||
|
||||
Assert.False(nextInvoked);
|
||||
Assert.Equal(StatusCodes.Status404NotFound, context.Response.StatusCode);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task InvokeAsync_NormalPath_CallsNext()
|
||||
{
|
||||
var nextInvoked = false;
|
||||
var middleware = new BotProbeBlockMiddleware(
|
||||
context =>
|
||||
{
|
||||
nextInvoked = true;
|
||||
context.Response.StatusCode = StatusCodes.Status204NoContent;
|
||||
return Task.CompletedTask;
|
||||
},
|
||||
NullLogger<BotProbeBlockMiddleware>.Instance);
|
||||
|
||||
var context = CreateContext("/System/Info/Public");
|
||||
|
||||
await middleware.InvokeAsync(context);
|
||||
|
||||
Assert.True(nextInvoked);
|
||||
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
||||
}
|
||||
|
||||
private static DefaultHttpContext CreateContext(string path)
|
||||
{
|
||||
var context = new DefaultHttpContext();
|
||||
context.Request.Path = path;
|
||||
context.Request.Method = HttpMethods.Get;
|
||||
context.Connection.RemoteIpAddress = IPAddress.Parse("203.0.113.10");
|
||||
context.Response.Body = new MemoryStream();
|
||||
return context;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,34 @@
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class BotProbeDetectorTests
|
||||
{
|
||||
[Theory]
|
||||
[InlineData("/.env")]
|
||||
[InlineData("/.git/config")]
|
||||
[InlineData("/wordpress")]
|
||||
[InlineData("/wp")]
|
||||
[InlineData("/wp-admin/install.php")]
|
||||
[InlineData("/vendor/phpunit/phpunit/src/Util/PHP/eval-stdin.php")]
|
||||
[InlineData("/public/vendor/laravel-filemanager/js/script.js")]
|
||||
[InlineData("/_ignition/execute-solution")]
|
||||
[InlineData("/debug/default/index")]
|
||||
[InlineData("https://jellyfin.joshpatra.me/.git/config")]
|
||||
public void IsHighConfidenceProbeUrl_ScannerPaths_ReturnsTrue(string path)
|
||||
{
|
||||
Assert.True(BotProbeDetector.IsHighConfidenceProbeUrl(path));
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("/System/Info/Public")]
|
||||
[InlineData("/web/index.html")]
|
||||
[InlineData("/Items/123")]
|
||||
[InlineData("/Users/AuthenticateByName")]
|
||||
[InlineData("/new")]
|
||||
[InlineData("/blog")]
|
||||
public void IsHighConfidenceProbeUrl_NormalProxyPaths_ReturnsFalse(string path)
|
||||
{
|
||||
Assert.False(BotProbeDetector.IsHighConfidenceProbeUrl(path));
|
||||
}
|
||||
}
|
||||
@@ -20,10 +20,42 @@ public class CacheKeyBuilderTests
|
||||
"1635cd7d23144ba08251ebe22a56119e");
|
||||
|
||||
Assert.Equal(
|
||||
"search:data:musicalbum:500:0:efa26829c37196b030fa31d127e0715b:datecreated,sortname:descending:true:1635cd7d23144ba08251ebe22a56119e",
|
||||
"search:data:musicalbum:500:0:efa26829c37196b030fa31d127e0715b:datecreated,sortname:descending:true:1635cd7d23144ba08251ebe22a56119e:",
|
||||
key);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SearchKey_ShouldDifferentiateFavoriteOnlyQueries()
|
||||
{
|
||||
var normalKey = CacheKeyBuilder.BuildSearchKey(
|
||||
"Sunflower",
|
||||
"Audio",
|
||||
100,
|
||||
0,
|
||||
"parent",
|
||||
"SortName",
|
||||
"Ascending",
|
||||
true,
|
||||
"user-1",
|
||||
"false");
|
||||
|
||||
var favoritesOnlyKey = CacheKeyBuilder.BuildSearchKey(
|
||||
"Sunflower",
|
||||
"Audio",
|
||||
100,
|
||||
0,
|
||||
"parent",
|
||||
"SortName",
|
||||
"Ascending",
|
||||
true,
|
||||
"user-1",
|
||||
"true");
|
||||
|
||||
Assert.NotEqual(normalKey, favoritesOnlyKey);
|
||||
Assert.EndsWith(":false", normalKey);
|
||||
Assert.EndsWith(":true", favoritesOnlyKey);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SearchKey_OldOverload_ShouldRemainCompatible()
|
||||
{
|
||||
|
||||
@@ -0,0 +1,69 @@
|
||||
using System.Reflection;
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class FavoritesMigrationServiceTests
|
||||
{
|
||||
[Fact]
|
||||
public void ParsePendingDeletions_ParsesLegacyDictionaryFormat()
|
||||
{
|
||||
var scheduledDeletion = new DateTime(2026, 3, 20, 14, 30, 0, DateTimeKind.Utc);
|
||||
var parsed = ParsePendingDeletions($$"""
|
||||
{
|
||||
"ext-deezer-123": "{{scheduledDeletion:O}}"
|
||||
}
|
||||
""");
|
||||
|
||||
Assert.Single(parsed);
|
||||
Assert.Equal(scheduledDeletion, parsed["ext-deezer-123"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParsePendingDeletions_ParsesSetFormatUsingFallbackDate()
|
||||
{
|
||||
var fallbackDeleteAtUtc = new DateTime(2026, 3, 23, 12, 0, 0, DateTimeKind.Utc);
|
||||
var parsed = ParsePendingDeletions("""
|
||||
[
|
||||
"ext-deezer-123",
|
||||
"ext-qobuz-456"
|
||||
]
|
||||
""", fallbackDeleteAtUtc);
|
||||
|
||||
Assert.Equal(2, parsed.Count);
|
||||
Assert.Equal(fallbackDeleteAtUtc, parsed["ext-deezer-123"]);
|
||||
Assert.Equal(fallbackDeleteAtUtc, parsed["ext-qobuz-456"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParsePendingDeletions_ThrowsForUnsupportedFormat()
|
||||
{
|
||||
var method = typeof(FavoritesMigrationService).GetMethod(
|
||||
"ParsePendingDeletions",
|
||||
BindingFlags.Static | BindingFlags.NonPublic);
|
||||
|
||||
Assert.NotNull(method);
|
||||
|
||||
var ex = Assert.Throws<TargetInvocationException>(() =>
|
||||
method!.Invoke(null, new object?[] { """{"bad":42}""", DateTime.UtcNow }));
|
||||
|
||||
Assert.IsType<System.Text.Json.JsonException>(ex.InnerException);
|
||||
}
|
||||
|
||||
private static Dictionary<string, DateTime> ParsePendingDeletions(string json, DateTime? fallbackDeleteAtUtc = null)
|
||||
{
|
||||
var method = typeof(FavoritesMigrationService).GetMethod(
|
||||
"ParsePendingDeletions",
|
||||
BindingFlags.Static | BindingFlags.NonPublic);
|
||||
|
||||
Assert.NotNull(method);
|
||||
|
||||
var result = method!.Invoke(null, new object?[]
|
||||
{
|
||||
json,
|
||||
fallbackDeleteAtUtc ?? new DateTime(2026, 3, 23, 0, 0, 0, DateTimeKind.Utc)
|
||||
});
|
||||
|
||||
return Assert.IsType<Dictionary<string, DateTime>>(result);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,64 @@
|
||||
using Microsoft.AspNetCore.Http;
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class ImageConditionalRequestHelperTests
|
||||
{
|
||||
[Fact]
|
||||
public void ComputeStrongETag_SamePayload_ReturnsStableQuotedHash()
|
||||
{
|
||||
var payload = new byte[] { 1, 2, 3, 4 };
|
||||
|
||||
var first = ImageConditionalRequestHelper.ComputeStrongETag(payload);
|
||||
var second = ImageConditionalRequestHelper.ComputeStrongETag(payload);
|
||||
|
||||
Assert.Equal(first, second);
|
||||
Assert.StartsWith("\"", first);
|
||||
Assert.EndsWith("\"", first);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MatchesIfNoneMatch_WithExactMatch_ReturnsTrue()
|
||||
{
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["If-None-Match"] = "\"ABC123\""
|
||||
};
|
||||
|
||||
Assert.True(ImageConditionalRequestHelper.MatchesIfNoneMatch(headers, "\"ABC123\""));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MatchesIfNoneMatch_WithMultipleValues_ReturnsTrueForMatchingEntry()
|
||||
{
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["If-None-Match"] = "\"stale\", \"fresh\""
|
||||
};
|
||||
|
||||
Assert.True(ImageConditionalRequestHelper.MatchesIfNoneMatch(headers, "\"fresh\""));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MatchesIfNoneMatch_WithWildcard_ReturnsTrue()
|
||||
{
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["If-None-Match"] = "*"
|
||||
};
|
||||
|
||||
Assert.True(ImageConditionalRequestHelper.MatchesIfNoneMatch(headers, "\"anything\""));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MatchesIfNoneMatch_WithoutMatch_ReturnsFalse()
|
||||
{
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["If-None-Match"] = "\"ABC123\""
|
||||
};
|
||||
|
||||
Assert.False(ImageConditionalRequestHelper.MatchesIfNoneMatch(headers, "\"XYZ789\""));
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,85 @@
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class InjectedPlaylistItemHelperTests
|
||||
{
|
||||
[Fact]
|
||||
public void LooksLikeSyntheticLocalItem_ReturnsTrue_ForLocalAllstarrItem()
|
||||
{
|
||||
var item = new Dictionary<string, object?>
|
||||
{
|
||||
["Id"] = "49cf417c0fe00ad9cb1ed59f2debc384",
|
||||
["ServerId"] = "allstarr"
|
||||
};
|
||||
|
||||
Assert.True(InjectedPlaylistItemHelper.LooksLikeSyntheticLocalItem(item));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LooksLikeSyntheticLocalItem_ReturnsFalse_ForExternalInjectedItem()
|
||||
{
|
||||
var item = new Dictionary<string, object?>
|
||||
{
|
||||
["Id"] = "ext-spotify-4h4QlmocP3IuwYEj2j14p8",
|
||||
["ServerId"] = "allstarr"
|
||||
};
|
||||
|
||||
Assert.False(InjectedPlaylistItemHelper.LooksLikeSyntheticLocalItem(item));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LooksLikeSyntheticLocalItem_ReturnsFalse_ForRawJellyfinItem()
|
||||
{
|
||||
var item = new Dictionary<string, object?>
|
||||
{
|
||||
["Id"] = "49cf417c0fe00ad9cb1ed59f2debc384",
|
||||
["ServerId"] = "c17d351d3af24c678a6d8049c212d522"
|
||||
};
|
||||
|
||||
Assert.False(InjectedPlaylistItemHelper.LooksLikeSyntheticLocalItem(item));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LooksLikeLocalItemMissingGenreMetadata_ReturnsTrue_ForRawJellyfinItemMissingGenreItems()
|
||||
{
|
||||
var item = new Dictionary<string, object?>
|
||||
{
|
||||
["Id"] = "49cf417c0fe00ad9cb1ed59f2debc384",
|
||||
["ServerId"] = "c17d351d3af24c678a6d8049c212d522",
|
||||
["Genres"] = new[] { "Pop" }
|
||||
};
|
||||
|
||||
Assert.True(InjectedPlaylistItemHelper.LooksLikeLocalItemMissingGenreMetadata(item));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LooksLikeLocalItemMissingGenreMetadata_ReturnsFalse_WhenGenresAndGenreItemsExist()
|
||||
{
|
||||
var item = new Dictionary<string, object?>
|
||||
{
|
||||
["Id"] = "49cf417c0fe00ad9cb1ed59f2debc384",
|
||||
["ServerId"] = "c17d351d3af24c678a6d8049c212d522",
|
||||
["Genres"] = new[] { "Pop" },
|
||||
["GenreItems"] = new[]
|
||||
{
|
||||
new Dictionary<string, object?> { ["Name"] = "Pop", ["Id"] = "genre-id" }
|
||||
}
|
||||
};
|
||||
|
||||
Assert.False(InjectedPlaylistItemHelper.LooksLikeLocalItemMissingGenreMetadata(item));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LooksLikeLocalItemMissingGenreMetadata_ReturnsFalse_ForExternalInjectedItem()
|
||||
{
|
||||
var item = new Dictionary<string, object?>
|
||||
{
|
||||
["Id"] = "ext-spotify-4h4QlmocP3IuwYEj2j14p8",
|
||||
["ServerId"] = "allstarr",
|
||||
["Genres"] = new[] { "Pop" }
|
||||
};
|
||||
|
||||
Assert.False(InjectedPlaylistItemHelper.LooksLikeLocalItemMissingGenreMetadata(item));
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,43 @@
|
||||
using System.Reflection;
|
||||
using allstarr.Controllers;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class JellyfinControllerSearchLimitTests
|
||||
{
|
||||
[Theory]
|
||||
[InlineData(null, 20, true, 20, 20, 20)]
|
||||
[InlineData("MusicAlbum", 20, true, 0, 20, 0)]
|
||||
[InlineData("Audio", 20, true, 20, 0, 0)]
|
||||
[InlineData("MusicArtist", 20, true, 0, 0, 20)]
|
||||
[InlineData("Playlist", 20, true, 0, 20, 0)]
|
||||
[InlineData("Playlist", 20, false, 0, 0, 0)]
|
||||
[InlineData("Audio,MusicArtist", 15, true, 15, 0, 15)]
|
||||
[InlineData("BoxSet", 10, true, 0, 0, 0)]
|
||||
public void GetExternalSearchLimits_UsesRequestedItemTypes(
|
||||
string? includeItemTypes,
|
||||
int limit,
|
||||
bool includePlaylistsAsAlbums,
|
||||
int expectedSongLimit,
|
||||
int expectedAlbumLimit,
|
||||
int expectedArtistLimit)
|
||||
{
|
||||
var requestedTypes = string.IsNullOrWhiteSpace(includeItemTypes)
|
||||
? null
|
||||
: includeItemTypes.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries);
|
||||
|
||||
var method = typeof(JellyfinController).GetMethod(
|
||||
"GetExternalSearchLimits",
|
||||
BindingFlags.Static | BindingFlags.NonPublic);
|
||||
|
||||
Assert.NotNull(method);
|
||||
|
||||
var result = ((int SongLimit, int AlbumLimit, int ArtistLimit))method!.Invoke(
|
||||
null,
|
||||
new object?[] { requestedTypes, limit, includePlaylistsAsAlbums })!;
|
||||
|
||||
Assert.Equal(expectedSongLimit, result.SongLimit);
|
||||
Assert.Equal(expectedAlbumLimit, result.AlbumLimit);
|
||||
Assert.Equal(expectedArtistLimit, result.ArtistLimit);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,65 @@
|
||||
using System.Reflection;
|
||||
using System.Text.Json;
|
||||
using allstarr.Controllers;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class JellyfinImageTagExtractionTests
|
||||
{
|
||||
[Fact]
|
||||
public void ExtractImageTag_WithMatchingImageTagsObject_ReturnsRequestedTag()
|
||||
{
|
||||
using var document = JsonDocument.Parse("""
|
||||
{
|
||||
"ImageTags": {
|
||||
"Primary": "playlist-primary-tag",
|
||||
"Backdrop": "playlist-backdrop-tag"
|
||||
}
|
||||
}
|
||||
""");
|
||||
|
||||
var imageTag = InvokeExtractImageTag(document.RootElement, "Primary");
|
||||
|
||||
Assert.Equal("playlist-primary-tag", imageTag);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ExtractImageTag_WithPrimaryImageTagFallback_ReturnsFallbackTag()
|
||||
{
|
||||
using var document = JsonDocument.Parse("""
|
||||
{
|
||||
"PrimaryImageTag": "primary-fallback-tag"
|
||||
}
|
||||
""");
|
||||
|
||||
var imageTag = InvokeExtractImageTag(document.RootElement, "Primary");
|
||||
|
||||
Assert.Equal("primary-fallback-tag", imageTag);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ExtractImageTag_WithoutMatchingTag_ReturnsNull()
|
||||
{
|
||||
using var document = JsonDocument.Parse("""
|
||||
{
|
||||
"ImageTags": {
|
||||
"Backdrop": "playlist-backdrop-tag"
|
||||
}
|
||||
}
|
||||
""");
|
||||
|
||||
var imageTag = InvokeExtractImageTag(document.RootElement, "Primary");
|
||||
|
||||
Assert.Null(imageTag);
|
||||
}
|
||||
|
||||
private static string? InvokeExtractImageTag(JsonElement item, string imageType)
|
||||
{
|
||||
var method = typeof(JellyfinController).GetMethod(
|
||||
"ExtractImageTag",
|
||||
BindingFlags.Static | BindingFlags.NonPublic);
|
||||
|
||||
Assert.NotNull(method);
|
||||
return (string?)method!.Invoke(null, new object?[] { item, imageType });
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,51 @@
|
||||
using System.Text.Json;
|
||||
using allstarr.Models.Domain;
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class JellyfinItemSnapshotHelperTests
|
||||
{
|
||||
[Fact]
|
||||
public void TryGetClonedRawItemSnapshot_RoundTripsThroughJsonSerialization()
|
||||
{
|
||||
var song = new Song { Id = "song-1", IsLocal = true };
|
||||
using var doc = JsonDocument.Parse("""
|
||||
{
|
||||
"Id": "song-1",
|
||||
"ServerId": "c17d351d3af24c678a6d8049c212d522",
|
||||
"RunTimeTicks": 2234068710,
|
||||
"MediaSources": [
|
||||
{
|
||||
"Id": "song-1",
|
||||
"RunTimeTicks": 2234068710
|
||||
}
|
||||
]
|
||||
}
|
||||
""");
|
||||
|
||||
JellyfinItemSnapshotHelper.StoreRawItemSnapshot(song, doc.RootElement);
|
||||
|
||||
var roundTripped = JsonSerializer.Deserialize<Song>(JsonSerializer.Serialize(song));
|
||||
|
||||
Assert.NotNull(roundTripped);
|
||||
Assert.True(JellyfinItemSnapshotHelper.TryGetClonedRawItemSnapshot(roundTripped, out var rawItem));
|
||||
|
||||
Assert.Equal("song-1", ((JsonElement)rawItem["Id"]!).GetString());
|
||||
Assert.Equal("c17d351d3af24c678a6d8049c212d522", ((JsonElement)rawItem["ServerId"]!).GetString());
|
||||
Assert.Equal(2234068710L, ((JsonElement)rawItem["RunTimeTicks"]!).GetInt64());
|
||||
|
||||
var mediaSources = (JsonElement)rawItem["MediaSources"]!;
|
||||
Assert.Equal(JsonValueKind.Array, mediaSources.ValueKind);
|
||||
Assert.Equal(2234068710L, mediaSources[0].GetProperty("RunTimeTicks").GetInt64());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void HasRawItemSnapshot_ReturnsFalse_WhenSnapshotMissing()
|
||||
{
|
||||
var song = new Song { Id = "song-1", IsLocal = true };
|
||||
|
||||
Assert.False(JellyfinItemSnapshotHelper.HasRawItemSnapshot(song));
|
||||
Assert.False(JellyfinItemSnapshotHelper.TryGetClonedRawItemSnapshot(song, out _));
|
||||
}
|
||||
}
|
||||
@@ -3,6 +3,7 @@ using Moq;
|
||||
using allstarr.Models.Domain;
|
||||
using allstarr.Models.Search;
|
||||
using allstarr.Models.Subsonic;
|
||||
using allstarr.Services.Common;
|
||||
using allstarr.Services.Jellyfin;
|
||||
using System.Text.Json;
|
||||
|
||||
@@ -220,6 +221,35 @@ public class JellyfinModelMapperTests
|
||||
Assert.Equal("Main Artist", song.Artist);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseSong_PreservesRawJellyfinItemSnapshot()
|
||||
{
|
||||
var json = @"{
|
||||
""Id"": ""song-abc"",
|
||||
""Name"": ""Test Song"",
|
||||
""Type"": ""Audio"",
|
||||
""Album"": ""Test Album"",
|
||||
""AlbumId"": ""album-123"",
|
||||
""RunTimeTicks"": 2450000000,
|
||||
""Artists"": [""Test Artist""],
|
||||
""MediaSources"": [
|
||||
{
|
||||
""Id"": ""song-abc"",
|
||||
""RunTimeTicks"": 2450000000
|
||||
}
|
||||
]
|
||||
}";
|
||||
var element = JsonDocument.Parse(json).RootElement;
|
||||
|
||||
var song = _mapper.ParseSong(element);
|
||||
|
||||
Assert.True(JellyfinItemSnapshotHelper.TryGetClonedRawItemSnapshot(song, out var rawItem));
|
||||
Assert.Equal("song-abc", ((JsonElement)rawItem["Id"]!).GetString());
|
||||
Assert.Equal(2450000000L, ((JsonElement)rawItem["RunTimeTicks"]!).GetInt64());
|
||||
Assert.NotNull(song.JellyfinMetadata);
|
||||
Assert.True(song.JellyfinMetadata!.ContainsKey("MediaSources"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ParseAlbum_ExtractsArtistId_FromAlbumArtists()
|
||||
{
|
||||
|
||||
@@ -0,0 +1,41 @@
|
||||
using System.Reflection;
|
||||
using allstarr.Controllers;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class JellyfinPlaylistRouteMatchingTests
|
||||
{
|
||||
[Theory]
|
||||
[InlineData("playlists/abc123/items", "abc123")]
|
||||
[InlineData("Playlists/abc123/Items", "abc123")]
|
||||
[InlineData("/playlists/abc123/items/", "abc123")]
|
||||
public void GetExactPlaylistItemsRequestId_ExactPlaylistItemsRoute_ReturnsPlaylistId(string path, string expectedPlaylistId)
|
||||
{
|
||||
var playlistId = InvokePrivateStatic<string?>("GetExactPlaylistItemsRequestId", path);
|
||||
|
||||
Assert.Equal(expectedPlaylistId, playlistId);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("playlists/abc123/items/extra")]
|
||||
[InlineData("users/user-1/playlists/abc123/items")]
|
||||
[InlineData("items/abc123")]
|
||||
[InlineData("playlists")]
|
||||
public void GetExactPlaylistItemsRequestId_NonExactRoute_ReturnsNull(string path)
|
||||
{
|
||||
var playlistId = InvokePrivateStatic<string?>("GetExactPlaylistItemsRequestId", path);
|
||||
|
||||
Assert.Null(playlistId);
|
||||
}
|
||||
|
||||
private static T InvokePrivateStatic<T>(string methodName, params object?[] args)
|
||||
{
|
||||
var method = typeof(JellyfinController).GetMethod(
|
||||
methodName,
|
||||
BindingFlags.NonPublic | BindingFlags.Static);
|
||||
|
||||
Assert.NotNull(method);
|
||||
var result = method!.Invoke(null, args);
|
||||
return (T)result!;
|
||||
}
|
||||
}
|
||||
@@ -117,6 +117,35 @@ public class JellyfinProxyServiceTests
|
||||
Assert.False(captured.Headers.Contains("X-Emby-Authorization"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetJsonAsync_WithXEmbyToken_ForwardsTokenHeader()
|
||||
{
|
||||
// Arrange
|
||||
HttpRequestMessage? captured = null;
|
||||
_mockHandler.Protected()
|
||||
.Setup<Task<HttpResponseMessage>>("SendAsync",
|
||||
ItExpr.IsAny<HttpRequestMessage>(),
|
||||
ItExpr.IsAny<CancellationToken>())
|
||||
.Callback<HttpRequestMessage, CancellationToken>((req, ct) => captured = req)
|
||||
.ReturnsAsync(new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("{}")
|
||||
});
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Token"] = "token-123"
|
||||
};
|
||||
|
||||
// Act
|
||||
await _service.GetJsonAsync("Items", null, headers);
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(captured);
|
||||
Assert.True(captured!.Headers.TryGetValues("X-Emby-Token", out var values));
|
||||
Assert.Contains("token-123", values);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetBytesAsync_ReturnsBodyAndContentType()
|
||||
{
|
||||
@@ -254,6 +283,197 @@ public class JellyfinProxyServiceTests
|
||||
Assert.Equal("DateCreated,PremiereDate,ProductionYear", query.Get("Fields"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetJsonAsync_WithRepeatedFields_PreservesAllFieldParameters()
|
||||
{
|
||||
// Arrange
|
||||
HttpRequestMessage? captured = null;
|
||||
_mockHandler.Protected()
|
||||
.Setup<Task<HttpResponseMessage>>("SendAsync",
|
||||
ItExpr.IsAny<HttpRequestMessage>(),
|
||||
ItExpr.IsAny<CancellationToken>())
|
||||
.Callback<HttpRequestMessage, CancellationToken>((req, ct) => captured = req)
|
||||
.ReturnsAsync(new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("{\"Items\":[]}")
|
||||
});
|
||||
|
||||
// Act
|
||||
await _service.GetJsonAsync(
|
||||
"Playlists/playlist-123/Items?Fields=Genres&Fields=DateCreated&Fields=MediaSources&UserId=user-abc");
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(captured);
|
||||
var query = captured!.RequestUri!.Query;
|
||||
Assert.Contains("Fields=Genres", query);
|
||||
Assert.Contains("Fields=DateCreated", query);
|
||||
Assert.Contains("Fields=MediaSources", query);
|
||||
Assert.Contains("UserId=user-abc", query);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetPassthroughResponseAsync_WithRepeatedFields_PreservesAllFieldParameters()
|
||||
{
|
||||
// Arrange
|
||||
HttpRequestMessage? captured = null;
|
||||
_mockHandler.Protected()
|
||||
.Setup<Task<HttpResponseMessage>>("SendAsync",
|
||||
ItExpr.IsAny<HttpRequestMessage>(),
|
||||
ItExpr.IsAny<CancellationToken>())
|
||||
.Callback<HttpRequestMessage, CancellationToken>((req, ct) => captured = req)
|
||||
.ReturnsAsync(new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("{\"Items\":[]}")
|
||||
});
|
||||
|
||||
// Act
|
||||
var response = await _service.GetPassthroughResponseAsync(
|
||||
"Playlists/playlist-123/Items?Fields=Genres&Fields=DateCreated&Fields=MediaSources&UserId=user-abc");
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(captured);
|
||||
var query = captured!.RequestUri!.Query;
|
||||
Assert.Contains("Fields=Genres", query);
|
||||
Assert.Contains("Fields=DateCreated", query);
|
||||
Assert.Contains("Fields=MediaSources", query);
|
||||
Assert.Contains("UserId=user-abc", query);
|
||||
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetPassthroughResponseAsync_WithClientAuth_ForwardsAuthHeader()
|
||||
{
|
||||
// Arrange
|
||||
HttpRequestMessage? captured = null;
|
||||
_mockHandler.Protected()
|
||||
.Setup<Task<HttpResponseMessage>>("SendAsync",
|
||||
ItExpr.IsAny<HttpRequestMessage>(),
|
||||
ItExpr.IsAny<CancellationToken>())
|
||||
.Callback<HttpRequestMessage, CancellationToken>((req, ct) => captured = req)
|
||||
.ReturnsAsync(new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("{\"Items\":[]}")
|
||||
});
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Authorization"] = "MediaBrowser Token=\"abc\""
|
||||
};
|
||||
|
||||
// Act
|
||||
var response = await _service.GetPassthroughResponseAsync(
|
||||
"Playlists/playlist-123/Items?Fields=Genres",
|
||||
headers);
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(captured);
|
||||
Assert.True(captured!.Headers.TryGetValues("X-Emby-Authorization", out var values));
|
||||
Assert.Contains("MediaBrowser Token=\"abc\"", values);
|
||||
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SendAsync_WithNoBody_PreservesEmptyRequestBody()
|
||||
{
|
||||
// Arrange
|
||||
HttpRequestMessage? captured = null;
|
||||
_mockHandler.Protected()
|
||||
.Setup<Task<HttpResponseMessage>>("SendAsync",
|
||||
ItExpr.IsAny<HttpRequestMessage>(),
|
||||
ItExpr.IsAny<CancellationToken>())
|
||||
.Callback<HttpRequestMessage, CancellationToken>((req, _) => captured = req)
|
||||
.ReturnsAsync(new HttpResponseMessage(HttpStatusCode.NoContent));
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Authorization"] = "MediaBrowser Token=\"abc\""
|
||||
};
|
||||
|
||||
// Act
|
||||
var (_, statusCode) = await _service.SendAsync(
|
||||
HttpMethod.Post,
|
||||
"Sessions/session-123/Playing/Pause?controllingUserId=user-123",
|
||||
null,
|
||||
headers);
|
||||
|
||||
// Assert
|
||||
Assert.Equal(204, statusCode);
|
||||
Assert.NotNull(captured);
|
||||
Assert.Equal(HttpMethod.Post, captured!.Method);
|
||||
Assert.Null(captured.Content);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SendAsync_WithCustomContentType_PreservesOriginalType()
|
||||
{
|
||||
// Arrange
|
||||
HttpRequestMessage? captured = null;
|
||||
_mockHandler.Protected()
|
||||
.Setup<Task<HttpResponseMessage>>("SendAsync",
|
||||
ItExpr.IsAny<HttpRequestMessage>(),
|
||||
ItExpr.IsAny<CancellationToken>())
|
||||
.Callback<HttpRequestMessage, CancellationToken>((req, _) => captured = req)
|
||||
.ReturnsAsync(new HttpResponseMessage(HttpStatusCode.NoContent));
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Authorization"] = "MediaBrowser Token=\"abc\""
|
||||
};
|
||||
|
||||
// Act
|
||||
await _service.SendAsync(
|
||||
HttpMethod.Put,
|
||||
"Sessions/session-123/Command/DisplayMessage",
|
||||
"{\"Text\":\"hello\"}",
|
||||
headers,
|
||||
"application/json; charset=utf-8");
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(captured);
|
||||
Assert.Equal(HttpMethod.Put, captured!.Method);
|
||||
Assert.NotNull(captured.Content);
|
||||
Assert.Equal("application/json; charset=utf-8", captured.Content!.Headers.ContentType!.ToString());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetPassthroughResponseAsync_WithAcceptEncoding_ForwardsCompressionHeaders()
|
||||
{
|
||||
// Arrange
|
||||
HttpRequestMessage? captured = null;
|
||||
_mockHandler.Protected()
|
||||
.Setup<Task<HttpResponseMessage>>("SendAsync",
|
||||
ItExpr.IsAny<HttpRequestMessage>(),
|
||||
ItExpr.IsAny<CancellationToken>())
|
||||
.Callback<HttpRequestMessage, CancellationToken>((req, ct) => captured = req)
|
||||
.ReturnsAsync(new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("{\"Items\":[]}")
|
||||
});
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["Accept-Encoding"] = "gzip, br",
|
||||
["User-Agent"] = "Finamp/1.0",
|
||||
["Accept-Language"] = "en-US"
|
||||
};
|
||||
|
||||
// Act
|
||||
var response = await _service.GetPassthroughResponseAsync(
|
||||
"Playlists/playlist-123/Items?Fields=Genres",
|
||||
headers);
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(captured);
|
||||
Assert.True(captured!.Headers.TryGetValues("Accept-Encoding", out var encodings));
|
||||
Assert.Contains("gzip", encodings);
|
||||
Assert.Contains("br", encodings);
|
||||
Assert.True(captured.Headers.TryGetValues("User-Agent", out var userAgents));
|
||||
Assert.Contains("Finamp/1.0", userAgents);
|
||||
Assert.True(captured.Headers.TryGetValues("Accept-Language", out var languages));
|
||||
Assert.Contains("en-US", languages);
|
||||
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetJsonAsync_WithEndpointAndExplicitQuery_MergesWithExplicitPrecedence()
|
||||
{
|
||||
|
||||
@@ -47,6 +47,8 @@ public class JellyfinResponseBuilderTests
|
||||
Assert.Equal(1, result["ParentIndexNumber"]);
|
||||
Assert.Equal(2023, result["ProductionYear"]);
|
||||
Assert.Equal(245 * TimeSpan.TicksPerSecond, result["RunTimeTicks"]);
|
||||
Assert.NotNull(result["AudioInfo"]);
|
||||
Assert.Equal(false, result["CanDelete"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
@@ -75,6 +77,44 @@ public class JellyfinResponseBuilderTests
|
||||
Assert.Equal("USRC12345678", providerIds["ISRC"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ConvertSongToJellyfinItem_ExternalExplicitSong_AppendsStreamingAndExplicitLabels()
|
||||
{
|
||||
var song = new Song
|
||||
{
|
||||
Id = "ext-squidwtf-song-12345",
|
||||
Title = "Sunflower",
|
||||
Artist = "Artist",
|
||||
IsLocal = false,
|
||||
ExternalProvider = "squidwtf",
|
||||
ExternalId = "12345",
|
||||
ExplicitContentLyrics = 1
|
||||
};
|
||||
|
||||
var result = _builder.ConvertSongToJellyfinItem(song);
|
||||
|
||||
Assert.Equal("Sunflower [S] [E]", result["Name"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ConvertSongToJellyfinItem_ExternalCleanSong_AppendsOnlyStreamingLabel()
|
||||
{
|
||||
var song = new Song
|
||||
{
|
||||
Id = "ext-squidwtf-song-12345",
|
||||
Title = "Sunflower",
|
||||
Artist = "Artist",
|
||||
IsLocal = false,
|
||||
ExternalProvider = "squidwtf",
|
||||
ExternalId = "12345",
|
||||
ExplicitContentLyrics = 0
|
||||
};
|
||||
|
||||
var result = _builder.ConvertSongToJellyfinItem(song);
|
||||
|
||||
Assert.Equal("Sunflower [S]", result["Name"]);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("deezer")]
|
||||
[InlineData("qobuz")]
|
||||
@@ -154,6 +194,9 @@ public class JellyfinResponseBuilderTests
|
||||
Assert.Equal("Famous Band", result["AlbumArtist"]);
|
||||
Assert.Equal(2020, result["ProductionYear"]);
|
||||
Assert.Equal(12, result["ChildCount"]);
|
||||
Assert.Equal("Greatest Hits", result["SortName"]);
|
||||
Assert.NotNull(result["DateCreated"]);
|
||||
Assert.NotNull(result["BasicSyncInfo"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
@@ -177,6 +220,9 @@ public class JellyfinResponseBuilderTests
|
||||
Assert.Equal("MusicArtist", result["Type"]);
|
||||
Assert.Equal(true, result["IsFolder"]);
|
||||
Assert.Equal(5, result["AlbumCount"]);
|
||||
Assert.Equal("The Rockers", result["SortName"]);
|
||||
Assert.Equal(1.0, result["PrimaryImageAspectRatio"]);
|
||||
Assert.NotNull(result["BasicSyncInfo"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
@@ -205,6 +251,9 @@ public class JellyfinResponseBuilderTests
|
||||
Assert.Equal("DJ Cool", result["AlbumArtist"]);
|
||||
Assert.Equal(50, result["ChildCount"]);
|
||||
Assert.Equal(2023, result["ProductionYear"]);
|
||||
Assert.Equal("Summer Vibes [S/P]", result["SortName"]);
|
||||
Assert.NotNull(result["DateCreated"]);
|
||||
Assert.NotNull(result["BasicSyncInfo"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
|
||||
@@ -0,0 +1,224 @@
|
||||
using System.Reflection;
|
||||
using System.Runtime.CompilerServices;
|
||||
using allstarr.Controllers;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class JellyfinSearchInterleaveTests
|
||||
{
|
||||
[Fact]
|
||||
public void InterleaveByScore_PrimaryOnly_PreservesOriginalOrder()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var primary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("zzz filler"),
|
||||
CreateItem("BTS Anthem")
|
||||
};
|
||||
|
||||
var result = InvokeInterleaveByScore(controller, primary, [], "bts", 5.0);
|
||||
|
||||
Assert.Equal(["zzz filler", "BTS Anthem"], result.Select(GetName));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void InterleaveByScore_SecondaryOnly_PreservesOriginalOrder()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var secondary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("zzz filler"),
|
||||
CreateItem("BTS Anthem")
|
||||
};
|
||||
|
||||
var result = InvokeInterleaveByScore(controller, [], secondary, "bts", 5.0);
|
||||
|
||||
Assert.Equal(["zzz filler", "BTS Anthem"], result.Select(GetName));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void InterleaveByScore_StrongerHeadMatch_LeadsWithoutReorderingSource()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var primary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("luther remastered"),
|
||||
CreateItem("zzz filler")
|
||||
};
|
||||
var secondary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("luther"),
|
||||
CreateItem("yyy filler")
|
||||
};
|
||||
|
||||
var result = InvokeInterleaveByScore(controller, primary, secondary, "luther", 0.0);
|
||||
|
||||
Assert.Equal(["luther", "luther remastered", "zzz filler", "yyy filler"], result.Select(GetName));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void InterleaveByScore_TiedScores_PreferPrimaryQueueHead()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var primary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("bts", "p1"),
|
||||
CreateItem("bts", "p2")
|
||||
};
|
||||
var secondary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("bts", "s1"),
|
||||
CreateItem("bts", "s2")
|
||||
};
|
||||
|
||||
var result = InvokeInterleaveByScore(controller, primary, secondary, "bts", 0.0);
|
||||
|
||||
Assert.Equal(["p1", "p2", "s1", "s2"], result.Select(GetId));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void InterleaveByScore_StrongerLaterPrimaryHead_DoesNotBypassCurrentQueueHead()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var primary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("zzz filler", "p1"),
|
||||
CreateItem("bts local later", "p2")
|
||||
};
|
||||
var secondary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("bts", "s1"),
|
||||
CreateItem("bts live", "s2")
|
||||
};
|
||||
|
||||
var result = InvokeInterleaveByScore(controller, primary, secondary, "bts", 0.0);
|
||||
|
||||
Assert.Equal(["s1", "s2", "p1", "p2"], result.Select(GetId));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void InterleaveByScore_JellyfinBoost_CanWinCloseHeadToHead()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var primary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("luther remastered", "p1")
|
||||
};
|
||||
var secondary = new List<Dictionary<string, object?>>
|
||||
{
|
||||
CreateItem("luther", "s1")
|
||||
};
|
||||
|
||||
var result = InvokeInterleaveByScore(controller, primary, secondary, "luther", 5.0);
|
||||
|
||||
Assert.Equal(["p1", "s1"], result.Select(GetId));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CalculateItemRelevanceScore_SongUsesArtistContext()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var withArtist = CreateTypedItem("Audio", "cardigan", "song-with-artist");
|
||||
withArtist["Artists"] = new[] { "Taylor Swift" };
|
||||
|
||||
var withoutArtist = CreateTypedItem("Audio", "cardigan", "song-without-artist");
|
||||
|
||||
var withArtistScore = InvokeCalculateItemRelevanceScore(controller, "taylor swift", withArtist);
|
||||
var withoutArtistScore = InvokeCalculateItemRelevanceScore(controller, "taylor swift", withoutArtist);
|
||||
|
||||
Assert.True(withArtistScore > withoutArtistScore);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CalculateItemRelevanceScore_AlbumUsesArtistContext()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var withArtist = CreateTypedItem("MusicAlbum", "folklore", "album-with-artist");
|
||||
withArtist["AlbumArtist"] = "Taylor Swift";
|
||||
|
||||
var withoutArtist = CreateTypedItem("MusicAlbum", "folklore", "album-without-artist");
|
||||
|
||||
var withArtistScore = InvokeCalculateItemRelevanceScore(controller, "taylor swift", withArtist);
|
||||
var withoutArtistScore = InvokeCalculateItemRelevanceScore(controller, "taylor swift", withoutArtist);
|
||||
|
||||
Assert.True(withArtistScore > withoutArtistScore);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CalculateItemRelevanceScore_ArtistIgnoresNonNameMetadata()
|
||||
{
|
||||
var controller = CreateController();
|
||||
var plainArtist = CreateTypedItem("MusicArtist", "Taylor Swift", "artist-plain");
|
||||
var noisyArtist = CreateTypedItem("MusicArtist", "Taylor Swift", "artist-noisy");
|
||||
noisyArtist["AlbumArtist"] = "Completely Different";
|
||||
noisyArtist["Artists"] = new[] { "Someone Else" };
|
||||
|
||||
var plainScore = InvokeCalculateItemRelevanceScore(controller, "taylor swift", plainArtist);
|
||||
var noisyScore = InvokeCalculateItemRelevanceScore(controller, "taylor swift", noisyArtist);
|
||||
|
||||
Assert.Equal(plainScore, noisyScore);
|
||||
}
|
||||
|
||||
private static JellyfinController CreateController()
|
||||
{
|
||||
return (JellyfinController)RuntimeHelpers.GetUninitializedObject(typeof(JellyfinController));
|
||||
}
|
||||
|
||||
private static List<Dictionary<string, object?>> InvokeInterleaveByScore(
|
||||
JellyfinController controller,
|
||||
List<Dictionary<string, object?>> primary,
|
||||
List<Dictionary<string, object?>> secondary,
|
||||
string query,
|
||||
double primaryBoost)
|
||||
{
|
||||
var method = typeof(JellyfinController).GetMethod(
|
||||
"InterleaveByScore",
|
||||
BindingFlags.Instance | BindingFlags.NonPublic);
|
||||
|
||||
Assert.NotNull(method);
|
||||
|
||||
return (List<Dictionary<string, object?>>)method!.Invoke(
|
||||
controller,
|
||||
[primary, secondary, query, primaryBoost])!;
|
||||
}
|
||||
|
||||
private static double InvokeCalculateItemRelevanceScore(
|
||||
JellyfinController controller,
|
||||
string query,
|
||||
Dictionary<string, object?> item)
|
||||
{
|
||||
var method = typeof(JellyfinController).GetMethod(
|
||||
"CalculateItemRelevanceScore",
|
||||
BindingFlags.Instance | BindingFlags.NonPublic);
|
||||
|
||||
Assert.NotNull(method);
|
||||
|
||||
return (double)method!.Invoke(controller, [query, item])!;
|
||||
}
|
||||
|
||||
private static Dictionary<string, object?> CreateItem(string name, string? id = null)
|
||||
{
|
||||
return new Dictionary<string, object?>
|
||||
{
|
||||
["Name"] = name,
|
||||
["Id"] = id ?? name
|
||||
};
|
||||
}
|
||||
|
||||
private static Dictionary<string, object?> CreateTypedItem(string type, string name, string id)
|
||||
{
|
||||
var item = CreateItem(name, id);
|
||||
item["Type"] = type;
|
||||
return item;
|
||||
}
|
||||
|
||||
private static string GetName(Dictionary<string, object?> item)
|
||||
{
|
||||
return item["Name"]?.ToString() ?? string.Empty;
|
||||
}
|
||||
|
||||
private static string GetId(Dictionary<string, object?> item)
|
||||
{
|
||||
return item["Id"]?.ToString() ?? string.Empty;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,38 @@
|
||||
using System.Reflection;
|
||||
using allstarr.Controllers;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class JellyfinSearchResponseSerializationTests
|
||||
{
|
||||
[Fact]
|
||||
public void SerializeSearchResponseJson_PreservesPascalCaseShape()
|
||||
{
|
||||
var payload = new
|
||||
{
|
||||
Items = new[]
|
||||
{
|
||||
new Dictionary<string, object?>
|
||||
{
|
||||
["Name"] = "BTS",
|
||||
["Type"] = "MusicAlbum"
|
||||
}
|
||||
},
|
||||
TotalRecordCount = 1,
|
||||
StartIndex = 0
|
||||
};
|
||||
|
||||
var method = typeof(JellyfinController).GetMethod(
|
||||
"SerializeSearchResponseJson",
|
||||
BindingFlags.NonPublic | BindingFlags.Static);
|
||||
|
||||
Assert.NotNull(method);
|
||||
|
||||
var closedMethod = method!.MakeGenericMethod(payload.GetType());
|
||||
var json = (string)closedMethod.Invoke(null, new object?[] { payload })!;
|
||||
|
||||
Assert.Equal(
|
||||
"{\"Items\":[{\"Name\":\"BTS\",\"Type\":\"MusicAlbum\"}],\"TotalRecordCount\":1,\"StartIndex\":0}",
|
||||
json);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,226 @@
|
||||
using System.Collections.Concurrent;
|
||||
using System.Net;
|
||||
using Microsoft.AspNetCore.Http;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Microsoft.Extensions.Options;
|
||||
using allstarr.Models.Settings;
|
||||
using allstarr.Services.Common;
|
||||
using allstarr.Services.Jellyfin;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class JellyfinSessionManagerTests
|
||||
{
|
||||
[Fact]
|
||||
public async Task MarkSessionPotentiallyEnded_DoesNotAutoRemoveSession()
|
||||
{
|
||||
var handler = new DelegateHttpMessageHandler((_, _) =>
|
||||
Task.FromResult(new HttpResponseMessage(HttpStatusCode.NoContent)));
|
||||
|
||||
var settings = new JellyfinSettings
|
||||
{
|
||||
Url = "http://127.0.0.1:1",
|
||||
ApiKey = "server-api-key",
|
||||
ClientName = "Allstarr",
|
||||
DeviceName = "Allstarr",
|
||||
DeviceId = "allstarr",
|
||||
ClientVersion = "1.0"
|
||||
};
|
||||
|
||||
var proxyService = CreateProxyService(handler, settings);
|
||||
using var manager = new JellyfinSessionManager(
|
||||
proxyService,
|
||||
Options.Create(settings),
|
||||
NullLogger<JellyfinSessionManager>.Instance);
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Authorization"] =
|
||||
"MediaBrowser Client=\"Feishin\", Device=\"Desktop\", DeviceId=\"dev-123\", Version=\"1.0\", Token=\"abc\""
|
||||
};
|
||||
|
||||
var ensured = await manager.EnsureSessionAsync("dev-123", "Feishin", "Desktop", "1.0", headers);
|
||||
Assert.True(ensured);
|
||||
|
||||
manager.MarkSessionPotentiallyEnded("dev-123", TimeSpan.FromMilliseconds(25));
|
||||
await Task.Delay(100);
|
||||
|
||||
Assert.True(manager.HasSession("dev-123"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RemoveSessionAsync_ReportsPlaybackStopButDoesNotLogoutUserSession()
|
||||
{
|
||||
var requestedPaths = new ConcurrentBag<string>();
|
||||
var handler = new DelegateHttpMessageHandler((request, _) =>
|
||||
{
|
||||
requestedPaths.Add(request.RequestUri?.AbsolutePath ?? string.Empty);
|
||||
return Task.FromResult(new HttpResponseMessage(HttpStatusCode.NoContent));
|
||||
});
|
||||
|
||||
var settings = new JellyfinSettings
|
||||
{
|
||||
Url = "http://127.0.0.1:1",
|
||||
ApiKey = "server-api-key",
|
||||
ClientName = "Allstarr",
|
||||
DeviceName = "Allstarr",
|
||||
DeviceId = "allstarr",
|
||||
ClientVersion = "1.0"
|
||||
};
|
||||
|
||||
var proxyService = CreateProxyService(handler, settings);
|
||||
using var manager = new JellyfinSessionManager(
|
||||
proxyService,
|
||||
Options.Create(settings),
|
||||
NullLogger<JellyfinSessionManager>.Instance);
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Authorization"] =
|
||||
"MediaBrowser Client=\"Feishin\", Device=\"Desktop\", DeviceId=\"dev-123\", Version=\"1.0\", Token=\"abc\""
|
||||
};
|
||||
|
||||
var ensured = await manager.EnsureSessionAsync("dev-123", "Feishin", "Desktop", "1.0", headers);
|
||||
Assert.True(ensured);
|
||||
|
||||
manager.UpdatePlayingItem("dev-123", "item-123", 42);
|
||||
await manager.RemoveSessionAsync("dev-123");
|
||||
|
||||
Assert.Contains("/Sessions/Capabilities/Full", requestedPaths);
|
||||
Assert.Contains("/Sessions/Playing/Stopped", requestedPaths);
|
||||
Assert.DoesNotContain("/Sessions/Logout", requestedPaths);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetActivePlaybackStates_ReturnsTrackedPlayingItems()
|
||||
{
|
||||
var handler = new DelegateHttpMessageHandler((_, _) =>
|
||||
Task.FromResult(new HttpResponseMessage(HttpStatusCode.NoContent)));
|
||||
|
||||
var settings = new JellyfinSettings
|
||||
{
|
||||
Url = "http://127.0.0.1:1",
|
||||
ApiKey = "server-api-key",
|
||||
ClientName = "Allstarr",
|
||||
DeviceName = "Allstarr",
|
||||
DeviceId = "allstarr",
|
||||
ClientVersion = "1.0"
|
||||
};
|
||||
|
||||
var proxyService = CreateProxyService(handler, settings);
|
||||
using var manager = new JellyfinSessionManager(
|
||||
proxyService,
|
||||
Options.Create(settings),
|
||||
NullLogger<JellyfinSessionManager>.Instance);
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Authorization"] =
|
||||
"MediaBrowser Client=\"Feishin\", Device=\"Desktop\", DeviceId=\"dev-123\", Version=\"1.0\", Token=\"abc\""
|
||||
};
|
||||
|
||||
var ensured = await manager.EnsureSessionAsync("dev-123", "Feishin", "Desktop", "1.0", headers);
|
||||
Assert.True(ensured);
|
||||
|
||||
manager.UpdatePlayingItem("dev-123", "ext-squidwtf-song-35734823", 45 * TimeSpan.TicksPerSecond);
|
||||
|
||||
var states = manager.GetActivePlaybackStates(TimeSpan.FromMinutes(1));
|
||||
|
||||
var state = Assert.Single(states);
|
||||
Assert.Equal("dev-123", state.DeviceId);
|
||||
Assert.Equal("ext-squidwtf-song-35734823", state.ItemId);
|
||||
Assert.Equal(45 * TimeSpan.TicksPerSecond, state.PositionTicks);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsureSessionAsync_WithProxiedWebSocket_DoesNotPostSyntheticCapabilities()
|
||||
{
|
||||
var requestedPaths = new ConcurrentBag<string>();
|
||||
var handler = new DelegateHttpMessageHandler((request, _) =>
|
||||
{
|
||||
requestedPaths.Add(request.RequestUri?.AbsolutePath ?? string.Empty);
|
||||
return Task.FromResult(new HttpResponseMessage(HttpStatusCode.NoContent));
|
||||
});
|
||||
|
||||
var settings = new JellyfinSettings
|
||||
{
|
||||
Url = "http://127.0.0.1:1",
|
||||
ApiKey = "server-api-key",
|
||||
ClientName = "Allstarr",
|
||||
DeviceName = "Allstarr",
|
||||
DeviceId = "allstarr",
|
||||
ClientVersion = "1.0"
|
||||
};
|
||||
|
||||
var proxyService = CreateProxyService(handler, settings);
|
||||
using var manager = new JellyfinSessionManager(
|
||||
proxyService,
|
||||
Options.Create(settings),
|
||||
NullLogger<JellyfinSessionManager>.Instance);
|
||||
|
||||
var headers = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Authorization"] =
|
||||
"MediaBrowser Client=\"Finamp\", Device=\"Android Auto\", DeviceId=\"dev-123\", Version=\"1.0\", Token=\"abc\""
|
||||
};
|
||||
|
||||
await manager.RegisterProxiedWebSocketAsync("dev-123");
|
||||
|
||||
var ensured = await manager.EnsureSessionAsync("dev-123", "Finamp", "Android Auto", "1.0", headers);
|
||||
|
||||
Assert.True(ensured);
|
||||
Assert.DoesNotContain("/Sessions/Capabilities/Full", requestedPaths);
|
||||
}
|
||||
|
||||
private static JellyfinProxyService CreateProxyService(HttpMessageHandler handler, JellyfinSettings settings)
|
||||
{
|
||||
var httpClientFactory = new TestHttpClientFactory(handler);
|
||||
var httpContextAccessor = new HttpContextAccessor
|
||||
{
|
||||
HttpContext = new DefaultHttpContext()
|
||||
};
|
||||
|
||||
var cache = new RedisCacheService(
|
||||
Options.Create(new RedisSettings { Enabled = false }),
|
||||
NullLogger<RedisCacheService>.Instance);
|
||||
|
||||
return new JellyfinProxyService(
|
||||
httpClientFactory,
|
||||
Options.Create(settings),
|
||||
httpContextAccessor,
|
||||
NullLogger<JellyfinProxyService>.Instance,
|
||||
cache);
|
||||
}
|
||||
|
||||
private sealed class TestHttpClientFactory : IHttpClientFactory
|
||||
{
|
||||
private readonly HttpClient _client;
|
||||
|
||||
public TestHttpClientFactory(HttpMessageHandler handler)
|
||||
{
|
||||
_client = new HttpClient(handler, disposeHandler: false);
|
||||
}
|
||||
|
||||
public HttpClient CreateClient(string name)
|
||||
{
|
||||
return _client;
|
||||
}
|
||||
}
|
||||
|
||||
private sealed class DelegateHttpMessageHandler : HttpMessageHandler
|
||||
{
|
||||
private readonly Func<HttpRequestMessage, CancellationToken, Task<HttpResponseMessage>> _handler;
|
||||
|
||||
public DelegateHttpMessageHandler(Func<HttpRequestMessage, CancellationToken, Task<HttpResponseMessage>> handler)
|
||||
{
|
||||
_handler = handler;
|
||||
}
|
||||
|
||||
protected override Task<HttpResponseMessage> SendAsync(
|
||||
HttpRequestMessage request,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
return _handler(request, cancellationToken);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,88 @@
|
||||
using allstarr.Services.Common;
|
||||
using Microsoft.Extensions.Configuration;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public sealed class RuntimeEnvConfigurationTests : IDisposable
|
||||
{
|
||||
private readonly string _envFilePath = Path.Combine(
|
||||
Path.GetTempPath(),
|
||||
$"allstarr-runtime-{Guid.NewGuid():N}.env");
|
||||
|
||||
[Fact]
|
||||
public void MapEnvVarToConfiguration_MapsFlatKeyToNestedConfigKey()
|
||||
{
|
||||
var mappings = RuntimeEnvConfiguration
|
||||
.MapEnvVarToConfiguration("SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS", "7")
|
||||
.ToList();
|
||||
|
||||
var mapping = Assert.Single(mappings);
|
||||
Assert.Equal("SpotifyImport:MatchingIntervalHours", mapping.Key);
|
||||
Assert.Equal("7", mapping.Value);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MapEnvVarToConfiguration_MapsSharedBackendKeysToBothSections()
|
||||
{
|
||||
var mappings = RuntimeEnvConfiguration
|
||||
.MapEnvVarToConfiguration("MUSIC_SERVICE", "Qobuz")
|
||||
.OrderBy(x => x.Key, StringComparer.Ordinal)
|
||||
.ToList();
|
||||
|
||||
Assert.Equal(2, mappings.Count);
|
||||
Assert.Equal("Jellyfin:MusicService", mappings[0].Key);
|
||||
Assert.Equal("Qobuz", mappings[0].Value);
|
||||
Assert.Equal("Subsonic:MusicService", mappings[1].Key);
|
||||
Assert.Equal("Qobuz", mappings[1].Value);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MapEnvVarToConfiguration_IgnoresComposeOnlyMountKeys()
|
||||
{
|
||||
var mappings = RuntimeEnvConfiguration
|
||||
.MapEnvVarToConfiguration("DOWNLOAD_PATH", "./downloads")
|
||||
.ToList();
|
||||
|
||||
Assert.Empty(mappings);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadDotEnvOverrides_StripsQuotesAndSupportsDoubleUnderscoreKeys()
|
||||
{
|
||||
File.WriteAllText(
|
||||
_envFilePath,
|
||||
"""
|
||||
SPOTIFY_API_SESSION_COOKIE="secret-cookie"
|
||||
Admin__EnableEnvExport=true
|
||||
""");
|
||||
|
||||
var overrides = RuntimeEnvConfiguration.LoadDotEnvOverrides(_envFilePath);
|
||||
|
||||
Assert.Equal("secret-cookie", overrides["SpotifyApi:SessionCookie"]);
|
||||
Assert.Equal("true", overrides["Admin:EnableEnvExport"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AddDotEnvOverrides_OverridesEarlierConfigurationValues()
|
||||
{
|
||||
File.WriteAllText(_envFilePath, "SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS=7\n");
|
||||
|
||||
var configuration = new ConfigurationManager();
|
||||
configuration.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["SpotifyImport:MatchingIntervalHours"] = "24"
|
||||
});
|
||||
|
||||
RuntimeEnvConfiguration.AddDotEnvOverrides(configuration, _envFilePath);
|
||||
|
||||
Assert.Equal(7, configuration.GetValue<int>("SpotifyImport:MatchingIntervalHours"));
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (File.Exists(_envFilePath))
|
||||
{
|
||||
File.Delete(_envFilePath);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -157,6 +157,31 @@ public class SpotifyApiClientTests
|
||||
Assert.Equal(new DateTime(2026, 2, 16, 5, 0, 0, DateTimeKind.Utc), track.AddedAt);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void TryGetSpotifyPlaylistItemCount_ParsesAttributesArrayEntries()
|
||||
{
|
||||
// Arrange
|
||||
using var doc = JsonDocument.Parse("""
|
||||
{
|
||||
"attributes": [
|
||||
{ "key": "core:item_count", "value": "42" }
|
||||
]
|
||||
}
|
||||
""");
|
||||
|
||||
var method = typeof(SpotifyApiClient).GetMethod(
|
||||
"TryGetSpotifyPlaylistItemCount",
|
||||
BindingFlags.Static | BindingFlags.NonPublic);
|
||||
|
||||
Assert.NotNull(method);
|
||||
|
||||
// Act
|
||||
var result = (int)method!.Invoke(null, new object?[] { doc.RootElement })!;
|
||||
|
||||
// Assert
|
||||
Assert.Equal(42, result);
|
||||
}
|
||||
|
||||
private static T InvokePrivateMethod<T>(object instance, string methodName, params object?[] args)
|
||||
{
|
||||
var method = instance.GetType().GetMethod(methodName, BindingFlags.Instance | BindingFlags.NonPublic);
|
||||
|
||||
@@ -0,0 +1,115 @@
|
||||
using allstarr.Models.Domain;
|
||||
using allstarr.Models.Spotify;
|
||||
using allstarr.Services.Common;
|
||||
using System.Text.Json;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class SpotifyPlaylistCountHelperTests
|
||||
{
|
||||
[Fact]
|
||||
public void ComputeServedItemCount_UsesExactCachedCount_WhenAvailable()
|
||||
{
|
||||
var matchedTracks = new List<MatchedTrack>
|
||||
{
|
||||
new() { MatchedSong = new Song { IsLocal = false } },
|
||||
new() { MatchedSong = new Song { IsLocal = false } }
|
||||
};
|
||||
|
||||
var count = SpotifyPlaylistCountHelper.ComputeServedItemCount(50, 9, matchedTracks);
|
||||
|
||||
Assert.Equal(50, count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComputeServedItemCount_FallsBackToLocalPlusExternalMatched()
|
||||
{
|
||||
var matchedTracks = new List<MatchedTrack>
|
||||
{
|
||||
new() { MatchedSong = new Song { IsLocal = true } },
|
||||
new() { MatchedSong = new Song { IsLocal = false } },
|
||||
new() { MatchedSong = new Song { IsLocal = false } }
|
||||
};
|
||||
|
||||
var count = SpotifyPlaylistCountHelper.ComputeServedItemCount(null, 9, matchedTracks);
|
||||
|
||||
Assert.Equal(11, count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CountExternalMatchedTracks_IgnoresLocalMatches()
|
||||
{
|
||||
var matchedTracks = new List<MatchedTrack>
|
||||
{
|
||||
new() { MatchedSong = new Song { IsLocal = true } },
|
||||
new() { MatchedSong = new Song { IsLocal = false } },
|
||||
new() { MatchedSong = new Song { IsLocal = false } }
|
||||
};
|
||||
|
||||
Assert.Equal(2, SpotifyPlaylistCountHelper.CountExternalMatchedTracks(matchedTracks));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SumExternalMatchedRunTimeTicks_IgnoresLocalMatches()
|
||||
{
|
||||
var matchedTracks = new List<MatchedTrack>
|
||||
{
|
||||
new() { MatchedSong = new Song { IsLocal = true, Duration = 100 } },
|
||||
new() { MatchedSong = new Song { IsLocal = false, Duration = 180 } },
|
||||
new() { MatchedSong = new Song { IsLocal = false, Duration = 240 } }
|
||||
};
|
||||
|
||||
var runTimeTicks = SpotifyPlaylistCountHelper.SumExternalMatchedRunTimeTicks(matchedTracks);
|
||||
|
||||
Assert.Equal((180L + 240L) * TimeSpan.TicksPerSecond, runTimeTicks);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SumCachedPlaylistRunTimeTicks_HandlesJsonElementsFromCache()
|
||||
{
|
||||
var cachedPlaylistItems = JsonSerializer.Deserialize<List<Dictionary<string, object?>>>("""
|
||||
[
|
||||
{ "RunTimeTicks": 1800000000 },
|
||||
{ "RunTimeTicks": 2400000000 }
|
||||
]
|
||||
""")!;
|
||||
|
||||
var runTimeTicks = SpotifyPlaylistCountHelper.SumCachedPlaylistRunTimeTicks(cachedPlaylistItems);
|
||||
|
||||
Assert.Equal(4200000000L, runTimeTicks);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComputeServedRunTimeTicks_UsesExactCachedRuntime_WhenAvailable()
|
||||
{
|
||||
var matchedTracks = new List<MatchedTrack>
|
||||
{
|
||||
new() { MatchedSong = new Song { IsLocal = false, Duration = 180 } }
|
||||
};
|
||||
|
||||
var runTimeTicks = SpotifyPlaylistCountHelper.ComputeServedRunTimeTicks(
|
||||
5000000000L,
|
||||
900000000L,
|
||||
matchedTracks);
|
||||
|
||||
Assert.Equal(5000000000L, runTimeTicks);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ComputeServedRunTimeTicks_FallsBackToLocalPlusExternalMatched()
|
||||
{
|
||||
var matchedTracks = new List<MatchedTrack>
|
||||
{
|
||||
new() { MatchedSong = new Song { IsLocal = true, Duration = 100 } },
|
||||
new() { MatchedSong = new Song { IsLocal = false, Duration = 180 } },
|
||||
new() { MatchedSong = new Song { IsLocal = false, Duration = 240 } }
|
||||
};
|
||||
|
||||
var runTimeTicks = SpotifyPlaylistCountHelper.ComputeServedRunTimeTicks(
|
||||
null,
|
||||
900000000L,
|
||||
matchedTracks);
|
||||
|
||||
Assert.Equal(5100000000L, runTimeTicks);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,181 @@
|
||||
using System.Net;
|
||||
using System.Reflection;
|
||||
using System.Text;
|
||||
using allstarr.Models.Settings;
|
||||
using allstarr.Services;
|
||||
using allstarr.Services.Common;
|
||||
using allstarr.Services.Local;
|
||||
using allstarr.Services.SquidWTF;
|
||||
using Microsoft.Extensions.Configuration;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Microsoft.Extensions.Options;
|
||||
using Moq;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
public class SquidWTFDownloadServiceTests : IDisposable
|
||||
{
|
||||
private readonly Mock<IHttpClientFactory> _httpClientFactoryMock = new();
|
||||
private readonly Mock<ILocalLibraryService> _localLibraryServiceMock = new();
|
||||
private readonly Mock<IMusicMetadataService> _metadataServiceMock = new();
|
||||
private readonly Mock<IServiceProvider> _serviceProviderMock = new();
|
||||
private readonly Mock<ILogger<SquidWTFDownloadService>> _loggerMock = new();
|
||||
private readonly Mock<ILogger<OdesliService>> _odesliLoggerMock = new();
|
||||
private readonly Mock<ILogger<RedisCacheService>> _redisLoggerMock = new();
|
||||
private readonly string _testDownloadPath;
|
||||
private readonly List<string> _apiUrls =
|
||||
[
|
||||
"http://127.0.0.1:18081",
|
||||
"http://127.0.0.1:18082"
|
||||
];
|
||||
|
||||
public SquidWTFDownloadServiceTests()
|
||||
{
|
||||
_testDownloadPath = Path.Combine(Path.GetTempPath(), "allstarr-squidwtf-download-tests-" + Guid.NewGuid());
|
||||
Directory.CreateDirectory(_testDownloadPath);
|
||||
|
||||
_serviceProviderMock
|
||||
.Setup(sp => sp.GetService(typeof(allstarr.Services.Subsonic.PlaylistSyncService)))
|
||||
.Returns((object?)null);
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (Directory.Exists(_testDownloadPath))
|
||||
{
|
||||
Directory.Delete(_testDownloadPath, true);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void BuildQualityFallbackOrder_MapsConfiguredQualityToDescendingFallbacks()
|
||||
{
|
||||
var order = InvokePrivateStaticMethod<IReadOnlyList<string>>(
|
||||
typeof(SquidWTFDownloadService),
|
||||
"BuildQualityFallbackOrder",
|
||||
"HI_RES");
|
||||
|
||||
Assert.Equal(["HI_RES_LOSSLESS", "LOSSLESS", "HIGH", "LOW"], order);
|
||||
}
|
||||
|
||||
|
||||
|
||||
private SquidWTFDownloadService CreateService(HttpMessageHandler handler, string quality)
|
||||
{
|
||||
var httpClient = new HttpClient(handler);
|
||||
_httpClientFactoryMock.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var configuration = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["Library:DownloadPath"] = _testDownloadPath
|
||||
})
|
||||
.Build();
|
||||
|
||||
var subsonicSettings = Options.Create(new SubsonicSettings
|
||||
{
|
||||
DownloadMode = DownloadMode.Track,
|
||||
StorageMode = StorageMode.Cache
|
||||
});
|
||||
|
||||
var squidwtfSettings = Options.Create(new SquidWTFSettings
|
||||
{
|
||||
Quality = quality
|
||||
});
|
||||
|
||||
var cache = new RedisCacheService(
|
||||
Options.Create(new RedisSettings { Enabled = false }),
|
||||
_redisLoggerMock.Object);
|
||||
|
||||
var odesliService = new OdesliService(_httpClientFactoryMock.Object, _odesliLoggerMock.Object, cache);
|
||||
|
||||
return new SquidWTFDownloadService(
|
||||
_httpClientFactoryMock.Object,
|
||||
configuration,
|
||||
_localLibraryServiceMock.Object,
|
||||
_metadataServiceMock.Object,
|
||||
subsonicSettings,
|
||||
squidwtfSettings,
|
||||
_serviceProviderMock.Object,
|
||||
_loggerMock.Object,
|
||||
odesliService,
|
||||
_apiUrls);
|
||||
}
|
||||
|
||||
private static string CreateTrackResponseJson(string audioQuality, string mimeType, string downloadUrl)
|
||||
{
|
||||
var manifestJson = $$"""
|
||||
{
|
||||
"mimeType": "{{mimeType}}",
|
||||
"codecs": "aac",
|
||||
"encryptionType": "NONE",
|
||||
"urls": ["{{downloadUrl}}"]
|
||||
}
|
||||
""";
|
||||
|
||||
var manifestBase64 = Convert.ToBase64String(Encoding.UTF8.GetBytes(manifestJson));
|
||||
|
||||
return $$"""
|
||||
{
|
||||
"version": "2.4",
|
||||
"data": {
|
||||
"audioQuality": "{{audioQuality}}",
|
||||
"manifest": "{{manifestBase64}}"
|
||||
}
|
||||
}
|
||||
""";
|
||||
}
|
||||
|
||||
private static async Task<object> InvokePrivateAsync(object target, string methodName, params object?[] parameters)
|
||||
{
|
||||
var method = target.GetType().GetMethod(methodName, BindingFlags.Instance | BindingFlags.NonPublic);
|
||||
Assert.NotNull(method);
|
||||
|
||||
var task = method!.Invoke(target, parameters) as Task;
|
||||
Assert.NotNull(task);
|
||||
|
||||
await task!;
|
||||
|
||||
var resultProperty = task.GetType().GetProperty("Result");
|
||||
Assert.NotNull(resultProperty);
|
||||
|
||||
var result = resultProperty!.GetValue(task);
|
||||
Assert.NotNull(result);
|
||||
return result!;
|
||||
}
|
||||
|
||||
private static T InvokePrivateStaticMethod<T>(Type targetType, string methodName, params object?[] parameters)
|
||||
{
|
||||
var method = targetType.GetMethod(methodName, BindingFlags.Static | BindingFlags.NonPublic);
|
||||
Assert.NotNull(method);
|
||||
|
||||
var result = method!.Invoke(null, parameters);
|
||||
Assert.NotNull(result);
|
||||
return (T)result!;
|
||||
}
|
||||
|
||||
private static T GetProperty<T>(object target, string propertyName)
|
||||
{
|
||||
var property = target.GetType().GetProperty(propertyName, BindingFlags.Instance | BindingFlags.Public);
|
||||
Assert.NotNull(property);
|
||||
|
||||
var value = property!.GetValue(target);
|
||||
Assert.NotNull(value);
|
||||
return (T)value!;
|
||||
}
|
||||
|
||||
private sealed class StubHttpMessageHandler : HttpMessageHandler
|
||||
{
|
||||
private readonly Func<HttpRequestMessage, HttpResponseMessage> _handler;
|
||||
|
||||
public StubHttpMessageHandler(Func<HttpRequestMessage, HttpResponseMessage> handler)
|
||||
{
|
||||
_handler = handler;
|
||||
}
|
||||
|
||||
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
|
||||
{
|
||||
return Task.FromResult(_handler(request));
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -7,8 +7,11 @@ using allstarr.Services.Common;
|
||||
using allstarr.Models.Domain;
|
||||
using allstarr.Models.Settings;
|
||||
using System.Collections.Generic;
|
||||
using System.Net;
|
||||
using System.Reflection;
|
||||
using System.Text.Json;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
|
||||
namespace allstarr.Tests;
|
||||
|
||||
@@ -296,6 +299,65 @@ public class SquidWTFMetadataServiceTests
|
||||
Assert.NotNull(result);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SearchAllAsync_WithZeroLimits_SkipsUnusedBuckets()
|
||||
{
|
||||
var requestKinds = new List<string>();
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
var trackQuery = GetQueryParameter(request.RequestUri!, "s");
|
||||
var albumQuery = GetQueryParameter(request.RequestUri!, "al");
|
||||
var artistQuery = GetQueryParameter(request.RequestUri!, "a");
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(trackQuery))
|
||||
{
|
||||
requestKinds.Add("song");
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateTrackSearchResponse(CreateTrackPayload(1, "Song", "USRC12345678")))
|
||||
};
|
||||
}
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(albumQuery))
|
||||
{
|
||||
requestKinds.Add("album");
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateAlbumSearchResponse())
|
||||
};
|
||||
}
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(artistQuery))
|
||||
{
|
||||
requestKinds.Add("artist");
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateArtistSearchResponse())
|
||||
};
|
||||
}
|
||||
|
||||
throw new InvalidOperationException($"Unexpected request URI: {request.RequestUri}");
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string> { "https://test1.example.com" });
|
||||
|
||||
var result = await service.SearchAllAsync("OK Computer", 0, 5, 0);
|
||||
|
||||
Assert.Empty(result.Songs);
|
||||
Assert.Single(result.Albums);
|
||||
Assert.Empty(result.Artists);
|
||||
Assert.Equal(new[] { "album" }, requestKinds);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ExplicitFilter_RespectsSettings()
|
||||
{
|
||||
@@ -343,6 +405,440 @@ public class SquidWTFMetadataServiceTests
|
||||
Assert.NotNull(service);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetTrackRecommendationsAsync_FallsBackWhenFirstEndpointReturnsEmpty()
|
||||
{
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
var port = request.RequestUri?.Port;
|
||||
|
||||
if (port == 5011)
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"version": "2.4",
|
||||
"data": {
|
||||
"limit": 20,
|
||||
"offset": 0,
|
||||
"totalNumberOfItems": 0,
|
||||
"items": []
|
||||
}
|
||||
}
|
||||
""")
|
||||
};
|
||||
}
|
||||
|
||||
if (port == 5012)
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"version": "2.4",
|
||||
"data": {
|
||||
"limit": 20,
|
||||
"offset": 0,
|
||||
"totalNumberOfItems": 1,
|
||||
"items": [
|
||||
{
|
||||
"track": {
|
||||
"id": 371921532,
|
||||
"title": "Take It Slow",
|
||||
"duration": 139,
|
||||
"trackNumber": 1,
|
||||
"volumeNumber": 1,
|
||||
"explicit": false,
|
||||
"artist": { "id": 10330497, "name": "Isaac Dunbar" },
|
||||
"artists": [
|
||||
{ "id": 10330497, "name": "Isaac Dunbar" }
|
||||
],
|
||||
"album": {
|
||||
"id": 371921525,
|
||||
"title": "Take It Slow",
|
||||
"cover": "aeb70f15-78ef-4230-929d-2d62c70ac00c"
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
""")
|
||||
};
|
||||
}
|
||||
|
||||
throw new InvalidOperationException($"Unexpected request URI: {request.RequestUri}");
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string>
|
||||
{
|
||||
"http://127.0.0.1:5011",
|
||||
"http://127.0.0.1:5012"
|
||||
});
|
||||
|
||||
var result = await service.GetTrackRecommendationsAsync("227242909", 20);
|
||||
|
||||
Assert.Single(result);
|
||||
Assert.Equal("371921532", result[0].ExternalId);
|
||||
Assert.Equal("Take It Slow", result[0].Title);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetSongAsync_FallsBackWhenFirstEndpointReturnsErrorPayload()
|
||||
{
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
var port = request.RequestUri?.Port;
|
||||
|
||||
if (port == 5021)
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"detail": "Upstream API error"
|
||||
}
|
||||
""")
|
||||
};
|
||||
}
|
||||
|
||||
if (port == 5022)
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"version": "2.4",
|
||||
"data": {
|
||||
"id": 227242909,
|
||||
"title": "Monica Lewinsky",
|
||||
"duration": 132,
|
||||
"trackNumber": 1,
|
||||
"volumeNumber": 1,
|
||||
"explicit": true,
|
||||
"artist": { "id": 8420542, "name": "UPSAHL" },
|
||||
"artists": [
|
||||
{ "id": 8420542, "name": "UPSAHL" }
|
||||
],
|
||||
"album": {
|
||||
"id": 227242908,
|
||||
"title": "Monica Lewinsky",
|
||||
"cover": "32522342-3903-42ab-aaea-a6f4f46ca0cc"
|
||||
}
|
||||
}
|
||||
}
|
||||
""")
|
||||
};
|
||||
}
|
||||
|
||||
throw new InvalidOperationException($"Unexpected request URI: {request.RequestUri}");
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string>
|
||||
{
|
||||
"http://127.0.0.1:5021",
|
||||
"http://127.0.0.1:5022"
|
||||
});
|
||||
|
||||
var song = await service.GetSongAsync("squidwtf", "227242909");
|
||||
|
||||
Assert.NotNull(song);
|
||||
Assert.Equal("227242909", song!.ExternalId);
|
||||
Assert.Equal("Monica Lewinsky", song.Title);
|
||||
Assert.Equal(1, song.ExplicitContentLyrics);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task FindSongByIsrcAsync_UsesExactIsrcEndpoint()
|
||||
{
|
||||
var requests = new List<string>();
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
requests.Add(request.RequestUri!.PathAndQuery);
|
||||
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateTrackSearchResponse(CreateTrackPayload(
|
||||
144371283,
|
||||
"Don't Look Back In Anger",
|
||||
"GBBQY0002027",
|
||||
artistName: "Oasis",
|
||||
artistId: 109,
|
||||
albumTitle: "Familiar To Millions (Live)",
|
||||
albumId: 144371273)))
|
||||
};
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string> { "http://127.0.0.1:5031" });
|
||||
|
||||
var song = await service.FindSongByIsrcAsync("GBBQY0002027");
|
||||
|
||||
Assert.NotNull(song);
|
||||
Assert.Equal("GBBQY0002027", song!.Isrc);
|
||||
Assert.Equal("144371283", song.ExternalId);
|
||||
Assert.Contains("/search/?i=GBBQY0002027&limit=1&offset=0", requests);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task FindSongByIsrcAsync_FallsBackToTextSearchWhenExactEndpointPayloadIsUnexpected()
|
||||
{
|
||||
var requests = new List<string>();
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
requests.Add(request.RequestUri!.PathAndQuery);
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(GetQueryParameter(request.RequestUri, "i")))
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""{ "version": "2.6", "unexpected": {} }""")
|
||||
};
|
||||
}
|
||||
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateTrackSearchResponse(CreateTrackPayload(
|
||||
427520487,
|
||||
"Azizam",
|
||||
"GBAHS2500081",
|
||||
artistName: "Ed Sheeran",
|
||||
artistId: 3995478,
|
||||
albumTitle: "Azizam",
|
||||
albumId: 427520486)))
|
||||
};
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string> { "http://127.0.0.1:5032" });
|
||||
|
||||
var song = await service.FindSongByIsrcAsync("GBAHS2500081");
|
||||
|
||||
Assert.NotNull(song);
|
||||
Assert.Equal("GBAHS2500081", song!.Isrc);
|
||||
Assert.Contains("/search/?i=GBAHS2500081&limit=1&offset=0", requests);
|
||||
Assert.Contains("/search/?s=isrc%3AGBAHS2500081&limit=1&offset=0", requests);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SearchEndpoints_IncludeRequestedRemoteLimitAndOffset()
|
||||
{
|
||||
var requests = new List<string>();
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
requests.Add(request.RequestUri!.PathAndQuery);
|
||||
var trackQuery = GetQueryParameter(request.RequestUri, "s");
|
||||
var albumQuery = GetQueryParameter(request.RequestUri, "al");
|
||||
var artistQuery = GetQueryParameter(request.RequestUri, "a");
|
||||
var playlistQuery = GetQueryParameter(request.RequestUri, "p");
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(trackQuery))
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateTrackSearchResponse(CreateTrackPayload(1, "Song", "USRC12345678")))
|
||||
};
|
||||
}
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(albumQuery))
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateAlbumSearchResponse())
|
||||
};
|
||||
}
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(artistQuery))
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateArtistSearchResponse())
|
||||
};
|
||||
}
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(playlistQuery))
|
||||
{
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreatePlaylistSearchResponse())
|
||||
};
|
||||
}
|
||||
|
||||
throw new InvalidOperationException($"Unexpected request URI: {request.RequestUri}");
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string> { "http://127.0.0.1:5033" });
|
||||
|
||||
await service.SearchSongsAsync("Take Five", 7);
|
||||
await service.SearchAlbumsAsync("Time Out", 8);
|
||||
await service.SearchArtistsAsync("Dave Brubeck", 9);
|
||||
await service.SearchPlaylistsAsync("Jazz Essentials", 10);
|
||||
|
||||
Assert.Contains("/search/?s=Take%20Five&limit=7&offset=0", requests);
|
||||
Assert.Contains("/search/?al=Time%20Out&limit=8&offset=0", requests);
|
||||
Assert.Contains("/search/?a=Dave%20Brubeck&limit=9&offset=0", requests);
|
||||
Assert.Contains("/search/?p=Jazz%20Essentials&limit=10&offset=0", requests);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetArtistAsync_UsesLightweightArtistEndpointAndCoverFallback()
|
||||
{
|
||||
var requests = new List<string>();
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
requests.Add(request.RequestUri!.PathAndQuery);
|
||||
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent("""
|
||||
{
|
||||
"version": "2.6",
|
||||
"artist": {
|
||||
"id": 25022,
|
||||
"name": "Kanye West",
|
||||
"picture": null
|
||||
},
|
||||
"cover": {
|
||||
"750": "https://example.com/kanye-750.jpg"
|
||||
}
|
||||
}
|
||||
""")
|
||||
};
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string> { "http://127.0.0.1:5034" });
|
||||
|
||||
var artist = await service.GetArtistAsync("squidwtf", "25022");
|
||||
|
||||
Assert.Contains("/artist/?id=25022", requests);
|
||||
Assert.NotNull(artist);
|
||||
Assert.Equal("Kanye West", artist!.Name);
|
||||
Assert.Equal("https://example.com/kanye-750.jpg", artist.ImageUrl);
|
||||
Assert.Null(artist.AlbumCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetAlbumAsync_PaginatesBeyondFirstPage()
|
||||
{
|
||||
var requests = new List<string>();
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
requests.Add(request.RequestUri!.PathAndQuery);
|
||||
var offset = int.Parse(GetQueryParameter(request.RequestUri, "offset") ?? "0");
|
||||
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreateAlbumPageResponse(offset, offset == 0 ? 500 : 1, totalTracks: 501))
|
||||
};
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string> { "http://127.0.0.1:5035" });
|
||||
|
||||
var album = await service.GetAlbumAsync("squidwtf", "58990510");
|
||||
|
||||
Assert.Contains("/album/?id=58990510&limit=500&offset=0", requests);
|
||||
Assert.Contains("/album/?id=58990510&limit=500&offset=500", requests);
|
||||
Assert.NotNull(album);
|
||||
Assert.Equal(501, album!.Songs.Count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetPlaylistTracksAsync_PaginatesBeyondFirstPage()
|
||||
{
|
||||
var requests = new List<string>();
|
||||
var handler = new StubHttpMessageHandler(request =>
|
||||
{
|
||||
requests.Add(request.RequestUri!.PathAndQuery);
|
||||
var offset = int.Parse(GetQueryParameter(request.RequestUri, "offset") ?? "0");
|
||||
|
||||
return new HttpResponseMessage(HttpStatusCode.OK)
|
||||
{
|
||||
Content = new StringContent(CreatePlaylistPageResponse(offset, offset == 0 ? 500 : 1, totalTracks: 501))
|
||||
};
|
||||
});
|
||||
|
||||
var httpClient = new HttpClient(handler);
|
||||
_mockHttpClientFactory.Setup(f => f.CreateClient(It.IsAny<string>())).Returns(httpClient);
|
||||
|
||||
var service = new SquidWTFMetadataService(
|
||||
_mockHttpClientFactory.Object,
|
||||
_subsonicSettings,
|
||||
_squidwtfSettings,
|
||||
_mockLogger.Object,
|
||||
_mockCache.Object,
|
||||
new List<string> { "http://127.0.0.1:5036" });
|
||||
|
||||
var songs = await service.GetPlaylistTracksAsync("squidwtf", "playlist123");
|
||||
|
||||
Assert.Equal(501, songs.Count);
|
||||
Assert.Equal("Big Playlist", songs[0].Album);
|
||||
Assert.Equal("Big Playlist", songs[^1].Album);
|
||||
Assert.Contains("/playlist/?id=playlist123&limit=500&offset=0", requests);
|
||||
Assert.Contains("/playlist/?id=playlist123&limit=500&offset=500", requests);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void BuildSearchQueryVariants_WithAmpersand_AddsAndVariant()
|
||||
{
|
||||
@@ -561,4 +1057,255 @@ public class SquidWTFMetadataServiceTests
|
||||
Assert.NotNull(result);
|
||||
return (T)result!;
|
||||
}
|
||||
|
||||
private static string CreateTrackSearchResponse(object trackPayload)
|
||||
{
|
||||
return JsonSerializer.Serialize(new Dictionary<string, object?>
|
||||
{
|
||||
["version"] = "2.6",
|
||||
["data"] = new Dictionary<string, object?>
|
||||
{
|
||||
["limit"] = 25,
|
||||
["offset"] = 0,
|
||||
["totalNumberOfItems"] = 1,
|
||||
["items"] = new[] { trackPayload }
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private static string CreateAlbumSearchResponse()
|
||||
{
|
||||
return JsonSerializer.Serialize(new Dictionary<string, object?>
|
||||
{
|
||||
["version"] = "2.6",
|
||||
["data"] = new Dictionary<string, object?>
|
||||
{
|
||||
["albums"] = new Dictionary<string, object?>
|
||||
{
|
||||
["limit"] = 25,
|
||||
["offset"] = 0,
|
||||
["totalNumberOfItems"] = 1,
|
||||
["items"] = new[]
|
||||
{
|
||||
new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = 58990510,
|
||||
["title"] = "OK Computer",
|
||||
["numberOfTracks"] = 12,
|
||||
["cover"] = "e77e4cc0-6cd0-4522-807d-88aeac488065",
|
||||
["artist"] = new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = 64518,
|
||||
["name"] = "Radiohead"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private static string CreateArtistSearchResponse()
|
||||
{
|
||||
return JsonSerializer.Serialize(new Dictionary<string, object?>
|
||||
{
|
||||
["version"] = "2.6",
|
||||
["data"] = new Dictionary<string, object?>
|
||||
{
|
||||
["artists"] = new Dictionary<string, object?>
|
||||
{
|
||||
["limit"] = 25,
|
||||
["offset"] = 0,
|
||||
["totalNumberOfItems"] = 1,
|
||||
["items"] = new[]
|
||||
{
|
||||
new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = 8812,
|
||||
["name"] = "Coldplay",
|
||||
["picture"] = "b4579672-5b91-4679-a27a-288f097a4da5"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private static string CreatePlaylistSearchResponse()
|
||||
{
|
||||
return JsonSerializer.Serialize(new Dictionary<string, object?>
|
||||
{
|
||||
["version"] = "2.6",
|
||||
["data"] = new Dictionary<string, object?>
|
||||
{
|
||||
["playlists"] = new Dictionary<string, object?>
|
||||
{
|
||||
["limit"] = 25,
|
||||
["offset"] = 0,
|
||||
["totalNumberOfItems"] = 1,
|
||||
["items"] = new[]
|
||||
{
|
||||
new Dictionary<string, object?>
|
||||
{
|
||||
["uuid"] = "playlist123",
|
||||
["title"] = "Jazz Essentials",
|
||||
["creator"] = new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = 0
|
||||
},
|
||||
["numberOfTracks"] = 1,
|
||||
["duration"] = 180,
|
||||
["squareImage"] = "b15bb487-dd6e-45ff-9e50-ee5083f20669"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private static string CreateAlbumPageResponse(int offset, int count, int totalTracks)
|
||||
{
|
||||
var items = Enumerable.Range(offset + 1, count)
|
||||
.Select(index => (object)new Dictionary<string, object?>
|
||||
{
|
||||
["item"] = CreateTrackPayload(
|
||||
index,
|
||||
$"Album Track {index}",
|
||||
$"USRC{index:00000000}",
|
||||
albumTitle: "Paginated Album",
|
||||
albumId: 58990510)
|
||||
})
|
||||
.ToArray();
|
||||
|
||||
return JsonSerializer.Serialize(new Dictionary<string, object?>
|
||||
{
|
||||
["version"] = "2.6",
|
||||
["data"] = new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = 58990510,
|
||||
["title"] = "Paginated Album",
|
||||
["numberOfTracks"] = totalTracks,
|
||||
["cover"] = "e77e4cc0-6cd0-4522-807d-88aeac488065",
|
||||
["artist"] = new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = 64518,
|
||||
["name"] = "Radiohead"
|
||||
},
|
||||
["items"] = items
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private static string CreatePlaylistPageResponse(int offset, int count, int totalTracks)
|
||||
{
|
||||
var items = Enumerable.Range(offset + 1, count)
|
||||
.Select(index => (object)new Dictionary<string, object?>
|
||||
{
|
||||
["item"] = CreateTrackPayload(
|
||||
index,
|
||||
$"Playlist Track {index}",
|
||||
$"GBARL{index:0000000}",
|
||||
artistName: "Mark Ronson",
|
||||
artistId: 8722,
|
||||
albumTitle: "Uptown Special",
|
||||
albumId: 39249709)
|
||||
})
|
||||
.ToArray();
|
||||
|
||||
return JsonSerializer.Serialize(new Dictionary<string, object?>
|
||||
{
|
||||
["version"] = "2.6",
|
||||
["playlist"] = new Dictionary<string, object?>
|
||||
{
|
||||
["uuid"] = "playlist123",
|
||||
["title"] = "Big Playlist",
|
||||
["creator"] = new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = 0
|
||||
},
|
||||
["numberOfTracks"] = totalTracks,
|
||||
["duration"] = totalTracks * 180,
|
||||
["squareImage"] = "b15bb487-dd6e-45ff-9e50-ee5083f20669"
|
||||
},
|
||||
["items"] = items
|
||||
});
|
||||
}
|
||||
|
||||
private static Dictionary<string, object?> CreateTrackPayload(
|
||||
int id,
|
||||
string title,
|
||||
string isrc,
|
||||
string artistName = "Artist",
|
||||
int artistId = 1,
|
||||
string albumTitle = "Album",
|
||||
int albumId = 10)
|
||||
{
|
||||
return new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = id,
|
||||
["title"] = title,
|
||||
["duration"] = 180,
|
||||
["trackNumber"] = (id % 12) + 1,
|
||||
["volumeNumber"] = 1,
|
||||
["explicit"] = false,
|
||||
["isrc"] = isrc,
|
||||
["artist"] = new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = artistId,
|
||||
["name"] = artistName
|
||||
},
|
||||
["artists"] = new object[]
|
||||
{
|
||||
new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = artistId,
|
||||
["name"] = artistName
|
||||
}
|
||||
},
|
||||
["album"] = new Dictionary<string, object?>
|
||||
{
|
||||
["id"] = albumId,
|
||||
["title"] = albumTitle,
|
||||
["cover"] = "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee"
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
private static string? GetQueryParameter(Uri uri, string name)
|
||||
{
|
||||
var query = uri.Query.TrimStart('?');
|
||||
if (string.IsNullOrWhiteSpace(query))
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
foreach (var pair in query.Split('&', StringSplitOptions.RemoveEmptyEntries))
|
||||
{
|
||||
var parts = pair.Split('=', 2);
|
||||
var key = Uri.UnescapeDataString(parts[0]);
|
||||
if (!key.Equals(name, StringComparison.Ordinal))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
return parts.Length > 1 ? Uri.UnescapeDataString(parts[1]) : string.Empty;
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
private sealed class StubHttpMessageHandler : HttpMessageHandler
|
||||
{
|
||||
private readonly Func<HttpRequestMessage, HttpResponseMessage> _handler;
|
||||
|
||||
public StubHttpMessageHandler(Func<HttpRequestMessage, HttpResponseMessage> handler)
|
||||
{
|
||||
_handler = handler;
|
||||
}
|
||||
|
||||
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
|
||||
{
|
||||
return Task.FromResult(_handler(request));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -9,5 +9,5 @@ public static class AppVersion
|
||||
/// <summary>
|
||||
/// Current application version.
|
||||
/// </summary>
|
||||
public const string Version = "1.3.0";
|
||||
public const string Version = "1.5.0";
|
||||
}
|
||||
|
||||
@@ -198,17 +198,20 @@ public class ConfigController : ControllerBase
|
||||
{
|
||||
arl = AdminHelperService.MaskValue(GetEnvString(envVars, "DEEZER_ARL", _deezerSettings.Arl ?? string.Empty), showLast: 8),
|
||||
arlFallback = AdminHelperService.MaskValue(GetEnvString(envVars, "DEEZER_ARL_FALLBACK", _deezerSettings.ArlFallback ?? string.Empty), showLast: 8),
|
||||
quality = GetEnvString(envVars, "DEEZER_QUALITY", _deezerSettings.Quality ?? "FLAC")
|
||||
quality = GetEnvString(envVars, "DEEZER_QUALITY", _deezerSettings.Quality ?? "FLAC"),
|
||||
minRequestIntervalMs = GetEnvInt(envVars, "DEEZER_MIN_REQUEST_INTERVAL_MS", _deezerSettings.MinRequestIntervalMs)
|
||||
},
|
||||
qobuz = new
|
||||
{
|
||||
userAuthToken = AdminHelperService.MaskValue(GetEnvString(envVars, "QOBUZ_USER_AUTH_TOKEN", _qobuzSettings.UserAuthToken ?? string.Empty), showLast: 8),
|
||||
userId = GetEnvString(envVars, "QOBUZ_USER_ID", _qobuzSettings.UserId ?? string.Empty),
|
||||
quality = GetEnvString(envVars, "QOBUZ_QUALITY", _qobuzSettings.Quality ?? "FLAC")
|
||||
quality = GetEnvString(envVars, "QOBUZ_QUALITY", _qobuzSettings.Quality ?? "FLAC"),
|
||||
minRequestIntervalMs = GetEnvInt(envVars, "QOBUZ_MIN_REQUEST_INTERVAL_MS", _qobuzSettings.MinRequestIntervalMs)
|
||||
},
|
||||
squidWtf = new
|
||||
{
|
||||
quality = GetEnvString(envVars, "SQUIDWTF_QUALITY", _squidWtfSettings.Quality ?? "LOSSLESS")
|
||||
quality = GetEnvString(envVars, "SQUIDWTF_QUALITY", _squidWtfSettings.Quality ?? "LOSSLESS"),
|
||||
minRequestIntervalMs = GetEnvInt(envVars, "SQUIDWTF_MIN_REQUEST_INTERVAL_MS", _squidWtfSettings.MinRequestIntervalMs)
|
||||
},
|
||||
musicBrainz = new
|
||||
{
|
||||
@@ -228,7 +231,8 @@ public class ConfigController : ControllerBase
|
||||
genreDays = GetEnvInt(envVars, "CACHE_GENRE_DAYS", _configuration.GetValue<int>("Cache:GenreDays", 30)),
|
||||
metadataDays = GetEnvInt(envVars, "CACHE_METADATA_DAYS", _configuration.GetValue<int>("Cache:MetadataDays", 7)),
|
||||
odesliLookupDays = GetEnvInt(envVars, "CACHE_ODESLI_LOOKUP_DAYS", _configuration.GetValue<int>("Cache:OdesliLookupDays", 60)),
|
||||
proxyImagesDays = GetEnvInt(envVars, "CACHE_PROXY_IMAGES_DAYS", _configuration.GetValue<int>("Cache:ProxyImagesDays", 14))
|
||||
proxyImagesDays = GetEnvInt(envVars, "CACHE_PROXY_IMAGES_DAYS", _configuration.GetValue<int>("Cache:ProxyImagesDays", 14)),
|
||||
transcodeCacheMinutes = GetEnvInt(envVars, "CACHE_TRANSCODE_MINUTES", _configuration.GetValue<int>("Cache:TranscodeCacheMinutes", 60))
|
||||
},
|
||||
scrobbling = await GetScrobblingSettingsFromEnvAsync()
|
||||
});
|
||||
@@ -470,70 +474,101 @@ public class ConfigController : ControllerBase
|
||||
_logger.LogWarning(".env file not found at {Path}, creating new file", _helperService.GetEnvFilePath());
|
||||
}
|
||||
|
||||
// Read current .env file or create new one
|
||||
var envContent = new Dictionary<string, string>();
|
||||
var envFilePath = _helperService.GetEnvFilePath();
|
||||
var envLines = new List<string>();
|
||||
|
||||
if (System.IO.File.Exists(_helperService.GetEnvFilePath()))
|
||||
if (System.IO.File.Exists(envFilePath))
|
||||
{
|
||||
var lines = await System.IO.File.ReadAllLinesAsync(_helperService.GetEnvFilePath());
|
||||
foreach (var line in lines)
|
||||
envLines = (await System.IO.File.ReadAllLinesAsync(envFilePath)).ToList();
|
||||
}
|
||||
else
|
||||
{
|
||||
// Fallback to reading .env.example if .env doesn't exist to preserve structure
|
||||
var examplePath = Path.Combine(Directory.GetCurrentDirectory(), ".env.example");
|
||||
if (!System.IO.File.Exists(examplePath))
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(line) || line.TrimStart().StartsWith('#'))
|
||||
continue;
|
||||
|
||||
var eqIndex = line.IndexOf('=');
|
||||
if (eqIndex > 0)
|
||||
{
|
||||
var key = line[..eqIndex].Trim();
|
||||
var value = line[(eqIndex + 1)..].Trim();
|
||||
|
||||
// Remove surrounding quotes if present (for proper re-quoting)
|
||||
if (value.StartsWith("\"") && value.EndsWith("\"") && value.Length >= 2)
|
||||
{
|
||||
value = value[1..^1];
|
||||
}
|
||||
|
||||
envContent[key] = value;
|
||||
}
|
||||
examplePath = Path.Combine(Directory.GetParent(Directory.GetCurrentDirectory())?.FullName ?? "", ".env.example");
|
||||
}
|
||||
|
||||
if (System.IO.File.Exists(examplePath))
|
||||
{
|
||||
_logger.LogInformation("Creating new .env from .env.example to preserve formatting");
|
||||
envLines = (await System.IO.File.ReadAllLinesAsync(examplePath)).ToList();
|
||||
}
|
||||
_logger.LogDebug("Loaded {Count} existing env vars from {Path}", envContent.Count, _helperService.GetEnvFilePath());
|
||||
}
|
||||
|
||||
// Apply updates with validation
|
||||
var appliedUpdates = new List<string>();
|
||||
foreach (var (key, value) in request.Updates)
|
||||
var updatesToProcess = new Dictionary<string, string>(request.Updates);
|
||||
|
||||
// Auto-set cookie date when Spotify session cookie is updated
|
||||
if (updatesToProcess.TryGetValue("SPOTIFY_API_SESSION_COOKIE", out var cookieVal) && !string.IsNullOrEmpty(cookieVal))
|
||||
{
|
||||
updatesToProcess["SPOTIFY_API_SESSION_COOKIE_SET_DATE"] = DateTime.UtcNow.ToString("o");
|
||||
_logger.LogInformation("Auto-setting SPOTIFY_API_SESSION_COOKIE_SET_DATE");
|
||||
}
|
||||
|
||||
foreach (var (key, value) in updatesToProcess)
|
||||
{
|
||||
// Validate key format
|
||||
if (!AdminHelperService.IsValidEnvKey(key))
|
||||
{
|
||||
_logger.LogWarning("Invalid env key rejected: {Key}", key);
|
||||
return BadRequest(new { error = $"Invalid environment variable key: {key}" });
|
||||
}
|
||||
|
||||
// IMPORTANT: Docker Compose does NOT need quotes in .env files
|
||||
// It handles special characters correctly without them
|
||||
// When quotes are used, they become part of the value itself
|
||||
envContent[key] = value;
|
||||
appliedUpdates.Add(key);
|
||||
_logger.LogInformation(" Setting {Key} = {Value}", key,
|
||||
key.Contains("COOKIE") || key.Contains("TOKEN") || key.Contains("KEY") || key.Contains("ARL") || key.Contains("PASSWORD")
|
||||
? "***" + (value.Length > 8 ? value[^8..] : "")
|
||||
: value);
|
||||
|
||||
var maskedValue = key.Contains("COOKIE") || key.Contains("TOKEN") || key.Contains("KEY") || key.Contains("ARL") || key.Contains("PASSWORD")
|
||||
? "***" + (value.Length > 8 ? value[^8..] : "")
|
||||
: value;
|
||||
_logger.LogInformation(" Setting {Key} = {Value}", key, maskedValue);
|
||||
|
||||
// Auto-set cookie date when Spotify session cookie is updated
|
||||
if (key == "SPOTIFY_API_SESSION_COOKIE" && !string.IsNullOrEmpty(value))
|
||||
var keyPrefix = $"{key}=";
|
||||
var found = false;
|
||||
|
||||
// 1. Look for active exact key
|
||||
for (int i = 0; i < envLines.Count; i++)
|
||||
{
|
||||
var dateKey = "SPOTIFY_API_SESSION_COOKIE_SET_DATE";
|
||||
var dateValue = DateTime.UtcNow.ToString("o"); // ISO 8601 format
|
||||
envContent[dateKey] = dateValue;
|
||||
appliedUpdates.Add(dateKey);
|
||||
_logger.LogInformation(" Auto-setting {Key} to {Value}", dateKey, dateValue);
|
||||
var trimmedLine = envLines[i].TrimStart();
|
||||
if (trimmedLine.StartsWith(keyPrefix, StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
envLines[i] = $"{key}={value}";
|
||||
found = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
// 2. Look for commented out key
|
||||
if (!found)
|
||||
{
|
||||
var commentedPrefix1 = $"# {key}=";
|
||||
var commentedPrefix2 = $"#{key}=";
|
||||
|
||||
for (int i = 0; i < envLines.Count; i++)
|
||||
{
|
||||
var trimmedLine = envLines[i].TrimStart();
|
||||
if (trimmedLine.StartsWith(commentedPrefix1, StringComparison.OrdinalIgnoreCase) ||
|
||||
trimmedLine.StartsWith(commentedPrefix2, StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
envLines[i] = $"{key}={value}";
|
||||
found = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// 3. Append to end of file if entirely missing
|
||||
if (!found)
|
||||
{
|
||||
if (envLines.Count > 0 && !string.IsNullOrWhiteSpace(envLines.Last()))
|
||||
{
|
||||
envLines.Add("");
|
||||
}
|
||||
envLines.Add($"{key}={value}");
|
||||
}
|
||||
}
|
||||
|
||||
// Write back to .env file (no quoting needed - Docker Compose handles special chars)
|
||||
var newContent = string.Join("\n", envContent.Select(kv => $"{kv.Key}={kv.Value}"));
|
||||
await System.IO.File.WriteAllTextAsync(_helperService.GetEnvFilePath(), newContent + "\n");
|
||||
await System.IO.File.WriteAllLinesAsync(envFilePath, envLines);
|
||||
|
||||
_logger.LogDebug("Config file updated successfully at {Path}", _helperService.GetEnvFilePath());
|
||||
|
||||
@@ -545,7 +580,7 @@ public class ConfigController : ControllerBase
|
||||
|
||||
return Ok(new
|
||||
{
|
||||
message = "Configuration updated. Restart container to apply changes.",
|
||||
message = "Configuration updated. Restart Allstarr to apply changes.",
|
||||
updatedKeys = appliedUpdates,
|
||||
requiresRestart = true,
|
||||
envFilePath = _helperService.GetEnvFilePath()
|
||||
@@ -661,7 +696,7 @@ public class ConfigController : ControllerBase
|
||||
_logger.LogWarning("Docker socket not available at {Path}", socketPath);
|
||||
return StatusCode(503, new {
|
||||
error = "Docker socket not available",
|
||||
message = "Please restart manually: docker-compose restart allstarr"
|
||||
message = "Please restart manually: docker restart allstarr"
|
||||
});
|
||||
}
|
||||
|
||||
@@ -714,7 +749,7 @@ public class ConfigController : ControllerBase
|
||||
_logger.LogError("Failed to restart container: {StatusCode} - {Body}", response.StatusCode, errorBody);
|
||||
return StatusCode((int)response.StatusCode, new {
|
||||
error = "Failed to restart container",
|
||||
message = "Please restart manually: docker-compose restart allstarr"
|
||||
message = "Please restart manually: docker restart allstarr"
|
||||
});
|
||||
}
|
||||
}
|
||||
@@ -723,7 +758,7 @@ public class ConfigController : ControllerBase
|
||||
_logger.LogError(ex, "Error restarting container");
|
||||
return StatusCode(500, new {
|
||||
error = "Failed to restart container",
|
||||
message = "Please restart manually: docker-compose restart allstarr"
|
||||
message = "Please restart manually: docker restart allstarr"
|
||||
});
|
||||
}
|
||||
}
|
||||
@@ -855,7 +890,7 @@ public class ConfigController : ControllerBase
|
||||
return Ok(new
|
||||
{
|
||||
success = true,
|
||||
message = ".env file imported successfully. Restart the application for changes to take effect."
|
||||
message = ".env file imported successfully. Restart Allstarr for changes to take effect."
|
||||
});
|
||||
}
|
||||
catch (Exception ex)
|
||||
|
||||
@@ -0,0 +1,181 @@
|
||||
using System.Text.Json;
|
||||
using allstarr.Models.Download;
|
||||
using allstarr.Services;
|
||||
using allstarr.Services.Jellyfin;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
|
||||
namespace allstarr.Controllers;
|
||||
|
||||
[ApiController]
|
||||
[Route("api/admin/downloads")]
|
||||
public class DownloadActivityController : ControllerBase
|
||||
{
|
||||
private readonly IEnumerable<IDownloadService> _downloadServices;
|
||||
private readonly JellyfinSessionManager _sessionManager;
|
||||
private readonly ILogger<DownloadActivityController> _logger;
|
||||
|
||||
public DownloadActivityController(
|
||||
IEnumerable<IDownloadService> downloadServices,
|
||||
JellyfinSessionManager sessionManager,
|
||||
ILogger<DownloadActivityController> logger)
|
||||
{
|
||||
_downloadServices = downloadServices;
|
||||
_sessionManager = sessionManager;
|
||||
_logger = logger;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Returns the current download queue as JSON.
|
||||
/// </summary>
|
||||
[HttpGet("queue")]
|
||||
public IActionResult GetDownloadQueue()
|
||||
{
|
||||
var allDownloads = GetAllActivityEntries();
|
||||
return Ok(allDownloads);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Server-Sent Events (SSE) endpoint that pushes the download queue state
|
||||
/// in real-time.
|
||||
/// </summary>
|
||||
[HttpGet("activity")]
|
||||
public async Task GetDownloadActivity(CancellationToken cancellationToken)
|
||||
{
|
||||
Response.Headers.Append("Content-Type", "text/event-stream");
|
||||
Response.Headers.Append("Cache-Control", "no-cache");
|
||||
Response.Headers.Append("Connection", "keep-alive");
|
||||
|
||||
// Use the request aborted token or the provided cancellation token.
|
||||
var requestAborted = HttpContext.RequestAborted;
|
||||
|
||||
using var linkedCts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken, requestAborted);
|
||||
var token = linkedCts.Token;
|
||||
|
||||
_logger.LogInformation("Download activity SSE connection opened.");
|
||||
|
||||
var jsonOptions = new JsonSerializerOptions
|
||||
{
|
||||
PropertyNamingPolicy = JsonNamingPolicy.CamelCase
|
||||
};
|
||||
|
||||
try
|
||||
{
|
||||
while (!token.IsCancellationRequested)
|
||||
{
|
||||
var allDownloads = GetAllActivityEntries();
|
||||
|
||||
var payload = JsonSerializer.Serialize(allDownloads, jsonOptions);
|
||||
var message = $"data: {payload}\n\n";
|
||||
|
||||
await Response.WriteAsync(message, token);
|
||||
await Response.Body.FlushAsync(token);
|
||||
|
||||
await Task.Delay(1000, token); // Poll every 1 second
|
||||
}
|
||||
}
|
||||
catch (TaskCanceledException)
|
||||
{
|
||||
// Client gracefully disconnected or requested cancellation
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Error while pushing download activity stream.");
|
||||
}
|
||||
finally
|
||||
{
|
||||
_logger.LogInformation("Download activity SSE connection closed.");
|
||||
}
|
||||
}
|
||||
|
||||
private List<DownloadActivityEntry> GetAllActivityEntries()
|
||||
{
|
||||
var allDownloads = new List<DownloadInfo>();
|
||||
foreach (var service in _downloadServices)
|
||||
{
|
||||
allDownloads.AddRange(service.GetActiveDownloads());
|
||||
}
|
||||
|
||||
var orderedDownloads = allDownloads
|
||||
.OrderByDescending(d => d.Status == DownloadStatus.InProgress)
|
||||
.ThenByDescending(d => d.StartedAt)
|
||||
.ToList();
|
||||
|
||||
var playbackByItemId = _sessionManager
|
||||
.GetActivePlaybackStates(TimeSpan.FromMinutes(5))
|
||||
.GroupBy(state => NormalizeExternalItemId(state.ItemId))
|
||||
.ToDictionary(
|
||||
group => group.Key,
|
||||
group => group.OrderByDescending(state => state.LastActivity).First());
|
||||
|
||||
return orderedDownloads
|
||||
.Select(download =>
|
||||
{
|
||||
var normalizedSongId = NormalizeExternalItemId(download.SongId);
|
||||
var hasPlayback = playbackByItemId.TryGetValue(normalizedSongId, out var playbackState);
|
||||
var playbackProgress = hasPlayback && download.DurationSeconds.GetValueOrDefault() > 0
|
||||
? Math.Clamp(
|
||||
playbackState!.PositionTicks / (double)TimeSpan.TicksPerSecond / download.DurationSeconds!.Value,
|
||||
0d,
|
||||
1d)
|
||||
: (double?)null;
|
||||
|
||||
return new DownloadActivityEntry
|
||||
{
|
||||
SongId = download.SongId,
|
||||
ExternalId = download.ExternalId,
|
||||
ExternalProvider = download.ExternalProvider,
|
||||
Title = download.Title,
|
||||
Artist = download.Artist,
|
||||
Status = download.Status,
|
||||
Progress = download.Progress,
|
||||
RequestedForStreaming = download.RequestedForStreaming,
|
||||
DurationSeconds = download.DurationSeconds,
|
||||
LocalPath = download.LocalPath,
|
||||
ErrorMessage = download.ErrorMessage,
|
||||
StartedAt = download.StartedAt,
|
||||
CompletedAt = download.CompletedAt,
|
||||
IsPlaying = hasPlayback,
|
||||
PlaybackPositionSeconds = hasPlayback
|
||||
? (int)Math.Max(0, playbackState!.PositionTicks / TimeSpan.TicksPerSecond)
|
||||
: null,
|
||||
PlaybackProgress = playbackProgress
|
||||
};
|
||||
})
|
||||
.ToList();
|
||||
}
|
||||
|
||||
private static string NormalizeExternalItemId(string itemId)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(itemId) || !itemId.StartsWith("ext-", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
return itemId;
|
||||
}
|
||||
|
||||
var parts = itemId.Split('-', StringSplitOptions.RemoveEmptyEntries);
|
||||
if (parts.Length < 3)
|
||||
{
|
||||
return itemId;
|
||||
}
|
||||
|
||||
var knownTypes = new HashSet<string>(StringComparer.OrdinalIgnoreCase)
|
||||
{
|
||||
"song",
|
||||
"album",
|
||||
"artist"
|
||||
};
|
||||
|
||||
if (parts.Length >= 4 && knownTypes.Contains(parts[2]))
|
||||
{
|
||||
return itemId;
|
||||
}
|
||||
|
||||
return $"ext-{parts[1]}-song-{string.Join("-", parts.Skip(2))}";
|
||||
}
|
||||
|
||||
private sealed class DownloadActivityEntry : DownloadInfo
|
||||
{
|
||||
public bool IsPlaying { get; init; }
|
||||
public int? PlaybackPositionSeconds { get; init; }
|
||||
public double? PlaybackProgress { get; init; }
|
||||
}
|
||||
}
|
||||
@@ -139,6 +139,56 @@ public class DownloadsController : ControllerBase
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// DELETE /api/admin/downloads/all
|
||||
/// Deletes all kept audio files and removes empty folders
|
||||
/// </summary>
|
||||
[HttpDelete("downloads/all")]
|
||||
public IActionResult DeleteAllDownloads()
|
||||
{
|
||||
try
|
||||
{
|
||||
var keptPath = Path.GetFullPath(Path.Combine(_configuration["Library:DownloadPath"] ?? "./downloads", "kept"));
|
||||
if (!Directory.Exists(keptPath))
|
||||
{
|
||||
return Ok(new { success = true, deletedCount = 0, message = "No kept downloads found" });
|
||||
}
|
||||
|
||||
var audioExtensions = new[] { ".flac", ".mp3", ".m4a", ".opus" };
|
||||
var allFiles = Directory.GetFiles(keptPath, "*.*", SearchOption.AllDirectories)
|
||||
.Where(f => audioExtensions.Contains(Path.GetExtension(f).ToLowerInvariant()))
|
||||
.ToList();
|
||||
|
||||
foreach (var filePath in allFiles)
|
||||
{
|
||||
System.IO.File.Delete(filePath);
|
||||
}
|
||||
|
||||
// Clean up empty directories under kept root (deepest first)
|
||||
var allDirectories = Directory.GetDirectories(keptPath, "*", SearchOption.AllDirectories)
|
||||
.OrderByDescending(d => d.Length);
|
||||
foreach (var directory in allDirectories)
|
||||
{
|
||||
if (!Directory.EnumerateFileSystemEntries(directory).Any())
|
||||
{
|
||||
Directory.Delete(directory);
|
||||
}
|
||||
}
|
||||
|
||||
return Ok(new
|
||||
{
|
||||
success = true,
|
||||
deletedCount = allFiles.Count,
|
||||
message = $"Deleted {allFiles.Count} kept download(s)"
|
||||
});
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to delete all kept downloads");
|
||||
return StatusCode(500, new { error = "Failed to delete all kept downloads" });
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// GET /api/admin/downloads/file
|
||||
/// Downloads a specific file from the kept folder
|
||||
|
||||
+170
-48
@@ -1,9 +1,11 @@
|
||||
using System.Text.Json;
|
||||
using System.Text;
|
||||
using System.Net.Http;
|
||||
using allstarr.Models.Domain;
|
||||
using allstarr.Models.Spotify;
|
||||
using allstarr.Services.Common;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
using Microsoft.AspNetCore.Http.Features;
|
||||
|
||||
namespace allstarr.Controllers;
|
||||
|
||||
@@ -11,6 +13,20 @@ public partial class JellyfinController
|
||||
{
|
||||
#region Helpers
|
||||
|
||||
private static readonly HashSet<string> PassthroughResponseHeadersToSkip = new(StringComparer.OrdinalIgnoreCase)
|
||||
{
|
||||
"Connection",
|
||||
"Keep-Alive",
|
||||
"Proxy-Authenticate",
|
||||
"Proxy-Authorization",
|
||||
"TE",
|
||||
"Trailer",
|
||||
"Transfer-Encoding",
|
||||
"Upgrade",
|
||||
"Content-Type",
|
||||
"Content-Length"
|
||||
};
|
||||
|
||||
/// <summary>
|
||||
/// Helper to handle proxy responses with proper status code handling.
|
||||
/// </summary>
|
||||
@@ -48,6 +64,60 @@ public partial class JellyfinController
|
||||
return NoContent();
|
||||
}
|
||||
|
||||
private async Task<IActionResult> ProxyJsonPassthroughAsync(string endpoint)
|
||||
{
|
||||
try
|
||||
{
|
||||
// Match the previous proxy semantics for client compatibility.
|
||||
// Some Jellyfin clients/proxies cancel the ASP.NET request token aggressively
|
||||
// even though the upstream request would still complete successfully.
|
||||
var upstreamResponse = await _proxyService.GetPassthroughResponseAsync(
|
||||
endpoint,
|
||||
Request.Headers);
|
||||
|
||||
HttpContext.Response.RegisterForDispose(upstreamResponse);
|
||||
HttpContext.Features.Get<IHttpResponseBodyFeature>()?.DisableBuffering();
|
||||
Response.StatusCode = (int)upstreamResponse.StatusCode;
|
||||
Response.Headers["X-Accel-Buffering"] = "no";
|
||||
|
||||
CopyPassthroughResponseHeaders(upstreamResponse);
|
||||
|
||||
if (upstreamResponse.Content.Headers.ContentLength.HasValue)
|
||||
{
|
||||
Response.ContentLength = upstreamResponse.Content.Headers.ContentLength.Value;
|
||||
}
|
||||
|
||||
var contentType = upstreamResponse.Content.Headers.ContentType?.ToString() ?? "application/json";
|
||||
var stream = await upstreamResponse.Content.ReadAsStreamAsync();
|
||||
|
||||
return new FileStreamResult(stream, contentType);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to transparently proxy Jellyfin request for {Endpoint}", endpoint);
|
||||
return StatusCode(502, new { error = "Failed to connect to Jellyfin server" });
|
||||
}
|
||||
}
|
||||
|
||||
private void CopyPassthroughResponseHeaders(HttpResponseMessage upstreamResponse)
|
||||
{
|
||||
foreach (var header in upstreamResponse.Headers)
|
||||
{
|
||||
if (!PassthroughResponseHeadersToSkip.Contains(header.Key))
|
||||
{
|
||||
Response.Headers[header.Key] = header.Value.ToArray();
|
||||
}
|
||||
}
|
||||
|
||||
foreach (var header in upstreamResponse.Content.Headers)
|
||||
{
|
||||
if (!PassthroughResponseHeadersToSkip.Contains(header.Key))
|
||||
{
|
||||
Response.Headers[header.Key] = header.Value.ToArray();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Updates ChildCount for Spotify playlists in the response to show total tracks (local + matched).
|
||||
/// </summary>
|
||||
@@ -129,35 +199,46 @@ public partial class JellyfinController
|
||||
}
|
||||
}
|
||||
|
||||
// Try loading from file cache if Redis is empty
|
||||
if (matchedTracks == null || matchedTracks.Count == 0)
|
||||
// Prefer the currently served playlist items cache when available.
|
||||
// This most closely matches what the injected playlist endpoint will return.
|
||||
var exactServedCount = 0;
|
||||
var playlistItemsKey = CacheKeyBuilder.BuildSpotifyPlaylistItemsKey(playlistName);
|
||||
var cachedPlaylistItems = await _cache.GetAsync<List<Dictionary<string, object?>>>(playlistItemsKey);
|
||||
var exactServedRunTimeTicks = 0L;
|
||||
if (cachedPlaylistItems != null &&
|
||||
cachedPlaylistItems.Count > 0 &&
|
||||
!InjectedPlaylistItemHelper.ContainsSyntheticLocalItems(cachedPlaylistItems))
|
||||
{
|
||||
var fileItems = await LoadPlaylistItemsFromFile(playlistName);
|
||||
if (fileItems != null && fileItems.Count > 0)
|
||||
{
|
||||
_logger.LogDebug(
|
||||
"💿 Loaded {Count} playlist items from file cache for count update",
|
||||
fileItems.Count);
|
||||
// Use file cache count directly
|
||||
itemDict["ChildCount"] = fileItems.Count;
|
||||
modified = true;
|
||||
}
|
||||
exactServedCount = cachedPlaylistItems.Count;
|
||||
exactServedRunTimeTicks =
|
||||
SpotifyPlaylistCountHelper.SumCachedPlaylistRunTimeTicks(cachedPlaylistItems);
|
||||
_logger.LogDebug(
|
||||
"Using Redis playlist items cache metrics for {Playlist}: count={Count}, runtimeTicks={RunTimeTicks}",
|
||||
playlistName, exactServedCount, exactServedRunTimeTicks);
|
||||
}
|
||||
|
||||
// Only fetch from Jellyfin if we didn't get count from file cache
|
||||
if (!itemDict.ContainsKey("ChildCount") ||
|
||||
(itemDict["ChildCount"] is JsonElement childCountElement &&
|
||||
childCountElement.GetInt32() == 0) ||
|
||||
(itemDict["ChildCount"] is int childCountInt && childCountInt == 0))
|
||||
if (exactServedCount > 0)
|
||||
{
|
||||
// Get local tracks count from Jellyfin
|
||||
itemDict["ChildCount"] = exactServedCount;
|
||||
itemDict["RunTimeTicks"] = exactServedRunTimeTicks;
|
||||
modified = true;
|
||||
}
|
||||
else
|
||||
{
|
||||
// Recompute ChildCount for injected playlists instead of trusting
|
||||
// Jellyfin/plugin values, which only reflect local tracks.
|
||||
var localTracksCount = 0;
|
||||
var localRunTimeTicks = 0L;
|
||||
try
|
||||
{
|
||||
// Include UserId parameter to avoid 401 Unauthorized
|
||||
var userId = _settings.UserId;
|
||||
var playlistItemsUrl = $"Playlists/{playlistId}/Items";
|
||||
var queryParams = new Dictionary<string, string>();
|
||||
var queryParams = new Dictionary<string, string>
|
||||
{
|
||||
["Fields"] = "Id,RunTimeTicks",
|
||||
["Limit"] = "10000"
|
||||
};
|
||||
|
||||
if (!string.IsNullOrEmpty(userId))
|
||||
{
|
||||
queryParams["UserId"] = userId;
|
||||
@@ -170,8 +251,16 @@ public partial class JellyfinController
|
||||
if (localTracksResponse != null &&
|
||||
localTracksResponse.RootElement.TryGetProperty("Items", out var localItems))
|
||||
{
|
||||
localTracksCount = localItems.GetArrayLength();
|
||||
_logger.LogDebug("Found {Count} total items in Jellyfin playlist {Name}",
|
||||
foreach (var localItem in localItems.EnumerateArray())
|
||||
{
|
||||
localTracksCount++;
|
||||
localRunTimeTicks += SpotifyPlaylistCountHelper.ExtractRunTimeTicks(
|
||||
localItem.TryGetProperty("RunTimeTicks", out var runTimeTicks)
|
||||
? runTimeTicks
|
||||
: null);
|
||||
}
|
||||
|
||||
_logger.LogDebug("Found {Count} local Jellyfin items in playlist {Name}",
|
||||
localTracksCount, playlistName);
|
||||
}
|
||||
}
|
||||
@@ -180,33 +269,25 @@ public partial class JellyfinController
|
||||
_logger.LogError(ex, "Failed to get local tracks count for {Name}", playlistName);
|
||||
}
|
||||
|
||||
// Count external matched tracks (not local)
|
||||
var externalMatchedCount = 0;
|
||||
if (matchedTracks != null)
|
||||
{
|
||||
externalMatchedCount = matchedTracks.Count(t =>
|
||||
t.MatchedSong != null && !t.MatchedSong.IsLocal);
|
||||
}
|
||||
var totalAvailableCount = SpotifyPlaylistCountHelper.ComputeServedItemCount(
|
||||
exactServedCount > 0 ? exactServedCount : null,
|
||||
localTracksCount,
|
||||
matchedTracks);
|
||||
var totalRunTimeTicks = SpotifyPlaylistCountHelper.ComputeServedRunTimeTicks(
|
||||
exactServedCount > 0 ? exactServedRunTimeTicks : null,
|
||||
localRunTimeTicks,
|
||||
matchedTracks);
|
||||
|
||||
// Total available tracks = local tracks in Jellyfin + external matched tracks
|
||||
// This represents what users will actually hear when playing the playlist
|
||||
var totalAvailableCount = localTracksCount + externalMatchedCount;
|
||||
|
||||
if (totalAvailableCount > 0)
|
||||
{
|
||||
// Update ChildCount to show actual available tracks
|
||||
itemDict["ChildCount"] = totalAvailableCount;
|
||||
modified = true;
|
||||
_logger.LogDebug(
|
||||
"✓ Updated ChildCount for Spotify playlist {Name} to {Total} ({Local} local + {External} external)",
|
||||
playlistName, totalAvailableCount, localTracksCount, externalMatchedCount);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"No tracks found for {Name} ({Local} local + {External} external = {Total} total)",
|
||||
playlistName, localTracksCount, externalMatchedCount, totalAvailableCount);
|
||||
}
|
||||
itemDict["ChildCount"] = totalAvailableCount;
|
||||
itemDict["RunTimeTicks"] = totalRunTimeTicks;
|
||||
modified = true;
|
||||
_logger.LogDebug(
|
||||
"✓ Updated Spotify playlist metrics for {Name}: count={Total} ({Local} local + {External} external), runtimeTicks={RunTimeTicks}",
|
||||
playlistName,
|
||||
totalAvailableCount,
|
||||
localTracksCount,
|
||||
SpotifyPlaylistCountHelper.CountExternalMatchedTracks(matchedTracks),
|
||||
totalRunTimeTicks);
|
||||
}
|
||||
}
|
||||
else
|
||||
@@ -396,6 +477,47 @@ public partial class JellyfinController
|
||||
return includeItemTypes.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries);
|
||||
}
|
||||
|
||||
private static string? GetExactPlaylistItemsRequestId(string path)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(path))
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
var parts = path.Split('/', StringSplitOptions.RemoveEmptyEntries);
|
||||
if (parts.Length != 3 ||
|
||||
!parts[0].Equals("playlists", StringComparison.OrdinalIgnoreCase) ||
|
||||
!parts[2].Equals("items", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
return parts[1];
|
||||
}
|
||||
|
||||
private static string? ExtractImageTag(JsonElement item, string imageType)
|
||||
{
|
||||
if (item.TryGetProperty("ImageTags", out var imageTags) &&
|
||||
imageTags.ValueKind == JsonValueKind.Object)
|
||||
{
|
||||
foreach (var imageTag in imageTags.EnumerateObject())
|
||||
{
|
||||
if (string.Equals(imageTag.Name, imageType, StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
return imageTag.Value.GetString();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (string.Equals(imageType, "Primary", StringComparison.OrdinalIgnoreCase) &&
|
||||
item.TryGetProperty("PrimaryImageTag", out var primaryImageTag))
|
||||
{
|
||||
return primaryImageTag.GetString();
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Determines whether Spotify playlist count enrichment should run for a response.
|
||||
/// We only run enrichment for playlist-oriented payloads to avoid mutating unrelated item lists
|
||||
|
||||
@@ -245,7 +245,9 @@ public class JellyfinAdminController : ControllerBase
|
||||
/// Get all playlists from the user's Spotify account
|
||||
/// </summary>
|
||||
[HttpGet("jellyfin/playlists")]
|
||||
public async Task<IActionResult> GetJellyfinPlaylists([FromQuery] string? userId = null)
|
||||
public async Task<IActionResult> GetJellyfinPlaylists(
|
||||
[FromQuery] string? userId = null,
|
||||
[FromQuery] bool includeStats = true)
|
||||
{
|
||||
if (string.IsNullOrEmpty(_jellyfinSettings.Url) || string.IsNullOrEmpty(_jellyfinSettings.ApiKey))
|
||||
{
|
||||
@@ -330,13 +332,13 @@ public class JellyfinAdminController : ControllerBase
|
||||
|
||||
var statsUserId = requestedUserId;
|
||||
var trackStats = (LocalTracks: 0, ExternalTracks: 0, ExternalAvailable: 0);
|
||||
if (isConfigured)
|
||||
if (isConfigured && includeStats)
|
||||
{
|
||||
trackStats = await GetPlaylistTrackStats(id!, session, statsUserId);
|
||||
}
|
||||
|
||||
var actualTrackCount = isConfigured
|
||||
? trackStats.LocalTracks + trackStats.ExternalTracks
|
||||
? (includeStats ? trackStats.LocalTracks + trackStats.ExternalTracks : childCount)
|
||||
: childCount;
|
||||
|
||||
playlists.Add(new
|
||||
@@ -349,6 +351,7 @@ public class JellyfinAdminController : ControllerBase
|
||||
isLinkedByAnotherUser,
|
||||
linkedOwnerUserId = scopedLinkedPlaylist?.UserId ??
|
||||
allLinkedForPlaylist.FirstOrDefault()?.UserId,
|
||||
statsPending = isConfigured && !includeStats,
|
||||
localTracks = trackStats.LocalTracks,
|
||||
externalTracks = trackStats.ExternalTracks,
|
||||
externalAvailable = trackStats.ExternalAvailable
|
||||
|
||||
@@ -69,8 +69,9 @@ public partial class JellyfinController
|
||||
return await ProxyJellyfinStream(fullPath, itemId);
|
||||
}
|
||||
|
||||
// Handle external content
|
||||
return await StreamExternalContent(provider!, externalId!);
|
||||
// Handle external content with quality override from client transcoding params
|
||||
var quality = StreamQualityHelper.ParseFromQueryString(Request.Query);
|
||||
return await StreamExternalContent(provider!, externalId!, quality);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -150,8 +151,9 @@ public partial class JellyfinController
|
||||
|
||||
/// <summary>
|
||||
/// Streams external content, using cache if available or downloading on-demand.
|
||||
/// Supports quality override for client-requested "transcoding" of external tracks.
|
||||
/// </summary>
|
||||
private async Task<IActionResult> StreamExternalContent(string provider, string externalId)
|
||||
private async Task<IActionResult> StreamExternalContent(string provider, string externalId, StreamQuality quality = StreamQuality.Original)
|
||||
{
|
||||
// Check for locally cached file
|
||||
var localPath = await _localLibraryService.GetLocalPathForExternalSongAsync(provider, externalId);
|
||||
@@ -178,13 +180,32 @@ public partial class JellyfinController
|
||||
var downloadStream = await _downloadService.DownloadAndStreamAsync(
|
||||
provider,
|
||||
externalId,
|
||||
quality != StreamQuality.Original ? quality : null,
|
||||
HttpContext.RequestAborted);
|
||||
|
||||
return File(downloadStream, "audio/mpeg", enableRangeProcessing: true);
|
||||
var contentType = "audio/mpeg";
|
||||
if (downloadStream is FileStream fs)
|
||||
{
|
||||
contentType = GetContentType(fs.Name);
|
||||
}
|
||||
|
||||
return File(downloadStream, contentType, enableRangeProcessing: true);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to stream external song {Provider}:{ExternalId}", provider, externalId);
|
||||
if (ex is HttpRequestException httpRequestException && httpRequestException.StatusCode.HasValue)
|
||||
{
|
||||
_logger.LogError("Failed to stream external song {Provider}:{ExternalId}: {StatusCode}: {ReasonPhrase}",
|
||||
provider,
|
||||
externalId,
|
||||
(int)httpRequestException.StatusCode.Value,
|
||||
httpRequestException.StatusCode.Value);
|
||||
_logger.LogDebug(ex, "Detailed streaming failure for external song {Provider}:{ExternalId}", provider, externalId);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogError(ex, "Failed to stream external song {Provider}:{ExternalId}", provider, externalId);
|
||||
}
|
||||
return StatusCode(500, new { error = "Streaming failed" });
|
||||
}
|
||||
}
|
||||
@@ -216,8 +237,9 @@ public partial class JellyfinController
|
||||
return await ProxyJellyfinStream(fullPath, itemId);
|
||||
}
|
||||
|
||||
// For external content, use simple streaming (no transcoding support yet)
|
||||
return await StreamExternalContent(provider!, externalId!);
|
||||
// For external content, parse quality override from client transcoding params
|
||||
var quality = StreamQualityHelper.ParseFromQueryString(Request.Query);
|
||||
return await StreamExternalContent(provider!, externalId!, quality);
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
using System.Text.Json;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Controllers;
|
||||
|
||||
@@ -38,66 +39,9 @@ public partial class JellyfinController
|
||||
{
|
||||
var responseJson = result.RootElement.GetRawText();
|
||||
|
||||
// On successful auth, extract access token and post session capabilities in background
|
||||
if (statusCode == 200)
|
||||
{
|
||||
_logger.LogInformation("Authentication successful");
|
||||
|
||||
// Extract access token from response for session capabilities
|
||||
string? accessToken = null;
|
||||
if (result.RootElement.TryGetProperty("AccessToken", out var tokenEl))
|
||||
{
|
||||
accessToken = tokenEl.GetString();
|
||||
}
|
||||
|
||||
// Post session capabilities in background if we have a token
|
||||
if (!string.IsNullOrEmpty(accessToken))
|
||||
{
|
||||
// Capture token in closure - don't use Request.Headers (will be disposed)
|
||||
var token = accessToken;
|
||||
_ = Task.Run(async () =>
|
||||
{
|
||||
try
|
||||
{
|
||||
_logger.LogDebug("🔧 Posting session capabilities after authentication");
|
||||
|
||||
// Build auth header with the new token
|
||||
var authHeaders = new HeaderDictionary
|
||||
{
|
||||
["X-Emby-Token"] = token
|
||||
};
|
||||
|
||||
var capabilities = new
|
||||
{
|
||||
PlayableMediaTypes = new[] { "Audio" },
|
||||
SupportedCommands = Array.Empty<string>(),
|
||||
SupportsMediaControl = false,
|
||||
SupportsPersistentIdentifier = true,
|
||||
SupportsSync = false
|
||||
};
|
||||
|
||||
var capabilitiesJson = JsonSerializer.Serialize(capabilities);
|
||||
var (capResult, capStatus) =
|
||||
await _proxyService.PostJsonAsync("Sessions/Capabilities/Full", capabilitiesJson,
|
||||
authHeaders);
|
||||
|
||||
if (capStatus == 204 || capStatus == 200)
|
||||
{
|
||||
_logger.LogDebug("✓ Session capabilities posted after auth ({StatusCode})",
|
||||
capStatus);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogDebug("⚠ Session capabilities returned {StatusCode} after auth",
|
||||
capStatus);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to post session capabilities after auth");
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
|
||||
@@ -145,12 +145,11 @@ public partial class JellyfinController
|
||||
return NotFound(new { error = "Song not found" });
|
||||
}
|
||||
|
||||
// Strip [S] suffix from title, artist, and album for lyrics search
|
||||
// The [S] tag is added to external tracks but shouldn't be used in lyrics queries
|
||||
var searchTitle = song.Title.Replace(" [S]", "").Trim();
|
||||
var searchArtist = song.Artist?.Replace(" [S]", "").Trim() ?? "";
|
||||
var searchAlbum = song.Album?.Replace(" [S]", "").Trim() ?? "";
|
||||
var searchArtists = song.Artists.Select(a => a.Replace(" [S]", "").Trim()).ToList();
|
||||
// Strip external track labels from lyrics search terms.
|
||||
var searchTitle = StripTrackDecorators(song.Title);
|
||||
var searchArtist = StripTrackDecorators(song.Artist);
|
||||
var searchAlbum = StripTrackDecorators(song.Album);
|
||||
var searchArtists = song.Artists.Select(StripTrackDecorators).ToList();
|
||||
|
||||
if (searchArtists.Count == 0 && !string.IsNullOrEmpty(searchArtist))
|
||||
{
|
||||
@@ -379,11 +378,11 @@ public partial class JellyfinController
|
||||
return;
|
||||
}
|
||||
|
||||
// Strip [S] suffix for lyrics search
|
||||
var searchTitle = song.Title.Replace(" [S]", "").Trim();
|
||||
var searchArtist = song.Artist?.Replace(" [S]", "").Trim() ?? "";
|
||||
var searchAlbum = song.Album?.Replace(" [S]", "").Trim() ?? "";
|
||||
var searchArtists = song.Artists.Select(a => a.Replace(" [S]", "").Trim()).ToList();
|
||||
// Strip external track labels for lyrics search.
|
||||
var searchTitle = StripTrackDecorators(song.Title);
|
||||
var searchArtist = StripTrackDecorators(song.Artist);
|
||||
var searchAlbum = StripTrackDecorators(song.Album);
|
||||
var searchArtists = song.Artists.Select(StripTrackDecorators).ToList();
|
||||
|
||||
if (searchArtists.Count == 0 && !string.IsNullOrEmpty(searchArtist))
|
||||
{
|
||||
@@ -467,5 +466,18 @@ public partial class JellyfinController
|
||||
}
|
||||
}
|
||||
|
||||
private static string StripTrackDecorators(string? value)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(value))
|
||||
{
|
||||
return string.Empty;
|
||||
}
|
||||
|
||||
return value
|
||||
.Replace(" [S]", "", StringComparison.Ordinal)
|
||||
.Replace(" [E]", "", StringComparison.Ordinal)
|
||||
.Trim();
|
||||
}
|
||||
|
||||
#endregion
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1558,9 +1558,14 @@ public partial class JellyfinController
|
||||
string.Join(", ", Request.Headers.Keys.Where(h =>
|
||||
h.Contains("Auth", StringComparison.OrdinalIgnoreCase))));
|
||||
|
||||
// Read body if present
|
||||
string body = "{}";
|
||||
if ((method == "POST" || method == "PUT") && Request.ContentLength > 0)
|
||||
// Read body if present. Preserve true empty-body requests because Jellyfin
|
||||
// uses several POST session-control endpoints with query params only.
|
||||
string? body = null;
|
||||
var hasRequestBody = !HttpMethods.IsGet(method) &&
|
||||
(Request.ContentLength.GetValueOrDefault() > 0 ||
|
||||
Request.Headers.ContainsKey("Transfer-Encoding"));
|
||||
|
||||
if (hasRequestBody)
|
||||
{
|
||||
Request.EnableBuffering();
|
||||
using (var reader = new StreamReader(Request.Body, System.Text.Encoding.UTF8,
|
||||
@@ -1577,9 +1582,9 @@ public partial class JellyfinController
|
||||
var (result, statusCode) = method switch
|
||||
{
|
||||
"GET" => await _proxyService.GetJsonAsync(endpoint, null, Request.Headers),
|
||||
"POST" => await _proxyService.PostJsonAsync(endpoint, body, Request.Headers),
|
||||
"PUT" => await _proxyService.PostJsonAsync(endpoint, body, Request.Headers), // Use POST for PUT
|
||||
"DELETE" => await _proxyService.PostJsonAsync(endpoint, body, Request.Headers), // Use POST for DELETE
|
||||
"POST" => await _proxyService.SendAsync(HttpMethod.Post, endpoint, body, Request.Headers, Request.ContentType),
|
||||
"PUT" => await _proxyService.SendAsync(HttpMethod.Put, endpoint, body, Request.Headers, Request.ContentType),
|
||||
"DELETE" => await _proxyService.SendAsync(HttpMethod.Delete, endpoint, body, Request.Headers, Request.ContentType),
|
||||
_ => (null, 405)
|
||||
};
|
||||
|
||||
|
||||
@@ -1,5 +1,7 @@
|
||||
using System.Text.Json;
|
||||
using System.Text;
|
||||
using allstarr.Models.Domain;
|
||||
using allstarr.Models.Search;
|
||||
using allstarr.Models.Subsonic;
|
||||
using allstarr.Services.Common;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
@@ -31,9 +33,11 @@ public partial class JellyfinController
|
||||
{
|
||||
var boundSearchTerm = searchTerm;
|
||||
searchTerm = GetEffectiveSearchTerm(searchTerm, Request.QueryString.Value);
|
||||
string? searchCacheKey = null;
|
||||
|
||||
// AlbumArtistIds takes precedence over ArtistIds if both are provided
|
||||
var effectiveArtistIds = albumArtistIds ?? artistIds;
|
||||
var favoritesOnlyRequest = IsFavoritesOnlyRequest();
|
||||
|
||||
_logger.LogDebug("=== SEARCHITEMS V2 CALLED === searchTerm={SearchTerm}, includeItemTypes={ItemTypes}, parentId={ParentId}, artistIds={ArtistIds}, albumArtistIds={AlbumArtistIds}, albumIds={AlbumIds}, userId={UserId}",
|
||||
searchTerm, includeItemTypes, parentId, artistIds, albumArtistIds, albumIds, userId);
|
||||
@@ -63,6 +67,12 @@ public partial class JellyfinController
|
||||
|
||||
if (isExternal)
|
||||
{
|
||||
if (favoritesOnlyRequest)
|
||||
{
|
||||
_logger.LogDebug("Suppressing external artist results for favorites-only request: {ArtistId}", artistId);
|
||||
return CreateEmptyItemsResponse(startIndex);
|
||||
}
|
||||
|
||||
// Check if this is a curator ID (format: ext-{provider}-curator-{name})
|
||||
if (artistId.Contains("-curator-", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
@@ -85,6 +95,12 @@ public partial class JellyfinController
|
||||
|
||||
if (isExternal)
|
||||
{
|
||||
if (favoritesOnlyRequest)
|
||||
{
|
||||
_logger.LogDebug("Suppressing external album results for favorites-only request: {AlbumId}", albumId);
|
||||
return CreateEmptyItemsResponse(startIndex);
|
||||
}
|
||||
|
||||
_logger.LogDebug("Fetching songs for external album: {Provider}/{ExternalId}", provider,
|
||||
externalId);
|
||||
|
||||
@@ -120,6 +136,12 @@ public partial class JellyfinController
|
||||
|
||||
if (isExternal)
|
||||
{
|
||||
if (favoritesOnlyRequest)
|
||||
{
|
||||
_logger.LogDebug("Suppressing external parent results for favorites-only request: {ParentId}", parentId);
|
||||
return CreateEmptyItemsResponse(startIndex);
|
||||
}
|
||||
|
||||
// External parent - get external content
|
||||
_logger.LogDebug("Fetching children for external parent: {Provider}/{Type}/{ExternalId}",
|
||||
provider, type, externalId);
|
||||
@@ -161,7 +183,7 @@ public partial class JellyfinController
|
||||
// Check cache for search results (only cache pure searches, not filtered searches)
|
||||
if (string.IsNullOrWhiteSpace(effectiveArtistIds) && string.IsNullOrWhiteSpace(albumIds))
|
||||
{
|
||||
var cacheKey = CacheKeyBuilder.BuildSearchKey(
|
||||
searchCacheKey = CacheKeyBuilder.BuildSearchKey(
|
||||
searchTerm,
|
||||
includeItemTypes,
|
||||
limit,
|
||||
@@ -170,13 +192,14 @@ public partial class JellyfinController
|
||||
sortBy,
|
||||
Request.Query["SortOrder"].ToString(),
|
||||
recursive,
|
||||
userId);
|
||||
var cachedResult = await _cache.GetAsync<object>(cacheKey);
|
||||
userId,
|
||||
Request.Query["IsFavorite"].ToString());
|
||||
var cachedResult = await _cache.GetStringAsync(searchCacheKey);
|
||||
|
||||
if (cachedResult != null)
|
||||
if (!string.IsNullOrWhiteSpace(cachedResult))
|
||||
{
|
||||
_logger.LogInformation("SEARCH TRACE: cache hit for key '{CacheKey}'", cacheKey);
|
||||
return new JsonResult(cachedResult);
|
||||
_logger.LogInformation("SEARCH TRACE: cache hit for key '{CacheKey}'", searchCacheKey);
|
||||
return Content(cachedResult, "application/json");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -282,6 +305,7 @@ public partial class JellyfinController
|
||||
|
||||
// Run local and external searches in parallel
|
||||
var itemTypes = ParseItemTypes(includeItemTypes);
|
||||
var externalSearchLimits = GetExternalSearchLimits(itemTypes, limit, includePlaylistsAsAlbums: true);
|
||||
var jellyfinTask = GetLocalSearchResultForCurrentRequest(
|
||||
cleanQuery,
|
||||
includeItemTypes,
|
||||
@@ -290,14 +314,33 @@ public partial class JellyfinController
|
||||
recursive,
|
||||
userId);
|
||||
|
||||
// Use parallel metadata service if available (races providers), otherwise use primary
|
||||
var externalTask = _parallelMetadataService != null
|
||||
? _parallelMetadataService.SearchAllAsync(cleanQuery, limit, limit, limit, HttpContext.RequestAborted)
|
||||
: _metadataService.SearchAllAsync(cleanQuery, limit, limit, limit, HttpContext.RequestAborted);
|
||||
_logger.LogInformation(
|
||||
"SEARCH TRACE: external limits for query '{Query}' => songs={SongLimit}, albums={AlbumLimit}, artists={ArtistLimit}",
|
||||
cleanQuery,
|
||||
externalSearchLimits.SongLimit,
|
||||
externalSearchLimits.AlbumLimit,
|
||||
externalSearchLimits.ArtistLimit);
|
||||
|
||||
var playlistTask = _settings.EnableExternalPlaylists
|
||||
? _metadataService.SearchPlaylistsAsync(cleanQuery, limit, HttpContext.RequestAborted)
|
||||
: Task.FromResult(new List<ExternalPlaylist>());
|
||||
// Use parallel metadata service if available (races providers), otherwise use primary
|
||||
var externalTask = favoritesOnlyRequest
|
||||
? Task.FromResult(new SearchResult())
|
||||
: _parallelMetadataService != null
|
||||
? _parallelMetadataService.SearchAllAsync(
|
||||
cleanQuery,
|
||||
externalSearchLimits.SongLimit,
|
||||
externalSearchLimits.AlbumLimit,
|
||||
externalSearchLimits.ArtistLimit,
|
||||
HttpContext.RequestAborted)
|
||||
: _metadataService.SearchAllAsync(
|
||||
cleanQuery,
|
||||
externalSearchLimits.SongLimit,
|
||||
externalSearchLimits.AlbumLimit,
|
||||
externalSearchLimits.ArtistLimit,
|
||||
HttpContext.RequestAborted);
|
||||
|
||||
var playlistTask = favoritesOnlyRequest || !_settings.EnableExternalPlaylists
|
||||
? Task.FromResult(new List<ExternalPlaylist>())
|
||||
: _metadataService.SearchPlaylistsAsync(cleanQuery, limit, HttpContext.RequestAborted);
|
||||
|
||||
_logger.LogDebug("Playlist search enabled: {Enabled}, searching for: '{Query}'",
|
||||
_settings.EnableExternalPlaylists, cleanQuery);
|
||||
@@ -361,11 +404,11 @@ public partial class JellyfinController
|
||||
var externalAlbumItems = externalResult.Albums.Select(a => _responseBuilder.ConvertAlbumToJellyfinItem(a)).ToList();
|
||||
var externalArtistItems = externalResult.Artists.Select(a => _responseBuilder.ConvertArtistToJellyfinItem(a)).ToList();
|
||||
|
||||
// Score-sort each source, then interleave by highest remaining score.
|
||||
// Keep only a small source preference for already-relevant primary results.
|
||||
var allSongs = InterleaveByScore(jellyfinSongItems, externalSongItems, cleanQuery, primaryBoost: 1.5, boostMinScore: 72);
|
||||
var allAlbums = InterleaveByScore(jellyfinAlbumItems, externalAlbumItems, cleanQuery, primaryBoost: 1.5, boostMinScore: 78);
|
||||
var allArtists = InterleaveByScore(jellyfinArtistItems, externalArtistItems, cleanQuery, primaryBoost: 1.5, boostMinScore: 75);
|
||||
// Keep Jellyfin/provider ordering intact.
|
||||
// Scores only decide which source leads each interleaving round.
|
||||
var allSongs = InterleaveByScore(jellyfinSongItems, externalSongItems, cleanQuery, primaryBoost: 5.0);
|
||||
var allAlbums = InterleaveByScore(jellyfinAlbumItems, externalAlbumItems, cleanQuery, primaryBoost: 5.0);
|
||||
var allArtists = InterleaveByScore(jellyfinArtistItems, externalArtistItems, cleanQuery, primaryBoost: 5.0);
|
||||
|
||||
// Log top results for debugging
|
||||
if (_logger.IsEnabled(LogLevel.Debug))
|
||||
@@ -414,13 +457,8 @@ public partial class JellyfinController
|
||||
_logger.LogDebug("No playlists found to merge with albums");
|
||||
}
|
||||
|
||||
// Merge albums and playlists using score-based interleaving (albums keep a light priority over playlists).
|
||||
var mergedAlbumsAndPlaylists = InterleaveByScore(allAlbums, mergedPlaylistItems, cleanQuery, primaryBoost: 2.0, boostMinScore: 70);
|
||||
mergedAlbumsAndPlaylists = ApplyRequestedAlbumOrderingIfApplicable(
|
||||
mergedAlbumsAndPlaylists,
|
||||
itemTypes,
|
||||
Request.Query["SortBy"].ToString(),
|
||||
Request.Query["SortOrder"].ToString());
|
||||
// Keep album/playlist source ordering intact and only let scores decide who leads each round.
|
||||
var mergedAlbumsAndPlaylists = InterleaveByScore(allAlbums, mergedPlaylistItems, cleanQuery, primaryBoost: 0.0);
|
||||
|
||||
_logger.LogDebug(
|
||||
"Merged results: Songs={Songs}, Albums+Playlists={AlbumsPlaylists}, Artists={Artists}",
|
||||
@@ -515,23 +553,16 @@ public partial class JellyfinController
|
||||
TotalRecordCount = items.Count,
|
||||
StartIndex = startIndex
|
||||
};
|
||||
var json = SerializeSearchResponseJson(response);
|
||||
|
||||
// Cache search results in Redis (15 min TTL, no file persistence)
|
||||
if (!string.IsNullOrWhiteSpace(searchTerm) && string.IsNullOrWhiteSpace(effectiveArtistIds))
|
||||
// Cache search results in Redis using the configured search TTL.
|
||||
if (!string.IsNullOrWhiteSpace(searchTerm) &&
|
||||
string.IsNullOrWhiteSpace(effectiveArtistIds) &&
|
||||
!string.IsNullOrWhiteSpace(searchCacheKey))
|
||||
{
|
||||
if (externalHasRequestedTypeResults)
|
||||
{
|
||||
var cacheKey = CacheKeyBuilder.BuildSearchKey(
|
||||
searchTerm,
|
||||
includeItemTypes,
|
||||
limit,
|
||||
startIndex,
|
||||
parentId,
|
||||
sortBy,
|
||||
Request.Query["SortOrder"].ToString(),
|
||||
recursive,
|
||||
userId);
|
||||
await _cache.SetAsync(cacheKey, response, CacheExtensions.SearchResultsTTL);
|
||||
await _cache.SetStringAsync(searchCacheKey, json, CacheExtensions.SearchResultsTTL);
|
||||
_logger.LogDebug("💾 Cached search results for '{SearchTerm}' ({Minutes} min TTL)", searchTerm,
|
||||
CacheExtensions.SearchResultsTTL.TotalMinutes);
|
||||
}
|
||||
@@ -546,12 +577,6 @@ public partial class JellyfinController
|
||||
|
||||
_logger.LogDebug("About to serialize response...");
|
||||
|
||||
var json = System.Text.Json.JsonSerializer.Serialize(response, new System.Text.Json.JsonSerializerOptions
|
||||
{
|
||||
PropertyNamingPolicy = null,
|
||||
DictionaryKeyPolicy = null
|
||||
});
|
||||
|
||||
if (_logger.IsEnabled(LogLevel.Debug))
|
||||
{
|
||||
var preview = json.Length > 200 ? json[..200] : json;
|
||||
@@ -567,6 +592,15 @@ public partial class JellyfinController
|
||||
}
|
||||
}
|
||||
|
||||
private static string SerializeSearchResponseJson<T>(T response) where T : class
|
||||
{
|
||||
return JsonSerializer.Serialize(response, new JsonSerializerOptions
|
||||
{
|
||||
PropertyNamingPolicy = null,
|
||||
DictionaryKeyPolicy = null
|
||||
});
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Gets child items of a parent (tracks in album, albums for artist).
|
||||
/// </summary>
|
||||
@@ -657,11 +691,36 @@ public partial class JellyfinController
|
||||
}
|
||||
|
||||
var cleanQuery = searchTerm.Trim().Trim('"');
|
||||
var requestedTypes = ParseItemTypes(includeItemTypes);
|
||||
var externalSearchLimits = GetExternalSearchLimits(requestedTypes, limit, includePlaylistsAsAlbums: false);
|
||||
var includesSongs = requestedTypes == null || requestedTypes.Length == 0 ||
|
||||
requestedTypes.Contains("Audio", StringComparer.OrdinalIgnoreCase);
|
||||
var includesAlbums = requestedTypes == null || requestedTypes.Length == 0 ||
|
||||
requestedTypes.Contains("MusicAlbum", StringComparer.OrdinalIgnoreCase);
|
||||
var includesArtists = requestedTypes == null || requestedTypes.Length == 0 ||
|
||||
requestedTypes.Contains("MusicArtist", StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
_logger.LogInformation(
|
||||
"SEARCH TRACE: hint limits for query '{Query}' => songs={SongLimit}, albums={AlbumLimit}, artists={ArtistLimit}",
|
||||
cleanQuery,
|
||||
externalSearchLimits.SongLimit,
|
||||
externalSearchLimits.AlbumLimit,
|
||||
externalSearchLimits.ArtistLimit);
|
||||
|
||||
// Use parallel metadata service if available (races providers), otherwise use primary
|
||||
var externalTask = _parallelMetadataService != null
|
||||
? _parallelMetadataService.SearchAllAsync(cleanQuery, limit, limit, limit, HttpContext.RequestAborted)
|
||||
: _metadataService.SearchAllAsync(cleanQuery, limit, limit, limit, HttpContext.RequestAborted);
|
||||
? _parallelMetadataService.SearchAllAsync(
|
||||
cleanQuery,
|
||||
externalSearchLimits.SongLimit,
|
||||
externalSearchLimits.AlbumLimit,
|
||||
externalSearchLimits.ArtistLimit,
|
||||
HttpContext.RequestAborted)
|
||||
: _metadataService.SearchAllAsync(
|
||||
cleanQuery,
|
||||
externalSearchLimits.SongLimit,
|
||||
externalSearchLimits.AlbumLimit,
|
||||
externalSearchLimits.ArtistLimit,
|
||||
HttpContext.RequestAborted);
|
||||
|
||||
// Run searches in parallel (local Jellyfin hints + external providers)
|
||||
var jellyfinTask = GetLocalSearchHintsResultForCurrentRequest(cleanQuery, userId);
|
||||
@@ -674,9 +733,15 @@ public partial class JellyfinController
|
||||
var (localSongs, localAlbums, localArtists) = _modelMapper.ParseSearchHintsResponse(jellyfinResult);
|
||||
|
||||
// NO deduplication - merge all results and take top matches
|
||||
var allSongs = localSongs.Concat(externalResult.Songs).Take(limit).ToList();
|
||||
var allAlbums = localAlbums.Concat(externalResult.Albums).Take(limit).ToList();
|
||||
var allArtists = localArtists.Concat(externalResult.Artists).Take(limit).ToList();
|
||||
var allSongs = includesSongs
|
||||
? localSongs.Concat(externalResult.Songs).Take(limit).ToList()
|
||||
: new List<Song>();
|
||||
var allAlbums = includesAlbums
|
||||
? localAlbums.Concat(externalResult.Albums).Take(limit).ToList()
|
||||
: new List<Album>();
|
||||
var allArtists = includesArtists
|
||||
? localArtists.Concat(externalResult.Artists).Take(limit).ToList()
|
||||
: new List<Artist>();
|
||||
|
||||
return _responseBuilder.CreateSearchHintsResponse(
|
||||
allSongs.Take(limit).ToList(),
|
||||
@@ -722,227 +787,87 @@ public partial class JellyfinController
|
||||
return MaskSensitiveQueryString(query);
|
||||
}
|
||||
|
||||
private List<Dictionary<string, object?>> ApplyRequestedAlbumOrderingIfApplicable(
|
||||
List<Dictionary<string, object?>> items,
|
||||
string[]? requestedTypes,
|
||||
string? sortBy,
|
||||
string? sortOrder)
|
||||
private bool IsFavoritesOnlyRequest()
|
||||
{
|
||||
if (items.Count <= 1 || string.IsNullOrWhiteSpace(sortBy))
|
||||
return string.Equals(Request.Query["IsFavorite"].ToString(), "true", StringComparison.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
private static (int SongLimit, int AlbumLimit, int ArtistLimit) GetExternalSearchLimits(
|
||||
string[]? requestedTypes,
|
||||
int limit,
|
||||
bool includePlaylistsAsAlbums)
|
||||
{
|
||||
if (limit <= 0)
|
||||
{
|
||||
return items;
|
||||
return (0, 0, 0);
|
||||
}
|
||||
|
||||
if (requestedTypes == null || requestedTypes.Length == 0)
|
||||
{
|
||||
return items;
|
||||
return (limit, limit, limit);
|
||||
}
|
||||
|
||||
var isAlbumOnlyRequest = requestedTypes.All(type =>
|
||||
string.Equals(type, "MusicAlbum", StringComparison.OrdinalIgnoreCase) ||
|
||||
string.Equals(type, "Playlist", StringComparison.OrdinalIgnoreCase));
|
||||
var includeSongs = requestedTypes.Contains("Audio", StringComparer.OrdinalIgnoreCase);
|
||||
var includeAlbums = requestedTypes.Contains("MusicAlbum", StringComparer.OrdinalIgnoreCase) ||
|
||||
(includePlaylistsAsAlbums &&
|
||||
requestedTypes.Contains("Playlist", StringComparer.OrdinalIgnoreCase));
|
||||
var includeArtists = requestedTypes.Contains("MusicArtist", StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
if (!isAlbumOnlyRequest)
|
||||
{
|
||||
return items;
|
||||
}
|
||||
|
||||
var sortFields = sortBy
|
||||
.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
|
||||
.Where(field => !string.IsNullOrWhiteSpace(field))
|
||||
.ToList();
|
||||
|
||||
if (sortFields.Count == 0)
|
||||
{
|
||||
return items;
|
||||
}
|
||||
|
||||
var descending = string.Equals(sortOrder, "Descending", StringComparison.OrdinalIgnoreCase);
|
||||
var sorted = items.ToList();
|
||||
sorted.Sort((left, right) => CompareAlbumItemsByRequestedSort(left, right, sortFields, descending));
|
||||
return sorted;
|
||||
return (
|
||||
includeSongs ? limit : 0,
|
||||
includeAlbums ? limit : 0,
|
||||
includeArtists ? limit : 0);
|
||||
}
|
||||
|
||||
private int CompareAlbumItemsByRequestedSort(
|
||||
Dictionary<string, object?> left,
|
||||
Dictionary<string, object?> right,
|
||||
IReadOnlyList<string> sortFields,
|
||||
bool descending)
|
||||
private static IActionResult CreateEmptyItemsResponse(int startIndex)
|
||||
{
|
||||
foreach (var field in sortFields)
|
||||
return new JsonResult(new
|
||||
{
|
||||
var comparison = CompareAlbumItemsByField(left, right, field);
|
||||
if (comparison == 0)
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
return descending ? -comparison : comparison;
|
||||
}
|
||||
|
||||
return string.Compare(GetItemStringValue(left, "Name"), GetItemStringValue(right, "Name"), StringComparison.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
private int CompareAlbumItemsByField(Dictionary<string, object?> left, Dictionary<string, object?> right, string field)
|
||||
{
|
||||
return field.ToLowerInvariant() switch
|
||||
{
|
||||
"sortname" => string.Compare(GetItemStringValue(left, "SortName"), GetItemStringValue(right, "SortName"), StringComparison.OrdinalIgnoreCase),
|
||||
"name" => string.Compare(GetItemStringValue(left, "Name"), GetItemStringValue(right, "Name"), StringComparison.OrdinalIgnoreCase),
|
||||
"datecreated" => DateTime.Compare(GetItemDateValue(left, "DateCreated"), GetItemDateValue(right, "DateCreated")),
|
||||
"premieredate" => DateTime.Compare(GetItemDateValue(left, "PremiereDate"), GetItemDateValue(right, "PremiereDate")),
|
||||
"productionyear" => CompareIntValues(GetItemIntValue(left, "ProductionYear"), GetItemIntValue(right, "ProductionYear")),
|
||||
_ => 0
|
||||
};
|
||||
}
|
||||
|
||||
private static int CompareIntValues(int? left, int? right)
|
||||
{
|
||||
if (left.HasValue && right.HasValue)
|
||||
{
|
||||
return left.Value.CompareTo(right.Value);
|
||||
}
|
||||
|
||||
if (left.HasValue)
|
||||
{
|
||||
return 1;
|
||||
}
|
||||
|
||||
if (right.HasValue)
|
||||
{
|
||||
return -1;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
private static DateTime GetItemDateValue(Dictionary<string, object?> item, string key)
|
||||
{
|
||||
if (!item.TryGetValue(key, out var value) || value == null)
|
||||
{
|
||||
return DateTime.MinValue;
|
||||
}
|
||||
|
||||
if (value is JsonElement jsonElement)
|
||||
{
|
||||
if (jsonElement.ValueKind == JsonValueKind.String &&
|
||||
DateTime.TryParse(jsonElement.GetString(), out var parsedDate))
|
||||
{
|
||||
return parsedDate;
|
||||
}
|
||||
|
||||
return DateTime.MinValue;
|
||||
}
|
||||
|
||||
if (DateTime.TryParse(value.ToString(), out var parsed))
|
||||
{
|
||||
return parsed;
|
||||
}
|
||||
|
||||
return DateTime.MinValue;
|
||||
}
|
||||
|
||||
private static int? GetItemIntValue(Dictionary<string, object?> item, string key)
|
||||
{
|
||||
if (!item.TryGetValue(key, out var value) || value == null)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
if (value is JsonElement jsonElement)
|
||||
{
|
||||
if (jsonElement.ValueKind == JsonValueKind.Number && jsonElement.TryGetInt32(out var intValue))
|
||||
{
|
||||
return intValue;
|
||||
}
|
||||
|
||||
if (jsonElement.ValueKind == JsonValueKind.String &&
|
||||
int.TryParse(jsonElement.GetString(), out var parsedInt))
|
||||
{
|
||||
return parsedInt;
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
return int.TryParse(value.ToString(), out var parsed) ? parsed : null;
|
||||
Items = Array.Empty<object>(),
|
||||
TotalRecordCount = 0,
|
||||
StartIndex = startIndex
|
||||
});
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Score-sorts each source and then interleaves by highest remaining score.
|
||||
/// This avoids weak head results in one source blocking stronger results later in that same source.
|
||||
/// Merges two source queues without reordering either queue.
|
||||
/// At each step, compare only the current head from each source and dequeue the winner.
|
||||
/// </summary>
|
||||
private List<Dictionary<string, object?>> InterleaveByScore(
|
||||
List<Dictionary<string, object?>> primaryItems,
|
||||
List<Dictionary<string, object?>> secondaryItems,
|
||||
string query,
|
||||
double primaryBoost,
|
||||
double boostMinScore = 70)
|
||||
double primaryBoost)
|
||||
{
|
||||
var primaryScored = primaryItems.Select((item, index) =>
|
||||
var primaryScored = primaryItems.Select(item =>
|
||||
{
|
||||
var baseScore = CalculateItemRelevanceScore(query, item);
|
||||
var finalScore = baseScore >= boostMinScore
|
||||
? Math.Min(100.0, baseScore + primaryBoost)
|
||||
: baseScore;
|
||||
return new
|
||||
{
|
||||
Item = item,
|
||||
BaseScore = baseScore,
|
||||
Score = finalScore,
|
||||
SourceIndex = index
|
||||
Score = Math.Min(100.0, CalculateItemRelevanceScore(query, item) + primaryBoost)
|
||||
};
|
||||
})
|
||||
.OrderByDescending(x => x.Score)
|
||||
.ThenByDescending(x => x.BaseScore)
|
||||
.ThenBy(x => x.SourceIndex)
|
||||
.ToList();
|
||||
|
||||
var secondaryScored = secondaryItems.Select((item, index) =>
|
||||
var secondaryScored = secondaryItems.Select(item =>
|
||||
{
|
||||
var baseScore = CalculateItemRelevanceScore(query, item);
|
||||
return new
|
||||
{
|
||||
Item = item,
|
||||
BaseScore = baseScore,
|
||||
Score = baseScore,
|
||||
SourceIndex = index
|
||||
Score = CalculateItemRelevanceScore(query, item)
|
||||
};
|
||||
})
|
||||
.OrderByDescending(x => x.Score)
|
||||
.ThenByDescending(x => x.BaseScore)
|
||||
.ThenBy(x => x.SourceIndex)
|
||||
.ToList();
|
||||
|
||||
var result = new List<Dictionary<string, object?>>(primaryScored.Count + secondaryScored.Count);
|
||||
int primaryIdx = 0, secondaryIdx = 0;
|
||||
|
||||
while (primaryIdx < primaryScored.Count || secondaryIdx < secondaryScored.Count)
|
||||
while (primaryIdx < primaryScored.Count && secondaryIdx < secondaryScored.Count)
|
||||
{
|
||||
if (primaryIdx >= primaryScored.Count)
|
||||
{
|
||||
result.Add(secondaryScored[secondaryIdx++].Item);
|
||||
continue;
|
||||
}
|
||||
|
||||
if (secondaryIdx >= secondaryScored.Count)
|
||||
{
|
||||
result.Add(primaryScored[primaryIdx++].Item);
|
||||
continue;
|
||||
}
|
||||
|
||||
var primaryCandidate = primaryScored[primaryIdx];
|
||||
var secondaryCandidate = secondaryScored[secondaryIdx];
|
||||
|
||||
if (primaryCandidate.Score > secondaryCandidate.Score)
|
||||
{
|
||||
result.Add(primaryScored[primaryIdx++].Item);
|
||||
}
|
||||
else if (secondaryCandidate.Score > primaryCandidate.Score)
|
||||
{
|
||||
result.Add(secondaryScored[secondaryIdx++].Item);
|
||||
}
|
||||
else if (primaryCandidate.BaseScore >= secondaryCandidate.BaseScore)
|
||||
if (primaryCandidate.Score >= secondaryCandidate.Score)
|
||||
{
|
||||
result.Add(primaryScored[primaryIdx++].Item);
|
||||
}
|
||||
@@ -952,146 +877,31 @@ public partial class JellyfinController
|
||||
}
|
||||
}
|
||||
|
||||
while (primaryIdx < primaryScored.Count)
|
||||
{
|
||||
result.Add(primaryScored[primaryIdx++].Item);
|
||||
}
|
||||
|
||||
while (secondaryIdx < secondaryScored.Count)
|
||||
{
|
||||
result.Add(secondaryScored[secondaryIdx++].Item);
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Calculates query relevance for a search item.
|
||||
/// Title is primary; metadata context is secondary and down-weighted.
|
||||
/// Calculates query relevance using the product's per-type rules.
|
||||
/// </summary>
|
||||
private double CalculateItemRelevanceScore(string query, Dictionary<string, object?> item)
|
||||
{
|
||||
var title = GetItemName(item);
|
||||
if (string.IsNullOrWhiteSpace(title))
|
||||
return GetItemType(item) switch
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
var titleScore = FuzzyMatcher.CalculateSimilarityAggressive(query, title);
|
||||
var searchText = BuildItemSearchText(item, title);
|
||||
|
||||
if (string.Equals(searchText, title, StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
return titleScore;
|
||||
}
|
||||
|
||||
var metadataScore = FuzzyMatcher.CalculateSimilarityAggressive(query, searchText);
|
||||
var weightedMetadataScore = metadataScore * 0.85;
|
||||
|
||||
var baseScore = Math.Max(titleScore, weightedMetadataScore);
|
||||
return ApplyQueryCoverageAdjustment(query, title, searchText, baseScore);
|
||||
}
|
||||
|
||||
private static double ApplyQueryCoverageAdjustment(string query, string title, string searchText, double baseScore)
|
||||
{
|
||||
var queryTokens = TokenizeForCoverage(query);
|
||||
if (queryTokens.Count < 2)
|
||||
{
|
||||
return baseScore;
|
||||
}
|
||||
|
||||
var titleCoverage = CalculateTokenCoverage(queryTokens, title);
|
||||
var searchCoverage = string.Equals(searchText, title, StringComparison.OrdinalIgnoreCase)
|
||||
? titleCoverage
|
||||
: CalculateTokenCoverage(queryTokens, searchText);
|
||||
|
||||
var coverage = Math.Max(titleCoverage, searchCoverage);
|
||||
|
||||
if (coverage >= 0.999)
|
||||
{
|
||||
return Math.Min(100.0, baseScore + 3.0);
|
||||
}
|
||||
|
||||
if (coverage >= 0.8)
|
||||
{
|
||||
return baseScore * 0.9;
|
||||
}
|
||||
|
||||
if (coverage >= 0.6)
|
||||
{
|
||||
return baseScore * 0.72;
|
||||
}
|
||||
|
||||
return baseScore * 0.5;
|
||||
}
|
||||
|
||||
private static double CalculateTokenCoverage(IReadOnlyList<string> queryTokens, string target)
|
||||
{
|
||||
var targetTokens = TokenizeForCoverage(target);
|
||||
if (queryTokens.Count == 0 || targetTokens.Count == 0)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
var matched = 0;
|
||||
foreach (var queryToken in queryTokens)
|
||||
{
|
||||
if (targetTokens.Any(targetToken => IsTokenMatch(queryToken, targetToken)))
|
||||
{
|
||||
matched++;
|
||||
}
|
||||
}
|
||||
|
||||
return (double)matched / queryTokens.Count;
|
||||
}
|
||||
|
||||
private static bool IsTokenMatch(string queryToken, string targetToken)
|
||||
{
|
||||
return queryToken.Equals(targetToken, StringComparison.Ordinal) ||
|
||||
queryToken.StartsWith(targetToken, StringComparison.Ordinal) ||
|
||||
targetToken.StartsWith(queryToken, StringComparison.Ordinal);
|
||||
}
|
||||
|
||||
private static IReadOnlyList<string> TokenizeForCoverage(string text)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(text))
|
||||
{
|
||||
return Array.Empty<string>();
|
||||
}
|
||||
|
||||
var normalized = NormalizeForCoverage(text);
|
||||
var allTokens = normalized
|
||||
.Split(' ', StringSplitOptions.RemoveEmptyEntries)
|
||||
.Distinct(StringComparer.Ordinal)
|
||||
.ToList();
|
||||
|
||||
if (allTokens.Count == 0)
|
||||
{
|
||||
return Array.Empty<string>();
|
||||
}
|
||||
|
||||
var significant = allTokens
|
||||
.Where(token => token.Length >= 2 && !SearchStopWords.Contains(token))
|
||||
.ToList();
|
||||
|
||||
return significant.Count > 0
|
||||
? significant
|
||||
: allTokens.Where(token => token.Length >= 2).ToList();
|
||||
}
|
||||
|
||||
private static string NormalizeForCoverage(string text)
|
||||
{
|
||||
var normalized = RemoveDiacritics(text).ToLowerInvariant();
|
||||
normalized = normalized.Replace('&', ' ');
|
||||
normalized = System.Text.RegularExpressions.Regex.Replace(normalized, @"[^\w\s]", " ");
|
||||
normalized = System.Text.RegularExpressions.Regex.Replace(normalized, @"\s+", " ").Trim();
|
||||
return normalized;
|
||||
}
|
||||
|
||||
private static string RemoveDiacritics(string text)
|
||||
{
|
||||
var normalized = text.Normalize(NormalizationForm.FormD);
|
||||
var chars = new List<char>(normalized.Length);
|
||||
|
||||
foreach (var c in normalized)
|
||||
{
|
||||
if (System.Globalization.CharUnicodeInfo.GetUnicodeCategory(c) != System.Globalization.UnicodeCategory.NonSpacingMark)
|
||||
{
|
||||
chars.Add(c);
|
||||
}
|
||||
}
|
||||
|
||||
return new string(chars.ToArray()).Normalize(NormalizationForm.FormC);
|
||||
"Audio" => CalculateSongRelevanceScore(query, item),
|
||||
"MusicAlbum" => CalculateAlbumRelevanceScore(query, item),
|
||||
"MusicArtist" => CalculateArtistRelevanceScore(query, item),
|
||||
_ => CalculateArtistRelevanceScore(query, item)
|
||||
};
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -1102,52 +912,90 @@ public partial class JellyfinController
|
||||
return GetItemStringValue(item, "Name");
|
||||
}
|
||||
|
||||
private string BuildItemSearchText(Dictionary<string, object?> item, string title)
|
||||
private double CalculateSongRelevanceScore(string query, Dictionary<string, object?> item)
|
||||
{
|
||||
var parts = new List<string>();
|
||||
|
||||
AddDistinct(parts, title);
|
||||
AddDistinct(parts, GetItemStringValue(item, "SortName"));
|
||||
AddDistinct(parts, GetItemStringValue(item, "AlbumArtist"));
|
||||
AddDistinct(parts, GetItemStringValue(item, "Artist"));
|
||||
AddDistinct(parts, GetItemStringValue(item, "Album"));
|
||||
|
||||
foreach (var artist in GetItemStringList(item, "Artists").Take(3))
|
||||
{
|
||||
AddDistinct(parts, artist);
|
||||
}
|
||||
|
||||
return string.Join(" ", parts);
|
||||
var title = GetItemName(item);
|
||||
var artistText = GetSongArtistText(item);
|
||||
return CalculateBestFuzzyScore(query, title, CombineSearchFields(title, artistText));
|
||||
}
|
||||
|
||||
private static readonly HashSet<string> SearchStopWords = new(StringComparer.Ordinal)
|
||||
private double CalculateAlbumRelevanceScore(string query, Dictionary<string, object?> item)
|
||||
{
|
||||
"a",
|
||||
"an",
|
||||
"and",
|
||||
"at",
|
||||
"for",
|
||||
"in",
|
||||
"of",
|
||||
"on",
|
||||
"the",
|
||||
"to",
|
||||
"with",
|
||||
"feat",
|
||||
"ft"
|
||||
};
|
||||
var albumName = GetItemName(item);
|
||||
var artistText = GetAlbumArtistText(item);
|
||||
return CalculateBestFuzzyScore(query, albumName, CombineSearchFields(albumName, artistText));
|
||||
}
|
||||
|
||||
private static void AddDistinct(List<string> values, string? value)
|
||||
private double CalculateArtistRelevanceScore(string query, Dictionary<string, object?> item)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(value))
|
||||
var artistName = GetItemName(item);
|
||||
if (string.IsNullOrWhiteSpace(artistName))
|
||||
{
|
||||
return;
|
||||
return 0;
|
||||
}
|
||||
|
||||
if (!values.Contains(value, StringComparer.OrdinalIgnoreCase))
|
||||
return FuzzyMatcher.CalculateSimilarityAggressive(query, artistName);
|
||||
}
|
||||
|
||||
private double CalculateBestFuzzyScore(string query, params string?[] candidates)
|
||||
{
|
||||
var best = 0;
|
||||
|
||||
foreach (var candidate in candidates)
|
||||
{
|
||||
values.Add(value);
|
||||
if (string.IsNullOrWhiteSpace(candidate))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
best = Math.Max(best, FuzzyMatcher.CalculateSimilarityAggressive(query, candidate));
|
||||
}
|
||||
|
||||
return best;
|
||||
}
|
||||
|
||||
private static string CombineSearchFields(params string?[] fields)
|
||||
{
|
||||
return string.Join(" ", fields.Where(field => !string.IsNullOrWhiteSpace(field)));
|
||||
}
|
||||
|
||||
private string GetItemType(Dictionary<string, object?> item)
|
||||
{
|
||||
return GetItemStringValue(item, "Type");
|
||||
}
|
||||
|
||||
private string GetSongArtistText(Dictionary<string, object?> item)
|
||||
{
|
||||
var artists = GetItemStringList(item, "Artists").Take(3).ToList();
|
||||
if (artists.Count > 0)
|
||||
{
|
||||
return string.Join(" ", artists);
|
||||
}
|
||||
|
||||
var albumArtist = GetItemStringValue(item, "AlbumArtist");
|
||||
if (!string.IsNullOrWhiteSpace(albumArtist))
|
||||
{
|
||||
return albumArtist;
|
||||
}
|
||||
|
||||
return GetItemStringValue(item, "Artist");
|
||||
}
|
||||
|
||||
private string GetAlbumArtistText(Dictionary<string, object?> item)
|
||||
{
|
||||
var albumArtist = GetItemStringValue(item, "AlbumArtist");
|
||||
if (!string.IsNullOrWhiteSpace(albumArtist))
|
||||
{
|
||||
return albumArtist;
|
||||
}
|
||||
|
||||
var artists = GetItemStringList(item, "Artists").Take(3).ToList();
|
||||
if (artists.Count > 0)
|
||||
{
|
||||
return string.Join(" ", artists);
|
||||
}
|
||||
|
||||
return GetItemStringValue(item, "Artist");
|
||||
}
|
||||
|
||||
private string GetItemStringValue(Dictionary<string, object?> item, string key)
|
||||
|
||||
@@ -63,11 +63,33 @@ public partial class JellyfinController
|
||||
var cachedJellyfinSignature = await _cache.GetAsync<string>(jellyfinSignatureCacheKey);
|
||||
|
||||
var jellyfinPlaylistChanged = cachedJellyfinSignature != currentJellyfinSignature;
|
||||
var requestNeedsGenreMetadata = RequestIncludesField("Genres");
|
||||
|
||||
// Check Redis cache first for fast serving (only if Jellyfin playlist hasn't changed)
|
||||
var cacheKey = CacheKeyBuilder.BuildSpotifyPlaylistItemsKey(spotifyPlaylistName);
|
||||
var cachedItems = await _cache.GetAsync<List<Dictionary<string, object?>>>(cacheKey);
|
||||
|
||||
if (cachedItems != null && cachedItems.Count > 0 &&
|
||||
InjectedPlaylistItemHelper.ContainsSyntheticLocalItems(cachedItems))
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"Ignoring Redis playlist cache for {Playlist}: found synthesized local items that should have remained raw Jellyfin objects",
|
||||
spotifyPlaylistName);
|
||||
await _cache.DeleteAsync(cacheKey);
|
||||
cachedItems = null;
|
||||
}
|
||||
|
||||
if (cachedItems != null && cachedItems.Count > 0 &&
|
||||
requestNeedsGenreMetadata &&
|
||||
InjectedPlaylistItemHelper.ContainsLocalItemsMissingGenreMetadata(cachedItems))
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"Ignoring Redis playlist cache for {Playlist}: local items are missing genre metadata required by this request",
|
||||
spotifyPlaylistName);
|
||||
await _cache.DeleteAsync(cacheKey);
|
||||
cachedItems = null;
|
||||
}
|
||||
|
||||
if (cachedItems != null && cachedItems.Count > 0 && !jellyfinPlaylistChanged)
|
||||
{
|
||||
_logger.LogDebug("✅ Loaded {Count} playlist items from Redis cache for {Playlist} (Jellyfin unchanged)",
|
||||
@@ -89,7 +111,26 @@ public partial class JellyfinController
|
||||
|
||||
// Check file cache as fallback
|
||||
var fileItems = await LoadPlaylistItemsFromFile(spotifyPlaylistName);
|
||||
if (fileItems != null && fileItems.Count > 0)
|
||||
if (fileItems != null && fileItems.Count > 0 &&
|
||||
InjectedPlaylistItemHelper.ContainsSyntheticLocalItems(fileItems))
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"Ignoring file playlist cache for {Playlist}: found synthesized local items that should have remained raw Jellyfin objects",
|
||||
spotifyPlaylistName);
|
||||
fileItems = null;
|
||||
}
|
||||
|
||||
if (fileItems != null && fileItems.Count > 0 &&
|
||||
requestNeedsGenreMetadata &&
|
||||
InjectedPlaylistItemHelper.ContainsLocalItemsMissingGenreMetadata(fileItems))
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"Ignoring file playlist cache for {Playlist}: local items are missing genre metadata required by this request",
|
||||
spotifyPlaylistName);
|
||||
fileItems = null;
|
||||
}
|
||||
|
||||
if (fileItems != null && fileItems.Count > 0 && !jellyfinPlaylistChanged)
|
||||
{
|
||||
_logger.LogDebug("✅ Loaded {Count} playlist items from file cache for {Playlist}",
|
||||
fileItems.Count, spotifyPlaylistName);
|
||||
@@ -208,6 +249,7 @@ public partial class JellyfinController
|
||||
var usedJellyfinItems = new HashSet<string>();
|
||||
var localUsedCount = 0;
|
||||
var externalUsedCount = 0;
|
||||
var unresolvedLocalCount = 0;
|
||||
|
||||
_logger.LogDebug("🔍 Building playlist in Spotify order with {SpotifyCount} positions...", spotifyTracks.Count);
|
||||
|
||||
@@ -283,9 +325,26 @@ public partial class JellyfinController
|
||||
}
|
||||
else
|
||||
{
|
||||
if (JellyfinItemSnapshotHelper.TryGetClonedRawItemSnapshot(
|
||||
matched.MatchedSong,
|
||||
out var cachedLocalItem))
|
||||
{
|
||||
ProviderIdsEnricher.EnsureSpotifyProviderIds(cachedLocalItem, spotifyTrack.SpotifyId,
|
||||
spotifyTrack.AlbumId);
|
||||
ApplySpotifyAddedAtDateCreated(cachedLocalItem, spotifyTrack.AddedAt);
|
||||
finalItems.Add(cachedLocalItem);
|
||||
localUsedCount++;
|
||||
_logger.LogDebug(
|
||||
"✅ Position #{Pos}: '{Title}' → LOCAL from cached raw snapshot (ID: {Id})",
|
||||
spotifyTrack.Position, spotifyTrack.Title, matched.MatchedSong.Id);
|
||||
continue;
|
||||
}
|
||||
|
||||
_logger.LogWarning(
|
||||
"⚠️ Position #{Pos}: '{Title}' marked as LOCAL but not found in Jellyfin items (ID: {Id})",
|
||||
"⚠️ Position #{Pos}: '{Title}' marked as LOCAL but not found in Jellyfin items (ID: {Id}); refusing to synthesize a replacement local object",
|
||||
spotifyTrack.Position, spotifyTrack.Title, matched.MatchedSong.Id);
|
||||
unresolvedLocalCount++;
|
||||
continue;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -316,6 +375,24 @@ public partial class JellyfinController
|
||||
_logger.LogDebug("🎵 Final playlist '{Playlist}': {Total} tracks ({Local} LOCAL + {External} EXTERNAL)",
|
||||
spotifyPlaylistName, finalItems.Count, localUsedCount, externalUsedCount);
|
||||
|
||||
if (unresolvedLocalCount > 0)
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"Aborting ordered injection for {Playlist}: {Count} local tracks could not be preserved from Jellyfin and would have been rewritten",
|
||||
spotifyPlaylistName, unresolvedLocalCount);
|
||||
await _cache.DeleteAsync(cacheKey);
|
||||
return null;
|
||||
}
|
||||
|
||||
if (InjectedPlaylistItemHelper.ContainsSyntheticLocalItems(finalItems))
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"Aborting ordered injection for {Playlist}: built playlist still contains synthesized local items",
|
||||
spotifyPlaylistName);
|
||||
await _cache.DeleteAsync(cacheKey);
|
||||
return null;
|
||||
}
|
||||
|
||||
// Save to file cache for persistence across restarts
|
||||
await SavePlaylistItemsToFile(spotifyPlaylistName, finalItems);
|
||||
|
||||
@@ -347,6 +424,30 @@ public partial class JellyfinController
|
||||
item["DateCreated"] = addedAt.Value.ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ss.fffffffZ");
|
||||
}
|
||||
|
||||
private bool RequestIncludesField(string fieldName)
|
||||
{
|
||||
if (!Request.Query.TryGetValue("Fields", out var rawValues) || rawValues.Count == 0)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
foreach (var rawValue in rawValues)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(rawValue))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var fields = rawValue.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries);
|
||||
if (fields.Any(field => string.Equals(field, fieldName, StringComparison.OrdinalIgnoreCase)))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// <summary>
|
||||
/// Copies an external track to the kept folder when favorited.
|
||||
@@ -623,8 +724,18 @@ public partial class JellyfinController
|
||||
}
|
||||
|
||||
#region Persistent Favorites Tracking
|
||||
|
||||
private readonly string _favoritesFilePath = "/app/cache/favorites.json";
|
||||
|
||||
/// <summary>
|
||||
/// Information about a favorited track for persistent storage.
|
||||
/// </summary>
|
||||
private class FavoriteTrackInfo
|
||||
{
|
||||
public string ItemId { get; set; } = "";
|
||||
public string Title { get; set; } = "";
|
||||
public string Artist { get; set; } = "";
|
||||
public string Album { get; set; } = "";
|
||||
public DateTime FavoritedAt { get; set; }
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Checks if a track is already favorited (persistent across restarts).
|
||||
@@ -633,13 +744,7 @@ public partial class JellyfinController
|
||||
{
|
||||
try
|
||||
{
|
||||
if (!System.IO.File.Exists(_favoritesFilePath))
|
||||
return false;
|
||||
|
||||
var json = await System.IO.File.ReadAllTextAsync(_favoritesFilePath);
|
||||
var favorites = JsonSerializer.Deserialize<Dictionary<string, FavoriteTrackInfo>>(json) ?? new();
|
||||
|
||||
return favorites.ContainsKey(itemId);
|
||||
return await _cache.ExistsAsync($"favorites:{itemId}");
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
@@ -655,29 +760,16 @@ public partial class JellyfinController
|
||||
{
|
||||
try
|
||||
{
|
||||
var favorites = new Dictionary<string, FavoriteTrackInfo>();
|
||||
|
||||
if (System.IO.File.Exists(_favoritesFilePath))
|
||||
{
|
||||
var json = await System.IO.File.ReadAllTextAsync(_favoritesFilePath);
|
||||
favorites = JsonSerializer.Deserialize<Dictionary<string, FavoriteTrackInfo>>(json) ?? new();
|
||||
}
|
||||
|
||||
favorites[itemId] = new FavoriteTrackInfo
|
||||
var info = new FavoriteTrackInfo
|
||||
{
|
||||
ItemId = itemId,
|
||||
Title = song.Title,
|
||||
Artist = song.Artist,
|
||||
Album = song.Album,
|
||||
Title = song.Title ?? "Unknown Title",
|
||||
Artist = song.Artist ?? "Unknown Artist",
|
||||
Album = song.Album ?? "Unknown Album",
|
||||
FavoritedAt = DateTime.UtcNow
|
||||
};
|
||||
|
||||
// Ensure cache directory exists
|
||||
Directory.CreateDirectory(Path.GetDirectoryName(_favoritesFilePath)!);
|
||||
|
||||
var updatedJson = JsonSerializer.Serialize(favorites, new JsonSerializerOptions { WriteIndented = true });
|
||||
await System.IO.File.WriteAllTextAsync(_favoritesFilePath, updatedJson);
|
||||
|
||||
|
||||
await _cache.SetAsync($"favorites:{itemId}", info);
|
||||
_logger.LogDebug("Marked track as favorited: {ItemId}", itemId);
|
||||
}
|
||||
catch (Exception ex)
|
||||
@@ -693,17 +785,9 @@ public partial class JellyfinController
|
||||
{
|
||||
try
|
||||
{
|
||||
if (!System.IO.File.Exists(_favoritesFilePath))
|
||||
return;
|
||||
|
||||
var json = await System.IO.File.ReadAllTextAsync(_favoritesFilePath);
|
||||
var favorites = JsonSerializer.Deserialize<Dictionary<string, FavoriteTrackInfo>>(json) ?? new();
|
||||
|
||||
if (favorites.Remove(itemId))
|
||||
if (await _cache.ExistsAsync($"favorites:{itemId}"))
|
||||
{
|
||||
var updatedJson =
|
||||
JsonSerializer.Serialize(favorites, new JsonSerializerOptions { WriteIndented = true });
|
||||
await System.IO.File.WriteAllTextAsync(_favoritesFilePath, updatedJson);
|
||||
await _cache.DeleteAsync($"favorites:{itemId}");
|
||||
_logger.LogDebug("Removed track from favorites: {ItemId}", itemId);
|
||||
}
|
||||
}
|
||||
@@ -720,24 +804,8 @@ public partial class JellyfinController
|
||||
{
|
||||
try
|
||||
{
|
||||
var deletionFilePath = "/app/cache/pending_deletions.json";
|
||||
var pendingDeletions = new Dictionary<string, DateTime>();
|
||||
|
||||
if (System.IO.File.Exists(deletionFilePath))
|
||||
{
|
||||
var json = await System.IO.File.ReadAllTextAsync(deletionFilePath);
|
||||
pendingDeletions = JsonSerializer.Deserialize<Dictionary<string, DateTime>>(json) ?? new();
|
||||
}
|
||||
|
||||
// Mark for deletion 24 hours from now
|
||||
pendingDeletions[itemId] = DateTime.UtcNow.AddHours(24);
|
||||
|
||||
// Ensure cache directory exists
|
||||
Directory.CreateDirectory(Path.GetDirectoryName(deletionFilePath)!);
|
||||
|
||||
var updatedJson =
|
||||
JsonSerializer.Serialize(pendingDeletions, new JsonSerializerOptions { WriteIndented = true });
|
||||
await System.IO.File.WriteAllTextAsync(deletionFilePath, updatedJson);
|
||||
var deletionTime = DateTime.UtcNow.AddHours(24);
|
||||
await _cache.SetStringAsync($"pending_deletion:{itemId}", deletionTime.ToString("O"));
|
||||
|
||||
// Also remove from favorites immediately
|
||||
await UnmarkTrackAsFavoritedAsync(itemId);
|
||||
@@ -750,18 +818,6 @@ public partial class JellyfinController
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Information about a favorited track for persistent storage.
|
||||
/// </summary>
|
||||
private class FavoriteTrackInfo
|
||||
{
|
||||
public string ItemId { get; set; } = "";
|
||||
public string Title { get; set; } = "";
|
||||
public string Artist { get; set; } = "";
|
||||
public string Album { get; set; } = "";
|
||||
public DateTime FavoritedAt { get; set; }
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Processes pending deletions (called by cleanup service).
|
||||
/// </summary>
|
||||
@@ -769,31 +825,29 @@ public partial class JellyfinController
|
||||
{
|
||||
try
|
||||
{
|
||||
var deletionFilePath = "/app/cache/pending_deletions.json";
|
||||
if (!System.IO.File.Exists(deletionFilePath))
|
||||
return;
|
||||
|
||||
var json = await System.IO.File.ReadAllTextAsync(deletionFilePath);
|
||||
var pendingDeletions = JsonSerializer.Deserialize<Dictionary<string, DateTime>>(json) ?? new();
|
||||
var deletionKeys = _cache.GetKeysByPattern("pending_deletion:*").ToList();
|
||||
if (deletionKeys.Count == 0) return;
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
var toDelete = pendingDeletions.Where(kvp => kvp.Value <= now).ToList();
|
||||
var remaining = pendingDeletions.Where(kvp => kvp.Value > now)
|
||||
.ToDictionary(kvp => kvp.Key, kvp => kvp.Value);
|
||||
int deletedCount = 0;
|
||||
|
||||
foreach (var (itemId, _) in toDelete)
|
||||
foreach (var key in deletionKeys)
|
||||
{
|
||||
await ActuallyDeleteTrackAsync(itemId);
|
||||
var timeStr = await _cache.GetStringAsync(key);
|
||||
if (string.IsNullOrEmpty(timeStr)) continue;
|
||||
|
||||
if (DateTime.TryParse(timeStr, out var scheduleTime) && scheduleTime <= now)
|
||||
{
|
||||
var itemId = key.Substring("pending_deletion:".Length);
|
||||
await ActuallyDeleteTrackAsync(itemId);
|
||||
await _cache.DeleteAsync(key);
|
||||
deletedCount++;
|
||||
}
|
||||
}
|
||||
|
||||
if (toDelete.Count > 0)
|
||||
if (deletedCount > 0)
|
||||
{
|
||||
// Update pending deletions file
|
||||
var updatedJson =
|
||||
JsonSerializer.Serialize(remaining, new JsonSerializerOptions { WriteIndented = true });
|
||||
await System.IO.File.WriteAllTextAsync(deletionFilePath, updatedJson);
|
||||
|
||||
_logger.LogDebug("Processed {Count} pending deletions", toDelete.Count);
|
||||
_logger.LogDebug("Processed {Count} pending deletions", deletedCount);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
|
||||
@@ -201,6 +201,16 @@ public partial class JellyfinController : ControllerBase
|
||||
/// </summary>
|
||||
private async Task<IActionResult> GetExternalChildItems(string provider, string type, string externalId, string? includeItemTypes, CancellationToken cancellationToken = default)
|
||||
{
|
||||
if (IsFavoritesOnlyRequest())
|
||||
{
|
||||
_logger.LogDebug(
|
||||
"Suppressing external child items for favorites-only request: provider={Provider}, type={Type}, externalId={ExternalId}",
|
||||
provider,
|
||||
type,
|
||||
externalId);
|
||||
return CreateEmptyItemsResponse(GetRequestedStartIndex());
|
||||
}
|
||||
|
||||
var itemTypes = ParseItemTypes(includeItemTypes);
|
||||
var itemTypesUnspecified = itemTypes == null || itemTypes.Length == 0;
|
||||
|
||||
@@ -280,6 +290,13 @@ public partial class JellyfinController : ControllerBase
|
||||
return _responseBuilder.CreateItemsResponse(new List<Song>());
|
||||
}
|
||||
|
||||
private int GetRequestedStartIndex()
|
||||
{
|
||||
return int.TryParse(Request.Query["StartIndex"], out var startIndex) && startIndex > 0
|
||||
? startIndex
|
||||
: 0;
|
||||
}
|
||||
|
||||
private List<Song> ApplySongSortAndPagingForCurrentRequest(IReadOnlyCollection<Song> songs, out int totalRecordCount, out int startIndex)
|
||||
{
|
||||
var sortBy = Request.Query["SortBy"].ToString();
|
||||
@@ -611,13 +628,20 @@ public partial class JellyfinController : ControllerBase
|
||||
|
||||
if (!isExternal)
|
||||
{
|
||||
var effectiveImageTag = tag;
|
||||
if (string.IsNullOrWhiteSpace(effectiveImageTag) &&
|
||||
_spotifySettings.IsSpotifyPlaylist(itemId))
|
||||
{
|
||||
effectiveImageTag = await ResolveCurrentSpotifyPlaylistImageTagAsync(itemId, imageType);
|
||||
}
|
||||
|
||||
// Proxy image from Jellyfin for local content
|
||||
var (imageBytes, contentType) = await _proxyService.GetImageAsync(
|
||||
itemId,
|
||||
imageType,
|
||||
maxWidth,
|
||||
maxHeight,
|
||||
tag);
|
||||
effectiveImageTag);
|
||||
|
||||
if (imageBytes == null || contentType == null)
|
||||
{
|
||||
@@ -654,7 +678,7 @@ public partial class JellyfinController : ControllerBase
|
||||
|
||||
if (fallbackBytes != null && fallbackContentType != null)
|
||||
{
|
||||
return File(fallbackBytes, fallbackContentType);
|
||||
return CreateConditionalImageResponse(fallbackBytes, fallbackContentType);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -663,7 +687,16 @@ public partial class JellyfinController : ControllerBase
|
||||
return await GetPlaceholderImageAsync();
|
||||
}
|
||||
|
||||
return File(imageBytes, contentType);
|
||||
return CreateConditionalImageResponse(imageBytes, contentType);
|
||||
}
|
||||
|
||||
// Check Redis cache for previously fetched external image
|
||||
var imageCacheKey = CacheKeyBuilder.BuildExternalImageKey(provider!, type!, externalId!);
|
||||
var cachedImageBytes = await _cache.GetAsync<byte[]>(imageCacheKey);
|
||||
if (cachedImageBytes != null)
|
||||
{
|
||||
_logger.LogDebug("Cache hit for external {Type} image: {Provider}/{ExternalId}", type, provider, externalId);
|
||||
return CreateConditionalImageResponse(cachedImageBytes, "image/jpeg");
|
||||
}
|
||||
|
||||
// Get external cover art URL
|
||||
@@ -729,9 +762,12 @@ public partial class JellyfinController : ControllerBase
|
||||
return await GetPlaceholderImageAsync();
|
||||
}
|
||||
|
||||
_logger.LogDebug("Successfully fetched external image from host {Host}, size: {Size} bytes",
|
||||
// Cache the fetched image bytes in Redis for future requests
|
||||
await _cache.SetAsync(imageCacheKey, imageBytes, CacheExtensions.ProxyImagesTTL);
|
||||
|
||||
_logger.LogDebug("Successfully fetched and cached external image from host {Host}, size: {Size} bytes",
|
||||
safeCoverUri.Host, imageBytes.Length);
|
||||
return File(imageBytes, "image/jpeg");
|
||||
return CreateConditionalImageResponse(imageBytes, "image/jpeg");
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
@@ -753,7 +789,7 @@ public partial class JellyfinController : ControllerBase
|
||||
if (System.IO.File.Exists(placeholderPath))
|
||||
{
|
||||
var imageBytes = await System.IO.File.ReadAllBytesAsync(placeholderPath);
|
||||
return File(imageBytes, "image/png");
|
||||
return CreateConditionalImageResponse(imageBytes, "image/png");
|
||||
}
|
||||
|
||||
// Fallback: Return a 1x1 transparent PNG as minimal placeholder
|
||||
@@ -761,7 +797,54 @@ public partial class JellyfinController : ControllerBase
|
||||
"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg=="
|
||||
);
|
||||
|
||||
return File(transparentPng, "image/png");
|
||||
return CreateConditionalImageResponse(transparentPng, "image/png");
|
||||
}
|
||||
|
||||
private IActionResult CreateConditionalImageResponse(byte[] imageBytes, string contentType)
|
||||
{
|
||||
var etag = ImageConditionalRequestHelper.ComputeStrongETag(imageBytes);
|
||||
Response.Headers["ETag"] = etag;
|
||||
|
||||
if (ImageConditionalRequestHelper.MatchesIfNoneMatch(Request.Headers, etag))
|
||||
{
|
||||
return StatusCode(StatusCodes.Status304NotModified);
|
||||
}
|
||||
|
||||
return File(imageBytes, contentType);
|
||||
}
|
||||
|
||||
private async Task<string?> ResolveCurrentSpotifyPlaylistImageTagAsync(string itemId, string imageType)
|
||||
{
|
||||
try
|
||||
{
|
||||
var (itemResult, statusCode) = await _proxyService.GetJsonAsyncInternal($"Items/{itemId}");
|
||||
if (itemResult == null || statusCode != 200)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
using var itemDocument = itemResult;
|
||||
var imageTag = ExtractImageTag(itemDocument.RootElement, imageType);
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(imageTag))
|
||||
{
|
||||
_logger.LogDebug(
|
||||
"Resolved current Jellyfin {ImageType} image tag for Spotify playlist {PlaylistId}: {ImageTag}",
|
||||
imageType,
|
||||
itemId,
|
||||
imageTag);
|
||||
}
|
||||
|
||||
return imageTag;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogDebug(ex,
|
||||
"Failed to resolve current Jellyfin {ImageType} image tag for Spotify playlist {PlaylistId}",
|
||||
imageType,
|
||||
itemId);
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
#endregion
|
||||
@@ -1263,33 +1346,37 @@ public partial class JellyfinController : ControllerBase
|
||||
});
|
||||
}
|
||||
|
||||
// Intercept Spotify playlist requests by ID
|
||||
if (_spotifySettings.Enabled &&
|
||||
path.StartsWith("playlists/", StringComparison.OrdinalIgnoreCase) &&
|
||||
path.Contains("/items", StringComparison.OrdinalIgnoreCase))
|
||||
var playlistItemsRequestId = GetExactPlaylistItemsRequestId(path);
|
||||
if (!string.IsNullOrEmpty(playlistItemsRequestId))
|
||||
{
|
||||
// Extract playlist ID from path: playlists/{id}/items
|
||||
var parts = path.Split('/', StringSplitOptions.RemoveEmptyEntries);
|
||||
if (parts.Length >= 2 && parts[0].Equals("playlists", StringComparison.OrdinalIgnoreCase))
|
||||
if (_spotifySettings.Enabled)
|
||||
{
|
||||
var playlistId = parts[1];
|
||||
|
||||
_logger.LogDebug("=== PLAYLIST REQUEST ===");
|
||||
_logger.LogInformation("Playlist ID: {PlaylistId}", playlistId);
|
||||
_logger.LogInformation("Playlist ID: {PlaylistId}", playlistItemsRequestId);
|
||||
_logger.LogInformation("Spotify Enabled: {Enabled}", _spotifySettings.Enabled);
|
||||
_logger.LogInformation("Configured Playlists: {Playlists}", string.Join(", ", _spotifySettings.Playlists.Select(p => $"{p.Name}:{p.Id}")));
|
||||
_logger.LogInformation("Is configured: {IsConfigured}", _spotifySettings.IsSpotifyPlaylist(playlistId));
|
||||
_logger.LogInformation("Is configured: {IsConfigured}", _spotifySettings.IsSpotifyPlaylist(playlistItemsRequestId));
|
||||
|
||||
// Check if this playlist ID is configured for Spotify injection
|
||||
if (_spotifySettings.IsSpotifyPlaylist(playlistId))
|
||||
if (_spotifySettings.IsSpotifyPlaylist(playlistItemsRequestId))
|
||||
{
|
||||
_logger.LogInformation("========================================");
|
||||
_logger.LogInformation("=== INTERCEPTING SPOTIFY PLAYLIST ===");
|
||||
_logger.LogInformation("Playlist ID: {PlaylistId}", playlistId);
|
||||
_logger.LogInformation("Playlist ID: {PlaylistId}", playlistItemsRequestId);
|
||||
_logger.LogInformation("========================================");
|
||||
return await GetPlaylistTracks(playlistId);
|
||||
return await GetPlaylistTracks(playlistItemsRequestId);
|
||||
}
|
||||
}
|
||||
|
||||
var playlistItemsPath = path;
|
||||
if (Request.QueryString.HasValue)
|
||||
{
|
||||
playlistItemsPath = $"{playlistItemsPath}{Request.QueryString.Value}";
|
||||
}
|
||||
|
||||
_logger.LogDebug("Using transparent Jellyfin passthrough for non-injected playlist {PlaylistId}",
|
||||
playlistItemsRequestId);
|
||||
return await ProxyJsonPassthroughAsync(playlistItemsPath);
|
||||
}
|
||||
|
||||
// Handle non-JSON responses (images, robots.txt, etc.)
|
||||
|
||||
@@ -161,8 +161,15 @@ public class SubsonicController : ControllerBase
|
||||
|
||||
try
|
||||
{
|
||||
var downloadStream = await _downloadService.DownloadAndStreamAsync(provider!, externalId!, HttpContext.RequestAborted);
|
||||
return File(downloadStream, "audio/mpeg", enableRangeProcessing: true);
|
||||
var downloadStream = await _downloadService.DownloadAndStreamAsync(provider!, externalId!, cancellationToken: HttpContext.RequestAborted);
|
||||
|
||||
var contentType = "audio/mpeg";
|
||||
if (downloadStream is FileStream fs)
|
||||
{
|
||||
contentType = GetContentType(fs.Name);
|
||||
}
|
||||
|
||||
return File(downloadStream, contentType, enableRangeProcessing: true);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
|
||||
@@ -0,0 +1,37 @@
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Middleware;
|
||||
|
||||
/// <summary>
|
||||
/// Short-circuits common internet scanner paths before they reach the Jellyfin proxy.
|
||||
/// </summary>
|
||||
public class BotProbeBlockMiddleware
|
||||
{
|
||||
private readonly RequestDelegate _next;
|
||||
private readonly ILogger<BotProbeBlockMiddleware> _logger;
|
||||
|
||||
public BotProbeBlockMiddleware(
|
||||
RequestDelegate next,
|
||||
ILogger<BotProbeBlockMiddleware> logger)
|
||||
{
|
||||
_next = next;
|
||||
_logger = logger;
|
||||
}
|
||||
|
||||
public async Task InvokeAsync(HttpContext context)
|
||||
{
|
||||
var requestPath = context.Request.Path.Value;
|
||||
if (!BotProbeDetector.IsHighConfidenceProbePath(requestPath))
|
||||
{
|
||||
await _next(context);
|
||||
return;
|
||||
}
|
||||
|
||||
_logger.LogDebug("Short-circuited likely bot probe from {RemoteIp}: {Method} {Path}",
|
||||
context.Connection.RemoteIpAddress?.ToString() ?? "(null)",
|
||||
context.Request.Method,
|
||||
requestPath);
|
||||
|
||||
context.Response.StatusCode = StatusCodes.Status404NotFound;
|
||||
}
|
||||
}
|
||||
@@ -120,6 +120,11 @@ public class WebSocketProxyMiddleware
|
||||
serverWebSocket.Options.SetRequestHeader("X-Emby-Authorization", embyAuthHeader.ToString());
|
||||
_logger.LogDebug("🔑 WEBSOCKET: Forwarded X-Emby-Authorization header");
|
||||
}
|
||||
else if (context.Request.Headers.TryGetValue("X-Emby-Token", out var tokenHeader))
|
||||
{
|
||||
serverWebSocket.Options.SetRequestHeader("X-Emby-Token", tokenHeader.ToString());
|
||||
_logger.LogDebug("🔑 WEBSOCKET: Forwarded X-Emby-Token header");
|
||||
}
|
||||
else if (context.Request.Headers.TryGetValue("Authorization", out var authHeader2))
|
||||
{
|
||||
var authValue = authHeader2.ToString();
|
||||
@@ -147,6 +152,11 @@ public class WebSocketProxyMiddleware
|
||||
clientWebSocket = await context.WebSockets.AcceptWebSocketAsync();
|
||||
_logger.LogDebug("✓ WEBSOCKET: Client WebSocket accepted");
|
||||
|
||||
if (!string.IsNullOrEmpty(deviceId))
|
||||
{
|
||||
await _sessionManager.RegisterProxiedWebSocketAsync(deviceId);
|
||||
}
|
||||
|
||||
// Start bidirectional proxying
|
||||
var clientToServer = ProxyMessagesAsync(clientWebSocket, serverWebSocket, "Client→Server", context.RequestAborted);
|
||||
var serverToClient = ProxyMessagesAsync(serverWebSocket, clientWebSocket, "Server→Client", context.RequestAborted);
|
||||
@@ -189,6 +199,11 @@ public class WebSocketProxyMiddleware
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (!string.IsNullOrEmpty(deviceId))
|
||||
{
|
||||
_sessionManager.UnregisterProxiedWebSocket(deviceId);
|
||||
}
|
||||
|
||||
// Clean up connections
|
||||
if (clientWebSocket?.State == WebSocketState.Open)
|
||||
{
|
||||
|
||||
@@ -112,8 +112,8 @@ public class Song
|
||||
public int? ExplicitContentLyrics { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Raw Jellyfin metadata (MediaSources, etc.) for local tracks
|
||||
/// Preserved to maintain bitrate and other technical details
|
||||
/// Raw Jellyfin metadata for local tracks, including MediaSources and cached item snapshots
|
||||
/// Preserved to maintain full Jellyfin object fidelity across cache round-trips
|
||||
/// </summary>
|
||||
public Dictionary<string, object?>? JellyfinMetadata { get; set; }
|
||||
}
|
||||
|
||||
@@ -8,8 +8,12 @@ public class DownloadInfo
|
||||
public string SongId { get; set; } = string.Empty;
|
||||
public string ExternalId { get; set; } = string.Empty;
|
||||
public string ExternalProvider { get; set; } = string.Empty;
|
||||
public string Title { get; set; } = string.Empty;
|
||||
public string Artist { get; set; } = string.Empty;
|
||||
public DownloadStatus Status { get; set; }
|
||||
public double Progress { get; set; } // 0.0 to 1.0
|
||||
public bool RequestedForStreaming { get; set; }
|
||||
public int? DurationSeconds { get; set; }
|
||||
public string? LocalPath { get; set; }
|
||||
public string? ErrorMessage { get; set; }
|
||||
public DateTime StartedAt { get; set; }
|
||||
|
||||
@@ -61,6 +61,14 @@ public class CacheSettings
|
||||
/// </summary>
|
||||
public int ProxyImagesDays { get; set; } = 14;
|
||||
|
||||
/// <summary>
|
||||
/// Transcoded audio cache duration in minutes.
|
||||
/// Quality-override files (downloaded at lower quality for cellular streaming)
|
||||
/// are cached in {downloads}/transcoded/ and cleaned up after this duration.
|
||||
/// Default: 60 minutes (1 hour)
|
||||
/// </summary>
|
||||
public int TranscodeCacheMinutes { get; set; } = 60;
|
||||
|
||||
// Helper methods to get TimeSpan values
|
||||
public TimeSpan SearchResultsTTL => TimeSpan.FromMinutes(SearchResultsMinutes);
|
||||
public TimeSpan PlaylistImagesTTL => TimeSpan.FromHours(PlaylistImagesHours);
|
||||
@@ -71,4 +79,5 @@ public class CacheSettings
|
||||
public TimeSpan MetadataTTL => TimeSpan.FromDays(MetadataDays);
|
||||
public TimeSpan OdesliLookupTTL => TimeSpan.FromDays(OdesliLookupDays);
|
||||
public TimeSpan ProxyImagesTTL => TimeSpan.FromDays(ProxyImagesDays);
|
||||
public TimeSpan TranscodeCacheTTL => TimeSpan.FromMinutes(TranscodeCacheMinutes);
|
||||
}
|
||||
|
||||
@@ -22,4 +22,10 @@ public class DeezerSettings
|
||||
/// If not specified or unavailable, the highest available quality will be used.
|
||||
/// </summary>
|
||||
public string? Quality { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Minimum interval between requests in milliseconds.
|
||||
/// Default: 200ms
|
||||
/// </summary>
|
||||
public int MinRequestIntervalMs { get; set; } = 200;
|
||||
}
|
||||
|
||||
@@ -22,4 +22,10 @@ public class QobuzSettings
|
||||
/// If not specified or unavailable, the highest available quality will be used.
|
||||
/// </summary>
|
||||
public string? Quality { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Minimum interval between requests in milliseconds.
|
||||
/// Default: 200ms
|
||||
/// </summary>
|
||||
public int MinRequestIntervalMs { get; set; } = 200;
|
||||
}
|
||||
|
||||
@@ -14,4 +14,10 @@ public class SquidWTFSettings
|
||||
/// If not specified or unavailable, LOSSLESS will be used.
|
||||
/// </summary>
|
||||
public string? Quality { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Minimum interval between requests in milliseconds.
|
||||
/// Default: 200ms
|
||||
/// </summary>
|
||||
public int MinRequestIntervalMs { get; set; } = 200;
|
||||
}
|
||||
|
||||
+36
-1
@@ -16,6 +16,7 @@ using Microsoft.Extensions.Http;
|
||||
using System.Net;
|
||||
|
||||
var builder = WebApplication.CreateBuilder(args);
|
||||
RuntimeEnvConfiguration.AddDotEnvOverrides(builder.Configuration, builder.Environment, Console.Out);
|
||||
|
||||
// Discover SquidWTF API and streaming endpoints from uptime feeds.
|
||||
var squidWtfEndpointCatalog = await SquidWtfEndpointDiscovery.DiscoverAsync();
|
||||
@@ -175,6 +176,25 @@ builder.Services.ConfigureAll<HttpClientFactoryOptions>(options =>
|
||||
// but we want to reduce noise in production logs
|
||||
options.SuppressHandlerScope = true;
|
||||
});
|
||||
|
||||
// Register a dedicated named HttpClient for Jellyfin backend with connection pooling.
|
||||
// SocketsHttpHandler reuses TCP connections across the scoped JellyfinProxyService
|
||||
// instances, eliminating per-request TCP/TLS handshake overhead.
|
||||
builder.Services.AddHttpClient(JellyfinProxyService.HttpClientName)
|
||||
.ConfigurePrimaryHttpMessageHandler(() => new SocketsHttpHandler
|
||||
{
|
||||
// Keep up to 20 idle connections to Jellyfin alive at any time
|
||||
MaxConnectionsPerServer = 20,
|
||||
// Recycle pooled connections every 5 minutes to pick up DNS changes
|
||||
PooledConnectionLifetime = TimeSpan.FromMinutes(5),
|
||||
// Close idle connections after 90 seconds to avoid stale sockets
|
||||
PooledConnectionIdleTimeout = TimeSpan.FromSeconds(90),
|
||||
// Allow HTTP/2 multiplexing when Jellyfin supports it
|
||||
EnableMultipleHttp2Connections = true,
|
||||
// Follow redirects within Jellyfin
|
||||
AllowAutoRedirect = true,
|
||||
MaxAutomaticRedirections = 5
|
||||
});
|
||||
builder.Services.AddEndpointsApiExplorer();
|
||||
builder.Services.AddSwaggerGen();
|
||||
builder.Services.AddHttpContextAccessor();
|
||||
@@ -509,6 +529,7 @@ else
|
||||
// Business services - shared across backends
|
||||
builder.Services.AddSingleton(squidWtfEndpointCatalog);
|
||||
builder.Services.AddSingleton<RedisCacheService>();
|
||||
builder.Services.AddSingleton<FavoritesMigrationService>();
|
||||
builder.Services.AddSingleton<OdesliService>();
|
||||
builder.Services.AddSingleton<ILocalLibraryService, LocalLibraryService>();
|
||||
builder.Services.AddSingleton<LrclibService>();
|
||||
@@ -891,6 +912,13 @@ builder.Services.AddCors(options =>
|
||||
|
||||
var app = builder.Build();
|
||||
|
||||
// Run one-time favorites/deletions migration if using Redis
|
||||
using (var scope = app.Services.CreateScope())
|
||||
{
|
||||
var migrationService = scope.ServiceProvider.GetRequiredService<FavoritesMigrationService>();
|
||||
await migrationService.MigrateAsync();
|
||||
}
|
||||
|
||||
// Initialize cache settings for static access
|
||||
CacheExtensions.InitializeCacheSettings(app.Services);
|
||||
|
||||
@@ -911,6 +939,9 @@ catch (Exception ex)
|
||||
// This processes X-Forwarded-For, X-Real-IP, etc. from nginx
|
||||
app.UseForwardedHeaders();
|
||||
|
||||
// Drop high-confidence scanner paths before they hit the proxy or request logging.
|
||||
app.UseMiddleware<BotProbeBlockMiddleware>();
|
||||
|
||||
// Request logging middleware (when DEBUG_LOG_ALL_REQUESTS=true)
|
||||
app.UseMiddleware<RequestLoggingMiddleware>();
|
||||
|
||||
@@ -934,7 +965,11 @@ if (app.Environment.IsDevelopment())
|
||||
app.UseSwaggerUI();
|
||||
}
|
||||
|
||||
app.UseHttpsRedirection();
|
||||
// The admin UI is documented and intended to be reachable directly over HTTP on port 5275.
|
||||
// Keep HTTPS redirection for non-admin traffic only.
|
||||
app.UseWhen(
|
||||
context => context.Connection.LocalPort != 5275,
|
||||
branch => branch.UseHttpsRedirection());
|
||||
|
||||
// Serve static files only on admin port (5275)
|
||||
app.UseMiddleware<allstarr.Middleware.AdminNetworkAllowlistMiddleware>();
|
||||
|
||||
@@ -4,6 +4,7 @@ using Microsoft.AspNetCore.Mvc;
|
||||
using Microsoft.Extensions.Options;
|
||||
using allstarr.Models.Settings;
|
||||
using allstarr.Models.Spotify;
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Services.Admin;
|
||||
|
||||
@@ -20,9 +21,7 @@ public class AdminHelperService
|
||||
{
|
||||
_logger = logger;
|
||||
_jellyfinSettings = jellyfinSettings.Value;
|
||||
_envFilePath = environment.IsDevelopment()
|
||||
? Path.Combine(environment.ContentRootPath, "..", ".env")
|
||||
: "/app/.env";
|
||||
_envFilePath = RuntimeEnvConfiguration.ResolveEnvFilePath(environment);
|
||||
}
|
||||
|
||||
public string GetJellyfinAuthHeader()
|
||||
|
||||
@@ -28,7 +28,18 @@ public static class AuthHeaderHelper
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
// Some Jellyfin clients send the raw token separately instead of a MediaBrowser auth header.
|
||||
foreach (var header in sourceHeaders)
|
||||
{
|
||||
if (header.Key.Equals("X-Emby-Token", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
var headerValue = header.Value.ToString();
|
||||
targetRequest.Headers.TryAddWithoutValidation("X-Emby-Token", headerValue);
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
// If no X-Emby-Authorization, check if Authorization header contains MediaBrowser format
|
||||
foreach (var header in sourceHeaders)
|
||||
{
|
||||
|
||||
@@ -29,13 +29,40 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
protected readonly string CachePath;
|
||||
|
||||
protected readonly ConcurrentDictionary<string, DownloadInfo> ActiveDownloads = new();
|
||||
protected readonly SemaphoreSlim DownloadLock = new(1, 1);
|
||||
|
||||
// Concurrency and state locking
|
||||
protected readonly SemaphoreSlim _stateSemaphore = new(1, 1);
|
||||
protected readonly SemaphoreSlim _concurrencySemaphore;
|
||||
|
||||
// Rate limiting fields
|
||||
private readonly SemaphoreSlim _requestLock = new(1, 1);
|
||||
private DateTime _lastRequestTime = DateTime.MinValue;
|
||||
private readonly int _minRequestIntervalMs = 200;
|
||||
protected int _minRequestIntervalMs = 200;
|
||||
|
||||
protected StorageMode CurrentStorageMode
|
||||
{
|
||||
get
|
||||
{
|
||||
var backendType = Configuration["Backend:Type"] ?? "Subsonic";
|
||||
var modeStr = backendType.Equals("Jellyfin", StringComparison.OrdinalIgnoreCase)
|
||||
? Configuration["Jellyfin:StorageMode"] ?? Configuration["Subsonic:StorageMode"] ?? "Permanent"
|
||||
: Configuration["Subsonic:StorageMode"] ?? "Permanent";
|
||||
return Enum.TryParse<StorageMode>(modeStr, true, out var result) ? result : StorageMode.Permanent;
|
||||
}
|
||||
}
|
||||
|
||||
protected DownloadMode CurrentDownloadMode
|
||||
{
|
||||
get
|
||||
{
|
||||
var backendType = Configuration["Backend:Type"] ?? "Subsonic";
|
||||
var modeStr = backendType.Equals("Jellyfin", StringComparison.OrdinalIgnoreCase)
|
||||
? Configuration["Jellyfin:DownloadMode"] ?? Configuration["Subsonic:DownloadMode"] ?? "Track"
|
||||
: Configuration["Subsonic:DownloadMode"] ?? "Track";
|
||||
return Enum.TryParse<DownloadMode>(modeStr, true, out var result) ? result : DownloadMode.Track;
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Lazy-loaded PlaylistSyncService to avoid circular dependency
|
||||
/// </summary>
|
||||
@@ -84,6 +111,13 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
{
|
||||
Directory.CreateDirectory(CachePath);
|
||||
}
|
||||
|
||||
var maxDownloadsStr = configuration["MAX_CONCURRENT_DOWNLOADS"];
|
||||
if (!int.TryParse(maxDownloadsStr, out var maxDownloads) || maxDownloads <= 0)
|
||||
{
|
||||
maxDownloads = 3;
|
||||
}
|
||||
_concurrencySemaphore = new SemaphoreSlim(maxDownloads, maxDownloads);
|
||||
}
|
||||
|
||||
#region IDownloadService Implementation
|
||||
@@ -95,12 +129,25 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
/// </summary>
|
||||
public async Task<string> DownloadSongAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default)
|
||||
{
|
||||
return await DownloadSongInternalAsync(externalProvider, externalId, triggerAlbumDownload: true, cancellationToken);
|
||||
return await DownloadSongInternalAsync(
|
||||
externalProvider,
|
||||
externalId,
|
||||
triggerAlbumDownload: true,
|
||||
requestedForStreaming: false,
|
||||
cancellationToken);
|
||||
}
|
||||
|
||||
|
||||
public async Task<Stream> DownloadAndStreamAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default)
|
||||
public async Task<Stream> DownloadAndStreamAsync(string externalProvider, string externalId, StreamQuality? qualityOverride = null, CancellationToken cancellationToken = default)
|
||||
{
|
||||
// If a quality override is requested (not Original), use the quality override path
|
||||
// This downloads to a temp file at the requested quality and streams it without caching
|
||||
if (qualityOverride.HasValue && qualityOverride.Value != StreamQuality.Original)
|
||||
{
|
||||
return await DownloadAndStreamWithQualityOverrideAsync(externalProvider, externalId, qualityOverride.Value, cancellationToken);
|
||||
}
|
||||
|
||||
// Standard path: use .env quality, cache the result
|
||||
var startTime = DateTime.UtcNow;
|
||||
|
||||
// Check if already downloaded locally
|
||||
@@ -111,7 +158,7 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
Logger.LogInformation("Streaming from local cache ({ElapsedMs}ms): {Path}", elapsed, localPath);
|
||||
|
||||
// Update write time for cache cleanup (extends cache lifetime)
|
||||
if (SubsonicSettings.StorageMode == StorageMode.Cache)
|
||||
if (CurrentStorageMode == StorageMode.Cache)
|
||||
{
|
||||
IOFile.SetLastWriteTime(localPath, DateTime.UtcNow);
|
||||
}
|
||||
@@ -134,7 +181,12 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
// IMPORTANT: Use CancellationToken.None for the actual download
|
||||
// This ensures downloads complete server-side even if the client cancels the request
|
||||
// The client can request the file again later once it's ready
|
||||
localPath = await DownloadSongInternalAsync(externalProvider, externalId, triggerAlbumDownload: true, CancellationToken.None);
|
||||
localPath = await DownloadSongInternalAsync(
|
||||
externalProvider,
|
||||
externalId,
|
||||
triggerAlbumDownload: true,
|
||||
requestedForStreaming: true,
|
||||
CancellationToken.None);
|
||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
||||
Logger.LogInformation("Download completed, starting stream ({ElapsedMs}ms total): {Path}", elapsed, localPath);
|
||||
|
||||
@@ -157,6 +209,65 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Downloads and streams with a quality override.
|
||||
/// When the client requests lower quality (e.g., cellular mode), this downloads to a temp file
|
||||
/// at the requested quality tier and streams it. The temp file is auto-deleted after streaming.
|
||||
/// This does NOT pollute the cache — the cached file at .env quality remains the canonical copy.
|
||||
/// </summary>
|
||||
private async Task<Stream> DownloadAndStreamWithQualityOverrideAsync(
|
||||
string externalProvider, string externalId, StreamQuality quality, CancellationToken cancellationToken)
|
||||
{
|
||||
var startTime = DateTime.UtcNow;
|
||||
|
||||
Logger.LogInformation(
|
||||
"Streaming with quality override {Quality} for {Provider}:{ExternalId}",
|
||||
quality, externalProvider, externalId);
|
||||
|
||||
try
|
||||
{
|
||||
// Get metadata for the track
|
||||
var song = await MetadataService.GetSongAsync(externalProvider, externalId);
|
||||
if (song == null)
|
||||
{
|
||||
throw new Exception("Song not found");
|
||||
}
|
||||
|
||||
// Download to a temp file at the overridden quality
|
||||
// IMPORTANT: Use CancellationToken.None to ensure download completes server-side
|
||||
var tempPath = await DownloadTrackWithQualityAsync(externalId, song, quality, CancellationToken.None);
|
||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
||||
Logger.LogInformation(
|
||||
"Quality-override download completed ({Quality}, {ElapsedMs}ms): {Path}",
|
||||
quality, elapsed, tempPath);
|
||||
// Touch the file to extend its cache lifetime for TTL-based cleanup
|
||||
IOFile.SetLastWriteTime(tempPath, DateTime.UtcNow);
|
||||
|
||||
// Start background Odesli conversion for lyrics (doesn't block streaming)
|
||||
StartBackgroundOdesliConversion(externalProvider, externalId);
|
||||
|
||||
// Return a regular stream — the file stays in the transcoded cache
|
||||
// and is cleaned up by CacheCleanupService based on CACHE_TRANSCODE_MINUTES TTL
|
||||
return IOFile.OpenRead(tempPath);
|
||||
}
|
||||
catch (OperationCanceledException)
|
||||
{
|
||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
||||
Logger.LogWarning(
|
||||
"Quality-override download cancelled after {ElapsedMs}ms for {Provider}:{ExternalId}",
|
||||
elapsed, externalProvider, externalId);
|
||||
throw;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
var elapsed = (DateTime.UtcNow - startTime).TotalMilliseconds;
|
||||
Logger.LogError(ex,
|
||||
"Quality-override download failed after {ElapsedMs}ms for {Provider}:{ExternalId}",
|
||||
elapsed, externalProvider, externalId);
|
||||
throw;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
/// <summary>
|
||||
/// Starts background Odesli conversion for lyrics support.
|
||||
@@ -194,6 +305,11 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
ActiveDownloads.TryGetValue(songId, out var info);
|
||||
return info;
|
||||
}
|
||||
|
||||
public IReadOnlyList<DownloadInfo> GetActiveDownloads()
|
||||
{
|
||||
return ActiveDownloads.Values.ToList().AsReadOnly();
|
||||
}
|
||||
|
||||
public async Task<string?> GetLocalPathIfExistsAsync(string externalProvider, string externalId)
|
||||
{
|
||||
@@ -213,6 +329,24 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
}
|
||||
|
||||
public abstract Task<bool> IsAvailableAsync();
|
||||
|
||||
protected string BuildTrackedSongId(string externalId)
|
||||
{
|
||||
return BuildTrackedSongId(ProviderName, externalId);
|
||||
}
|
||||
|
||||
protected static string BuildTrackedSongId(string externalProvider, string externalId)
|
||||
{
|
||||
return $"ext-{externalProvider}-song-{externalId}";
|
||||
}
|
||||
|
||||
protected void SetDownloadProgress(string songId, double progress)
|
||||
{
|
||||
if (ActiveDownloads.TryGetValue(songId, out var info))
|
||||
{
|
||||
info.Progress = Math.Clamp(progress, 0d, 1d);
|
||||
}
|
||||
}
|
||||
|
||||
public void DownloadRemainingAlbumTracksInBackground(string externalProvider, string albumExternalId, string excludeTrackExternalId)
|
||||
{
|
||||
@@ -249,6 +383,23 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
/// <returns>Local file path where the track was saved</returns>
|
||||
protected abstract Task<string> DownloadTrackAsync(string trackId, Song song, CancellationToken cancellationToken);
|
||||
|
||||
/// <summary>
|
||||
/// Downloads a track at a specific quality tier to a temp file.
|
||||
/// Subclasses override this to map StreamQuality to provider-specific quality settings.
|
||||
/// The .env quality is used as a ceiling — the override can only go equal or lower.
|
||||
/// Default implementation falls back to DownloadTrackAsync (uses .env quality).
|
||||
/// </summary>
|
||||
/// <param name="trackId">External track ID</param>
|
||||
/// <param name="song">Song metadata</param>
|
||||
/// <param name="quality">Requested quality tier</param>
|
||||
/// <param name="cancellationToken">Cancellation token</param>
|
||||
/// <returns>Local temp file path where the track was saved</returns>
|
||||
protected virtual Task<string> DownloadTrackWithQualityAsync(string trackId, Song song, StreamQuality quality, CancellationToken cancellationToken)
|
||||
{
|
||||
// Default: ignore quality override and use configured quality
|
||||
return DownloadTrackAsync(trackId, song, cancellationToken);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Extracts the external album ID from the internal album ID format.
|
||||
/// Example: "ext-deezer-album-123456" -> "123456"
|
||||
@@ -272,20 +423,25 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
/// <summary>
|
||||
/// Internal method for downloading a song with control over album download triggering
|
||||
/// </summary>
|
||||
protected async Task<string> DownloadSongInternalAsync(string externalProvider, string externalId, bool triggerAlbumDownload, CancellationToken cancellationToken = default)
|
||||
protected async Task<string> DownloadSongInternalAsync(
|
||||
string externalProvider,
|
||||
string externalId,
|
||||
bool triggerAlbumDownload,
|
||||
bool requestedForStreaming = false,
|
||||
CancellationToken cancellationToken = default)
|
||||
{
|
||||
if (externalProvider != ProviderName)
|
||||
{
|
||||
throw new NotSupportedException($"Provider '{externalProvider}' is not supported");
|
||||
}
|
||||
|
||||
var songId = $"ext-{externalProvider}-{externalId}";
|
||||
var isCache = SubsonicSettings.StorageMode == StorageMode.Cache;
|
||||
var songId = BuildTrackedSongId(externalProvider, externalId);
|
||||
var isCache = CurrentStorageMode == StorageMode.Cache;
|
||||
|
||||
// Acquire lock BEFORE checking existence to prevent race conditions with concurrent requests
|
||||
await DownloadLock.WaitAsync(cancellationToken);
|
||||
var lockHeld = true;
|
||||
bool isInitiator = false;
|
||||
|
||||
// 1. Synchronous state check to prevent race conditions on checking existence or ActiveDownloads
|
||||
await _stateSemaphore.WaitAsync(cancellationToken);
|
||||
try
|
||||
{
|
||||
// Check if already downloaded (works for both cache and permanent modes)
|
||||
@@ -306,40 +462,73 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
// Check if download in progress
|
||||
if (ActiveDownloads.TryGetValue(songId, out var activeDownload) && activeDownload.Status == DownloadStatus.InProgress)
|
||||
{
|
||||
Logger.LogDebug("Download already in progress for {SongId}, waiting for completion...", songId);
|
||||
// Release lock while waiting
|
||||
DownloadLock.Release();
|
||||
lockHeld = false;
|
||||
|
||||
// Wait for download to complete, checking every 100ms
|
||||
// Note: We check cancellation but don't cancel the actual download
|
||||
// The download continues server-side even if this client gives up waiting
|
||||
while (ActiveDownloads.TryGetValue(songId, out activeDownload) && activeDownload.Status == DownloadStatus.InProgress)
|
||||
if (requestedForStreaming)
|
||||
{
|
||||
// If client cancels, throw but let the download continue in background
|
||||
if (cancellationToken.IsCancellationRequested)
|
||||
{
|
||||
Logger.LogInformation("Client cancelled while waiting for download {SongId}, but download continues server-side", songId);
|
||||
throw new OperationCanceledException("Client cancelled request, but download continues server-side");
|
||||
}
|
||||
await Task.Delay(100, CancellationToken.None);
|
||||
activeDownload.RequestedForStreaming = true;
|
||||
}
|
||||
|
||||
if (activeDownload?.Status == DownloadStatus.Completed && activeDownload.LocalPath != null)
|
||||
{
|
||||
Logger.LogDebug("Download completed while waiting, returning path: {Path}", activeDownload.LocalPath);
|
||||
return activeDownload.LocalPath;
|
||||
}
|
||||
|
||||
// Download failed or was cancelled
|
||||
throw new Exception(activeDownload?.ErrorMessage ?? "Download failed while waiting");
|
||||
}
|
||||
|
||||
Logger.LogDebug("Download already in progress for {SongId}, waiting for completion...", songId);
|
||||
// We are not the initiator; we will wait outside the lock.
|
||||
}
|
||||
else
|
||||
{
|
||||
// We must initiate the download
|
||||
isInitiator = true;
|
||||
ActiveDownloads[songId] = new DownloadInfo
|
||||
{
|
||||
SongId = songId,
|
||||
ExternalId = externalId,
|
||||
ExternalProvider = externalProvider,
|
||||
Title = "Unknown Title", // Will be updated after fetching
|
||||
Artist = "Unknown Artist",
|
||||
Status = DownloadStatus.InProgress,
|
||||
Progress = 0,
|
||||
RequestedForStreaming = requestedForStreaming,
|
||||
StartedAt = DateTime.UtcNow
|
||||
};
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
_stateSemaphore.Release();
|
||||
}
|
||||
|
||||
// If another thread is already downloading this track, wait for it.
|
||||
if (!isInitiator)
|
||||
{
|
||||
DownloadInfo? activeDownload;
|
||||
while (ActiveDownloads.TryGetValue(songId, out activeDownload) && activeDownload.Status == DownloadStatus.InProgress)
|
||||
{
|
||||
// If client cancels, throw but let the download continue in background
|
||||
if (cancellationToken.IsCancellationRequested)
|
||||
{
|
||||
Logger.LogInformation("Client cancelled while waiting for download {SongId}, but download continues server-side", songId);
|
||||
throw new OperationCanceledException("Client cancelled request, but download continues server-side");
|
||||
}
|
||||
await Task.Delay(100, CancellationToken.None);
|
||||
}
|
||||
|
||||
if (activeDownload?.Status == DownloadStatus.Completed && activeDownload.LocalPath != null)
|
||||
{
|
||||
Logger.LogDebug("Download completed while waiting, returning path: {Path}", activeDownload.LocalPath);
|
||||
return activeDownload.LocalPath;
|
||||
}
|
||||
|
||||
// Download failed or was cancelled
|
||||
throw new Exception(activeDownload?.ErrorMessage ?? "Download failed while waiting");
|
||||
}
|
||||
|
||||
// --- Execute the Download (we are the initiator) ---
|
||||
|
||||
// Wait for a concurrency permit before doing the heavy lifting
|
||||
await _concurrencySemaphore.WaitAsync(cancellationToken);
|
||||
try
|
||||
{
|
||||
// Get metadata
|
||||
// In Album mode, fetch the full album first to ensure AlbumArtist is correctly set
|
||||
Song? song = null;
|
||||
|
||||
if (SubsonicSettings.DownloadMode == DownloadMode.Album)
|
||||
if (CurrentDownloadMode == DownloadMode.Album)
|
||||
{
|
||||
// First try to get the song to extract album ID
|
||||
var tempSong = await MetadataService.GetSongAsync(externalProvider, externalId);
|
||||
@@ -370,21 +559,23 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
throw new Exception("Song not found");
|
||||
}
|
||||
|
||||
var downloadInfo = new DownloadInfo
|
||||
// Update ActiveDownloads with the real title/artist information
|
||||
if (ActiveDownloads.TryGetValue(songId, out var info))
|
||||
{
|
||||
SongId = songId,
|
||||
ExternalId = externalId,
|
||||
ExternalProvider = externalProvider,
|
||||
Status = DownloadStatus.InProgress,
|
||||
StartedAt = DateTime.UtcNow
|
||||
};
|
||||
ActiveDownloads[songId] = downloadInfo;
|
||||
info.Title = song.Title ?? "Unknown Title";
|
||||
info.Artist = song.Artist ?? "Unknown Artist";
|
||||
info.DurationSeconds = song.Duration;
|
||||
}
|
||||
|
||||
var localPath = await DownloadTrackAsync(externalId, song, cancellationToken);
|
||||
|
||||
downloadInfo.Status = DownloadStatus.Completed;
|
||||
downloadInfo.LocalPath = localPath;
|
||||
downloadInfo.CompletedAt = DateTime.UtcNow;
|
||||
if (ActiveDownloads.TryGetValue(songId, out var successInfo))
|
||||
{
|
||||
successInfo.Status = DownloadStatus.Completed;
|
||||
successInfo.Progress = 1.0;
|
||||
successInfo.LocalPath = localPath;
|
||||
successInfo.CompletedAt = DateTime.UtcNow;
|
||||
}
|
||||
|
||||
song.LocalPath = localPath;
|
||||
|
||||
@@ -434,7 +625,7 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
});
|
||||
|
||||
// If download mode is Album and triggering is enabled, start background download of remaining tracks
|
||||
if (triggerAlbumDownload && SubsonicSettings.DownloadMode == DownloadMode.Album && !string.IsNullOrEmpty(song.AlbumId))
|
||||
if (triggerAlbumDownload && CurrentDownloadMode == DownloadMode.Album && !string.IsNullOrEmpty(song.AlbumId))
|
||||
{
|
||||
var albumExternalId = ExtractExternalIdFromAlbumId(song.AlbumId);
|
||||
if (!string.IsNullOrEmpty(albumExternalId))
|
||||
@@ -467,15 +658,22 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
Logger.LogDebug("Cleaned up failed download tracking for {SongId}", songId);
|
||||
});
|
||||
}
|
||||
Logger.LogError(ex, "Download failed for {SongId}", songId);
|
||||
|
||||
if (ex is HttpRequestException httpRequestException && httpRequestException.StatusCode.HasValue)
|
||||
{
|
||||
Logger.LogError("Download failed for {SongId}: {StatusCode}: {ReasonPhrase}",
|
||||
songId, (int)httpRequestException.StatusCode.Value, httpRequestException.StatusCode.Value);
|
||||
Logger.LogDebug(ex, "Detailed download failure for {SongId}", songId);
|
||||
}
|
||||
else
|
||||
{
|
||||
Logger.LogError(ex, "Download failed for {SongId}", songId);
|
||||
}
|
||||
throw;
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (lockHeld)
|
||||
{
|
||||
DownloadLock.Release();
|
||||
}
|
||||
_concurrencySemaphore.Release();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -510,7 +708,7 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
}
|
||||
|
||||
// Check if download is already in progress or recently completed
|
||||
var songId = $"ext-{ProviderName}-{track.ExternalId}";
|
||||
var songId = BuildTrackedSongId(track.ExternalId!);
|
||||
if (ActiveDownloads.TryGetValue(songId, out var activeDownload))
|
||||
{
|
||||
if (activeDownload.Status == DownloadStatus.InProgress)
|
||||
@@ -527,7 +725,12 @@ public abstract class BaseDownloadService : IDownloadService
|
||||
}
|
||||
|
||||
Logger.LogInformation("Downloading track '{Title}' from album '{Album}'", track.Title, album.Title);
|
||||
await DownloadSongInternalAsync(ProviderName, track.ExternalId!, triggerAlbumDownload: false, CancellationToken.None);
|
||||
await DownloadSongInternalAsync(
|
||||
ProviderName,
|
||||
track.ExternalId!,
|
||||
triggerAlbumDownload: false,
|
||||
requestedForStreaming: false,
|
||||
CancellationToken.None);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
|
||||
@@ -0,0 +1,107 @@
|
||||
using System.Globalization;
|
||||
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
/// <summary>
|
||||
/// Identifies high-confidence internet scanner paths that should never hit Jellyfin.
|
||||
/// </summary>
|
||||
public static class BotProbeDetector
|
||||
{
|
||||
private static readonly string[] PrefixMatches =
|
||||
{
|
||||
".env",
|
||||
".git",
|
||||
".hg",
|
||||
".svn",
|
||||
"_ignition/",
|
||||
"debug/default",
|
||||
"vendor/",
|
||||
"public/vendor/"
|
||||
};
|
||||
|
||||
private static readonly string[] FragmentMatches =
|
||||
{
|
||||
"/.env",
|
||||
"/.git/",
|
||||
"/vendor/",
|
||||
"phpunit",
|
||||
"laravel-filemanager",
|
||||
"eval-stdin.php"
|
||||
};
|
||||
|
||||
private static readonly string[] SuffixMatches =
|
||||
{
|
||||
".php"
|
||||
};
|
||||
|
||||
public static bool IsHighConfidenceProbePath(string? rawPath)
|
||||
{
|
||||
var path = NormalizePath(rawPath);
|
||||
if (string.IsNullOrEmpty(path))
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
if (path.Equals("wp", StringComparison.Ordinal) ||
|
||||
path.StartsWith("wp-", StringComparison.Ordinal) ||
|
||||
path.StartsWith("wp/", StringComparison.Ordinal) ||
|
||||
path.Equals("wordpress", StringComparison.Ordinal) ||
|
||||
path.StartsWith("wordpress/", StringComparison.Ordinal))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
if (PrefixMatches.Any(prefix => path.StartsWith(prefix, StringComparison.Ordinal)))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
if (FragmentMatches.Any(fragment => path.Contains(fragment, StringComparison.Ordinal)))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
return SuffixMatches.Any(suffix => path.EndsWith(suffix, StringComparison.Ordinal));
|
||||
}
|
||||
|
||||
public static bool IsHighConfidenceProbeUrl(string? rawUrlOrPath)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(rawUrlOrPath))
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
if (Uri.TryCreate(rawUrlOrPath, UriKind.Absolute, out var uri))
|
||||
{
|
||||
return IsHighConfidenceProbePath(uri.AbsolutePath);
|
||||
}
|
||||
|
||||
return IsHighConfidenceProbePath(rawUrlOrPath);
|
||||
}
|
||||
|
||||
private static string NormalizePath(string? rawPath)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(rawPath))
|
||||
{
|
||||
return string.Empty;
|
||||
}
|
||||
|
||||
var path = rawPath.Trim();
|
||||
|
||||
if (Uri.TryCreate(path, UriKind.Absolute, out var uri))
|
||||
{
|
||||
path = uri.AbsolutePath;
|
||||
}
|
||||
|
||||
path = Uri.UnescapeDataString(path)
|
||||
.Replace('\\', '/')
|
||||
.TrimStart('/');
|
||||
|
||||
while (path.Contains("//", StringComparison.Ordinal))
|
||||
{
|
||||
path = path.Replace("//", "/", StringComparison.Ordinal);
|
||||
}
|
||||
|
||||
return path.ToLower(CultureInfo.InvariantCulture);
|
||||
}
|
||||
}
|
||||
@@ -45,6 +45,7 @@ public class CacheCleanupService : BackgroundService
|
||||
try
|
||||
{
|
||||
await CleanupOldCachedFilesAsync(stoppingToken);
|
||||
await CleanupTranscodedCacheAsync(stoppingToken);
|
||||
await ProcessPendingDeletionsAsync(stoppingToken);
|
||||
await Task.Delay(_cleanupInterval, stoppingToken);
|
||||
}
|
||||
@@ -134,6 +135,71 @@ public class CacheCleanupService : BackgroundService
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Cleans up transcoded quality-override files based on CACHE_TRANSCODE_MINUTES TTL.
|
||||
/// This always runs regardless of StorageMode, since transcoded files are a separate concern.
|
||||
/// </summary>
|
||||
private async Task CleanupTranscodedCacheAsync(CancellationToken cancellationToken)
|
||||
{
|
||||
var downloadPath = _configuration["Library:DownloadPath"] ?? "downloads";
|
||||
var transcodedPath = Path.Combine(downloadPath, "transcoded");
|
||||
|
||||
if (!Directory.Exists(transcodedPath))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
var ttl = CacheExtensions.TranscodeCacheTTL;
|
||||
var cutoffTime = DateTime.UtcNow - ttl;
|
||||
var deletedCount = 0;
|
||||
var totalSize = 0L;
|
||||
|
||||
try
|
||||
{
|
||||
var files = Directory.GetFiles(transcodedPath, "*.*", SearchOption.AllDirectories);
|
||||
|
||||
foreach (var filePath in files)
|
||||
{
|
||||
if (cancellationToken.IsCancellationRequested)
|
||||
break;
|
||||
|
||||
try
|
||||
{
|
||||
var fileInfo = new FileInfo(filePath);
|
||||
|
||||
// Use last write time (updated on cache hit) to determine if file should be deleted
|
||||
if (fileInfo.LastWriteTimeUtc < cutoffTime)
|
||||
{
|
||||
var size = fileInfo.Length;
|
||||
File.Delete(filePath);
|
||||
deletedCount++;
|
||||
totalSize += size;
|
||||
_logger.LogDebug("Deleted transcoded cache file: {Path} (age: {Age:F1} minutes)",
|
||||
filePath, (DateTime.UtcNow - fileInfo.LastWriteTimeUtc).TotalMinutes);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to delete transcoded cache file: {Path}", filePath);
|
||||
}
|
||||
}
|
||||
|
||||
// Clean up empty directories in the transcoded folder
|
||||
await CleanupEmptyDirectoriesAsync(transcodedPath, cancellationToken);
|
||||
|
||||
if (deletedCount > 0)
|
||||
{
|
||||
var sizeMB = totalSize / (1024.0 * 1024.0);
|
||||
_logger.LogInformation("Transcoded cache cleanup: deleted {Count} files, freed {Size:F2} MB (TTL: {TTL} minutes)",
|
||||
deletedCount, sizeMB, ttl.TotalMinutes);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Error during transcoded cache cleanup");
|
||||
}
|
||||
}
|
||||
|
||||
private async Task CleanupEmptyDirectoriesAsync(string rootPath, CancellationToken cancellationToken)
|
||||
{
|
||||
try
|
||||
|
||||
@@ -49,4 +49,5 @@ public static class CacheExtensions
|
||||
public static TimeSpan MetadataTTL => GetCacheSettings().MetadataTTL;
|
||||
public static TimeSpan OdesliLookupTTL => GetCacheSettings().OdesliLookupTTL;
|
||||
public static TimeSpan ProxyImagesTTL => GetCacheSettings().ProxyImagesTTL;
|
||||
public static TimeSpan TranscodeCacheTTL => GetCacheSettings().TranscodeCacheTTL;
|
||||
}
|
||||
|
||||
@@ -22,7 +22,8 @@ public static class CacheKeyBuilder
|
||||
string? sortBy,
|
||||
string? sortOrder,
|
||||
bool? recursive,
|
||||
string? userId)
|
||||
string? userId,
|
||||
string? isFavorite = null)
|
||||
{
|
||||
var normalizedTerm = Normalize(searchTerm);
|
||||
var normalizedItemTypes = Normalize(itemTypes);
|
||||
@@ -30,9 +31,10 @@ public static class CacheKeyBuilder
|
||||
var normalizedSortBy = Normalize(sortBy);
|
||||
var normalizedSortOrder = Normalize(sortOrder);
|
||||
var normalizedUserId = Normalize(userId);
|
||||
var normalizedIsFavorite = Normalize(isFavorite);
|
||||
var normalizedRecursive = recursive.HasValue ? (recursive.Value ? "true" : "false") : string.Empty;
|
||||
|
||||
return $"search:{normalizedTerm}:{normalizedItemTypes}:{limit}:{startIndex}:{normalizedParentId}:{normalizedSortBy}:{normalizedSortOrder}:{normalizedRecursive}:{normalizedUserId}";
|
||||
return $"search:{normalizedTerm}:{normalizedItemTypes}:{limit}:{startIndex}:{normalizedParentId}:{normalizedSortBy}:{normalizedSortOrder}:{normalizedRecursive}:{normalizedUserId}:{normalizedIsFavorite}";
|
||||
}
|
||||
|
||||
private static string Normalize(string? value)
|
||||
@@ -151,13 +153,22 @@ public static class CacheKeyBuilder
|
||||
|
||||
#endregion
|
||||
|
||||
#region Playlist Keys
|
||||
#region Image Keys
|
||||
|
||||
public static string BuildPlaylistImageKey(string playlistId)
|
||||
{
|
||||
return $"playlist:image:{playlistId}";
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Builds a cache key for external album/song/artist cover art images.
|
||||
/// Images are cached as byte[] in Redis with ProxyImagesTTL (default 14 days).
|
||||
/// </summary>
|
||||
public static string BuildExternalImageKey(string provider, string type, string externalId)
|
||||
{
|
||||
return $"image:{provider}:{type}:{externalId}";
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
#region Genre Keys
|
||||
|
||||
@@ -35,13 +35,13 @@ public class EnvMigrationService
|
||||
if (string.IsNullOrWhiteSpace(line) || line.StartsWith("#"))
|
||||
continue;
|
||||
|
||||
// Migrate DOWNLOAD_PATH to Library__DownloadPath
|
||||
if (line.StartsWith("DOWNLOAD_PATH="))
|
||||
// Migrate Library__DownloadPath to DOWNLOAD_PATH (inverse migration)
|
||||
if (line.StartsWith("Library__DownloadPath="))
|
||||
{
|
||||
var value = line.Substring("DOWNLOAD_PATH=".Length);
|
||||
lines[i] = $"Library__DownloadPath={value}";
|
||||
var value = line.Substring("Library__DownloadPath=".Length);
|
||||
lines[i] = $"DOWNLOAD_PATH={value}";
|
||||
modified = true;
|
||||
_logger.LogDebug("Migrated DOWNLOAD_PATH to Library__DownloadPath in .env file");
|
||||
_logger.LogInformation("Migrated Library__DownloadPath to DOWNLOAD_PATH in .env file");
|
||||
}
|
||||
|
||||
// Migrate old SquidWTF quality values to new format
|
||||
@@ -104,10 +104,107 @@ public class EnvMigrationService
|
||||
File.WriteAllLines(_envFilePath, lines);
|
||||
_logger.LogInformation("✅ .env file migration completed successfully");
|
||||
}
|
||||
|
||||
ReformatEnvFileIfSquashed();
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to migrate .env file");
|
||||
}
|
||||
}
|
||||
|
||||
private void ReformatEnvFileIfSquashed()
|
||||
{
|
||||
try
|
||||
{
|
||||
if (!File.Exists(_envFilePath)) return;
|
||||
|
||||
var currentLines = File.ReadAllLines(_envFilePath);
|
||||
var commentCount = currentLines.Count(l => l.TrimStart().StartsWith("#"));
|
||||
|
||||
// If the file has fewer than 5 comments, it's likely a flattened/squashed file
|
||||
// from an older version or raw docker output. Let's rehydrate it.
|
||||
if (commentCount < 5)
|
||||
{
|
||||
var examplePath = Path.Combine(Directory.GetCurrentDirectory(), ".env.example");
|
||||
if (!File.Exists(examplePath))
|
||||
{
|
||||
examplePath = Path.Combine(Directory.GetParent(Directory.GetCurrentDirectory())?.FullName ?? "", ".env.example");
|
||||
}
|
||||
|
||||
if (!File.Exists(examplePath)) return;
|
||||
|
||||
_logger.LogInformation("Flattened/raw .env file detected (only {Count} comments). Rehydrating formatting from .env.example...", commentCount);
|
||||
|
||||
var currentValues = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
|
||||
foreach (var line in currentLines)
|
||||
{
|
||||
var trimmed = line.Trim();
|
||||
if (string.IsNullOrWhiteSpace(trimmed) || trimmed.StartsWith("#")) continue;
|
||||
|
||||
var eqIndex = trimmed.IndexOf('=');
|
||||
if (eqIndex > 0)
|
||||
{
|
||||
var key = trimmed[..eqIndex].Trim();
|
||||
var value = trimmed[(eqIndex + 1)..].Trim();
|
||||
currentValues[key] = value;
|
||||
}
|
||||
}
|
||||
|
||||
var exampleLines = File.ReadAllLines(examplePath).ToList();
|
||||
var usedKeys = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
for (int i = 0; i < exampleLines.Count; i++)
|
||||
{
|
||||
var line = exampleLines[i].TrimStart();
|
||||
if (string.IsNullOrWhiteSpace(line)) continue;
|
||||
|
||||
if (!line.StartsWith("#"))
|
||||
{
|
||||
var eqIndex = line.IndexOf('=');
|
||||
if (eqIndex > 0)
|
||||
{
|
||||
var key = line[..eqIndex].Trim();
|
||||
if (currentValues.TryGetValue(key, out var val))
|
||||
{
|
||||
exampleLines[i] = $"{key}={val}";
|
||||
usedKeys.Add(key);
|
||||
}
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
var eqIndex = line.IndexOf('=');
|
||||
if (eqIndex > 0)
|
||||
{
|
||||
var keyPart = line[..eqIndex].TrimStart('#').Trim();
|
||||
if (!keyPart.Contains(" ") && keyPart.Length > 0 && currentValues.TryGetValue(keyPart, out var val))
|
||||
{
|
||||
exampleLines[i] = $"{keyPart}={val}";
|
||||
usedKeys.Add(keyPart);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
var leftoverKeys = currentValues.Keys.Except(usedKeys).ToList();
|
||||
if (leftoverKeys.Any())
|
||||
{
|
||||
exampleLines.Add("");
|
||||
exampleLines.Add("# ===== CUSTOM / UNKNOWN VARIABLES =====");
|
||||
foreach (var key in leftoverKeys)
|
||||
{
|
||||
exampleLines.Add($"{key}={currentValues[key]}");
|
||||
}
|
||||
}
|
||||
|
||||
File.WriteAllLines(_envFilePath, exampleLines);
|
||||
_logger.LogInformation("✅ .env file successfully rehydrated with comments and formatting");
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to rehydrate .env file formatting");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,168 @@
|
||||
using System.Text.Json;
|
||||
using System.Globalization;
|
||||
using allstarr.Models.Domain;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Microsoft.Extensions.Configuration;
|
||||
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
/// <summary>
|
||||
/// Handles one-time migration of favorites and pending deletions from old JSON files to Redis.
|
||||
/// </summary>
|
||||
public class FavoritesMigrationService
|
||||
{
|
||||
private readonly RedisCacheService _cache;
|
||||
private readonly ILogger<FavoritesMigrationService> _logger;
|
||||
private readonly string _cacheDir;
|
||||
|
||||
public FavoritesMigrationService(
|
||||
RedisCacheService cache,
|
||||
IConfiguration configuration,
|
||||
ILogger<FavoritesMigrationService> logger)
|
||||
{
|
||||
_cache = cache;
|
||||
_logger = logger;
|
||||
_cacheDir = "/app/cache"; // This matches the path in JellyfinController
|
||||
}
|
||||
|
||||
public async Task MigrateAsync()
|
||||
{
|
||||
if (!_cache.IsEnabled) return;
|
||||
|
||||
await MigrateFavoritesAsync();
|
||||
await MigratePendingDeletionsAsync();
|
||||
}
|
||||
|
||||
private async Task MigrateFavoritesAsync()
|
||||
{
|
||||
var filePath = Path.Combine(_cacheDir, "favorites.json");
|
||||
var migrationMark = Path.Combine(_cacheDir, "favorites.json.migrated");
|
||||
|
||||
if (!File.Exists(filePath) || File.Exists(migrationMark)) return;
|
||||
|
||||
try
|
||||
{
|
||||
var options = new JsonSerializerOptions { PropertyNameCaseInsensitive = true };
|
||||
_logger.LogInformation("🚀 Starting one-time migration of favorites from {Path} to Redis...", filePath);
|
||||
|
||||
var json = await File.ReadAllTextAsync(filePath);
|
||||
var favorites = JsonSerializer.Deserialize<Dictionary<string, FavoriteTrackInfo>>(json, options);
|
||||
|
||||
if (favorites == null || favorites.Count == 0)
|
||||
{
|
||||
File.Move(filePath, migrationMark);
|
||||
return;
|
||||
}
|
||||
|
||||
int count = 0;
|
||||
foreach (var fav in favorites.Values)
|
||||
{
|
||||
await _cache.SetAsync($"favorites:{fav.ItemId}", fav);
|
||||
count++;
|
||||
}
|
||||
|
||||
File.Move(filePath, migrationMark);
|
||||
_logger.LogInformation("✅ Successfully migrated {Count} favorites to Redis cached storage.", count);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "❌ Failed to migrate favorites from JSON to Redis");
|
||||
}
|
||||
}
|
||||
|
||||
private async Task MigratePendingDeletionsAsync()
|
||||
{
|
||||
var filePath = Path.Combine(_cacheDir, "pending_deletions.json");
|
||||
var migrationMark = Path.Combine(_cacheDir, "pending_deletions.json.migrated");
|
||||
|
||||
if (!File.Exists(filePath) || File.Exists(migrationMark)) return;
|
||||
|
||||
try
|
||||
{
|
||||
_logger.LogInformation("🚀 Starting one-time migration of pending deletions from {Path} to Redis...", filePath);
|
||||
|
||||
var json = await File.ReadAllTextAsync(filePath);
|
||||
var deletions = ParsePendingDeletions(json, DateTime.UtcNow);
|
||||
|
||||
if (deletions == null || deletions.Count == 0)
|
||||
{
|
||||
File.Move(filePath, migrationMark);
|
||||
return;
|
||||
}
|
||||
|
||||
int count = 0;
|
||||
foreach (var (itemId, deleteAt) in deletions)
|
||||
{
|
||||
await _cache.SetStringAsync($"pending_deletion:{itemId}", deleteAt.ToUniversalTime().ToString("O"));
|
||||
count++;
|
||||
}
|
||||
|
||||
File.Move(filePath, migrationMark);
|
||||
_logger.LogInformation("✅ Successfully migrated {Count} pending deletions to Redis cached storage.", count);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "❌ Failed to migrate pending deletions from JSON to Redis");
|
||||
}
|
||||
}
|
||||
|
||||
private static Dictionary<string, DateTime> ParsePendingDeletions(string json, DateTime fallbackDeleteAtUtc)
|
||||
{
|
||||
var legacySchedule = TryDeserialize<Dictionary<string, DateTime>>(json);
|
||||
if (legacySchedule != null)
|
||||
{
|
||||
return legacySchedule.ToDictionary(
|
||||
kvp => kvp.Key,
|
||||
kvp => kvp.Value.Kind == DateTimeKind.Utc ? kvp.Value : kvp.Value.ToUniversalTime());
|
||||
}
|
||||
|
||||
var legacyScheduleStrings = TryDeserialize<Dictionary<string, string>>(json);
|
||||
if (legacyScheduleStrings != null)
|
||||
{
|
||||
var parsed = new Dictionary<string, DateTime>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
foreach (var (itemId, deleteAtRaw) in legacyScheduleStrings)
|
||||
{
|
||||
if (DateTime.TryParse(
|
||||
deleteAtRaw,
|
||||
CultureInfo.InvariantCulture,
|
||||
DateTimeStyles.RoundtripKind | DateTimeStyles.AssumeUniversal,
|
||||
out var deleteAt))
|
||||
{
|
||||
parsed[itemId] = deleteAt.Kind == DateTimeKind.Utc ? deleteAt : deleteAt.ToUniversalTime();
|
||||
}
|
||||
}
|
||||
|
||||
return parsed;
|
||||
}
|
||||
|
||||
var deletionSet = TryDeserialize<HashSet<string>>(json) ?? TryDeserialize<List<string>>(json)?.ToHashSet();
|
||||
if (deletionSet != null)
|
||||
{
|
||||
return deletionSet.ToDictionary(itemId => itemId, _ => fallbackDeleteAtUtc, StringComparer.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
throw new JsonException("Unsupported pending_deletions.json format");
|
||||
}
|
||||
|
||||
private static T? TryDeserialize<T>(string json)
|
||||
{
|
||||
try
|
||||
{
|
||||
return JsonSerializer.Deserialize<T>(json);
|
||||
}
|
||||
catch (JsonException)
|
||||
{
|
||||
return default;
|
||||
}
|
||||
}
|
||||
|
||||
private class FavoriteTrackInfo
|
||||
{
|
||||
public string ItemId { get; set; } = "";
|
||||
public string Title { get; set; } = "";
|
||||
public string Artist { get; set; } = "";
|
||||
public string Album { get; set; } = "";
|
||||
public DateTime FavoritedAt { get; set; }
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,39 @@
|
||||
using System.Security.Cryptography;
|
||||
using Microsoft.AspNetCore.Http;
|
||||
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
public static class ImageConditionalRequestHelper
|
||||
{
|
||||
public static string ComputeStrongETag(byte[] payload)
|
||||
{
|
||||
var hash = SHA256.HashData(payload);
|
||||
return $"\"{Convert.ToHexString(hash)}\"";
|
||||
}
|
||||
|
||||
public static bool MatchesIfNoneMatch(IHeaderDictionary headers, string etag)
|
||||
{
|
||||
if (!headers.TryGetValue("If-None-Match", out var headerValues))
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
foreach (var headerValue in headerValues)
|
||||
{
|
||||
if (string.IsNullOrEmpty(headerValue))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
foreach (var candidate in headerValue.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries))
|
||||
{
|
||||
if (candidate == "*" || string.Equals(candidate, etag, StringComparison.Ordinal))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,79 @@
|
||||
using System.Text.Json;
|
||||
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
/// <summary>
|
||||
/// Detects invalid injected playlist items so local Jellyfin tracks stay raw.
|
||||
/// </summary>
|
||||
public static class InjectedPlaylistItemHelper
|
||||
{
|
||||
private const string SyntheticServerId = "allstarr";
|
||||
|
||||
public static bool ContainsSyntheticLocalItems(IEnumerable<Dictionary<string, object?>> items)
|
||||
{
|
||||
return items.Any(LooksLikeSyntheticLocalItem);
|
||||
}
|
||||
|
||||
public static bool ContainsLocalItemsMissingGenreMetadata(IEnumerable<Dictionary<string, object?>> items)
|
||||
{
|
||||
return items.Any(LooksLikeLocalItemMissingGenreMetadata);
|
||||
}
|
||||
|
||||
public static bool LooksLikeSyntheticLocalItem(IReadOnlyDictionary<string, object?> item)
|
||||
{
|
||||
var id = GetString(item, "Id");
|
||||
if (string.IsNullOrWhiteSpace(id) || IsExternalItemId(id))
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
var serverId = GetString(item, "ServerId");
|
||||
return string.Equals(serverId, SyntheticServerId, StringComparison.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
public static bool LooksLikeLocalItemMissingGenreMetadata(IReadOnlyDictionary<string, object?> item)
|
||||
{
|
||||
var id = GetString(item, "Id");
|
||||
if (string.IsNullOrWhiteSpace(id) || IsExternalItemId(id) || LooksLikeSyntheticLocalItem(item))
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
return !HasNonNullValue(item, "Genres") || !HasNonNullValue(item, "GenreItems");
|
||||
}
|
||||
|
||||
private static bool IsExternalItemId(string itemId)
|
||||
{
|
||||
return itemId.StartsWith("ext-", StringComparison.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
private static bool HasNonNullValue(IReadOnlyDictionary<string, object?> item, string key)
|
||||
{
|
||||
if (!item.TryGetValue(key, out var value) || value == null)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
return value switch
|
||||
{
|
||||
JsonElement { ValueKind: JsonValueKind.Null or JsonValueKind.Undefined } => false,
|
||||
_ => true
|
||||
};
|
||||
}
|
||||
|
||||
private static string? GetString(IReadOnlyDictionary<string, object?> item, string key)
|
||||
{
|
||||
if (!item.TryGetValue(key, out var value) || value == null)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
return value switch
|
||||
{
|
||||
string s => s,
|
||||
JsonElement { ValueKind: JsonValueKind.String } element => element.GetString(),
|
||||
JsonElement { ValueKind: JsonValueKind.Number } element => element.ToString(),
|
||||
_ => value.ToString()
|
||||
};
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,61 @@
|
||||
using System.Text.Json;
|
||||
using allstarr.Models.Domain;
|
||||
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
/// <summary>
|
||||
/// Stores and restores raw Jellyfin item snapshots on local songs for cache safety.
|
||||
/// </summary>
|
||||
public static class JellyfinItemSnapshotHelper
|
||||
{
|
||||
private const string RawItemKey = "RawItem";
|
||||
|
||||
public static void StoreRawItemSnapshot(Song song, JsonElement item)
|
||||
{
|
||||
var rawItem = DeserializeDictionary(item.GetRawText());
|
||||
if (rawItem == null)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
song.JellyfinMetadata ??= new Dictionary<string, object?>();
|
||||
song.JellyfinMetadata[RawItemKey] = rawItem;
|
||||
}
|
||||
|
||||
public static bool HasRawItemSnapshot(Song? song)
|
||||
{
|
||||
return song?.JellyfinMetadata?.ContainsKey(RawItemKey) == true;
|
||||
}
|
||||
|
||||
public static bool TryGetClonedRawItemSnapshot(Song? song, out Dictionary<string, object?> rawItem)
|
||||
{
|
||||
rawItem = new Dictionary<string, object?>();
|
||||
|
||||
if (song?.JellyfinMetadata == null ||
|
||||
!song.JellyfinMetadata.TryGetValue(RawItemKey, out var snapshot) ||
|
||||
snapshot == null)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
var normalized = snapshot switch
|
||||
{
|
||||
Dictionary<string, object?> dict => DeserializeDictionary(JsonSerializer.Serialize(dict)),
|
||||
JsonElement { ValueKind: JsonValueKind.Object } json => DeserializeDictionary(json.GetRawText()),
|
||||
_ => DeserializeDictionary(JsonSerializer.Serialize(snapshot))
|
||||
};
|
||||
|
||||
if (normalized == null)
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
||||
rawItem = normalized;
|
||||
return true;
|
||||
}
|
||||
|
||||
private static Dictionary<string, object?>? DeserializeDictionary(string json)
|
||||
{
|
||||
return JsonSerializer.Deserialize<Dictionary<string, object?>>(json);
|
||||
}
|
||||
}
|
||||
@@ -248,6 +248,25 @@ public class RedisCacheService
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Gets all keys matching a pattern.
|
||||
/// </summary>
|
||||
public IEnumerable<string> GetKeysByPattern(string pattern)
|
||||
{
|
||||
if (!IsEnabled) return Array.Empty<string>();
|
||||
|
||||
try
|
||||
{
|
||||
var server = _redis!.GetServer(_redis.GetEndPoints().First());
|
||||
return server.Keys(pattern: pattern).Select(k => (string)k!);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Redis GET KEYS BY PATTERN failed for pattern: {Pattern}", pattern);
|
||||
return Array.Empty<string>();
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Deletes all keys matching a pattern (e.g., "search:*").
|
||||
/// WARNING: Use with caution as this scans all keys.
|
||||
|
||||
@@ -235,8 +235,7 @@ public class RoundRobinFallbackHelper
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "{Service} request failed with endpoint {Endpoint}, trying next...",
|
||||
_serviceName, baseUrl);
|
||||
LogEndpointFailure(baseUrl, ex, willRetry: attempt < orderedEndpoints.Count - 1);
|
||||
|
||||
// Mark as unhealthy in cache
|
||||
lock (_healthCacheLock)
|
||||
@@ -351,8 +350,7 @@ public class RoundRobinFallbackHelper
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "{Service} request failed with endpoint {Endpoint}, trying next...",
|
||||
_serviceName, baseUrl);
|
||||
LogEndpointFailure(baseUrl, ex, willRetry: attempt < orderedEndpoints.Count - 1);
|
||||
|
||||
// Mark as unhealthy in cache
|
||||
lock (_healthCacheLock)
|
||||
@@ -371,10 +369,110 @@ public class RoundRobinFallbackHelper
|
||||
return defaultValue;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Tries endpoints until one both succeeds and returns an acceptable result.
|
||||
/// Unacceptable results continue to the next endpoint without poisoning health state.
|
||||
/// </summary>
|
||||
public async Task<T> TryWithFallbackAsync<T>(
|
||||
Func<string, Task<T>> action,
|
||||
Func<T, bool> isAcceptableResult,
|
||||
T defaultValue)
|
||||
{
|
||||
if (isAcceptableResult == null)
|
||||
{
|
||||
throw new ArgumentNullException(nameof(isAcceptableResult));
|
||||
}
|
||||
|
||||
// Get healthy endpoints first (with caching to avoid excessive checks)
|
||||
var healthyEndpoints = await GetHealthyEndpointsAsync();
|
||||
|
||||
// Try healthy endpoints first, then fall back to all if needed
|
||||
var endpointsToTry = healthyEndpoints.Count < _apiUrls.Count
|
||||
? healthyEndpoints.Concat(_apiUrls.Except(healthyEndpoints)).ToList()
|
||||
: healthyEndpoints;
|
||||
|
||||
var orderedEndpoints = BuildTryOrder(endpointsToTry);
|
||||
|
||||
for (int attempt = 0; attempt < orderedEndpoints.Count; attempt++)
|
||||
{
|
||||
var baseUrl = orderedEndpoints[attempt];
|
||||
|
||||
try
|
||||
{
|
||||
_logger.LogDebug("Trying {Service} endpoint {Endpoint} (attempt {Attempt}/{Total})",
|
||||
_serviceName, baseUrl, attempt + 1, orderedEndpoints.Count);
|
||||
|
||||
var result = await action(baseUrl);
|
||||
if (isAcceptableResult(result))
|
||||
{
|
||||
return result;
|
||||
}
|
||||
|
||||
_logger.LogDebug("{Service} endpoint {Endpoint} returned an unacceptable result, trying next...",
|
||||
_serviceName, baseUrl);
|
||||
|
||||
if (attempt == orderedEndpoints.Count - 1)
|
||||
{
|
||||
_logger.LogWarning("All {Count} {Service} endpoints returned unacceptable results, returning default value",
|
||||
orderedEndpoints.Count, _serviceName);
|
||||
return defaultValue;
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
LogEndpointFailure(baseUrl, ex, willRetry: attempt < orderedEndpoints.Count - 1);
|
||||
|
||||
lock (_healthCacheLock)
|
||||
{
|
||||
_healthCache[baseUrl] = (false, DateTime.UtcNow);
|
||||
}
|
||||
|
||||
if (attempt == orderedEndpoints.Count - 1)
|
||||
{
|
||||
_logger.LogError("All {Count} {Service} endpoints failed, returning default value",
|
||||
orderedEndpoints.Count, _serviceName);
|
||||
return defaultValue;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return defaultValue;
|
||||
}
|
||||
|
||||
private void LogEndpointFailure(string baseUrl, Exception ex, bool willRetry)
|
||||
{
|
||||
var message = BuildFailureSummary(ex);
|
||||
|
||||
if (willRetry)
|
||||
{
|
||||
_logger.LogWarning("{Service} request failed at {Endpoint}: {Error}. Trying next...",
|
||||
_serviceName, baseUrl, message);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogError("{Service} request failed at {Endpoint}: {Error}",
|
||||
_serviceName, baseUrl, message);
|
||||
}
|
||||
|
||||
_logger.LogDebug(ex, "{Service} detailed failure for endpoint {Endpoint}",
|
||||
_serviceName, baseUrl);
|
||||
}
|
||||
|
||||
private static string BuildFailureSummary(Exception ex)
|
||||
{
|
||||
if (ex is HttpRequestException httpRequestException && httpRequestException.StatusCode.HasValue)
|
||||
{
|
||||
var statusCode = (int)httpRequestException.StatusCode.Value;
|
||||
return $"{statusCode}: {httpRequestException.StatusCode.Value}";
|
||||
}
|
||||
|
||||
return ex.Message;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Processes multiple items in parallel across all available endpoints.
|
||||
/// Each endpoint processes items sequentially. Failed endpoints are blacklisted.
|
||||
/// </summary>
|
||||
/// </summary>
|
||||
public async Task<List<TResult>> ProcessInParallelAsync<TItem, TResult>(
|
||||
List<TItem> items,
|
||||
Func<string, TItem, CancellationToken, Task<TResult>> action,
|
||||
|
||||
@@ -0,0 +1,235 @@
|
||||
using Microsoft.Extensions.Configuration;
|
||||
using Microsoft.Extensions.Hosting;
|
||||
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
/// <summary>
|
||||
/// Loads supported flat .env keys into ASP.NET configuration so Docker/admin UI
|
||||
/// updates stored in /app/.env take effect on the next application startup.
|
||||
/// </summary>
|
||||
public static class RuntimeEnvConfiguration
|
||||
{
|
||||
private static readonly IReadOnlyDictionary<string, string[]> ExactKeyMappings =
|
||||
new Dictionary<string, string[]>(StringComparer.OrdinalIgnoreCase)
|
||||
{
|
||||
["BACKEND_TYPE"] = ["Backend:Type"],
|
||||
["ADMIN_BIND_ANY_IP"] = ["Admin:BindAnyIp"],
|
||||
["ADMIN_TRUSTED_SUBNETS"] = ["Admin:TrustedSubnets"],
|
||||
["ADMIN_ENABLE_ENV_EXPORT"] = ["Admin:EnableEnvExport"],
|
||||
|
||||
["CORS_ALLOWED_ORIGINS"] = ["Cors:AllowedOrigins"],
|
||||
["CORS_ALLOWED_METHODS"] = ["Cors:AllowedMethods"],
|
||||
["CORS_ALLOWED_HEADERS"] = ["Cors:AllowedHeaders"],
|
||||
["CORS_ALLOW_CREDENTIALS"] = ["Cors:AllowCredentials"],
|
||||
|
||||
["SUBSONIC_URL"] = ["Subsonic:Url"],
|
||||
["JELLYFIN_URL"] = ["Jellyfin:Url"],
|
||||
["JELLYFIN_API_KEY"] = ["Jellyfin:ApiKey"],
|
||||
["JELLYFIN_USER_ID"] = ["Jellyfin:UserId"],
|
||||
["JELLYFIN_CLIENT_USERNAME"] = ["Jellyfin:ClientUsername"],
|
||||
["JELLYFIN_LIBRARY_ID"] = ["Jellyfin:LibraryId"],
|
||||
|
||||
["LIBRARY_DOWNLOAD_PATH"] = ["Library:DownloadPath"],
|
||||
["LIBRARY_KEPT_PATH"] = ["Library:KeptPath"],
|
||||
|
||||
["REDIS_ENABLED"] = ["Redis:Enabled"],
|
||||
["REDIS_CONNECTION_STRING"] = ["Redis:ConnectionString"],
|
||||
|
||||
["SPOTIFY_IMPORT_ENABLED"] = ["SpotifyImport:Enabled"],
|
||||
["SPOTIFY_IMPORT_SYNC_START_HOUR"] = ["SpotifyImport:SyncStartHour"],
|
||||
["SPOTIFY_IMPORT_SYNC_START_MINUTE"] = ["SpotifyImport:SyncStartMinute"],
|
||||
["SPOTIFY_IMPORT_SYNC_WINDOW_HOURS"] = ["SpotifyImport:SyncWindowHours"],
|
||||
["SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS"] = ["SpotifyImport:MatchingIntervalHours"],
|
||||
["SPOTIFY_IMPORT_PLAYLISTS"] = ["SpotifyImport:Playlists"],
|
||||
["SPOTIFY_IMPORT_PLAYLIST_IDS"] = ["SpotifyImport:PlaylistIds"],
|
||||
["SPOTIFY_IMPORT_PLAYLIST_NAMES"] = ["SpotifyImport:PlaylistNames"],
|
||||
["SPOTIFY_IMPORT_PLAYLIST_LOCAL_TRACKS_POSITIONS"] = ["SpotifyImport:PlaylistLocalTracksPositions"],
|
||||
|
||||
["SPOTIFY_API_ENABLED"] = ["SpotifyApi:Enabled"],
|
||||
["SPOTIFY_API_SESSION_COOKIE"] = ["SpotifyApi:SessionCookie"],
|
||||
["SPOTIFY_API_SESSION_COOKIE_SET_DATE"] = ["SpotifyApi:SessionCookieSetDate"],
|
||||
["SPOTIFY_API_CACHE_DURATION_MINUTES"] = ["SpotifyApi:CacheDurationMinutes"],
|
||||
["SPOTIFY_API_RATE_LIMIT_DELAY_MS"] = ["SpotifyApi:RateLimitDelayMs"],
|
||||
["SPOTIFY_API_PREFER_ISRC_MATCHING"] = ["SpotifyApi:PreferIsrcMatching"],
|
||||
["SPOTIFY_LYRICS_API_URL"] = ["SpotifyApi:LyricsApiUrl"],
|
||||
|
||||
["SCROBBLING_ENABLED"] = ["Scrobbling:Enabled"],
|
||||
["SCROBBLING_LOCAL_TRACKS_ENABLED"] = ["Scrobbling:LocalTracksEnabled"],
|
||||
["SCROBBLING_SYNTHETIC_LOCAL_PLAYED_SIGNAL_ENABLED"] = ["Scrobbling:SyntheticLocalPlayedSignalEnabled"],
|
||||
["SCROBBLING_LASTFM_ENABLED"] = ["Scrobbling:LastFm:Enabled"],
|
||||
["SCROBBLING_LASTFM_API_KEY"] = ["Scrobbling:LastFm:ApiKey"],
|
||||
["SCROBBLING_LASTFM_SHARED_SECRET"] = ["Scrobbling:LastFm:SharedSecret"],
|
||||
["SCROBBLING_LASTFM_SESSION_KEY"] = ["Scrobbling:LastFm:SessionKey"],
|
||||
["SCROBBLING_LASTFM_USERNAME"] = ["Scrobbling:LastFm:Username"],
|
||||
["SCROBBLING_LASTFM_PASSWORD"] = ["Scrobbling:LastFm:Password"],
|
||||
["SCROBBLING_LISTENBRAINZ_ENABLED"] = ["Scrobbling:ListenBrainz:Enabled"],
|
||||
["SCROBBLING_LISTENBRAINZ_USER_TOKEN"] = ["Scrobbling:ListenBrainz:UserToken"],
|
||||
|
||||
["DEBUG_LOG_ALL_REQUESTS"] = ["Debug:LogAllRequests"],
|
||||
["DEBUG_REDACT_SENSITIVE_REQUEST_VALUES"] = ["Debug:RedactSensitiveRequestValues"],
|
||||
|
||||
["DEEZER_ARL"] = ["Deezer:Arl"],
|
||||
["DEEZER_ARL_FALLBACK"] = ["Deezer:ArlFallback"],
|
||||
["DEEZER_QUALITY"] = ["Deezer:Quality"],
|
||||
["DEEZER_MIN_REQUEST_INTERVAL_MS"] = ["Deezer:MinRequestIntervalMs"],
|
||||
|
||||
["QOBUZ_USER_AUTH_TOKEN"] = ["Qobuz:UserAuthToken"],
|
||||
["QOBUZ_USER_ID"] = ["Qobuz:UserId"],
|
||||
["QOBUZ_QUALITY"] = ["Qobuz:Quality"],
|
||||
["QOBUZ_MIN_REQUEST_INTERVAL_MS"] = ["Qobuz:MinRequestIntervalMs"],
|
||||
|
||||
["SQUIDWTF_QUALITY"] = ["SquidWTF:Quality"],
|
||||
["SQUIDWTF_MIN_REQUEST_INTERVAL_MS"] = ["SquidWTF:MinRequestIntervalMs"],
|
||||
|
||||
["MUSICBRAINZ_ENABLED"] = ["MusicBrainz:Enabled"],
|
||||
["MUSICBRAINZ_USERNAME"] = ["MusicBrainz:Username"],
|
||||
["MUSICBRAINZ_PASSWORD"] = ["MusicBrainz:Password"],
|
||||
|
||||
["CACHE_SEARCH_RESULTS_MINUTES"] = ["Cache:SearchResultsMinutes"],
|
||||
["CACHE_PLAYLIST_IMAGES_HOURS"] = ["Cache:PlaylistImagesHours"],
|
||||
["CACHE_SPOTIFY_PLAYLIST_ITEMS_HOURS"] = ["Cache:SpotifyPlaylistItemsHours"],
|
||||
["CACHE_SPOTIFY_MATCHED_TRACKS_DAYS"] = ["Cache:SpotifyMatchedTracksDays"],
|
||||
["CACHE_LYRICS_DAYS"] = ["Cache:LyricsDays"],
|
||||
["CACHE_GENRE_DAYS"] = ["Cache:GenreDays"],
|
||||
["CACHE_METADATA_DAYS"] = ["Cache:MetadataDays"],
|
||||
["CACHE_ODESLI_LOOKUP_DAYS"] = ["Cache:OdesliLookupDays"],
|
||||
["CACHE_PROXY_IMAGES_DAYS"] = ["Cache:ProxyImagesDays"],
|
||||
["CACHE_TRANSCODE_MINUTES"] = ["Cache:TranscodeCacheMinutes"]
|
||||
};
|
||||
|
||||
private static readonly IReadOnlyDictionary<string, string[]> SharedBackendKeyMappings =
|
||||
new Dictionary<string, string[]>(StringComparer.OrdinalIgnoreCase)
|
||||
{
|
||||
["MUSIC_SERVICE"] = ["Subsonic:MusicService", "Jellyfin:MusicService"],
|
||||
["EXPLICIT_FILTER"] = ["Subsonic:ExplicitFilter", "Jellyfin:ExplicitFilter"],
|
||||
["DOWNLOAD_MODE"] = ["Subsonic:DownloadMode", "Jellyfin:DownloadMode"],
|
||||
["STORAGE_MODE"] = ["Subsonic:StorageMode", "Jellyfin:StorageMode"],
|
||||
["CACHE_DURATION_HOURS"] = ["Subsonic:CacheDurationHours", "Jellyfin:CacheDurationHours"],
|
||||
["ENABLE_EXTERNAL_PLAYLISTS"] = ["Subsonic:EnableExternalPlaylists", "Jellyfin:EnableExternalPlaylists"],
|
||||
["PLAYLISTS_DIRECTORY"] = ["Subsonic:PlaylistsDirectory", "Jellyfin:PlaylistsDirectory"]
|
||||
};
|
||||
|
||||
private static readonly HashSet<string> IgnoredComposeOnlyKeys = new(StringComparer.OrdinalIgnoreCase)
|
||||
{
|
||||
"DOWNLOAD_PATH",
|
||||
"KEPT_PATH",
|
||||
"CACHE_PATH",
|
||||
"REDIS_DATA_PATH"
|
||||
};
|
||||
|
||||
public static string ResolveEnvFilePath(IHostEnvironment environment)
|
||||
{
|
||||
return environment.IsDevelopment()
|
||||
? Path.GetFullPath(Path.Combine(environment.ContentRootPath, "..", ".env"))
|
||||
: "/app/.env";
|
||||
}
|
||||
|
||||
public static void AddDotEnvOverrides(
|
||||
ConfigurationManager configuration,
|
||||
IHostEnvironment environment,
|
||||
TextWriter? logWriter = null)
|
||||
{
|
||||
AddDotEnvOverrides(configuration, ResolveEnvFilePath(environment), logWriter);
|
||||
}
|
||||
|
||||
public static void AddDotEnvOverrides(
|
||||
ConfigurationManager configuration,
|
||||
string envFilePath,
|
||||
TextWriter? logWriter = null)
|
||||
{
|
||||
var overrides = LoadDotEnvOverrides(envFilePath);
|
||||
if (overrides.Count == 0)
|
||||
{
|
||||
if (File.Exists(envFilePath))
|
||||
{
|
||||
logWriter?.WriteLine($"No supported runtime overrides found in {envFilePath}");
|
||||
}
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
configuration.AddInMemoryCollection(overrides);
|
||||
logWriter?.WriteLine($"Loaded {overrides.Count} runtime override(s) from {envFilePath}");
|
||||
}
|
||||
|
||||
public static Dictionary<string, string?> LoadDotEnvOverrides(string envFilePath)
|
||||
{
|
||||
var overrides = new Dictionary<string, string?>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
if (!File.Exists(envFilePath))
|
||||
{
|
||||
return overrides;
|
||||
}
|
||||
|
||||
foreach (var line in File.ReadLines(envFilePath))
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(line) || line.TrimStart().StartsWith('#'))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var separatorIndex = line.IndexOf('=');
|
||||
if (separatorIndex <= 0)
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var envKey = line[..separatorIndex].Trim();
|
||||
var envValue = StripQuotes(line[(separatorIndex + 1)..].Trim());
|
||||
|
||||
foreach (var mapping in MapEnvVarToConfiguration(envKey, envValue))
|
||||
{
|
||||
overrides[mapping.Key] = mapping.Value;
|
||||
}
|
||||
}
|
||||
|
||||
return overrides;
|
||||
}
|
||||
|
||||
public static IEnumerable<KeyValuePair<string, string?>> MapEnvVarToConfiguration(string envKey, string? envValue)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(envKey) || IgnoredComposeOnlyKeys.Contains(envKey))
|
||||
{
|
||||
yield break;
|
||||
}
|
||||
|
||||
if (envKey.Contains("__", StringComparison.Ordinal))
|
||||
{
|
||||
yield return new KeyValuePair<string, string?>(envKey.Replace("__", ":"), envValue);
|
||||
yield break;
|
||||
}
|
||||
|
||||
if (SharedBackendKeyMappings.TryGetValue(envKey, out var sharedKeys))
|
||||
{
|
||||
foreach (var sharedKey in sharedKeys)
|
||||
{
|
||||
yield return new KeyValuePair<string, string?>(sharedKey, envValue);
|
||||
}
|
||||
|
||||
yield break;
|
||||
}
|
||||
|
||||
if (ExactKeyMappings.TryGetValue(envKey, out var configKeys))
|
||||
{
|
||||
foreach (var configKey in configKeys)
|
||||
{
|
||||
yield return new KeyValuePair<string, string?>(configKey, envValue);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private static string StripQuotes(string? value)
|
||||
{
|
||||
if (string.IsNullOrEmpty(value))
|
||||
{
|
||||
return value ?? string.Empty;
|
||||
}
|
||||
|
||||
if (value.StartsWith('"') && value.EndsWith('"') && value.Length >= 2)
|
||||
{
|
||||
return value[1..^1];
|
||||
}
|
||||
|
||||
return value;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,100 @@
|
||||
using System.Text.Json;
|
||||
using allstarr.Models.Spotify;
|
||||
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
/// <summary>
|
||||
/// Computes displayed counts for injected Spotify playlists.
|
||||
/// </summary>
|
||||
public static class SpotifyPlaylistCountHelper
|
||||
{
|
||||
public static int CountExternalMatchedTracks(IEnumerable<MatchedTrack>? matchedTracks)
|
||||
{
|
||||
if (matchedTracks == null)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
return matchedTracks.Count(t => t.MatchedSong != null && !t.MatchedSong.IsLocal);
|
||||
}
|
||||
|
||||
public static int ComputeServedItemCount(
|
||||
int? exactCachedPlaylistItemsCount,
|
||||
int localTracksCount,
|
||||
IEnumerable<MatchedTrack>? matchedTracks)
|
||||
{
|
||||
if (exactCachedPlaylistItemsCount.HasValue && exactCachedPlaylistItemsCount.Value > 0)
|
||||
{
|
||||
return exactCachedPlaylistItemsCount.Value;
|
||||
}
|
||||
|
||||
return Math.Max(0, localTracksCount) + CountExternalMatchedTracks(matchedTracks);
|
||||
}
|
||||
|
||||
public static long SumExternalMatchedRunTimeTicks(IEnumerable<MatchedTrack>? matchedTracks)
|
||||
{
|
||||
if (matchedTracks == null)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
return matchedTracks
|
||||
.Where(t => t.MatchedSong != null && !t.MatchedSong.IsLocal)
|
||||
.Sum(t => Math.Max(0, (long)(t.MatchedSong.Duration ?? 0) * TimeSpan.TicksPerSecond));
|
||||
}
|
||||
|
||||
public static long SumCachedPlaylistRunTimeTicks(IEnumerable<Dictionary<string, object?>>? cachedPlaylistItems)
|
||||
{
|
||||
if (cachedPlaylistItems == null)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
long total = 0;
|
||||
foreach (var item in cachedPlaylistItems)
|
||||
{
|
||||
item.TryGetValue("RunTimeTicks", out var runTimeTicks);
|
||||
total += ExtractRunTimeTicks(runTimeTicks);
|
||||
}
|
||||
|
||||
return total;
|
||||
}
|
||||
|
||||
public static long ComputeServedRunTimeTicks(
|
||||
long? exactCachedPlaylistRunTimeTicks,
|
||||
long localPlaylistRunTimeTicks,
|
||||
IEnumerable<MatchedTrack>? matchedTracks)
|
||||
{
|
||||
if (exactCachedPlaylistRunTimeTicks.HasValue)
|
||||
{
|
||||
return Math.Max(0, exactCachedPlaylistRunTimeTicks.Value);
|
||||
}
|
||||
|
||||
return Math.Max(0, localPlaylistRunTimeTicks) + SumExternalMatchedRunTimeTicks(matchedTracks);
|
||||
}
|
||||
|
||||
public static long ExtractRunTimeTicks(object? rawValue)
|
||||
{
|
||||
return rawValue switch
|
||||
{
|
||||
null => 0,
|
||||
long longValue => Math.Max(0, longValue),
|
||||
int intValue => Math.Max(0, intValue),
|
||||
double doubleValue => Math.Max(0, (long)doubleValue),
|
||||
decimal decimalValue => Math.Max(0, (long)decimalValue),
|
||||
string stringValue when long.TryParse(stringValue, out var parsed) => Math.Max(0, parsed),
|
||||
JsonElement jsonElement => ExtractJsonRunTimeTicks(jsonElement),
|
||||
_ => 0
|
||||
};
|
||||
}
|
||||
|
||||
private static long ExtractJsonRunTimeTicks(JsonElement jsonElement)
|
||||
{
|
||||
return jsonElement.ValueKind switch
|
||||
{
|
||||
JsonValueKind.Number when jsonElement.TryGetInt64(out var longValue) => Math.Max(0, longValue),
|
||||
JsonValueKind.String when long.TryParse(jsonElement.GetString(), out var parsed) => Math.Max(0, parsed),
|
||||
_ => 0
|
||||
};
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,110 @@
|
||||
namespace allstarr.Services.Common;
|
||||
|
||||
/// <summary>
|
||||
/// Represents the quality tier requested by a client for streaming.
|
||||
/// Used to map client transcoding parameters to provider-specific quality levels.
|
||||
/// The .env quality setting acts as a ceiling — client requests can only go equal or lower.
|
||||
/// </summary>
|
||||
public enum StreamQuality
|
||||
{
|
||||
/// <summary>
|
||||
/// Use the quality configured in .env / appsettings (default behavior).
|
||||
/// This is the "Lossless" / "no transcoding" selection in a client.
|
||||
/// </summary>
|
||||
Original,
|
||||
|
||||
/// <summary>
|
||||
/// High quality lossy (e.g., 320kbps AAC/MP3).
|
||||
/// Covers client selections: 320K, 256K, 192K.
|
||||
/// Maps to: SquidWTF HIGH, Deezer MP3_320, Qobuz MP3_320.
|
||||
/// </summary>
|
||||
High,
|
||||
|
||||
/// <summary>
|
||||
/// Low quality lossy (e.g., 96-128kbps AAC/MP3).
|
||||
/// Covers client selections: 128K, 64K.
|
||||
/// Maps to: SquidWTF LOW, Deezer MP3_128, Qobuz MP3_320 (lowest available).
|
||||
/// </summary>
|
||||
Low
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Parses Jellyfin client transcoding query parameters to determine
|
||||
/// the requested stream quality tier for external tracks.
|
||||
///
|
||||
/// Typical client quality options: Lossless, 320K, 256K, 192K, 128K, 64K
|
||||
/// These are mapped to StreamQuality tiers which providers then translate
|
||||
/// to their own quality levels, capped at the .env ceiling.
|
||||
/// </summary>
|
||||
public static class StreamQualityHelper
|
||||
{
|
||||
/// <summary>
|
||||
/// Parses the request query string to determine what quality the client wants.
|
||||
/// Jellyfin clients send parameters like AudioBitRate, MaxStreamingBitrate,
|
||||
/// AudioCodec, TranscodingContainer when requesting transcoded streams.
|
||||
/// </summary>
|
||||
public static StreamQuality ParseFromQueryString(IQueryCollection query)
|
||||
{
|
||||
// Check for explicit audio bitrate (e.g., AudioBitRate=128000)
|
||||
if (query.TryGetValue("AudioBitRate", out var audioBitRateVal) &&
|
||||
int.TryParse(audioBitRateVal.FirstOrDefault(), out var audioBitRate))
|
||||
{
|
||||
return MapBitRateToQuality(audioBitRate);
|
||||
}
|
||||
|
||||
// Check for MaxStreamingBitrate (e.g., MaxStreamingBitrate=140000000 for lossless)
|
||||
if (query.TryGetValue("MaxStreamingBitrate", out var maxBitrateVal) &&
|
||||
long.TryParse(maxBitrateVal.FirstOrDefault(), out var maxBitrate))
|
||||
{
|
||||
// Very high values (>= 10Mbps) indicate lossless / no transcoding
|
||||
if (maxBitrate >= 10_000_000)
|
||||
{
|
||||
return StreamQuality.Original;
|
||||
}
|
||||
|
||||
return MapBitRateToQuality((int)(maxBitrate / 1000));
|
||||
}
|
||||
|
||||
// Check for audioBitRate (lowercase variant used by some clients)
|
||||
if (query.TryGetValue("audioBitRate", out var audioBitRateLower) &&
|
||||
int.TryParse(audioBitRateLower.FirstOrDefault(), out var audioBitRateLowerVal))
|
||||
{
|
||||
return MapBitRateToQuality(audioBitRateLowerVal);
|
||||
}
|
||||
|
||||
// Check TranscodingContainer — if client requests mp3/aac, they want lossy
|
||||
if (query.TryGetValue("TranscodingContainer", out var container))
|
||||
{
|
||||
var containerStr = container.FirstOrDefault()?.ToLowerInvariant();
|
||||
if (containerStr is "mp3" or "aac" or "m4a")
|
||||
{
|
||||
// Container specified but no bitrate — default to High (320kbps)
|
||||
return StreamQuality.High;
|
||||
}
|
||||
}
|
||||
|
||||
// No transcoding parameters — use original quality from .env
|
||||
return StreamQuality.Original;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Maps a bitrate value (in bps) to a StreamQuality tier.
|
||||
/// Client options are typically: Lossless, 320K, 256K, 192K, 128K, 64K
|
||||
///
|
||||
/// >= 192kbps → High (covers 320K, 256K, 192K selections)
|
||||
/// < 192kbps → Low (covers 128K, 64K selections)
|
||||
/// </summary>
|
||||
private static StreamQuality MapBitRateToQuality(int bitRate)
|
||||
{
|
||||
// >= 192kbps → High (320kbps tier)
|
||||
// Covers client selections: 320K, 256K, 192K
|
||||
if (bitRate >= 192_000)
|
||||
{
|
||||
return StreamQuality.High;
|
||||
}
|
||||
|
||||
// < 192kbps → Low (96-128kbps tier)
|
||||
// Covers client selections: 128K, 64K
|
||||
return StreamQuality.Low;
|
||||
}
|
||||
}
|
||||
@@ -14,6 +14,8 @@ public class VersionUpgradeRebuildService : IHostedService
|
||||
private readonly SpotifyTrackMatchingService _matchingService;
|
||||
private readonly SpotifyImportSettings _spotifyImportSettings;
|
||||
private readonly ILogger<VersionUpgradeRebuildService> _logger;
|
||||
private CancellationTokenSource? _backgroundRebuildCts;
|
||||
private Task? _backgroundRebuildTask;
|
||||
|
||||
public VersionUpgradeRebuildService(
|
||||
SpotifyTrackMatchingService matchingService,
|
||||
@@ -53,15 +55,12 @@ public class VersionUpgradeRebuildService : IHostedService
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogInformation("Triggering full rebuild for all playlists after version upgrade");
|
||||
try
|
||||
{
|
||||
await _matchingService.TriggerRebuildAllAsync();
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to trigger auto rebuild after version upgrade");
|
||||
}
|
||||
_logger.LogInformation(
|
||||
"Scheduling full rebuild for all playlists in background after version upgrade");
|
||||
|
||||
_backgroundRebuildCts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
|
||||
_backgroundRebuildTask = RunBackgroundRebuildAsync(currentVersion, _backgroundRebuildCts.Token);
|
||||
return;
|
||||
}
|
||||
}
|
||||
else
|
||||
@@ -76,7 +75,51 @@ public class VersionUpgradeRebuildService : IHostedService
|
||||
|
||||
public Task StopAsync(CancellationToken cancellationToken)
|
||||
{
|
||||
return Task.CompletedTask;
|
||||
return StopBackgroundRebuildAsync(cancellationToken);
|
||||
}
|
||||
|
||||
private async Task RunBackgroundRebuildAsync(string currentVersion, CancellationToken cancellationToken)
|
||||
{
|
||||
try
|
||||
{
|
||||
_logger.LogInformation("Starting background full rebuild for all playlists after version upgrade");
|
||||
await _matchingService.TriggerRebuildAllAsync(cancellationToken);
|
||||
_logger.LogInformation("Background full rebuild after version upgrade completed");
|
||||
await WriteCurrentVersionAsync(currentVersion, cancellationToken);
|
||||
}
|
||||
catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested)
|
||||
{
|
||||
_logger.LogWarning("Background full rebuild after version upgrade was cancelled before completion");
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to trigger auto rebuild after version upgrade");
|
||||
await WriteCurrentVersionAsync(currentVersion, CancellationToken.None);
|
||||
}
|
||||
}
|
||||
|
||||
private async Task StopBackgroundRebuildAsync(CancellationToken cancellationToken)
|
||||
{
|
||||
if (_backgroundRebuildTask == null)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
try
|
||||
{
|
||||
_backgroundRebuildCts?.Cancel();
|
||||
await _backgroundRebuildTask.WaitAsync(cancellationToken);
|
||||
}
|
||||
catch (OperationCanceledException)
|
||||
{
|
||||
// Host shutdown is in progress or the background task observed cancellation.
|
||||
}
|
||||
finally
|
||||
{
|
||||
_backgroundRebuildCts?.Dispose();
|
||||
_backgroundRebuildCts = null;
|
||||
_backgroundRebuildTask = null;
|
||||
}
|
||||
}
|
||||
|
||||
private async Task<string?> ReadPreviousVersionAsync(CancellationToken cancellationToken)
|
||||
|
||||
@@ -57,6 +57,7 @@ public class DeezerDownloadService : BaseDownloadService
|
||||
_arl = deezer.Arl;
|
||||
_arlFallback = deezer.ArlFallback;
|
||||
_preferredQuality = deezer.Quality;
|
||||
_minRequestIntervalMs = deezer.MinRequestIntervalMs;
|
||||
}
|
||||
|
||||
#region BaseDownloadService Implementation
|
||||
@@ -98,10 +99,9 @@ public class DeezerDownloadService : BaseDownloadService
|
||||
|
||||
// Build organized folder structure: Artist/Album/Track using AlbumArtist (fallback to Artist for singles)
|
||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||
// Cache mode uses downloads/cache/ folder, Permanent mode uses downloads/permanent/
|
||||
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache
|
||||
? Path.Combine("downloads", "cache")
|
||||
: Path.Combine("downloads", "permanent");
|
||||
var basePath = CurrentStorageMode == StorageMode.Cache
|
||||
? Path.Combine(DownloadPath, "cache")
|
||||
: Path.Combine(DownloadPath, "permanent");
|
||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension, "deezer", trackId);
|
||||
|
||||
// Create directories if they don't exist
|
||||
@@ -118,11 +118,11 @@ public class DeezerDownloadService : BaseDownloadService
|
||||
request.Headers.Add("User-Agent", "Mozilla/5.0");
|
||||
request.Headers.Add("Accept", "*/*");
|
||||
|
||||
return await _httpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
var res = await _httpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
res.EnsureSuccessStatusCode();
|
||||
return res;
|
||||
}, Logger);
|
||||
|
||||
response.EnsureSuccessStatusCode();
|
||||
|
||||
// Download and decrypt
|
||||
await using var responseStream = await response.Content.ReadAsStreamAsync(cancellationToken);
|
||||
await using var outputFile = IOFile.Create(outputPath);
|
||||
@@ -140,6 +140,140 @@ public class DeezerDownloadService : BaseDownloadService
|
||||
|
||||
#endregion
|
||||
|
||||
#region Quality Override Support
|
||||
|
||||
/// <summary>
|
||||
/// Downloads a track at a specific quality tier, capped at the .env quality ceiling.
|
||||
/// Deezer quality hierarchy: FLAC > MP3_320 > MP3_128
|
||||
///
|
||||
/// Examples:
|
||||
/// env=FLAC: Original→FLAC, High→MP3_320, Low→MP3_128
|
||||
/// env=MP3_320: Original→MP3_320, High→MP3_320, Low→MP3_128
|
||||
/// env=MP3_128: Original→MP3_128, High→MP3_128, Low→MP3_128
|
||||
/// </summary>
|
||||
protected override async Task<string> DownloadTrackWithQualityAsync(
|
||||
string trackId, Song song, StreamQuality quality, CancellationToken cancellationToken)
|
||||
{
|
||||
if (quality == StreamQuality.Original)
|
||||
{
|
||||
return await DownloadTrackAsync(trackId, song, cancellationToken);
|
||||
}
|
||||
|
||||
// Map StreamQuality to Deezer quality, capped at .env ceiling
|
||||
var envQuality = NormalizeDeezerQuality(_preferredQuality);
|
||||
var deezerQuality = MapStreamQualityToDeezer(quality, envQuality);
|
||||
|
||||
Logger.LogInformation(
|
||||
"Quality override: StreamQuality.{Quality} → Deezer quality '{DeezerQuality}' (env ceiling: {EnvQuality}) for track {TrackId}",
|
||||
quality, deezerQuality, envQuality, trackId);
|
||||
|
||||
// Use the existing download logic with the overridden quality
|
||||
var downloadInfo = await GetTrackDownloadInfoAsync(trackId, cancellationToken, deezerQuality);
|
||||
|
||||
Logger.LogInformation(
|
||||
"Quality override download info resolved (Format: {Format})",
|
||||
downloadInfo.Format);
|
||||
|
||||
// Determine extension based on format
|
||||
var extension = downloadInfo.Format?.ToUpper() switch
|
||||
{
|
||||
"FLAC" => ".flac",
|
||||
_ => ".mp3"
|
||||
};
|
||||
|
||||
// Write to transcoded cache directory: {downloads}/transcoded/Artist/Album/song.ext
|
||||
// These files are cleaned up by CacheCleanupService based on CACHE_TRANSCODE_MINUTES TTL
|
||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||
var basePath = Path.Combine("downloads", "transcoded");
|
||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension, "deezer", trackId);
|
||||
|
||||
// Create directories if they don't exist
|
||||
var albumFolder = Path.GetDirectoryName(outputPath)!;
|
||||
EnsureDirectoryExists(albumFolder);
|
||||
|
||||
// If the file already exists in transcoded cache, return it directly
|
||||
if (IOFile.Exists(outputPath))
|
||||
{
|
||||
// Touch the file to extend its cache lifetime
|
||||
IOFile.SetLastWriteTime(outputPath, DateTime.UtcNow);
|
||||
Logger.LogInformation("Quality override cache hit: {Path}", outputPath);
|
||||
return outputPath;
|
||||
}
|
||||
|
||||
// Download the encrypted file
|
||||
var response = await RetryHelper.RetryWithBackoffAsync(async () =>
|
||||
{
|
||||
using var request = new HttpRequestMessage(HttpMethod.Get, downloadInfo.DownloadUrl);
|
||||
request.Headers.Add("User-Agent", "Mozilla/5.0");
|
||||
request.Headers.Add("Accept", "*/*");
|
||||
|
||||
var res = await _httpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
res.EnsureSuccessStatusCode();
|
||||
return res;
|
||||
}, Logger);
|
||||
|
||||
// Download and decrypt (Deezer uses Blowfish CBC encryption)
|
||||
await using var responseStream = await response.Content.ReadAsStreamAsync(cancellationToken);
|
||||
await using var outputFile = IOFile.Create(outputPath);
|
||||
await DecryptAndWriteStreamAsync(responseStream, outputFile, trackId, cancellationToken);
|
||||
|
||||
// Close file before writing metadata
|
||||
await outputFile.DisposeAsync();
|
||||
|
||||
// Write metadata and cover art
|
||||
await WriteMetadataAsync(outputPath, song, cancellationToken);
|
||||
|
||||
return outputPath;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Normalizes the .env quality string to a standard Deezer quality level.
|
||||
/// </summary>
|
||||
private static string NormalizeDeezerQuality(string? quality)
|
||||
{
|
||||
if (string.IsNullOrEmpty(quality)) return "FLAC";
|
||||
|
||||
return quality.ToUpperInvariant() switch
|
||||
{
|
||||
"FLAC" => "FLAC",
|
||||
"MP3_320" or "320" => "MP3_320",
|
||||
"MP3_128" or "128" => "MP3_128",
|
||||
_ => "FLAC"
|
||||
};
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Maps a StreamQuality tier to a Deezer quality string, capped at the .env ceiling.
|
||||
/// </summary>
|
||||
private static string MapStreamQualityToDeezer(StreamQuality streamQuality, string envQuality)
|
||||
{
|
||||
// Quality ranking from highest to lowest
|
||||
var ranking = new[] { "FLAC", "MP3_320", "MP3_128" };
|
||||
var envIndex = Array.IndexOf(ranking, envQuality);
|
||||
if (envIndex < 0) envIndex = 0; // Default to FLAC if unknown
|
||||
|
||||
var idealQuality = streamQuality switch
|
||||
{
|
||||
StreamQuality.Original => envQuality,
|
||||
StreamQuality.High => "MP3_320",
|
||||
StreamQuality.Low => "MP3_128",
|
||||
_ => envQuality
|
||||
};
|
||||
|
||||
// Cap at env ceiling (lower index = higher quality)
|
||||
var idealIndex = Array.IndexOf(ranking, idealQuality);
|
||||
if (idealIndex < 0) idealIndex = envIndex;
|
||||
|
||||
if (idealIndex < envIndex)
|
||||
{
|
||||
return envQuality;
|
||||
}
|
||||
|
||||
return idealQuality;
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
#region Deezer API Methods
|
||||
|
||||
private async Task InitializeAsync(string? arlOverride = null)
|
||||
@@ -185,7 +319,7 @@ public class DeezerDownloadService : BaseDownloadService
|
||||
}, Logger);
|
||||
}
|
||||
|
||||
private async Task<DownloadResult> GetTrackDownloadInfoAsync(string trackId, CancellationToken cancellationToken)
|
||||
private async Task<DownloadResult> GetTrackDownloadInfoAsync(string trackId, CancellationToken cancellationToken, string? qualityOverride = null)
|
||||
{
|
||||
var tryDownload = async (string arl) =>
|
||||
{
|
||||
@@ -213,8 +347,8 @@ public class DeezerDownloadService : BaseDownloadService
|
||||
: "";
|
||||
|
||||
// Get download URL via media API
|
||||
// Build format list based on preferred quality
|
||||
var formatsList = BuildFormatsList(_preferredQuality);
|
||||
// Build format list based on preferred quality (or overridden quality for transcoding)
|
||||
var formatsList = BuildFormatsList(qualityOverride ?? _preferredQuality);
|
||||
|
||||
var mediaRequest = new
|
||||
{
|
||||
|
||||
@@ -62,6 +62,19 @@ public class DeezerMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
}
|
||||
|
||||
public async Task<Song?> FindSongByIsrcAsync(string isrc, CancellationToken cancellationToken = default)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(isrc))
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
var results = await SearchSongsAsync(isrc, limit: 5, cancellationToken);
|
||||
return results.FirstOrDefault(song =>
|
||||
!string.IsNullOrWhiteSpace(song.Isrc) &&
|
||||
song.Isrc.Equals(isrc, StringComparison.OrdinalIgnoreCase));
|
||||
}
|
||||
|
||||
public async Task<List<Album>> SearchAlbumsAsync(string query, int limit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
try
|
||||
@@ -122,10 +135,15 @@ public class DeezerMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
public async Task<SearchResult> SearchAllAsync(string query, int songLimit = 20, int albumLimit = 20, int artistLimit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
// Execute searches in parallel
|
||||
var songsTask = SearchSongsAsync(query, songLimit, cancellationToken);
|
||||
var albumsTask = SearchAlbumsAsync(query, albumLimit, cancellationToken);
|
||||
var artistsTask = SearchArtistsAsync(query, artistLimit, cancellationToken);
|
||||
var songsTask = songLimit > 0
|
||||
? SearchSongsAsync(query, songLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Song>());
|
||||
var albumsTask = albumLimit > 0
|
||||
? SearchAlbumsAsync(query, albumLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Album>());
|
||||
var artistsTask = artistLimit > 0
|
||||
? SearchArtistsAsync(query, artistLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Artist>());
|
||||
|
||||
await Task.WhenAll(songsTask, albumsTask, artistsTask);
|
||||
|
||||
|
||||
@@ -21,13 +21,17 @@ public interface IDownloadService
|
||||
Task<string> DownloadSongAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default);
|
||||
|
||||
/// <summary>
|
||||
/// Downloads a song and streams the result progressively
|
||||
/// Downloads a song and streams the result progressively.
|
||||
/// When qualityOverride is specified (not null and not Original), downloads at the requested
|
||||
/// quality tier instead of the configured .env quality. Used for client-requested "transcoding".
|
||||
/// The .env quality acts as a ceiling — client requests can only go equal or lower.
|
||||
/// </summary>
|
||||
/// <param name="externalProvider">The provider (deezer, spotify)</param>
|
||||
/// <param name="externalId">The ID on the external provider</param>
|
||||
/// <param name="qualityOverride">Optional quality tier override for streaming (null = use .env quality)</param>
|
||||
/// <param name="cancellationToken">Cancellation token</param>
|
||||
/// <returns>A stream of the audio file</returns>
|
||||
Task<Stream> DownloadAndStreamAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default);
|
||||
Task<Stream> DownloadAndStreamAsync(string externalProvider, string externalId, Common.StreamQuality? qualityOverride = null, CancellationToken cancellationToken = default);
|
||||
|
||||
/// <summary>
|
||||
/// Downloads remaining tracks from an album in background (excluding the specified track)
|
||||
@@ -42,6 +46,11 @@ public interface IDownloadService
|
||||
/// </summary>
|
||||
DownloadInfo? GetDownloadStatus(string songId);
|
||||
|
||||
/// <summary>
|
||||
/// Gets a snapshot of all active/recent downloads for the activity feed
|
||||
/// </summary>
|
||||
IReadOnlyList<DownloadInfo> GetActiveDownloads();
|
||||
|
||||
/// <summary>
|
||||
/// Gets the local path for a song if it has been downloaded already
|
||||
/// </summary>
|
||||
|
||||
@@ -40,6 +40,11 @@ public interface IMusicMetadataService
|
||||
/// Gets details of an external song
|
||||
/// </summary>
|
||||
Task<Song?> GetSongAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default);
|
||||
|
||||
/// <summary>
|
||||
/// Attempts to find a song by ISRC using the provider's most exact lookup path.
|
||||
/// </summary>
|
||||
Task<Song?> FindSongByIsrcAsync(string isrc, CancellationToken cancellationToken = default);
|
||||
|
||||
/// <summary>
|
||||
/// Gets details of an external album with its songs
|
||||
|
||||
@@ -2,6 +2,7 @@ using System.Text.Json;
|
||||
using allstarr.Models.Domain;
|
||||
using allstarr.Models.Search;
|
||||
using allstarr.Models.Subsonic;
|
||||
using allstarr.Services.Common;
|
||||
|
||||
namespace allstarr.Services.Jellyfin;
|
||||
|
||||
@@ -186,10 +187,13 @@ public class JellyfinModelMapper
|
||||
|
||||
// Cover art URL construction
|
||||
song.CoverArtUrl = $"/Items/{id}/Images/Primary";
|
||||
|
||||
// Preserve Jellyfin metadata (MediaSources, etc.) for local tracks
|
||||
// This ensures bitrate and other technical details are maintained
|
||||
song.JellyfinMetadata = new Dictionary<string, object?>();
|
||||
|
||||
// Preserve the full raw item so cached local matches can be replayed without losing fields.
|
||||
JellyfinItemSnapshotHelper.StoreRawItemSnapshot(song, item);
|
||||
|
||||
// Preserve Jellyfin metadata (MediaSources, etc.) for local tracks.
|
||||
// This ensures bitrate and other technical details are maintained.
|
||||
song.JellyfinMetadata ??= new Dictionary<string, object?>();
|
||||
if (item.TryGetProperty("MediaSources", out var mediaSources))
|
||||
{
|
||||
song.JellyfinMetadata["MediaSources"] = JsonSerializer.Deserialize<object>(mediaSources.GetRawText());
|
||||
|
||||
@@ -2,6 +2,7 @@ using Microsoft.AspNetCore.Mvc;
|
||||
using Microsoft.Extensions.Options;
|
||||
using allstarr.Models.Settings;
|
||||
using allstarr.Services.Common;
|
||||
using System.Net;
|
||||
using System.Net.Http.Headers;
|
||||
using System.Text.Json;
|
||||
|
||||
@@ -9,9 +10,17 @@ namespace allstarr.Services.Jellyfin;
|
||||
|
||||
/// <summary>
|
||||
/// Handles proxying requests to the Jellyfin server and authentication.
|
||||
/// Uses a named HttpClient ("JellyfinBackend") with SocketsHttpHandler for
|
||||
/// TCP connection pooling across scoped instances.
|
||||
/// </summary>
|
||||
public class JellyfinProxyService
|
||||
{
|
||||
/// <summary>
|
||||
/// The IHttpClientFactory registration name for the Jellyfin backend client.
|
||||
/// Configured with SocketsHttpHandler for connection pooling in Program.cs.
|
||||
/// </summary>
|
||||
public const string HttpClientName = "JellyfinBackend";
|
||||
|
||||
private readonly HttpClient _httpClient;
|
||||
private readonly JellyfinSettings _settings;
|
||||
private readonly IHttpContextAccessor _httpContextAccessor;
|
||||
@@ -30,7 +39,7 @@ public class JellyfinProxyService
|
||||
ILogger<JellyfinProxyService> logger,
|
||||
RedisCacheService cache)
|
||||
{
|
||||
_httpClient = httpClientFactory.CreateClient();
|
||||
_httpClient = httpClientFactory.CreateClient(HttpClientName);
|
||||
_settings = settings.Value;
|
||||
_httpContextAccessor = httpContextAccessor;
|
||||
_logger = logger;
|
||||
@@ -114,27 +123,37 @@ public class JellyfinProxyService
|
||||
var baseEndpoint = parts[0];
|
||||
var existingQuery = parts[1];
|
||||
|
||||
// Parse existing query string
|
||||
var mergedParams = new Dictionary<string, string>();
|
||||
foreach (var param in existingQuery.Split('&'))
|
||||
// Fast path: preserve the caller's raw query string exactly as provided.
|
||||
// This is required for endpoints that legitimately repeat keys like Fields=...
|
||||
if (queryParams == null || queryParams.Count == 0)
|
||||
{
|
||||
return await GetJsonAsyncInternal(BuildUrl(endpoint), clientHeaders);
|
||||
}
|
||||
|
||||
var preservedParams = new List<string>();
|
||||
|
||||
foreach (var param in existingQuery.Split('&', StringSplitOptions.RemoveEmptyEntries))
|
||||
{
|
||||
var kv = param.Split('=', 2);
|
||||
if (kv.Length == 2)
|
||||
var key = kv.Length > 0 ? Uri.UnescapeDataString(kv[0]) : string.Empty;
|
||||
|
||||
// Explicit query params override every existing value for the same key.
|
||||
if (!string.IsNullOrEmpty(key) && queryParams.ContainsKey(key))
|
||||
{
|
||||
mergedParams[Uri.UnescapeDataString(kv[0])] = Uri.UnescapeDataString(kv[1]);
|
||||
continue;
|
||||
}
|
||||
|
||||
preservedParams.Add(param);
|
||||
}
|
||||
|
||||
// Merge with provided queryParams (provided params take precedence)
|
||||
if (queryParams != null)
|
||||
{
|
||||
foreach (var kv in queryParams)
|
||||
{
|
||||
mergedParams[kv.Key] = kv.Value;
|
||||
}
|
||||
}
|
||||
var explicitParams = queryParams.Select(kv =>
|
||||
$"{Uri.EscapeDataString(kv.Key)}={Uri.EscapeDataString(kv.Value)}");
|
||||
|
||||
var mergedQuery = string.Join("&", preservedParams.Concat(explicitParams));
|
||||
var url = string.IsNullOrEmpty(mergedQuery)
|
||||
? BuildUrl(baseEndpoint)
|
||||
: $"{BuildUrl(baseEndpoint)}?{mergedQuery}";
|
||||
|
||||
var url = BuildUrl(baseEndpoint, mergedParams);
|
||||
return await GetJsonAsyncInternal(url, clientHeaders);
|
||||
}
|
||||
|
||||
@@ -142,9 +161,78 @@ public class JellyfinProxyService
|
||||
return await GetJsonAsyncInternal(finalUrl, clientHeaders);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Sends a proxied GET request to Jellyfin and returns the raw upstream response without buffering the body.
|
||||
/// Intended for transparent passthrough of large JSON payloads that Allstarr does not modify.
|
||||
/// </summary>
|
||||
public async Task<HttpResponseMessage> GetPassthroughResponseAsync(
|
||||
string endpoint,
|
||||
IHeaderDictionary? clientHeaders = null,
|
||||
CancellationToken cancellationToken = default)
|
||||
{
|
||||
var url = BuildUrl(endpoint);
|
||||
using var request = CreateClientGetRequest(url, clientHeaders, out var isBrowserStaticRequest, out var isPublicEndpoint);
|
||||
ForwardPassthroughRequestHeaders(clientHeaders, request);
|
||||
|
||||
var response = await _httpClient.SendAsync(
|
||||
request,
|
||||
HttpCompletionOption.ResponseHeadersRead,
|
||||
cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode && !isBrowserStaticRequest && !isPublicEndpoint)
|
||||
{
|
||||
LogUpstreamFailure(HttpMethod.Get, response.StatusCode, url);
|
||||
}
|
||||
|
||||
return response;
|
||||
}
|
||||
|
||||
private async Task<(JsonDocument? Body, int StatusCode)> GetJsonAsyncInternal(string url, IHeaderDictionary? clientHeaders)
|
||||
{
|
||||
using var request = new HttpRequestMessage(HttpMethod.Get, url);
|
||||
using var request = CreateClientGetRequest(url, clientHeaders, out var isBrowserStaticRequest, out var isPublicEndpoint);
|
||||
|
||||
var response = await _httpClient.SendAsync(request);
|
||||
|
||||
var statusCode = (int)response.StatusCode;
|
||||
|
||||
// Always parse the response, even for errors
|
||||
// The caller needs to see 401s so the client can re-authenticate
|
||||
var content = await response.Content.ReadAsStringAsync();
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
if (!isBrowserStaticRequest && !isPublicEndpoint)
|
||||
{
|
||||
LogUpstreamFailure(HttpMethod.Get, response.StatusCode, url);
|
||||
}
|
||||
|
||||
// Try to parse error response to pass through to client
|
||||
if (!string.IsNullOrWhiteSpace(content))
|
||||
{
|
||||
try
|
||||
{
|
||||
var errorDoc = JsonDocument.Parse(content);
|
||||
return (errorDoc, statusCode);
|
||||
}
|
||||
catch
|
||||
{
|
||||
// Not valid JSON, return null
|
||||
}
|
||||
}
|
||||
|
||||
return (null, statusCode);
|
||||
}
|
||||
|
||||
return (JsonDocument.Parse(content), statusCode);
|
||||
}
|
||||
|
||||
private HttpRequestMessage CreateClientGetRequest(
|
||||
string url,
|
||||
IHeaderDictionary? clientHeaders,
|
||||
out bool isBrowserStaticRequest,
|
||||
out bool isPublicEndpoint)
|
||||
{
|
||||
var request = new HttpRequestMessage(HttpMethod.Get, url);
|
||||
|
||||
// Forward client IP address to Jellyfin so it can identify the real client
|
||||
if (_httpContextAccessor.HttpContext != null)
|
||||
@@ -157,21 +245,21 @@ public class JellyfinProxyService
|
||||
}
|
||||
}
|
||||
|
||||
bool authHeaderAdded = false;
|
||||
|
||||
// Check if this is a browser request for static assets (favicon, etc.)
|
||||
bool isBrowserStaticRequest = url.Contains("/favicon.ico", StringComparison.OrdinalIgnoreCase) ||
|
||||
url.Contains("/web/", StringComparison.OrdinalIgnoreCase) ||
|
||||
(clientHeaders?.Any(h => h.Key.Equals("User-Agent", StringComparison.OrdinalIgnoreCase) &&
|
||||
h.Value.ToString().Contains("Mozilla", StringComparison.OrdinalIgnoreCase)) == true &&
|
||||
clientHeaders?.Any(h => h.Key.Equals("sec-fetch-dest", StringComparison.OrdinalIgnoreCase) &&
|
||||
(h.Value.ToString().Contains("image", StringComparison.OrdinalIgnoreCase) ||
|
||||
h.Value.ToString().Contains("document", StringComparison.OrdinalIgnoreCase))) == true);
|
||||
isBrowserStaticRequest = url.Contains("/favicon.ico", StringComparison.OrdinalIgnoreCase) ||
|
||||
url.Contains("/web/", StringComparison.OrdinalIgnoreCase) ||
|
||||
(clientHeaders?.Any(h => h.Key.Equals("User-Agent", StringComparison.OrdinalIgnoreCase) &&
|
||||
h.Value.ToString().Contains("Mozilla", StringComparison.OrdinalIgnoreCase)) == true &&
|
||||
clientHeaders?.Any(h => h.Key.Equals("sec-fetch-dest", StringComparison.OrdinalIgnoreCase) &&
|
||||
(h.Value.ToString().Contains("image", StringComparison.OrdinalIgnoreCase) ||
|
||||
h.Value.ToString().Contains("document", StringComparison.OrdinalIgnoreCase))) == true);
|
||||
|
||||
// Check if this is a public endpoint that doesn't require authentication
|
||||
bool isPublicEndpoint = url.Contains("/System/Info/Public", StringComparison.OrdinalIgnoreCase) ||
|
||||
url.Contains("/Branding/", StringComparison.OrdinalIgnoreCase) ||
|
||||
url.Contains("/Startup/", StringComparison.OrdinalIgnoreCase);
|
||||
isPublicEndpoint = url.Contains("/System/Info/Public", StringComparison.OrdinalIgnoreCase) ||
|
||||
url.Contains("/Branding/", StringComparison.OrdinalIgnoreCase) ||
|
||||
url.Contains("/Startup/", StringComparison.OrdinalIgnoreCase);
|
||||
|
||||
var authHeaderAdded = false;
|
||||
|
||||
// Forward authentication headers from client if provided
|
||||
if (clientHeaders != null && clientHeaders.Count > 0)
|
||||
@@ -198,45 +286,35 @@ public class JellyfinProxyService
|
||||
}
|
||||
|
||||
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
|
||||
return request;
|
||||
}
|
||||
|
||||
var response = await _httpClient.SendAsync(request);
|
||||
|
||||
var statusCode = (int)response.StatusCode;
|
||||
|
||||
// Always parse the response, even for errors
|
||||
// The caller needs to see 401s so the client can re-authenticate
|
||||
var content = await response.Content.ReadAsStringAsync();
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
private static void ForwardPassthroughRequestHeaders(
|
||||
IHeaderDictionary? clientHeaders,
|
||||
HttpRequestMessage request)
|
||||
{
|
||||
if (clientHeaders == null || clientHeaders.Count == 0)
|
||||
{
|
||||
if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized)
|
||||
{
|
||||
// 401 means token expired or invalid - client needs to re-authenticate
|
||||
_logger.LogDebug("Jellyfin returned 401 Unauthorized for {Url} - client should re-authenticate", url);
|
||||
}
|
||||
else if (!isBrowserStaticRequest && !isPublicEndpoint)
|
||||
{
|
||||
_logger.LogError("Jellyfin request failed: {StatusCode} for {Url}", response.StatusCode, url);
|
||||
}
|
||||
|
||||
// Try to parse error response to pass through to client
|
||||
if (!string.IsNullOrWhiteSpace(content))
|
||||
{
|
||||
try
|
||||
{
|
||||
var errorDoc = JsonDocument.Parse(content);
|
||||
return (errorDoc, statusCode);
|
||||
}
|
||||
catch
|
||||
{
|
||||
// Not valid JSON, return null
|
||||
}
|
||||
}
|
||||
|
||||
return (null, statusCode);
|
||||
return;
|
||||
}
|
||||
|
||||
return (JsonDocument.Parse(content), statusCode);
|
||||
if (clientHeaders.TryGetValue("Accept-Encoding", out var acceptEncoding) &&
|
||||
acceptEncoding.Count > 0)
|
||||
{
|
||||
request.Headers.TryAddWithoutValidation("Accept-Encoding", acceptEncoding.ToArray());
|
||||
}
|
||||
|
||||
if (clientHeaders.TryGetValue("User-Agent", out var userAgent) &&
|
||||
userAgent.Count > 0)
|
||||
{
|
||||
request.Headers.TryAddWithoutValidation("User-Agent", userAgent.ToArray());
|
||||
}
|
||||
|
||||
if (clientHeaders.TryGetValue("Accept-Language", out var acceptLanguage) &&
|
||||
acceptLanguage.Count > 0)
|
||||
{
|
||||
request.Headers.TryAddWithoutValidation("Accept-Language", acceptLanguage.ToArray());
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -245,10 +323,31 @@ public class JellyfinProxyService
|
||||
/// Returns the response body and HTTP status code.
|
||||
/// </summary>
|
||||
public async Task<(JsonDocument? Body, int StatusCode)> PostJsonAsync(string endpoint, string body, IHeaderDictionary clientHeaders)
|
||||
{
|
||||
var bodyToSend = body;
|
||||
if (string.IsNullOrWhiteSpace(bodyToSend))
|
||||
{
|
||||
bodyToSend = "{}";
|
||||
_logger.LogWarning("POST body was empty for {Endpoint}, sending empty JSON object", endpoint);
|
||||
}
|
||||
|
||||
return await SendAsync(HttpMethod.Post, endpoint, bodyToSend, clientHeaders, "application/json");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Sends an arbitrary HTTP request to Jellyfin while preserving the caller's method and body semantics.
|
||||
/// Intended for transparent proxy scenarios such as session control routes.
|
||||
/// </summary>
|
||||
public async Task<(JsonDocument? Body, int StatusCode)> SendAsync(
|
||||
HttpMethod method,
|
||||
string endpoint,
|
||||
string? body,
|
||||
IHeaderDictionary clientHeaders,
|
||||
string? contentType = null)
|
||||
{
|
||||
var url = BuildUrl(endpoint, null);
|
||||
|
||||
using var request = new HttpRequestMessage(HttpMethod.Post, url);
|
||||
using var request = new HttpRequestMessage(method, url);
|
||||
|
||||
// Forward client IP address to Jellyfin so it can identify the real client
|
||||
if (_httpContextAccessor.HttpContext != null)
|
||||
@@ -261,68 +360,62 @@ public class JellyfinProxyService
|
||||
}
|
||||
}
|
||||
|
||||
// Handle special case for playback endpoints
|
||||
// NOTE: Jellyfin API expects PlaybackStartInfo/PlaybackProgressInfo/PlaybackStopInfo
|
||||
// DIRECTLY as the body, NOT wrapped in a field. Do NOT wrap the body.
|
||||
var bodyToSend = body;
|
||||
if (string.IsNullOrWhiteSpace(body))
|
||||
if (body != null)
|
||||
{
|
||||
bodyToSend = "{}";
|
||||
_logger.LogWarning("POST body was empty for {Url}, sending empty JSON object", url);
|
||||
var requestContent = new StringContent(body, System.Text.Encoding.UTF8);
|
||||
try
|
||||
{
|
||||
requestContent.Headers.ContentType = !string.IsNullOrWhiteSpace(contentType)
|
||||
? MediaTypeHeaderValue.Parse(contentType)
|
||||
: new MediaTypeHeaderValue("application/json") { CharSet = "utf-8" };
|
||||
}
|
||||
catch (FormatException)
|
||||
{
|
||||
_logger.LogWarning("Invalid content type '{ContentType}' for {Method} {Endpoint}; falling back to application/json",
|
||||
contentType,
|
||||
method,
|
||||
endpoint);
|
||||
requestContent.Headers.ContentType = new MediaTypeHeaderValue("application/json") { CharSet = "utf-8" };
|
||||
}
|
||||
|
||||
request.Content = requestContent;
|
||||
}
|
||||
|
||||
request.Content = new StringContent(bodyToSend, System.Text.Encoding.UTF8, "application/json");
|
||||
|
||||
bool authHeaderAdded = false;
|
||||
bool isAuthEndpoint = endpoint.Contains("Authenticate", StringComparison.OrdinalIgnoreCase);
|
||||
|
||||
// Forward authentication headers from client
|
||||
authHeaderAdded = AuthHeaderHelper.ForwardAuthHeaders(clientHeaders, request);
|
||||
var authHeaderAdded = AuthHeaderHelper.ForwardAuthHeaders(clientHeaders, request);
|
||||
var isAuthEndpoint = endpoint.Contains("Authenticate", StringComparison.OrdinalIgnoreCase);
|
||||
|
||||
if (authHeaderAdded)
|
||||
{
|
||||
_logger.LogTrace("Forwarded authentication headers");
|
||||
}
|
||||
|
||||
// For authentication endpoints, credentials are in the body, not headers
|
||||
// For other endpoints without auth, let Jellyfin reject the request
|
||||
if (!authHeaderAdded && !isAuthEndpoint)
|
||||
else if (!isAuthEndpoint)
|
||||
{
|
||||
_logger.LogDebug("No client auth provided for POST {Url} - Jellyfin will handle authentication", url);
|
||||
_logger.LogDebug("No client auth provided for {Method} {Url} - Jellyfin will handle authentication", method, url);
|
||||
}
|
||||
|
||||
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
|
||||
|
||||
// DO NOT log the body for auth endpoints - it contains passwords!
|
||||
if (isAuthEndpoint)
|
||||
{
|
||||
_logger.LogDebug("POST to Jellyfin: {Url} (auth request - body not logged)", url);
|
||||
_logger.LogDebug("{Method} to Jellyfin: {Url} (auth request - body not logged)", method, url);
|
||||
}
|
||||
else if (body == null)
|
||||
{
|
||||
_logger.LogTrace("{Method} to Jellyfin: {Url} (no request body)", method, url);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogTrace("POST to Jellyfin: {Url}, body length: {Length} bytes", url, bodyToSend.Length);
|
||||
_logger.LogTrace("{Method} to Jellyfin: {Url}, body length: {Length} bytes", method, url, body.Length);
|
||||
}
|
||||
|
||||
var response = await _httpClient.SendAsync(request);
|
||||
|
||||
var statusCode = (int)response.StatusCode;
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
var errorContent = await response.Content.ReadAsStringAsync();
|
||||
LogUpstreamFailure(method, response.StatusCode, url, errorContent);
|
||||
|
||||
// 401 is expected when tokens expire - don't spam logs
|
||||
if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized)
|
||||
{
|
||||
_logger.LogDebug("Jellyfin POST returned 401 for {Url} - client should re-authenticate", url);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogError("Jellyfin POST request failed: {StatusCode} for {Url}. Response: {Response}",
|
||||
response.StatusCode, url, errorContent.Length > 200 ? errorContent[..200] + "..." : errorContent);
|
||||
}
|
||||
|
||||
// Try to parse error response as JSON to pass through to client
|
||||
if (!string.IsNullOrWhiteSpace(errorContent))
|
||||
{
|
||||
try
|
||||
@@ -339,21 +432,17 @@ public class JellyfinProxyService
|
||||
return (null, statusCode);
|
||||
}
|
||||
|
||||
// Log successful session-related responses
|
||||
if (endpoint.Contains("Sessions", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
_logger.LogTrace("Jellyfin responded {StatusCode} for {Endpoint}", statusCode, endpoint);
|
||||
_logger.LogTrace("Jellyfin responded {StatusCode} for {Method} {Endpoint}", statusCode, method, endpoint);
|
||||
}
|
||||
|
||||
// Handle 204 No Content responses (e.g., /sessions/playing, /sessions/playing/progress)
|
||||
if (response.StatusCode == System.Net.HttpStatusCode.NoContent)
|
||||
if (response.StatusCode == HttpStatusCode.NoContent)
|
||||
{
|
||||
return (null, statusCode);
|
||||
}
|
||||
|
||||
var responseContent = await response.Content.ReadAsStringAsync();
|
||||
|
||||
// Handle empty responses
|
||||
if (string.IsNullOrWhiteSpace(responseContent))
|
||||
{
|
||||
return (null, statusCode);
|
||||
@@ -415,66 +504,7 @@ public class JellyfinProxyService
|
||||
/// </summary>
|
||||
public async Task<(JsonDocument? Body, int StatusCode)> DeleteAsync(string endpoint, IHeaderDictionary clientHeaders)
|
||||
{
|
||||
var url = BuildUrl(endpoint, null);
|
||||
|
||||
using var request = new HttpRequestMessage(HttpMethod.Delete, url);
|
||||
|
||||
// Forward client IP address to Jellyfin so it can identify the real client
|
||||
if (_httpContextAccessor.HttpContext != null)
|
||||
{
|
||||
var clientIp = _httpContextAccessor.HttpContext.Connection.RemoteIpAddress?.ToString();
|
||||
if (!string.IsNullOrEmpty(clientIp))
|
||||
{
|
||||
request.Headers.TryAddWithoutValidation("X-Forwarded-For", clientIp);
|
||||
request.Headers.TryAddWithoutValidation("X-Real-IP", clientIp);
|
||||
}
|
||||
}
|
||||
|
||||
bool authHeaderAdded = false;
|
||||
|
||||
// Forward authentication headers from client
|
||||
authHeaderAdded = AuthHeaderHelper.ForwardAuthHeaders(clientHeaders, request);
|
||||
|
||||
if (!authHeaderAdded)
|
||||
{
|
||||
_logger.LogDebug("No client auth provided for DELETE {Url} - forwarding without auth", url);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogTrace("Forwarded authentication headers");
|
||||
}
|
||||
|
||||
request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
|
||||
|
||||
_logger.LogDebug("DELETE to Jellyfin: {Url}", url);
|
||||
|
||||
var response = await _httpClient.SendAsync(request);
|
||||
|
||||
var statusCode = (int)response.StatusCode;
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
var errorContent = await response.Content.ReadAsStringAsync();
|
||||
_logger.LogError("Jellyfin DELETE request failed: {StatusCode} for {Url}. Response: {Response}",
|
||||
response.StatusCode, url, errorContent);
|
||||
return (null, statusCode);
|
||||
}
|
||||
|
||||
// Handle 204 No Content responses
|
||||
if (response.StatusCode == System.Net.HttpStatusCode.NoContent)
|
||||
{
|
||||
return (null, statusCode);
|
||||
}
|
||||
|
||||
var responseContent = await response.Content.ReadAsStringAsync();
|
||||
|
||||
// Handle empty responses
|
||||
if (string.IsNullOrWhiteSpace(responseContent))
|
||||
{
|
||||
return (null, statusCode);
|
||||
}
|
||||
|
||||
return (JsonDocument.Parse(responseContent), statusCode);
|
||||
return await SendAsync(HttpMethod.Delete, endpoint, null, clientHeaders);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -915,6 +945,62 @@ public class JellyfinProxyService
|
||||
return url;
|
||||
}
|
||||
|
||||
private void LogUpstreamFailure(HttpMethod method, HttpStatusCode statusCode, string url, string? responseBody = null)
|
||||
{
|
||||
if (statusCode == HttpStatusCode.Unauthorized)
|
||||
{
|
||||
_logger.LogDebug("Jellyfin {Method} returned 401 for {Url} - client should re-authenticate",
|
||||
method.Method, url);
|
||||
return;
|
||||
}
|
||||
|
||||
var isLikelyBotProbe = BotProbeDetector.IsHighConfidenceProbeUrl(url);
|
||||
|
||||
if (statusCode == HttpStatusCode.NotFound)
|
||||
{
|
||||
if (isLikelyBotProbe)
|
||||
{
|
||||
_logger.LogDebug("Likely bot probe returned 404 for {Url}", url);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogDebug("Jellyfin {Method} returned 404 for {Url}", method.Method, url);
|
||||
}
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
var responsePreview = string.IsNullOrWhiteSpace(responseBody)
|
||||
? null
|
||||
: responseBody.Length > 200 ? responseBody[..200] + "..." : responseBody;
|
||||
|
||||
if (isLikelyBotProbe)
|
||||
{
|
||||
if (responsePreview == null)
|
||||
{
|
||||
_logger.LogWarning("Likely bot probe returned {StatusCode} for {Url}", statusCode, url);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogWarning("Likely bot probe returned {StatusCode} for {Url}. Response: {Response}",
|
||||
statusCode, url, responsePreview);
|
||||
}
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
if (responsePreview == null)
|
||||
{
|
||||
_logger.LogError("Jellyfin {Method} request failed: {StatusCode} for {Url}",
|
||||
method.Method, statusCode, url);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogError("Jellyfin {Method} request failed: {StatusCode} for {Url}. Response: {Response}",
|
||||
method.Method, statusCode, url, responsePreview);
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Sends a GET request to the Jellyfin server using the server's API key for internal operations.
|
||||
/// This should only be used for server-side operations, not for proxying client requests.
|
||||
|
||||
@@ -294,7 +294,7 @@ public class JellyfinResponseBuilder
|
||||
/// </summary>
|
||||
public Dictionary<string, object?> ConvertSongToJellyfinItem(Song song)
|
||||
{
|
||||
// Add " [S]" suffix to external song titles (S = streaming source)
|
||||
// Add external/explicit labels to song titles for external tracks.
|
||||
var songTitle = song.Title;
|
||||
var artistName = song.Artist;
|
||||
var albumName = song.Album;
|
||||
@@ -302,7 +302,7 @@ public class JellyfinResponseBuilder
|
||||
|
||||
if (!song.IsLocal)
|
||||
{
|
||||
songTitle = $"{song.Title} [S]";
|
||||
songTitle = BuildExternalSongTitle(song);
|
||||
|
||||
// Also add [S] to artist and album names for consistency
|
||||
if (!string.IsNullOrEmpty(artistName) && !artistName.EndsWith(" [S]"))
|
||||
@@ -355,6 +355,7 @@ public class JellyfinResponseBuilder
|
||||
["Tags"] = new string[0],
|
||||
["People"] = new object[0],
|
||||
["SortName"] = songTitle,
|
||||
["AudioInfo"] = new Dictionary<string, object?>(),
|
||||
["ParentLogoItemId"] = song.AlbumId,
|
||||
["ParentBackdropItemId"] = song.AlbumId,
|
||||
["ParentBackdropImageTags"] = new string[0],
|
||||
@@ -405,6 +406,7 @@ public class JellyfinResponseBuilder
|
||||
["MediaType"] = "Audio",
|
||||
["NormalizationGain"] = 0.0,
|
||||
["Path"] = $"/music/{song.Artist}/{song.Album}/{song.Title}.flac",
|
||||
["CanDelete"] = false,
|
||||
["CanDownload"] = true,
|
||||
["SupportsSync"] = true
|
||||
};
|
||||
@@ -502,6 +504,18 @@ public class JellyfinResponseBuilder
|
||||
return item;
|
||||
}
|
||||
|
||||
private static string BuildExternalSongTitle(Song song)
|
||||
{
|
||||
var title = $"{song.Title} [S]";
|
||||
|
||||
if (song.ExplicitContentLyrics == 1)
|
||||
{
|
||||
title = $"{title} [E]";
|
||||
}
|
||||
|
||||
return title;
|
||||
}
|
||||
|
||||
private static bool ShouldDisableTranscoding(string provider)
|
||||
{
|
||||
return provider.Equals("deezer", StringComparison.OrdinalIgnoreCase) ||
|
||||
@@ -527,6 +541,7 @@ public class JellyfinResponseBuilder
|
||||
["ServerId"] = "allstarr",
|
||||
["Id"] = album.Id,
|
||||
["PremiereDate"] = album.Year.HasValue ? $"{album.Year}-01-01T05:00:00.0000000Z" : null,
|
||||
["DateCreated"] = album.Year.HasValue ? $"{album.Year}-01-01T05:00:00.0000000Z" : "1970-01-01T00:00:00.0000000Z",
|
||||
["ChannelId"] = (object?)null,
|
||||
["Genres"] = !string.IsNullOrEmpty(album.Genre)
|
||||
? new[] { album.Genre }
|
||||
@@ -535,6 +550,8 @@ public class JellyfinResponseBuilder
|
||||
["ProductionYear"] = album.Year,
|
||||
["IsFolder"] = true,
|
||||
["Type"] = "MusicAlbum",
|
||||
["SortName"] = albumName,
|
||||
["BasicSyncInfo"] = new Dictionary<string, object?>(),
|
||||
["GenreItems"] = !string.IsNullOrEmpty(album.Genre)
|
||||
? new[]
|
||||
{
|
||||
@@ -621,6 +638,9 @@ public class JellyfinResponseBuilder
|
||||
["RunTimeTicks"] = 0,
|
||||
["IsFolder"] = true,
|
||||
["Type"] = "MusicArtist",
|
||||
["SortName"] = artistName,
|
||||
["PrimaryImageAspectRatio"] = 1.0,
|
||||
["BasicSyncInfo"] = new Dictionary<string, object?>(),
|
||||
["GenreItems"] = new Dictionary<string, object?>[0],
|
||||
["UserData"] = new Dictionary<string, object>
|
||||
{
|
||||
@@ -743,6 +763,11 @@ public class JellyfinResponseBuilder
|
||||
["RunTimeTicks"] = playlist.Duration * TimeSpan.TicksPerSecond,
|
||||
["IsFolder"] = true,
|
||||
["Type"] = "MusicAlbum",
|
||||
["SortName"] = $"{playlist.Name} [S/P]",
|
||||
["DateCreated"] = playlist.CreatedDate.HasValue
|
||||
? playlist.CreatedDate.Value.ToString("o")
|
||||
: "1970-01-01T00:00:00.0000000Z",
|
||||
["BasicSyncInfo"] = new Dictionary<string, object?>(),
|
||||
["GenreItems"] = new Dictionary<string, object?>[0],
|
||||
["UserData"] = new Dictionary<string, object>
|
||||
{
|
||||
|
||||
@@ -20,6 +20,7 @@ public class JellyfinSessionManager : IDisposable
|
||||
private readonly ILogger<JellyfinSessionManager> _logger;
|
||||
private readonly ConcurrentDictionary<string, SessionInfo> _sessions = new();
|
||||
private readonly ConcurrentDictionary<string, SemaphoreSlim> _sessionInitLocks = new();
|
||||
private readonly ConcurrentDictionary<string, byte> _proxiedWebSocketConnections = new();
|
||||
private readonly Timer _keepAliveTimer;
|
||||
|
||||
public JellyfinSessionManager(
|
||||
@@ -53,21 +54,28 @@ public class JellyfinSessionManager : IDisposable
|
||||
await initLock.WaitAsync();
|
||||
try
|
||||
{
|
||||
var hasProxiedWebSocket = HasProxiedWebSocket(deviceId);
|
||||
|
||||
// Check if we already have this session tracked
|
||||
if (_sessions.TryGetValue(deviceId, out var existingSession))
|
||||
{
|
||||
existingSession.LastActivity = DateTime.UtcNow;
|
||||
existingSession.HasProxiedWebSocket = hasProxiedWebSocket;
|
||||
_logger.LogInformation("Session already exists for device {DeviceId}", deviceId);
|
||||
|
||||
// Refresh capabilities to keep session alive
|
||||
// If this returns false (401), the token expired and client needs to re-auth
|
||||
var refreshOk = await PostCapabilitiesAsync(headers);
|
||||
if (!refreshOk)
|
||||
if (!hasProxiedWebSocket)
|
||||
{
|
||||
// Token expired - remove the stale session
|
||||
_logger.LogWarning("Token expired for device {DeviceId} - removing session", deviceId);
|
||||
await RemoveSessionAsync(deviceId);
|
||||
return false;
|
||||
// Refresh capabilities to keep session alive only for sessions that Allstarr
|
||||
// is synthesizing itself. Native proxied websocket sessions should be left
|
||||
// entirely under Jellyfin's control.
|
||||
var refreshOk = await PostCapabilitiesAsync(headers);
|
||||
if (!refreshOk)
|
||||
{
|
||||
// Token expired - remove the stale session
|
||||
_logger.LogWarning("Token expired for device {DeviceId} - removing session", deviceId);
|
||||
await RemoveSessionAsync(deviceId);
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
return true;
|
||||
@@ -75,16 +83,26 @@ public class JellyfinSessionManager : IDisposable
|
||||
|
||||
_logger.LogDebug("Creating new session for device: {DeviceId} ({Client} on {Device})", deviceId, client, device);
|
||||
|
||||
// Post session capabilities to Jellyfin - this creates the session
|
||||
var createOk = await PostCapabilitiesAsync(headers);
|
||||
if (!createOk)
|
||||
if (!hasProxiedWebSocket)
|
||||
{
|
||||
// Token expired or invalid - client needs to re-authenticate
|
||||
_logger.LogError("Failed to create session for {DeviceId} - token may be expired", deviceId);
|
||||
return false;
|
||||
}
|
||||
// Post session capabilities to Jellyfin only when Allstarr is creating a
|
||||
// synthetic session. If the real client already has a proxied websocket,
|
||||
// re-posting capabilities can overwrite its remote-control state.
|
||||
var createOk = await PostCapabilitiesAsync(headers);
|
||||
if (!createOk)
|
||||
{
|
||||
// Token expired or invalid - client needs to re-authenticate
|
||||
_logger.LogError("Failed to create session for {DeviceId} - token may be expired", deviceId);
|
||||
return false;
|
||||
}
|
||||
|
||||
_logger.LogInformation("Session created for {DeviceId}", deviceId);
|
||||
_logger.LogInformation("Session created for {DeviceId}", deviceId);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogDebug("Skipping synthetic Jellyfin session bootstrap for proxied websocket device {DeviceId}",
|
||||
deviceId);
|
||||
}
|
||||
|
||||
// Track this session
|
||||
var clientIp = headers["X-Forwarded-For"].FirstOrDefault()?.Split(',')[0].Trim()
|
||||
@@ -99,11 +117,16 @@ public class JellyfinSessionManager : IDisposable
|
||||
Version = version,
|
||||
LastActivity = DateTime.UtcNow,
|
||||
Headers = CloneHeaders(headers),
|
||||
ClientIp = clientIp
|
||||
ClientIp = clientIp,
|
||||
HasProxiedWebSocket = hasProxiedWebSocket
|
||||
};
|
||||
|
||||
// Start a WebSocket connection to Jellyfin on behalf of this client
|
||||
_ = Task.Run(() => MaintainWebSocketForSessionAsync(deviceId, headers));
|
||||
// Start a synthetic WebSocket connection only when the client itself does not
|
||||
// already have a proxied Jellyfin socket through Allstarr.
|
||||
if (!hasProxiedWebSocket)
|
||||
{
|
||||
_ = Task.Run(() => MaintainWebSocketForSessionAsync(deviceId, headers));
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
@@ -118,6 +141,44 @@ public class JellyfinSessionManager : IDisposable
|
||||
}
|
||||
}
|
||||
|
||||
public async Task RegisterProxiedWebSocketAsync(string deviceId)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(deviceId))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
_proxiedWebSocketConnections[deviceId] = 0;
|
||||
|
||||
if (_sessions.TryGetValue(deviceId, out var session))
|
||||
{
|
||||
session.HasProxiedWebSocket = true;
|
||||
session.LastActivity = DateTime.UtcNow;
|
||||
await CloseSyntheticWebSocketAsync(deviceId, session);
|
||||
}
|
||||
}
|
||||
|
||||
public void UnregisterProxiedWebSocket(string deviceId)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(deviceId))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
_proxiedWebSocketConnections.TryRemove(deviceId, out _);
|
||||
|
||||
if (_sessions.TryGetValue(deviceId, out var session))
|
||||
{
|
||||
session.HasProxiedWebSocket = false;
|
||||
session.LastActivity = DateTime.UtcNow;
|
||||
}
|
||||
}
|
||||
|
||||
private bool HasProxiedWebSocket(string deviceId)
|
||||
{
|
||||
return !string.IsNullOrWhiteSpace(deviceId) && _proxiedWebSocketConnections.ContainsKey(deviceId);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Posts session capabilities to Jellyfin.
|
||||
/// Returns true if successful, false if token expired (401).
|
||||
@@ -296,34 +357,37 @@ public class JellyfinSessionManager : IDisposable
|
||||
return (null, null);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Returns current active playback states for tracked sessions.
|
||||
/// </summary>
|
||||
public IReadOnlyList<ActivePlaybackState> GetActivePlaybackStates(TimeSpan maxAge)
|
||||
{
|
||||
var cutoff = DateTime.UtcNow - maxAge;
|
||||
|
||||
return _sessions.Values
|
||||
.Where(session =>
|
||||
!string.IsNullOrWhiteSpace(session.LastPlayingItemId) &&
|
||||
session.LastActivity >= cutoff)
|
||||
.Select(session => new ActivePlaybackState(
|
||||
session.DeviceId,
|
||||
session.LastPlayingItemId!,
|
||||
session.LastPlayingPositionTicks ?? 0,
|
||||
session.LastActivity))
|
||||
.ToList();
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Marks a session as potentially ended (e.g., after playback stops).
|
||||
/// The session will be cleaned up if no new activity occurs within the timeout.
|
||||
/// Jellyfin should decide when the upstream playback session expires.
|
||||
/// </summary>
|
||||
public void MarkSessionPotentiallyEnded(string deviceId, TimeSpan timeout)
|
||||
{
|
||||
if (_sessions.TryGetValue(deviceId, out var session))
|
||||
if (_sessions.TryGetValue(deviceId, out _))
|
||||
{
|
||||
_logger.LogDebug("⏰ SESSION: Marking session {DeviceId} as potentially ended, will cleanup in {Seconds}s if no activity",
|
||||
deviceId, timeout.TotalSeconds);
|
||||
|
||||
_ = Task.Run(async () =>
|
||||
{
|
||||
var markedTime = DateTime.UtcNow;
|
||||
await Task.Delay(timeout);
|
||||
|
||||
// Check if there's been activity since we marked it
|
||||
if (_sessions.TryGetValue(deviceId, out var currentSession) &&
|
||||
currentSession.LastActivity <= markedTime)
|
||||
{
|
||||
_logger.LogDebug("🧹 SESSION: Auto-removing inactive session {DeviceId} after playback stop", deviceId);
|
||||
await RemoveSessionAsync(deviceId);
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogDebug("✓ SESSION: Session {DeviceId} had activity, keeping alive", deviceId);
|
||||
}
|
||||
});
|
||||
_logger.LogDebug(
|
||||
"⏰ SESSION: Playback stopped for {DeviceId}; leaving upstream session lifetime to Jellyfin (timeout hint {Seconds}s ignored)",
|
||||
deviceId,
|
||||
timeout.TotalSeconds);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -342,8 +406,10 @@ public class JellyfinSessionManager : IDisposable
|
||||
ClientIp = s.ClientIp,
|
||||
LastActivity = s.LastActivity,
|
||||
InactiveMinutes = Math.Round((now - s.LastActivity).TotalMinutes, 1),
|
||||
HasWebSocket = s.WebSocket != null,
|
||||
WebSocketState = s.WebSocket?.State.ToString() ?? "None"
|
||||
HasWebSocket = s.HasProxiedWebSocket || s.WebSocket != null,
|
||||
HasProxiedWebSocket = s.HasProxiedWebSocket,
|
||||
HasSyntheticWebSocket = s.WebSocket != null,
|
||||
WebSocketState = s.HasProxiedWebSocket ? "Proxied" : s.WebSocket?.State.ToString() ?? "None"
|
||||
}).ToList();
|
||||
|
||||
return new
|
||||
@@ -360,6 +426,8 @@ public class JellyfinSessionManager : IDisposable
|
||||
/// </summary>
|
||||
public async Task RemoveSessionAsync(string deviceId)
|
||||
{
|
||||
_proxiedWebSocketConnections.TryRemove(deviceId, out _);
|
||||
|
||||
if (_sessions.TryRemove(deviceId, out var session))
|
||||
{
|
||||
_logger.LogDebug("🗑️ SESSION: Removing session for device {DeviceId}", deviceId);
|
||||
@@ -398,8 +466,7 @@ public class JellyfinSessionManager : IDisposable
|
||||
deviceId, session.LastPlayingItemId, session.LastPlayingPositionTicks);
|
||||
}
|
||||
|
||||
// Notify Jellyfin that the session is ending
|
||||
await _proxyService.PostJsonAsync("Sessions/Logout", "{}", session.Headers);
|
||||
// Let Jellyfin retire the session naturally; internal cleanup must not revoke the user's token.
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
@@ -420,6 +487,12 @@ public class JellyfinSessionManager : IDisposable
|
||||
return;
|
||||
}
|
||||
|
||||
if (session.HasProxiedWebSocket || HasProxiedWebSocket(deviceId))
|
||||
{
|
||||
_logger.LogDebug("Skipping synthetic Jellyfin websocket for proxied device {DeviceId}", deviceId);
|
||||
return;
|
||||
}
|
||||
|
||||
ClientWebSocket? webSocket = null;
|
||||
|
||||
try
|
||||
@@ -452,6 +525,12 @@ public class JellyfinSessionManager : IDisposable
|
||||
_logger.LogDebug("🔑 WEBSOCKET: Using X-Emby-Authorization for {DeviceId}", deviceId);
|
||||
authFound = true;
|
||||
}
|
||||
else if (sessionHeaders.TryGetValue("X-Emby-Token", out var token))
|
||||
{
|
||||
webSocket.Options.SetRequestHeader("X-Emby-Token", token.ToString());
|
||||
_logger.LogDebug("🔑 WEBSOCKET: Using X-Emby-Token for {DeviceId}", deviceId);
|
||||
authFound = true;
|
||||
}
|
||||
else if (sessionHeaders.TryGetValue("Authorization", out var auth))
|
||||
{
|
||||
var authValue = auth.ToString();
|
||||
@@ -517,6 +596,13 @@ public class JellyfinSessionManager : IDisposable
|
||||
{
|
||||
try
|
||||
{
|
||||
if (HasProxiedWebSocket(deviceId))
|
||||
{
|
||||
_logger.LogDebug("Stopping synthetic Jellyfin websocket because proxied client websocket is active for {DeviceId}",
|
||||
deviceId);
|
||||
break;
|
||||
}
|
||||
|
||||
// Use a timeout so we can send keep-alive messages periodically
|
||||
using var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(cts.Token);
|
||||
timeoutCts.CancelAfter(TimeSpan.FromSeconds(30));
|
||||
@@ -627,6 +713,12 @@ public class JellyfinSessionManager : IDisposable
|
||||
{
|
||||
try
|
||||
{
|
||||
session.HasProxiedWebSocket = HasProxiedWebSocket(session.DeviceId);
|
||||
if (session.HasProxiedWebSocket)
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
// Post capabilities again to keep session alive
|
||||
// If this returns false (401), the token has expired
|
||||
var success = await PostCapabilitiesAsync(session.Headers);
|
||||
@@ -687,8 +779,15 @@ public class JellyfinSessionManager : IDisposable
|
||||
public string? LastLocalPlayedSignalItemId { get; set; }
|
||||
public string? LastExplicitStopItemId { get; set; }
|
||||
public DateTime? LastExplicitStopAtUtc { get; set; }
|
||||
public bool HasProxiedWebSocket { get; set; }
|
||||
}
|
||||
|
||||
public sealed record ActivePlaybackState(
|
||||
string DeviceId,
|
||||
string ItemId,
|
||||
long PositionTicks,
|
||||
DateTime LastActivity);
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
_keepAliveTimer?.Dispose();
|
||||
@@ -715,4 +814,31 @@ public class JellyfinSessionManager : IDisposable
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private async Task CloseSyntheticWebSocketAsync(string deviceId, SessionInfo session)
|
||||
{
|
||||
var syntheticSocket = session.WebSocket;
|
||||
if (syntheticSocket == null)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
session.WebSocket = null;
|
||||
|
||||
try
|
||||
{
|
||||
if (syntheticSocket.State == WebSocketState.Open || syntheticSocket.State == WebSocketState.CloseReceived)
|
||||
{
|
||||
await syntheticSocket.CloseAsync(WebSocketCloseStatus.NormalClosure, "Native client websocket active", CancellationToken.None);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogDebug(ex, "Failed to close synthetic Jellyfin websocket for proxied device {DeviceId}", deviceId);
|
||||
}
|
||||
finally
|
||||
{
|
||||
syntheticSocket.Dispose();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -55,6 +55,7 @@ public class QobuzDownloadService : BaseDownloadService
|
||||
_userAuthToken = qobuzConfig.UserAuthToken;
|
||||
_userId = qobuzConfig.UserId;
|
||||
_preferredQuality = qobuzConfig.Quality;
|
||||
_minRequestIntervalMs = qobuzConfig.MinRequestIntervalMs;
|
||||
}
|
||||
|
||||
#region BaseDownloadService Implementation
|
||||
@@ -101,8 +102,7 @@ public class QobuzDownloadService : BaseDownloadService
|
||||
|
||||
// Build organized folder structure using AlbumArtist (fallback to Artist for singles)
|
||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||
// Cache mode uses downloads/cache/ folder, Permanent mode uses downloads/permanent/
|
||||
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache
|
||||
var basePath = CurrentStorageMode == StorageMode.Cache
|
||||
? Path.Combine(DownloadPath, "cache")
|
||||
: Path.Combine(DownloadPath, "permanent");
|
||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension, "qobuz", trackId);
|
||||
@@ -113,8 +113,12 @@ public class QobuzDownloadService : BaseDownloadService
|
||||
outputPath = PathHelper.ResolveUniquePath(outputPath);
|
||||
|
||||
// Download the file (Qobuz files are NOT encrypted like Deezer)
|
||||
var response = await _httpClient.GetAsync(downloadInfo.Url, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
response.EnsureSuccessStatusCode();
|
||||
var response = await RetryHelper.RetryWithBackoffAsync(async () =>
|
||||
{
|
||||
var res = await _httpClient.GetAsync(downloadInfo.Url, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
res.EnsureSuccessStatusCode();
|
||||
return res;
|
||||
}, Logger);
|
||||
|
||||
await using var responseStream = await response.Content.ReadAsStreamAsync(cancellationToken);
|
||||
await using var outputFile = IOFile.Create(outputPath);
|
||||
@@ -130,6 +134,143 @@ public class QobuzDownloadService : BaseDownloadService
|
||||
|
||||
#endregion
|
||||
|
||||
#region Quality Override Support
|
||||
|
||||
/// <summary>
|
||||
/// Downloads a track at a specific quality tier, capped at the .env quality ceiling.
|
||||
/// Note: Qobuz's lowest available quality is MP3 320kbps, so both High and Low map to FormatMp3320.
|
||||
///
|
||||
/// Quality hierarchy: FormatFlac24High > FormatFlac24Low > FormatFlac16 > FormatMp3320
|
||||
/// </summary>
|
||||
protected override async Task<string> DownloadTrackWithQualityAsync(
|
||||
string trackId, Song song, StreamQuality quality, CancellationToken cancellationToken)
|
||||
{
|
||||
if (quality == StreamQuality.Original)
|
||||
{
|
||||
return await DownloadTrackAsync(trackId, song, cancellationToken);
|
||||
}
|
||||
|
||||
// Map StreamQuality to Qobuz format ID, capped at .env ceiling
|
||||
// Both High and Low map to MP3_320 since Qobuz has no lower quality
|
||||
var envFormatId = GetFormatId(_preferredQuality);
|
||||
var formatId = MapStreamQualityToQobuz(quality, envFormatId);
|
||||
|
||||
Logger.LogInformation(
|
||||
"Quality override: StreamQuality.{Quality} → Qobuz formatId {FormatId} (env ceiling: {EnvFormatId}) for track {TrackId}",
|
||||
quality, formatId, envFormatId, trackId);
|
||||
|
||||
// Get download URL at the overridden quality — try all secrets
|
||||
var secrets = await _bundleService.GetSecretsAsync();
|
||||
|
||||
if (secrets.Count == 0)
|
||||
{
|
||||
throw new Exception("No secrets available for signing");
|
||||
}
|
||||
|
||||
QobuzDownloadResult? downloadInfo = null;
|
||||
Exception? lastException = null;
|
||||
|
||||
foreach (var secret in secrets)
|
||||
{
|
||||
try
|
||||
{
|
||||
downloadInfo = await TryGetTrackDownloadUrlAsync(trackId, formatId, secret, cancellationToken);
|
||||
break;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
lastException = ex;
|
||||
Logger.LogDebug("Failed with secret for quality override: {Error}", ex.Message);
|
||||
}
|
||||
}
|
||||
|
||||
if (downloadInfo == null)
|
||||
{
|
||||
throw new Exception("Failed to get download URL for quality override", lastException);
|
||||
}
|
||||
|
||||
// Check if it's a demo/sample
|
||||
if (downloadInfo.IsSample)
|
||||
{
|
||||
throw new Exception("Track is only available as a demo/sample");
|
||||
}
|
||||
|
||||
// Determine extension based on MIME type
|
||||
var extension = downloadInfo.MimeType?.Contains("flac") == true ? ".flac" : ".mp3";
|
||||
|
||||
// Write to transcoded cache directory: {downloads}/transcoded/Artist/Album/song.ext
|
||||
// These files are cleaned up by CacheCleanupService based on CACHE_TRANSCODE_MINUTES TTL
|
||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||
var basePath = Path.Combine("downloads", "transcoded");
|
||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension, "qobuz", trackId);
|
||||
|
||||
// Create directories if they don't exist
|
||||
var albumFolder = Path.GetDirectoryName(outputPath)!;
|
||||
EnsureDirectoryExists(albumFolder);
|
||||
|
||||
// If the file already exists in transcoded cache, return it directly
|
||||
if (IOFile.Exists(outputPath))
|
||||
{
|
||||
// Touch the file to extend its cache lifetime
|
||||
IOFile.SetLastWriteTime(outputPath, DateTime.UtcNow);
|
||||
Logger.LogInformation("Quality override cache hit: {Path}", outputPath);
|
||||
return outputPath;
|
||||
}
|
||||
|
||||
// Download the file (Qobuz files are NOT encrypted like Deezer)
|
||||
var response = await RetryHelper.RetryWithBackoffAsync(async () =>
|
||||
{
|
||||
var res = await _httpClient.GetAsync(downloadInfo.Url, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
res.EnsureSuccessStatusCode();
|
||||
return res;
|
||||
}, Logger);
|
||||
|
||||
await using var responseStream = await response.Content.ReadAsStreamAsync(cancellationToken);
|
||||
await using var outputFile = IOFile.Create(outputPath);
|
||||
await responseStream.CopyToAsync(outputFile, cancellationToken);
|
||||
|
||||
// Close file before writing metadata
|
||||
await outputFile.DisposeAsync();
|
||||
|
||||
// Write metadata and cover art
|
||||
await WriteMetadataAsync(outputPath, song, cancellationToken);
|
||||
|
||||
return outputPath;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Maps a StreamQuality tier to a Qobuz format ID, capped at the .env ceiling.
|
||||
/// Since Qobuz's lowest quality is MP3 320, both High and Low map to FormatMp3320.
|
||||
/// </summary>
|
||||
private int MapStreamQualityToQobuz(StreamQuality streamQuality, int envFormatId)
|
||||
{
|
||||
// Format ranking from highest to lowest quality
|
||||
var ranking = new[] { FormatFlac24High, FormatFlac24Low, FormatFlac16, FormatMp3320 };
|
||||
var envIndex = Array.IndexOf(ranking, envFormatId);
|
||||
if (envIndex < 0) envIndex = 0; // Default to highest if unknown
|
||||
|
||||
var idealFormatId = streamQuality switch
|
||||
{
|
||||
StreamQuality.Original => envFormatId,
|
||||
StreamQuality.High => FormatMp3320, // Both High and Low map to MP3 320 (Qobuz's lowest)
|
||||
StreamQuality.Low => FormatMp3320,
|
||||
_ => envFormatId
|
||||
};
|
||||
|
||||
// Cap at env ceiling (lower index = higher quality)
|
||||
var idealIndex = Array.IndexOf(ranking, idealFormatId);
|
||||
if (idealIndex < 0) idealIndex = envIndex;
|
||||
|
||||
if (idealIndex < envIndex)
|
||||
{
|
||||
return envFormatId;
|
||||
}
|
||||
|
||||
return idealFormatId;
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
#region Qobuz Download Methods
|
||||
|
||||
/// <summary>
|
||||
|
||||
@@ -81,6 +81,19 @@ public class QobuzMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
}
|
||||
|
||||
public async Task<Song?> FindSongByIsrcAsync(string isrc, CancellationToken cancellationToken = default)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(isrc))
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
var results = await SearchSongsAsync(isrc, limit: 5, cancellationToken);
|
||||
return results.FirstOrDefault(song =>
|
||||
!string.IsNullOrWhiteSpace(song.Isrc) &&
|
||||
song.Isrc.Equals(isrc, StringComparison.OrdinalIgnoreCase));
|
||||
}
|
||||
|
||||
public async Task<List<Album>> SearchAlbumsAsync(string query, int limit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
try
|
||||
@@ -147,9 +160,15 @@ public class QobuzMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
public async Task<SearchResult> SearchAllAsync(string query, int songLimit = 20, int albumLimit = 20, int artistLimit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
var songsTask = SearchSongsAsync(query, songLimit, cancellationToken);
|
||||
var albumsTask = SearchAlbumsAsync(query, albumLimit, cancellationToken);
|
||||
var artistsTask = SearchArtistsAsync(query, artistLimit, cancellationToken);
|
||||
var songsTask = songLimit > 0
|
||||
? SearchSongsAsync(query, songLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Song>());
|
||||
var albumsTask = albumLimit > 0
|
||||
? SearchAlbumsAsync(query, albumLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Album>());
|
||||
var artistsTask = artistLimit > 0
|
||||
? SearchArtistsAsync(query, artistLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Artist>());
|
||||
|
||||
await Task.WhenAll(songsTask, albumsTask, artistsTask);
|
||||
|
||||
|
||||
@@ -1026,26 +1026,7 @@ public class SpotifyApiClient : IDisposable
|
||||
continue;
|
||||
}
|
||||
|
||||
// Get track count if available - try multiple possible paths
|
||||
var trackCount = 0;
|
||||
if (playlist.TryGetProperty("content", out var content))
|
||||
{
|
||||
if (content.TryGetProperty("totalCount", out var totalTrackCount))
|
||||
{
|
||||
trackCount = totalTrackCount.GetInt32();
|
||||
}
|
||||
}
|
||||
// Fallback: try attributes.itemCount
|
||||
else if (playlist.TryGetProperty("attributes", out var attributes) &&
|
||||
attributes.TryGetProperty("itemCount", out var itemCountProp))
|
||||
{
|
||||
trackCount = itemCountProp.GetInt32();
|
||||
}
|
||||
// Fallback: try totalCount directly
|
||||
else if (playlist.TryGetProperty("totalCount", out var directTotalCount))
|
||||
{
|
||||
trackCount = directTotalCount.GetInt32();
|
||||
}
|
||||
var trackCount = TryGetSpotifyPlaylistItemCount(playlist);
|
||||
|
||||
// Log if we couldn't find track count for debugging
|
||||
if (trackCount == 0)
|
||||
@@ -1057,7 +1038,9 @@ public class SpotifyApiClient : IDisposable
|
||||
// Get owner name
|
||||
string? ownerName = null;
|
||||
if (playlist.TryGetProperty("ownerV2", out var ownerV2) &&
|
||||
ownerV2.ValueKind == JsonValueKind.Object &&
|
||||
ownerV2.TryGetProperty("data", out var ownerData) &&
|
||||
ownerData.ValueKind == JsonValueKind.Object &&
|
||||
ownerData.TryGetProperty("username", out var ownerNameProp))
|
||||
{
|
||||
ownerName = ownerNameProp.GetString();
|
||||
@@ -1066,11 +1049,14 @@ public class SpotifyApiClient : IDisposable
|
||||
// Get image URL
|
||||
string? imageUrl = null;
|
||||
if (playlist.TryGetProperty("images", out var images) &&
|
||||
images.ValueKind == JsonValueKind.Object &&
|
||||
images.TryGetProperty("items", out var imageItems) &&
|
||||
imageItems.ValueKind == JsonValueKind.Array &&
|
||||
imageItems.GetArrayLength() > 0)
|
||||
{
|
||||
var firstImage = imageItems[0];
|
||||
if (firstImage.TryGetProperty("sources", out var sources) &&
|
||||
sources.ValueKind == JsonValueKind.Array &&
|
||||
sources.GetArrayLength() > 0)
|
||||
{
|
||||
var firstSource = sources[0];
|
||||
@@ -1165,6 +1151,68 @@ public class SpotifyApiClient : IDisposable
|
||||
return null;
|
||||
}
|
||||
|
||||
private static int TryGetSpotifyPlaylistItemCount(JsonElement playlistElement)
|
||||
{
|
||||
if (playlistElement.TryGetProperty("content", out var content) &&
|
||||
content.ValueKind == JsonValueKind.Object &&
|
||||
content.TryGetProperty("totalCount", out var totalTrackCount) &&
|
||||
TryParseSpotifyIntegerElement(totalTrackCount, out var contentCount))
|
||||
{
|
||||
return contentCount;
|
||||
}
|
||||
|
||||
if (playlistElement.TryGetProperty("attributes", out var attributes))
|
||||
{
|
||||
if (attributes.ValueKind == JsonValueKind.Object &&
|
||||
attributes.TryGetProperty("itemCount", out var itemCountProp) &&
|
||||
TryParseSpotifyIntegerElement(itemCountProp, out var directAttributeCount))
|
||||
{
|
||||
return directAttributeCount;
|
||||
}
|
||||
|
||||
if (attributes.ValueKind == JsonValueKind.Array)
|
||||
{
|
||||
foreach (var attribute in attributes.EnumerateArray())
|
||||
{
|
||||
if (attribute.ValueKind != JsonValueKind.Object ||
|
||||
!attribute.TryGetProperty("key", out var keyProp) ||
|
||||
keyProp.ValueKind != JsonValueKind.String ||
|
||||
!attribute.TryGetProperty("value", out var valueProp))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var key = keyProp.GetString();
|
||||
if (string.IsNullOrWhiteSpace(key))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var normalizedKey = key.Replace("_", "", StringComparison.OrdinalIgnoreCase)
|
||||
.Replace(":", "", StringComparison.OrdinalIgnoreCase);
|
||||
if (!normalizedKey.Contains("itemcount", StringComparison.OrdinalIgnoreCase) &&
|
||||
!normalizedKey.Contains("trackcount", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
if (TryParseSpotifyIntegerElement(valueProp, out var attributeCount))
|
||||
{
|
||||
return attributeCount;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (playlistElement.TryGetProperty("totalCount", out var directTotalCount) &&
|
||||
TryParseSpotifyIntegerElement(directTotalCount, out var totalCount))
|
||||
{
|
||||
return totalCount;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
private static DateTime? ParseSpotifyDateElement(JsonElement value)
|
||||
{
|
||||
switch (value.ValueKind)
|
||||
@@ -1238,6 +1286,40 @@ public class SpotifyApiClient : IDisposable
|
||||
return null;
|
||||
}
|
||||
|
||||
private static bool TryParseSpotifyIntegerElement(JsonElement value, out int parsed)
|
||||
{
|
||||
switch (value.ValueKind)
|
||||
{
|
||||
case JsonValueKind.Number:
|
||||
return value.TryGetInt32(out parsed);
|
||||
case JsonValueKind.String:
|
||||
return int.TryParse(value.GetString(), NumberStyles.Integer, CultureInfo.InvariantCulture, out parsed);
|
||||
case JsonValueKind.Object:
|
||||
if (value.TryGetProperty("value", out var nestedValue) &&
|
||||
TryParseSpotifyIntegerElement(nestedValue, out parsed))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
if (value.TryGetProperty("itemCount", out var itemCount) &&
|
||||
TryParseSpotifyIntegerElement(itemCount, out parsed))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
if (value.TryGetProperty("totalCount", out var totalCount) &&
|
||||
TryParseSpotifyIntegerElement(totalCount, out parsed))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
break;
|
||||
}
|
||||
|
||||
parsed = 0;
|
||||
return false;
|
||||
}
|
||||
|
||||
private static DateTime? ParseSpotifyUnixTimestamp(long value)
|
||||
{
|
||||
try
|
||||
|
||||
@@ -247,6 +247,7 @@ public class SpotifyPlaylistFetcher : BackgroundService
|
||||
|
||||
// Re-fetch
|
||||
await GetPlaylistTracksAsync(playlistName);
|
||||
await ClearPlaylistImageCacheAsync(playlistName);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -262,6 +263,20 @@ public class SpotifyPlaylistFetcher : BackgroundService
|
||||
}
|
||||
}
|
||||
|
||||
private async Task ClearPlaylistImageCacheAsync(string playlistName)
|
||||
{
|
||||
var playlistConfig = _spotifyImportSettings.GetPlaylistByName(playlistName);
|
||||
if (playlistConfig == null || string.IsNullOrWhiteSpace(playlistConfig.JellyfinId))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
var deletedCount = await _cache.DeleteByPatternAsync($"image:{playlistConfig.JellyfinId}:*");
|
||||
_logger.LogDebug("Cleared {Count} cached local image entries for playlist {Playlist}",
|
||||
deletedCount,
|
||||
playlistName);
|
||||
}
|
||||
|
||||
protected override async Task ExecuteAsync(CancellationToken stoppingToken)
|
||||
{
|
||||
_logger.LogInformation("========================================");
|
||||
|
||||
@@ -26,6 +26,9 @@ namespace allstarr.Services.Spotify;
|
||||
/// </summary>
|
||||
public class SpotifyTrackMatchingService : BackgroundService
|
||||
{
|
||||
private const string CachedPlaylistItemFields =
|
||||
"Genres,GenreItems,DateCreated,MediaSources,ParentId,People,Tags,SortName,UserData,ProviderIds";
|
||||
|
||||
private readonly SpotifyImportSettings _spotifySettings;
|
||||
private readonly SpotifyApiSettings _spotifyApiSettings;
|
||||
private readonly RedisCacheService _cache;
|
||||
@@ -35,6 +38,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
private readonly IServiceProvider _serviceProvider;
|
||||
private const int DelayBetweenSearchesMs = 150; // 150ms = ~6.6 searches/second to avoid rate limiting
|
||||
private const int BatchSize = 11; // Number of parallel searches (matches SquidWTF provider count)
|
||||
private static readonly TimeSpan ExternalProviderSearchTimeout = TimeSpan.FromSeconds(30);
|
||||
|
||||
// Track last run time per playlist to prevent duplicate runs
|
||||
private readonly Dictionary<string, DateTime> _lastRunTimes = new();
|
||||
@@ -292,6 +296,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
throw;
|
||||
}
|
||||
|
||||
await ClearPlaylistImageCacheAsync(playlist);
|
||||
_logger.LogInformation("✓ Rebuild complete for {Playlist}", playlistName);
|
||||
}
|
||||
|
||||
@@ -334,6 +339,8 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
await MatchPlaylistTracksLegacyAsync(
|
||||
playlist.Name, metadataService, cancellationToken);
|
||||
}
|
||||
|
||||
await ClearPlaylistImageCacheAsync(playlist);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
@@ -342,14 +349,27 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
}
|
||||
}
|
||||
|
||||
private async Task ClearPlaylistImageCacheAsync(SpotifyPlaylistConfig playlist)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(playlist.JellyfinId))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
var deletedCount = await _cache.DeleteByPatternAsync($"image:{playlist.JellyfinId}:*");
|
||||
_logger.LogDebug("Cleared {Count} cached local image entries for playlist {Playlist}",
|
||||
deletedCount,
|
||||
playlist.Name);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Public method to trigger full rebuild for all playlists (called from "Rebuild All Remote" button).
|
||||
/// This clears caches, fetches fresh data, and re-matches everything immediately.
|
||||
/// </summary>
|
||||
public async Task TriggerRebuildAllAsync()
|
||||
public async Task TriggerRebuildAllAsync(CancellationToken cancellationToken = default)
|
||||
{
|
||||
_logger.LogInformation("Manual full rebuild triggered for all playlists");
|
||||
await RebuildAllPlaylistsAsync(CancellationToken.None);
|
||||
_logger.LogInformation("Full rebuild triggered for all playlists");
|
||||
await RebuildAllPlaylistsAsync(cancellationToken);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -594,6 +614,16 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
// Only re-match if cache is missing OR if we detect manual mappings that need to be applied
|
||||
if (existingMatched != null && existingMatched.Count > 0)
|
||||
{
|
||||
var hasIncompleteLocalSnapshots = existingMatched.Any(m =>
|
||||
m.MatchedSong?.IsLocal == true && !JellyfinItemSnapshotHelper.HasRawItemSnapshot(m.MatchedSong));
|
||||
|
||||
if (hasIncompleteLocalSnapshots)
|
||||
{
|
||||
_logger.LogInformation(
|
||||
"Rebuilding matched track cache for {Playlist}: cached local matches are missing full Jellyfin item snapshots",
|
||||
playlistName);
|
||||
}
|
||||
|
||||
// Check if we have NEW manual mappings that aren't in the cache
|
||||
var hasNewManualMappings = false;
|
||||
foreach (var track in tracksToMatch)
|
||||
@@ -616,14 +646,16 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
}
|
||||
}
|
||||
|
||||
if (!hasNewManualMappings)
|
||||
if (!hasNewManualMappings && !hasIncompleteLocalSnapshots)
|
||||
{
|
||||
_logger.LogWarning("✓ Playlist {Playlist} already has {Count} matched tracks cached (skipping {ToMatch} new tracks), no re-matching needed",
|
||||
playlistName, existingMatched.Count, tracksToMatch.Count);
|
||||
return;
|
||||
}
|
||||
|
||||
_logger.LogInformation("New manual mappings detected for {Playlist}, rebuilding cache to apply them", playlistName);
|
||||
_logger.LogInformation(
|
||||
"Rebuilding matched track cache for {Playlist} to apply updated mappings or snapshot completeness",
|
||||
playlistName);
|
||||
}
|
||||
|
||||
// PHASE 1: Get ALL Jellyfin tracks from the playlist (already injected by plugin)
|
||||
@@ -633,6 +665,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
using var scope = _serviceProvider.CreateScope();
|
||||
var proxyService = scope.ServiceProvider.GetService<JellyfinProxyService>();
|
||||
var jellyfinSettings = scope.ServiceProvider.GetService<IOptions<JellyfinSettings>>()?.Value;
|
||||
var jellyfinModelMapper = scope.ServiceProvider.GetService<JellyfinModelMapper>();
|
||||
|
||||
if (proxyService != null && jellyfinSettings != null)
|
||||
{
|
||||
@@ -640,7 +673,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
{
|
||||
var userId = jellyfinSettings.UserId;
|
||||
var playlistItemsUrl = $"Playlists/{playlistConfig.JellyfinId}/Items";
|
||||
var queryParams = new Dictionary<string, string> { ["Fields"] = "ProviderIds" };
|
||||
var queryParams = new Dictionary<string, string> { ["Fields"] = CachedPlaylistItemFields };
|
||||
if (!string.IsNullOrEmpty(userId))
|
||||
{
|
||||
queryParams["UserId"] = userId;
|
||||
@@ -652,14 +685,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
{
|
||||
foreach (var item in items.EnumerateArray())
|
||||
{
|
||||
var song = new Song
|
||||
{
|
||||
Id = item.GetProperty("Id").GetString() ?? "",
|
||||
Title = item.GetProperty("Name").GetString() ?? "",
|
||||
Artist = item.TryGetProperty("AlbumArtist", out var artist) ? artist.GetString() ?? "" : "",
|
||||
Album = item.TryGetProperty("Album", out var album) ? album.GetString() ?? "" : "",
|
||||
IsLocal = true
|
||||
};
|
||||
var song = jellyfinModelMapper?.ParseSong(item) ?? CreateLocalSongSnapshot(item);
|
||||
jellyfinTracks.Add(song);
|
||||
}
|
||||
_logger.LogInformation("📚 Loaded {Count} tracks from Jellyfin playlist {Playlist}",
|
||||
@@ -748,11 +774,28 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
if (cancellationToken.IsCancellationRequested) break;
|
||||
|
||||
var batch = unmatchedSpotifyTracks.Skip(i).Take(BatchSize).ToList();
|
||||
var batchStart = i + 1;
|
||||
var batchEnd = i + batch.Count;
|
||||
var batchStopwatch = System.Diagnostics.Stopwatch.StartNew();
|
||||
|
||||
_logger.LogInformation(
|
||||
"Starting external matching batch for {Playlist}: tracks {Start}-{End}/{Total}",
|
||||
playlistName,
|
||||
batchStart,
|
||||
batchEnd,
|
||||
unmatchedSpotifyTracks.Count);
|
||||
|
||||
var batchTasks = batch.Select(async spotifyTrack =>
|
||||
{
|
||||
var primaryArtist = spotifyTrack.PrimaryArtist;
|
||||
var trackStopwatch = System.Diagnostics.Stopwatch.StartNew();
|
||||
|
||||
try
|
||||
{
|
||||
using var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
|
||||
timeoutCts.CancelAfter(ExternalProviderSearchTimeout);
|
||||
var trackCancellationToken = timeoutCts.Token;
|
||||
|
||||
var candidates = new List<(Song Song, double Score, string MatchType)>();
|
||||
|
||||
// Check global external mapping first
|
||||
@@ -764,12 +807,23 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
if (!string.IsNullOrEmpty(globalMapping.ExternalProvider) &&
|
||||
!string.IsNullOrEmpty(globalMapping.ExternalId))
|
||||
{
|
||||
mappedSong = await metadataService.GetSongAsync(globalMapping.ExternalProvider, globalMapping.ExternalId);
|
||||
mappedSong = await metadataService.GetSongAsync(
|
||||
globalMapping.ExternalProvider,
|
||||
globalMapping.ExternalId,
|
||||
trackCancellationToken);
|
||||
}
|
||||
|
||||
if (mappedSong != null)
|
||||
{
|
||||
candidates.Add((mappedSong, 100.0, "global-mapping-external"));
|
||||
trackStopwatch.Stop();
|
||||
_logger.LogDebug(
|
||||
"External candidate search finished for {Playlist} track #{Position}: {Title} by {Artist} in {ElapsedMs}ms using global mapping",
|
||||
playlistName,
|
||||
spotifyTrack.Position,
|
||||
spotifyTrack.Title,
|
||||
primaryArtist,
|
||||
trackStopwatch.ElapsedMilliseconds);
|
||||
return (spotifyTrack, candidates);
|
||||
}
|
||||
}
|
||||
@@ -777,10 +831,31 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
// Try ISRC match
|
||||
if (_spotifyApiSettings.PreferIsrcMatching && !string.IsNullOrEmpty(spotifyTrack.Isrc))
|
||||
{
|
||||
var isrcSong = await TryMatchByIsrcAsync(spotifyTrack.Isrc, metadataService);
|
||||
if (isrcSong != null)
|
||||
try
|
||||
{
|
||||
candidates.Add((isrcSong, 100.0, "isrc"));
|
||||
var isrcSong = await TryMatchByIsrcAsync(
|
||||
spotifyTrack.Isrc,
|
||||
metadataService,
|
||||
trackCancellationToken);
|
||||
|
||||
if (isrcSong != null)
|
||||
{
|
||||
candidates.Add((isrcSong, 100.0, "isrc"));
|
||||
}
|
||||
}
|
||||
catch (OperationCanceledException) when (!cancellationToken.IsCancellationRequested)
|
||||
{
|
||||
throw;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogWarning(
|
||||
ex,
|
||||
"ISRC lookup failed for {Playlist} track #{Position}: {Title} by {Artist}",
|
||||
playlistName,
|
||||
spotifyTrack.Position,
|
||||
spotifyTrack.Title,
|
||||
primaryArtist);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -788,7 +863,8 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
var fuzzySongs = await TryMatchByFuzzyMultipleAsync(
|
||||
spotifyTrack.Title,
|
||||
spotifyTrack.Artists,
|
||||
metadataService);
|
||||
metadataService,
|
||||
trackCancellationToken);
|
||||
|
||||
foreach (var (song, score) in fuzzySongs)
|
||||
{
|
||||
@@ -798,16 +874,48 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
}
|
||||
}
|
||||
|
||||
trackStopwatch.Stop();
|
||||
_logger.LogDebug(
|
||||
"External candidate search finished for {Playlist} track #{Position}: {Title} by {Artist} in {ElapsedMs}ms with {CandidateCount} candidates",
|
||||
playlistName,
|
||||
spotifyTrack.Position,
|
||||
spotifyTrack.Title,
|
||||
primaryArtist,
|
||||
trackStopwatch.ElapsedMilliseconds,
|
||||
candidates.Count);
|
||||
|
||||
return (spotifyTrack, candidates);
|
||||
}
|
||||
catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested)
|
||||
{
|
||||
return (spotifyTrack, new List<(Song, double, string)>());
|
||||
}
|
||||
catch (OperationCanceledException)
|
||||
{
|
||||
_logger.LogWarning(
|
||||
"External candidate search timed out for {Playlist} track #{Position}: {Title} by {Artist} after {TimeoutSeconds}s",
|
||||
playlistName,
|
||||
spotifyTrack.Position,
|
||||
spotifyTrack.Title,
|
||||
primaryArtist,
|
||||
ExternalProviderSearchTimeout.TotalSeconds);
|
||||
return (spotifyTrack, new List<(Song, double, string)>());
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Failed to match track: {Title}", spotifyTrack.Title);
|
||||
_logger.LogError(
|
||||
ex,
|
||||
"Failed to match track for {Playlist} track #{Position}: {Title} by {Artist}",
|
||||
playlistName,
|
||||
spotifyTrack.Position,
|
||||
spotifyTrack.Title,
|
||||
primaryArtist);
|
||||
return (spotifyTrack, new List<(Song, double, string)>());
|
||||
}
|
||||
}).ToList();
|
||||
|
||||
var batchResults = await Task.WhenAll(batchTasks);
|
||||
batchStopwatch.Stop();
|
||||
|
||||
foreach (var result in batchResults)
|
||||
{
|
||||
@@ -817,6 +925,16 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
}
|
||||
}
|
||||
|
||||
var batchCandidateCount = batchResults.Sum(result => result.Item2.Count);
|
||||
_logger.LogInformation(
|
||||
"Finished external matching batch for {Playlist}: tracks {Start}-{End}/{Total} in {ElapsedMs}ms ({CandidateCount} candidates)",
|
||||
playlistName,
|
||||
batchStart,
|
||||
batchEnd,
|
||||
unmatchedSpotifyTracks.Count,
|
||||
batchStopwatch.ElapsedMilliseconds,
|
||||
batchCandidateCount);
|
||||
|
||||
if (i + BatchSize < unmatchedSpotifyTracks.Count)
|
||||
{
|
||||
await Task.Delay(DelayBetweenSearchesMs, cancellationToken);
|
||||
@@ -989,140 +1107,136 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
private async Task<List<(Song Song, double Score)>> TryMatchByFuzzyMultipleAsync(
|
||||
string title,
|
||||
List<string> artists,
|
||||
IMusicMetadataService metadataService)
|
||||
IMusicMetadataService metadataService,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
try
|
||||
var primaryArtist = artists.FirstOrDefault() ?? "";
|
||||
var titleStripped = FuzzyMatcher.StripDecorators(title);
|
||||
var query = $"{titleStripped} {primaryArtist}";
|
||||
|
||||
var allCandidates = new List<(Song Song, double Score)>();
|
||||
|
||||
// STEP 1: Search LOCAL Jellyfin library FIRST
|
||||
using var scope = _serviceProvider.CreateScope();
|
||||
var proxyService = scope.ServiceProvider.GetService<JellyfinProxyService>();
|
||||
if (proxyService != null)
|
||||
{
|
||||
var primaryArtist = artists.FirstOrDefault() ?? "";
|
||||
var titleStripped = FuzzyMatcher.StripDecorators(title);
|
||||
var query = $"{titleStripped} {primaryArtist}";
|
||||
|
||||
var allCandidates = new List<(Song Song, double Score)>();
|
||||
|
||||
// STEP 1: Search LOCAL Jellyfin library FIRST
|
||||
using var scope = _serviceProvider.CreateScope();
|
||||
var proxyService = scope.ServiceProvider.GetService<JellyfinProxyService>();
|
||||
if (proxyService != null)
|
||||
try
|
||||
{
|
||||
try
|
||||
// Search Jellyfin for local tracks
|
||||
var searchParams = new Dictionary<string, string>
|
||||
{
|
||||
// Search Jellyfin for local tracks
|
||||
var searchParams = new Dictionary<string, string>
|
||||
{
|
||||
["searchTerm"] = query,
|
||||
["includeItemTypes"] = "Audio",
|
||||
["recursive"] = "true",
|
||||
["limit"] = "10"
|
||||
};
|
||||
["searchTerm"] = query,
|
||||
["includeItemTypes"] = "Audio",
|
||||
["recursive"] = "true",
|
||||
["limit"] = "10"
|
||||
};
|
||||
|
||||
var (searchResponse, _) = await proxyService.GetJsonAsyncInternal("Items", searchParams);
|
||||
var (searchResponse, _) = await proxyService.GetJsonAsyncInternal("Items", searchParams);
|
||||
|
||||
if (searchResponse != null && searchResponse.RootElement.TryGetProperty("Items", out var items))
|
||||
if (searchResponse != null && searchResponse.RootElement.TryGetProperty("Items", out var items))
|
||||
{
|
||||
var localResults = new List<Song>();
|
||||
foreach (var item in items.EnumerateArray())
|
||||
{
|
||||
var localResults = new List<Song>();
|
||||
foreach (var item in items.EnumerateArray())
|
||||
var id = item.TryGetProperty("Id", out var idEl) ? idEl.GetString() ?? "" : "";
|
||||
var songTitle = item.TryGetProperty("Name", out var nameEl) ? nameEl.GetString() ?? "" : "";
|
||||
var artist = "";
|
||||
|
||||
if (item.TryGetProperty("Artists", out var artistsEl) && artistsEl.GetArrayLength() > 0)
|
||||
{
|
||||
var id = item.TryGetProperty("Id", out var idEl) ? idEl.GetString() ?? "" : "";
|
||||
var songTitle = item.TryGetProperty("Name", out var nameEl) ? nameEl.GetString() ?? "" : "";
|
||||
var artist = "";
|
||||
|
||||
if (item.TryGetProperty("Artists", out var artistsEl) && artistsEl.GetArrayLength() > 0)
|
||||
{
|
||||
artist = artistsEl[0].GetString() ?? "";
|
||||
}
|
||||
else if (item.TryGetProperty("AlbumArtist", out var albumArtistEl))
|
||||
{
|
||||
artist = albumArtistEl.GetString() ?? "";
|
||||
}
|
||||
|
||||
localResults.Add(new Song
|
||||
{
|
||||
Id = id,
|
||||
Title = songTitle,
|
||||
Artist = artist,
|
||||
IsLocal = true
|
||||
});
|
||||
artist = artistsEl[0].GetString() ?? "";
|
||||
}
|
||||
else if (item.TryGetProperty("AlbumArtist", out var albumArtistEl))
|
||||
{
|
||||
artist = albumArtistEl.GetString() ?? "";
|
||||
}
|
||||
|
||||
if (localResults.Count > 0)
|
||||
localResults.Add(new Song
|
||||
{
|
||||
// Score local results
|
||||
var scoredLocal = localResults
|
||||
.Select(song => new
|
||||
{
|
||||
Song = song,
|
||||
TitleScore = FuzzyMatcher.CalculateSimilarityAggressive(title, song.Title),
|
||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(artists, song.Artist, song.Contributors)
|
||||
})
|
||||
.Select(x => new
|
||||
{
|
||||
x.Song,
|
||||
x.TitleScore,
|
||||
x.ArtistScore,
|
||||
TotalScore = (x.TitleScore * 0.7) + (x.ArtistScore * 0.3)
|
||||
})
|
||||
.Where(x =>
|
||||
x.TotalScore >= 40 ||
|
||||
(x.ArtistScore >= 70 && x.TitleScore >= 30) ||
|
||||
x.TitleScore >= 85)
|
||||
.OrderByDescending(x => x.TotalScore)
|
||||
.Select(x => (x.Song, x.TotalScore))
|
||||
.ToList();
|
||||
Id = id,
|
||||
Title = songTitle,
|
||||
Artist = artist,
|
||||
IsLocal = true
|
||||
});
|
||||
}
|
||||
|
||||
allCandidates.AddRange(scoredLocal);
|
||||
|
||||
// If we found good local matches, return them (don't search external)
|
||||
if (scoredLocal.Any(x => x.TotalScore >= 70))
|
||||
if (localResults.Count > 0)
|
||||
{
|
||||
// Score local results
|
||||
var scoredLocal = localResults
|
||||
.Select(song => new
|
||||
{
|
||||
_logger.LogDebug("Found {Count} local matches for '{Title}', skipping external search",
|
||||
scoredLocal.Count, title);
|
||||
return allCandidates;
|
||||
}
|
||||
Song = song,
|
||||
TitleScore = FuzzyMatcher.CalculateSimilarityAggressive(title, song.Title),
|
||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(artists, song.Artist, song.Contributors)
|
||||
})
|
||||
.Select(x => new
|
||||
{
|
||||
x.Song,
|
||||
x.TitleScore,
|
||||
x.ArtistScore,
|
||||
TotalScore = (x.TitleScore * 0.7) + (x.ArtistScore * 0.3)
|
||||
})
|
||||
.Where(x =>
|
||||
x.TotalScore >= 40 ||
|
||||
(x.ArtistScore >= 70 && x.TitleScore >= 30) ||
|
||||
x.TitleScore >= 85)
|
||||
.OrderByDescending(x => x.TotalScore)
|
||||
.Select(x => (x.Song, x.TotalScore))
|
||||
.ToList();
|
||||
|
||||
allCandidates.AddRange(scoredLocal);
|
||||
|
||||
// If we found good local matches, return them (don't search external)
|
||||
if (scoredLocal.Any(x => x.TotalScore >= 70))
|
||||
{
|
||||
_logger.LogDebug("Found {Count} local matches for '{Title}', skipping external search",
|
||||
scoredLocal.Count, title);
|
||||
return allCandidates;
|
||||
}
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogWarning(ex, "Failed to search local library for '{Title}'", title);
|
||||
}
|
||||
}
|
||||
|
||||
// STEP 2: Only search EXTERNAL if no good local match found
|
||||
var externalResults = await metadataService.SearchSongsAsync(query, limit: 10);
|
||||
|
||||
if (externalResults.Count > 0)
|
||||
catch (Exception ex)
|
||||
{
|
||||
var scoredExternal = externalResults
|
||||
.Select(song => new
|
||||
{
|
||||
Song = song,
|
||||
TitleScore = FuzzyMatcher.CalculateSimilarityAggressive(title, song.Title),
|
||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(artists, song.Artist, song.Contributors)
|
||||
})
|
||||
.Select(x => new
|
||||
{
|
||||
x.Song,
|
||||
x.TitleScore,
|
||||
x.ArtistScore,
|
||||
TotalScore = (x.TitleScore * 0.7) + (x.ArtistScore * 0.3)
|
||||
})
|
||||
.Where(x =>
|
||||
x.TotalScore >= 40 ||
|
||||
(x.ArtistScore >= 70 && x.TitleScore >= 30) ||
|
||||
x.TitleScore >= 85)
|
||||
.OrderByDescending(x => x.TotalScore)
|
||||
.Select(x => (x.Song, x.TotalScore))
|
||||
.ToList();
|
||||
|
||||
allCandidates.AddRange(scoredExternal);
|
||||
_logger.LogWarning(ex, "Failed to search local library for '{Title}'", title);
|
||||
}
|
||||
}
|
||||
|
||||
return allCandidates;
|
||||
}
|
||||
catch
|
||||
cancellationToken.ThrowIfCancellationRequested();
|
||||
|
||||
// STEP 2: Only search EXTERNAL if no good local match found
|
||||
var externalResults = await metadataService.SearchSongsAsync(query, limit: 10, cancellationToken);
|
||||
|
||||
if (externalResults.Count > 0)
|
||||
{
|
||||
return new List<(Song, double)>();
|
||||
var scoredExternal = externalResults
|
||||
.Select(song => new
|
||||
{
|
||||
Song = song,
|
||||
TitleScore = FuzzyMatcher.CalculateSimilarityAggressive(title, song.Title),
|
||||
ArtistScore = FuzzyMatcher.CalculateArtistMatchScore(artists, song.Artist, song.Contributors)
|
||||
})
|
||||
.Select(x => new
|
||||
{
|
||||
x.Song,
|
||||
x.TitleScore,
|
||||
x.ArtistScore,
|
||||
TotalScore = (x.TitleScore * 0.7) + (x.ArtistScore * 0.3)
|
||||
})
|
||||
.Where(x =>
|
||||
x.TotalScore >= 40 ||
|
||||
(x.ArtistScore >= 70 && x.TitleScore >= 30) ||
|
||||
x.TitleScore >= 85)
|
||||
.OrderByDescending(x => x.TotalScore)
|
||||
.Select(x => (x.Song, x.TotalScore))
|
||||
.ToList();
|
||||
|
||||
allCandidates.AddRange(scoredExternal);
|
||||
}
|
||||
|
||||
return allCandidates;
|
||||
}
|
||||
|
||||
private double CalculateMatchScore(string jellyfinTitle, string jellyfinArtist, string spotifyTitle, string spotifyArtist)
|
||||
@@ -1136,33 +1250,19 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
/// Attempts to match a track by ISRC.
|
||||
/// SEARCHES LOCAL FIRST, then external if no local match found.
|
||||
/// </summary>
|
||||
private async Task<Song?> TryMatchByIsrcAsync(string isrc, IMusicMetadataService metadataService)
|
||||
private async Task<Song?> TryMatchByIsrcAsync(
|
||||
string isrc,
|
||||
IMusicMetadataService metadataService,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
try
|
||||
{
|
||||
// STEP 1: Search LOCAL Jellyfin library FIRST by ISRC
|
||||
// Note: Jellyfin doesn't have ISRC search, so we skip local ISRC search
|
||||
// Local tracks will be found via fuzzy matching instead
|
||||
// STEP 1: Search LOCAL Jellyfin library FIRST by ISRC
|
||||
// Note: Jellyfin doesn't have ISRC search, so we skip local ISRC search
|
||||
// Local tracks will be found via fuzzy matching instead
|
||||
|
||||
// STEP 2: Search EXTERNAL by ISRC
|
||||
var results = await metadataService.SearchSongsAsync($"isrc:{isrc}", limit: 1);
|
||||
if (results.Count > 0 && results[0].Isrc == isrc)
|
||||
{
|
||||
return results[0];
|
||||
}
|
||||
cancellationToken.ThrowIfCancellationRequested();
|
||||
|
||||
// Some providers may not support isrc: prefix, try without
|
||||
results = await metadataService.SearchSongsAsync(isrc, limit: 5);
|
||||
var exactMatch = results.FirstOrDefault(r =>
|
||||
!string.IsNullOrEmpty(r.Isrc) &&
|
||||
r.Isrc.Equals(isrc, StringComparison.OrdinalIgnoreCase));
|
||||
|
||||
return exactMatch;
|
||||
}
|
||||
catch
|
||||
{
|
||||
return null;
|
||||
}
|
||||
// STEP 2: Search EXTERNAL by ISRC
|
||||
return await metadataService.FindSongByIsrcAsync(isrc, cancellationToken);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -1399,7 +1499,7 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
}
|
||||
|
||||
// Request all fields that clients typically need (not just MediaSources)
|
||||
var playlistItemsUrl = $"Playlists/{jellyfinPlaylistId}/Items?UserId={userId}&Fields=Genres,DateCreated,MediaSources,ParentId,People,Tags,SortName,ProviderIds";
|
||||
var playlistItemsUrl = $"Playlists/{jellyfinPlaylistId}/Items?UserId={userId}&Fields={CachedPlaylistItemFields}";
|
||||
var (existingTracksResponse, statusCode) = await proxyService.GetJsonAsync(playlistItemsUrl, null, headers);
|
||||
|
||||
if (statusCode != 200 || existingTracksResponse == null)
|
||||
@@ -1901,4 +2001,39 @@ public class SpotifyTrackMatchingService : BackgroundService
|
||||
_logger.LogError(ex, "Failed to save matched tracks to file for {Playlist}", playlistName);
|
||||
}
|
||||
}
|
||||
|
||||
private static Song CreateLocalSongSnapshot(JsonElement item)
|
||||
{
|
||||
var runTimeTicks = item.TryGetProperty("RunTimeTicks", out var rtt) ? rtt.GetInt64() : 0;
|
||||
var song = new Song
|
||||
{
|
||||
Id = item.TryGetProperty("Id", out var idEl) ? idEl.GetString() ?? "" : "",
|
||||
Title = item.TryGetProperty("Name", out var name) ? name.GetString() ?? "" : "",
|
||||
Album = item.TryGetProperty("Album", out var album) ? album.GetString() ?? "" : "",
|
||||
AlbumId = item.TryGetProperty("AlbumId", out var albumId) ? albumId.GetString() : null,
|
||||
Duration = (int)(runTimeTicks / TimeSpan.TicksPerSecond),
|
||||
Track = item.TryGetProperty("IndexNumber", out var track) ? track.GetInt32() : null,
|
||||
DiscNumber = item.TryGetProperty("ParentIndexNumber", out var disc) ? disc.GetInt32() : null,
|
||||
Year = item.TryGetProperty("ProductionYear", out var year) ? year.GetInt32() : null,
|
||||
IsLocal = true
|
||||
};
|
||||
|
||||
if (item.TryGetProperty("Artists", out var artists) && artists.GetArrayLength() > 0)
|
||||
{
|
||||
song.Artist = artists[0].GetString() ?? "";
|
||||
}
|
||||
else if (item.TryGetProperty("AlbumArtist", out var albumArtist))
|
||||
{
|
||||
song.Artist = albumArtist.GetString() ?? "";
|
||||
}
|
||||
|
||||
JellyfinItemSnapshotHelper.StoreRawItemSnapshot(song, item);
|
||||
song.JellyfinMetadata ??= new Dictionary<string, object?>();
|
||||
if (item.TryGetProperty("MediaSources", out var mediaSources))
|
||||
{
|
||||
song.JellyfinMetadata["MediaSources"] = JsonSerializer.Deserialize<object>(mediaSources.GetRawText());
|
||||
}
|
||||
|
||||
return song;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -81,6 +81,7 @@ public class SquidWTFDownloadService : BaseDownloadService
|
||||
|
||||
// Increase timeout for large downloads and slow endpoints
|
||||
_httpClient.Timeout = TimeSpan.FromMinutes(5);
|
||||
_minRequestIntervalMs = _squidwtfSettings.MinRequestIntervalMs;
|
||||
}
|
||||
|
||||
|
||||
@@ -96,220 +97,312 @@ public class SquidWTFDownloadService : BaseDownloadService
|
||||
}
|
||||
|
||||
|
||||
private async Task<string> RunDownloadWithFallbackAsync(string trackId, Song song, string quality, string basePath, CancellationToken cancellationToken)
|
||||
{
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async baseUrl =>
|
||||
{
|
||||
var songId = BuildTrackedSongId(trackId);
|
||||
var downloadInfo = await FetchTrackDownloadInfoAsync(baseUrl, trackId, quality, cancellationToken);
|
||||
|
||||
Logger.LogInformation(
|
||||
"Track download info resolved via {Endpoint} (Format: {Format}, Quality: {Quality})",
|
||||
downloadInfo.Endpoint, downloadInfo.MimeType, downloadInfo.AudioQuality);
|
||||
Logger.LogDebug("Resolved SquidWTF CDN download URL: {Url}", downloadInfo.DownloadUrl);
|
||||
|
||||
var extension = downloadInfo.MimeType?.ToLower() switch
|
||||
{
|
||||
"audio/flac" => ".flac", "audio/mpeg" => ".mp3", "audio/mp4" => ".m4a", _ => ".flac"
|
||||
};
|
||||
|
||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension, "squidwtf", trackId);
|
||||
|
||||
var albumFolder = Path.GetDirectoryName(outputPath)!;
|
||||
EnsureDirectoryExists(albumFolder);
|
||||
|
||||
if (basePath.EndsWith("transcoded") && IOFile.Exists(outputPath))
|
||||
{
|
||||
IOFile.SetLastWriteTime(outputPath, DateTime.UtcNow);
|
||||
Logger.LogInformation("Quality override cache hit: {Path}", outputPath);
|
||||
return outputPath;
|
||||
}
|
||||
|
||||
outputPath = PathHelper.ResolveUniquePath(outputPath);
|
||||
|
||||
using var req = new HttpRequestMessage(HttpMethod.Get, downloadInfo.DownloadUrl);
|
||||
req.Headers.Add("User-Agent", "Mozilla/5.0");
|
||||
req.Headers.Add("Accept", "*/*");
|
||||
var res = await _httpClient.SendAsync(req, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
res.EnsureSuccessStatusCode();
|
||||
|
||||
await using var responseStream = await res.Content.ReadAsStreamAsync(cancellationToken);
|
||||
await using var outputFile = IOFile.Create(outputPath);
|
||||
var totalBytes = res.Content.Headers.ContentLength;
|
||||
var buffer = new byte[81920];
|
||||
long totalBytesRead = 0;
|
||||
|
||||
while (true)
|
||||
{
|
||||
var bytesRead = await responseStream.ReadAsync(buffer.AsMemory(0, buffer.Length), cancellationToken);
|
||||
if (bytesRead <= 0)
|
||||
{
|
||||
break;
|
||||
}
|
||||
|
||||
await outputFile.WriteAsync(buffer.AsMemory(0, bytesRead), cancellationToken);
|
||||
totalBytesRead += bytesRead;
|
||||
|
||||
if (totalBytes.HasValue && totalBytes.Value > 0)
|
||||
{
|
||||
SetDownloadProgress(songId, (double)totalBytesRead / totalBytes.Value);
|
||||
}
|
||||
}
|
||||
|
||||
await outputFile.DisposeAsync();
|
||||
SetDownloadProgress(songId, 1.0);
|
||||
|
||||
_ = Task.Run(async () =>
|
||||
{
|
||||
try
|
||||
{
|
||||
var spotifyId = await _odesliService.ConvertTidalToSpotifyIdAsync(trackId, CancellationToken.None);
|
||||
if (!string.IsNullOrEmpty(spotifyId))
|
||||
{
|
||||
Logger.LogDebug("Background Spotify ID obtained for Tidal/{TrackId}: {SpotifyId}", trackId, spotifyId);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
Logger.LogDebug(ex, "Background Spotify ID conversion failed for Tidal/{TrackId}", trackId);
|
||||
}
|
||||
});
|
||||
|
||||
await WriteMetadataAsync(outputPath, song, cancellationToken);
|
||||
return outputPath;
|
||||
});
|
||||
}
|
||||
|
||||
protected override async Task<string> DownloadTrackAsync(string trackId, Song song, CancellationToken cancellationToken)
|
||||
{
|
||||
var downloadInfo = await GetTrackDownloadInfoAsync(trackId, cancellationToken);
|
||||
|
||||
Logger.LogInformation("Track download URL obtained from hifi-api: {Url}", downloadInfo.DownloadUrl);
|
||||
Logger.LogInformation("Using format: {Format} (Quality: {Quality})", downloadInfo.MimeType, downloadInfo.AudioQuality);
|
||||
|
||||
// Determine extension from MIME type
|
||||
var extension = downloadInfo.MimeType?.ToLower() switch
|
||||
return await QueueRequestAsync(async () =>
|
||||
{
|
||||
"audio/flac" => ".flac",
|
||||
"audio/mpeg" => ".mp3",
|
||||
"audio/mp4" => ".m4a",
|
||||
_ => ".flac" // Default to FLAC
|
||||
};
|
||||
|
||||
// Build organized folder structure: Artist/Album/Track using AlbumArtist (fallback to Artist for singles)
|
||||
var artistForPath = song.AlbumArtist ?? song.Artist;
|
||||
// Cache mode uses downloads/cache/ folder, Permanent mode uses downloads/permanent/
|
||||
var basePath = SubsonicSettings.StorageMode == StorageMode.Cache
|
||||
? Path.Combine("downloads", "cache")
|
||||
: Path.Combine("downloads", "permanent");
|
||||
var outputPath = PathHelper.BuildTrackPath(basePath, artistForPath, song.Album, song.Title, song.Track, extension, "squidwtf", trackId);
|
||||
|
||||
// Create directories if they don't exist
|
||||
var albumFolder = Path.GetDirectoryName(outputPath)!;
|
||||
EnsureDirectoryExists(albumFolder);
|
||||
|
||||
// Resolve unique path if file already exists
|
||||
outputPath = PathHelper.ResolveUniquePath(outputPath);
|
||||
Exception? lastException = null;
|
||||
var qualityOrder = BuildQualityFallbackOrder(_squidwtfSettings.Quality);
|
||||
var basePath = CurrentStorageMode == StorageMode.Cache
|
||||
? Path.Combine(DownloadPath, "cache") : Path.Combine(DownloadPath, "permanent");
|
||||
|
||||
// Use round-robin with fallback for downloads to reduce CPU usage
|
||||
Logger.LogDebug("Using round-robin endpoint selection for download");
|
||||
|
||||
var response = await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Map quality settings to Tidal's quality levels per hifi-api spec
|
||||
var quality = _squidwtfSettings.Quality?.ToUpperInvariant() switch
|
||||
foreach (var quality in qualityOrder)
|
||||
{
|
||||
"FLAC" => "LOSSLESS",
|
||||
"HI_RES" => "HI_RES_LOSSLESS",
|
||||
"LOSSLESS" => "LOSSLESS",
|
||||
"HIGH" => "HIGH",
|
||||
"LOW" => "LOW",
|
||||
_ => "LOSSLESS"
|
||||
};
|
||||
|
||||
var url = $"{baseUrl}/track/?id={trackId}&quality={quality}";
|
||||
|
||||
Logger.LogDebug("Requesting track download info: {Url}", url);
|
||||
|
||||
// Get download info from this endpoint
|
||||
var infoResponse = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!infoResponse.IsSuccessStatusCode)
|
||||
{
|
||||
Logger.LogWarning("Track download request failed: {StatusCode} {Url}", infoResponse.StatusCode, url);
|
||||
infoResponse.EnsureSuccessStatusCode();
|
||||
try
|
||||
{
|
||||
return await RunDownloadWithFallbackAsync(trackId, song, quality, basePath, cancellationToken);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
lastException = ex;
|
||||
if (!string.Equals(quality, qualityOrder[^1], StringComparison.Ordinal))
|
||||
{
|
||||
Logger.LogWarning("Track {TrackId} unavailable at SquidWTF quality {Quality}: {Error}. Trying lower quality", trackId, quality, DescribeException(ex));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
var json = await infoResponse.Content.ReadAsStringAsync(cancellationToken);
|
||||
var doc = JsonDocument.Parse(json);
|
||||
|
||||
if (!doc.RootElement.TryGetProperty("data", out var data))
|
||||
{
|
||||
throw new Exception("Invalid response from API");
|
||||
}
|
||||
|
||||
var manifestBase64 = data.GetProperty("manifest").GetString()
|
||||
?? throw new Exception("No manifest in response");
|
||||
|
||||
// Decode base64 manifest to get actual CDN URL
|
||||
var manifestJson = Encoding.UTF8.GetString(Convert.FromBase64String(manifestBase64));
|
||||
var manifest = JsonDocument.Parse(manifestJson);
|
||||
|
||||
if (!manifest.RootElement.TryGetProperty("urls", out var urls) || urls.GetArrayLength() == 0)
|
||||
{
|
||||
throw new Exception("No download URLs in manifest");
|
||||
}
|
||||
|
||||
var downloadUrl = urls[0].GetString()
|
||||
?? throw new Exception("Download URL is null");
|
||||
|
||||
// Start the actual download from Tidal CDN (no encryption - squid.wtf handles everything)
|
||||
using var request = new HttpRequestMessage(HttpMethod.Get, downloadUrl);
|
||||
request.Headers.Add("User-Agent", "Mozilla/5.0");
|
||||
request.Headers.Add("Accept", "*/*");
|
||||
|
||||
return await _httpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
|
||||
throw lastException ?? new Exception($"Unable to download track {trackId}");
|
||||
});
|
||||
|
||||
response.EnsureSuccessStatusCode();
|
||||
|
||||
// Download directly (no decryption needed - squid.wtf handles everything)
|
||||
await using var responseStream = await response.Content.ReadAsStreamAsync(cancellationToken);
|
||||
await using var outputFile = IOFile.Create(outputPath);
|
||||
|
||||
await responseStream.CopyToAsync(outputFile, cancellationToken);
|
||||
|
||||
// Close file before writing metadata
|
||||
await outputFile.DisposeAsync();
|
||||
|
||||
// Start Spotify ID conversion in background (for lyrics support)
|
||||
// This doesn't block streaming - lyrics endpoint will fetch it on-demand if needed
|
||||
_ = Task.Run(async () =>
|
||||
{
|
||||
try
|
||||
{
|
||||
var spotifyId = await _odesliService.ConvertTidalToSpotifyIdAsync(trackId, CancellationToken.None);
|
||||
if (!string.IsNullOrEmpty(spotifyId))
|
||||
{
|
||||
Logger.LogDebug("Background Spotify ID obtained for Tidal/{TrackId}: {SpotifyId}", trackId, spotifyId);
|
||||
// Spotify ID is cached by Odesli service for future lyrics requests
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
Logger.LogDebug(ex, "Background Spotify ID conversion failed for Tidal/{TrackId}", trackId);
|
||||
}
|
||||
});
|
||||
|
||||
// Write metadata and cover art (without Spotify ID - it's only needed for lyrics)
|
||||
await WriteMetadataAsync(outputPath, song, cancellationToken);
|
||||
|
||||
return outputPath;
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
#region SquidWTF API Methods
|
||||
|
||||
#region Quality Override Support
|
||||
|
||||
/// <summary>
|
||||
/// Gets track download information from hifi-api /track/ endpoint.
|
||||
/// Per hifi-api spec: GET /track/?id={trackId}&quality={quality}
|
||||
/// Returns: { "version": "2.0", "data": { trackId, assetPresentation, audioMode, audioQuality,
|
||||
/// manifestMimeType, manifestHash, manifest (base64), albumReplayGain, trackReplayGain, bitDepth, sampleRate } }
|
||||
/// The manifest is base64-encoded JSON containing: { mimeType, codecs, encryptionType, urls: [downloadUrl] }
|
||||
/// Quality options: HI_RES_LOSSLESS (24-bit/192kHz FLAC), LOSSLESS (16-bit/44.1kHz FLAC), HIGH (320kbps AAC), LOW (96kbps AAC)
|
||||
/// Downloads a track at a specific quality tier, capped at the .env quality ceiling.
|
||||
/// The .env quality is the maximum — client requests can only go equal or lower.
|
||||
///
|
||||
/// Quality hierarchy (highest to lowest): HI_RES_LOSSLESS > LOSSLESS > HIGH > LOW
|
||||
///
|
||||
/// Examples:
|
||||
/// env=HI_RES_LOSSLESS: Original→HI_RES_LOSSLESS, High→HIGH, Low→LOW
|
||||
/// env=LOSSLESS: Original→LOSSLESS, High→HIGH, Low→LOW
|
||||
/// env=HIGH: Original→HIGH, High→HIGH, Low→LOW
|
||||
/// env=LOW: Original→LOW, High→LOW, Low→LOW
|
||||
/// </summary>
|
||||
private async Task<DownloadResult> GetTrackDownloadInfoAsync(string trackId, CancellationToken cancellationToken)
|
||||
protected override async Task<string> DownloadTrackWithQualityAsync(
|
||||
string trackId, Song song, StreamQuality quality, CancellationToken cancellationToken)
|
||||
{
|
||||
if (quality == StreamQuality.Original)
|
||||
{
|
||||
return await DownloadTrackAsync(trackId, song, cancellationToken);
|
||||
}
|
||||
|
||||
// Map StreamQuality to SquidWTF quality string, capped at .env ceiling
|
||||
var envQuality = NormalizeSquidWTFQuality(_squidwtfSettings.Quality);
|
||||
var squidQuality = MapStreamQualityToSquidWTF(quality, envQuality);
|
||||
|
||||
Logger.LogInformation(
|
||||
"Quality override: StreamQuality.{Quality} → SquidWTF quality '{SquidQuality}' (env ceiling: {EnvQuality}) for track {TrackId}",
|
||||
quality, squidQuality, envQuality, trackId);
|
||||
|
||||
var basePath = Path.Combine("downloads", "transcoded");
|
||||
|
||||
return await QueueRequestAsync(async () =>
|
||||
{
|
||||
// Use round-robin with fallback instead of racing to reduce CPU usage
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Map quality settings to Tidal's quality levels per hifi-api spec
|
||||
var quality = _squidwtfSettings.Quality?.ToUpperInvariant() switch
|
||||
{
|
||||
"FLAC" => "LOSSLESS",
|
||||
"HI_RES" => "HI_RES_LOSSLESS",
|
||||
"LOSSLESS" => "LOSSLESS",
|
||||
"HIGH" => "HIGH",
|
||||
"LOW" => "LOW",
|
||||
_ => "LOSSLESS" // Default to lossless
|
||||
};
|
||||
|
||||
var url = $"{baseUrl}/track/?id={trackId}&quality={quality}";
|
||||
|
||||
Logger.LogDebug("Fetching track download info from: {Url}", url);
|
||||
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
Logger.LogWarning("Track download info request failed: {StatusCode} {Url}", response.StatusCode, url);
|
||||
response.EnsureSuccessStatusCode();
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var doc = JsonDocument.Parse(json);
|
||||
|
||||
if (!doc.RootElement.TryGetProperty("data", out var data))
|
||||
{
|
||||
throw new Exception("Invalid response from API");
|
||||
}
|
||||
|
||||
// Get the manifest (base64 encoded JSON containing the actual CDN URL)
|
||||
var manifestBase64 = data.GetProperty("manifest").GetString()
|
||||
?? throw new Exception("No manifest in response");
|
||||
|
||||
// Decode the manifest
|
||||
var manifestJson = Encoding.UTF8.GetString(Convert.FromBase64String(manifestBase64));
|
||||
var manifest = JsonDocument.Parse(manifestJson);
|
||||
|
||||
// Extract the download URL from the manifest
|
||||
if (!manifest.RootElement.TryGetProperty("urls", out var urls) || urls.GetArrayLength() == 0)
|
||||
{
|
||||
throw new Exception("No download URLs in manifest");
|
||||
}
|
||||
|
||||
var downloadUrl = urls[0].GetString()
|
||||
?? throw new Exception("Download URL is null");
|
||||
|
||||
var mimeType = manifest.RootElement.TryGetProperty("mimeType", out var mimeTypeEl)
|
||||
? mimeTypeEl.GetString()
|
||||
: "audio/flac";
|
||||
|
||||
var audioQuality = data.TryGetProperty("audioQuality", out var audioQualityEl)
|
||||
? audioQualityEl.GetString()
|
||||
: "LOSSLESS";
|
||||
|
||||
Logger.LogInformation("Track download URL obtained from hifi-api: {Url}", downloadUrl);
|
||||
|
||||
return new DownloadResult
|
||||
{
|
||||
DownloadUrl = downloadUrl,
|
||||
MimeType = mimeType ?? "audio/flac",
|
||||
AudioQuality = audioQuality ?? "LOSSLESS"
|
||||
};
|
||||
});
|
||||
return await RunDownloadWithFallbackAsync(trackId, song, squidQuality, basePath, cancellationToken);
|
||||
});
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Normalizes the .env quality string to a standard SquidWTF quality level.
|
||||
/// Maps various aliases (HI_RES, FLAC, etc.) to canonical names.
|
||||
/// </summary>
|
||||
private static string NormalizeSquidWTFQuality(string? quality)
|
||||
{
|
||||
if (string.IsNullOrEmpty(quality)) return "LOSSLESS";
|
||||
|
||||
return quality.ToUpperInvariant() switch
|
||||
{
|
||||
"HI_RES" or "HI_RES_LOSSLESS" => "HI_RES_LOSSLESS",
|
||||
"FLAC" or "LOSSLESS" => "LOSSLESS",
|
||||
"HIGH" => "HIGH",
|
||||
"LOW" => "LOW",
|
||||
_ => "LOSSLESS"
|
||||
};
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Maps a StreamQuality tier to a SquidWTF quality string, capped at the .env ceiling.
|
||||
/// The .env quality is the maximum — client requests can only go equal or lower.
|
||||
/// </summary>
|
||||
private static string MapStreamQualityToSquidWTF(StreamQuality streamQuality, string envQuality)
|
||||
{
|
||||
// Quality ranking from highest to lowest
|
||||
var ranking = new[] { "HI_RES_LOSSLESS", "LOSSLESS", "HIGH", "LOW" };
|
||||
var envIndex = Array.IndexOf(ranking, envQuality);
|
||||
if (envIndex < 0) envIndex = 1; // Default to LOSSLESS if unknown
|
||||
|
||||
// Map StreamQuality to the "ideal" SquidWTF quality
|
||||
var idealQuality = streamQuality switch
|
||||
{
|
||||
StreamQuality.Original => envQuality, // Lossless client selection → use .env setting
|
||||
StreamQuality.High => "HIGH", // 320/256/192K → HIGH (320kbps AAC)
|
||||
StreamQuality.Low => "LOW", // 128/64K → LOW (96kbps AAC)
|
||||
_ => envQuality
|
||||
};
|
||||
|
||||
// Cap: if the ideal quality is higher than env, clamp down to env
|
||||
// Lower array index = higher quality
|
||||
var idealIndex = Array.IndexOf(ranking, idealQuality);
|
||||
if (idealIndex < 0) idealIndex = envIndex;
|
||||
|
||||
if (idealIndex < envIndex)
|
||||
{
|
||||
return envQuality;
|
||||
}
|
||||
|
||||
return idealQuality;
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
#region SquidWTF API Methods
|
||||
|
||||
// Removed GetTrackDownloadInfoAsync as it's now integrated inside RunDownloadWithFallbackAsync
|
||||
|
||||
private async Task<DownloadResult> FetchTrackDownloadInfoAsync(
|
||||
string baseUrl,
|
||||
string trackId,
|
||||
string quality,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
var url = $"{baseUrl}/track/?id={trackId}&quality={quality}";
|
||||
|
||||
Logger.LogDebug("Fetching track download info from: {Url}", url);
|
||||
|
||||
using var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
response.EnsureSuccessStatusCode();
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
using var doc = JsonDocument.Parse(json);
|
||||
|
||||
if (!doc.RootElement.TryGetProperty("data", out var data))
|
||||
{
|
||||
throw new Exception("Invalid response from API");
|
||||
}
|
||||
|
||||
// Get the manifest (base64 encoded JSON containing the actual CDN URL)
|
||||
var manifestBase64 = data.GetProperty("manifest").GetString()
|
||||
?? throw new Exception("No manifest in response");
|
||||
|
||||
// Decode the manifest
|
||||
var manifestJson = Encoding.UTF8.GetString(Convert.FromBase64String(manifestBase64));
|
||||
using var manifest = JsonDocument.Parse(manifestJson);
|
||||
|
||||
// Extract the download URL from the manifest
|
||||
if (!manifest.RootElement.TryGetProperty("urls", out var urls) || urls.GetArrayLength() == 0)
|
||||
{
|
||||
throw new Exception("No download URLs in manifest");
|
||||
}
|
||||
|
||||
var downloadUrl = urls[0].GetString()
|
||||
?? throw new Exception("Download URL is null");
|
||||
|
||||
var mimeType = manifest.RootElement.TryGetProperty("mimeType", out var mimeTypeEl)
|
||||
? mimeTypeEl.GetString()
|
||||
: "audio/flac";
|
||||
|
||||
var audioQuality = data.TryGetProperty("audioQuality", out var audioQualityEl)
|
||||
? audioQualityEl.GetString()
|
||||
: quality;
|
||||
|
||||
return new DownloadResult
|
||||
{
|
||||
Endpoint = baseUrl,
|
||||
DownloadUrl = downloadUrl,
|
||||
MimeType = mimeType ?? "audio/flac",
|
||||
AudioQuality = audioQuality ?? quality
|
||||
};
|
||||
}
|
||||
|
||||
private static IReadOnlyList<string> BuildQualityFallbackOrder(string? configuredQuality)
|
||||
{
|
||||
return NormalizeQuality(configuredQuality) switch
|
||||
{
|
||||
"HI_RES_LOSSLESS" => ["HI_RES_LOSSLESS", "LOSSLESS", "HIGH", "LOW"],
|
||||
"LOSSLESS" => ["LOSSLESS", "HIGH", "LOW"],
|
||||
"HIGH" => ["HIGH", "LOW"],
|
||||
"LOW" => ["LOW"],
|
||||
_ => ["LOSSLESS", "HIGH", "LOW"]
|
||||
};
|
||||
}
|
||||
|
||||
private static string NormalizeQuality(string? configuredQuality)
|
||||
{
|
||||
return configuredQuality?.ToUpperInvariant() switch
|
||||
{
|
||||
"FLAC" => "LOSSLESS",
|
||||
"HI_RES" => "HI_RES_LOSSLESS",
|
||||
"HI_RES_LOSSLESS" => "HI_RES_LOSSLESS",
|
||||
"LOSSLESS" => "LOSSLESS",
|
||||
"HIGH" => "HIGH",
|
||||
"LOW" => "LOW",
|
||||
_ => "LOSSLESS"
|
||||
};
|
||||
}
|
||||
|
||||
private static string DescribeException(Exception ex)
|
||||
{
|
||||
if (ex is HttpRequestException httpRequestException && httpRequestException.StatusCode.HasValue)
|
||||
{
|
||||
var statusCode = (int)httpRequestException.StatusCode.Value;
|
||||
return $"{statusCode}: {httpRequestException.StatusCode.Value}";
|
||||
}
|
||||
|
||||
return ex.Message;
|
||||
}
|
||||
|
||||
|
||||
#endregion
|
||||
|
||||
@@ -367,8 +460,9 @@ public class SquidWTFDownloadService : BaseDownloadService
|
||||
|
||||
private class DownloadResult
|
||||
{
|
||||
public string Endpoint { get; set; } = string.Empty;
|
||||
public string DownloadUrl { get; set; } = string.Empty;
|
||||
public string MimeType { get; set; } = string.Empty;
|
||||
public string AudioQuality { get; set; } = string.Empty;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -7,7 +7,6 @@ using allstarr.Services.Common;
|
||||
using System.Text.Json;
|
||||
using System.Text;
|
||||
using Microsoft.Extensions.Options;
|
||||
using System.Text.Json.Nodes;
|
||||
|
||||
namespace allstarr.Services.SquidWTF;
|
||||
|
||||
@@ -17,17 +16,19 @@ namespace allstarr.Services.SquidWTF;
|
||||
/// SquidWTF is a proxy to Tidal's API that provides free access to Tidal's music catalog.
|
||||
/// This implementation follows the hifi-api specification documented at the forked repository.
|
||||
///
|
||||
/// API Endpoints (per hifi-api spec):
|
||||
/// - GET /search/?s={query} - Search tracks (returns data.items array)
|
||||
/// - GET /search/?a={query} - Search artists (returns data.artists.items array)
|
||||
/// - GET /search/?al={query} - Search albums (returns data.albums.items array, undocumented)
|
||||
/// - GET /search/?p={query} - Search playlists (returns data.playlists.items array, undocumented)
|
||||
/// - GET /info/?id={trackId} - Get track metadata (returns data object with full track info)
|
||||
/// - GET /track/?id={trackId}&quality={quality} - Get track download info (returns manifest)
|
||||
/// - GET /recommendations/?id={trackId} - Get recommended next/similar tracks
|
||||
/// - GET /album/?id={albumId} - Get album with tracks (undocumented, returns data.items array)
|
||||
/// - GET /artist/?f={artistId} - Get artist with albums (undocumented, returns albums.items array)
|
||||
/// - GET /playlist/?id={playlistId} - Get playlist with tracks (undocumented)
|
||||
/// API Endpoints (per hifi-api README):
|
||||
/// - GET /search/?s={query}&limit={limit}&offset={offset} - Search tracks (returns data.items array)
|
||||
/// - GET /search/?i={isrc}&limit=1&offset=0 - Exact track lookup by ISRC (returns data.items array)
|
||||
/// - GET /search/?a={query}&limit={limit}&offset={offset} - Search artists (returns data.artists.items array)
|
||||
/// - GET /search/?al={query}&limit={limit}&offset={offset} - Search albums (returns data.albums.items array)
|
||||
/// - GET /search/?p={query}&limit={limit}&offset={offset} - Search playlists (returns data.playlists.items array)
|
||||
/// - GET /info/?id={trackId} - Get track metadata (returns data object with full track info)
|
||||
/// - GET /track/?id={trackId}&quality={quality} - Get track download info (returns manifest)
|
||||
/// - GET /recommendations/?id={trackId} - Get recommended next/similar tracks
|
||||
/// - GET /album/?id={albumId}&limit={limit}&offset={offset} - Get album with paginated tracks
|
||||
/// - GET /artist/?id={artistId} - Get lightweight artist metadata + cover
|
||||
/// - GET /artist/?f={artistId} - Get artist releases and aggregate tracks
|
||||
/// - GET /playlist/?id={playlistId}&limit={limit}&offset={offset} - Get playlist with paginated tracks
|
||||
///
|
||||
/// Quality Options:
|
||||
/// - HI_RES_LOSSLESS: 24-bit/192kHz FLAC
|
||||
@@ -36,7 +37,8 @@ namespace allstarr.Services.SquidWTF;
|
||||
/// - LOW: 96kbps AAC
|
||||
///
|
||||
/// Response Structure:
|
||||
/// All responses follow: { "version": "2.0", "data": { ... } }
|
||||
/// Responses follow the documented hifi-api 2.x envelopes.
|
||||
/// Track search and ISRC search return: { "version": "2.x", "data": { "items": [ ... ] } }
|
||||
/// Track objects include: id, title, duration, trackNumber, volumeNumber, explicit, bpm, isrc,
|
||||
/// artist (singular), artists (array), album (object with id, title, cover UUID)
|
||||
/// Cover art URLs: https://resources.tidal.com/images/{uuid-with-slashes}/{size}.jpg
|
||||
@@ -52,6 +54,12 @@ namespace allstarr.Services.SquidWTF;
|
||||
|
||||
public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
{
|
||||
private const int RemoteSearchMinLimit = 1;
|
||||
private const int RemoteSearchMaxLimit = 500;
|
||||
private const int DefaultSearchOffset = 0;
|
||||
private const int IsrcLookupLimit = 1;
|
||||
private const int IsrcFallbackLimit = 5;
|
||||
private const int MetadataPageSize = 500;
|
||||
private readonly HttpClient _httpClient;
|
||||
private readonly SubsonicSettings _settings;
|
||||
private readonly ILogger<SquidWTFMetadataService> _logger;
|
||||
@@ -87,12 +95,13 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
public async Task<List<Song>> SearchSongsAsync(string query, int limit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
var allSongs = new List<Song>();
|
||||
var seenIds = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
foreach (var queryVariant in BuildSearchQueryVariants(query))
|
||||
{
|
||||
var songs = await SearchSongsSingleQueryAsync(queryVariant, limit, cancellationToken);
|
||||
var songs = await SearchSongsSingleQueryAsync(queryVariant, normalizedLimit, cancellationToken);
|
||||
foreach (var song in songs)
|
||||
{
|
||||
var key = !string.IsNullOrWhiteSpace(song.ExternalId) ? song.ExternalId : song.Id;
|
||||
@@ -102,13 +111,13 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
|
||||
allSongs.Add(song);
|
||||
if (allSongs.Count >= limit)
|
||||
if (allSongs.Count >= normalizedLimit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
if (allSongs.Count >= limit)
|
||||
if (allSongs.Count >= normalizedLimit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
@@ -120,12 +129,13 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
public async Task<List<Album>> SearchAlbumsAsync(string query, int limit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
var allAlbums = new List<Album>();
|
||||
var seenIds = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
foreach (var queryVariant in BuildSearchQueryVariants(query))
|
||||
{
|
||||
var albums = await SearchAlbumsSingleQueryAsync(queryVariant, limit, cancellationToken);
|
||||
var albums = await SearchAlbumsSingleQueryAsync(queryVariant, normalizedLimit, cancellationToken);
|
||||
foreach (var album in albums)
|
||||
{
|
||||
var key = !string.IsNullOrWhiteSpace(album.ExternalId) ? album.ExternalId : album.Id;
|
||||
@@ -135,13 +145,13 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
|
||||
allAlbums.Add(album);
|
||||
if (allAlbums.Count >= limit)
|
||||
if (allAlbums.Count >= normalizedLimit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
if (allAlbums.Count >= limit)
|
||||
if (allAlbums.Count >= normalizedLimit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
@@ -153,12 +163,13 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
public async Task<List<Artist>> SearchArtistsAsync(string query, int limit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
var allArtists = new List<Artist>();
|
||||
var seenIds = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
foreach (var queryVariant in BuildSearchQueryVariants(query))
|
||||
{
|
||||
var artists = await SearchArtistsSingleQueryAsync(queryVariant, limit, cancellationToken);
|
||||
var artists = await SearchArtistsSingleQueryAsync(queryVariant, normalizedLimit, cancellationToken);
|
||||
foreach (var artist in artists)
|
||||
{
|
||||
var key = !string.IsNullOrWhiteSpace(artist.ExternalId) ? artist.ExternalId : artist.Id;
|
||||
@@ -168,13 +179,13 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
|
||||
allArtists.Add(artist);
|
||||
if (allArtists.Count >= limit)
|
||||
if (allArtists.Count >= normalizedLimit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
if (allArtists.Count >= limit)
|
||||
if (allArtists.Count >= normalizedLimit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
@@ -186,11 +197,12 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
private async Task<List<Song>> SearchSongsSingleQueryAsync(string query, int limit, CancellationToken cancellationToken)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
// Use benchmark-ordered fallback (no endpoint racing).
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Use 's' parameter for track search as per hifi-api spec
|
||||
var url = $"{baseUrl}/search/?s={Uri.EscapeDataString(query)}";
|
||||
var url = BuildSearchUrl(baseUrl, "s", query, normalizedLimit);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
@@ -216,7 +228,7 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
int count = 0;
|
||||
foreach (var track in items.EnumerateArray())
|
||||
{
|
||||
if (count >= limit) break;
|
||||
if (count >= normalizedLimit) break;
|
||||
|
||||
var song = ParseTidalTrack(track);
|
||||
if (ExplicitContentFilter.ShouldIncludeSong(song, _settings.ExplicitFilter))
|
||||
@@ -226,18 +238,23 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
count++;
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
throw new InvalidOperationException("SquidWTF song search response did not contain data.items");
|
||||
}
|
||||
return songs;
|
||||
}, new List<Song>());
|
||||
}
|
||||
|
||||
private async Task<List<Album>> SearchAlbumsSingleQueryAsync(string query, int limit, CancellationToken cancellationToken)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
// Use benchmark-ordered fallback (no endpoint racing).
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Use 'al' parameter for album search
|
||||
// a= is for artists, al= is for albums, p= is for playlists
|
||||
var url = $"{baseUrl}/search/?al={Uri.EscapeDataString(query)}";
|
||||
var url = BuildSearchUrl(baseUrl, "al", query, normalizedLimit);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
@@ -257,12 +274,16 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
int count = 0;
|
||||
foreach (var album in items.EnumerateArray())
|
||||
{
|
||||
if (count >= limit) break;
|
||||
if (count >= normalizedLimit) break;
|
||||
|
||||
albums.Add(ParseTidalAlbum(album));
|
||||
count++;
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
throw new InvalidOperationException("SquidWTF album search response did not contain data.albums.items");
|
||||
}
|
||||
|
||||
return albums;
|
||||
}, new List<Album>());
|
||||
@@ -270,11 +291,12 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
private async Task<List<Artist>> SearchArtistsSingleQueryAsync(string query, int limit, CancellationToken cancellationToken)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
// Use benchmark-ordered fallback (no endpoint racing).
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Per hifi-api spec: use 'a' parameter for artist search
|
||||
var url = $"{baseUrl}/search/?a={Uri.EscapeDataString(query)}";
|
||||
var url = BuildSearchUrl(baseUrl, "a", query, normalizedLimit);
|
||||
_logger.LogDebug("🔍 SQUIDWTF: Searching artists with URL: {Url}", url);
|
||||
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
@@ -288,6 +310,12 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var result = JsonDocument.Parse(json);
|
||||
|
||||
if (result.RootElement.TryGetProperty("detail", out _) ||
|
||||
result.RootElement.TryGetProperty("error", out _))
|
||||
{
|
||||
throw new HttpRequestException("API returned error response");
|
||||
}
|
||||
|
||||
var artists = new List<Artist>();
|
||||
// Per hifi-api spec: artist search returns data.artists.items array
|
||||
if (result.RootElement.TryGetProperty("data", out var data) &&
|
||||
@@ -297,7 +325,7 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
int count = 0;
|
||||
foreach (var artist in items.EnumerateArray())
|
||||
{
|
||||
if (count >= limit) break;
|
||||
if (count >= normalizedLimit) break;
|
||||
|
||||
var parsedArtist = ParseTidalArtist(artist);
|
||||
artists.Add(parsedArtist);
|
||||
@@ -305,6 +333,10 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
count++;
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
throw new InvalidOperationException("SquidWTF artist search response did not contain data.artists.items");
|
||||
}
|
||||
|
||||
return artists;
|
||||
}, new List<Artist>());
|
||||
@@ -338,18 +370,101 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
}
|
||||
|
||||
private static int NormalizeRemoteLimit(int limit)
|
||||
{
|
||||
return Math.Clamp(limit, RemoteSearchMinLimit, RemoteSearchMaxLimit);
|
||||
}
|
||||
|
||||
private static string BuildSearchUrl(string baseUrl, string field, string query, int limit, int offset = DefaultSearchOffset)
|
||||
{
|
||||
return $"{baseUrl}/search/?{field}={Uri.EscapeDataString(query)}&limit={NormalizeRemoteLimit(limit)}&offset={Math.Max(DefaultSearchOffset, offset)}";
|
||||
}
|
||||
|
||||
private static string BuildPagedEndpointUrl(string baseUrl, string endpoint, string idParameterName, string externalId, int limit, int offset = DefaultSearchOffset)
|
||||
{
|
||||
return $"{baseUrl}/{endpoint}/?{idParameterName}={Uri.EscapeDataString(externalId)}&limit={NormalizeRemoteLimit(limit)}&offset={Math.Max(DefaultSearchOffset, offset)}";
|
||||
}
|
||||
|
||||
private static string? GetArtistCoverFallbackUrl(JsonElement rootElement)
|
||||
{
|
||||
if (!rootElement.TryGetProperty("cover", out var cover) || cover.ValueKind != JsonValueKind.Object)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
foreach (var propertyName in new[] { "750", "640", "320", "1280" })
|
||||
{
|
||||
if (cover.TryGetProperty(propertyName, out var value) &&
|
||||
value.ValueKind == JsonValueKind.String &&
|
||||
!string.IsNullOrWhiteSpace(value.GetString()))
|
||||
{
|
||||
return value.GetString();
|
||||
}
|
||||
}
|
||||
|
||||
foreach (var property in cover.EnumerateObject())
|
||||
{
|
||||
if (property.Value.ValueKind == JsonValueKind.String &&
|
||||
!string.IsNullOrWhiteSpace(property.Value.GetString()))
|
||||
{
|
||||
return property.Value.GetString();
|
||||
}
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
private static TimeSpan GetMetadataCacheTtl()
|
||||
{
|
||||
try
|
||||
{
|
||||
return CacheExtensions.MetadataTTL;
|
||||
}
|
||||
catch (InvalidOperationException)
|
||||
{
|
||||
return new CacheSettings().MetadataTTL;
|
||||
}
|
||||
}
|
||||
|
||||
private async Task<Song?> FindSongByIsrcViaTextSearchAsync(string isrc, CancellationToken cancellationToken)
|
||||
{
|
||||
var prefixedResults = await SearchSongsAsync($"isrc:{isrc}", limit: IsrcLookupLimit, cancellationToken);
|
||||
var prefixedMatch = prefixedResults.FirstOrDefault(song =>
|
||||
!string.IsNullOrWhiteSpace(song.Isrc) &&
|
||||
song.Isrc.Equals(isrc, StringComparison.OrdinalIgnoreCase));
|
||||
if (prefixedMatch != null)
|
||||
{
|
||||
return prefixedMatch;
|
||||
}
|
||||
|
||||
var rawResults = await SearchSongsAsync(isrc, limit: IsrcFallbackLimit, cancellationToken);
|
||||
return rawResults.FirstOrDefault(song =>
|
||||
!string.IsNullOrWhiteSpace(song.Isrc) &&
|
||||
song.Isrc.Equals(isrc, StringComparison.OrdinalIgnoreCase));
|
||||
}
|
||||
|
||||
public async Task<List<ExternalPlaylist>> SearchPlaylistsAsync(string query, int limit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Per hifi-api spec: use 'p' parameter for playlist search
|
||||
var url = $"{baseUrl}/search/?p={Uri.EscapeDataString(query)}";
|
||||
var url = BuildSearchUrl(baseUrl, "p", query, normalizedLimit);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode) return new List<ExternalPlaylist>();
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var result = JsonDocument.Parse(json);
|
||||
|
||||
if (result.RootElement.TryGetProperty("detail", out _) ||
|
||||
result.RootElement.TryGetProperty("error", out _))
|
||||
{
|
||||
throw new HttpRequestException("API returned error response");
|
||||
}
|
||||
|
||||
var playlists = new List<ExternalPlaylist>();
|
||||
// Per hifi-api spec: playlist search returns data.playlists.items array
|
||||
if (result.RootElement.TryGetProperty("data", out var data) &&
|
||||
@@ -359,7 +474,7 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
int count = 0;
|
||||
foreach(var playlist in items.EnumerateArray())
|
||||
{
|
||||
if (count >= limit) break;
|
||||
if (count >= normalizedLimit) break;
|
||||
|
||||
try
|
||||
{
|
||||
@@ -370,23 +485,32 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
{
|
||||
_logger.LogWarning(ex, "Failed to parse playlist, skipping");
|
||||
// Skip this playlist and continue with others
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
throw new InvalidOperationException("SquidWTF playlist search response did not contain data.playlists.items");
|
||||
}
|
||||
return playlists;
|
||||
}, new List<ExternalPlaylist>());
|
||||
}
|
||||
|
||||
public async Task<SearchResult> SearchAllAsync(string query, int songLimit = 20, int albumLimit = 20, int artistLimit = 20, CancellationToken cancellationToken = default)
|
||||
{
|
||||
// Execute searches in parallel
|
||||
var songsTask = SearchSongsAsync(query, songLimit, cancellationToken);
|
||||
var albumsTask = SearchAlbumsAsync(query, albumLimit, cancellationToken);
|
||||
var artistsTask = SearchArtistsAsync(query, artistLimit, cancellationToken);
|
||||
var songsTask = songLimit > 0
|
||||
? SearchSongsAsync(query, songLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Song>());
|
||||
var albumsTask = albumLimit > 0
|
||||
? SearchAlbumsAsync(query, albumLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Album>());
|
||||
var artistsTask = artistLimit > 0
|
||||
? SearchArtistsAsync(query, artistLimit, cancellationToken)
|
||||
: Task.FromResult(new List<Artist>());
|
||||
|
||||
await Task.WhenAll(songsTask, albumsTask, artistsTask);
|
||||
|
||||
var temp = new SearchResult
|
||||
var temp = new SearchResult
|
||||
{
|
||||
Songs = await songsTask,
|
||||
Albums = await albumsTask,
|
||||
@@ -396,6 +520,65 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
return temp;
|
||||
}
|
||||
|
||||
public async Task<Song?> FindSongByIsrcAsync(string isrc, CancellationToken cancellationToken = default)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(isrc))
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
var normalizedIsrc = isrc.Trim();
|
||||
|
||||
var exactMatch = await _fallbackHelper.TryWithFallbackAsync(
|
||||
async (baseUrl) =>
|
||||
{
|
||||
var url = BuildSearchUrl(baseUrl, "i", normalizedIsrc, IsrcLookupLimit);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var result = JsonDocument.Parse(json);
|
||||
|
||||
if (result.RootElement.TryGetProperty("detail", out _) ||
|
||||
result.RootElement.TryGetProperty("error", out _))
|
||||
{
|
||||
throw new HttpRequestException("API returned error response");
|
||||
}
|
||||
|
||||
if (!result.RootElement.TryGetProperty("data", out var data) ||
|
||||
!data.TryGetProperty("items", out var items) ||
|
||||
items.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
throw new InvalidOperationException("SquidWTF ISRC search response did not contain data.items");
|
||||
}
|
||||
|
||||
foreach (var track in items.EnumerateArray())
|
||||
{
|
||||
var song = ParseTidalTrack(track);
|
||||
if (!ExplicitContentFilter.ShouldIncludeSong(song, _settings.ExplicitFilter))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(song.Isrc) &&
|
||||
song.Isrc.Equals(normalizedIsrc, StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
return song;
|
||||
}
|
||||
}
|
||||
|
||||
return null;
|
||||
},
|
||||
song => song != null,
|
||||
(Song?)null);
|
||||
|
||||
return exactMatch ?? await FindSongByIsrcViaTextSearchAsync(normalizedIsrc, cancellationToken);
|
||||
}
|
||||
|
||||
public async Task<Song?> GetSongAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default)
|
||||
{
|
||||
if (externalProvider != "squidwtf") return null;
|
||||
@@ -406,14 +589,19 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
var url = $"{baseUrl}/info/?id={externalId}";
|
||||
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode) return null;
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var result = JsonDocument.Parse(json);
|
||||
|
||||
// Per hifi-api spec: response is { "version": "2.0", "data": { track object } }
|
||||
if (!result.RootElement.TryGetProperty("data", out var track))
|
||||
return null;
|
||||
{
|
||||
throw new InvalidOperationException($"SquidWTF /info response for track {externalId} did not contain data");
|
||||
}
|
||||
|
||||
var song = ParseTidalTrackFull(track);
|
||||
|
||||
@@ -445,84 +633,96 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(externalId)) return new List<Song>();
|
||||
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
var url = $"{baseUrl}/recommendations/?id={Uri.EscapeDataString(externalId)}";
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
return await _fallbackHelper.TryWithFallbackAsync(
|
||||
async (baseUrl) =>
|
||||
{
|
||||
_logger.LogDebug("SquidWTF recommendations request failed for track {TrackId} with status {StatusCode}",
|
||||
externalId, response.StatusCode);
|
||||
return new List<Song>();
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var result = JsonDocument.Parse(json);
|
||||
|
||||
if (!result.RootElement.TryGetProperty("data", out var data) ||
|
||||
!data.TryGetProperty("items", out var items) ||
|
||||
items.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
return new List<Song>();
|
||||
}
|
||||
|
||||
var songs = new List<Song>();
|
||||
var seenIds = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
foreach (var recommendation in items.EnumerateArray())
|
||||
{
|
||||
JsonElement track;
|
||||
if (recommendation.TryGetProperty("track", out var wrappedTrack))
|
||||
var url = $"{baseUrl}/recommendations/?id={Uri.EscapeDataString(externalId)}";
|
||||
if (limit > 0)
|
||||
{
|
||||
track = wrappedTrack;
|
||||
}
|
||||
else
|
||||
{
|
||||
track = recommendation;
|
||||
url += $"&limit={limit}";
|
||||
}
|
||||
|
||||
if (!track.TryGetProperty("id", out _))
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
continue;
|
||||
throw new HttpRequestException(
|
||||
$"SquidWTF recommendations request failed for track {externalId} with status {response.StatusCode}");
|
||||
}
|
||||
|
||||
Song song;
|
||||
try
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var result = JsonDocument.Parse(json);
|
||||
|
||||
if (!result.RootElement.TryGetProperty("data", out var data) ||
|
||||
!data.TryGetProperty("items", out var items) ||
|
||||
items.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
song = ParseTidalTrack(track);
|
||||
}
|
||||
catch
|
||||
{
|
||||
continue;
|
||||
throw new InvalidOperationException(
|
||||
$"SquidWTF recommendations response for track {externalId} did not contain data.items");
|
||||
}
|
||||
|
||||
if (string.Equals(song.ExternalId, externalId, StringComparison.OrdinalIgnoreCase))
|
||||
var songs = new List<Song>();
|
||||
var seenIds = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
foreach (var recommendation in items.EnumerateArray())
|
||||
{
|
||||
continue;
|
||||
JsonElement track;
|
||||
if (recommendation.TryGetProperty("track", out var wrappedTrack))
|
||||
{
|
||||
track = wrappedTrack;
|
||||
}
|
||||
else
|
||||
{
|
||||
track = recommendation;
|
||||
}
|
||||
|
||||
if (!track.TryGetProperty("id", out _))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
Song song;
|
||||
try
|
||||
{
|
||||
song = ParseTidalTrack(track);
|
||||
}
|
||||
catch
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
if (string.Equals(song.ExternalId, externalId, StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var songKey = !string.IsNullOrWhiteSpace(song.ExternalId) ? song.ExternalId : song.Id;
|
||||
if (string.IsNullOrWhiteSpace(songKey) || !seenIds.Add(songKey))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!ShouldIncludeSong(song))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
songs.Add(song);
|
||||
if (songs.Count >= limit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
var songKey = !string.IsNullOrWhiteSpace(song.ExternalId) ? song.ExternalId : song.Id;
|
||||
if (string.IsNullOrWhiteSpace(songKey) || !seenIds.Add(songKey))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!ShouldIncludeSong(song))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
songs.Add(song);
|
||||
if (songs.Count >= limit)
|
||||
{
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
_logger.LogDebug("SQUIDWTF: Recommendations returned {Count} songs for track {TrackId}", songs.Count, externalId);
|
||||
return songs;
|
||||
}, new List<Song>());
|
||||
_logger.LogDebug(
|
||||
"SQUIDWTF: Recommendations returned {Count} songs for track {TrackId} from {BaseUrl}",
|
||||
songs.Count,
|
||||
externalId,
|
||||
baseUrl);
|
||||
return songs;
|
||||
},
|
||||
songs => songs.Count > 0,
|
||||
new List<Song>());
|
||||
}
|
||||
|
||||
public async Task<Album?> GetAlbumAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default)
|
||||
@@ -536,43 +736,71 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Note: hifi-api doesn't document album endpoint, but /album/?id={albumId} is commonly used
|
||||
var url = $"{baseUrl}/album/?id={externalId}";
|
||||
Album? album = null;
|
||||
var offset = DefaultSearchOffset;
|
||||
var rawItemCount = 0;
|
||||
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode) return null;
|
||||
while (true)
|
||||
{
|
||||
var url = BuildPagedEndpointUrl(baseUrl, "album", "id", externalId, MetadataPageSize, offset);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var result = JsonDocument.Parse(json);
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
using var result = JsonDocument.Parse(json);
|
||||
|
||||
// Response structure: { "data": { album object with "items" array of tracks } }
|
||||
if (!result.RootElement.TryGetProperty("data", out var albumElement))
|
||||
return null;
|
||||
if (!result.RootElement.TryGetProperty("data", out var albumElement))
|
||||
{
|
||||
throw new InvalidOperationException($"SquidWTF /album response for album {externalId} did not contain data");
|
||||
}
|
||||
|
||||
var album = ParseTidalAlbum(albumElement);
|
||||
album ??= ParseTidalAlbum(albumElement);
|
||||
|
||||
// Get album tracks from items array
|
||||
if (albumElement.TryGetProperty("items", out var tracks))
|
||||
{
|
||||
foreach (var trackWrapper in tracks.EnumerateArray())
|
||||
{
|
||||
// Each item is wrapped: { "item": { track object } }
|
||||
if (trackWrapper.TryGetProperty("item", out var track))
|
||||
{
|
||||
var song = ParseTidalTrack(track);
|
||||
if (ExplicitContentFilter.ShouldIncludeSong(song, _settings.ExplicitFilter))
|
||||
{
|
||||
album.Songs.Add(song);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
if (!albumElement.TryGetProperty("items", out var tracks) || tracks.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
throw new InvalidOperationException($"SquidWTF /album response for album {externalId} did not contain data.items");
|
||||
}
|
||||
|
||||
// Cache for configurable duration
|
||||
await _cache.SetAsync(cacheKey, album, CacheExtensions.MetadataTTL);
|
||||
var pageCount = 0;
|
||||
foreach (var trackWrapper in tracks.EnumerateArray())
|
||||
{
|
||||
pageCount++;
|
||||
|
||||
return album;
|
||||
}, (Album?)null);
|
||||
if (!trackWrapper.TryGetProperty("item", out var track))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var song = ParseTidalTrack(track);
|
||||
if (ExplicitContentFilter.ShouldIncludeSong(song, _settings.ExplicitFilter))
|
||||
{
|
||||
album.Songs.Add(song);
|
||||
}
|
||||
}
|
||||
|
||||
rawItemCount += pageCount;
|
||||
if (pageCount == 0 ||
|
||||
pageCount < MetadataPageSize ||
|
||||
(album.SongCount.HasValue && rawItemCount >= album.SongCount.Value))
|
||||
{
|
||||
break;
|
||||
}
|
||||
|
||||
offset += pageCount;
|
||||
}
|
||||
|
||||
if (album == null)
|
||||
{
|
||||
throw new InvalidOperationException($"SquidWTF /album response for album {externalId} did not contain album data");
|
||||
}
|
||||
|
||||
await _cache.SetAsync(cacheKey, album, GetMetadataCacheTtl());
|
||||
|
||||
return album;
|
||||
}, (Album?)null);
|
||||
}
|
||||
|
||||
public async Task<Artist?> GetArtistAsync(string externalProvider, string externalId, CancellationToken cancellationToken = default)
|
||||
@@ -592,83 +820,52 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Note: hifi-api doesn't document artist endpoint, but /artist/?f={artistId} is commonly used
|
||||
var url = $"{baseUrl}/artist/?f={externalId}";
|
||||
var url = $"{baseUrl}/artist/?id={Uri.EscapeDataString(externalId)}";
|
||||
_logger.LogDebug("Fetching artist from {Url}", url);
|
||||
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
_logger.LogError("SquidWTF artist request failed with status {StatusCode}", response.StatusCode);
|
||||
return null;
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
_logger.LogDebug("SquidWTF artist response: {Json}", json.Length > 500 ? json.Substring(0, 500) + "..." : json);
|
||||
var result = JsonDocument.Parse(json);
|
||||
using var result = JsonDocument.Parse(json);
|
||||
|
||||
JsonElement? artistSource = null;
|
||||
int albumCount = 0;
|
||||
|
||||
// Response structure: { "albums": { "items": [ album objects ] }, "tracks": [ track objects ] }
|
||||
// Extract artist info from albums.items[0].artist (most reliable source)
|
||||
if (result.RootElement.TryGetProperty("albums", out var albums) &&
|
||||
albums.TryGetProperty("items", out var albumItems) &&
|
||||
albumItems.GetArrayLength() > 0)
|
||||
{
|
||||
albumCount = albumItems.GetArrayLength();
|
||||
if (albumItems[0].TryGetProperty("artist", out var artistEl))
|
||||
{
|
||||
artistSource = artistEl;
|
||||
_logger.LogDebug("Found artist from albums, albumCount={AlbumCount}", albumCount);
|
||||
}
|
||||
}
|
||||
|
||||
// Fallback: try to get artist from tracks[0].artists[0]
|
||||
if (artistSource == null &&
|
||||
result.RootElement.TryGetProperty("tracks", out var tracks) &&
|
||||
tracks.GetArrayLength() > 0 &&
|
||||
tracks[0].TryGetProperty("artists", out var artists) &&
|
||||
artists.GetArrayLength() > 0)
|
||||
{
|
||||
artistSource = artists[0];
|
||||
_logger.LogInformation("Found artist from tracks");
|
||||
}
|
||||
|
||||
if (artistSource == null)
|
||||
if (!result.RootElement.TryGetProperty("artist", out var artistElement))
|
||||
{
|
||||
_logger.LogDebug("Could not find artist data in response. Response keys: {Keys}",
|
||||
string.Join(", ", result.RootElement.EnumerateObject().Select(p => p.Name)));
|
||||
return null;
|
||||
var keys = string.Join(", ", result.RootElement.EnumerateObject().Select(p => p.Name));
|
||||
throw new InvalidOperationException(
|
||||
$"SquidWTF artist response for {externalId} did not contain artist data. Keys: {keys}");
|
||||
}
|
||||
|
||||
var artistElement = artistSource.Value;
|
||||
var artistName = artistElement.GetProperty("name").GetString() ?? string.Empty;
|
||||
var pictureUuid = artistElement.TryGetProperty("picture", out var pictureEl) &&
|
||||
pictureEl.ValueKind == JsonValueKind.String
|
||||
? pictureEl.GetString()
|
||||
: null;
|
||||
var coverUrl = GetArtistCoverFallbackUrl(result.RootElement);
|
||||
var imageUrl = !string.IsNullOrWhiteSpace(pictureUuid)
|
||||
? BuildTidalImageUrl(pictureUuid, "320x320")
|
||||
: coverUrl;
|
||||
|
||||
// Extract picture UUID (may be null)
|
||||
string? pictureUuid = null;
|
||||
if (artistElement.TryGetProperty("picture", out var pictureEl) && pictureEl.ValueKind != JsonValueKind.Null)
|
||||
var artist = new Artist
|
||||
{
|
||||
pictureUuid = pictureEl.GetString();
|
||||
}
|
||||
Id = BuildExternalArtistId("squidwtf", externalId),
|
||||
Name = artistName,
|
||||
ImageUrl = imageUrl,
|
||||
AlbumCount = null,
|
||||
IsLocal = false,
|
||||
ExternalProvider = "squidwtf",
|
||||
ExternalId = externalId
|
||||
};
|
||||
|
||||
// Normalize artist data to include album count
|
||||
var normalizedArtist = new JsonObject
|
||||
{
|
||||
["id"] = artistElement.GetProperty("id").GetInt64(),
|
||||
["name"] = artistElement.GetProperty("name").GetString(),
|
||||
["albums_count"] = albumCount,
|
||||
["picture"] = pictureUuid
|
||||
};
|
||||
_logger.LogDebug("Successfully parsed artist {ArtistName} via /artist/?id=", artist.Name);
|
||||
|
||||
using var doc = JsonDocument.Parse(normalizedArtist.ToJsonString());
|
||||
var artist = ParseTidalArtist(doc.RootElement);
|
||||
await _cache.SetAsync(cacheKey, artist, GetMetadataCacheTtl());
|
||||
|
||||
_logger.LogDebug("Successfully parsed artist {ArtistName} with {AlbumCount} albums", artist.Name, albumCount);
|
||||
|
||||
// Cache for configurable duration
|
||||
await _cache.SetAsync(cacheKey, artist, CacheExtensions.MetadataTTL);
|
||||
|
||||
return artist;
|
||||
return artist;
|
||||
}, (Artist?)null);
|
||||
}
|
||||
|
||||
@@ -680,15 +877,14 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
{
|
||||
_logger.LogDebug("GetArtistAlbumsAsync called for SquidWTF artist {ExternalId}", externalId);
|
||||
|
||||
// Note: hifi-api doesn't document artist endpoint, but /artist/?f={artistId} is commonly used
|
||||
// Per hifi-api README: /artist/?f={artistId} returns aggregated releases and tracks
|
||||
var url = $"{baseUrl}/artist/?f={externalId}";
|
||||
_logger.LogDebug("Fetching artist albums from URL: {Url}", url);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
_logger.LogError("SquidWTF artist albums request failed with status {StatusCode}", response.StatusCode);
|
||||
return new List<Album>();
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
@@ -712,7 +908,8 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogWarning("No albums found in response for artist {ExternalId}", externalId);
|
||||
throw new InvalidOperationException(
|
||||
$"SquidWTF artist albums response for {externalId} did not contain albums.items");
|
||||
}
|
||||
|
||||
return albums;
|
||||
@@ -727,15 +924,14 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
{
|
||||
_logger.LogDebug("GetArtistTracksAsync called for SquidWTF artist {ExternalId}", externalId);
|
||||
|
||||
// Same endpoint as albums - /artist/?f={artistId} returns both albums and tracks
|
||||
// Per hifi-api README: /artist/?f={artistId} returns both albums and tracks
|
||||
var url = $"{baseUrl}/artist/?f={externalId}";
|
||||
_logger.LogDebug("Fetching artist tracks from URL: {Url}", url);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
_logger.LogError("SquidWTF artist tracks request failed with status {StatusCode}", response.StatusCode);
|
||||
return new List<Song>();
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
@@ -756,7 +952,8 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
}
|
||||
else
|
||||
{
|
||||
_logger.LogWarning("No tracks found in response for artist {ExternalId}", externalId);
|
||||
throw new InvalidOperationException(
|
||||
$"SquidWTF artist tracks response for {externalId} did not contain tracks");
|
||||
}
|
||||
|
||||
return tracks;
|
||||
@@ -769,21 +966,29 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Note: hifi-api doesn't document playlist endpoint, but /playlist/?id={playlistId} is commonly used
|
||||
var url = $"{baseUrl}/playlist/?id={externalId}";
|
||||
var url = BuildPagedEndpointUrl(baseUrl, "playlist", "id", externalId, RemoteSearchMinLimit);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode) return null;
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var rootElement = JsonDocument.Parse(json).RootElement;
|
||||
using var result = JsonDocument.Parse(json);
|
||||
var rootElement = result.RootElement;
|
||||
|
||||
// Check for error response
|
||||
if (rootElement.TryGetProperty("error", out _)) return null;
|
||||
if (rootElement.TryGetProperty("error", out _))
|
||||
{
|
||||
throw new InvalidOperationException($"SquidWTF playlist response for {externalId} contained an error payload");
|
||||
}
|
||||
|
||||
// Response structure: { "playlist": { playlist object }, "items": [ track wrappers ] }
|
||||
// Extract the playlist object from the response
|
||||
if (!rootElement.TryGetProperty("playlist", out var playlistElement))
|
||||
return null;
|
||||
{
|
||||
throw new InvalidOperationException($"SquidWTF playlist response for {externalId} did not contain playlist");
|
||||
}
|
||||
|
||||
return ParseTidalPlaylist(playlistElement);
|
||||
}, (ExternalPlaylist?)null);
|
||||
@@ -795,64 +1000,85 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
return await _fallbackHelper.TryWithFallbackAsync(async (baseUrl) =>
|
||||
{
|
||||
// Note: hifi-api doesn't document playlist endpoint, but /playlist/?id={playlistId} is commonly used
|
||||
var url = $"{baseUrl}/playlist/?id={externalId}";
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode) return new List<Song>();
|
||||
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
var playlistElement = JsonDocument.Parse(json).RootElement;
|
||||
|
||||
// Check for error response
|
||||
if (playlistElement.TryGetProperty("error", out _)) return new List<Song>();
|
||||
|
||||
JsonElement? playlist = null;
|
||||
JsonElement? tracks = null;
|
||||
|
||||
// Response structure: { "playlist": { playlist object }, "items": [ track wrappers ] }
|
||||
if (playlistElement.TryGetProperty("playlist", out var playlistEl))
|
||||
{
|
||||
playlist = playlistEl;
|
||||
}
|
||||
|
||||
if (playlistElement.TryGetProperty("items", out var tracksEl))
|
||||
{
|
||||
tracks = tracksEl;
|
||||
}
|
||||
|
||||
var songs = new List<Song>();
|
||||
var offset = DefaultSearchOffset;
|
||||
var rawTrackCount = 0;
|
||||
var trackIndex = 1;
|
||||
string playlistName = "Unknown Playlist";
|
||||
int? expectedTrackCount = null;
|
||||
|
||||
// Get playlist name for album field
|
||||
var playlistName = playlist?.TryGetProperty("title", out var titleEl) == true
|
||||
? titleEl.GetString() ?? "Unknown Playlist"
|
||||
: "Unknown Playlist";
|
||||
while (true)
|
||||
{
|
||||
var url = BuildPagedEndpointUrl(baseUrl, "playlist", "id", externalId, MetadataPageSize, offset);
|
||||
var response = await _httpClient.GetAsync(url, cancellationToken);
|
||||
if (!response.IsSuccessStatusCode)
|
||||
{
|
||||
throw new HttpRequestException($"HTTP {response.StatusCode}");
|
||||
}
|
||||
|
||||
if (tracks.HasValue)
|
||||
{
|
||||
int trackIndex = 1;
|
||||
foreach (var entry in tracks.Value.EnumerateArray())
|
||||
{
|
||||
// Each item is wrapped: { "item": { track object } }
|
||||
if (!entry.TryGetProperty("item", out var track))
|
||||
continue;
|
||||
var json = await response.Content.ReadAsStringAsync(cancellationToken);
|
||||
using var result = JsonDocument.Parse(json);
|
||||
var playlistElement = result.RootElement;
|
||||
|
||||
// For playlists, use the track's own artist (not a single album artist)
|
||||
var song = ParseTidalTrack(track, trackIndex);
|
||||
if (playlistElement.TryGetProperty("error", out _))
|
||||
{
|
||||
throw new InvalidOperationException($"SquidWTF playlist tracks response for {externalId} contained an error payload");
|
||||
}
|
||||
|
||||
// Override album name to be the playlist name
|
||||
song.Album = playlistName;
|
||||
if (playlistElement.TryGetProperty("playlist", out var playlistEl))
|
||||
{
|
||||
if (playlistEl.TryGetProperty("title", out var titleEl))
|
||||
{
|
||||
playlistName = titleEl.GetString() ?? playlistName;
|
||||
}
|
||||
|
||||
// Playlists should not have disc numbers - always set to null
|
||||
// This prevents Jellyfin from splitting the playlist into multiple "discs"
|
||||
song.DiscNumber = null;
|
||||
if (!expectedTrackCount.HasValue &&
|
||||
playlistEl.TryGetProperty("numberOfTracks", out var trackCountEl) &&
|
||||
trackCountEl.ValueKind == JsonValueKind.Number)
|
||||
{
|
||||
expectedTrackCount = trackCountEl.GetInt32();
|
||||
}
|
||||
}
|
||||
|
||||
if (!playlistElement.TryGetProperty("items", out var tracks) || tracks.ValueKind != JsonValueKind.Array)
|
||||
{
|
||||
throw new InvalidOperationException(
|
||||
$"SquidWTF playlist tracks response for {externalId} did not contain items");
|
||||
}
|
||||
|
||||
var pageCount = 0;
|
||||
foreach (var entry in tracks.EnumerateArray())
|
||||
{
|
||||
pageCount++;
|
||||
|
||||
if (!entry.TryGetProperty("item", out var track))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var song = ParseTidalTrack(track, trackIndex);
|
||||
song.Album = playlistName;
|
||||
song.DiscNumber = null;
|
||||
|
||||
if (ExplicitContentFilter.ShouldIncludeSong(song, _settings.ExplicitFilter))
|
||||
{
|
||||
songs.Add(song);
|
||||
}
|
||||
|
||||
trackIndex++;
|
||||
}
|
||||
|
||||
rawTrackCount += pageCount;
|
||||
if (pageCount == 0 ||
|
||||
pageCount < MetadataPageSize ||
|
||||
(expectedTrackCount.HasValue && rawTrackCount >= expectedTrackCount.Value))
|
||||
{
|
||||
break;
|
||||
}
|
||||
|
||||
offset += pageCount;
|
||||
}
|
||||
|
||||
if (ExplicitContentFilter.ShouldIncludeSong(song, _settings.ExplicitFilter))
|
||||
{
|
||||
songs.Add(song);
|
||||
}
|
||||
trackIndex++;
|
||||
}
|
||||
}
|
||||
return songs;
|
||||
}, new List<Song>());
|
||||
}
|
||||
@@ -1179,10 +1405,18 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
var externalId = artist.GetProperty("id").GetInt64().ToString();
|
||||
var artistName = artist.GetProperty("name").GetString() ?? "";
|
||||
|
||||
var imageUrl = artist.TryGetProperty("picture", out var picture)
|
||||
var imageUrl = artist.TryGetProperty("picture", out var picture) &&
|
||||
picture.ValueKind == JsonValueKind.String
|
||||
? BuildTidalImageUrl(picture.GetString(), "320x320")
|
||||
: null;
|
||||
|
||||
if (string.IsNullOrWhiteSpace(imageUrl) &&
|
||||
artist.TryGetProperty("imageUrl", out var imageUrlElement) &&
|
||||
imageUrlElement.ValueKind == JsonValueKind.String)
|
||||
{
|
||||
imageUrl = imageUrlElement.GetString();
|
||||
}
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(imageUrl))
|
||||
{
|
||||
_logger.LogDebug("Artist {ArtistName} picture: {ImageUrl}", artistName, imageUrl);
|
||||
@@ -1204,8 +1438,7 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
|
||||
/// <summary>
|
||||
/// Parses a Tidal playlist from hifi-api /playlist/ endpoint response.
|
||||
/// Per hifi-api spec (undocumented), response structure is:
|
||||
/// { "playlist": { uuid, title, description, creator, created, numberOfTracks, duration, squareImage },
|
||||
/// Response structure: { "playlist": { uuid, title, description, creator, created, numberOfTracks, duration, squareImage },
|
||||
/// "items": [ { "item": { track object } } ] }
|
||||
/// </summary>
|
||||
/// <param name="playlistElement">Root JSON element containing playlist and items</param>
|
||||
@@ -1355,13 +1588,14 @@ public class SquidWTFMetadataService : TrackParserBase, IMusicMetadataService
|
||||
/// </summary>
|
||||
public async Task<List<Song?>> SearchSongsInParallelAsync(List<string> queries, int limit = 10, CancellationToken cancellationToken = default)
|
||||
{
|
||||
var normalizedLimit = NormalizeRemoteLimit(limit);
|
||||
return await _fallbackHelper.ProcessInParallelAsync(
|
||||
queries,
|
||||
async (baseUrl, query, ct) =>
|
||||
{
|
||||
try
|
||||
{
|
||||
var url = $"{baseUrl}/search/?s={Uri.EscapeDataString(query)}";
|
||||
var url = BuildSearchUrl(baseUrl, "s", query, normalizedLimit);
|
||||
var response = await _httpClient.GetAsync(url, ct);
|
||||
|
||||
if (!response.IsSuccessStatusCode)
|
||||
|
||||
@@ -51,15 +51,18 @@
|
||||
"Qobuz": {
|
||||
"UserAuthToken": "your-qobuz-token",
|
||||
"UserId": "your-qobuz-user-id",
|
||||
"Quality": "FLAC"
|
||||
"Quality": "FLAC",
|
||||
"MinRequestIntervalMs": 200
|
||||
},
|
||||
"Deezer": {
|
||||
"Arl": "your-deezer-arl-token",
|
||||
"ArlFallback": "",
|
||||
"Quality": "FLAC"
|
||||
"Quality": "FLAC",
|
||||
"MinRequestIntervalMs": 200
|
||||
},
|
||||
"SquidWTF": {
|
||||
"Quality": "FLAC"
|
||||
"Quality": "FLAC",
|
||||
"MinRequestIntervalMs": 200
|
||||
},
|
||||
"Redis": {
|
||||
"Enabled": true,
|
||||
@@ -74,7 +77,8 @@
|
||||
"GenreDays": 30,
|
||||
"MetadataDays": 7,
|
||||
"OdesliLookupDays": 60,
|
||||
"ProxyImagesDays": 14
|
||||
"ProxyImagesDays": 14,
|
||||
"TranscodeCacheMinutes": 60
|
||||
},
|
||||
"SpotifyImport": {
|
||||
"Enabled": false,
|
||||
|
||||
+113
-58
@@ -12,8 +12,8 @@
|
||||
<!-- Restart Required Banner -->
|
||||
<div class="restart-banner" id="restart-banner">
|
||||
⚠️ Configuration changed. Restart required to apply changes.
|
||||
<button onclick="restartContainer()">Restart Now</button>
|
||||
<button onclick="dismissRestartBanner()"
|
||||
<button data-action="restartContainer">Restart Allstarr</button>
|
||||
<button data-action="dismissRestartBanner"
|
||||
style="background: transparent; border: 1px solid var(--bg-primary);">Dismiss</button>
|
||||
</div>
|
||||
|
||||
@@ -32,36 +32,64 @@
|
||||
<div class="auth-error" id="auth-error" role="alert"></div>
|
||||
</form>
|
||||
</div>
|
||||
|
||||
<div class="support-badge">
|
||||
If Allstarr has helped you, or maybe even replaced a monthly streaming service subscription, consider
|
||||
supporting its development via
|
||||
<a href="https://github.com/sponsors/SoPat712" target="_blank" rel="noopener noreferrer">GitHub Sponsor</a>
|
||||
or
|
||||
<a href="https://ko-fi.com/joshpatra" target="_blank" rel="noopener noreferrer">Ko-Fi</a>.
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div class="container" id="main-container" style="display:none;">
|
||||
<header>
|
||||
<h1>
|
||||
Allstarr <span class="version" id="version">Loading...</span>
|
||||
</h1>
|
||||
<div class="header-actions">
|
||||
<div class="auth-user" id="auth-user-display" style="display:none;">
|
||||
Signed in as <strong id="auth-user-name">-</strong>
|
||||
<div class="container hidden" id="main-container">
|
||||
<div class="app-shell">
|
||||
<aside class="sidebar" aria-label="Admin navigation">
|
||||
<div class="sidebar-brand">
|
||||
<div class="sidebar-title">Allstarr</div>
|
||||
<div class="sidebar-subtitle" id="sidebar-version">Loading...</div>
|
||||
</div>
|
||||
<button id="auth-logout-btn" onclick="logoutAdminSession()" style="display:none;">Logout</button>
|
||||
<div id="status-indicator">
|
||||
<span class="status-badge" id="spotify-status">
|
||||
<span class="status-dot"></span>
|
||||
<span>Loading...</span>
|
||||
</span>
|
||||
<nav class="sidebar-nav">
|
||||
<button class="sidebar-link active" type="button" data-tab="dashboard">Dashboard</button>
|
||||
<button class="sidebar-link" type="button" data-tab="jellyfin-playlists">Link Playlists</button>
|
||||
<button class="sidebar-link" type="button" data-tab="playlists">Injected Playlists</button>
|
||||
<button class="sidebar-link" type="button" data-tab="kept">Kept Downloads</button>
|
||||
<button class="sidebar-link" type="button" data-tab="scrobbling">Scrobbling</button>
|
||||
<button class="sidebar-link" type="button" data-tab="config">Configuration</button>
|
||||
<button class="sidebar-link" type="button" data-tab="endpoints">API Analytics</button>
|
||||
</nav>
|
||||
<div class="sidebar-footer">
|
||||
<div class="auth-user hidden" id="auth-user-display">
|
||||
Signed in as <strong id="auth-user-name">-</strong>
|
||||
</div>
|
||||
<button id="auth-logout-btn" data-action="logoutAdminSession" class="hidden">Logout</button>
|
||||
</div>
|
||||
</div>
|
||||
</header>
|
||||
</aside>
|
||||
|
||||
<div class="tabs">
|
||||
<div class="tab active" data-tab="dashboard">Dashboard</div>
|
||||
<div class="tab" data-tab="jellyfin-playlists">Link Playlists</div>
|
||||
<div class="tab" data-tab="playlists">Injected Playlists</div>
|
||||
<div class="tab" data-tab="kept">Kept Downloads</div>
|
||||
<div class="tab" data-tab="scrobbling">Scrobbling</div>
|
||||
<div class="tab" data-tab="config">Configuration</div>
|
||||
<div class="tab" data-tab="endpoints">API Analytics</div>
|
||||
</div>
|
||||
<main class="app-main">
|
||||
<header class="app-header">
|
||||
<h1>
|
||||
Allstarr <span class="version" id="version">Loading...</span>
|
||||
</h1>
|
||||
<div class="header-actions">
|
||||
<div id="status-indicator">
|
||||
<span class="status-badge" id="spotify-status">
|
||||
<span class="status-dot"></span>
|
||||
<span>Loading...</span>
|
||||
</span>
|
||||
</div>
|
||||
</div>
|
||||
</header>
|
||||
|
||||
<div class="tabs top-tabs" aria-hidden="true">
|
||||
<div class="tab active" data-tab="dashboard">Dashboard</div>
|
||||
<div class="tab" data-tab="jellyfin-playlists">Link Playlists</div>
|
||||
<div class="tab" data-tab="playlists">Injected Playlists</div>
|
||||
<div class="tab" data-tab="kept">Kept Downloads</div>
|
||||
<div class="tab" data-tab="scrobbling">Scrobbling</div>
|
||||
<div class="tab" data-tab="config">Configuration</div>
|
||||
<div class="tab" data-tab="endpoints">API Analytics</div>
|
||||
</div>
|
||||
|
||||
<!-- Dashboard Tab -->
|
||||
<div class="tab-content active" id="tab-dashboard">
|
||||
@@ -113,9 +141,9 @@
|
||||
</h2>
|
||||
<div id="dashboard-guidance" class="guidance-stack"></div>
|
||||
<div class="card-actions-row">
|
||||
<button class="primary" onclick="refreshPlaylists()">Refresh All Playlists</button>
|
||||
<button onclick="clearCache()">Clear Cache</button>
|
||||
<button onclick="openAddPlaylist()">Add Playlist</button>
|
||||
<button class="primary" data-action="refreshPlaylists">Refresh All Playlists</button>
|
||||
<button data-action="clearCache">Clear Cache</button>
|
||||
<button data-action="openAddPlaylist">Add Playlist</button>
|
||||
<button onclick="window.location.href='/spotify-mappings.html'">View Spotify Mappings</button>
|
||||
</div>
|
||||
</div>
|
||||
@@ -130,7 +158,7 @@
|
||||
<button onclick="fetchJellyfinPlaylists()">Refresh</button>
|
||||
</div>
|
||||
</h2>
|
||||
<p style="color: var(--text-secondary); margin-bottom: 16px;">
|
||||
<p class="text-secondary mb-16">
|
||||
Connect your Jellyfin playlists to Spotify playlists. Allstarr will automatically fill in missing
|
||||
tracks from Spotify using your preferred music service (SquidWTF/Deezer/Qobuz).
|
||||
<br><strong>Tip:</strong> Use the sp_dc cookie method for best results - it's simpler and more
|
||||
@@ -138,10 +166,9 @@
|
||||
</p>
|
||||
<div id="jellyfin-guidance" class="guidance-stack"></div>
|
||||
|
||||
<div id="jellyfin-user-filter" style="display: flex; gap: 16px; margin-bottom: 16px; flex-wrap: wrap;">
|
||||
<div class="form-group" style="margin: 0; flex: 1; min-width: 200px;">
|
||||
<label
|
||||
style="display: block; margin-bottom: 4px; color: var(--text-secondary); font-size: 0.85rem;">User</label>
|
||||
<div id="jellyfin-user-filter" class="flex-row-wrap mb-16">
|
||||
<div class="form-group jellyfin-user-form-group">
|
||||
<label class="text-secondary">User</label>
|
||||
<select id="jellyfin-user-select" onchange="fetchJellyfinPlaylists()"
|
||||
style="width: 100%; padding: 8px; background: var(--bg-secondary); border: 1px solid var(--border); border-radius: 6px; color: var(--text-primary);">
|
||||
<option value="">All Users</option>
|
||||
@@ -217,7 +244,7 @@
|
||||
</div>
|
||||
</details>
|
||||
|
||||
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
||||
<p class="text-secondary mb-12">
|
||||
These are the Spotify playlists currently being injected into Jellyfin with tracks from your music
|
||||
service.
|
||||
</p>
|
||||
@@ -253,15 +280,14 @@
|
||||
Manual mappings override automatic matching for external providers (SquidWTF, Deezer, Qobuz). For
|
||||
local Jellyfin tracks, use the Spotify Import plugin instead.
|
||||
</p>
|
||||
<div id="mappings-summary"
|
||||
style="display: flex; gap: 20px; margin-bottom: 16px; padding: 12px; background: var(--bg-tertiary); border-radius: 6px;">
|
||||
<div id="mappings-summary" class="summary-box">
|
||||
<div>
|
||||
<span style="color: var(--text-secondary);">Total:</span>
|
||||
<span style="font-weight: 600; margin-left: 8px;" id="mappings-total">0</span>
|
||||
<span class="summary-label">Total:</span>
|
||||
<span class="summary-value" id="mappings-total">0</span>
|
||||
</div>
|
||||
<div>
|
||||
<span style="color: var(--text-secondary);">External:</span>
|
||||
<span style="font-weight: 600; margin-left: 8px; color: var(--success);"
|
||||
<span class="summary-label">External:</span>
|
||||
<span class="summary-value success"
|
||||
id="mappings-external">0</span>
|
||||
</div>
|
||||
</div>
|
||||
@@ -294,15 +320,14 @@
|
||||
<button onclick="fetchMissingTracks()">Refresh</button>
|
||||
</div>
|
||||
</h2>
|
||||
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
||||
<p class="text-secondary mb-12">
|
||||
Tracks that couldn't be matched locally or externally. Map them manually to add them to your
|
||||
playlists.
|
||||
</p>
|
||||
<div id="missing-summary"
|
||||
style="display: flex; gap: 20px; margin-bottom: 16px; padding: 12px; background: var(--bg-tertiary); border-radius: 6px;">
|
||||
<div id="missing-summary" class="summary-box">
|
||||
<div>
|
||||
<span style="color: var(--text-secondary);">Total Missing:</span>
|
||||
<span style="font-weight: 600; margin-left: 8px; color: var(--warning);"
|
||||
<span class="summary-label">Total Missing:</span>
|
||||
<span class="summary-value warning"
|
||||
id="missing-total">0</span>
|
||||
</div>
|
||||
</div>
|
||||
@@ -333,23 +358,23 @@
|
||||
<h2>
|
||||
Kept Downloads
|
||||
<div class="actions">
|
||||
<button onclick="downloadAllKept()" style="background:var(--accent);border-color:var(--accent);">Download All</button>
|
||||
<button onclick="downloadAllKept()" class="primary">Download All</button>
|
||||
<button onclick="deleteAllKept()" class="danger">Delete All</button>
|
||||
<button onclick="fetchDownloads()">Refresh</button>
|
||||
</div>
|
||||
</h2>
|
||||
<p style="color: var(--text-secondary); margin-bottom: 12px;">
|
||||
<p class="text-secondary mb-12">
|
||||
Downloaded files stored permanently. Download individual tracks or download all as a zip archive.
|
||||
</p>
|
||||
<div id="downloads-summary"
|
||||
style="display: flex; gap: 20px; margin-bottom: 16px; padding: 12px; background: var(--bg-tertiary); border-radius: 6px;">
|
||||
<div id="downloads-summary" class="summary-box">
|
||||
<div>
|
||||
<span style="color: var(--text-secondary);">Total Files:</span>
|
||||
<span style="font-weight: 600; margin-left: 8px; color: var(--accent);"
|
||||
<span class="summary-label">Total Files:</span>
|
||||
<span class="summary-value accent"
|
||||
id="downloads-count">0</span>
|
||||
</div>
|
||||
<div>
|
||||
<span style="color: var(--text-secondary);">Total Size:</span>
|
||||
<span style="font-weight: 600; margin-left: 8px; color: var(--accent);" id="downloads-size">0
|
||||
<span class="summary-label">Total Size:</span>
|
||||
<span class="summary-value accent" id="downloads-size">0
|
||||
B</span>
|
||||
</div>
|
||||
</div>
|
||||
@@ -631,6 +656,12 @@
|
||||
<button
|
||||
onclick="openEditSetting('DEEZER_QUALITY', 'Deezer Quality', 'select', '', ['FLAC', 'MP3_320', 'MP3_128'])">Edit</button>
|
||||
</div>
|
||||
<div class="config-item">
|
||||
<span class="label">Request Interval</span>
|
||||
<span class="value" id="config-deezer-ratelimit">200 ms</span>
|
||||
<button
|
||||
onclick="openEditSetting('DEEZER_MIN_REQUEST_INTERVAL_MS', 'Deezer Request Interval', 'number', 'Minimum milliseconds between API requests (default: 200)')">Edit</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
@@ -643,6 +674,12 @@
|
||||
<button
|
||||
onclick="openEditSetting('SQUIDWTF_QUALITY', 'SquidWTF Quality', 'select', 'HI_RES_LOSSLESS: 24-bit/192kHz FLAC (highest)\\nLOSSLESS: 16-bit/44.1kHz FLAC (default)\\nHIGH: 320kbps AAC\\nLOW: 96kbps AAC', ['HI_RES_LOSSLESS', 'LOSSLESS', 'HIGH', 'LOW'])">Edit</button>
|
||||
</div>
|
||||
<div class="config-item">
|
||||
<span class="label">Request Interval</span>
|
||||
<span class="value" id="config-squid-ratelimit">200 ms</span>
|
||||
<button
|
||||
onclick="openEditSetting('SQUIDWTF_MIN_REQUEST_INTERVAL_MS', 'SquidWTF Request Interval', 'number', 'Minimum milliseconds between API requests (default: 200)')">Edit</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
@@ -680,10 +717,16 @@
|
||||
onclick="openEditSetting('QOBUZ_USER_AUTH_TOKEN', 'Qobuz User Auth Token', 'password', 'Get from browser while logged into Qobuz')">Update</button>
|
||||
</div>
|
||||
<div class="config-item">
|
||||
<span class="label">Quality</span>
|
||||
<span class="label">Preferred Quality</span>
|
||||
<span class="value" id="config-qobuz-quality">-</span>
|
||||
<button
|
||||
onclick="openEditSetting('QOBUZ_QUALITY', 'Qobuz Quality', 'select', '', ['FLAC_24_192', 'FLAC_24_96', 'FLAC_16_44', 'MP3_320'])">Edit</button>
|
||||
onclick="openEditSetting('QOBUZ_QUALITY', 'Qobuz Quality', 'select', 'Default: FLAC', ['FLAC', 'FLAC_24_HIGH', 'FLAC_24_LOW', 'FLAC_16', 'MP3_320'])">Edit</button>
|
||||
</div>
|
||||
<div class="config-item">
|
||||
<span class="label">Request Interval</span>
|
||||
<span class="value" id="config-qobuz-ratelimit">200 ms</span>
|
||||
<button
|
||||
onclick="openEditSetting('QOBUZ_MIN_REQUEST_INTERVAL_MS', 'Qobuz Request Interval', 'number', 'Minimum milliseconds between API requests (default: 200)')">Edit</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -833,7 +876,7 @@
|
||||
</p>
|
||||
<div style="display: flex; gap: 12px; flex-wrap: wrap;">
|
||||
<button class="danger" onclick="clearCache()">Clear All Cache</button>
|
||||
<button class="danger" onclick="restartContainer()">Restart Container</button>
|
||||
<button class="danger" onclick="restartContainer()">Restart Allstarr</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -929,6 +972,18 @@
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<footer class="support-footer">
|
||||
<p>
|
||||
If Allstarr has helped you, or maybe even replaced a monthly streaming service subscription, consider
|
||||
supporting its development via
|
||||
<a href="https://github.com/sponsors/SoPat712" target="_blank" rel="noopener noreferrer">GitHub Sponsor</a>
|
||||
or
|
||||
<a href="https://ko-fi.com/joshpatra" target="_blank" rel="noopener noreferrer">Ko-Fi</a>.
|
||||
</p>
|
||||
</footer>
|
||||
</main>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<!-- Add Playlist Modal -->
|
||||
|
||||
@@ -0,0 +1,84 @@
|
||||
function toBoolean(value) {
|
||||
if (value === true || value === false) {
|
||||
return value;
|
||||
}
|
||||
const normalized = String(value ?? "")
|
||||
.trim()
|
||||
.toLowerCase();
|
||||
return normalized === "true" || normalized === "1" || normalized === "yes";
|
||||
}
|
||||
|
||||
function toNumber(value) {
|
||||
const parsed = Number(value);
|
||||
return Number.isFinite(parsed) ? parsed : null;
|
||||
}
|
||||
|
||||
function getActionArgs(el) {
|
||||
if (!el || !el.dataset) {
|
||||
return {};
|
||||
}
|
||||
|
||||
// Convention:
|
||||
// - data-action="foo"
|
||||
// - data-arg-bar="baz" => { bar: "baz" }
|
||||
const args = {};
|
||||
for (const [key, value] of Object.entries(el.dataset)) {
|
||||
if (!key.startsWith("arg")) continue;
|
||||
const argName = key.slice(3);
|
||||
if (!argName) continue;
|
||||
const normalized =
|
||||
argName.charAt(0).toLowerCase() + argName.slice(1);
|
||||
args[normalized] = value;
|
||||
}
|
||||
|
||||
return args;
|
||||
}
|
||||
|
||||
export function initActionDispatcher({ root = document } = {}) {
|
||||
const handlers = new Map();
|
||||
|
||||
function register(actionName, handler) {
|
||||
if (!actionName || typeof handler !== "function") {
|
||||
return;
|
||||
}
|
||||
handlers.set(actionName, handler);
|
||||
}
|
||||
|
||||
async function dispatch(actionName, el, event = null) {
|
||||
const handler = handlers.get(actionName);
|
||||
const args = getActionArgs(el);
|
||||
|
||||
if (handler) {
|
||||
return await handler({ el, event, args, toBoolean, toNumber });
|
||||
}
|
||||
|
||||
// Transitional fallback: if a legacy window function exists, call it.
|
||||
// This allows incremental conversion away from inline onclick.
|
||||
const legacy = typeof window !== "undefined" ? window[actionName] : null;
|
||||
if (typeof legacy === "function") {
|
||||
const legacyArgs = args && Object.keys(args).length > 0 ? [args] : [];
|
||||
return legacy(...legacyArgs);
|
||||
}
|
||||
|
||||
console.warn(`No handler registered for action "${actionName}"`);
|
||||
return null;
|
||||
}
|
||||
|
||||
function bind() {
|
||||
root.addEventListener("click", (event) => {
|
||||
const trigger = event.target?.closest?.("[data-action]");
|
||||
if (!trigger) return;
|
||||
|
||||
const actionName = trigger.getAttribute("data-action") || "";
|
||||
if (!actionName) return;
|
||||
|
||||
event.preventDefault();
|
||||
dispatch(actionName, trigger, event);
|
||||
});
|
||||
}
|
||||
|
||||
bind();
|
||||
|
||||
return { register, dispatch };
|
||||
}
|
||||
|
||||
@@ -124,6 +124,14 @@ export async function deleteDownload(path) {
|
||||
);
|
||||
}
|
||||
|
||||
export async function deleteAllDownloads() {
|
||||
return requestJson(
|
||||
"/api/admin/downloads/all",
|
||||
{ method: "DELETE" },
|
||||
"Failed to delete all downloads",
|
||||
);
|
||||
}
|
||||
|
||||
export async function fetchConfig() {
|
||||
return requestJson(
|
||||
"/api/admin/config",
|
||||
@@ -144,10 +152,15 @@ export async function fetchJellyfinUsers() {
|
||||
return requestOptionalJson("/api/admin/jellyfin/users");
|
||||
}
|
||||
|
||||
export async function fetchJellyfinPlaylists(userId = null) {
|
||||
export async function fetchJellyfinPlaylists(userId = null, includeStats = true) {
|
||||
let url = "/api/admin/jellyfin/playlists";
|
||||
const params = [];
|
||||
if (userId) {
|
||||
url += "?userId=" + encodeURIComponent(userId);
|
||||
params.push("userId=" + encodeURIComponent(userId));
|
||||
}
|
||||
params.push("includeStats=" + String(Boolean(includeStats)));
|
||||
if (params.length > 0) {
|
||||
url += "?" + params.join("&");
|
||||
}
|
||||
|
||||
return requestJson(url, {}, "Failed to fetch Jellyfin playlists");
|
||||
@@ -274,7 +287,7 @@ export async function restartContainer() {
|
||||
return requestJson(
|
||||
"/api/admin/restart",
|
||||
{ method: "POST" },
|
||||
"Failed to restart container",
|
||||
"Failed to restart Allstarr",
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { escapeHtml, showToast, formatCookieAge } from "./utils.js";
|
||||
import { escapeHtml, escapeJs, showToast, formatCookieAge } from "./utils.js";
|
||||
import * as API from "./api.js";
|
||||
import * as UI from "./ui.js";
|
||||
import { renderCookieAge } from "./settings-editor.js";
|
||||
@@ -6,6 +6,7 @@ import { runAction } from "./operations.js";
|
||||
|
||||
let playlistAutoRefreshInterval = null;
|
||||
let dashboardRefreshInterval = null;
|
||||
let downloadActivityEventSource = null;
|
||||
|
||||
let isAuthenticated = () => false;
|
||||
let isAdminSession = () => false;
|
||||
@@ -14,6 +15,7 @@ let onCookieNeedsInit = async () => {};
|
||||
let setCurrentConfigState = () => {};
|
||||
let syncConfigUiExtras = () => {};
|
||||
let loadScrobblingConfig = () => {};
|
||||
let jellyfinPlaylistRequestToken = 0;
|
||||
|
||||
async function fetchStatus() {
|
||||
try {
|
||||
@@ -128,6 +130,7 @@ async function fetchMissingTracks() {
|
||||
missing.forEach((t) => {
|
||||
missingTracks.push({
|
||||
playlist: playlist.name,
|
||||
provider: t.externalProvider || t.provider || "squidwtf",
|
||||
...t,
|
||||
});
|
||||
});
|
||||
@@ -150,6 +153,7 @@ async function fetchMissingTracks() {
|
||||
const artist =
|
||||
t.artists && t.artists.length > 0 ? t.artists.join(", ") : "";
|
||||
const searchQuery = `${t.title} ${artist}`;
|
||||
const provider = t.provider || "squidwtf";
|
||||
const trackPosition = Number.isFinite(t.position)
|
||||
? Number(t.position)
|
||||
: 0;
|
||||
@@ -162,7 +166,7 @@ async function fetchMissingTracks() {
|
||||
<td class="mapping-actions-cell">
|
||||
<button class="map-action-btn map-action-search missing-track-search-btn"
|
||||
data-query="${escapeHtml(searchQuery)}"
|
||||
data-provider="squidwtf">🔍 Search</button>
|
||||
data-provider="${escapeHtml(provider)}">🔍 Search</button>
|
||||
<button class="map-action-btn map-action-local missing-track-local-btn"
|
||||
data-playlist="${escapeHtml(t.playlist)}"
|
||||
data-position="${trackPosition}"
|
||||
@@ -212,9 +216,9 @@ async function fetchDownloads() {
|
||||
<td style="font-family:monospace;font-size:0.85rem;">${escapeHtml(f.fileName)}</td>
|
||||
<td style="color:var(--text-secondary);">${f.sizeFormatted}</td>
|
||||
<td>
|
||||
<button onclick="downloadFile('${escapeJs(f.path)}')"
|
||||
<button data-action="downloadFile" data-arg-path="${escapeHtml(escapeJs(f.path))}"
|
||||
style="margin-right:4px;font-size:0.75rem;padding:4px 8px;background:var(--accent);border-color:var(--accent);">Download</button>
|
||||
<button onclick="deleteDownload('${escapeJs(f.path)}')"
|
||||
<button data-action="deleteDownload" data-arg-path="${escapeHtml(escapeJs(f.path))}"
|
||||
class="danger" style="font-size:0.75rem;padding:4px 8px;">Delete</button>
|
||||
</td>
|
||||
</tr>
|
||||
@@ -244,11 +248,28 @@ async function fetchJellyfinPlaylists() {
|
||||
'<tr><td colspan="4" class="loading"><span class="spinner"></span> Loading Jellyfin playlists...</td></tr>';
|
||||
|
||||
try {
|
||||
const requestToken = ++jellyfinPlaylistRequestToken;
|
||||
const userId = isAdminSession()
|
||||
? document.getElementById("jellyfin-user-select")?.value
|
||||
: null;
|
||||
const data = await API.fetchJellyfinPlaylists(userId);
|
||||
UI.updateJellyfinPlaylistsUI(data);
|
||||
const baseData = await API.fetchJellyfinPlaylists(userId, false);
|
||||
if (requestToken !== jellyfinPlaylistRequestToken) {
|
||||
return;
|
||||
}
|
||||
|
||||
UI.updateJellyfinPlaylistsUI(baseData);
|
||||
|
||||
// Enrich counts after initial render so big accounts don't appear empty.
|
||||
API.fetchJellyfinPlaylists(userId, true)
|
||||
.then((statsData) => {
|
||||
if (requestToken !== jellyfinPlaylistRequestToken) {
|
||||
return;
|
||||
}
|
||||
UI.updateJellyfinPlaylistsUI(statsData);
|
||||
})
|
||||
.catch((err) => {
|
||||
console.error("Failed to fetch Jellyfin playlist track stats:", err);
|
||||
});
|
||||
} catch (error) {
|
||||
console.error("Failed to fetch Jellyfin playlists:", error);
|
||||
tbody.innerHTML =
|
||||
@@ -324,6 +345,10 @@ function stopDashboardRefresh() {
|
||||
clearInterval(dashboardRefreshInterval);
|
||||
dashboardRefreshInterval = null;
|
||||
}
|
||||
if (downloadActivityEventSource) {
|
||||
downloadActivityEventSource.close();
|
||||
downloadActivityEventSource = null;
|
||||
}
|
||||
stopPlaylistAutoRefresh();
|
||||
}
|
||||
|
||||
@@ -341,7 +366,10 @@ function startDashboardRefresh() {
|
||||
fetchPlaylists();
|
||||
fetchTrackMappings();
|
||||
fetchMissingTracks();
|
||||
fetchDownloads();
|
||||
const keptTab = document.getElementById("tab-kept");
|
||||
if (keptTab && keptTab.classList.contains("active")) {
|
||||
fetchDownloads();
|
||||
}
|
||||
|
||||
const endpointsTab = document.getElementById("tab-endpoints");
|
||||
if (endpointsTab && endpointsTab.classList.contains("active")) {
|
||||
@@ -377,6 +405,133 @@ async function loadDashboardData() {
|
||||
startDashboardRefresh();
|
||||
}
|
||||
|
||||
function startDownloadActivityStream() {
|
||||
if (!isAdminSession()) return;
|
||||
|
||||
if (downloadActivityEventSource) {
|
||||
downloadActivityEventSource.close();
|
||||
}
|
||||
|
||||
downloadActivityEventSource = new EventSource("/api/admin/downloads/activity");
|
||||
|
||||
downloadActivityEventSource.onmessage = (event) => {
|
||||
try {
|
||||
const downloads = JSON.parse(event.data);
|
||||
renderDownloadActivity(downloads);
|
||||
} catch (err) {
|
||||
console.error("Failed to parse download activity:", err);
|
||||
}
|
||||
};
|
||||
|
||||
downloadActivityEventSource.onerror = (err) => {
|
||||
console.error("Download activity SSE error:", err);
|
||||
// EventSource will auto-reconnect
|
||||
};
|
||||
}
|
||||
|
||||
function renderDownloadActivity(downloads) {
|
||||
const container = document.getElementById("download-activity-list");
|
||||
if (!container) return;
|
||||
|
||||
if (!downloads || downloads.length === 0) {
|
||||
container.innerHTML = '<div class="empty-state">No active downloads</div>';
|
||||
return;
|
||||
}
|
||||
|
||||
const statusIcons = {
|
||||
0: '⏳', // NotStarted
|
||||
1: '<span class="spinner" style="border-width:2px; height:12px; width:12px; display:inline-block; margin-right:4px;"></span> Downloading', // InProgress
|
||||
2: '✅ Completed', // Completed
|
||||
3: '❌ Failed' // Failed
|
||||
};
|
||||
|
||||
const html = downloads.map(d => {
|
||||
const downloadProgress = clampProgress(d.progress);
|
||||
const playbackProgress = clampProgress(d.playbackProgress);
|
||||
|
||||
// Determine elapsed/duration text
|
||||
let timeText = "";
|
||||
if (d.startedAt) {
|
||||
const start = new Date(d.startedAt);
|
||||
const end = d.completedAt ? new Date(d.completedAt) : new Date();
|
||||
const diffSecs = Math.floor((end.getTime() - start.getTime()) / 1000);
|
||||
timeText = diffSecs < 60 ? `${diffSecs}s` : `${Math.floor(diffSecs/60)}m ${diffSecs%60}s`;
|
||||
}
|
||||
|
||||
const progressMeta = [];
|
||||
if (typeof d.durationSeconds === "number" && typeof d.playbackPositionSeconds === "number") {
|
||||
progressMeta.push(`${formatSeconds(d.playbackPositionSeconds)} / ${formatSeconds(d.durationSeconds)}`);
|
||||
} else if (typeof d.durationSeconds === "number") {
|
||||
progressMeta.push(formatSeconds(d.durationSeconds));
|
||||
}
|
||||
if (d.requestedForStreaming) {
|
||||
progressMeta.push("stream");
|
||||
}
|
||||
|
||||
const progressMetaText = progressMeta.length > 0
|
||||
? `<div class="download-progress-meta">${progressMeta.map(escapeHtml).join(" • ")}</div>`
|
||||
: "";
|
||||
|
||||
const progressBar = `
|
||||
<div class="download-progress-bar" aria-hidden="true">
|
||||
<div class="download-progress-buffer" style="width:${downloadProgress * 100}%"></div>
|
||||
<div class="download-progress-playback" style="width:${playbackProgress * 100}%"></div>
|
||||
</div>
|
||||
${progressMetaText}
|
||||
`;
|
||||
|
||||
const title = d.title || 'Unknown Title';
|
||||
const artist = d.artist || 'Unknown Artist';
|
||||
const errorText = d.errorMessage ? `<div style="color:var(--error); font-size:0.8rem; margin-top:4px;">${escapeHtml(d.errorMessage)}</div>` : '';
|
||||
const streamBadge = d.requestedForStreaming
|
||||
? '<span class="download-queue-badge">Stream</span>'
|
||||
: '';
|
||||
const playingBadge = d.isPlaying
|
||||
? '<span class="download-queue-badge is-playing">Playing</span>'
|
||||
: '';
|
||||
|
||||
return `
|
||||
<div class="download-queue-item">
|
||||
<div class="download-queue-info">
|
||||
<div class="download-queue-title">${escapeHtml(title)}</div>
|
||||
<div class="download-queue-meta">
|
||||
<span class="download-queue-artist">${escapeHtml(artist)}</span>
|
||||
<span class="download-queue-provider">${escapeHtml(d.externalProvider)}</span>
|
||||
${streamBadge}
|
||||
${playingBadge}
|
||||
</div>
|
||||
${progressBar}
|
||||
${errorText}
|
||||
</div>
|
||||
<div class="download-queue-status">
|
||||
<span style="font-size:0.85rem;">${statusIcons[d.status] || 'Unknown'}</span>
|
||||
<span class="download-queue-time">${timeText}</span>
|
||||
</div>
|
||||
</div>
|
||||
`;
|
||||
}).join('');
|
||||
|
||||
container.innerHTML = html;
|
||||
}
|
||||
|
||||
function clampProgress(value) {
|
||||
if (typeof value !== "number" || Number.isNaN(value)) {
|
||||
return 0;
|
||||
}
|
||||
|
||||
return Math.max(0, Math.min(1, value));
|
||||
}
|
||||
|
||||
function formatSeconds(totalSeconds) {
|
||||
if (typeof totalSeconds !== "number" || Number.isNaN(totalSeconds) || totalSeconds < 0) {
|
||||
return "0:00";
|
||||
}
|
||||
|
||||
const minutes = Math.floor(totalSeconds / 60);
|
||||
const seconds = Math.floor(totalSeconds % 60);
|
||||
return `${minutes}:${String(seconds).padStart(2, "0")}`;
|
||||
}
|
||||
|
||||
export function initDashboardData(options) {
|
||||
isAuthenticated = options.isAuthenticated;
|
||||
isAdminSession = options.isAdminSession;
|
||||
|
||||
@@ -100,14 +100,14 @@ export async function viewTracks(name) {
|
||||
const durationSeconds = Math.floor((t.durationMs || 0) / 1000);
|
||||
const externalSearchLink =
|
||||
t.isLocal === false && t.searchQuery && t.externalProvider
|
||||
? `<br><small style="color:var(--accent)"><a href="#" onclick="searchProvider('${escapeJs(t.searchQuery)}', '${escapeJs(t.externalProvider)}'); return false;" style="color:var(--accent);text-decoration:underline;">🔍 Search: ${escapeHtml(searchLinkText)}</a></small>`
|
||||
? `<br><small style="color:var(--accent)"><a href="#" data-action="searchProvider" data-arg-query="${escapeHtml(escapeJs(t.searchQuery))}" data-arg-provider="${escapeHtml(escapeJs(t.externalProvider))}" style="color:var(--accent);text-decoration:underline;">🔍 Search: ${escapeHtml(searchLinkText)}</a></small>`
|
||||
: "";
|
||||
const missingSearchLink =
|
||||
t.isLocal === null && t.searchQuery
|
||||
? `<br><small style="color:var(--text-secondary)"><a href="#" onclick="searchProvider('${escapeJs(t.searchQuery)}', 'squidwtf'); return false;" style="color:var(--text-secondary);text-decoration:underline;">🔍 Search: ${escapeHtml(searchLinkText)}</a></small>`
|
||||
? `<br><small style="color:var(--text-secondary)"><a href="#" data-action="searchProvider" data-arg-query="${escapeHtml(escapeJs(t.searchQuery))}" data-arg-provider="squidwtf" style="color:var(--text-secondary);text-decoration:underline;">🔍 Search: ${escapeHtml(searchLinkText)}</a></small>`
|
||||
: "";
|
||||
|
||||
const lyricsMapButton = `<button class="small" onclick="openLyricsMap('${escapeJs(firstArtist)}', '${escapeJs(t.title)}', '${escapeJs(t.album || "")}', ${durationSeconds})" style="margin-left:4px;font-size:0.75rem;padding:4px 8px;background:#3b82f6;border-color:#3b82f6;color:white;">Map Lyrics ID</button>`;
|
||||
const lyricsMapButton = `<button class="small" data-action="openLyricsMap" data-arg-artist="${escapeHtml(escapeJs(firstArtist))}" data-arg-title="${escapeHtml(escapeJs(t.title))}" data-arg-album="${escapeHtml(escapeJs(t.album || ""))}" data-arg-duration-seconds="${durationSeconds}" style="margin-left:4px;font-size:0.75rem;padding:4px 8px;background:#3b82f6;border-color:#3b82f6;color:white;">Map Lyrics ID</button>`;
|
||||
|
||||
return `
|
||||
<div class="track-item" data-position="${t.position}">
|
||||
@@ -246,7 +246,7 @@ export async function searchJellyfinTracks() {
|
||||
const artist = track.artist || "";
|
||||
const album = track.album || "";
|
||||
return `
|
||||
<div class="jellyfin-result" data-jellyfin-id="${escapeHtml(id)}" onclick="selectJellyfinTrack('${escapeJs(id)}')">
|
||||
<div class="jellyfin-result" data-jellyfin-id="${escapeHtml(id)}" data-action="selectJellyfinTrack" data-arg-jellyfin-id="${escapeHtml(escapeJs(id))}">
|
||||
<div>
|
||||
<strong>${escapeHtml(title)}</strong>
|
||||
<br>
|
||||
@@ -344,7 +344,15 @@ export async function searchExternalTracks() {
|
||||
const externalUrl = track.url || "";
|
||||
|
||||
return `
|
||||
<div class="external-result" data-result-index="${index}" data-external-id="${escapeHtml(id)}" onclick="selectExternalTrack(${index}, '${escapeJs(id)}', '${escapeJs(title)}', '${escapeJs(artist)}', '${escapeJs(providerName)}', '${escapeJs(externalUrl)}')">
|
||||
<div class="external-result" data-result-index="${index}" data-external-id="${escapeHtml(id)}"
|
||||
data-action="selectExternalTrack"
|
||||
data-arg-result-index="${index}"
|
||||
data-arg-external-id="${escapeHtml(escapeJs(id))}"
|
||||
data-arg-title="${escapeHtml(escapeJs(title))}"
|
||||
data-arg-artist="${escapeHtml(escapeJs(artist))}"
|
||||
data-arg-provider="${escapeHtml(escapeJs(providerName))}"
|
||||
data-arg-external-url="${escapeHtml(escapeJs(externalUrl))}"
|
||||
>
|
||||
<div>
|
||||
<strong>${escapeHtml(title)}</strong>
|
||||
<br>
|
||||
@@ -662,13 +670,26 @@ export async function saveLyricsMapping() {
|
||||
// Search provider (open in new tab)
|
||||
export async function searchProvider(query, provider) {
|
||||
try {
|
||||
const data = await API.getSquidWTFBaseUrl();
|
||||
const baseUrl = data.baseUrl; // Use the actual property name from API
|
||||
const searchUrl = `${baseUrl}/music/search?q=${encodeURIComponent(query)}`;
|
||||
const normalizedProvider = (provider || "squidwtf").toLowerCase();
|
||||
let searchUrl = "";
|
||||
|
||||
if (normalizedProvider === "squidwtf" || normalizedProvider === "tidal") {
|
||||
const data = await API.getSquidWTFBaseUrl();
|
||||
const baseUrl = data.baseUrl;
|
||||
searchUrl = `${baseUrl}/search/?s=${encodeURIComponent(query)}`;
|
||||
} else if (normalizedProvider === "deezer") {
|
||||
searchUrl = `https://www.deezer.com/search/${encodeURIComponent(query)}`;
|
||||
} else if (normalizedProvider === "qobuz") {
|
||||
searchUrl = `https://www.qobuz.com/search?query=${encodeURIComponent(query)}`;
|
||||
} else {
|
||||
const data = await API.getSquidWTFBaseUrl();
|
||||
const baseUrl = data.baseUrl;
|
||||
searchUrl = `${baseUrl}/search/?s=${encodeURIComponent(query)}`;
|
||||
}
|
||||
|
||||
window.open(searchUrl, "_blank");
|
||||
} catch (error) {
|
||||
console.error("Failed to get SquidWTF base URL:", error);
|
||||
// Fallback to first encoded URL (triton)
|
||||
showToast("Failed to get SquidWTF URL, using fallback", "warning");
|
||||
console.error("Failed to open provider search:", error);
|
||||
showToast("Failed to open provider search link", "warning");
|
||||
}
|
||||
}
|
||||
|
||||
+104
-29
@@ -34,17 +34,13 @@ import {
|
||||
} from "./playlist-admin.js";
|
||||
import { initScrobblingAdmin } from "./scrobbling-admin.js";
|
||||
import { initAuthSession } from "./auth-session.js";
|
||||
import { initActionDispatcher } from "./action-dispatcher.js";
|
||||
import { initNavigationView } from "./views/navigation-view.js";
|
||||
import { initScrobblingView } from "./views/scrobbling-view.js";
|
||||
|
||||
let cookieDateInitialized = false;
|
||||
let restartRequired = false;
|
||||
|
||||
window.showToast = showToast;
|
||||
window.escapeHtml = escapeHtml;
|
||||
window.escapeJs = escapeJs;
|
||||
window.openModal = openModal;
|
||||
window.closeModal = closeModal;
|
||||
window.capitalizeProvider = capitalizeProvider;
|
||||
|
||||
window.showRestartBanner = function () {
|
||||
restartRequired = true;
|
||||
document.getElementById("restart-banner")?.classList.add("active");
|
||||
@@ -58,17 +54,30 @@ window.switchTab = function (tabName) {
|
||||
document
|
||||
.querySelectorAll(".tab")
|
||||
.forEach((tab) => tab.classList.remove("active"));
|
||||
document
|
||||
.querySelectorAll(".sidebar-link")
|
||||
.forEach((link) => link.classList.remove("active"));
|
||||
document
|
||||
.querySelectorAll(".tab-content")
|
||||
.forEach((content) => content.classList.remove("active"));
|
||||
|
||||
const tab = document.querySelector(`.tab[data-tab="${tabName}"]`);
|
||||
const sidebarLink = document.querySelector(
|
||||
`.sidebar-link[data-tab="${tabName}"]`,
|
||||
);
|
||||
const content = document.getElementById(`tab-${tabName}`);
|
||||
|
||||
if (tab && content) {
|
||||
tab.classList.add("active");
|
||||
if (sidebarLink) {
|
||||
sidebarLink.classList.add("active");
|
||||
}
|
||||
content.classList.add("active");
|
||||
window.location.hash = tabName;
|
||||
|
||||
if (tabName === "kept" && typeof window.fetchDownloads === "function") {
|
||||
window.fetchDownloads();
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
@@ -138,46 +147,112 @@ const authSession = initAuthSession({
|
||||
},
|
||||
});
|
||||
|
||||
window.viewTracks = viewTracks;
|
||||
window.openManualMap = openManualMap;
|
||||
window.openExternalMap = openExternalMap;
|
||||
window.openMapToLocal = openManualMap;
|
||||
window.openMapToExternal = openExternalMap;
|
||||
window.openModal = openModal;
|
||||
window.closeModal = closeModal;
|
||||
window.searchJellyfinTracks = searchJellyfinTracks;
|
||||
window.selectJellyfinTrack = selectJellyfinTrack;
|
||||
window.saveLocalMapping = saveLocalMapping;
|
||||
window.saveManualMapping = saveManualMapping;
|
||||
window.searchExternalTracks = searchExternalTracks;
|
||||
window.selectExternalTrack = selectExternalTrack;
|
||||
window.validateExternalMapping = validateExternalMapping;
|
||||
window.openLyricsMap = openLyricsMap;
|
||||
window.saveLyricsMapping = saveLyricsMapping;
|
||||
window.searchProvider = searchProvider;
|
||||
window.validateExternalMapping = validateExternalMapping;
|
||||
window.saveLyricsMapping = saveLyricsMapping;
|
||||
// Note: viewTracks/selectExternalTrack/selectJellyfinTrack/openLyricsMap/searchProvider
|
||||
// are now wired via the ActionDispatcher and no longer require window exports.
|
||||
|
||||
document.addEventListener("DOMContentLoaded", () => {
|
||||
console.log("🚀 Allstarr Admin UI (Modular) loaded");
|
||||
|
||||
document.querySelectorAll(".tab").forEach((tab) => {
|
||||
tab.addEventListener("click", () => {
|
||||
window.switchTab(tab.dataset.tab);
|
||||
});
|
||||
const dispatcher = initActionDispatcher({ root: document });
|
||||
// Register a few core actions first; more will be migrated as inline
|
||||
// onclick handlers are removed from HTML and generated markup.
|
||||
dispatcher.register("switchTab", ({ args }) => {
|
||||
const tab = args?.tab || args?.tabName;
|
||||
if (tab) {
|
||||
window.switchTab(tab);
|
||||
}
|
||||
});
|
||||
dispatcher.register("logoutAdminSession", () => window.logoutAdminSession?.());
|
||||
dispatcher.register("dismissRestartBanner", () =>
|
||||
window.dismissRestartBanner?.(),
|
||||
);
|
||||
dispatcher.register("restartContainer", () => window.restartContainer?.());
|
||||
dispatcher.register("refreshPlaylists", () => window.refreshPlaylists?.());
|
||||
dispatcher.register("clearCache", () => window.clearCache?.());
|
||||
dispatcher.register("openAddPlaylist", () => window.openAddPlaylist?.());
|
||||
dispatcher.register("toggleRowMenu", ({ event, args }) =>
|
||||
window.toggleRowMenu?.(event, args?.menuId),
|
||||
);
|
||||
dispatcher.register("toggleDetailsRow", ({ event, args }) =>
|
||||
window.toggleDetailsRow?.(event, args?.detailsRowId),
|
||||
);
|
||||
dispatcher.register("viewTracks", ({ args }) => viewTracks(args?.playlistName));
|
||||
dispatcher.register("refreshPlaylist", ({ args }) =>
|
||||
window.refreshPlaylist?.(args?.playlistName),
|
||||
);
|
||||
dispatcher.register("matchPlaylistTracks", ({ args }) =>
|
||||
window.matchPlaylistTracks?.(args?.playlistName),
|
||||
);
|
||||
dispatcher.register("clearPlaylistCache", ({ args }) =>
|
||||
window.clearPlaylistCache?.(args?.playlistName),
|
||||
);
|
||||
dispatcher.register("editPlaylistSchedule", ({ args }) =>
|
||||
window.editPlaylistSchedule?.(args?.playlistName, args?.syncSchedule),
|
||||
);
|
||||
dispatcher.register("removePlaylist", ({ args }) =>
|
||||
window.removePlaylist?.(args?.playlistName),
|
||||
);
|
||||
dispatcher.register("openLinkPlaylist", ({ args }) =>
|
||||
window.openLinkPlaylist?.(args?.jellyfinId, args?.jellyfinName),
|
||||
);
|
||||
dispatcher.register("unlinkPlaylist", ({ args }) =>
|
||||
window.unlinkPlaylist?.(args?.jellyfinId, args?.jellyfinName),
|
||||
);
|
||||
dispatcher.register("fetchJellyfinPlaylists", () =>
|
||||
window.fetchJellyfinPlaylists?.(),
|
||||
);
|
||||
dispatcher.register("searchProvider", ({ args }) =>
|
||||
searchProvider(args?.query, args?.provider),
|
||||
);
|
||||
dispatcher.register("openLyricsMap", ({ args, toNumber }) =>
|
||||
openLyricsMap(
|
||||
args?.artist,
|
||||
args?.title,
|
||||
args?.album,
|
||||
toNumber(args?.durationSeconds) ?? 0,
|
||||
),
|
||||
);
|
||||
dispatcher.register("selectJellyfinTrack", ({ args }) =>
|
||||
selectJellyfinTrack(args?.jellyfinId),
|
||||
);
|
||||
dispatcher.register("selectExternalTrack", ({ args, toNumber }) =>
|
||||
selectExternalTrack(
|
||||
toNumber(args?.resultIndex),
|
||||
args?.externalId,
|
||||
args?.title,
|
||||
args?.artist,
|
||||
args?.provider,
|
||||
args?.externalUrl,
|
||||
),
|
||||
);
|
||||
dispatcher.register("downloadFile", ({ args }) =>
|
||||
window.downloadFile?.(args?.path),
|
||||
);
|
||||
dispatcher.register("deleteDownload", ({ args }) =>
|
||||
window.deleteDownload?.(args?.path),
|
||||
);
|
||||
|
||||
const hash = window.location.hash.substring(1);
|
||||
if (hash) {
|
||||
window.switchTab(hash);
|
||||
}
|
||||
initNavigationView({ switchTab: window.switchTab });
|
||||
|
||||
setupModalBackdropClose();
|
||||
|
||||
const scrobblingTab = document.querySelector('.tab[data-tab="scrobbling"]');
|
||||
if (scrobblingTab) {
|
||||
scrobblingTab.addEventListener("click", () => {
|
||||
if (authSession.isAuthenticated()) {
|
||||
window.loadScrobblingConfig();
|
||||
}
|
||||
});
|
||||
}
|
||||
initScrobblingView({
|
||||
isAuthenticated: () => authSession.isAuthenticated(),
|
||||
loadScrobblingConfig: () => window.loadScrobblingConfig?.(),
|
||||
});
|
||||
|
||||
authSession.bootstrapAuth();
|
||||
});
|
||||
|
||||
@@ -1,17 +1,100 @@
|
||||
// Modal management
|
||||
const modalState = new Map();
|
||||
const FOCUSABLE_SELECTOR =
|
||||
'a[href], button:not([disabled]), textarea, input, select, [tabindex]:not([tabindex="-1"])';
|
||||
|
||||
function getModal(id) {
|
||||
return document.getElementById(id);
|
||||
}
|
||||
|
||||
function getFocusableElements(modal) {
|
||||
return Array.from(modal.querySelectorAll(FOCUSABLE_SELECTOR)).filter(
|
||||
(el) => !el.hasAttribute("disabled") && !el.getAttribute("aria-hidden"),
|
||||
);
|
||||
}
|
||||
|
||||
function onModalKeyDown(event, modal) {
|
||||
if (event.key === "Escape") {
|
||||
event.preventDefault();
|
||||
closeModal(modal.id);
|
||||
return;
|
||||
}
|
||||
|
||||
if (event.key !== "Tab") {
|
||||
return;
|
||||
}
|
||||
|
||||
const focusable = getFocusableElements(modal);
|
||||
if (focusable.length === 0) {
|
||||
event.preventDefault();
|
||||
return;
|
||||
}
|
||||
|
||||
const first = focusable[0];
|
||||
const last = focusable[focusable.length - 1];
|
||||
const isShift = event.shiftKey;
|
||||
|
||||
if (isShift && document.activeElement === first) {
|
||||
event.preventDefault();
|
||||
last.focus();
|
||||
} else if (!isShift && document.activeElement === last) {
|
||||
event.preventDefault();
|
||||
first.focus();
|
||||
}
|
||||
}
|
||||
|
||||
export function openModal(id) {
|
||||
document.getElementById(id).classList.add('active');
|
||||
const modal = getModal(id);
|
||||
if (!modal) return;
|
||||
|
||||
const modalContent = modal.querySelector(".modal-content");
|
||||
if (!modalContent) return;
|
||||
|
||||
const previousActive = document.activeElement;
|
||||
modalState.set(id, { previousActive });
|
||||
|
||||
modal.setAttribute("role", "dialog");
|
||||
modal.setAttribute("aria-modal", "true");
|
||||
modal.removeAttribute("aria-hidden");
|
||||
modal.classList.add("active");
|
||||
|
||||
const keydownHandler = (event) => onModalKeyDown(event, modal);
|
||||
modalState.set(id, { previousActive, keydownHandler });
|
||||
modal.addEventListener("keydown", keydownHandler);
|
||||
|
||||
const focusable = getFocusableElements(modalContent);
|
||||
if (focusable.length > 0) {
|
||||
focusable[0].focus();
|
||||
} else {
|
||||
modalContent.setAttribute("tabindex", "-1");
|
||||
modalContent.focus();
|
||||
}
|
||||
}
|
||||
|
||||
export function closeModal(id) {
|
||||
document.getElementById(id).classList.remove('active');
|
||||
const modal = getModal(id);
|
||||
if (!modal) return;
|
||||
|
||||
modal.classList.remove("active");
|
||||
modal.setAttribute("aria-hidden", "true");
|
||||
|
||||
const state = modalState.get(id);
|
||||
if (state?.keydownHandler) {
|
||||
modal.removeEventListener("keydown", state.keydownHandler);
|
||||
}
|
||||
|
||||
if (state?.previousActive && typeof state.previousActive.focus === "function") {
|
||||
state.previousActive.focus();
|
||||
}
|
||||
|
||||
modalState.delete(id);
|
||||
}
|
||||
|
||||
export function setupModalBackdropClose() {
|
||||
document.querySelectorAll('.modal').forEach(modal => {
|
||||
modal.addEventListener('click', e => {
|
||||
if (e.target === modal) closeModal(modal.id);
|
||||
});
|
||||
document.querySelectorAll(".modal").forEach((modal) => {
|
||||
modal.setAttribute("aria-hidden", "true");
|
||||
modal.addEventListener("click", (e) => {
|
||||
if (e.target === modal) closeModal(modal.id);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
@@ -77,6 +77,20 @@ function downloadAllKept() {
|
||||
}
|
||||
}
|
||||
|
||||
async function deleteAllKept() {
|
||||
const result = await runAction({
|
||||
confirmMessage:
|
||||
"Delete ALL kept downloads?\n\nThis will permanently remove all kept audio files.",
|
||||
task: () => API.deleteAllDownloads(),
|
||||
success: (data) => data.message || "All kept downloads deleted",
|
||||
error: (err) => err.message || "Failed to delete all kept downloads",
|
||||
});
|
||||
|
||||
if (result) {
|
||||
await fetchDownloads();
|
||||
}
|
||||
}
|
||||
|
||||
async function deleteDownload(path) {
|
||||
const result = await runAction({
|
||||
confirmMessage: `Delete this file?\n\n${path}\n\nThis action cannot be undone.`,
|
||||
@@ -270,7 +284,7 @@ async function importEnv(event) {
|
||||
|
||||
const result = await runAction({
|
||||
confirmMessage:
|
||||
"Import this .env file? This will replace your current configuration.\n\nA backup will be created automatically.\n\nYou will need to restart the container for changes to take effect.",
|
||||
"Import this .env file? This will replace your current configuration.\n\nA backup will be created automatically.\n\nYou will need to restart Allstarr for changes to take effect.",
|
||||
task: () => API.importEnv(file),
|
||||
success: (data) => data.message,
|
||||
error: (err) => err.message || "Failed to import .env file",
|
||||
@@ -283,7 +297,7 @@ async function importEnv(event) {
|
||||
async function restartContainer() {
|
||||
if (
|
||||
!confirm(
|
||||
"Restart the container to apply configuration changes?\n\nThe dashboard will be temporarily unavailable.",
|
||||
"Restart Allstarr to reload /app/.env and apply configuration changes?\n\nThe dashboard will be temporarily unavailable.",
|
||||
)
|
||||
) {
|
||||
return;
|
||||
@@ -291,7 +305,7 @@ async function restartContainer() {
|
||||
|
||||
const result = await runAction({
|
||||
task: () => API.restartContainer(),
|
||||
error: "Failed to restart container",
|
||||
error: "Failed to restart Allstarr",
|
||||
});
|
||||
|
||||
if (!result) {
|
||||
@@ -301,7 +315,7 @@ async function restartContainer() {
|
||||
document.getElementById("restart-overlay")?.classList.add("active");
|
||||
const statusEl = document.getElementById("restart-status");
|
||||
if (statusEl) {
|
||||
statusEl.textContent = "Stopping container...";
|
||||
statusEl.textContent = "Restarting Allstarr...";
|
||||
}
|
||||
|
||||
setTimeout(() => {
|
||||
@@ -364,6 +378,7 @@ export function initOperations(options) {
|
||||
window.deleteTrackMapping = deleteTrackMapping;
|
||||
window.downloadFile = downloadFile;
|
||||
window.downloadAllKept = downloadAllKept;
|
||||
window.deleteAllKept = deleteAllKept;
|
||||
window.deleteDownload = deleteDownload;
|
||||
window.refreshPlaylists = refreshPlaylists;
|
||||
window.refreshPlaylist = refreshPlaylist;
|
||||
|
||||
@@ -70,7 +70,12 @@ async function openLinkPlaylist(jellyfinId, name) {
|
||||
}
|
||||
|
||||
try {
|
||||
spotifyUserPlaylists = await API.fetchSpotifyUserPlaylists(selectedUserId);
|
||||
const response = await API.fetchSpotifyUserPlaylists(selectedUserId);
|
||||
spotifyUserPlaylists = Array.isArray(response?.playlists)
|
||||
? response.playlists
|
||||
: Array.isArray(response)
|
||||
? response
|
||||
: [];
|
||||
spotifyUserPlaylistsScopeUserId = selectedUserId;
|
||||
const availablePlaylists = spotifyUserPlaylists.filter((p) => !p.isLinked);
|
||||
|
||||
|
||||
@@ -211,12 +211,26 @@ const SETTINGS_REGISTRY = {
|
||||
ensureConfigSection(config, "deezer").quality = value;
|
||||
},
|
||||
),
|
||||
DEEZER_MIN_REQUEST_INTERVAL_MS: numberBinding(
|
||||
(config) => config?.deezer?.minRequestIntervalMs ?? 200,
|
||||
(config, value) => {
|
||||
ensureConfigSection(config, "deezer").minRequestIntervalMs = value;
|
||||
},
|
||||
200,
|
||||
),
|
||||
SQUIDWTF_QUALITY: textBinding(
|
||||
(config) => config?.squidWtf?.quality ?? "LOSSLESS",
|
||||
(config, value) => {
|
||||
ensureConfigSection(config, "squidWtf").quality = value;
|
||||
},
|
||||
),
|
||||
SQUIDWTF_MIN_REQUEST_INTERVAL_MS: numberBinding(
|
||||
(config) => config?.squidWtf?.minRequestIntervalMs ?? 200,
|
||||
(config, value) => {
|
||||
ensureConfigSection(config, "squidWtf").minRequestIntervalMs = value;
|
||||
},
|
||||
200,
|
||||
),
|
||||
MUSICBRAINZ_ENABLED: toggleBinding(
|
||||
(config) => config?.musicBrainz?.enabled ?? false,
|
||||
(config, value) => {
|
||||
@@ -247,6 +261,13 @@ const SETTINGS_REGISTRY = {
|
||||
ensureConfigSection(config, "qobuz").quality = value;
|
||||
},
|
||||
),
|
||||
QOBUZ_MIN_REQUEST_INTERVAL_MS: numberBinding(
|
||||
(config) => config?.qobuz?.minRequestIntervalMs ?? 200,
|
||||
(config, value) => {
|
||||
ensureConfigSection(config, "qobuz").minRequestIntervalMs = value;
|
||||
},
|
||||
200,
|
||||
),
|
||||
JELLYFIN_URL: textBinding(
|
||||
(config) => config?.jellyfin?.url ?? "",
|
||||
(config, value) => {
|
||||
|
||||
+92
-30
@@ -3,6 +3,8 @@
|
||||
import { escapeHtml, escapeJs, capitalizeProvider } from "./utils.js";
|
||||
|
||||
let rowMenuHandlersBound = false;
|
||||
let tableRowHandlersBound = false;
|
||||
const expandedInjectedPlaylistDetails = new Set();
|
||||
|
||||
function bindRowMenuHandlers() {
|
||||
if (rowMenuHandlersBound) {
|
||||
@@ -16,6 +18,41 @@ function bindRowMenuHandlers() {
|
||||
rowMenuHandlersBound = true;
|
||||
}
|
||||
|
||||
function bindTableRowHandlers() {
|
||||
if (tableRowHandlersBound) {
|
||||
return;
|
||||
}
|
||||
|
||||
document.addEventListener("click", (event) => {
|
||||
const detailsTrigger = event.target.closest?.(
|
||||
"button.details-trigger[data-details-target]",
|
||||
);
|
||||
if (detailsTrigger) {
|
||||
const target = detailsTrigger.getAttribute("data-details-target");
|
||||
if (target) {
|
||||
toggleDetailsRow(event, target);
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
const row = event.target.closest?.("tr.compact-row[data-details-row]");
|
||||
if (!row) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (event.target.closest("button, a, .row-actions-menu")) {
|
||||
return;
|
||||
}
|
||||
|
||||
const detailsRowId = row.getAttribute("data-details-row");
|
||||
if (detailsRowId) {
|
||||
toggleDetailsRow(null, detailsRowId);
|
||||
}
|
||||
});
|
||||
|
||||
tableRowHandlersBound = true;
|
||||
}
|
||||
|
||||
function closeAllRowMenus(exceptId = null) {
|
||||
document.querySelectorAll(".row-actions-menu.open").forEach((menu) => {
|
||||
if (!exceptId || menu.id !== exceptId) {
|
||||
@@ -82,6 +119,18 @@ function toggleDetailsRow(event, detailsRowId) {
|
||||
);
|
||||
if (parentRow) {
|
||||
parentRow.classList.toggle("expanded", isExpanded);
|
||||
|
||||
// Persist Injected Playlists details expansion across auto-refreshes.
|
||||
if (parentRow.closest("#playlist-table-body")) {
|
||||
const detailsKey = parentRow.getAttribute("data-details-key");
|
||||
if (detailsKey) {
|
||||
if (isExpanded) {
|
||||
expandedInjectedPlaylistDetails.add(detailsKey);
|
||||
} else {
|
||||
expandedInjectedPlaylistDetails.delete(detailsKey);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -183,11 +232,15 @@ if (typeof window !== "undefined") {
|
||||
}
|
||||
|
||||
bindRowMenuHandlers();
|
||||
bindTableRowHandlers();
|
||||
|
||||
export function updateStatusUI(data) {
|
||||
const versionEl = document.getElementById("version");
|
||||
if (versionEl) versionEl.textContent = "v" + data.version;
|
||||
|
||||
const sidebarVersionEl = document.getElementById("sidebar-version");
|
||||
if (sidebarVersionEl) sidebarVersionEl.textContent = "v" + data.version;
|
||||
|
||||
const backendTypeEl = document.getElementById("backend-type");
|
||||
if (backendTypeEl) backendTypeEl.textContent = data.backendType;
|
||||
|
||||
@@ -271,6 +324,7 @@ export function updatePlaylistsUI(data) {
|
||||
const playlists = data.playlists || [];
|
||||
|
||||
if (playlists.length === 0) {
|
||||
expandedInjectedPlaylistDetails.clear();
|
||||
tbody.innerHTML =
|
||||
'<tr><td colspan="4" style="text-align:center;color:var(--text-secondary);padding:40px;">No playlists configured. Link playlists from the Link Playlists tab.</td></tr>';
|
||||
renderGuidance("playlists-guidance", [
|
||||
@@ -329,9 +383,12 @@ export function updatePlaylistsUI(data) {
|
||||
const summary = getPlaylistStatusSummary(playlist);
|
||||
const detailsRowId = `playlist-details-${index}`;
|
||||
const menuId = `playlist-menu-${index}`;
|
||||
const detailsKey = `${playlist.id || playlist.name || index}`;
|
||||
const isExpanded = expandedInjectedPlaylistDetails.has(detailsKey);
|
||||
const syncSchedule = playlist.syncSchedule || "0 8 * * *";
|
||||
const escapedPlaylistName = escapeJs(playlist.name);
|
||||
const escapedSyncSchedule = escapeJs(syncSchedule);
|
||||
const escapedPlaylistName = escapeHtml(playlist.name);
|
||||
const escapedSyncSchedule = escapeHtml(syncSchedule);
|
||||
const escapedDetailsKey = escapeHtml(detailsKey);
|
||||
|
||||
const breakdownBadges = [
|
||||
`<span class="status-pill neutral">${summary.localCount} Local</span>`,
|
||||
@@ -345,7 +402,7 @@ export function updatePlaylistsUI(data) {
|
||||
}
|
||||
|
||||
return `
|
||||
<tr class="compact-row" data-details-row="${detailsRowId}" onclick="onCompactRowClick(event, '${detailsRowId}')">
|
||||
<tr class="compact-row ${isExpanded ? "expanded" : ""}" data-details-row="${detailsRowId}" data-details-key="${escapedDetailsKey}">
|
||||
<td>
|
||||
<div class="name-cell">
|
||||
<strong>${escapeHtml(playlist.name)}</strong>
|
||||
@@ -358,24 +415,23 @@ export function updatePlaylistsUI(data) {
|
||||
</td>
|
||||
<td><span class="status-pill ${summary.statusClass}">${summary.statusLabel}</span></td>
|
||||
<td class="row-controls">
|
||||
<button class="icon-btn details-trigger" data-details-target="${detailsRowId}" aria-expanded="false"
|
||||
onclick="toggleDetailsRow(event, '${detailsRowId}')">Details</button>
|
||||
<button class="icon-btn details-trigger" data-details-target="${detailsRowId}" aria-expanded="${isExpanded ? "true" : "false"}">${isExpanded ? "Hide" : "Details"}</button>
|
||||
<div class="row-actions-wrap">
|
||||
<button class="icon-btn menu-trigger" aria-haspopup="true" aria-expanded="false"
|
||||
onclick="toggleRowMenu(event, '${menuId}')">...</button>
|
||||
data-action="toggleRowMenu" data-arg-menu-id="${menuId}">...</button>
|
||||
<div class="row-actions-menu" id="${menuId}" role="menu">
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); viewTracks('${escapedPlaylistName}')">View Tracks</button>
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); refreshPlaylist('${escapedPlaylistName}')">Refresh</button>
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); matchPlaylistTracks('${escapedPlaylistName}')">Rematch</button>
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); clearPlaylistCache('${escapedPlaylistName}')">Rebuild</button>
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); editPlaylistSchedule('${escapedPlaylistName}', '${escapedSyncSchedule}')">Edit Schedule</button>
|
||||
<button data-action="viewTracks" data-arg-playlist-name="${escapedPlaylistName}">View Tracks</button>
|
||||
<button data-action="refreshPlaylist" data-arg-playlist-name="${escapedPlaylistName}">Refresh</button>
|
||||
<button data-action="matchPlaylistTracks" data-arg-playlist-name="${escapedPlaylistName}">Rematch</button>
|
||||
<button data-action="clearPlaylistCache" data-arg-playlist-name="${escapedPlaylistName}">Rebuild</button>
|
||||
<button data-action="editPlaylistSchedule" data-arg-playlist-name="${escapedPlaylistName}" data-arg-sync-schedule="${escapedSyncSchedule}">Edit Schedule</button>
|
||||
<hr>
|
||||
<button class="danger-item" onclick="closeRowMenu(event, '${menuId}'); removePlaylist('${escapedPlaylistName}')">Remove Playlist</button>
|
||||
<button class="danger-item" data-action="removePlaylist" data-arg-playlist-name="${escapedPlaylistName}">Remove Playlist</button>
|
||||
</div>
|
||||
</div>
|
||||
</td>
|
||||
</tr>
|
||||
<tr id="${detailsRowId}" class="details-row" hidden>
|
||||
<tr id="${detailsRowId}" class="details-row" ${isExpanded ? "" : "hidden"}>
|
||||
<td colspan="4">
|
||||
<div class="details-panel">
|
||||
<div class="details-grid">
|
||||
@@ -383,7 +439,7 @@ export function updatePlaylistsUI(data) {
|
||||
<span class="detail-label">Sync Schedule</span>
|
||||
<span class="detail-value mono">
|
||||
${escapeHtml(syncSchedule)}
|
||||
<button class="inline-action-link" onclick="editPlaylistSchedule('${escapedPlaylistName}', '${escapedSyncSchedule}')">Edit</button>
|
||||
<button class="inline-action-link" data-action="editPlaylistSchedule" data-arg-playlist-name="${escapedPlaylistName}" data-arg-sync-schedule="${escapedSyncSchedule}">Edit</button>
|
||||
</span>
|
||||
</div>
|
||||
<div class="detail-item">
|
||||
@@ -478,9 +534,9 @@ export function updateDownloadsUI(data) {
|
||||
<td style="font-family:monospace;font-size:0.85rem;">${escapeHtml(f.fileName)}</td>
|
||||
<td style="color:var(--text-secondary);">${f.sizeFormatted}</td>
|
||||
<td>
|
||||
<button onclick="downloadFile('${escapeJs(f.path)}')"
|
||||
<button data-action="downloadFile" data-arg-path="${escapeHtml(escapeJs(f.path))}"
|
||||
style="margin-right:4px;font-size:0.75rem;padding:4px 8px;background:var(--accent);border-color:var(--accent);">Download</button>
|
||||
<button onclick="deleteDownload('${escapeJs(f.path)}')"
|
||||
<button data-action="deleteDownload" data-arg-path="${escapeHtml(escapeJs(f.path))}"
|
||||
class="danger" style="font-size:0.75rem;padding:4px 8px;">Delete</button>
|
||||
</td>
|
||||
</tr>
|
||||
@@ -536,8 +592,12 @@ export function updateConfigUI(data) {
|
||||
data.deezer.arl || "(not set)";
|
||||
document.getElementById("config-deezer-quality").textContent =
|
||||
data.deezer.quality;
|
||||
document.getElementById("config-deezer-ratelimit").textContent =
|
||||
(data.deezer.minRequestIntervalMs || 200) + " ms";
|
||||
document.getElementById("config-squid-quality").textContent =
|
||||
data.squidWtf.quality;
|
||||
document.getElementById("config-squid-ratelimit").textContent =
|
||||
(data.squidWtf.minRequestIntervalMs || 200) + " ms";
|
||||
document.getElementById("config-musicbrainz-enabled").textContent = data
|
||||
.musicBrainz.enabled
|
||||
? "Yes"
|
||||
@@ -546,6 +606,8 @@ export function updateConfigUI(data) {
|
||||
data.qobuz.userAuthToken || "(not set)";
|
||||
document.getElementById("config-qobuz-quality").textContent =
|
||||
data.qobuz.quality || "FLAC";
|
||||
document.getElementById("config-qobuz-ratelimit").textContent =
|
||||
(data.qobuz.minRequestIntervalMs || 200) + " ms";
|
||||
document.getElementById("config-jellyfin-url").textContent =
|
||||
data.jellyfin.url || "-";
|
||||
document.getElementById("config-jellyfin-api-key").textContent =
|
||||
@@ -628,26 +690,27 @@ export function updateJellyfinPlaylistsUI(data) {
|
||||
.map((playlist, index) => {
|
||||
const detailsRowId = `jellyfin-details-${index}`;
|
||||
const menuId = `jellyfin-menu-${index}`;
|
||||
const statsPending = Boolean(playlist.statsPending);
|
||||
const localCount = playlist.localTracks || 0;
|
||||
const externalCount = playlist.externalTracks || 0;
|
||||
const externalAvailable = playlist.externalAvailable || 0;
|
||||
const escapedId = escapeJs(playlist.id);
|
||||
const escapedName = escapeJs(playlist.name);
|
||||
const escapedId = escapeHtml(playlist.id);
|
||||
const escapedName = escapeHtml(playlist.name);
|
||||
const statusClass = playlist.isConfigured ? "success" : "info";
|
||||
const statusLabel = playlist.isConfigured ? "Linked" : "Not Linked";
|
||||
|
||||
const actionButtons = playlist.isConfigured
|
||||
? `
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); fetchJellyfinPlaylists()">Refresh Row Data</button>
|
||||
<button class="danger-item" onclick="closeRowMenu(event, '${menuId}'); unlinkPlaylist('${escapedId}', '${escapedName}')">Unlink from Spotify</button>
|
||||
<button data-action="fetchJellyfinPlaylists">Refresh Row Data</button>
|
||||
<button class="danger-item" data-action="unlinkPlaylist" data-arg-jellyfin-id="${escapedId}" data-arg-jellyfin-name="${escapedName}">Unlink from Spotify</button>
|
||||
`
|
||||
: `
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); openLinkPlaylist('${escapedId}', '${escapedName}')">Link to Spotify</button>
|
||||
<button onclick="closeRowMenu(event, '${menuId}'); fetchJellyfinPlaylists()">Refresh Row Data</button>
|
||||
<button data-action="openLinkPlaylist" data-arg-jellyfin-id="${escapedId}" data-arg-jellyfin-name="${escapedName}">Link to Spotify</button>
|
||||
<button data-action="fetchJellyfinPlaylists">Refresh Row Data</button>
|
||||
`;
|
||||
|
||||
return `
|
||||
<tr class="compact-row" data-details-row="${detailsRowId}" onclick="onCompactRowClick(event, '${detailsRowId}')">
|
||||
<tr class="compact-row" data-details-row="${detailsRowId}">
|
||||
<td>
|
||||
<div class="name-cell">
|
||||
<strong>${escapeHtml(playlist.name)}</strong>
|
||||
@@ -655,16 +718,15 @@ export function updateJellyfinPlaylistsUI(data) {
|
||||
</div>
|
||||
</td>
|
||||
<td>
|
||||
<span class="track-count">${localCount + externalAvailable}</span>
|
||||
<div class="meta-text">L ${localCount} • E ${externalAvailable}/${externalCount}</div>
|
||||
<span class="track-count">${statsPending ? "..." : localCount + externalAvailable}</span>
|
||||
<div class="meta-text">${statsPending ? "Loading track stats..." : `L ${localCount} • E ${externalAvailable}/${externalCount}`}</div>
|
||||
</td>
|
||||
<td><span class="status-pill ${statusClass}">${statusLabel}</span></td>
|
||||
<td class="row-controls">
|
||||
<button class="icon-btn details-trigger" data-details-target="${detailsRowId}" aria-expanded="false"
|
||||
onclick="toggleDetailsRow(event, '${detailsRowId}')">Details</button>
|
||||
<button class="icon-btn details-trigger" data-details-target="${detailsRowId}" aria-expanded="false">Details</button>
|
||||
<div class="row-actions-wrap">
|
||||
<button class="icon-btn menu-trigger" aria-haspopup="true" aria-expanded="false"
|
||||
onclick="toggleRowMenu(event, '${menuId}')">...</button>
|
||||
data-action="toggleRowMenu" data-arg-menu-id="${menuId}">...</button>
|
||||
<div class="row-actions-menu" id="${menuId}" role="menu">
|
||||
${actionButtons}
|
||||
</div>
|
||||
@@ -677,11 +739,11 @@ export function updateJellyfinPlaylistsUI(data) {
|
||||
<div class="details-grid">
|
||||
<div class="detail-item">
|
||||
<span class="detail-label">Local Tracks</span>
|
||||
<span class="detail-value">${localCount}</span>
|
||||
<span class="detail-value">${statsPending ? "..." : localCount}</span>
|
||||
</div>
|
||||
<div class="detail-item">
|
||||
<span class="detail-label">External Tracks</span>
|
||||
<span class="detail-value">${externalAvailable}/${externalCount}</span>
|
||||
<span class="detail-value">${statsPending ? "Loading..." : `${externalAvailable}/${externalCount}`}</span>
|
||||
</div>
|
||||
<div class="detail-item">
|
||||
<span class="detail-label">Linked Spotify ID</span>
|
||||
|
||||
@@ -0,0 +1,4 @@
|
||||
This folder contains small “view” modules for the admin UI.
|
||||
|
||||
Goal: keep `js/main.js` as orchestration only, while view modules encapsulate DOM wiring for each section.
|
||||
|
||||
@@ -0,0 +1,22 @@
|
||||
export function initNavigationView({ switchTab } = {}) {
|
||||
const doSwitch =
|
||||
typeof switchTab === "function" ? switchTab : (tab) => window.switchTab?.(tab);
|
||||
|
||||
document.querySelectorAll(".tab").forEach((tab) => {
|
||||
tab.addEventListener("click", () => {
|
||||
doSwitch(tab.dataset.tab);
|
||||
});
|
||||
});
|
||||
|
||||
document.querySelectorAll(".sidebar-link").forEach((link) => {
|
||||
link.addEventListener("click", () => {
|
||||
doSwitch(link.dataset.tab);
|
||||
});
|
||||
});
|
||||
|
||||
const hash = window.location.hash.substring(1);
|
||||
if (hash) {
|
||||
doSwitch(hash);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,30 @@
|
||||
export function initScrobblingView({
|
||||
isAuthenticated,
|
||||
loadScrobblingConfig,
|
||||
} = {}) {
|
||||
const canLoad =
|
||||
typeof isAuthenticated === "function" ? isAuthenticated : () => false;
|
||||
const load =
|
||||
typeof loadScrobblingConfig === "function"
|
||||
? loadScrobblingConfig
|
||||
: () => window.loadScrobblingConfig?.();
|
||||
|
||||
function onActivateScrobbling() {
|
||||
if (canLoad()) {
|
||||
load();
|
||||
}
|
||||
}
|
||||
|
||||
const scrobblingTab = document.querySelector('.tab[data-tab="scrobbling"]');
|
||||
if (scrobblingTab) {
|
||||
scrobblingTab.addEventListener("click", onActivateScrobbling);
|
||||
}
|
||||
|
||||
const scrobblingSidebar = document.querySelector(
|
||||
'.sidebar-link[data-tab="scrobbling"]',
|
||||
);
|
||||
if (scrobblingSidebar) {
|
||||
scrobblingSidebar.addEventListener("click", onActivateScrobbling);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -4,6 +4,7 @@
|
||||
<meta charset="UTF-8" />
|
||||
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
|
||||
<title>Spotify Track Mappings - Allstarr</title>
|
||||
<link rel="stylesheet" href="styles.css" />
|
||||
<style>
|
||||
:root {
|
||||
--bg-primary: #0d1117;
|
||||
@@ -41,6 +42,26 @@
|
||||
padding: 20px;
|
||||
}
|
||||
|
||||
.support-footer {
|
||||
max-width: 1400px;
|
||||
margin: 0 auto 24px;
|
||||
padding: 20px;
|
||||
border-top: 1px solid var(--border);
|
||||
color: var(--text-secondary);
|
||||
font-size: 0.92rem;
|
||||
text-align: center;
|
||||
}
|
||||
|
||||
.support-footer a {
|
||||
color: var(--accent);
|
||||
text-decoration: none;
|
||||
}
|
||||
|
||||
.support-footer a:hover {
|
||||
color: var(--accent-hover);
|
||||
text-decoration: underline;
|
||||
}
|
||||
|
||||
header {
|
||||
display: flex;
|
||||
justify-content: space-between;
|
||||
@@ -646,5 +667,15 @@
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<footer class="support-footer">
|
||||
<p>
|
||||
If Allstarr has helped you, or maybe even replaced a monthly streaming service subscription, consider
|
||||
supporting its development via
|
||||
<a href="https://github.com/sponsors/SoPat712" target="_blank" rel="noopener noreferrer">GitHub Sponsor</a>
|
||||
or
|
||||
<a href="https://ko-fi.com/joshpatra" target="_blank" rel="noopener noreferrer">Ko-Fi</a>.
|
||||
</p>
|
||||
</footer>
|
||||
</body>
|
||||
</html>
|
||||
|
||||
@@ -15,6 +15,7 @@ let localMapContext = null;
|
||||
let localMapResults = [];
|
||||
let localMapSelectedIndex = -1;
|
||||
let externalMapContext = null;
|
||||
const modalFocusState = new Map();
|
||||
|
||||
function showToast(message, type = "success", duration = 3000) {
|
||||
const toast = document.createElement("div");
|
||||
@@ -247,9 +248,26 @@ function toggleModal(modalId, shouldOpen) {
|
||||
}
|
||||
|
||||
if (shouldOpen) {
|
||||
const previousActive = document.activeElement;
|
||||
modalFocusState.set(modalId, previousActive);
|
||||
modal.setAttribute("role", "dialog");
|
||||
modal.setAttribute("aria-modal", "true");
|
||||
modal.removeAttribute("aria-hidden");
|
||||
modal.classList.add("active");
|
||||
const firstFocusable = modal.querySelector(
|
||||
'button, input, select, textarea, a[href], [tabindex]:not([tabindex="-1"])',
|
||||
);
|
||||
if (firstFocusable) {
|
||||
firstFocusable.focus();
|
||||
}
|
||||
} else {
|
||||
modal.classList.remove("active");
|
||||
modal.setAttribute("aria-hidden", "true");
|
||||
const previousActive = modalFocusState.get(modalId);
|
||||
if (previousActive && typeof previousActive.focus === "function") {
|
||||
previousActive.focus();
|
||||
}
|
||||
modalFocusState.delete(modalId);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -627,6 +645,10 @@ function initializeEventListeners() {
|
||||
closeLocalMapModal();
|
||||
closeExternalMapModal();
|
||||
});
|
||||
|
||||
document.querySelectorAll(".modal-overlay").forEach((modal) => {
|
||||
modal.setAttribute("aria-hidden", "true");
|
||||
});
|
||||
}
|
||||
|
||||
// Initialize on page load
|
||||
|
||||
@@ -69,12 +69,144 @@ body {
|
||||
font-size: 0.85rem;
|
||||
}
|
||||
|
||||
.support-badge {
|
||||
position: fixed;
|
||||
right: 20px;
|
||||
bottom: 20px;
|
||||
width: min(360px, calc(100vw - 32px));
|
||||
padding: 12px 14px;
|
||||
border: 1px solid var(--border);
|
||||
border-radius: 10px;
|
||||
background: rgba(22, 27, 34, 0.94);
|
||||
box-shadow: 0 12px 30px rgba(0, 0, 0, 0.28);
|
||||
color: var(--text-secondary);
|
||||
font-size: 0.82rem;
|
||||
line-height: 1.45;
|
||||
z-index: 10;
|
||||
}
|
||||
|
||||
.support-badge a,
|
||||
.support-footer a {
|
||||
color: var(--accent);
|
||||
text-decoration: none;
|
||||
}
|
||||
|
||||
.support-badge a:hover,
|
||||
.support-footer a:hover {
|
||||
color: var(--accent-hover);
|
||||
text-decoration: underline;
|
||||
}
|
||||
|
||||
.container {
|
||||
max-width: 1200px;
|
||||
margin: 0 auto;
|
||||
padding: 20px;
|
||||
}
|
||||
|
||||
.app-shell {
|
||||
display: grid;
|
||||
grid-template-columns: 260px 1fr;
|
||||
gap: 18px;
|
||||
align-items: start;
|
||||
}
|
||||
|
||||
.sidebar {
|
||||
position: sticky;
|
||||
top: 16px;
|
||||
border: 1px solid var(--border);
|
||||
border-radius: 10px;
|
||||
background: rgba(22, 27, 34, 0.8);
|
||||
backdrop-filter: blur(8px);
|
||||
padding: 14px;
|
||||
max-height: calc(100vh - 32px);
|
||||
overflow: auto;
|
||||
}
|
||||
|
||||
.sidebar-brand {
|
||||
padding-bottom: 12px;
|
||||
margin-bottom: 12px;
|
||||
border-bottom: 1px solid var(--border);
|
||||
}
|
||||
|
||||
.sidebar-title {
|
||||
font-weight: 700;
|
||||
font-size: 1.05rem;
|
||||
letter-spacing: 0.2px;
|
||||
}
|
||||
|
||||
.sidebar-subtitle {
|
||||
margin-top: 2px;
|
||||
color: var(--text-secondary);
|
||||
font-size: 0.82rem;
|
||||
font-family: ui-monospace, Menlo, Monaco, "Cascadia Mono", "Segoe UI Mono",
|
||||
monospace;
|
||||
}
|
||||
|
||||
.sidebar-nav {
|
||||
display: grid;
|
||||
gap: 6px;
|
||||
}
|
||||
|
||||
.sidebar-link {
|
||||
width: 100%;
|
||||
text-align: left;
|
||||
padding: 9px 10px;
|
||||
border-radius: 8px;
|
||||
border: 1px solid transparent;
|
||||
background: transparent;
|
||||
color: var(--text-secondary);
|
||||
}
|
||||
|
||||
.sidebar-link:hover {
|
||||
background: rgba(33, 38, 45, 0.7);
|
||||
color: var(--text-primary);
|
||||
}
|
||||
|
||||
.sidebar-link.active {
|
||||
background: rgba(88, 166, 255, 0.12);
|
||||
border-color: rgba(88, 166, 255, 0.35);
|
||||
color: #9ecbff;
|
||||
}
|
||||
|
||||
.sidebar-footer {
|
||||
margin-top: 14px;
|
||||
padding-top: 12px;
|
||||
border-top: 1px solid var(--border);
|
||||
display: grid;
|
||||
gap: 10px;
|
||||
}
|
||||
|
||||
.sidebar-footer button {
|
||||
width: 100%;
|
||||
}
|
||||
|
||||
.app-main {
|
||||
min-width: 0;
|
||||
}
|
||||
|
||||
.app-header {
|
||||
display: flex;
|
||||
justify-content: space-between;
|
||||
align-items: center;
|
||||
padding: 12px 0 16px;
|
||||
border-bottom: 1px solid var(--border);
|
||||
margin-bottom: 18px;
|
||||
}
|
||||
|
||||
.top-tabs,
|
||||
.tabs.top-tabs {
|
||||
display: none !important;
|
||||
}
|
||||
|
||||
.support-footer {
|
||||
margin-top: 8px;
|
||||
padding: 20px 0 8px;
|
||||
border-top: 1px solid var(--border);
|
||||
color: var(--text-secondary);
|
||||
font-size: 0.92rem;
|
||||
text-align: center;
|
||||
}
|
||||
|
||||
header {
|
||||
display: flex;
|
||||
justify-content: space-between;
|
||||
@@ -859,6 +991,31 @@ input::placeholder {
|
||||
border-bottom-color: var(--accent);
|
||||
}
|
||||
|
||||
@media (max-width: 768px) {
|
||||
.app-shell {
|
||||
grid-template-columns: 1fr;
|
||||
gap: 12px;
|
||||
}
|
||||
|
||||
.sidebar {
|
||||
position: static;
|
||||
max-height: none;
|
||||
}
|
||||
|
||||
.support-badge {
|
||||
right: 12px;
|
||||
bottom: 12px;
|
||||
width: min(340px, calc(100vw - 24px));
|
||||
padding: 10px 12px;
|
||||
font-size: 0.78rem;
|
||||
}
|
||||
|
||||
.support-footer {
|
||||
padding-top: 16px;
|
||||
font-size: 0.88rem;
|
||||
}
|
||||
}
|
||||
|
||||
.tab-content {
|
||||
display: none;
|
||||
}
|
||||
@@ -867,6 +1024,140 @@ input::placeholder {
|
||||
display: block;
|
||||
}
|
||||
|
||||
/* Utility classes to reduce inline styles in index.html */
|
||||
.hidden {
|
||||
display: none;
|
||||
}
|
||||
|
||||
.text-secondary {
|
||||
color: var(--text-secondary);
|
||||
}
|
||||
|
||||
.text-warning {
|
||||
color: var(--warning);
|
||||
}
|
||||
|
||||
.text-error {
|
||||
color: var(--error);
|
||||
}
|
||||
|
||||
.mb-12 {
|
||||
margin-bottom: 12px;
|
||||
}
|
||||
|
||||
.mb-16 {
|
||||
margin-bottom: 16px;
|
||||
}
|
||||
|
||||
.mt-8 {
|
||||
margin-top: 8px;
|
||||
}
|
||||
|
||||
.mt-12 {
|
||||
margin-top: 12px;
|
||||
}
|
||||
|
||||
.w-full {
|
||||
width: 100%;
|
||||
}
|
||||
|
||||
.flex-row-wrap {
|
||||
display: flex;
|
||||
gap: 12px;
|
||||
flex-wrap: wrap;
|
||||
}
|
||||
|
||||
.flex-row-wrap-8 {
|
||||
display: flex;
|
||||
gap: 8px;
|
||||
flex-wrap: wrap;
|
||||
}
|
||||
|
||||
.summary-box {
|
||||
display: flex;
|
||||
gap: 20px;
|
||||
margin-bottom: 16px;
|
||||
padding: 12px;
|
||||
background: var(--bg-tertiary);
|
||||
border-radius: 6px;
|
||||
}
|
||||
|
||||
.summary-label {
|
||||
color: var(--text-secondary);
|
||||
}
|
||||
|
||||
.summary-value {
|
||||
font-weight: 600;
|
||||
margin-left: 8px;
|
||||
}
|
||||
|
||||
.summary-value.success {
|
||||
color: var(--success);
|
||||
}
|
||||
|
||||
.summary-value.warning {
|
||||
color: var(--warning);
|
||||
}
|
||||
|
||||
.summary-value.accent {
|
||||
color: var(--accent);
|
||||
}
|
||||
|
||||
.callout {
|
||||
border: 1px solid var(--border);
|
||||
border-radius: 6px;
|
||||
padding: 12px;
|
||||
margin-bottom: 16px;
|
||||
}
|
||||
|
||||
.callout.warning {
|
||||
background: rgba(245, 158, 11, 0.12);
|
||||
border-color: var(--warning);
|
||||
color: var(--text-secondary);
|
||||
}
|
||||
|
||||
.callout.warning-strong {
|
||||
background: rgba(255, 193, 7, 0.15);
|
||||
border-color: #ffc107;
|
||||
color: var(--text-primary);
|
||||
}
|
||||
|
||||
.callout.danger {
|
||||
background: rgba(248, 81, 73, 0.15);
|
||||
border-color: var(--error);
|
||||
color: var(--text-primary);
|
||||
}
|
||||
|
||||
.pill-card {
|
||||
background: var(--bg-tertiary);
|
||||
padding: 16px;
|
||||
border-radius: 8px;
|
||||
}
|
||||
|
||||
.stats-grid-auto {
|
||||
display: grid;
|
||||
grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
|
||||
gap: 16px;
|
||||
margin-bottom: 20px;
|
||||
}
|
||||
|
||||
.max-h-600 {
|
||||
max-height: 600px;
|
||||
overflow-y: auto;
|
||||
}
|
||||
|
||||
.jellyfin-user-form-group {
|
||||
margin: 0;
|
||||
flex: 1;
|
||||
min-width: 200px;
|
||||
}
|
||||
|
||||
.jellyfin-user-form-group label {
|
||||
display: block;
|
||||
margin-bottom: 4px;
|
||||
font-size: 0.85rem;
|
||||
}
|
||||
|
||||
.tracks-list {
|
||||
max-height: 400px;
|
||||
overflow-y: auto;
|
||||
@@ -980,3 +1271,119 @@ input::placeholder {
|
||||
transform: rotate(360deg);
|
||||
}
|
||||
}
|
||||
|
||||
/* Download Activity Queue */
|
||||
.download-queue-list {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
gap: 8px;
|
||||
}
|
||||
|
||||
.download-queue-item {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
justify-content: space-between;
|
||||
padding: 10px 14px;
|
||||
background: var(--bg-tertiary);
|
||||
border: 1px solid var(--border);
|
||||
border-radius: 6px;
|
||||
animation: slideIn 0.3s ease;
|
||||
}
|
||||
|
||||
.download-queue-info {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
gap: 4px;
|
||||
min-width: 0;
|
||||
flex: 1;
|
||||
}
|
||||
|
||||
.download-queue-title {
|
||||
font-weight: 500;
|
||||
font-size: 0.95rem;
|
||||
}
|
||||
|
||||
.download-queue-meta {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 8px;
|
||||
}
|
||||
|
||||
.download-queue-artist {
|
||||
color: var(--text-secondary);
|
||||
font-size: 0.85rem;
|
||||
}
|
||||
|
||||
.download-queue-provider {
|
||||
font-size: 0.75rem;
|
||||
padding: 2px 6px;
|
||||
background: rgba(88, 166, 255, 0.1);
|
||||
color: var(--accent);
|
||||
border-radius: 4px;
|
||||
text-transform: uppercase;
|
||||
}
|
||||
|
||||
.download-queue-badge {
|
||||
font-size: 0.75rem;
|
||||
padding: 2px 6px;
|
||||
background: rgba(255, 255, 255, 0.08);
|
||||
color: var(--text-secondary);
|
||||
border: 1px solid var(--border);
|
||||
border-radius: 999px;
|
||||
text-transform: uppercase;
|
||||
}
|
||||
|
||||
.download-queue-badge.is-playing {
|
||||
color: #79c0ff;
|
||||
border-color: rgba(121, 192, 255, 0.45);
|
||||
background: rgba(56, 139, 253, 0.16);
|
||||
}
|
||||
|
||||
.download-progress-bar {
|
||||
position: relative;
|
||||
height: 8px;
|
||||
width: 100%;
|
||||
margin-top: 6px;
|
||||
background: rgba(255, 255, 255, 0.06);
|
||||
border-radius: 999px;
|
||||
overflow: hidden;
|
||||
}
|
||||
|
||||
.download-progress-buffer {
|
||||
position: absolute;
|
||||
inset: 0 auto 0 0;
|
||||
background: rgba(201, 209, 217, 0.28);
|
||||
border-radius: 999px;
|
||||
}
|
||||
|
||||
.download-progress-playback {
|
||||
position: absolute;
|
||||
inset: 0 auto 0 0;
|
||||
background: linear-gradient(90deg, #2f81f7 0%, #79c0ff 100%);
|
||||
border-radius: 999px;
|
||||
}
|
||||
|
||||
.download-progress-meta {
|
||||
margin-top: 4px;
|
||||
color: var(--text-secondary);
|
||||
font-size: 0.75rem;
|
||||
}
|
||||
|
||||
.download-queue-status {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 12px;
|
||||
}
|
||||
|
||||
.download-queue-time {
|
||||
font-family: monospace;
|
||||
color: var(--text-secondary);
|
||||
font-size: 0.85rem;
|
||||
}
|
||||
|
||||
.empty-state {
|
||||
color: var(--text-secondary);
|
||||
font-style: italic;
|
||||
padding: 12px;
|
||||
text-align: center;
|
||||
}
|
||||
|
||||
@@ -1,72 +0,0 @@
|
||||
# Admin UI Modularity Guide
|
||||
|
||||
This document defines the modular JavaScript architecture for `allstarr/wwwroot/js` and the guardrails future agents should follow.
|
||||
|
||||
## Goals
|
||||
|
||||
- Keep admin UI code split by feature and responsibility.
|
||||
- Centralize request handling and async UI action handling.
|
||||
- Minimize `window.*` globals to only those required by inline HTML handlers.
|
||||
- Keep polling and refresh lifecycle in one place.
|
||||
|
||||
## Current Module Map
|
||||
|
||||
- `main.js`: Composition root only. Wires modules, shared globals, and bootstrap lifecycle.
|
||||
- `auth-session.js`: Auth/session state, role-based scope, login/logout wiring, 401 recovery handling.
|
||||
- `dashboard-data.js`: Polling lifecycle + data loading/render orchestration.
|
||||
- `operations.js`: Shared `runAction` helper + non-domain operational actions.
|
||||
- `settings-editor.js`: Settings registry, modal editor rendering, local config state sync.
|
||||
- `playlist-admin.js`: Playlist linking and admin CRUD.
|
||||
- `scrobbling-admin.js`: Scrobbling configuration actions and UI state updates.
|
||||
- `api.js`: API transport layer wrappers and endpoint functions.
|
||||
|
||||
## Required Patterns
|
||||
|
||||
### 1) Request Layer Rules
|
||||
|
||||
- All HTTP requests must go through `api.js`.
|
||||
- `api.js` owns low-level `fetch` usage (`requestJson`, `requestBlob`, `requestOptionalJson`).
|
||||
- Feature modules should call `API.*` methods and avoid direct `fetch`.
|
||||
|
||||
### 2) Action Flow Rules
|
||||
|
||||
- UI actions with toast/error handling should use `runAction(...)` from `operations.js`.
|
||||
- If an action always reloads scrobbling UI state, use `runScrobblingAction(...)` in `scrobbling-admin.js`.
|
||||
|
||||
### 3) Polling Rules
|
||||
|
||||
- Polling timers must stay in `dashboard-data.js`.
|
||||
- New background refresh loops should be added to existing refresh lifecycle, not separate timers in other modules.
|
||||
|
||||
### 4) Global Surface Rules
|
||||
|
||||
- Expose only `window.*` members needed by current inline HTML (`onclick`, `onchange`, `oninput`) or legacy UI templates.
|
||||
- Keep new feature logic module-scoped and expose narrow entry points in `init*` functions.
|
||||
|
||||
## Adding New Admin UI Behavior
|
||||
|
||||
1. Add/extend endpoint method in `api.js`.
|
||||
2. Implement feature logic in the relevant module (`*-admin.js`, `dashboard-data.js`, etc.).
|
||||
3. Prefer `runAction(...)` for async UI operations.
|
||||
4. Export/init through module `init*` only.
|
||||
5. Wire it from `main.js` if cross-module dependencies are needed.
|
||||
6. Add/adjust tests in `allstarr.Tests/JavaScriptSyntaxTests.cs`.
|
||||
|
||||
## Tests That Enforce This Architecture
|
||||
|
||||
`allstarr.Tests/JavaScriptSyntaxTests.cs` includes checks for:
|
||||
|
||||
- Module existence and syntax.
|
||||
- Coordinator bootstrap expectations.
|
||||
- API request centralization (`fetch` calls constrained to helper functions in `api.js`).
|
||||
- Scrobbling module prohibition on direct `fetch`.
|
||||
|
||||
## Fast Validation Commands
|
||||
|
||||
```bash
|
||||
# Full suite
|
||||
dotnet test allstarr.sln
|
||||
|
||||
# JS architecture/syntax focused
|
||||
dotnet test allstarr.Tests/allstarr.Tests.csproj --filter JavaScriptSyntaxTests
|
||||
```
|
||||
@@ -0,0 +1,249 @@
|
||||
services:
|
||||
valkey:
|
||||
image: valkey/valkey:8
|
||||
container_name: allstarr-valkey
|
||||
restart: unless-stopped
|
||||
# Valkey is only accessible internally - no external port exposure
|
||||
expose:
|
||||
- "6379"
|
||||
# Use a self-healing entrypoint to automatically handle Redis -> Valkey migration pitfalls (like RDB format 12 errors)
|
||||
# Only delete Valkey/Redis persistence artifacts so misconfigured REDIS_DATA_PATH values do not wipe app cache files.
|
||||
entrypoint:
|
||||
- "sh"
|
||||
- "-ec"
|
||||
- |
|
||||
log_file=/tmp/valkey-startup.log
|
||||
log_pipe=/tmp/valkey-startup.pipe
|
||||
server_pid=
|
||||
tee_pid=
|
||||
|
||||
forward_signal() {
|
||||
if [ -n "$$server_pid" ]; then
|
||||
kill -TERM "$$server_pid" 2>/dev/null || true
|
||||
wait "$$server_pid" 2>/dev/null || true
|
||||
fi
|
||||
|
||||
if [ -n "$$tee_pid" ]; then
|
||||
kill "$$tee_pid" 2>/dev/null || true
|
||||
wait "$$tee_pid" 2>/dev/null || true
|
||||
fi
|
||||
|
||||
rm -f "$$log_pipe"
|
||||
exit 143
|
||||
}
|
||||
|
||||
trap forward_signal TERM INT
|
||||
|
||||
start_valkey() {
|
||||
rm -f "$$log_file" "$$log_pipe"
|
||||
: > "$$log_file"
|
||||
mkfifo "$$log_pipe"
|
||||
|
||||
tee -a "$$log_file" < "$$log_pipe" &
|
||||
tee_pid=$$!
|
||||
|
||||
valkey-server --maxmemory 1gb --maxmemory-policy allkeys-lru --save 60 1 --appendonly yes > "$$log_pipe" 2>&1 &
|
||||
server_pid=$$!
|
||||
|
||||
wait "$$server_pid"
|
||||
status=$$?
|
||||
|
||||
wait "$$tee_pid" 2>/dev/null || true
|
||||
rm -f "$$log_pipe"
|
||||
server_pid=
|
||||
tee_pid=
|
||||
|
||||
return "$$status"
|
||||
}
|
||||
|
||||
is_incompatible_persistence_error() {
|
||||
grep -Eq "Can't handle RDB format version|Error reading the RDB base file|AOF loading aborted" "$$log_file"
|
||||
}
|
||||
|
||||
cleanup_incompatible_persistence() {
|
||||
echo 'Valkey failed to start (likely incompatible Redis persistence files). Removing persisted RDB/AOF artifacts and retrying...'
|
||||
rm -f /data/*.rdb /data/*.aof /data/*.manifest
|
||||
rm -rf /data/appendonlydir /data/appendonlydir-*
|
||||
}
|
||||
|
||||
if ! start_valkey; then
|
||||
if is_incompatible_persistence_error; then
|
||||
cleanup_incompatible_persistence
|
||||
exec valkey-server --maxmemory 1gb --maxmemory-policy allkeys-lru --save 60 1 --appendonly yes
|
||||
fi
|
||||
|
||||
exit 1
|
||||
fi
|
||||
healthcheck:
|
||||
# Use CMD-SHELL for broader compatibility in some environments
|
||||
test: ["CMD-SHELL", "valkey-cli ping || exit 1"]
|
||||
interval: 10s
|
||||
timeout: 3s
|
||||
retries: 5
|
||||
start_period: 20s
|
||||
volumes:
|
||||
- ${REDIS_DATA_PATH:-./redis-data}:/data
|
||||
networks:
|
||||
- allstarr-network
|
||||
|
||||
# Spotify Lyrics API sidecar service
|
||||
# Note: This image only supports AMD64. On ARM64 systems, Docker will use emulation.
|
||||
spotify-lyrics:
|
||||
image: akashrchandran/spotify-lyrics-api:latest
|
||||
platform: linux/amd64
|
||||
container_name: allstarr-spotify-lyrics
|
||||
restart: unless-stopped
|
||||
ports:
|
||||
- "8365:8080"
|
||||
environment:
|
||||
- SP_DC=${SPOTIFY_API_SESSION_COOKIE:-}
|
||||
networks:
|
||||
- allstarr-network
|
||||
|
||||
allstarr:
|
||||
# Use pre-built image from GitHub Container Registry
|
||||
# For latest stable: ghcr.io/sopat712/allstarr:latest
|
||||
# For beta/testing: ghcr.io/sopat712/allstarr:beta
|
||||
# To build locally instead, uncomment the build section below
|
||||
image: ghcr.io/sopat712/allstarr:latest
|
||||
|
||||
# Uncomment to build locally instead of using GHCR image:
|
||||
# build:
|
||||
# context: .
|
||||
# dockerfile: Dockerfile
|
||||
# image: allstarr:local
|
||||
|
||||
container_name: allstarr
|
||||
restart: unless-stopped
|
||||
ports:
|
||||
- "5274:8080"
|
||||
# Admin UI on port 5275 - for local/Tailscale access only
|
||||
# DO NOT expose through reverse proxy - contains sensitive config
|
||||
- "5275:5275"
|
||||
depends_on:
|
||||
valkey:
|
||||
condition: service_healthy
|
||||
spotify-lyrics:
|
||||
condition: service_started
|
||||
healthcheck:
|
||||
test: ["CMD", "curl", "-f", "http://localhost:8080/health"]
|
||||
interval: 30s
|
||||
timeout: 10s
|
||||
retries: 3
|
||||
start_period: 40s
|
||||
networks:
|
||||
- allstarr-network
|
||||
environment:
|
||||
- ASPNETCORE_ENVIRONMENT=Production
|
||||
# Backend type: Subsonic or Jellyfin (default: Subsonic)
|
||||
- Backend__Type=${BACKEND_TYPE:-Subsonic}
|
||||
# Admin network controls (port 5275)
|
||||
- Admin__BindAnyIp=${ADMIN_BIND_ANY_IP:-false}
|
||||
- Admin__TrustedSubnets=${ADMIN_TRUSTED_SUBNETS:-}
|
||||
|
||||
# ===== REDIS / VALKEY CACHE =====
|
||||
- Redis__ConnectionString=valkey:6379
|
||||
- Redis__Enabled=${REDIS_ENABLED:-true}
|
||||
|
||||
# ===== CACHE TTL SETTINGS =====
|
||||
- Cache__SearchResultsMinutes=${CACHE_SEARCH_RESULTS_MINUTES:-1}
|
||||
- Cache__PlaylistImagesHours=${CACHE_PLAYLIST_IMAGES_HOURS:-168}
|
||||
- Cache__SpotifyPlaylistItemsHours=${CACHE_SPOTIFY_PLAYLIST_ITEMS_HOURS:-168}
|
||||
- Cache__SpotifyMatchedTracksDays=${CACHE_SPOTIFY_MATCHED_TRACKS_DAYS:-30}
|
||||
- Cache__LyricsDays=${CACHE_LYRICS_DAYS:-14}
|
||||
- Cache__GenreDays=${CACHE_GENRE_DAYS:-30}
|
||||
- Cache__MetadataDays=${CACHE_METADATA_DAYS:-7}
|
||||
- Cache__OdesliLookupDays=${CACHE_ODESLI_LOOKUP_DAYS:-60}
|
||||
- Cache__ProxyImagesDays=${CACHE_PROXY_IMAGES_DAYS:-14}
|
||||
- Cache__TranscodeCacheMinutes=${CACHE_TRANSCODE_MINUTES:-60}
|
||||
|
||||
# ===== SUBSONIC BACKEND =====
|
||||
- Subsonic__Url=${SUBSONIC_URL:-http://localhost:4533}
|
||||
- Subsonic__ExplicitFilter=${EXPLICIT_FILTER:-ExplicitOnly}
|
||||
- Subsonic__DownloadMode=${DOWNLOAD_MODE:-Track}
|
||||
- Subsonic__MusicService=${MUSIC_SERVICE:-SquidWTF}
|
||||
- Subsonic__StorageMode=${STORAGE_MODE:-Permanent}
|
||||
- Subsonic__CacheDurationHours=${CACHE_DURATION_HOURS:-1}
|
||||
- Subsonic__EnableExternalPlaylists=${ENABLE_EXTERNAL_PLAYLISTS:-true}
|
||||
- Subsonic__PlaylistsDirectory=${PLAYLISTS_DIRECTORY:-playlists}
|
||||
|
||||
# ===== JELLYFIN BACKEND =====
|
||||
- Jellyfin__Url=${JELLYFIN_URL:-http://localhost:8096}
|
||||
- Jellyfin__ApiKey=${JELLYFIN_API_KEY:-}
|
||||
- Jellyfin__UserId=${JELLYFIN_USER_ID:-}
|
||||
- Jellyfin__LibraryId=${JELLYFIN_LIBRARY_ID:-}
|
||||
- Jellyfin__ClientUsername=${JELLYFIN_CLIENT_USERNAME:-}
|
||||
- Jellyfin__ExplicitFilter=${EXPLICIT_FILTER:-ExplicitOnly}
|
||||
- Jellyfin__DownloadMode=${DOWNLOAD_MODE:-Track}
|
||||
- Jellyfin__MusicService=${MUSIC_SERVICE:-SquidWTF}
|
||||
- Jellyfin__StorageMode=${STORAGE_MODE:-Permanent}
|
||||
- Jellyfin__CacheDurationHours=${CACHE_DURATION_HOURS:-1}
|
||||
- Jellyfin__EnableExternalPlaylists=${ENABLE_EXTERNAL_PLAYLISTS:-true}
|
||||
- Jellyfin__PlaylistsDirectory=${PLAYLISTS_DIRECTORY:-playlists}
|
||||
|
||||
# ===== SPOTIFY PLAYLIST INJECTION (JELLYFIN ONLY) =====
|
||||
- SpotifyImport__Enabled=${SPOTIFY_IMPORT_ENABLED:-false}
|
||||
- SpotifyImport__SyncStartHour=${SPOTIFY_IMPORT_SYNC_START_HOUR:-16}
|
||||
- SpotifyImport__SyncStartMinute=${SPOTIFY_IMPORT_SYNC_START_MINUTE:-15}
|
||||
- SpotifyImport__SyncWindowHours=${SPOTIFY_IMPORT_SYNC_WINDOW_HOURS:-2}
|
||||
- SpotifyImport__MatchingIntervalHours=${SPOTIFY_IMPORT_MATCHING_INTERVAL_HOURS:-24}
|
||||
- SpotifyImport__Playlists=${SPOTIFY_IMPORT_PLAYLISTS:-}
|
||||
- SpotifyImport__PlaylistIds=${SPOTIFY_IMPORT_PLAYLIST_IDS:-}
|
||||
- SpotifyImport__PlaylistNames=${SPOTIFY_IMPORT_PLAYLIST_NAMES:-}
|
||||
- SpotifyImport__PlaylistLocalTracksPositions=${SPOTIFY_IMPORT_PLAYLIST_LOCAL_TRACKS_POSITIONS:-}
|
||||
|
||||
# ===== SPOTIFY DIRECT API (for lyrics, ISRC matching, track ordering) =====
|
||||
- SpotifyApi__Enabled=${SPOTIFY_API_ENABLED:-false}
|
||||
- SpotifyApi__SessionCookie=${SPOTIFY_API_SESSION_COOKIE:-}
|
||||
- SpotifyApi__SessionCookieSetDate=${SPOTIFY_API_SESSION_COOKIE_SET_DATE:-}
|
||||
- SpotifyApi__CacheDurationMinutes=${SPOTIFY_API_CACHE_DURATION_MINUTES:-60}
|
||||
- SpotifyApi__RateLimitDelayMs=${SPOTIFY_API_RATE_LIMIT_DELAY_MS:-100}
|
||||
- SpotifyApi__PreferIsrcMatching=${SPOTIFY_API_PREFER_ISRC_MATCHING:-true}
|
||||
# Spotify Lyrics API sidecar service URL (internal)
|
||||
- SpotifyApi__LyricsApiUrl=${SPOTIFY_LYRICS_API_URL:-http://spotify-lyrics:8080}
|
||||
|
||||
# ===== SCROBBLING (LAST.FM, LISTENBRAINZ) =====
|
||||
- Scrobbling__Enabled=${SCROBBLING_ENABLED:-false}
|
||||
- Scrobbling__LocalTracksEnabled=${SCROBBLING_LOCAL_TRACKS_ENABLED:-false}
|
||||
- Scrobbling__SyntheticLocalPlayedSignalEnabled=${SCROBBLING_SYNTHETIC_LOCAL_PLAYED_SIGNAL_ENABLED:-false}
|
||||
- Scrobbling__LastFm__Enabled=${SCROBBLING_LASTFM_ENABLED:-false}
|
||||
- Scrobbling__LastFm__ApiKey=${SCROBBLING_LASTFM_API_KEY:-}
|
||||
- Scrobbling__LastFm__SharedSecret=${SCROBBLING_LASTFM_SHARED_SECRET:-}
|
||||
- Scrobbling__LastFm__SessionKey=${SCROBBLING_LASTFM_SESSION_KEY:-}
|
||||
- Scrobbling__LastFm__Username=${SCROBBLING_LASTFM_USERNAME:-}
|
||||
- Scrobbling__LastFm__Password=${SCROBBLING_LASTFM_PASSWORD:-}
|
||||
- Scrobbling__ListenBrainz__Enabled=${SCROBBLING_LISTENBRAINZ_ENABLED:-false}
|
||||
- Scrobbling__ListenBrainz__UserToken=${SCROBBLING_LISTENBRAINZ_USER_TOKEN:-}
|
||||
|
||||
# ===== DEBUG SETTINGS =====
|
||||
- Debug__LogAllRequests=${DEBUG_LOG_ALL_REQUESTS:-false}
|
||||
- Debug__RedactSensitiveRequestValues=${DEBUG_REDACT_SENSITIVE_REQUEST_VALUES:-false}
|
||||
|
||||
# ===== SHARED =====
|
||||
- Library__DownloadPath=/app/downloads
|
||||
- SquidWTF__Quality=${SQUIDWTF_QUALITY:-FLAC}
|
||||
- SquidWTF__MinRequestIntervalMs=${SQUIDWTF_MIN_REQUEST_INTERVAL_MS:-200}
|
||||
- Deezer__Arl=${DEEZER_ARL:-}
|
||||
- Deezer__ArlFallback=${DEEZER_ARL_FALLBACK:-}
|
||||
- Deezer__Quality=${DEEZER_QUALITY:-FLAC}
|
||||
- Deezer__MinRequestIntervalMs=${DEEZER_MIN_REQUEST_INTERVAL_MS:-200}
|
||||
- Qobuz__UserAuthToken=${QOBUZ_USER_AUTH_TOKEN:-}
|
||||
- Qobuz__UserId=${QOBUZ_USER_ID:-}
|
||||
- Qobuz__Quality=${QOBUZ_QUALITY:-FLAC}
|
||||
- Qobuz__MinRequestIntervalMs=${QOBUZ_MIN_REQUEST_INTERVAL_MS:-200}
|
||||
- MusicBrainz__Enabled=${MUSICBRAINZ_ENABLED:-true}
|
||||
- MusicBrainz__Username=${MUSICBRAINZ_USERNAME:-}
|
||||
- MusicBrainz__Password=${MUSICBRAINZ_PASSWORD:-}
|
||||
volumes:
|
||||
- ${DOWNLOAD_PATH:-./downloads}:/app/downloads
|
||||
- ${KEPT_PATH:-./kept}:/app/kept
|
||||
- ${CACHE_PATH:-./cache}:/app/cache
|
||||
# Mount .env file for runtime configuration updates from admin UI
|
||||
- ./.env:/app/.env
|
||||
# Docker socket for self-restart capability (admin UI only)
|
||||
- /var/run/docker.sock:/var/run/docker.sock:ro
|
||||
|
||||
networks:
|
||||
allstarr-network:
|
||||
name: allstarr-network
|
||||
driver: bridge
|
||||
+17
-11
@@ -1,17 +1,19 @@
|
||||
services:
|
||||
redis:
|
||||
image: redis:7-alpine
|
||||
container_name: allstarr-redis
|
||||
valkey:
|
||||
image: valkey/valkey:8
|
||||
container_name: allstarr-valkey
|
||||
restart: unless-stopped
|
||||
# Redis is only accessible internally - no external port exposure
|
||||
# Valkey is only accessible internally - no external port exposure
|
||||
expose:
|
||||
- "6379"
|
||||
command: redis-server --maxmemory 1gb --maxmemory-policy allkeys-lru --save 60 1 --appendonly yes
|
||||
command: valkey-server --maxmemory 1gb --maxmemory-policy allkeys-lru --save 60 1 --appendonly yes
|
||||
healthcheck:
|
||||
test: ["CMD", "redis-cli", "ping"]
|
||||
# Use CMD-SHELL for broader compatibility in some environments
|
||||
test: ["CMD-SHELL", "valkey-cli ping || exit 1"]
|
||||
interval: 10s
|
||||
timeout: 3s
|
||||
retries: 3
|
||||
retries: 5
|
||||
start_period: 20s
|
||||
volumes:
|
||||
- ${REDIS_DATA_PATH:-./redis-data}:/data
|
||||
networks:
|
||||
@@ -52,7 +54,7 @@ services:
|
||||
# DO NOT expose through reverse proxy - contains sensitive config
|
||||
- "5275:5275"
|
||||
depends_on:
|
||||
redis:
|
||||
valkey:
|
||||
condition: service_healthy
|
||||
spotify-lyrics:
|
||||
condition: service_started
|
||||
@@ -72,12 +74,12 @@ services:
|
||||
- Admin__BindAnyIp=${ADMIN_BIND_ANY_IP:-false}
|
||||
- Admin__TrustedSubnets=${ADMIN_TRUSTED_SUBNETS:-}
|
||||
|
||||
# ===== REDIS CACHE =====
|
||||
- Redis__ConnectionString=redis:6379
|
||||
# ===== REDIS / VALKEY CACHE =====
|
||||
- Redis__ConnectionString=valkey:6379
|
||||
- Redis__Enabled=${REDIS_ENABLED:-true}
|
||||
|
||||
# ===== CACHE TTL SETTINGS =====
|
||||
- Cache__SearchResultsMinutes=${CACHE_SEARCH_RESULTS_MINUTES:-120}
|
||||
- Cache__SearchResultsMinutes=${CACHE_SEARCH_RESULTS_MINUTES:-1}
|
||||
- Cache__PlaylistImagesHours=${CACHE_PLAYLIST_IMAGES_HOURS:-168}
|
||||
- Cache__SpotifyPlaylistItemsHours=${CACHE_SPOTIFY_PLAYLIST_ITEMS_HOURS:-168}
|
||||
- Cache__SpotifyMatchedTracksDays=${CACHE_SPOTIFY_MATCHED_TRACKS_DAYS:-30}
|
||||
@@ -86,6 +88,7 @@ services:
|
||||
- Cache__MetadataDays=${CACHE_METADATA_DAYS:-7}
|
||||
- Cache__OdesliLookupDays=${CACHE_ODESLI_LOOKUP_DAYS:-60}
|
||||
- Cache__ProxyImagesDays=${CACHE_PROXY_IMAGES_DAYS:-14}
|
||||
- Cache__TranscodeCacheMinutes=${CACHE_TRANSCODE_MINUTES:-60}
|
||||
|
||||
# ===== SUBSONIC BACKEND =====
|
||||
- Subsonic__Url=${SUBSONIC_URL:-http://localhost:4533}
|
||||
@@ -152,12 +155,15 @@ services:
|
||||
# ===== SHARED =====
|
||||
- Library__DownloadPath=/app/downloads
|
||||
- SquidWTF__Quality=${SQUIDWTF_QUALITY:-FLAC}
|
||||
- SquidWTF__MinRequestIntervalMs=${SQUIDWTF_MIN_REQUEST_INTERVAL_MS:-200}
|
||||
- Deezer__Arl=${DEEZER_ARL:-}
|
||||
- Deezer__ArlFallback=${DEEZER_ARL_FALLBACK:-}
|
||||
- Deezer__Quality=${DEEZER_QUALITY:-FLAC}
|
||||
- Deezer__MinRequestIntervalMs=${DEEZER_MIN_REQUEST_INTERVAL_MS:-200}
|
||||
- Qobuz__UserAuthToken=${QOBUZ_USER_AUTH_TOKEN:-}
|
||||
- Qobuz__UserId=${QOBUZ_USER_ID:-}
|
||||
- Qobuz__Quality=${QOBUZ_QUALITY:-FLAC}
|
||||
- Qobuz__MinRequestIntervalMs=${QOBUZ_MIN_REQUEST_INTERVAL_MS:-200}
|
||||
- MusicBrainz__Enabled=${MUSICBRAINZ_ENABLED:-true}
|
||||
- MusicBrainz__Username=${MUSICBRAINZ_USERNAME:-}
|
||||
- MusicBrainz__Password=${MUSICBRAINZ_PASSWORD:-}
|
||||
|
||||
Reference in New Issue
Block a user