joshpatra/videospeed
1
0
Fork 0
mirror of https://github.com/SoPat712/videospeed.git synced 2025-08-21 18:08:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

update audio+video min/max references

Browse Source 
Audio is no longer cutoff [1]. Video limits still in place.

[1] https://developers.google.com/web/updates/2017/12/chrome-63-64-media-updates#remove-muting-extreme-playbackrates

Closes #300.
This commit is contained in:
Ilya Grigorik
2018-02-08 13:35:26 +00:00
parent e50c29c5dd
commit e85dad3280
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
inject.js
View File

@@ -331,14 +331,12 @@ chrome.runtime.sendMessage({}, function(response) {
v.currentTime += tc.settings.advanceTime; v.currentTime += tc.settings.advanceTime;
} else if (action === 'faster') { } else if (action === 'faster') {
// Maximum playback speed in Chrome is set to 16: // Maximum playback speed in Chrome is set to 16:
// https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?l=103 // https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp?l=168
var s = Math.min( (v.playbackRate < 0.1 ? 0.0 : v.playbackRate) + tc.settings.speedStep, 16); var s = Math.min( (v.playbackRate < 0.1 ? 0.0 : v.playbackRate) + tc.settings.speedStep, 16);
v.playbackRate = Number(s.toFixed(2)); v.playbackRate = Number(s.toFixed(2));
} else if (action === 'slower') { } else if (action === 'slower') {
// Audio playback is cut at 0.05:
// https://cs.chromium.org/chromium/src/media/filters/audio_renderer_algorithm.cc?l=49
// Video min rate is 0.0625: // Video min rate is 0.0625:
// https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?l=102 // https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp?l=167
var s = Math.max(v.playbackRate - tc.settings.speedStep, 0.0625); var s = Math.max(v.playbackRate - tc.settings.speedStep, 0.0625);
v.playbackRate = Number(s.toFixed(2)); v.playbackRate = Number(s.toFixed(2));
} else if (action === 'reset') { } else if (action === 'reset') {